Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread David Edmondson
On Tuesday, 2021-06-22 at 15:16:29 -06, Alex Williamson wrote: >> Additionally, an alternative to hardcoded ranges as we do today, >> VFIO could advertise the platform valid IOVA ranges without >> necessarily >> requiring to have a PCI device added in the vfio container.

Re: [PATCH v3 3/5] ui: Create sync objects and fences only for blobs

2021-06-23 Thread Gerd Hoffmann
Hi, > dmabuf->buf.fd = res->dmabuf_fd; > +dmabuf->buf.blob = true; Do you actually need the 'blob' field? I think checking 'fd' instead should work too. take care, Gerd

[PATCH 2/3] [hack] scripts/copy-dlls

2021-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 3 +- scripts/copy-dlls| 56 2 files changed, 58 insertions(+), 1 deletion(-) create mode 100755 scripts/copy-dlls diff --git a/.gitlab-ci.d/crossbuild-template.yml

[PATCH 3/3] ci: build & store guest agent msi

2021-06-23 Thread Gerd Hoffmann
Build guest agent windows msi install package in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 3 ++- .gitlab-ci.d/crossbuilds.yml | 2 ++ tests/docker/dockerfiles/fedora-win32-cross.docker |

Re: [PATCH v4 0/2] Gitlab: Add issue templates

2021-06-23 Thread Alex Bennée
John Snow writes: > Add "Bug" and "Feature Request" templates to the Gitlab interface to > help improve the quality of newly reported issues. > > To see what this looks like, I've temporarily allowed my Gitlab fork to > diverge with these files merged. See my fork's "new issue" page to see >

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:00 +0100 Joao Martins wrote: > It is assumed that the whole GPA space is available to be > DMA addressable, within a given address space limit. Since > v5.4 based that is not true, and VFIO will validate whether > the selected IOVA is indeed valid i.e. not reserved by

Re: [PATCH v3 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:24PM -0700, Vivek Kasireddy wrote: > Instead of immediately drawing and submitting, queue and wait > for the draw signal if the dmabuf submitted is a blob. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy Reviewed-by: Gerd Hoffmann

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Dov Murik
Hi Connor, +cc: Daniel On 23/06/2021 0:15, Connor Kuehl wrote: > On 6/21/21 2:05 PM, Dov Murik wrote: >> +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t >> *guid, >> + const uint8_t *hash, size_t hash_len) >> +{ >> +

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Daniel P . Berrangé
On Wed, Jun 23, 2021 at 11:41:56AM +0300, Dov Murik wrote: > Hi Connor, > > +cc: Daniel > > On 23/06/2021 0:15, Connor Kuehl wrote: > > On 6/21/21 2:05 PM, Dov Murik wrote: > >> +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t > >> *guid, > >> +

[PATCH 0/2] usb-host: windows support

2021-06-23 Thread Gerd Hoffmann
Gerd Hoffmann (2): usb-host: wire up timer for windows ci: add libusb for windows builds hw/usb/host-libusb.c | 33 ++- .../dockerfiles/fedora-win32-cross.docker | 1 + .../dockerfiles/fedora-win64-cross.docker | 1 + 3 files changed, 34

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 10:39 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >> >> The number of blocks is defined in the lower bits [15:0] > > I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. May be that's an eMMC thing. That's what I read from

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Joao Martins
On 6/23/21 8:11 AM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:49:00 +0100 > Joao Martins wrote: > >> It is assumed that the whole GPA space is available to be >> DMA addressable, within a given address space limit. Since >> v5.4 based that is not true, and VFIO will validate whether >> the

Re: [PATCH v2 2/2] x86/sev: generate SEV kernel loader hashes in x86_load_linux

2021-06-23 Thread Dov Murik
Hi Connor, On 22/06/2021 23:55, Connor Kuehl wrote: > On 6/21/21 2:05 PM, Dov Murik wrote: >> If SEV is enabled and a kernel is passed via -kernel, pass the hashes of >> kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV >> measured boot. >> >> Co-developed-by: James Bottomley >>

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-23 Thread Andrew Jones
On Wed, Jun 23, 2021 at 02:43:49PM +1000, Gavin Shan wrote: > Hi Drew, > > On 6/22/21 5:13 PM, Andrew Jones wrote: > > On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > > > On 6/3/21 2:48 PM, Gavin Shan wrote: > > > > On 6/2/21 9:36 PM, Andrew Jones wrote: > > > > > On Wed, Jun 02,

Re: [PATCH v3 5/5] virtio-gpu: Add gl_flushed callback

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:25PM -0700, Vivek Kasireddy wrote: > Adding this callback provides a way to resume the processing of > cmds in fenceq and cmdq that were not processed because the UI > was waiting on a fence and blocked cmd processing. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek

Re: [PATCH RFC 6/6] i386/pc: Add a machine property for AMD-only enforcing of valid IOVAs

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:05 +0100 Joao Martins wrote: > The added enforcing is only relevant in the case of AMD where the range > right before the 1TB is restricted and cannot be DMA mapped by the > kernel consequently leading to IOMMU INVALID_DEVICE_REQUEST or possibly > other kinds of IOMMU

Re: [PATCH 2/6] tests/acceptance: add replay kernel test for ppc64

2021-06-23 Thread Pavel Dovgalyuk
On 22.06.2021 22:23, Willian Rampazzo wrote: On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk wrote: This patch adds record/replay test which boots Linux kernel on ppc64 platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-by: Pavel Dovgalyuk ---

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-23 Thread Andrew Jones
On Wed, Jun 23, 2021 at 10:07:36AM +0200, Andrew Jones wrote: > On Wed, Jun 23, 2021 at 02:43:49PM +1000, Gavin Shan wrote: > > Hi Drew, > > > > On 6/22/21 5:13 PM, Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > > > > On 6/3/21 2:48 PM, Gavin Shan wrote: >

[PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
The number of blocks is defined in the lower bits [15:0] Signed-off-by: Cédric Le Goater --- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a73d80661a10..a2553a502edc 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1358,7 +1358,7 @@

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > > The number of blocks is defined in the lower bits [15:0] I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. > > Signed-off-by: Cédric Le Goater > --- > hw/sd/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-23 Thread Stefan Hajnoczi
On Wed, Jun 23, 2021 at 12:27:55AM +0530, Niteesh G. S. wrote: > Hi Stefan, > On Tue, Jun 22, 2021 at 3:05 PM Stefan Hajnoczi wrote: > > > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > > TLDR: The goal of this mail wasn't to review the dummy command I had > > posted > > >

[PATCH 0/3] [RfC] build windows installers in ci

2021-06-23 Thread Gerd Hoffmann
Side product of making usb-host work on windows. I'll go disappear into my summer vacation soon, so posting my current state as RfC. If someone feels like picking this up feel free to do so. Otherwise I'll go continue this when I'm back, but it most likely wouldn't make it into the 6.1 release

[PATCH 1/3] ci: build & store windows installer

2021-06-23 Thread Gerd Hoffmann
Build windows installer for qemu in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 5 + .gitlab-ci.d/crossbuilds.yml | 6 ++ tests/docker/dockerfiles/fedora-win64-cross.docker | 1 + 3

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:52 PM Philippe Mathieu-Daudé wrote: > > On 6/23/21 10:39 AM, Bin Meng wrote: > > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > >> > >> The number of blocks is defined in the lower bits [15:0] > > > > I checked the physical spec v8.00 and it says bits [31:0]

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

2021-06-23 Thread Daniel P . Berrangé
On Mon, Jun 07, 2021 at 04:29:54PM +0800, Tom Yan wrote: > Hi philmd (and others), > > So I just noticed your commit of requiring the size of an emulated SD > card to be a power of 2, when I was trying to emulate one for an > actual one (well, it's a microSD, but still), as it errored out. > >

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Dov Murik
On 23/06/2021 11:49, Daniel P. Berrangé wrote: > On Wed, Jun 23, 2021 at 11:41:56AM +0300, Dov Murik wrote: ... >> >> Related: I wondered if I could replace HASH_SIZE in: >> >> >> /* hard code sha256 digest size */ >> #define HASH_SIZE 32 >> >> typedef struct QEMU_PACKED

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:00 +0100 Joao Martins wrote: > It is assumed that the whole GPA space is available to be > DMA addressable, within a given address space limit. Since > v5.4 based that is not true, and VFIO will validate whether > the selected IOVA is indeed valid i.e. not reserved by

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread Joao Martins
On 6/22/21 10:16 PM, Alex Williamson wrote: > On Tue, 22 Jun 2021 16:48:59 +0100 > Joao Martins wrote: > >> Hey, >> >> This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO, >> particularly >> when running on AMD systems with an IOMMU. >> >> Since Linux v5.4, VFIO validates

Re: [PATCH v3 02/24] modules: collect module meta-data

2021-06-23 Thread Gerd Hoffmann
On Tue, Jun 22, 2021 at 06:03:45PM +0200, Paolo Bonzini wrote: > On 21/06/21 14:52, Gerd Hoffmann wrote: > > ninja: error: 'libui-curses.a.p/meson-generated_.._config-host.h.o', needed > > by 'ui-curses.modinfo.test', missing and no known rule to make it > > > > Hmm, not sure where this comes

Re: [PATCH v3 2/5] ui/egl: Add egl helpers to help with synchronization

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:22PM -0700, Vivek Kasireddy wrote: > These egl helpers would be used for creating and waiting on > a sync object. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy Reviewed-by: Gerd Hoffmann

[PATCH 1/2] usb-host: wire up timer for windows

2021-06-23 Thread Gerd Hoffmann
On windows we can't wait on file descriptors. Poll libusb using a timer instead. Fixes long-standing FIXME. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/431 Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 33 - 1 file changed, 32

[PATCH 2/2] ci: add libusb for windows builds

2021-06-23 Thread Gerd Hoffmann
Add CI coverage for usb passthrough on windows. Signed-off-by: Gerd Hoffmann --- tests/docker/dockerfiles/fedora-win32-cross.docker | 1 + tests/docker/dockerfiles/fedora-win64-cross.docker | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:55 PM Cédric Le Goater wrote: > > On 6/23/21 10:39 AM, Bin Meng wrote: > > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > >> > >> The number of blocks is defined in the lower bits [15:0] > > > > I checked the physical spec v8.00 and it says bits [31:0] for

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 11:12 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:55 PM Cédric Le Goater wrote: >> >> On 6/23/21 10:39 AM, Bin Meng wrote: >>> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: The number of blocks is defined in the lower bits [15:0] >>> >>> I checked the physical

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Philippe Mathieu-Daudé
On 6/23/21 10:39 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >> >> The number of blocks is defined in the lower bits [15:0] > > I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. Watch out, we only support 1-3: enum

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 10:52 AM, Philippe Mathieu-Daudé wrote: > On 6/23/21 10:39 AM, Bin Meng wrote: >> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >>> >>> The number of blocks is defined in the lower bits [15:0] >> >> I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument.

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Kevin Wolf
Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > To save the user from having to check 'qemu-img info --backing-chain' > > > or other followup command to determine which

Re: [PATCH v3 11/15] target/cris: Add DISAS_DBRANCH

2021-06-23 Thread Edgar E. Iglesias
On Tue, Jun 22, 2021 at 08:48:16AM -0700, Richard Henderson wrote: > Move delayed branch handling to tb_stop, where we can re-use other > end-of-tb code, e.g. the evaluation of flags. Honor single stepping. > Validate that we aren't losing state by overwriting is_jmp. Hi Richard, This patch

[PATCH v4 06/22] tests/docker: fix sorting in package lists

2021-06-23 Thread Daniel P . Berrangé
This will make diffs in later patches clearer. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos8.docker | 2 +- tests/docker/dockerfiles/fedora.docker| 4 ++--

[PATCH v4 03/22] tests/docker: use project specific container registries

2021-06-23 Thread Daniel P . Berrangé
Since Docker Hub has started to enforce pull rate limits on clients, it is preferrable to use project specific container registries where they are available. Fedora and OpenSUSE projects provide registries. The images in these registries are also refreshed on a more regular basis than the ones in

[PATCH v4 08/22] tests/docker: fix mistakes in fedora package list

2021-06-23 Thread Daniel P . Berrangé
libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-06-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210623142245.307776-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210623142245.307776-1-berra...@redhat.com Subject: [PATCH v4 00/22] tests/docker:

[PATCH v2 0/6] block: block-status cache for data regions

2021-06-23 Thread Max Reitz
Hi, See the cover letter from v1 for the general idea: https://lists.nongnu.org/archive/html/qemu-block/2021-06/msg00843.html The biggest change here in v2 is that instead of having a common CoMutex protect the block-status cache, we’re using RCU now. So to read from the cache, or even to

[PATCH v2 3/6] block: Clarify that @bytes is no limit on *pnum

2021-06-23 Thread Max Reitz
.bdrv_co_block_status() implementations are free to return a *pnum that exceeds @bytes, because bdrv_co_block_status() in block/io.c will clamp *pnum as necessary. On the other hand, if drivers' implementations return values for *pnum that are as large as possible, our recently introduced

[PATCH v2 5/6] block/gluster: Do not force-cap *pnum

2021-06-23 Thread Max Reitz
bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[PATCH v2 6/6] block/iscsi: Do not force-cap *pnum

2021-06-23 Thread Max Reitz
bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy ---

Re: [PATCH 10/18] vhost-vdpa: open device fd in net_init_vhost_vdpa()

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:42PM +0800, Jason Wang wrote: This path switches to open device fd in net_init_vhost_vpda(). This is used to prepare for the multiqueue support. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 23 +++ 1 file changed, 15 insertions(+), 8

Re: [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/

2021-06-23 Thread Al Cho
Yes, you are right. I think keep the old pattern is better. From: Cornelia Huck Sent: Tuesday, June 22, 2021 7:39 PM To: Al Cho ; qemu-devel@nongnu.org ; qemu-s3...@nongnu.org Cc: Claudio Fontana ; Al Cho ; Claudio Fontana ; David Hildenbrand Subject: Re: [RFC

[PATCH v4 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO

2021-06-23 Thread Alex Bennée
The previous numbers were a guess at best and rather arbitrary without taking into account anything that might be loaded. Instead of using guesses based on the state of registers implement a new function that: a) scans the MemoryRegions for the largest RAM block b) iterates through all "ROM"

Re: [PATCH v3 11/15] target/cris: Add DISAS_DBRANCH

2021-06-23 Thread Richard Henderson
On 6/23/21 6:43 AM, Edgar E. Iglesias wrote: On Tue, Jun 22, 2021 at 08:48:16AM -0700, Richard Henderson wrote: Move delayed branch handling to tb_stop, where we can re-use other end-of-tb code, e.g. the evaluation of flags. Honor single stepping. Validate that we aren't losing state by

Re: [PATCH v4 4/5] docs/devel: Added cache plugin to the plugins docs

2021-06-23 Thread Mahmoud Mandour
On Wed, Jun 23, 2021 at 2:55 PM Mahmoud Mandour wrote: > Signed-off-by: Mahmoud Mandour > --- > docs/devel/tcg-plugins.rst | 60 ++ > 1 file changed, 60 insertions(+) > > diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst > index

Re: [PATCH v17 0/6] MTE support for KVM guest

2021-06-23 Thread Steven Price
On 22/06/2021 15:21, Marc Zyngier wrote: > On Mon, 21 Jun 2021 12:17:10 +0100, Steven Price wrote: >> This series adds support for using the Arm Memory Tagging Extensions >> (MTE) in a KVM guest. >> >> Changes since v16[1]: >> >> - Dropped the first patch ("Handle race when synchronising tags")

Re: [PATCH v3 11/15] target/cris: Add DISAS_DBRANCH

2021-06-23 Thread Edgar E. Iglesias
On Wed, Jun 23, 2021 at 06:55:49AM -0700, Richard Henderson wrote: > On 6/23/21 6:43 AM, Edgar E. Iglesias wrote: > > On Tue, Jun 22, 2021 at 08:48:16AM -0700, Richard Henderson wrote: > > > Move delayed branch handling to tb_stop, where we can re-use other > > > end-of-tb code, e.g. the

[PATCH v4 15/22] tests/docker: expand opensuse-leap package list

2021-06-23 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/opensuse-leap.docker | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-)

[PATCH v4 18/22] tests/docker: auto-generate fedora with lcitool

2021-06-23 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 1 + tests/docker/dockerfiles/fedora.docker | 254 ++--- 2 files changed, 141 insertions(+), 114

[PATCH v4 21/22] tests/docker: auto-generate opensuse-leap with lcitool

2021-06-23 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py | 1 + tests/docker/dockerfiles/opensuse-leap.docker | 239 ++ 2 files changed, 130

[PATCH v4 20/22] tests/docker: auto-generate ubuntu2004 with lcitool

2021-06-23 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu2004.docker | 253 - 2 files changed, 146 insertions(+),

Re: [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:36PM +0800, Jason Wang wrote: The VhostVDPAState is just allocated by qemu_new_net_client() via g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for sure, let's remove this unnecessary check in vhost_vdpa_add(). Signed-off-by: Jason Wang ---

[PATCH v2 4/6] block/file-posix: Do not force-cap *pnum

2021-06-23 Thread Max Reitz
bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy ---

Re: [PATCH 08/18] vhost-vdpa: fix the wrong assertion in vhost_vdpa_init()

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:40PM +0800, Jason Wang wrote: Vhost_vdpa_add() can fail for various reasons, so the assertion of the succeed is wrong. Instead, we should free the NetClientState and propagate the error to the caller Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 5 - 1 file

Re: Too slow edk2 bios boot?

2021-06-23 Thread Laszlo Ersek
On 06/23/21 07:47, Bin Meng wrote: > Hi Laszlo, > > On Wed, Jun 23, 2021 at 12:13 AM Laszlo Ersek wrote: > >> On 06/18/21 15:06, Bin Meng wrote: >>> On Fri, Jun 18, 2021 at 7:46 PM Gerd Hoffmann wrote: >>> On Fri, Jun 18, 2021 at 06:46:57PM +0800, Bin Meng wrote: > Hi Laszlo, >

[PATCH v4 0/2] semihosting/next (SYS_HEAPINFO)

2021-06-23 Thread Alex Bennée
Hi Peter, This is v4 of the semihosting changes with your proposed algorithm for finding the largest gap in the various loaded ROMS. The included test is fairly simple but I also did a bit of manual testing with guest-loader and loader stanzas and it seemed to do the right thing. I think this is

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Nir Soffer
On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > > To save the user from having to check 'qemu-img info

Re: [PATCH v17 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-23 Thread Steven Price
On 22/06/2021 11:56, Fuad Tabba wrote: > Hi Marc, > > On Tue, Jun 22, 2021 at 11:25 AM Marc Zyngier wrote: >> >> Hi Fuad, >> >> On Tue, 22 Jun 2021 09:56:22 +0100, >> Fuad Tabba wrote: >>> >>> Hi, >>> >>> >>> On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: The VMM may not wish

[PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-06-23 Thread Daniel P . Berrangé
Currently the tests/docker/dockerfiles/*Dockerfile recipes are all hand written by contributors. There is a common design pattern, but the set of packages listed for installation leaves alot to be desired - There is no consistency at all across distros - Many potential build deps are not listed

[PATCH v4 01/22] hw/usb/ccid: remove references to NSS

2021-06-23 Thread Daniel P . Berrangé
The NSS package was previously pre-requisite for building CCID related features, however, this became obsolete when the libcacard library was spun off to a separate project: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author: Marc-André Lureau Date: Sun Aug 30 11:48:40 2015

[PATCH v4 02/22] tests/docker: don't use BUILDKIT in GitLab either

2021-06-23 Thread Daniel P . Berrangé
Using BUILDKIT breaks with certain container registries such as CentOS, with docker build reporting an error such as failed to solve with frontend dockerfile.v0: failed to build LLB: failed to load cache key: unexpected status code https://registry.centos.org/v2/centos/manifests/7: 403

[PATCH v4 07/22] tests/docker: fix mistakes in centos package lists

2021-06-23 Thread Daniel P . Berrangé
mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. spice-glib-devel is not use in QEMU at all, but spice-protocol is. We also need the -devel package for spice-server, not the runtime. There is no need to specifically refer to python36, we can just use python3 as in other

[PATCH v4 04/22] tests/docker: use explicit docker.io registry

2021-06-23 Thread Daniel P . Berrangé
It is good practice to use an explicit registry for referencing the base image. This is because some distros will inject their own registries into the search path. For example registry.fedoraproject.org comes ahead of docker.io. Using an explicit registry avoids wasting time querying multiple

[PATCH v4 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-06-23 Thread Daniel P . Berrangé
librados-dev is not required by QEMU directly, only librbd-dev. glusterfs-common is not directly needed by QEMU. QEMU uses ncursesw only on non-Windows hosts. The clang package is clang 10. flex and bison are not required by QEMU. Standardize on nmap ncat implementation to match

[PATCH v4 14/22] tests/docker: expand ubuntu2004 package list

2021-06-23 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/ubuntu2004.docker | 50 +- 1 file changed, 48 insertions(+), 2 deletions(-)

[PATCH v4 10/22] tests/docker: remove mingw packages from Fedora

2021-06-23 Thread Daniel P . Berrangé
There are dedicated containers providing mingw packages for Fedora. Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 27 -- 1 file changed, 27 deletions(-) diff --git a/tests/docker/dockerfiles/fedora.docker

[PATCH v4 17/22] tests/docker: auto-generate centos8 with lcitool

2021-06-23 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py | 2 +- tests/docker/dockerfiles/centos8.docker | 238 +--- 2 files changed, 132 insertions(+),

[PATCH v4 05/22] tests/docker: remove FEATURES env var from templates

2021-06-23 Thread Daniel P . Berrangé
In preparation for switching to auto-generated dockerfiles, remove the FEATURES env variable. The equivalent functionality can be achieved in most cases by just looking for existance of a binary. The cases which don't correspond to binaries are simply dropped because configure/meson will probe

[PATCH v4 12/22] tests/docker: expand fedora package list

2021-06-23 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-)

[PATCH v4 22/22] tests/docker: remove ubuntu container

2021-06-23 Thread Daniel P . Berrangé
This duplicates the ubuntu2004 container but with an inconsistent set of packages. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/containers.yml| 5 -- tests/docker/dockerfiles/ubuntu.docker | 71 -- 2 files changed,

Re: [PATCH v2] mc146818rtc: Make PF independent of PIE

2021-06-23 Thread Jason Thorpe
> On Jun 21, 2021, at 7:46 AM, Paolo Bonzini wrote: > I agree that there's obviously a bug in QEMU. However, I'm worried of two > things with this patch. > > First, the RTC device model has a complicated mechanism to deliver missed > ticks of the periodic timer. This is used with old

[PATCH v4 16/22] tests/docker: add script for automating container refresh

2021-06-23 Thread Daniel P . Berrangé
This introduces https://gitlab.com/libvirt/libvirt-ci as a git submodule at tests/docker/libvirt-ci This submodule only needs to be checked out when needing to re-generate the files in tests/docker/dockerfiles. When a new build pre-requisite is needed for QEMU, it should be added to the

[PATCH v4 19/22] tests/docker: auto-generate ubuntu1804 with lcitool

2021-06-23 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu1804.docker | 251 - 2 files changed, 145 insertions(+),

RE: [PULL 0/4] Hexagon (target/hexagon) bug fixes

2021-06-23 Thread Taylor Simpson
Adding Peter to the CC list ... > -Original Message- > From: Taylor Simpson > Sent: Friday, June 18, 2021 1:07 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@redhat.com; a...@rev.ng; Brian Cain > Subject: [PULL 0/4] Hexagon (target/hexagon)

Re: [PATCH 03/18] vhost_net: do not assume nvqs is always 2

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:35PM +0800, Jason Wang wrote: This patch switches to initialize dev.nvqs from the VhostNetOptions instead of assuming it was 2. This is useful for implementing control virtqueue support which will be a single vhost_net structure with a single cvq. Signed-off-by:

[PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-23 Thread Ulrich Weigand
The FP-to-integer conversion instructions need to set CC 3 whenever a "special case" occurs; this is the case whenever the instruction also signals the IEEE invalid exception. (See e.g. figure 19-18 in the Principles of Operation.) However, qemu currently will set CC 3 only in the case where the

Re: [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote: Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index f5689a7c32..21f09c546f

Re: [PATCH 07/18] vhost-vdpa: tweak the error label in vhost_vdpa_add()

2021-06-23 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 12:16:39PM +0800, Jason Wang wrote: Introduce new error label to avoid the unnecessary checking of net pointer. Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 13 ++--- 1 file changed, 6

[PATCH v2 2/6] block: block-status cache for data regions

2021-06-23 Thread Max Reitz
As we have attempted before (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, "file-posix: Cache lseek result for data regions"; https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html, "file-posix: Cache next hole"), this patch seeks to reduce the number of

Re: Auditing QEMU to replace NULL with _abort

2021-06-23 Thread Daniel P . Berrangé
On Wed, Jun 23, 2021 at 02:16:55PM +0200, Markus Armbruster wrote: > _abort has been a clear win for us. _fatal too, when used > judiciously. Marc-André tried to get both into GLib, unsuccessfully[2]. ...snip... > [2] https://gitlab.gnome.org/GNOME/glib/-/issues/2288 This doesn't actually

[PATCH V9 4/6] net/colo-compare: Move data structure and define to .h file.

2021-06-23 Thread Zhang Chen
Rename structure with COLO index and move it to .h file, It make other modules can reuse COLO code. Signed-off-by: Zhang Chen --- net/colo-compare.c | 132 - net/colo-compare.h | 86 + 2 files changed, 109 insertions(+),

[PATCH V9 5/6] net/colo-compare: Add passthrough list to CompareState

2021-06-23 Thread Zhang Chen
Add passthrough list for each CompareState. Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 net/colo-compare.h | 12 2 files changed, 40 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index dcd24bb113..64e72c82f1 100644 ---

Re: [PATCH RFC 6/6] i386/pc: Add a machine property for AMD-only enforcing of valid IOVAs

2021-06-23 Thread Joao Martins
On 6/23/21 10:18 AM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:49:05 +0100 > Joao Martins wrote: > >> The added enforcing is only relevant in the case of AMD where the range >> right before the 1TB is restricted and cannot be DMA mapped by the >> kernel consequently leading to IOMMU

Re: [PATCH] Update documentation to refer to new location for issues

2021-06-23 Thread Alex Bennée
Stefan Weil writes: > Signed-off-by: Stefan Weil Queued to testing/next as I'm putting together a PR, thanks. -- Alex Bennée

[PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now

2021-06-23 Thread Alex Bennée
There are fixes currently in flight but as this is getting in the way of a green CI we might as well skip for now. For reference the fix series are: linux-user: Move signal trampolines to new page 20210616011209.1446045-1-richard.hender...@linaro.org and linux-user: Load a vdso for x86_64

[PATCH v1 1/8] tests/acceptance: tweak the tcg/kvm tests for virt

2021-06-23 Thread Alex Bennée
Really it's only TCG that can select which GIC model you want, KVM guests should always be using the "host" version of the GIC for which QEMU already provides a handy shortcut. Make the KVM test use this and split the TCG test into it's two versions. Signed-off-by: Alex Bennée ---

[PATCH v1 0/8] misc fixes pre-PR (docs, plugins, tests)

2021-06-23 Thread Alex Bennée
Hi, This is a pre-PR series which collects up some miscellaneous random bits and pieces. This includes various documentation tweaks, a minor plugin helper API and a temporary suppression of the signals test for s390x/hppa to keep CI green. I should roll the PR on Friday morning so shout now if

Re: [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.h| 4 >

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.h | 1 + > include/hw/acpi/ich9.h |

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Wed, 23 Jun 2021 10:37:38 +0100 Joao Martins wrote: > On 6/23/21 8:11 AM, Igor Mammedov wrote: > > On Tue, 22 Jun 2021 16:49:00 +0100 > > Joao Martins wrote: > > > >> It is assumed that the whole GPA space is available to be > >> DMA addressable, within a given address space limit. Since

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread Igor Mammedov
On Wed, 23 Jun 2021 10:30:29 +0100 Joao Martins wrote: > On 6/22/21 10:16 PM, Alex Williamson wrote: > > On Tue, 22 Jun 2021 16:48:59 +0100 > > Joao Martins wrote: > > > >> Hey, > >> > >> This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO, > >> particularly > >> when

[PULL 07/12] configure, meson: convert libtasn1 detection to meson

2021-06-23 Thread Paolo Bonzini
Make it depend on gnutls too, since it is only used as part of gnutls tests. Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 19 --- meson.build| 9 + tests/unit/meson.build | 2 +-

[PULL 08/12] configure, meson: convert pam detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- authz/meson.build | 2 +- configure | 38 -- meson.build| 30 +- meson_options.txt | 2 ++ tests/unit/meson.build | 2 +- 5

[PULL 10/12] configure, meson: convert libcacard detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 28 hw/usb/meson.build | 2 +- meson.build| 9 + meson_options.txt | 2 ++ 4 files changed, 12 insertions(+), 29 deletions(-) diff --git a/configure

  1   2   3   >