[RFC 1/3] modules: Add CONFIG_TCG_MODULAR in config_host

2021-06-30 Thread Jose R. Ziviani
CONFIG_TCG_MODULAR is a complement to CONFIG_MODULES, in order to know if TCG will be a module, even if --enable-modules option was set. Signed-off-by: Jose R. Ziviani --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index 2d72b8cc06..c37a2358d4

[PULL 07/15] python: rename 'venv-check' target to 'check-pipenv'

2021-06-30 Thread John Snow
Well, Cleber was right, this is a better name. In preparation for adding a different kind of virtual environment check (One that simply uses whichever version of Python you happen to have), rename this test 'check-pipenv' so that it matches the CI job 'check-python-pipenv'. Remove the "If you

[PULL 05/15] python: README.rst touchups

2021-06-30 Thread John Snow
Clarifying a few points; removing the reference to 'setuptools' because it isn't referenced anywhere else in this document and doesn't really provide any useful information to a Python newcomer. Adjusting the language elsewhere to be less ambiguous and have fewer run-on sentences. Signed-off-by:

Re: [PATCH 15/18] vhost-net: control virtqueue support

2021-06-30 Thread Jason Wang
在 2021/7/1 上午1:33, Eugenio Perez Martin 写道: On Mon, Jun 21, 2021 at 6:18 AM Jason Wang wrote: We assume there's no cvq in the past, this is not true when we need control virtqueue support for vhost-user backends. So this patch implements the control virtqueue support for vhost-net. As

[PATCH 12/20] python/aqmp: add QMP Message format

2021-06-30 Thread John Snow
The Message class is here primarily to serve as a solid type to use for mypy static typing for unambiguous annotation and documentation. We can also stuff JSON serialization and deserialization into this class itself so it can be re-used even outside this infrastructure. Signed-off-by: John Snow

[PATCH 09/20] python/aqmp: add AsyncProtocol.accept() method

2021-06-30 Thread John Snow
It's a little messier than connect, because it wasn't designed to accept *precisely one* connection. Such is life. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 85 ++-- 1 file changed, 82 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property

2021-06-30 Thread David Gibson
On Wed, Jun 23, 2021 at 04:47:47PM +0200, Julia Suvorova wrote: > PCIE_SLOT property renamed to "native-hotplug" to be more concise > and consistent with other properties. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum Reviewed-by: David Gibson

Re: [PATCH] target/riscv: pmp: Fix some typos

2021-06-30 Thread Alistair Francis
On Sun, Jun 27, 2021 at 9:57 PM Bin Meng wrote: > > %s/CSP/CSR > %s/thie/the > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > > target/riscv/pmp.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target/riscv/pmp.c

[PATCH 01/20] python/pylint: Add exception for TypeVar names ('T')

2021-06-30 Thread John Snow
'T' is a common TypeVar name, allow its use. See also https://github.com/PyCQA/pylint/issues/3401 -- In the future, we might be able to have a separate list of acceptable names for TypeVars exclusively. Signed-off-by: John Snow --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 11/20] python/aqmp: add AsyncProtocol._readline() method

2021-06-30 Thread John Snow
This is added as a courtesy: many protocols are line-based, including QMP. Putting it in AsyncProtocol lets us keep the QMP class implementation just a pinch more abstract. (And, if we decide to add a QTEST implementation later, it will need this, too. (Yes, I have a QTEST implementation.))

[PATCH v3 0/2] hw/i386/pc: Clarify pc_system_ovmf_table_find usage

2021-06-30 Thread Dov Murik
Add assertion to verify that the flash was parsed (looking for the OVMF table), and add documentation for pc_system_ovmf_table_find. v3: - [style] remove static initalization to 'false' v2: - add assertion (insert patch 1/2) Dov Murik (2): hw/i386/pc: pc_system_ovmf_table_find: Assert that

[RFC 2/3] modules: Implement module_is_loaded function

2021-06-30 Thread Jose R. Ziviani
The function module_load_one() fills a hash table will all modules that were successfuly loaded. However, that table is a static variable of module_load_one(). This patch changes it and creates a function that informs whether a given module was loaded or not. Signed-off-by: Jose R. Ziviani ---

[RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-06-30 Thread Jose R. Ziviani
module_object_class_by_name() calls module_load_qom_one if the object is provided by a dynamically linked library. Such library might not be available at this moment - for instance, it can be a package not yet installed. Thus, instead of assert error messages, this patch outputs more friendly

Re: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:14 PM LIU Zhiwei wrote: > > This patchset implements the packed extension for RISC-V on QEMU. > > You can also find this patch set on my > repo(https://github.com/romanheros/qemu.git branch:packed-upstream-v3). > > Features: > * support specification packed extension >

[PULL 13/15] python: Update help text on 'make clean', 'make distclean'

2021-06-30 Thread John Snow
Update for visual parity with all the remaining targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-14-js...@redhat.com Signed-off-by: John Snow --- python/Makefile | 11 +++ 1 file changed, 7

[PATCH 07/20] python/aqmp: add runstate state machine to AsyncProtocol

2021-06-30 Thread John Snow
This serves a few purposes: 1. Protect interfaces when it's not safe to call them (via @require) 2. Add an interface by which an async client can determine if the state has changed, for the purposes of connection management. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 5 +-

[PATCH 19/20] python/aqmp: add asyncio_run compatibility wrapper

2021-06-30 Thread John Snow
Merely as a convenience for users stuck on Python 3.6. It isn't used by the library itself. Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 20 1 file changed, 20 insertions(+) diff --git a/python/qemu/aqmp/util.py b/python/qemu/aqmp/util.py index

[PATCH 10/20] python/aqmp: add _cb_inbound and _cb_inbound logging hooks

2021-06-30 Thread John Snow
Add hooks designed to log/filter incoming/outgoing messages. The primary intent for these is to be able to support iotests which may want to log messages with specific filters for reproducible output. Another use is for plugging into Urwid frameworks; all messages in/out can be automatically

[PATCH 20/20] python/aqmp: add scary message

2021-06-30 Thread John Snow
Add a warning whenever AQMP is used to steer people gently away from using it for the time-being. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py index

ping Re: [PATCH] scsi: fix bug scsi resp sense is 0 when expand disk

2021-06-30 Thread wangjie (P)
ping. On 2021/6/29 15:12, Jie Wang wrote: > A large number of I/Os are delivered during disk capacity expansion. > Many I/Os are extracted from the Vring ring, and each one registers > reqops_unit_attention when new scsi req. > If the first registered req takes the ua, the ua is cleared > and

Re: [PATCH v3 03/37] target/riscv: 16-bit Addition & Subtraction Instructions

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:08 PM LIU Zhiwei wrote: > > Include 5 groups: Wrap-around (dropping overflow), Signed Halving, > Unsigned Halving, Signed Saturation, and Unsigned Saturation. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h

[PATCH 02/20] python/pylint: disable too-many-function-args

2021-06-30 Thread John Snow
too-many-function-args seems prone to failure when considering things like Method Resolution Order, which mypy gets correct. When dealing with multiple inheritance, pylint doesn't seem to understand which method will actually get called, while mypy does. Remove the less powerful, redundant check.

[PATCH 06/20] python/aqmp: add generic async message-based protocol support

2021-06-30 Thread John Snow
This is the bare minimum that you need to establish a full-duplex async message-based protocol with Python's asyncio. The features to be added in forthcoming commits are: - Runstate tracking - Logging - Support for incoming connections via accept() - _cb_outbound, _cb_inbound message hooks -

[PATCH 05/20] python/aqmp: add asyncio compatibility wrappers

2021-06-30 Thread John Snow
Python 3.6 does not have all of the goodies that Python 3.7 does, and I need to support both. Add some compatibility wrappers needed for this purpose. (Note: Python 3.6 is EOL December 2021.) Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 77 1

[PATCH 17/20] python/aqmp: add execute() interfaces

2021-06-30 Thread John Snow
Add execute() and execute_msg(). _execute() is split into _issue() and _reply() halves so that hypothetical subclasses of QMP that want to support different execution paradigms can do so. I anticipate a synchronous interface may have need of separating the send/reply phases. However, I do not

[PATCH 15/20] python/aqmp: add QMP protocol support

2021-06-30 Thread John Snow
The star of our show! Add most of the QMP protocol, sans support for actually executing commands. No problem, that happens in the next two commits. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 2 + python/qemu/aqmp/qmp_protocol.py | 257 +++ 2

[PATCH 18/20] python/aqmp: add _raw() execution interface

2021-06-30 Thread John Snow
This is added in anticipation of wanting it for a synchronous wrapper for the iotest interface. Normally, execute() and execute_msg() both raise QMP errors in the form of Python exceptions. Many iotests expect the entire reply as-is. To reduce churn there, add a private execution interface that

Re: [PATCH v5 7/7] bios-tables-test: Update golden binaries

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:39PM +0200, Julia Suvorova wrote: > Add ACPI hot-plug registers to DSDT Q35 tables. > Changes in the tables: > > +Scope (_SB.PCI0) > +{ > +OperationRegion (PCST, SystemIO, 0x0CC4, 0x08) > +Field (PCST, DWordAcc, NoLock, WriteAsZeros) > +

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum > --- >

Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

2021-06-30 Thread Al Cho
Hi Cornelia, Sorry for missing the reply. I think it may not be worth it, as you said it seem to be the only call site for kvm_s390_get_hpage_1m(). So I think we could keep it. Thanks, AL From: Cornelia Huck Sent: Wednesday, June 30, 2021 11:21 PM

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Dov Murik
On 30/06/2021 17:35, Philippe Mathieu-Daudé wrote: > On 6/30/21 3:38 PM, Tom Lendacky wrote: >> On 6/30/21 12:46 AM, Dov Murik wrote: >>> Add assertion in pc_system_ovmf_table_find that verifies that the flash >>> was indeed previously parsed (looking for the OVMF table) by >>>

Re: [External] Re: [RFC v1] virtio/vsock: add two more queues for datagram types

2021-06-30 Thread Jiang Wang .
On Thu, Jun 24, 2021 at 7:31 AM Stefano Garzarella wrote: > > On Wed, Jun 23, 2021 at 11:50:33PM -0700, Jiang Wang . wrote: > >Hi Stefano, > > > >I checked virtio_net_set_multiqueue(), which will help with following > >changes in my patch: > > > >#ifdef CONFIG_VHOST_VSOCK_DGRAM >

[RFC 0/3] Improve module accelerator error message

2021-06-30 Thread Jose R. Ziviani
Hello! I'm sending this as RFC because it's based on a patch still on review[1], so I'd like to see if it makes sense. Tt will improve the error message when an accelerator module could not be loaded. Instead of the current assert error, a formated message will be displayed. [1]

[PULL 01/15] python/qom: Do not use 'err' name at module scope

2021-06-30 Thread John Snow
Pylint updated to 2.9.0 upstream, adding new warnings for things that re-use the 'err' variable. Luckily, this only breaks the python-check-tox job, which is allowed to fail as a warning. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo

[PULL 03/15] python: Remove global pylint suppressions

2021-06-30 Thread John Snow
These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables -- there's little chance of meaningfully

[PULL 00/15] Python patches

2021-06-30 Thread John Snow
The following changes since commit d940d468e29bff5eb5669c0dd8f3de0c3de17bfb: Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20210629' into staging (2021-06-30 19:09:45 +0100) are available in the Git repository at: https://gitlab.com/jsnow/qemu.git tags/python-pull-request for

[PULL 11/15] python: add 'make check-dev' invocation

2021-06-30 Thread John Snow
This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLab CI. Summary: Checked via GitLab

[PULL 09/15] python: Fix .PHONY Make specifiers

2021-06-30 Thread John Snow
I missed the 'check-tox' target. Add that, but split the large .PHONY specifier at the top into its component pieces and move them near the targets they describe so that they're much harder to forget to update. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by:

[PATCH 08/20] python/aqmp: add logging to AsyncProtocol

2021-06-30 Thread John Snow
Give the connection and the reader/writer tasks nicknames, and add logging statements throughout. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 64 python/qemu/aqmp/util.py | 32 ++ 2 files changed, 90 insertions(+), 6

[PATCH 00/20] python: introduce Asynchronous QMP package

2021-06-30 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-async-qmp-aqmp CI: https://gitlab.com/jsnow/qemu/-/pipelines/330003554 Docs: https://people.redhat.com/~jsnow/sphinx/html/qemu.aqmp.html Based-on: <20210701020921.1679468-1-js...@redhat.com> [PULL 00/15] Python patches Hi! This

[PATCH 04/20] python/aqmp: add error classes

2021-06-30 Thread John Snow
Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 7 +++ python/qemu/aqmp/error.py| 97 2 files changed, 104 insertions(+) create mode 100644 python/qemu/aqmp/error.py diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py

[PATCH 14/20] python/aqmp: add QMP event support

2021-06-30 Thread John Snow
This class was designed as a "mix-in" primarily so that the feature could be given its own treatment in its own python file. It gets quite a bit too long otherwise. Signed-off-by: John Snow --- Yes, the docstring is long. I recommend looking at the generated Sphinx output for that part

Re: [PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:36PM +0200, Julia Suvorova wrote: > Instead of changing the hot-plug type in _OSC register, do not > set the 'Hot-Plug Capable' flag. This way guest will choose ACPI > hot-plug if it is preferred and leave the option to use SHPC with > pcie-pci-bridge. > > The

[PATCH v3 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Dov Murik
Add assertion in pc_system_ovmf_table_find that verifies that the flash was indeed previously parsed (looking for the OVMF table) by pc_system_parse_ovmf_flash. Now pc_system_ovmf_table_find distinguishes between "no one called pc_system_parse_ovmf_flash" (which will abort due to assertion

[PATCH v3 2/2] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-30 Thread Dov Murik
Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Dov Murik Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc_sysfw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c index e353f2a4e9..6ddce92a86 100644 --- a/hw/i386/pc_sysfw.c +++

[PULL 15/15] python: Fix broken ReST docstrings

2021-06-30 Thread John Snow
This patch *doesn't* update all of the docstring standards across the QEMU package directory to make our docstring usage consistent. It *doesn't* fix the formatting to make it look pretty or reasonable in generated output. It *does* fix a few small instances where Sphinx would emit a build warning

[PULL 02/15] python: expose typing information via PEP 561

2021-06-30 Thread John Snow
https://www.python.org/dev/peps/pep-0561/#specification Create 'py.typed' files in each subpackage that indicate to mypy that this is a typed module, so that users of any of these packages can use mypy to check their code as well. Note: Theoretically it's possible to ditch MANIFEST.in in favor

[PULL 10/15] python: only check qemu/ subdir with flake8

2021-06-30 Thread John Snow
flake8 is a little eager to check everything it can. Limit it to checking inside the qemu namespace directory only. Update setup.cfg now that the exclude patterns are no longer necessary. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Tested-by:

[PATCH 13/20] python/aqmp: add well-known QMP object models

2021-06-30 Thread John Snow
The QMP spec doesn't define very many objects that are iron-clad in their format, but there are a few. This module makes it trivial to validate them without relying on an external third-party library. Signed-off-by: John Snow --- python/qemu/aqmp/models.py | 133

[PATCH 16/20] python/aqmp: Add message routing to QMP protocol

2021-06-30 Thread John Snow
Add the ability to handle and route messages in qmp_protocol.py. The interface for actually sending anything still isn't added until next commit. Signed-off-by: John Snow --- python/qemu/aqmp/qmp_protocol.py | 98 +++- 1 file changed, 96 insertions(+), 2 deletions(-)

Re: [PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:33PM +0200, Julia Suvorova wrote: > PCI Express does not allow hot-plug on pcie.0. Check for Q35 in > acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the > 'acpi-root-pci-hotplug' flag. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-30 Thread Wainer dos Santos Moschetta
Hi, On 6/29/21 5:17 PM, Eric Auger wrote: Hi Cleber, all, On 6/29/21 4:36 PM, Eric Auger wrote: This series adds ARM SMMU and Intel IOMMU functional tests using Fedora cloud-init images. ARM SMMU tests feature guests with and without RIL (range invalidation support) using respectively fedora

Re: [PATCH v3 05/37] target/riscv: SIMD 16-bit Shift Instructions

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:11 PM LIU Zhiwei wrote: > > Instructions include right arithmetic shift, right logic shift, > and left shift. > > The shift can be an immediate or a register scalar. The > right shift has rounding operation. And the left shift > has saturation operation. > >

[PULL 04/15] python: Re-lock pipenv at *oldest* supported versions

2021-06-30 Thread John Snow
tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. The effect of this is that the python-check-pipenv CI job on gitlab will now

[PULL 08/15] python: update help text for check-tox

2021-06-30 Thread John Snow
Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without it. It should stay.) Signed-off-by: John Snow

[PULL 14/15] python: remove auto-generated pyproject.toml file

2021-06-30 Thread John Snow
For reasons that at-present escape me, pipenv insists on creating a stub pyproject.toml file. This file is a nuisance, because its mere presence changes the behavior of various tools. For instance, this stub file will cause "pip install --user -e ." to fail in spectacular fashion with misleading

[PULL 06/15] python: Add no-install usage instructions

2021-06-30 Thread John Snow
It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-7-js...@redhat.com Signed-off-by: John Snow --- python/README.rst | 28

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-30 Thread maobibo
在 2021年06月30日 17:36, Alex Bennée 写道: > > maobibo writes: > >> 在 2021年06月29日 21:42, Peter Maydell 写道: >>> On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: Add files to linux-user/loongarch64 Add file to default-configs Add loongarch to target/meson.build

[PULL 12/15] python: Update help text on 'make check', 'make develop'

2021-06-30 Thread John Snow
Update for visual parity with the other targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-13-js...@redhat.com Signed-off-by: John Snow --- python/Makefile | 10 +++--- 1 file changed, 7

Re: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4

2021-06-30 Thread LIU Zhiwei
On 2021/7/1 上午9:30, Alistair Francis wrote: On Thu, Jun 24, 2021 at 9:14 PM LIU Zhiwei wrote: This patchset implements the packed extension for RISC-V on QEMU. You can also find this patch set on my repo(https://github.com/romanheros/qemu.git branch:packed-upstream-v3). Features: * support

[PATCH 03/20] python/aqmp: add asynchronous QMP (AQMP) subpackage

2021-06-30 Thread John Snow
For now, it's empty! Soon, it won't be. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 27 +++ python/qemu/aqmp/py.typed| 0 python/setup.cfg | 1 + 3 files changed, 28 insertions(+) create mode 100644 python/qemu/aqmp/__init__.py create

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

2021-06-30 Thread Wang, Wei W
On Thursday, July 1, 2021 4:08 AM, Peter Xu wrote: > Taking the mutex every time for each dirty bit to clear is too slow, > especially we'll > take/release even if the dirty bit is cleared. So far it's only used to sync > with > special cases with qemu_guest_free_page_hint() against migration

Re: [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:34PM +0200, Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum I don't

Re: [PATCH 19/53] acpi: add helper routines to initialize ACPI tables

2021-06-30 Thread Igor Mammedov
On Tue, 29 Jun 2021 15:16:42 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jun 25, 2021 at 05:17:44AM -0400, Igor Mammedov wrote: > >acpi_init_table(): > > initializes table header and keeps track of > > table data/offsets > >acpi_table_composed(): > > sets actual table

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread wangyanan (Y)
Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using maxcpus to calculate the missing sockets while using *cpus* to calculate the missing cores and threads? This

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-30 Thread Eric Auger
Hi William, On 6/29/21 10:38 PM, Willian Rampazzo wrote: > On Tue, Jun 29, 2021 at 5:17 PM Eric Auger wrote: >> Hi Cleber, all, >> >> On 6/29/21 4:36 PM, Eric Auger wrote: >>> This series adds ARM SMMU and Intel IOMMU functional >>> tests using Fedora cloud-init images. >>> >>> ARM SMMU tests

Re: [PATCH] qga: fix a memory leak in qmp_guest_exec_status()

2021-06-30 Thread Marc-André Lureau
Hi On Wed, Jun 30, 2021 at 11:42 AM Yi Wang wrote: > From: Wang Yechao > > The $GuestExecInfo.out.data is alloced in guest_exec_output_watch(), > and the buffer size is $GuestExecInfo.out.size. We should free the > $GuestExecInfo.out.data judge by the size, not length. Because the >

[PATCH] softmmu/vl: Remove obsolete comment about the "frame" parameter

2021-06-30 Thread Thomas Huth
The frame parameter has been removed along with the support for SDL 1.2. Fixes: 09bd7ba9f5 ("Remove deprecated -no-frame option") Signed-off-by: Thomas Huth --- softmmu/vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index d99e2cbdbf..cee6339580 100644 ---

Re: [PATCH v2] virtiofsd: Don't allow file creation with FUSE_OPEN

2021-06-30 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > A well behaved FUSE client uses FUSE_CREATE to create files. It isn't > supposed to pass O_CREAT along a FUSE_OPEN request, as documented in > the "fuse_lowlevel.h" header : > > /** > * Open a file > * > * Open flags are available in

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
On Mon, Jun 28, 2021 at 10:49:52AM -0700, Richard Henderson wrote: > On 6/28/21 9:32 AM, Ulrich Weigand wrote: > >>Don't clear out env->fpu_status.float_exception_flags in > >>handle_exceptions. Wait until we're actually done with the data. > > > >I don't really know much about qemu internals,

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Philippe Mathieu-Daudé
On 6/30/21 7:46 AM, Dov Murik wrote: > Add assertion in pc_system_ovmf_table_find that verifies that the flash > was indeed previously parsed (looking for the OVMF table) by > pc_system_parse_ovmf_flash. > > Now pc_system_ovmf_table_find distinguishes between "no one called >

Possible io_uring regression with QEMU on Ubuntu's kernel

2021-06-30 Thread Juhyung Park
Hi everyone. With the latest Ubuntu 20.04's HWE kernel 5.8.0-59, I'm noticing some weirdness when using QEMU/libvirt with the following storage configuration: QEMU version is 5.2+dfsg-9ubuntu3 and libvirt version is 7.0.0-2ubuntu2. The guest VM is unable to handle I/O

[PATCH v2] qga: fix a memory leak in qmp_guest_exec_status()

2021-06-30 Thread Yi Wang
From: Wang Yechao In some case, $GuestExecInfo.out.length maybe zero and the memory is leaked in qmp_guest_exec_status(). Call g_free() on the fileds directly to fix memory leak (NULL is ignored). $GuestExecInfo.err.data has the same problem. Signed-off-by: Yechao Wang Signed-off-by: Yi Wang

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 11:01:06AM +0100, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > > > It's just a cumbersome wrapper around the -display ...,window_close=off > > parameter, so we should rather tell our users to use that instead. > > This is an interesting

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" --

Re: [PULL 3/6] hmp-commands: Add new HMP command for filter passthrough

2021-06-30 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > Add hmp_passthrough_filter_add and hmp_passthrough_filter_del make user > can maintain object network passthrough list in human monitor > > Signed-off-by: Zhang Chen > --- > hmp-commands.hx | 26 +++ > include/monitor/hmp.h | 2 ++

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
On Mon, Jun 28, 2021 at 11:45:27AM -0700, Richard Henderson wrote: > On 6/28/21 9:35 AM, Ulrich Weigand wrote: > >@@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, > >uint32_t m34) > > { > > int old_mode = s390_swap_bfp_rounding_mode(env, round_from_m34(m34)); > >

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-30 Thread Valeriy Vdovin
On Mon, Jun 21, 2021 at 07:09:51PM +0300, Valeriy Vdovin wrote: > On Mon, Jun 21, 2021 at 05:50:55PM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Mon, Jun 21, 2021 at 10:07:44AM +0200, Claudio Fontana wrote: > > >> On 6/18/21 10:40 PM, Eduardo Habkost wrote: > > >> >

[PATCH] qga: fix a memory leak in qmp_guest_exec_status()

2021-06-30 Thread Yi Wang
From: Wang Yechao The $GuestExecInfo.out.data is alloced in guest_exec_output_watch(), and the buffer size is $GuestExecInfo.out.size. We should free the $GuestExecInfo.out.data judge by the size, not length. Because the $GuestExecInfo.out.length maybe zero in some case. $GuestExecInfo.err.data

Re: [Virtio-fs] [PATCH v7 1/7] virtiofsd: Fix fuse setxattr() API change issue

2021-06-30 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Mon, 28 Jun 2021 15:46:40 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > With kernel header updates fuse_setxattr_in struct has grown in size. > > > But this new struct size only takes affect if user has opted

[PATCH] Fix CPUID_Fn8000001E_EBX for AMD

2021-06-30 Thread Jade Cheng
According to AMD64 Arch Programmer's Manual Appendix D, bits 7:0 in Fn8000_001E_EBX should be physical core(s) per logical processor, not per die. Signed-off-by: Jade Cheng --- target/i386/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c

Re: [PATCH 2/2] migration: failover: continue to wait card unplug on error

2021-06-30 Thread Laurent Vivier
On 29/06/2021 19:50, Juan Quintela wrote: > Laurent Vivier wrote: >> If the user cancels the migration in the unplug-wait state, >> QEMU will try to plug back the card and this fails because the card >> is partially unplugged. >> To avoid the problem, continue to wait the card unplug, but to >>

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-06-30 Thread Eric Auger
On 6/30/21 3:38 AM, Kunkun Jiang wrote: > On 2021/6/30 4:14, Eric Auger wrote: >> Hi Kunkun, >> >> On 6/29/21 11:33 AM, Kunkun Jiang wrote: >>> Hi all, >>> >>> Accroding to the patch cddafd8f353d2d251b1a5c6c948a577a85838582, >>> our original intention is to flush the ITS tables into guest RAM

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 11:21:27AM +0200, Thomas Huth wrote: > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. > > Signed-off-by: Thomas Huth > --- > docs/system/deprecated.rst | 6 ++ >

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Peter Maydell
On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" -- personally I would say the long -display option

[PATCH v3] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
The FP-to-integer conversion instructions need to set CC 3 whenever a "special case" occurs; this is the case whenever the instruction also signals the IEEE invalid exception. (See e.g. figure 19-18 in the Principles of Operation.) However, qemu currently will set CC 3 only in the case where the

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Dov Murik
On 30/06/2021 11:23, Philippe Mathieu-Daudé wrote: > On 6/30/21 7:46 AM, Dov Murik wrote: >> Add assertion in pc_system_ovmf_table_find that verifies that the flash >> was indeed previously parsed (looking for the OVMF table) by >> pc_system_parse_ovmf_flash. >> >> Now pc_system_ovmf_table_find

Re: [PATCH 33/53] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header()

2021-06-30 Thread Igor Mammedov
On Tue, 29 Jun 2021 11:19:17 -0400 Stefan Berger wrote: > On 6/25/21 5:17 AM, Igor Mammedov wrote: > > > it replaces error-prone pointer arithmetic for build_header() API, > > with 2 calls to start and finish table creation, > > which hides offsets magic from API user. > > > > While at it

Re: [PATCH 2/2] migration: failover: continue to wait card unplug on error

2021-06-30 Thread Juan Quintela
Laurent Vivier wrote: > On 29/06/2021 19:50, Juan Quintela wrote: >> Laurent Vivier wrote: >>> If the user cancels the migration in the unplug-wait state, >>> QEMU will try to plug back the card and this fails because the card >>> is partially unplugged. >>> To avoid the problem, continue to

[PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. Signed-off-by: Thomas Huth --- docs/system/deprecated.rst | 6 ++ qemu-options.hx| 5 +++-- softmmu/vl.c | 2 ++ 3 files

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread wangyanan (Y)
On 2021/6/30 16:30, Andrew Jones wrote: On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-30 Thread Alex Bennée
maobibo writes: > 在 2021年06月29日 21:42, Peter Maydell 写道: >> On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: >>> >>> Add files to linux-user/loongarch64 >>> Add file to default-configs >>> Add loongarch to target/meson.build >>> >>> Signed-off-by: Song Gao >>> --- >>> MAINTAINERS

Re: [PATCH] tests/vm: update openbsd to release 6.9

2021-06-30 Thread Philippe Mathieu-Daudé
On 5/31/21 4:01 AM, Brad Smith wrote: > tests/vm: update openbsd to release 6.9 > > Signed-off-by: Brad Smith Acked-by: Philippe Mathieu-Daudé > --- > tests/vm/openbsd | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd > index

Re: [PATCH] tests/vm: update NetBSD to 9.2

2021-06-30 Thread Philippe Mathieu-Daudé
Hi Brad, You forgot to Cc the maintainers: $ ./scripts/get_maintainer.pl -f tests/vm/netbsd "Alex Bennée" (maintainer:Build and test au...) "Philippe Mathieu-Daudé" (maintainer:Build and test au...) Thomas Huth (maintainer:Build and test au...) Wainer dos Santos Moschetta (reviewer:Build and

[PATCH v2 33/53] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header()

2021-06-30 Thread Igor Mammedov
it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. While at it switch to build_append_int_noprefix() to build table entries (which also removes some manual offset calculations).

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread Andrew Jones
On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: > Hi Drew, Igor, > > I have a question below, hope for some explanation... :) > > I'm trying to rearrange the smp_parse() helper to make it more scalable. > But I wonder why we are currently using maxcpus to calculate the missing >

Re: [v4] migration: fix the memory overwriting risk in add_to_iovec

2021-06-30 Thread Dr. David Alan Gilbert
* Lin Feng (linfen...@huawei.com) wrote: > From: Feng Lin > > When testing migration, a Segmentation fault qemu core is generated. > 0 error_free (err=0x1) > 1 0x7f8b862df647 in qemu_fclose (f=f@entry=0x55e06c247640) > 2 0x7f8b8516d59a in migrate_fd_cleanup (s=s@entry=0x55e06c0e1ef0)

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
On 30/06/2021 12.16, Thomas Huth wrote: On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an

Re: [PATCH] block/ssh: add support for sha256 host key fingerprints

2021-06-30 Thread Kevin Wolf
Am 22.06.2021 um 13:51 hat Daniel P. Berrangé geschrieben: > Currently the SSH block driver supports MD5 and SHA1 for host key > fingerprints. This is a cryptographically sensitive operation and > so these hash algorithms are inadequate by modern standards. This > adds support for SHA256 which has

[PULL 0/7] crypto patches

2021-06-30 Thread Daniel P . Berrangé
The following changes since commit 13d5f87cc3b94bfccc501142df4a7b12fee3a6e7: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-axp-20210628' into staging (2021-06-29 10:02:42 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/tls-deps-pull-request

  1   2   3   >