[PATCH v7 06/14] target/s390x: rename internal.h to s390x-internal.h

The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: David Hildenbrand Acked-by: Cornelia Huck --- target/s390x/arch_dump.c | 2 +-

[PATCH v7 03/14] hw/s390x: tod: make explicit checks for accelerators when initializing

replace general "else" with specific checks for each possible accelerator. Handle qtest as a NOP, and error out for an unknown accelerator used in combination with tod. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck

[PATCH v7 13/14] target/s390x: move kvm files into kvm/

move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Cornelia Huck --- MAINTAINERS| 3 +-- hw/intc/s390_flic_kvm.c

[PATCH v7 09/14] target/s390x: split cpu-dump from helper.c

Splitting this functionality also allows us to make helper.c sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/cpu-dump.c | 134 ++ target/s390x/cpu.c | 43 +++ target/s390x/helper.c

[PATCH v7 04/14] hw/s390x: only build tod-tcg from the CONFIG_TCG build

this will allow in later patches to remove unneeded stubs in target/s390x. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- hw/s390x/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH] tcg: Move tb_phys_invalidate_count to tb_ctx (#457)

On Tue, Jul 06, 2021 at 08:55:32PM -0700, Richard Henderson wrote: > We can call do_tb_phys_invalidate from an iocontext, which has > no per-thread tcg_ctx. Move this to tb_ctx, which is global. > The actual update still takes place with a lock held, so only > an atomic set is required, not an

[PATCH for 6.1 v2 0/5] custom device configs

Hi, This is the second edition of the custom config patches. The first 3 patches are well reviewed but the last two could do with some attention. I assume this should be merged through Paolo's tree? The final two need review: - configure: allow the selection of alternate config in the build -

[PATCH v2 1/5] meson: Introduce target-specific Kconfig

From: Philippe Mathieu-Daudé Add a target-specific Kconfig. We need the definitions in Kconfig so the minikconf tool can verify they exits. However CONFIG_FOO is only enabled for target foo via the meson.build rules. Two architecture have a particularity, ARM and MIPS. As their translators have

Re: [PATCH] blockdev: fix drive-backup transaction endless drained section

Forgotten thing :( Kevin, could you please queue it in your block branch? For me not to bother Peter with one-patch pull request. 08.06.2021 20:18, Vladimir Sementsov-Ogievskiy wrote: drive_backup_prepare() does bdrv_drained_begin() in hope that bdrv_drained_end() will be called in

Re: pipe2 & configure script

On 07/07/21 06:42, Thomas Huth wrote: What conditions are required for "#define CONFIG_PIPE2" to be set in build/config-host.h? It prevents building for Haiku as pipe2() doesn't exist. I didn't see anything in the configure script regarding pipe2. I also updated my code to the latest in the

Re: [PATCH 12/20] python/aqmp: add QMP Message format

On Thu, Jul 1, 2021 at 9:43 AM John Snow wrote: > The Message class is here primarily to serve as a solid type to use for > mypy static typing for unambiguous annotation and documentation. > > We can also stuff JSON serialization and deserialization into this class > itself so it can be re-used

[PULL 01/13] virtio: disable ioeventfd for record/replay

From: Pavel Dovgalyuk virtio devices support separate iothreads waiting for events from file descriptors. These are asynchronous events that can't be recorded and replayed, therefore this patch disables ioeventfd for all devices when record or replay is enabled. Signed-off-by: Pavel Dovgalyuk

Re: [PATCH v2 5/5] configure: allow the selection of alternate config in the build

On 7/7/21 6:17 AM, Alex Bennée wrote: While the default config works well enough it does end up enabling a lot of stuff. For more minimal builds we can select a different list of devices and let Kconfig work out what we want. For example: ../../configure --without-default-features \

[PATCH v2] tests/acceptance: allow control over tags during check-acceptance

Although it is possible to run a specific test using the avocado command-line, a user may want to use a specific tag while running the ``make check-acceptance`` during the development or debugging. This allows using the AVOCADO_TAGS environment variable where the user takes total control of which

Re: [PATCH] docs: Add '-device intel-iommu' entry

On Wed, Jul 07, 2021 at 11:29:47AM +0200, Eric Auger wrote: > Hi Peter, Hi, Eric, > > On 6/11/21 8:55 PM, Peter Xu wrote: > > The parameters of intel-iommu device are non-trivial to understand. Add an > > entry for it so that people can reference to it when using. > > > > There're actually a

Re: [RFC PATCH] hw/display/virtio-gpu: Fix memory leak (CID 1453811)

Hi On Mon, May 31, 2021 at 2:20 PM Philippe Mathieu-Daudé wrote: > To avoid leaking memory on the error path, reorder the > code as: > - check the parameters first > - check resource already existing > - finally allocate memory > > Reported-by: Coverity (CID 1453811: RESOURCE_LEAK) > Fixes:

Re: [PATCH v7 01/14] target/s390x: meson: add target_user_arch

On 07/07/2021 12.53, Cho, Yu-Chen wrote: the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by:

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On 07.07.2021 13:10, Michael S. Tsirkin wrote: On Fri, Jun 25, 2021 at 11:52:10AM +0300, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to

Re: [PATCH V4 00/25] Live Update

Hi Steve On Tue, Jul 6, 2021 at 8:58 PM Steve Sistare wrote: > Provide the cprsave, cprexec, and cprload commands for live update. These > save and restore VM state, with minimal guest pause time, so that qemu may > be updated to a new version in between. > > cprsave stops the VM and saves

Re: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

Am 07.07.2021 um 10:50 hat Or Ozeri geschrieben: > Would you suggest to do this child traversal on bdrv_query_image_info, and > have > it returned as part of the ImageInfo struct? > In that case, I would add *driver-specific to ImageInfo, in addition to the > existing *format-specific? No,

[PATCH v2 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

Currently when a compare-and-trap instruction is executed, qemu will always raise a SIGILL signal. On real hardware, a SIGFPE is raised. Change the PGM_DATA case in cpu_loop to follow the behavior in linux kernel /arch/s390/kernel/traps.c. * Only raise SIGILL if DXC == 0 * If DXC matches an

[PATCH 2/2] numa: Parse initiator= attribute before cpus= attribute

When parsing cpus= attribute of -numa object couple of checks is performed, such as correct initiator setting (see the if() statement at the end of for() loop in machine_set_cpu_numa_node()). However, with the current code cpus= attribute is parsed before initiator= attribute and thus the check

Re: pipe2 & configure script

On 07/07/21 05:24, Richard Zak wrote: What conditions are required for "#define CONFIG_PIPE2" to be set in build/config-host.h? It prevents building for Haiku as pipe2() doesn't exist. I didn't see anything in the configure script regarding pipe2. I also updated my code to the latest in the

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On Wed, Jul 07, 2021 at 03:19:20PM +0300, Denis Plotnikov wrote: > > On 07.07.2021 13:10, Michael S. Tsirkin wrote: > > On Fri, Jun 25, 2021 at 11:52:10AM +0300, Denis Plotnikov wrote: > > > On vhost-user-blk migration, qemu normally sends a number of commands > > > to enable logging if

[PULL 07/13] migration: failover: reset partially_hotplugged

From: Laurent Vivier When the card is plugged back, reset the partially_hotplugged flag to false Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1787194 Signed-off-by: Laurent Vivier Message-Id: <20210629152937.619193-1-lviv...@redhat.com> Reviewed-by: Juan Quintela Reviewed-by: Michael S.

[PATCH v2] docs: Add '-device intel-iommu' entry

The parameters of intel-iommu device are non-trivial to understand. Add an entry for it so that people can reference to it when using. There're actually a few more options there, but I hide them explicitly because they shouldn't be used by normal QEMU users. Cc: Chao Yang Cc: Lei Yang Cc:

[PATCH v2 2/4] hw/nvme: mark nvme-subsys non-hotpluggable

From: Klaus Jensen We currently lack the infrastructure to handle subsystem hotplugging, so disable it. Reviewed-by: Hannes Reinecke Signed-off-by: Klaus Jensen --- hw/nvme/subsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c index

Re: [PATCH v7 07/14] target/s390x: start moving TCG-only code to tcg/

On 07/07/2021 12.53, Cho, Yu-Chen wrote: move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/tcg/

Re: [PATCH] block/replication.c: Properly attach children

06.07.2021 19:11, Lukas Straub wrote: The replication driver needs access to the children block-nodes of it's child so it can issue bdrv_make_empty to manage the replication. However, it does this by directly copying the BdrvChilds, which is wrong. Fix this by properly attaching the block-nodes

[PATCH v2 3/5] hw/arm: move CONFIG_V7M out of default-devices

We currently select CONFIG_V7M for a bunch of our m-profile devices. The last sticking point is translate.c which cannot be compiled without expecting v7m support. Express this dependency in Kconfig rather than in default devices as a stepping stone to a fully configurable translate.c. While we

[PATCH v2 2/5] hw/arm: add dependency on OR_IRQ for XLNX_VERSAL

We need this functionality due to: /* XRAM IRQs get ORed into a single line. */ object_initialize_child(OBJECT(s), "xram-irq-orgate", >lpd.xram.irq_orgate, TYPE_OR_IRQ); Fixes: a55b441b2ca ("hw/arm: versal: Add support for the XRAMs") Signed-off-by: Alex

Re: [PATCH v8 0/9] i386: KVM: expand Hyper-V features early

On Tue, Jun 08, 2021 at 02:08:08PM +0200, Vitaly Kuznetsov wrote: > Changes since v7: > - Make eVMCS version check future proof [Eduardo] > - Collect R-b tags [Eduardo] > - Drop 'if (!strcmp(arch, "i386") || !strcmp(arch, "x86_64"))' check from > qtest > [Eduardo] > - s/priviliges/privileges/

[PATCH 0/3] linux-aio: limit the batch size to reduce queue latency

This series add a new `aio-max-batch` parameter to IOThread, and use it in the Linux AIO backend to limit the batch size (number of request submitted to the kernel through io_submit(2)). Commit 2558cb8dd4 ("linux-aio: increasing MAX_EVENTS to a larger hardcoded value") changed MAX_EVENTS from 128

[PATCH 1/3] iothread: generalize iothread_set_param/iothread_get_param

Changes in preparation for next patches where we add a new parameter not related to the poll mechanism. Let's add two new generic functions (iothread_set_param and iothread_get_param) that we use to set and get IOThread parameters. Signed-off-by: Stefano Garzarella --- iothread.c | 27

[PATCH v2 0/4] hw/nvme: fix controller hotplugging

From: Klaus Jensen Back in May, Hannes posted a fix[1] to re-enable NVMe PCI hotplug. We discussed a bit back and fourth and I mentioned that the core issue was an artifact of the parent/child relationship stemming from the qdev setup we have with namespaces attaching to controller through a

[PATCH v2 1/4] hw/nvme: remove NvmeCtrl parameter from ns setup/check functions

From: Klaus Jensen The nvme_ns_setup and nvme_ns_check_constraints should not depend on the controller state. Refactor and remove it. Reviewed-by: Hannes Reinecke Signed-off-by: Klaus Jensen --- hw/nvme/nvme.h | 2 +- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 37

[PATCH v2 4/4] hw/nvme: fix controller hot unplugging

From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subsystems are involved, this is not what we want since the namespaces may be attached

[PATCH v2 3/4] hw/nvme: unregister controller with subsystem at exit

From: Klaus Jensen Make sure the controller is unregistered from the subsystem when device is removed. Reviewed-by: Hannes Reinecke Signed-off-by: Klaus Jensen --- hw/nvme/nvme.h | 1 + hw/nvme/ctrl.c | 4 hw/nvme/subsys.c | 5 + 3 files changed, 10 insertions(+) diff --git

Re: [PATCH v2 0/6] export/fuse: Allow other users access to the export

Am 25.06.2021 um 16:23 hat Max Reitz geschrieben: > Max Reitz (6): > export/fuse: Pass default_permissions for mount > export/fuse: Add allow-other option > export/fuse: Give SET_ATTR_SIZE its own branch > export/fuse: Let permissions be adjustable > iotests/308: Test +w on read-only

Re: [PATCH] tcg: Move tb_phys_invalidate_count to tb_ctx (#457)

On Tue, Jul 06, 2021 at 08:55:32PM -0700, Richard Henderson wrote: > We can call do_tb_phys_invalidate from an iocontext, which has > no per-thread tcg_ctx. Move this to tb_ctx, which is global. > The actual update still takes place with a lock held, so only > an atomic set is required, not an

Re: [PATCH v7 00/14] s390x cleanup

On Wed, Jul 07 2021, "Cho, Yu-Chen" wrote: > this is the next version of a cleanup series for s390x. This seems to be in good shape now, I guess we can do any remaining cleanups on top. I'll give it a whirl and queue it if nothing shows up.

[PATCH] vl: fix leak of qdict_crumple return value

Coverity reports that qemu_parse_config_group is returning without unrefing the "crumpled" dictionary in case its top level item is a list. But actually the contract with qemu_record_config_group is the same as for qemu_parse_config_group itself: if those function need to stash the dictionary

[Bug 1757363] Re: infinite loop due to improper deal with "eret" on mips32

This seems to affect me too; I have a loop on interrupt handler after the first interrupt called. The version of qemu is latest 3.1 from upstream, so this is not Ubuntu issue. However, have you done with it? Just commenting out env->CP0_Status &= ~(1 << CP0St_EXL); does not help. -- You

Re: [PATCH v1 17/39] tests/docker: fix mistakes in ubuntu package lists

On Wed, Jul 07, 2021 at 04:41:42PM +0200, Philippe Mathieu-Daudé wrote: > On 7/6/21 4:57 PM, Alex Bennée wrote: > > From: Daniel P. Berrangé > > > > librados-dev is not required by QEMU directly, only librbd-dev. > > > > glusterfs-common is not directly needed by QEMU. > > > > QEMU uses

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On 07.07.2021 17:39, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at 03:19:20PM +0300, Denis Plotnikov wrote: On 07.07.2021 13:10, Michael S. Tsirkin wrote: On Fri, Jun 25, 2021 at 11:52:10AM +0300, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of

[PULL 08/16] virtio-blk: Fix rollback path in virtio_blk_data_plane_start()

From: Greg Kurz When dataplane multiqueue support was added in QEMU 2.7, the path that would rollback guest notifiers assignment in case of error simply got dropped. Later on, when Error was added to blk_set_aio_context() in QEMU 4.1, another error path was introduced, but it ommits to rollback

[PULL 08/13] tests: acpi: prepare for changing DSDT tables

From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20210624204229.998824-2-imamm...@redhat.com> Reviewed-by: Stefan Hajnoczi Tested-by: John Sucaet Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 10 ++

Re: [PATCH] docs: Add '-device intel-iommu' entry

On Wed, Jul 07, 2021 at 11:35:43AM +0800, Jason Wang wrote: > > 在 2021/6/12 上午2:55, Peter Xu 写道: > > The parameters of intel-iommu device are non-trivial to understand. Add an > > entry for it so that people can reference to it when using. > > > > There're actually a few more options there, but

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On Wed, Jul 07, 2021 at 12:43:56PM +0200, Hannes Reinecke wrote: > On 7/7/21 11:53 AM, Klaus Jensen wrote: > > On Jul  7 09:49, Hannes Reinecke wrote: > > > On 7/6/21 11:33 AM, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > > > > > Prior to this patch the nvme-ns devices are always

Re: [PATCH] block/replication.c: Properly attach children

07.07.2021 17:53, Lukas Straub wrote: Hi, Thanks for your review. More below. Btw: There is a overview of the replication design in docs/block-replication.txt On Wed, 7 Jul 2021 16:01:31 +0300 Vladimir Sementsov-Ogievskiy wrote: 06.07.2021 19:11, Lukas Straub wrote: The replication driver

[PATCH v7 10/14] target/s390x: make helper.c sysemu-only

Now that we have moved cpu-dump functionality out of helper.c, we can make the module sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- target/s390x/helper.c| 9 + target/s390x/meson.build | 2 +- 2 files

[PATCH v7 11/14] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

this will allow to remove the kvm stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Thomas Huth --- target/s390x/diag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index c17a2498a7..8405f69df0

[PATCH 0/2] numa: Parse initiator= attribute before cpus= attribute

See 2/2 for explanation. The first patch is just cosmetics. Michal Privoznik (2): numa: Report expected initiator numa: Parse initiator= attribute before cpus= attribute hw/core/machine.c | 3 ++- hw/core/numa.c| 45 +++-- 2 files changed, 25

[PATCH 1/2] numa: Report expected initiator

When setting up NUMA with HMAT enabled there's a check performed in machine_set_cpu_numa_node() that reports an error when a NUMA node has a CPU but the node's initiator is not itself. The error message reported contains only the expected value and not the actual value (which is different because

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

On Wed, Jul 07, 2021 at 02:47:15PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Currently the crypto layer exposes support for a 'des-rfb' > > algorithm which is just normal single-DES, with the bits > > in each key byte reversed. This special key munging is > > required by

Re: [PATCH] block/replication.c: Properly attach children

Hi, Thanks for your review. More below. Btw: There is a overview of the replication design in docs/block-replication.txt On Wed, 7 Jul 2021 16:01:31 +0300 Vladimir Sementsov-Ogievskiy wrote: > 06.07.2021 19:11, Lukas Straub wrote: > > The replication driver needs access to the children

Re: [PATCH v2 4/5] configs: rename default-configs to configs and reorganise

On 7/7/21 6:17 AM, Alex Bennée wrote: In preparation for offering variation to our build configurations lets move everything and rename it to default. Common included base configs are also renamed. During the cleanup the stale usb.mak and pci.mak references were removed from MAINTAINERS.

[PATCH] osdep: fix HAVE_BROKEN_SIZE_MAX case

While config-host.mak entries are expanded to "1" for compatibility with create-config.sh, tests done directly in meson.build expand to the empty string and cannot be placed to the right of the && operator. Adjust osdep.h after commit e46bd55d9c ("configure: convert HAVE_BROKEN_SIZE_MAX to

Re: Plugin virtual-to-physical translation incorrect for some IO accesses

On Jul 07 09:53, Philippe Mathieu-Daudé wrote: > On 7/6/21 11:56 PM, Aaron Lindsay wrote: > > On Jul 06 23:10, Philippe Mathieu-Daudé wrote: > >> +Peter/Paolo > >> > >> On 7/6/21 10:47 PM, Aaron Lindsay wrote: > >>> Hello, > >>> > >>> I previously supplied a patch which modified the plugin

Re: [PATCH v7 13/14] target/s390x: move kvm files into kvm/

On 07/07/2021 12.53, Cho, Yu-Chen wrote: move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Cornelia Huck --- MAINTAINERS

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

On Wednesday, July 7, 2021 1:40 AM, Peter Xu wrote: > On Tue, Jul 06, 2021 at 12:05:49PM +0200, David Hildenbrand wrote: > > On 06.07.21 11:41, Wang, Wei W wrote: > > > On Monday, July 5, 2021 9:42 PM, David Hildenbrand wrote: > > > > On 03.07.21 04:53, Wang, Wei W wrote: > > > > > On Friday, July

[PATCH] hw: timer: Add i.MX sysctr timer implementation

From: Viorica Mancas The System Counter (SYS_CTR) is a programmable system counter, which provides a shared time base to multiple processors. It is intended for applications where the counter is always powered on, and supports multiple unrelated clocks. This system counter can be found on NXP

Re: [PATCH v4] memory: Directly dispatch alias accesses on origin memory region

Peter Xu already reviewed, but Cc'ing Peter Maydell too due to his last comment on v3: https://www.mail-archive.com/qemu-devel@nongnu.org/msg800482.html On 4/18/21 7:57 AM, Philippe Mathieu-Daudé wrote: > Since commit 2cdfcf272d ("memory: assign MemoryRegionOps to all > regions"), all newly

[PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Working on getting migration for virtio-mem completely right [1] I realized that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with postcopy might be shaky. Actually testing it, I directly found two issues, one of both being far from trivial to fix. Let's disallow postcopy with

[PULL 04/13] virtio-pci: Added check for virtio device presence in mm callbacks.

From: Andrew Melnychenko During unplug the virtio device is unplugged from virtio-bus on pci. In some cases, requests to virtio-pci mm may acquire during/after unplug. Added check that virtio device is on the bus, for "common" memory region. Signed-off-by: Andrew Melnychenko Message-Id:

[PULL 09/13] acpi: pc: revert back to v5.2 PCI slot enumeration

From: Igor Mammedov Commit [1] moved _SUN variable from only hot-pluggable to all devices. This made linux kernel enumerate extra slots that weren't present before. If extra slot happens to be be enumerated first and there is a device in th same slot but on other bridge, linux kernel will add -N

[PULL 05/13] virtio-pci: Added check for virtio device in PCI config cbs.

From: Andrew Melnychenko Now, if virtio device is not present on virtio-bus - pci config callbacks will not lead to possible crush. The read will return "-1" which should be interpreted by a driver that pci device may be unplugged. Signed-off-by: Andrew Melnychenko Message-Id:

[PULL 12/13] docs: add slot when adding new PCIe root port

From: Vincent Bernat Without providing a specific slot, QEMU won't be able to create the second additional PCIe root port with the following error: $ qemu-system-x86_64 [...] -machine q35 \ >-device pcie-root-port,bus=pcie.0,id=rp1 \ >-device pcie-root-port,bus=pcie.0,id=rp2

[PULL 10/13] tests: acpi: pc: update expected DSDT blobs

From: Igor Mammedov @@ -930,20 +930,20 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) Device (S00) { Name (_ADR, Zero) // _ADR: Address -Name (_SUN, Zero) // _SUN: Slot User Number +Name (ASUN,

[PULL 06/13] virtio-pci: Changed return values for "notify", "device" and "isr" read.

From: Andrew Melnychenko At some point, after unplugging virtio-pci the virtio device may be unrealised, but the memory regions may be present in flatview. So, it's a possible situation when memory region's callbacks are called for "unplugged" device. Previous two patches made sure this case

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On Jul 7 12:43, Hannes Reinecke wrote: On 7/7/21 11:53 AM, Klaus Jensen wrote: On Jul  7 09:49, Hannes Reinecke wrote: On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes

[PATCH v7 14/14] target/s390x: split sysemu part of cpu models

split sysemu part of cpu models, also create a tiny _user.c with just the (at least for now), empty implementation of apply_cpu_model. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + target/s390x/cpu_models.c

Re: [PATCH] ui/gtk: Fix relative mouse with multiple monitors

Ping https://lore.kernel.org/qemu-devel/20210629132410.286813-1-denniswoelf...@gmx.de On 29.06.21 15:24, Dennis Wölfing wrote: To handle relative mouse input the event handler needs to move the mouse away from the screen edges. Failing to do so results in the mouse getting stuck at invisible

Re: [PATCH] osdep: fix HAVE_BROKEN_SIZE_MAX case

On Wed, Jul 07, 2021 at 12:56:00PM +0200, Paolo Bonzini wrote: > While config-host.mak entries are expanded to "1" for compatibility with > create-config.sh, tests done directly in meson.build expand to the empty > string and cannot be placed to the right of the && operator. Adjust > osdep.h

Re: [PATCH] trace: add hardware interrupt calls tracing

Ping? https://patchwork.kernel.org/project/qemu-devel/patch/20210625073844.1229-3-mark.cave-ayl...@ilande.co.uk/ вт, 29 июн. 2021 г. в 16:38, Arkadiy : > From: NDNF > > Adds hardware interrupt call tracing. This is necessary to debugging Qemu > and > virtual devices. It was decided to use

Re: [PATCH v7 06/14] target/s390x: rename internal.h to s390x-internal.h

On 07/07/2021 12.53, Cho, Yu-Chen wrote: The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: David Hildenbrand Acked-by: Cornelia Huck ---

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

Daniel P. Berrangé writes: > Currently the crypto layer exposes support for a 'des-rfb' > algorithm which is just normal single-DES, with the bits > in each key byte reversed. This special key munging is > required by the RFB protocol password authentication > mechanism. > > Since the crypto

[PATCH v2 5/5] configure: allow the selection of alternate config in the build

While the default config works well enough it does end up enabling a lot of stuff. For more minimal builds we can select a different list of devices and let Kconfig work out what we want. For example: ../../configure --without-default-features \ --target-list=arm-softmmu,aarch64-softmmu \

[PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Postcopy never worked properly with 'free-page-hint=on', as there are at least two issues: 1) With postcopy, the guest will never receive a VIRTIO_BALLOON_CMD_ID_DONE and consequently won't release free pages back to the OS once migration finishes. The issue is that for postcopy, we

[PATCH v1 1/2] migration/postcopy-ram: define type for "struct PostcopyNotifyData"

Let's define a proper type, just as we do for PrecopyNotifyData already. Cc: Wei Wang Cc: Michael S. Tsirkin Cc: Philippe Mathieu-Daudé Cc: Alexander Duyck Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Cc: Peter Xu Signed-off-by: David Hildenbrand --- hw/virtio/vhost-user.c | 2 +-

[PATCH 2/3] iothread: add aio-max-batch parameter

The `aio-max-batch` parameter will be propagated to AIO engines and it will be used to control the maximum number of queued requests. When there are in queue a number of requests equal to `aio-max-batch`, the engine invokes the system call to forward the requests to the kernel. This parameter

Re: [PATCH v3 2/2] qemu-img: Make unallocated part of backing chain obvious in map

On Sat, Jul 03, 2021 at 10:25:28AM +0300, Vladimir Sementsov-Ogievskiy wrote: ... > > An obvious solution is to make 'qemu-img map --output=json' add an > > additional "present":false designation to any cluster lacking an > > allocation anywhere in the chain, without any change to the "depth" > >

[PATCH] qemu-config: never call the callback after an error, fix leak

Ensure that the callback to qemu_config_foreach is never called upon an error, by moving the invocation before the "out" label and ensuring all error cases jump to the label. The qobject_unref however needs to be done in all cases (which Coverity is already complaining about). The leak is

Re: [PATCH V4 00/25] Live Update

On 7/7/2021 8:31 AM, Marc-André Lureau wrote: > Hi Steve > > On Tue, Jul 6, 2021 at 8:58 PM Steve Sistare > wrote: > >[...] > It doesn't apply on master, could you rebase and resend? > thanks > -- > Marc-André Lureau Will do, sorry about that - steve

[PATCH v2 2/2] tests/tcg: Test that compare-and-trap raises SIGFPE

Signed-off-by: Jonathan Albrecht --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/trap.c | 102 2 files changed, 103 insertions(+) create mode 100644 tests/tcg/s390x/trap.c diff --git a/tests/tcg/s390x/Makefile.target

[PATCH v2 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

qemu-s390x signals with SIGILL on compare-and-trap instructions. This breaks OpenJDK which expects SIGFPE in its implementation of implicit exceptions. This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE psw.addr reporting

Re: [PATCH v7 0/9] i386: KVM: expand Hyper-V features early

On Thu, Jun 03, 2021 at 01:48:26PM +0200, Vitaly Kuznetsov wrote: > Changes since v6 [Eduardo]: > - First 14 patches of v6 made it upstream! > - New patches addressing feedback on the already merged patches added: > i386: make hyperv_expand_features() return bool > i386: hardcode supported

Re: [PATCH v1 17/39] tests/docker: fix mistakes in ubuntu package lists

On 7/6/21 4:57 PM, Alex Bennée wrote: > From: Daniel P. Berrangé > > librados-dev is not required by QEMU directly, only librbd-dev. > > glusterfs-common is not directly needed by QEMU. > > QEMU uses ncursesw only on non-Windows hosts. > > The clang package is clang 10. > > flex and bison

Re: [PATCH] vhost-user: Fix backends without multiqueue support

On Mon, Jul 05 2021, Kevin Wolf wrote: > dev->max_queues was never initialised for backends that don't support > VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of > queues to check against and consequently fail for any such backend. > > Set it to 1 if the backend doesn't have

[PULL 02/13] virtio: Clarify MR transaction optimization

From: Greg Kurz The device model batching its ioeventfds in a single MR transaction is an optimization. Clarify this in virtio-scsi, virtio-blk and generic virtio code. Also clarify that the transaction must commit before closing ioeventfds so that no one is tempted to merge the loops in the

[PULL 11/13] acpi/ged: fix reset cause

From: Gerd Hoffmann Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not SHUTDOWN_CAUSE_GUEST_SHUTDOWN. Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann Message-Id: <20210624110057.2398779-1-kra...@redhat.com> Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé

[PULL 13/13] MAINTAINERS: Add maintainer for vhost-user RNG implementation

From: Mathieu Poirier This patch adds entry for the vhost-user-rng related files. Signed-off-by: Mathieu Poirier Message-Id: <20210614202842.581640-6-mathieu.poir...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 9 + 1 file changed,

Re: [PATCH v2 4/4] hw/nvme: fix controller hot unplugging

On 7/7/21 5:49 PM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subsystems are involved, this is not what we

Re: [PATCH v7 09/14] target/s390x: split cpu-dump from helper.c

On 07/07/2021 12.53, Cho, Yu-Chen wrote: Splitting this functionality also allows us to make helper.c sysemu-only. Maybe add a sentence that you move some other functions to cpu.c now. Anyway: Reviewed-by: Thomas Huth

[PATCH v2 4/5] configs: rename default-configs to configs and reorganise

In preparation for offering variation to our build configurations lets move everything and rename it to default. Common included base configs are also renamed. During the cleanup the stale usb.mak and pci.mak references were removed from MAINTAINERS. Signed-off-by: Alex Bennée Cc: Paolo Bonzini

Re: Plugin virtual-to-physical translation incorrect for some IO accesses

On Jul 07 07:35, Aaron Lindsay wrote: > On Jul 07 09:53, Philippe Mathieu-Daudé wrote: > > On 7/6/21 11:56 PM, Aaron Lindsay wrote: > > > On Jul 06 23:10, Philippe Mathieu-Daudé wrote: > > >> +Peter/Paolo > > >> > > >> On 7/6/21 10:47 PM, Aaron Lindsay wrote: > > >>> Hello, > > >>> > > >>> I

[PATCH 3/3] linux-aio: limit the batch size using `aio-max-batch` parameter

When there are multiple queues attached to the same AIO context, some requests may experience high latency, since in the worst case the AIO engine queue is only flushed when it is full (MAX_EVENTS) or there are no more queues plugged. Commit 2558cb8dd4 ("linux-aio: increasing MAX_EVENTS to a

[PULL 03/13] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

From: Philippe Mathieu-Daudé libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -d guest_errors -trace pci\* outl 0xcf8 0xf260 outl 0xcfc 0x8400056e EOF pci_cfg_write mch 00:0

[PULL 00/13] pc,pci,virtio: bugfixes, improvements

The following changes since commit 9c2647f75004c4f7d64c9c0ec55f8c6f0739a8b1: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-07-02 11:46:32 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

Re: [PATCH v7 00/14] s390x cleanup

On Wed, Jul 07 2021, "Cho, Yu-Chen" wrote: > this is the next version of a cleanup series for s390x. > > v6 -> v7: > > * "hw/s390x: rename tod-qemu.c to tod-tcg.c" #2 > - change the comment at the top of the file: > "TCG implementation" instead of "QEMU implementation" > (Thomas) > > *

  1   2   3   4   >