On 08/07/21 11:24, Markus Armbruster wrote:
Looks like the patch fixes two separate issues:
1. Memory leak on ferror()
Fixes: f7544edcd32e602af1aae86714dc7c32350d5d7c
2. Callback can run on error.
Fixes: 37701411397c7b7d709ae92abd347cc593940ee5
I*think* this happens when the cb()
On 08/07/21 12:36, Stefan Hajnoczi wrote:
What is very clear from this patch is that it
is strictly related to the brdv_* and lower level calls, because
they also internally check or even use the aiocontext lock.
Therefore, in order to make it work, I temporarly added some
John Snow writes:
> I'm writing a "fake" QMP server for the purposes of creating unit tests for
> the python QMP library. In doing so, I am left with some esoteric questions:
>
>
> (1) qemu-spec.txt, section 2.4.2, "error":
>
> The format of an "error response" is:
>
>> { "error": { "class":
On 08/07/2021 20:39, BALATON Zoltan wrote:
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
On 08/07/2021 20:18, BALATON Zoltan wrote:
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with
On Wed, Jul 07, 2021 at 06:58:11PM +0200, Emanuele Giuseppe Esposito wrote:
> -/** AioContext to run the job coroutine in */
> +/**
> + * AioContext to run the job coroutine in.
> + * Atomic.
> + */
> AioContext *aio_context;
This isn't accessed using atomic operations,
On 7/7/21 1:48 AM, Richard Henderson wrote:
> Supercedes: <20210619034329.532318-1-richard.hender...@linaro.org>
> ("[PATCH 00/12] linux-user: Load a vdso for x86_64 and hppa")
>
> Supercedes: <20210618192951.125651-1-richard.hender...@linaro.org>
> ("[PATCH v2 00/23] linux-user: Move signal
On Wed, Jul 07, 2021 at 06:58:10PM +0200, Emanuele Giuseppe Esposito wrote:
> @@ -406,15 +410,18 @@ void *job_create(const char *job_id, const JobDriver
> *driver, JobTxn *txn,
> error_setg(errp, "Invalid job ID '%s'", job_id);
> return NULL;
> }
> -if
On Wed, Jul 07, 2021 at 06:58:09PM +0200, Emanuele Giuseppe Esposito wrote:
> diff --git a/job.c b/job.c
> index 872bbebb01..96fb8e9730 100644
> --- a/job.c
> +++ b/job.c
> @@ -32,6 +32,10 @@
> #include "trace/trace-root.h"
> #include "qapi/qapi-events-job.h"
>
> +/* job_mutex protexts the
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven wrote:
>
> adding myself as a designated reviewer.
>
> Signed-off-by: Peter Lieven
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 516db737d1..cfda57e825 100644
> --- a/MAINTAINERS
> +++
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven wrote:
>
> task->complete is a bool not an integer.
>
> Signed-off-by: Peter Lieven
> ---
> block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 01a7b94d62..dcf82b15b8 100644
> ---
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
On 08/07/2021 20:18, BALATON Zoltan wrote:
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with Pegasos2):
(VOF) setprop will start failing if the
On Wed, Jul 07, 2021 at 06:58:07PM +0200, Emanuele Giuseppe Esposito wrote:
> This is a continuation on the work to reduce (and possibly get rid of) the
> usage of AioContext lock, by introducing smaller granularity locks to keep
> the thread safety.
>
> This series aims to:
> 1) remove the
On 08/07/2021 20:18, BALATON Zoltan wrote:
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with Pegasos2):
(VOF) setprop will start failing if the machine class callback
did not handle it;
I'll
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote:
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with Pegasos2):
(VOF) setprop will start failing if the machine class callback
did not handle it;
I'll try this later but I think I've seen guests
From: Philippe Mathieu-Daudé
Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210704183755.655002-4-f4...@amsat.org>
Signed-off-by: Laurent Vivier
---
linux-user/mips/target_syscall.h
From: Philippe Mathieu-Daudé
We are going to move this code, fix its style first.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210704183755.655002-7-f4...@amsat.org>
Signed-off-by: Laurent Vivier
---
linux-user/alpha/target_syscall.h | 196
From: Philippe Mathieu-Daudé
Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210704183755.655002-3-f4...@amsat.org>
Signed-off-by: Laurent Vivier
---
linux-user/hppa/target_syscall.h |
From: Philippe Mathieu-Daudé
Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210704183755.655002-2-f4...@amsat.org>
Signed-off-by: Laurent Vivier
---
linux-user/alpha/target_syscall.h
From: Kito Cheng
Set I, M, A, F, D and C bit for hwcap if misa is set.
Signed-off-by: Kito Cheng
Reviewed-by: Richard Henderson
Message-Id: <20210706035015.122899-1-kito.ch...@sifive.com>
Signed-off-by: Laurent Vivier
---
linux-user/elfload.c | 13 +
1 file changed, 13
From: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-Id: <20210706234932.356913-3-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
linux-user/linuxload.c | 42 --
1 file changed, 20
From: Philippe Mathieu-Daudé
We are going to move this code, fix its style first.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210704183755.655002-12-f4...@amsat.org>
Signed-off-by: Laurent Vivier
---
linux-user/syscall.c | 188 +--
1 file
-pull-request
for you to fetch changes up to c632ea1dd90313bc360b9de9d5014c2167f4d038:
linux-user/syscall: Remove hardcoded tabs (code style) (2021-07-07 21:34:21
+0200)
linux-user pull request 20210708
Code and style cleanup
Add
From: Andreas Schwab
Signed-off-by: Andreas Schwab
Reviewed-by: Laurent Vivier
Message-Id:
Signed-off-by: Laurent Vivier
---
linux-user/syscall.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 64bbf331b282..3bc06d178e83 100644
---
Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben:
> On 7/7/21 11:04 AM, Peter Lieven wrote:
> > task->complete is a bool not an integer.
> >
> > Signed-off-by: Peter Lieven
> > ---
> > block/rbd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/rbd.c
i have to apply below extra changes
From a8d027d3dfe70fb33363ad5934e163999fc29eec Mon Sep 17 00:00:00 2001
From: Li Zhijian
Date: Thu, 8 Jul 2021 17:52:40 +0800
Subject: [PATCH] fix libpmem configuration
Signed-off-by: Li Zhijian
---
configure | 2 +-
1 file changed, 1 insertion(+), 1
Let's compress the code a bit to improve readability. We can drop the
vm_running check in virtio_balloon_free_page_start() as it's already
properly checked in the single caller.
Cc: Wei Wang
Cc: Michael S. Tsirkin
Cc: Philippe Mathieu-Daudé
Cc: Alexander Duyck
Cc: Juan Quintela
Cc: "Dr.
On Tue, 6 Jul 2021 at 22:14, Rebecca Cran wrote:
>
> Add a space in the message printed when gicr_read*/gicr_write* returns
> MEMTX_ERROR in arm_gicv3_redist.c.
>
> Signed-off-by: Rebecca Cran
> ---
> hw/intc/arm_gicv3_redist.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Postcopy never worked properly with 'free-page-hint=on', as there are
at least two issues:
1) With postcopy, the guest will never receive a VIRTIO_BALLOON_CMD_ID_DONE
and consequently won't release free pages back to the OS once
migration finishes.
The issue is that for postcopy, we
This is the follow up on [1]:
[PATCH v1 0/2] virtio-balloon: disallow postcopy with
VIRTIO_BALLOON_F_FREE_PAGE_HINT
Working on getting migration for virtio-mem completely right [2] I realized
that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with
postcopy might be shaky.
On Wed, 7 Jul 2021 at 20:32, Eduardo Habkost wrote:
>
> The following changes since commit 9aef0954195cc592e86846dbbe7f3c2c5603690a:
>
> Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream'
> into staging (2021-07-06 11:24:58 +0100)
>
> are available in the Git repository
On Tue, 6 Jul 2021 at 14:45, wrote:
>
> Signed-off-by: Nick Hudson
> ---
> target/arm/helper.c | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index a66c1f0b9e..910ace4274 100644
> --- a/target/arm/helper.c
>
On 08/07/21 11:05, Markus Armbruster wrote:
Minimally invasive fix, but the result is a bit awkward. Possibly
neater:
if (qobject_type(crumpled) == QTYPE_QLIST) {
error_setg(errp,
"Lists cannot be at top level of a configuration
section");
}
On 08/07/21 11:05, Markus Armbruster wrote:
Fixes: c0d4aa82f895af67cbf7772324e05605e22b4162
Good point, will add.
Paolo
On Wed, 7 Jul 2021 at 02:25, Richard Henderson
wrote:
>
> On 7/2/21 4:45 AM, Peter Maydell wrote:
> > On Fri, 2 Jul 2021 at 12:02, Philippe Mathieu-Daudé wrote:
> >> On 7/2/21 12:40 PM, Peter Maydell wrote:
> >>> static const VMStateDescription vmstate_pl061 = {
> >>> @@ -151,16 +150,9 @@
Hi Alex,
Sorry, missed this one, apologies for the delay in responding.
On Tuesday, 2021-06-29 at 23:41:23 -04, Alexander Bulekov wrote:
> By default, -fsanitize=fuzzer instruments all code with coverage
> information. However, this means that libfuzzer will track coverage over
> hundreds of
Paolo Bonzini writes:
> Ensure that the callback to qemu_config_foreach is never called upon
> an error, by moving the invocation before the "out" label and ensuring
> all error cases jump to the label. The qobject_unref however needs
> to be done in all cases (which Coverity is already
On Wed, Jul 07, 2021 at 07:45:49PM +0100, Alex Bennée wrote:
> While we do mention some of this stuff in the various daemons and
> manuals the subtleties of the socket and memory sharing are sometimes
> missed. This document attempts to give some background on vhost-user
> daemons in general
On Fri, 2 Jul 2021 10:45:37 -0400
"Michael S. Tsirkin" wrote:
> On Fri, Jun 25, 2021 at 05:17:28AM -0400, Igor Mammedov wrote:
> > Set -smp 1,maxcpus=288 to test for ACPI code that
> > deal with CPUs with large APIC ID (>255).
> >
> > PS:
> > Test requires KVM and in-kernel irqchip support,
> >
On Wed, Jul 07, 2021 at 09:57:21PM -0500, Shivaprasad G Bhat wrote:
> The patch adds support for the SCM flush hcall for the nvdimm devices.
> To be available for exploitation by guest through the next patch.
>
> The hcall expects the semantics such that the flush to return
> with one of
Paolo Bonzini writes:
> Coverity reports that qemu_parse_config_group is returning without
> unrefing the "crumpled" dictionary in case its top level item is a
> list. But actually the contract with qemu_record_config_group is
> the same as for qemu_parse_config_group itself: if those function
On Thu, 8 Jul 2021 at 06:46, Akihiko Odaki wrote:
>
> Signed-off-by: Akihiko Odaki
> ---
> ui/cocoa.m | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 9f72844b079..68a6302184a 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1888,12
Hi Peter,
On 7/7/21 5:35 PM, Peter Xu wrote:
> On Wed, Jul 07, 2021 at 11:29:47AM +0200, Eric Auger wrote:
>> Hi Peter,
>
> Hi, Eric,
>
>>
>> On 6/11/21 8:55 PM, Peter Xu wrote:
>>> The parameters of intel-iommu device are non-trivial to understand. Add an
>>> entry for it so that people can
On Thu, 8 Jul 2021 at 06:38, Akihiko Odaki wrote:
>
> Hi,
>
> My installation correctly shows the picture. Please make sure you
> install it and run the installed binary (not the binary located in the
> build directory). The new code should work reliably once you install
> it while the old code
Hi Wainer, William, Cleber,
On 7/8/21 3:17 AM, Cleber Rosa wrote:
>
> On 7/6/21 9:17 AM, Eric Auger wrote:
>> From: Willian Rampazzo
>>
>> As the KNOWN_DISTROS grows, more loosely methods will be created in
>> the avocado_qemu/__init__.py file.
>>
>> Let's refactor the code so that KNOWN_DISTROS
On 08/07/2021 01:52, Finn Thain wrote:
On Wed, 7 Jul 2021, Mark Cave-Ayland wrote:
However this conflicts with what you mention above that the SONIC is
hard-coded into little-endian mode, in which case we would still need to
keep it.
If you want to fully implement BMODE in QEMU then you'll
On 7/7/21 3:53 AM, Richard Henderson wrote:
> On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote:
>> We want to access the target errno indepently of the rest
>> of the linux-user code. Extract it to a new target-specific
>> header: 'target_errno_defs.h'.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
On vhost-user-blk migration, qemu normally sends a number of commands
to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and
VHOST_USER_SET_VRING_ADDR per each started ring to enable "used ring"
data logging.
The issue
On 07.07.21 21:57, Michael S. Tsirkin wrote:
On Wed, Jul 07, 2021 at 09:47:31PM +0200, David Hildenbrand wrote:
On 07.07.21 21:19, Michael S. Tsirkin wrote:
On Wed, Jul 07, 2021 at 09:14:00PM +0200, David Hildenbrand wrote:
On 07.07.21 21:05, Michael S. Tsirkin wrote:
On Wed, Jul 07, 2021 at
On 7/8/21 12:24 AM, Richard Henderson wrote:
> Do not call helper_fninit directly from helper_xrstor.
> Do call the new helper from do_fsave.
>
> Signed-off-by: Richard Henderson
> ---
> target/i386/tcg/fpu_helper.c | 22 --
> 1 file changed, 8 insertions(+), 14 deletions(-)
On 7/8/21 9:14 AM, Laszlo Ersek wrote:
> I've relinquished my edk2 roles with the following commit message [1] [2]
> [3]:
>
>> Maintainers.txt: remove Laszlo Ersek's entries
>>
>> I'm relinquishing all my roles listed in "Maintainers.txt", for personal
>> reasons.
Thank you Laszlo for your
07.07.2021 21:41, Eric Blake wrote:
Reword the paragraphs to list the JSON key first, rather than in the
middle of prose.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Thu, Jul 08, 2021 at 09:26:17AM +0200, David Hildenbrand wrote:
> On 08.07.21 09:12, Yang Zhong wrote:
> >The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> >in the hw/remote/memory.c.
>
> Yes, seems like that call was added just after I crafted my patches:
>
>
On Wednesday, 2021-07-07 at 11:10:21 +01, David Edmondson wrote:
> On Tuesday, 2021-07-06 at 18:09:42 -07, Richard Henderson wrote:
>
>> On 7/5/21 3:46 AM, David Edmondson wrote:
>>> Given that TCG is now the only consumer of X86XSaveArea, move the
>>> structure definition and associated offset
On 08.07.21 09:12, Yang Zhong wrote:
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
in the hw/remote/memory.c.
Yes, seems like that call was added just after I crafted my patches:
Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
On 07.07.2021 21:44, Michael S. Tsirkin wrote:
On Wed, Jul 07, 2021 at 05:58:50PM +0300, Denis Plotnikov wrote:
On 07.07.2021 17:39, Michael S. Tsirkin wrote:
On Wed, Jul 07, 2021 at 03:19:20PM +0300, Denis Plotnikov wrote:
On 07.07.2021 13:10, Michael S. Tsirkin wrote:
On Fri, Jun 25,
On 07.07.21 23:22, Alexander Duyck wrote:
On Wed, Jul 7, 2021 at 1:08 PM Peter Xu wrote:
On Wed, Jul 07, 2021 at 08:57:29PM +0200, David Hildenbrand wrote:
On 07.07.21 20:02, Peter Xu wrote:
On Wed, Jul 07, 2021 at 04:06:55PM +0200, David Hildenbrand wrote:
As it never worked properly,
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
in the hw/remote/memory.c.
Signed-off-by: Yang Zhong
---
hw/remote/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/remote/memory.c b/hw/remote/memory.c
index 472ed2a272..6e21ab1a45
On 08.07.21 00:40, Peter Xu wrote:
On Wed, Jul 07, 2021 at 02:22:32PM -0700, Alexander Duyck wrote:
On Wed, Jul 7, 2021 at 1:08 PM Peter Xu wrote:
On Wed, Jul 07, 2021 at 08:57:29PM +0200, David Hildenbrand wrote:
On 07.07.21 20:02, Peter Xu wrote:
On Wed, Jul 07, 2021 at 04:06:55PM +0200,
I've relinquished my edk2 roles with the following commit message [1] [2]
[3]:
> Maintainers.txt: remove Laszlo Ersek's entries
>
> I'm relinquishing all my roles listed in "Maintainers.txt", for personal
> reasons.
>
> My email address remains functional.
>
> To my understanding, my employer is
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with Pegasos2):
(VOF) setprop will start failing if the machine class callback
did not handle it;
(VOF) unit addresses are lowered in path_offset();
(SPAPR) /chosen/bootargs is initialized from
On 08/07/2021 12:40, David Gibson wrote:
[snip]
+static uint32_t vof_getprop(const void *fdt, uint32_t nodeph, uint32_t pname,
+uint32_t valaddr, uint32_t vallen)
+{
+char propname[OF_PROPNAME_LEN_MAX + 1];
+uint32_t ret = 0;
+int proplen = 0;
+
On 7/7/21 6:14 PM, Stefan Hajnoczi wrote:
On Wed, Jul 07, 2021 at 12:43:56PM +0200, Hannes Reinecke wrote:
On 7/7/21 11:53 AM, Klaus Jensen wrote:
On Jul 7 09:49, Hannes Reinecke wrote:
On 7/6/21 11:33 AM, Klaus Jensen wrote:
From: Klaus Jensen
Prior to this patch the nvme-ns devices are
601 - 662 of 662 matches
Mail list logo
