[PULL 07/14] target/alpha: Use tcg_constant_i64 for zero and lit

2021-07-13 Thread Richard Henderson
These constant temps do not need to be freed, and therefore need less bookkeeping from tcg producers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/alpha/translate.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git

[PULL 13/14] target/hppa: Use tcg_constant_*

2021-07-13 Thread Richard Henderson
Replace uses of tcg_const_* with the allocate and free close together. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/translate.c | 56 + 1 file changed, 18 insertions(+), 38 deletions(-) diff --git

Re: [PATCH v6 06/10] hw/intc: GICv3 redistributor ITS processing

2021-07-13 Thread Peter Maydell
On Wed, 7 Jul 2021 at 03:18, Shashi Mallela wrote: > > Implemented lpi processing at redistributor to get lpi config info > from lpi configuration table,determine priority,set pending state in > lpi pending table and forward the lpi to cpuif.Added logic to invoke > redistributor lpi processing

[PULL 08/14] target/alpha: Use tcg_constant_* elsewhere

2021-07-13 Thread Richard Henderson
Replace the remaining uses of tcg_const_*. These uses are all local, with the allocate and free close together. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/alpha/translate.c | 46 1 file changed, 14 insertions(+), 32

Re: [PATCH 0/4] support dirtyrate measurement with dirty bitmap

2021-07-13 Thread Peter Xu
On Sun, Jul 11, 2021 at 11:27:13PM +0800, Hyman Huang wrote: > > IMHO we can directly do the calculation when synchronizing the dirty bits in > > below functions: > > > > cpu_physical_memory_set_dirty_range > > cpu_physical_memory_set_dirty_lebitmap > >

[PATCH v2 3/5] hw/nvme: fix out-of-bounds reads

2021-07-13 Thread Klaus Jensen
From: Klaus Jensen Peter noticed that mmio access may read into the NvmeParams member in the NvmeCtrl struct. Fix the bounds check. Reported-by: Peter Maydell Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-)

[PATCH v2 4/5] hw/nvme: fix mmio read

2021-07-13 Thread Klaus Jensen
From: Klaus Jensen The new PMR test unearthed a long-standing issue with MMIO reads on big-endian hosts. Fix this by unconditionally storing all controller registers in little endian. Cc: Gollu Appalanaidu Reported-by: Peter Maydell Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 304

[RFC PATCH v3 2/5] spapr: move NUMA data init to post-CAS

2021-07-13 Thread Daniel Henrique Barboza
The pSeries machine will support a new NUMA affinity form, FORM2. This new FORM will be negotiated via ibm,architecture-vec5 during CAS. All artifacts and assumptions that are currently on use for FORM1 affinity will be deprecated in a guest that chooses to use FORM2. This means that we're going

[RFC PATCH v3 0/5] pSeries FORM2 affinity support

2021-07-13 Thread Daniel Henrique Barboza
Hi, This new version drops all the NVDIMM related changes from the previous iteraction after the reviews done in the kernel mailing list [1]. FORM2 will not use ibm,associativity-reference-points to determine a second NUMA mode for different operation modes of PAPR-SCM. [1]

Re: [PATCH V5 10/25] util: env var helpers

2021-07-13 Thread Steven Sistare
On 7/12/2021 3:36 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jul 12, 2021 at 11:19 PM Steven Sistare > wrote: > > On 7/8/2021 11:10 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 7, 2021 at 9:30 PM Steve Sistare

[PULL 02/11] i386: hardcode supported eVMCS version to '1'

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov Currently, the only eVMCS version, supported by KVM (and described in TLFS) is '1'. When Enlightened VMCS feature is enabled, QEMU takes the supported eVMCS version range (from KVM_CAP_HYPERV_ENLIGHTENED_VMCS enablement) and puts it to guest visible CPUIDs. When (and if)

[PULL 10/11] numa: Report expected initiator

2021-07-13 Thread Eduardo Habkost
From: Michal Privoznik When setting up NUMA with HMAT enabled there's a check performed in machine_set_cpu_numa_node() that reports an error when a NUMA node has a CPU but the node's initiator is not itself. The error message reported contains only the expected value and not the actual value

[PATCH v2 2/4] qemu-options: re-arrange CPU topology options

2021-07-13 Thread Daniel P . Berrangé
The list of CPU topology options are presented in a fairly arbitrary order currently. Re-arrange them so that they're ordered from largest to smallest unit Reviewed-by: Andrew Jones Reviewed-by: Yanan Wang Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 12 ++-- 1 file

Re: [PATCH 05/11] hw/audio/adlib: Remove unused variable in adlib_callback

2021-07-13 Thread Philippe Mathieu-Daudé
On 7/12/21 11:55 PM, Richard Henderson wrote: > From clang-13: > hw/audio/adlib.c:189:18: error: variable 'net' set but not used \ > [-Werror,-Wunused-but-set-variable] > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > hw/audio/adlib.c | 3 +-- > 1 file changed, 1

[PATCH v2 4/4] qemu-options: rewrite help for -smp options

2021-07-13 Thread Daniel P . Berrangé
The -smp option help is peculiarly specific about mentioning the CPU upper limits, but these are wrong. The "PC" target has varying max CPU counts depending on the machine type picked. Notes about guest OS limits are inappropriate for QEMU docs. There are way too many machine types for it to be

[PULL 04/14] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-07-13 Thread Richard Henderson
From: Ziqiao Kong Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note that CPUID.(EAX=07H,ECX=0H):EBX[bit 13] is not implemented by design in this patch and will be added along with TCG features flag in a separate patch later. Signed-off-by: Ziqiao Kong Message-Id:

[PULL 00/14] misc translator patch queue

2021-07-13 Thread Richard Henderson
The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into staging (2021-07-13 14:32:20 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-misc-20210713

[PULL 12/14] target/openrisc: Use dc->zero in gen_add, gen_addc

2021-07-13 Thread Richard Henderson
We still need the t0 temporary for computing overflow, but we do not need to initialize it to zero first. Reviewed-by: Stafford Horne Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-13 Thread Cleber Rosa
Philippe Mathieu-Daudé writes: > Avocado allows us to select set of tests using tags. > When wanting to run all tests using a NetBSD guest OS, > it is convenient to have them tagged, add the 'os:netbsd' > tag. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PULL v4 00/42] testing, build and plugin updates

2021-07-13 Thread Peter Maydell
On Mon, 12 Jul 2021 at 22:05, Alex Bennée wrote: > > The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' > into staging (2021-07-12 11:02:39 +0100) > > are available in the Git repository at:

Re: [RFC PATCH 3/6] job: minor changes to simplify locking

2021-07-13 Thread Eric Blake
On Wed, Jul 07, 2021 at 06:58:10PM +0200, Emanuele Giuseppe Esposito wrote: > Check for NULL id to job_get, so that in the next patch we can > move job_get inside a single critical section of job_create. > > Also add missing notifier_list_init for the on_idle NotifierList, > which seems to have

License advice for Async QMP

2021-07-13 Thread John Snow
Hi, I'm deep into writing a new Async QMP library for QEMU, one that I intend to ship outside of our castle walls and host on PyPI. I need to choose a license for it. I slapped GPLv2 on it in keeping with the license on the original library by Luiz Capitulino (And it is generally my preference),

Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10

2021-07-13 Thread Michael Roth
Quoting Konstantin Kostiuk (2021-04-22 02:43:25) > ping I've been trying to get these queued but I'm hitting an issue where qga reports: failed to load qga-vss.dll: The specified module could not be found. via LoadLibraryA(QGA_VSS_DLL) returning error code 126. What's weird is it seems to

[RFC PATCH v3 1/5] spapr_numa.c: split FORM1 code into helpers

2021-07-13 Thread Daniel Henrique Barboza
The upcoming FORM2 NUMA affinity will support asymmetric NUMA topologies and doesn't need be concerned with all the legacy support for older pseries FORM1 guests. We're also not going to calculate associativity domains based on numa distance (via spapr_numa_define_associativity_domains) since the

[PATCH 0/2] SIGSEGV fixes

2021-07-13 Thread Taylor Simpson
The Hexagon target was silently failing the SIGSEGV test because the signal handler was not called. Patch 1/2 fixes the Hexagon target Patch 2/2 adds a check that the signal handler is called Taylor Simpson (2): Hexagon (target/hexagon) do probe_write in HELPER(commit_store) linux-test

[RFC PATCH v3 3/5] spapr_numa.c: base FORM2 NUMA affinity support

2021-07-13 Thread Daniel Henrique Barboza
The main feature of FORM2 affinity support is the separation of NUMA distances from ibm,associativity information. This allows for a more flexible and straightforward NUMA distance assignment without relying on complex associations between several levels of NUMA via ibm,associativity matches.

[PATCH v5 02/10] tests: Add tpm_version field to TPMTestState and fill it

2021-07-13 Thread Stefan Berger
Signed-off-by: Stefan Berger --- v3: - Added enum TPMVersion for when CONFIG_TPM is not defined --- tests/qtest/bios-tables-test.c| 5 +++-- tests/qtest/tpm-crb-test.c| 1 + tests/qtest/tpm-emu.c | 13 ++--- tests/qtest/tpm-emu.h | 8

[PATCH v5 06/10] tests: tpm: Create TPM 1.2 response in TPM emulator

2021-07-13 Thread Stefan Berger
Signed-off-by: Stefan Berger --- v3: - Added TPM_VERSION_1_2 enum for when CONFIG_TPM is not defined --- tests/qtest/tpm-emu.c | 5 + tests/qtest/tpm-emu.h | 4 2 files changed, 9 insertions(+) diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c index 8baf49eafd..32c704194b

Re: [PULL 00/22] Crypto and more patches

2021-07-13 Thread Daniel P . Berrangé
On Tue, Jul 13, 2021 at 02:45:28PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 13, 2021 at 10:25:44AM +0100, Peter Maydell wrote: > > On Mon, 12 Jul 2021 at 14:23, Daniel P. Berrangé > > wrote: > > > > > > The following changes since commit > > > bd38ae26cea0d1d6a97f930248df149204c210a2: > >

Re: [PATCH V4 18/25] vhost: reset vhost devices upon cprsave

2021-07-13 Thread Michael S. Tsirkin
On Tue, Jul 06, 2021 at 09:45:49AM -0700, Steve Sistare wrote: > A vhost device is implicitly preserved across re-exec because its fd is not > closed, and the value of the fd is specified on the command line for the > new qemu to find. However, new qemu issues an VHOST_RESET_OWNER ioctl, > which

[PULL 04/11] i386: expand Hyper-V features during CPU feature expansion time

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we need to expand and set the corresponding CPUID leaves early. Modify x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V specific kvm_hv_get_supported_cpuid() instead of

Re: [PATCH 0/4] docs: improve -smp documentation

2021-07-13 Thread Eduardo Habkost
On Fri, Jul 09, 2021 at 04:48:57PM -0400, Eduardo Habkost wrote: > On Mon, Jun 28, 2021 at 12:30:43PM +0100, Daniel P. Berrangé wrote: > > This is a spin off from this thread: > > > > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06135.html > > > > to improve the documentation of

[PULL 05/11] i386: kill off hv_cpuid_check_and_set()

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov hv_cpuid_check_and_set() does too much: - Checks if the feature is supported by KVM; - Checks if all dependencies are enabled; - Sets the feature bit in cpu->hyperv_features for 'passthrough' mode. To reduce the complexity, move all the logic except for dependencies check

[PULL 07/11] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS privileges

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov When Hyper-V SynIC is enabled, we may need to allow Windows guests to make hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed because KVM is very permissive, allowing these hypercalls regarding of guest visible CPUid bits. Reviewed-by: Eduardo

Re: [PATCH v2 1/3] docs: Add skeletal documentation of cubieboard

2021-07-13 Thread Philippe Mathieu-Daudé
On 7/13/21 4:22 PM, Peter Maydell wrote: > Add skeletal documentation of the cubieboard machine. > > Signed-off-by: Peter Maydell > --- > docs/system/arm/cubieboard.rst | 16 > docs/system/target-arm.rst | 1 + > MAINTAINERS| 1 + > 3 files changed, 18

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-13 Thread Stefan Hajnoczi
On Tue, Jul 13, 2021 at 06:18:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 13.07.2021 16:10, Stefan Hajnoczi wrote: > > On Mon, Jul 12, 2021 at 10:41:46AM +0200, Emanuele Giuseppe Esposito wrote: > > > > > > > > > On 08/07/2021 15:04, Stefan Hajnoczi wrote: > > > > On Thu, Jul 08, 2021 at

[PULL 02/14] target/i386: Trivial code motion and code style fix

2021-07-13 Thread Richard Henderson
From: Ziqiao Kong A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong Message-Id: <20210530150112.74411-1-ziqiaok...@gmail.com> Signed-off-by: Richard

[PULL 01/14] target/i386: Tidy hw_breakpoint_remove

2021-07-13 Thread Richard Henderson
From: Dmitry Voronetskiy Since cpu_breakpoint and cpu_watchpoint are in a union, the code should access only one of them. Signed-off-by: Dmitry Voronetskiy Message-Id: <20210613180838.21349-1-davoronets...@gmail.com> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson ---

[PULL 05/14] target/alpha: Store set into rx flag

2021-07-13 Thread Richard Henderson
A paste-o meant that we wrote back the existing value of the RX flag rather than changing it to TMP. Use tcg_constant_i64 while we're at it. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PULL 14/14] target/hppa: Clean up DisasCond

2021-07-13 Thread Richard Henderson
The a0_is_n flag is redundant with comparing a0 to cpu_psw_n. The a1_is_0 flag can be removed by initializing a1 to $0, which also means that cond_prep can be removed entirely. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 43 + 1 file

Re: [PATCH 1/4] configure: Fix --without-default-features propagation to meson

2021-07-13 Thread Philippe Mathieu-Daudé
+Alex On 7/13/21 11:31 AM, Thomas Huth wrote: > A typo prevents that many features get disabled when the user > runs "configure" with the --without-default-features switch. > > Reported-by: Cole Robinson > Signed-off-by: Thomas Huth > --- > configure | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper

2021-07-13 Thread Cleber Rosa
Philippe Mathieu-Daudé writes: > To be able to expand an image to a non-power-of-2 value, > extract image_expand() from image_pow2ceil_expand(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 14 +- > 1 file changed, 9 insertions(+), 5

Re: [PATCH v2 2/3] qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap

2021-07-13 Thread Eric Blake
On Sat, Jul 10, 2021 at 09:06:24PM +0300, Nir Soffer wrote: > On 7/9/21 6:39 PM, Eric Blake wrote: > > Waiting until the end of the convert operation (a potentially > > time-consuming task) to finally detect that we can't copy a bitmap is > > bad, comparing to failing fast up front. Furthermore,

Re: [PATCH v2 3/3] qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'

2021-07-13 Thread Nir Soffer
On Tue, Jul 13, 2021 at 8:53 PM Eric Blake wrote: > > On Sat, Jul 10, 2021 at 09:37:35PM +0300, Nir Soffer wrote: > > > We don't want to delete inconsistent bitmaps by default: although a > > > corrupt bitmap is only a loss of optimization rather than a corruption > > > of user-visible data, it

[PATCH v2 1/5] hw/nvme: split pmrmsc register into upper and lower

2021-07-13 Thread Klaus Jensen
From: Klaus Jensen The specification uses a set of 32 bit PMRMSCL and PMRMSCU registers to make up the 64 bit logical PMRMSC register. Make it so. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 31 --- hw/nvme/ctrl.c | 9 + 2 files changed,

[RFC PATCH v3 5/5] spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()

2021-07-13 Thread Daniel Henrique Barboza
FORM2 NUMA affinity is prepared to deal with memory/cpu less NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM device that has a different latency than the original NUMA node from the regular memory. Move this verification to FORM1 affinity code. Signed-off-by: Daniel Henrique

Re: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

2021-07-13 Thread Peter Xu
On Tue, Jul 13, 2021 at 08:40:21AM +, Wang, Wei W wrote: > On Thursday, July 1, 2021 4:08 AM, Peter Xu wrote: > > Taking the mutex every time for each dirty bit to clear is too slow, > > especially we'll > > take/release even if the dirty bit is cleared. So far it's only used to > > sync

[PULL 01/11] i386: clarify 'hv-passthrough' behavior

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov Clarify the fact that 'hv-passthrough' only enables features which are already known to QEMU and that it overrides all other 'hv-*' settings. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-3-vkuzn...@redhat.com>

Re: [PATCH v2 3/3] docs: Add skeletal documentation of highbank and midway

2021-07-13 Thread Philippe Mathieu-Daudé
On 7/13/21 4:22 PM, Peter Maydell wrote: > Add skeletal documentation for the highbank and midway machines. > > Signed-off-by: Peter Maydell > --- > docs/system/arm/highbank.rst | 19 +++ > docs/system/target-arm.rst | 1 + > MAINTAINERS | 1 + > 3 files

[PATCH v2 1/4] docs: fix typo s/Intel/AMD/ in CPU model notes

2021-07-13 Thread Daniel P . Berrangé
Reviewed-by: Andrew Jones Reviewed-by: Yanan Wang Signed-off-by: Daniel P. Berrangé --- docs/system/cpu-models-x86.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc index f40ee03ecc..9119f5dff5

[PULL 09/14] target/openrisc: Use tcg_constant_*

2021-07-13 Thread Richard Henderson
Replace uses of tcg_const_* allocate and free close together with tcg_constant_*. Reviewed-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 42 - 1 file changed, 9 insertions(+), 33

[PULL 11/14] target/openrisc: Cache constant 0 in DisasContext

2021-07-13 Thread Richard Henderson
We are virtually certain to have fetched constant 0 once, at the beginning of the TB, so we might as well use it elsewhere. Reviewed-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 12 ++-- 1 file changed, 6

[PULL 06/14] target/alpha: Use dest_sink for HW_RET temporary

2021-07-13 Thread Richard Henderson
This temp is automatically freed, just like ctx->lit. But we're about to remove ctx->lit, so use sink instead. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-13 Thread Richard Henderson
On 7/13/21 8:18 AM, Cole Robinson wrote:   https://bugs.llvm.org/show_bug.cgi?id=51076 ... Richard can you clarify, do you think the errors are a clang bug as well, or strictly a qemu issue? If it's clang maybe I can get Red Hat llvm devs to help There are minor adjustments that can (and

Re: [PATCH v2 3/3] qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'

2021-07-13 Thread Eric Blake
On Sat, Jul 10, 2021 at 09:37:35PM +0300, Nir Soffer wrote: > > We don't want to delete inconsistent bitmaps by default: although a > > corrupt bitmap is only a loss of optimization rather than a corruption > > of user-visible data, it is still nice to require the user to opt in > > to the fact

[PULL 0/1] qemu-ga patch queue for soft-freeze

2021-07-13 Thread Michael Roth
The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' into staging (2021-07-12 11:02:39 +0100) are available in the Git repository at: git://github.com/mdroth/qemu.git

Re: License advice for Async QMP

2021-07-13 Thread Daniel P . Berrangé
On Tue, Jul 13, 2021 at 02:26:28PM -0400, John Snow wrote: > Hi, > > I'm deep into writing a new Async QMP library for QEMU, one that I intend > to ship outside of our castle walls and host on PyPI. > > I need to choose a license for it. I slapped GPLv2 on it in keeping with > the license on the

Re: [PATCH v2 2/3] qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap

2021-07-13 Thread Nir Soffer
On Tue, Jul 13, 2021 at 8:48 PM Eric Blake wrote: > > On Sat, Jul 10, 2021 at 09:06:24PM +0300, Nir Soffer wrote: > > On 7/9/21 6:39 PM, Eric Blake wrote: > > > Waiting until the end of the convert operation (a potentially > > > time-consuming task) to finally detect that we can't copy a bitmap

[PATCH v5 03/10] tests: acpi: Prepare for renaming of TPM2 related ACPI files

2021-07-13 Thread Stefan Berger
Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger Reviewed-by: Igor Mammedov --- tests/data/acpi/q35/DSDT.tis.tpm2 | 0 tests/data/acpi/q35/TPM2.tis.tpm2 | 0 tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 3 files changed, 2 insertions(+) create

[PATCH v5 01/10] tests: Rename TestState to TPMTestState

2021-07-13 Thread Stefan Berger
Signed-off-by: Stefan Berger Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c| 2 +- tests/qtest/tpm-crb-test.c| 4 ++-- tests/qtest/tpm-emu.c | 6 +++--- tests/qtest/tpm-emu.h | 6 +++--- tests/qtest/tpm-tis-device-test.c | 2 +-

[PATCH 1/5] ebpf: Added eBPF initialization by fds and map update.

2021-07-13 Thread Andrew Melnychenko
RSS maps are combined into one array map. Changed eBPF map updates through mmaped array. eBPF RSS context may be initialized by program fd and map fd. virtio-net may provide fds passed by libvirt. Signed-off-by: Andrew Melnychenko --- ebpf/ebpf_rss-stub.c| 6 + ebpf/ebpf_rss.c |

Re: [PATCH 03/11] util/selfmap: Discard mapping on error

2021-07-13 Thread Eric Blake
On Mon, Jul 12, 2021 at 02:55:27PM -0700, Richard Henderson wrote: > From clang-13: > util/selfmap.c:26:21: error: variable 'errors' set but not used \ > [-Werror,-Wunused-but-set-variable] > > Quite right of course, but there's no reason not to check errors. > > First, incrementing errors

Re: [PATCH v2 2/3] docs: Add skeletal documentation of the emcraft-sf2

2021-07-13 Thread Philippe Mathieu-Daudé
On 7/13/21 4:22 PM, Peter Maydell wrote: > Add skeletal documentation of the emcraft-sf2 machine. > > Signed-off-by: Peter Maydell > --- > docs/system/arm/emcraft-sf2.rst | 15 +++ > docs/system/target-arm.rst | 1 + > MAINTAINERS | 1 + > 3 files changed,

Re: [PATCH 03/11] util/selfmap: Discard mapping on error

2021-07-13 Thread Richard Henderson
On 7/13/21 9:06 AM, Eric Blake wrote: e->dev = g_strdup(fields[3]); e->dev now contains malloc'd memory... -errors += qemu_strtou64(fields[4], NULL, 10, >inode); +errors |= qemu_strtou64(fields[4], NULL, 10, >inode); ...and if this

Re: [PULL 00/11] riscv-to-apply queue

2021-07-13 Thread Peter Maydell
On Mon, 12 Jul 2021 at 23:53, Alistair Francis wrote: > > The following changes since commit 57e28d34c0cb04abf7683ac6a12c87ede447c320: > > Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210708' > into staging (2021-07-12 19:15:11 +0100) > > are available in the Git repository

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-13 Thread Eric Blake
On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. To simplify > the launch parameter passing, introduce a .ini-like config file that can be > used for

[RFC PATCH v3 4/5] spapr: simplify spapr_numa_associativity_init params

2021-07-13 Thread Daniel Henrique Barboza
When spapr_numa_associativity_init() was introduced it was being called from spapr_machine_init(), where we have pointers to a SpaprMachineState and a MachineState. Having both being passed as params spared us from calling a macro to get the MachineState. Previous patches moved the function away

migration test, random hang, x86-64 host

2021-07-13 Thread Peter Maydell
Random hang in 'make check' for x86-64 host, clang build, qemu-system-i386 target. I think I've seen this occasionally in the past. This is with commit 708f50199b59 plus a merge of the ppc pullreq c785a40179b, but the latter doesn't touch anything relevant here. Process tree: petmay01 17386

Re: [PULL 36/40] vl: switch -M parsing to keyval

2021-07-13 Thread Alex Williamson
On Tue, 6 Jul 2021 12:01:37 +0200 Paolo Bonzini wrote: > Switch from QemuOpts to keyval. This enables the introduction > of non-scalar machine properties, and JSON syntax in the future. > > For JSON syntax to be supported right now, we would have to > consider what would happen if

[PATCH 1/2] Hexagon (target/hexagon) do probe_write in HELPER(commit_store)

2021-07-13 Thread Taylor Simpson
Check that access is OK before doing put_user_* Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 4595559..d7f53a2 100644 ---

[PATCH v5 08/10] tests: Use QMP to check whether a TPM device model is available

2021-07-13 Thread Stefan Berger
Use QMP to check whether a given TPM device model is available and if it is not the case then do not register the tests that require it. Signed-off-by: Stefan Berger --- tests/qtest/bios-tables-test.c | 8 +++ tests/qtest/tpm-emu.c | 38 ++

[PATCH v5 10/10] tests: acpi: tpm1.2: Add expected TPM 1.2 ACPI blobs

2021-07-13 Thread Stefan Berger
The TCPA.tis.tpm12 file contains the following: [000h 4]Signature : "TCPA"[Trusted Computing Platform Alliance table] [004h 0004 4] Table Length : 0032 [008h 0008 1] Revision : 02 [009h 0009 1]

[PATCH v5 04/10] tests: Add suffix 'tpm2' or 'tpm12' to ACPI table files

2021-07-13 Thread Stefan Berger
Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index

[PATCH v5 09/10] tests: acpi: Add test cases for TPM 1.2 with TCPA table

2021-07-13 Thread Stefan Berger
Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index

Re: [PATCH v6 04/10] hw/intc: GICv3 ITS Command processing

2021-07-13 Thread Peter Maydell
On Wed, 7 Jul 2021 at 03:18, Shashi Mallela wrote: > > Added ITS command queue handling for MAPTI,MAPI commands,handled ITS > translation which triggers an LPI via INT command as well as write > to GITS_TRANSLATER register,defined enum to differentiate between ITS > command interrupt trigger and

[PULL 03/11] i386: make hyperv_expand_features() return bool

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov Return 'false' when hyperv_expand_features() sets an error. No functional change intended. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-5-vkuzn...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/kvm/kvm.c

[PULL 11/11] numa: Parse initiator= attribute before cpus= attribute

2021-07-13 Thread Eduardo Habkost
From: Michal Privoznik When parsing cpus= attribute of -numa object couple of checks is performed, such as correct initiator setting (see the if() statement at the end of for() loop in machine_set_cpu_numa_node()). However, with the current code cpus= attribute is parsed before initiator=

[PULL 09/11] target/i386: Fix cpuid level for AMD

2021-07-13 Thread Eduardo Habkost
From: zhenwei pi A AMD server typically has cpuid level 0x10(test on Rome/Milan), it should not be changed to 0x1f in multi-dies case. * to maintain compatibility with older machine types, only implement this change when the CPU's "x-vendor-cpuid-only" property is false Cc: "Dr. David Alan

Re: [PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec

2021-07-13 Thread Philippe Mathieu-Daudé
On 7/12/21 11:55 PM, Richard Henderson wrote: > From clang-13: > accel/tcg/cpu-exec.c:783:15: error: variable 'cc' set but not used \ > [-Werror,-Wunused-but-set-variable] > > Signed-off-by: Richard Henderson > --- > accel/tcg/cpu-exec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff

[PATCH 2/2] linux-test (tests/tcg/multiarch/linux-test.c) add check

2021-07-13 Thread Taylor Simpson
Add a check that the SIGSEGV handler is called Signed-off-by: Taylor Simpson --- tests/tcg/multiarch/linux-test.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index c8c6aed..cb845c9 100644 ---

[PATCH v5 05/10] tests: acpi: tpm2: Add the renamed ACPI files and drop old ones

2021-07-13 Thread Stefan Berger
Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger Acked-by: Igor Mammedov --- tests/data/acpi/q35/DSDT.tis| Bin 8465 -> 0 bytes tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 0 -> 8465 bytes tests/data/acpi/q35/TPM2.tis| Bin 76 -> 0

Re: [PATCH RESEND v2 0/3] To add HMP interface to dump PCI MSI-X table/PBA

2021-07-13 Thread Michael S. Tsirkin
On Mon, Jul 12, 2021 at 04:58:09PM -0700, Dongli Zhang wrote: > I have just rebased the v2 patchset on top of most recent qemu to resend. > > This patch is to introduce the new HMP command to dump the MSI-X table/PBA. > > Here is the RFC v1: > >

[PULL 00/23] Python and Acceptance Tests

2021-07-13 Thread Cleber Rosa
The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into staging (2021-07-13 14:32:20 +0100) are available in the Git repository at: https://gitlab.com/cleber.gnu/qemu.git/

[PULL 11/23] avocado_qemu: Add Intel iommu tests

2021-07-13 Thread Cleber Rosa
From: Eric Auger Add Intel IOMMU functional tests based on fedora 31. Different configs are checked: - strict - caching mode, strict - passthrough. Signed-off-by: Eric Auger Signed-off-by: Willian Rampazzo Tested-by: Wainer dos Santos Moschetta Acked-by: Peter Xu Message-Id:

[PULL 10/23] avocado_qemu: Add SMMUv3 tests

2021-07-13 Thread Cleber Rosa
From: Eric Auger Add new tests checking the good behavior of the SMMUv3 protecting 2 virtio pci devices (block and net). We check the guest boots and we are able to install a package. Different guest configs are tested: standard, passthrough an strict=0. This is tested with both fedora 31 and

[PULL 02/23] Acceptance Tests: log information when creating QEMUMachine

2021-07-13 Thread Cleber Rosa
Including its base temporary directory, given that information useful for debugging can be put there. Signed-off-by: Cleber Rosa Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210211220146.2525771-5-cr...@redhat.com> Signed-off-by: Cleber Rosa ---

[PULL 1/3] vfio: Fix CID 1458134 in vfio_register_ram_discard_listener()

2021-07-13 Thread Alex Williamson
From: David Hildenbrand CID 1458134: Integer handling issues (BAD_SHIFT) In expression "1 << ctz64(container->pgsizes)", left shifting by more than 31 bits has undefined behavior. The shift amount, "ctz64(container->pgsizes)", is 64. Commit 5e3b981c330c ("vfio: Support for

Re: [PATCH 3/6] python/aqmp-tui: Add AQMP TUI draft

2021-07-13 Thread Niteesh G. S.
On Thu, Jul 8, 2021 at 8:50 AM John Snow wrote: > > > On Fri, Jul 2, 2021 at 5:26 PM G S Niteesh Babu > wrote: > >> Added a draft of AQMP TUI. >> >> Implements the follwing basic features: >> 1) Command transmission/reception. >> 2) Shows events asynchronously. >> 3) Shows server status in the

[PULL 19/23] hw/arm/virt-acpi-build: Add IORT support to bypass SMMUv3

2021-07-13 Thread Michael S. Tsirkin
From: Xingang Wang When we build IORT table with SMMUv3 and bypass iommu feature enabled, we can no longer setup one map from RC to SMMUv3 covering the whole RIDs. We need to walk the PCI bus and check whether the root bus will bypass iommu, setup RC -> SMMUv3 -> ITS map for RC which will not

[PULL 07/23] vhost-user-rng: Add vhost-user-rng implementation

2021-07-13 Thread Michael S. Tsirkin
From: Mathieu Poirier Following in the footsteps of what whas done for vhost-user-i2c and virtiofsd, introduce a random number generator (RNG) backend that communicates with a vhost-user server to retrieve entropy. That way another VMM could be using the same vhost-user daemon and avoid having

[PULL 15/23] hw/pxb: Add a bypass iommu property

2021-07-13 Thread Michael S. Tsirkin
From: Xingang Wang Add a bypass_iommu property for pci_expander_bridge, the property is used to indicate whether pxb root bus will bypass iommu. By default the bypass_iommu is disabled, and it can be enabled with: qemu -device pxb-pcie,bus_nr=0x10,addr=0x1,bypass_iommu=true Signed-off-by:

[PATCH v3 2/3] msix/hmp: add interface to dump device specific info

2021-07-13 Thread Dongli Zhang
While the previous patch is to dump the MSI-X table, sometimes we may need to dump device specific data, e.g., to help match the vector with the specific device queue. This patch is to add the PCI device specific interface to help dump those information. Any PCI device class may implement this

[PULL 05/23] Acceptance Tests: move definition of distro checksums to the framework

2021-07-13 Thread Cleber Rosa
Instead of having, by default, the checksum in the tests, and the definition of tests in the framework, let's keep them together. A central definition for distributions is available, and it should allow other known distros to be added more easily. No behavior change is expected here, and tests

[PULL 03/23] Acceptance Tests: distinguish between temp and logs dir

2021-07-13 Thread Cleber Rosa
Logs can be very important to debug issues, and currently QEMUMachine instances will remove logs that are created under the temporary directories. With this change, the stdout and stderr generated by the QEMU process started by QEMUMachine will always be kept along the test results directory.

[PULL 08/23] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-13 Thread Cleber Rosa
From: Willian Rampazzo As the KNOWN_DISTROS grows, more loosely methods will be created in the avocado_qemu/__init__.py file. Let's refactor the code so that KNOWN_DISTROS and related methods are packaged in a class Signed-off-by: Wainer dos Santos Moschetta Signed-off-by: Eric Auger

[PULL 17/23] python/qemu: Add args property to the QEMUMachine class

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta This added the args property to QEMUMachine so that users of the class can access and handle the list of arguments to be given to the QEMU binary. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta Message-Id:

[PULL 15/23] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The tests that are already tagged with "cpu:VALUE" don't need to add "-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu framework is able to handle it automatically. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by:

[PATCH v2 3/6] python/aqmp-tui: Add AQMP TUI draft

2021-07-13 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu ---

[PATCH v2 1/6] python: disable pylint errors for aqmp-tui

2021-07-13 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+) diff

[PULL 13/23] docs: Add '-device intel-iommu' entry

2021-07-13 Thread Michael S. Tsirkin
From: Peter Xu The parameters of intel-iommu device are non-trivial to understand. Add an entry for it so that people can reference to it when using. There're actually a few more options there, but I hide them explicitly because they shouldn't be used by normal QEMU users. Cc: Chao Yang Cc:

<    1   2   3   4   >