Re: spapr_events: Sure we may ignore migrate_add_blocker() failure?

2021-07-21 Thread David Gibson
On Mon, Jul 19, 2021 at 12:41:09PM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Mon, Jul 19, 2021 at 09:18:07AM +0200, Markus Armbruster wrote: > >> David Gibson writes: > >> > >> > On Thu, Jul 15, 2021 at 03:32:06PM +0200, Markus Armbruster wrote: > >> >> Commit 2500fb423a

[PATCH for-6.2 10/23] target/m68k: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 44 + 1 file changed, 9 insertions(+), 35 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index

[PATCH for-6.2 14/23] target/mips: Drop exit checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 50 + 1 file changed, 18 insertions(+), 32 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index

[PATCH for-6.2 16/23] target/ppc: Drop exit checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Reuse gen_debug_exception to handle architectural debug exceptions. Signed-off-by: Richard Henderson --- target/ppc/translate.c | 38 -- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git

[PATCH for-6.2 22/23] target/tricore: Drop check for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/tricore/helper.h| 1 - target/tricore/op_helper.c | 7 --- target/tricore/translate.c | 14 +- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/target/tricore/helper.h

Re: [PATCH] usb: fix usb-host dependency check

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 10:17 AM, Gerd Hoffmann wrote: > Fixes: 627302afb2f8 ("usb: build usb-host as module") > Reported-by: Programmingkid > Signed-off-by: Gerd Hoffmann > --- > hw/usb/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 07/12] ui/vdagent: unregister clipboard peer on finalize

2021-07-21 Thread Marc-André Lureau
Hi On Mon, Jul 19, 2021 at 11:30 AM wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > ui/vdagent.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ui/vdagent.c b/ui/vdagent.c > index 5ae5734c81..bce9f44b7b 100644 > --- a/ui/vdagent.c > +++ b/ui/vdagent.c

Re: [Virtio-fs] [PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table

2021-07-21 Thread Max Reitz
On 20.07.21 16:50, Vivek Goyal wrote: On Tue, Jul 13, 2021 at 05:07:31PM +0200, Max Reitz wrote: [..] The next question is, how do we detect temporary failure, because if we look up some new inode, name_to_handle_at() fails, we ignore it, and then it starts to work and we fail all further

[PATCH v2 09/13] ui/vdagent: split clipboard recv message handling

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 157 +-- 1 file changed, 89 insertions(+), 68 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index 3770c58b6c..362064213c 100644 --- a/ui/vdagent.c +++

[PATCH v2 13/13] ui/gtk-clipboard: emit release clipboard events

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/gtk-clipboard.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c index 4e4b3c52bb..16b2e2063e 100644 --- a/ui/gtk-clipboard.c +++ b/ui/gtk-clipboard.c @@ -144,7

[PATCH v2 03/13] ui/gtk-clipboard: use existing macros

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Hardcoding strings is error prone, use dedicated macros instead. Signed-off-by: Marc-André Lureau --- ui/gtk-clipboard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c index bff28d2030..5e817ae55c

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-21 Thread Richard Henderson
On 7/20/21 11:53 AM, Philippe Mathieu-Daudé wrote: Practically, this is working around what I'd call a gdb bug wrt avr. Which may even have been fixed -- I haven't looked. This is not a bug but a feature to deal with the Harvard architecture. QEMU AVR model is based on GCC sources so uses the

Re: [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-21 Thread Kirti Wankhede
On 7/20/2021 6:23 PM, Markus Armbruster wrote: When migrate_add_blocker(blocker, ) is followed by error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). This is the case in vfio_migration_probe(). Prior art: commit 386f6c07d2 "error: Avoid error_propagate()

[PATCH for-6.2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec

2021-07-21 Thread Richard Henderson
Currently the change in cpu_tb_exec is masked by the debug exception being raised by the translators. But this allows us to remove that code. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/accel/tcg/cpu-exec.c

[PATCH for-6.2 07/23] target/hppa: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b18150ef8d..9e0524efef 100644 ---

[PATCH for-6.2 06/23] target/arm: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 10 ++ target/arm/translate.c | 36 ++-- 2 files changed, 8 insertions(+), 38 deletions(-) diff --git a/target/arm/translate-a64.c

[PATCH for-6.2 03/23] target/avr: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/avr/translate.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index e08b83..0403470dd8 100644 ---

[PATCH for-6.2 05/23] target/hexagon: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/hexagon/translate.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 54fdcaa5e8..606fae6b06 100644 ---

[PATCH for-6.2 08/23] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt

2021-07-21 Thread Richard Henderson
We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/translate.c

[PATCH for-6.2 23/23] target/xtensa: Drop check for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 20399d6a04..3fbf76f4dd 100644

Re: [PATCH 2/2] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Claudio Fontana
On 7/21/21 12:31 AM, Jose R. Ziviani wrote: > module_object_class_by_name() calls module_load_qom_one if the object > is provided by a dynamically linked library. Such library might not be > available at this moment - for instance, it can be a package not yet > installed. Thus, instead of assert

Re: [PATCH v1 0/3] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-07-21 Thread David Hildenbrand
On 20.07.21 16:45, Daniel P. Berrangé wrote: On Wed, Jul 14, 2021 at 01:23:03PM +0200, David Hildenbrand wrote: #1 adds support for MADV_POPULATE_WRITE, #2 cleans up the code to avoid global variables and prepare for concurrency and #3 makes os_mem_prealloc() safe to be called from multiple

[PATCH v2 01/13] ui/vdagent: fix leak on error path

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau "info" was leaked when more than 10 entries. Signed-off-by: Marc-André Lureau --- include/ui/clipboard.h | 2 ++ ui/vdagent.c | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/ui/clipboard.h b/include/ui/clipboard.h index

[PATCH v2 11/13] ui/gtk-clipboard: use qemu_clipboard_info helper

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/gtk.h | 1 - ui/gtk-clipboard.c | 14 ++ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index 9516670ebc..60e9cdc39c 100644 --- a/include/ui/gtk.h +++

Re: [PATCH] failover: unregister ram on unplug

2021-07-21 Thread Igor Mammedov
On Tue, 20 Jul 2021 20:16:44 +0200 Laurent Vivier wrote: > This simple change allows to test failover with a simulated device > like e1000e rather than a vfio device. > > This is interesting to developers that want to test failover on > a system with no vfio device. Moreover it simplifies host

[PATCH for-6.2 19/23] target/rx: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/rx/helper.h| 1 - target/rx/op_helper.c | 8 target/rx/translate.c | 12 ++-- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/target/rx/helper.h

[PATCH for-6.2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP

2021-07-21 Thread Richard Henderson
We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c

[PATCH for-6.2 17/23] target/riscv: Remove dead code after exception

2021-07-21 Thread Richard Henderson
We have already set DISAS_NORETURN in generate_exception, which makes the exit_tb unreachable. Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_privileged.c.inc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH for-6.2 13/23] target/mips: Fix single stepping

2021-07-21 Thread Richard Henderson
As per an ancient comment in mips_tr_translate_insn about the expectations of gdb, when restarting the insn in a delay slot we also re-execute the branch. Which means that we are expected to execute two insns in this case. This has been broken since 8b86d6d2580, where we forced max_insns to 1

Re: [PATCH v1 27/29] gitlab: enable a very minimal build with the tricore container

2021-07-21 Thread Thomas Huth
On 21/07/2021 01.27, Alex Bennée wrote: Rather than base of the shared Debian 10 container which would require us to bring in even more dependencies just bring in what is needed for building tricore-softmmu in GitLab. We don't even remove the container from the DOCKER_PARTIAL_IMAGES lest we

[PATCH] vhost: use large iotlb entry if no IOMMU translation is needed

2021-07-21 Thread Chao Gao
If guest enables IOMMU_PLATFORM for virtio-net, severe network performance drop is observed even if there is no IOMMU. And disabling vhost can mitigate the perf issue. Finally, we found the culprit is frequent iotlb misses: kernel vhost-net has 2048 entries and each entry is 4K (qemu uses 4K for

Re: [PATCH v1 09/29] gitdm.config: sort the corporate GroupMap entries

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 1:26 AM, Alex Bennée wrote: > Lets try and keep them that way. > > Signed-off-by: Alex Bennée > Message-Id: <20210714182056.25888-10-alex.ben...@linaro.org> > --- > gitdm.config | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v6 5/5] tests/qtest/nvme-test: add mmio read test

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen Add a regression test for mmio read on big-endian hosts. Signed-off-by: Klaus Jensen Reviewed-by: Gollu Appalanaidu --- tests/qtest/nvme-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/nvme-test.c b/tests/qtest/nvme-test.c

[PATCH v3 3/4] softmmu/memory_mapping: factor out adding physical memory ranges

2021-07-21 Thread David Hildenbrand
Let's factor out adding a MemoryRegionSection to the list, to be reused in RamDiscardManager context next. Reviewed-by: Stefan Berger Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc:

[PATCH v3 2/4] softmmu/memory_mapping: never merge ranges accross memory regions

2021-07-21 Thread David Hildenbrand
Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Acked-by: Stefan Berger Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc:

[PATCH v2 06/13] ui/clipboard: release owned grabs on unregister

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/clipboard.c | 9 + 1 file changed, 9 insertions(+) diff --git a/ui/clipboard.c b/ui/clipboard.c index 56c14509fe..a9512f01a7 100644 --- a/ui/clipboard.c +++ b/ui/clipboard.c @@ -13,6 +13,15 @@ void

Re: [PATCH v3 1/4] vhost-user-rng: Add vhost-user-rng implementation

2021-07-21 Thread Alex Bennée
Mathieu Poirier writes: > Following in the footsteps of what whas done for vhost-user-i2c > and virtiofsd, introduce a random number generator (RNG) backend > that communicates with a vhost-user server to retrieve entropy. > That way another VMM could be using the same vhost-user daemon and >

Re: [PATCH v6 4/6] qmp: add QMP command x-debug-virtio-queue-status

2021-07-21 Thread Jonah Palmer
On 7/13/21 10:37 PM, Jason Wang wrote: 在 2021/7/12 下午6:35, Jonah Palmer 写道: From: Laurent Vivier This new command shows internal status of a VirtQueue. (vrings and indexes). Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer ---   hw/virtio/virtio-stub.c |   6 +++  

Re: [PATCH for-6.2 v6 7/7] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

2021-07-21 Thread David Gibson
On Mon, Jul 19, 2021 at 05:13:44PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 19, 2021 at 05:08:27PM -0300, Daniel Henrique Barboza wrote: > > MEM_UNPLUG_ERROR is deprecated since the introduction of > > DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of > > MEM_UNPLUG_ERROR is

Re: [PATCH qemu v2] ppc/vof: Fix Coverity issues

2021-07-21 Thread David Gibson
On Tue, Jul 20, 2021 at 03:07:26PM +1000, Alexey Kardashevskiy wrote: > Coverity reported issues which are caused by mixing of signed return codes > from DTC and unsigned return codes of the client interface. > > This introduces PROM_ERROR and makes distinction between the error types. > > This

[PATCH for-6.2 20/23] target/s390x: Drop check for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 0632b0374b..1894ed7a66 100644 ---

Re: Disabling TLS address caching to help QEMU on GNU/Linux

2021-07-21 Thread Thomas Huth
On 20/07/2021 16.52, Florian Weimer wrote: Currently, the GNU/Linux ABI does not really specify whether the thread pointer (the address of the TCB) may change at a function boundary. [...] One important piece of software for GNU is QEMU (not just for GNU/Linux, Hurd development also benefits

[PATCH v6 4/5] hw/nvme: fix mmio read

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen The new PMR test unearthed a long-standing issue with MMIO reads on big-endian hosts. Fix this by unconditionally storing all controller registers in little endian. Cc: Gollu Appalanaidu Reported-by: Peter Maydell Signed-off-by: Klaus Jensen Reviewed-by: Peter Maydell

[PATCH v6 3/5] hw/nvme: fix out-of-bounds reads

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen Peter noticed that mmio access may read into the NvmeParams member in the NvmeCtrl struct. Fix the bounds check. Reported-by: Peter Maydell Signed-off-by: Klaus Jensen Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Maydell --- hw/nvme/ctrl.c | 27

Re: [PATCH v1 23/29] plugins/cache: Fixed "function decl. is not a prototype" warnings

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 1:26 AM, Alex Bennée wrote: > From: Mahmoud Mandour > > Signed-off-by: Mahmoud Mandour > Reviewed-by: Alex Bennée > Message-Id: <20210714172151.8494-7-ma.mando...@gmail.com> > Signed-off-by: Alex Bennée > --- > contrib/plugins/cache.c | 6 +++--- > 1 file changed, 3 insertions(+),

[PATCH v3 0/4] softmmu/memory_mapping: optimize dump/tpm for virtio-mem

2021-07-21 Thread David Hildenbrand
Minor fixes and cleanups, followed by an optimization for virtio-mem regarding guest dumps and tpm. virtio-mem logically plugs/unplugs memory within a sparse memory region and notifies via the RamDiscardManager interface when parts become plugged (populated) or unplugged (discarded). Currently,

[PATCH v2 02/13] ui/vdagent: remove copy-pasta comment

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index f6ef8d1993..5ae5734c81 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -516,7 +516,7 @@ static void

[PATCH v2 05/13] ui/clipboard: add helper to retrieve current clipboard

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/clipboard.h | 9 + ui/clipboard.c | 15 +++ 2 files changed, 24 insertions(+) diff --git a/include/ui/clipboard.h b/include/ui/clipboard.h index eb789a285a..e9fcb15c66 100644 ---

[PATCH v2 04/13] ui/gtk-clipboard: fix clipboard enum typo

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/gtk-clipboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c index 5e817ae55c..2c78de9500 100644 --- a/ui/gtk-clipboard.c +++ b/ui/gtk-clipboard.c @@ -155,7 +155,7 @@

[PATCH v3 1/4] tpm: mark correct memory region range dirty when clearing RAM

2021-07-21 Thread David Hildenbrand
We might not start at the beginning of the memory region. We could also calculate via the difference in the host address; however, memory_region_set_dirty() also relies on memory_region_get_ram_addr() internally, so let's just use that. Acked-by: Stefan Berger Fixes: ffab1be70692 ("tpm: clear

[PATCH v2 08/13] ui/vdagent: reset outbuf on disconnect

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vdagent.c b/ui/vdagent.c index 1a29016e07..3770c58b6c 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -723,6 +723,7 @@ static void vdagent_chr_accept_input(Chardev

[PATCH v2 00/13] Clipboard fixes (for 6.1?)

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is a few fixes I have collected while working on clipboard-related code. There are some obvious code improvements/fixes, and better handling of release & unregister to avoid dangling pointers and improve user experience. v2: - replaced "ui/vdagent: unregister

[PATCH v2 07/13] ui/vdagent: disconnect handlers and reset state on finalize

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Avoid handlers being called with dangling pointers when the object is freed. Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index

Re: [PATCH v6 0/6] hmp, qmp: Add some commands to introspect virtio devices

2021-07-21 Thread Jonah Palmer
Hi Jason. My apologies for the delayed response, several work-related things came up recently, but they're slowing down now so I'm turning my attention these patches to get taken care of. A few questions and comments below (and in other following patches): On 7/13/21 10:42 PM, Jason Wang

Re: [PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event

2021-07-21 Thread David Gibson
On Mon, Jul 19, 2021 at 05:08:20PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and > has a few simple changes based on Greg's review. Tentatively applied to ppc-for-6.2. > > changes from v5: > - patch 1: > * fixed function

Re: [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly

2021-07-21 Thread David Gibson
On Tue, Jul 20, 2021 at 02:53:55PM +0200, Markus Armbruster wrote: > spapr_mce_req_event() makes an effort to prevent migration from > degrading the reporting of FWNMIs. It adds a migration blocker when > it receives one, and deletes it when it's done handling it. This is a > best effort. > >

Re: [PATCH v2] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-21 Thread David Gibson
On Tue, Jul 20, 2021 at 10:55:07AM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > In commit 8f0a4b6a9b, we started to require L=0 for ppc32 to match what > The Programming Environments Manual say: > > "For 32-bit implementations, the L field must be cleared, otherwise >

Re: -only-migrate and the two different uses of migration blockers

2021-07-21 Thread David Gibson
On Tue, Jul 20, 2021 at 07:30:16AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> We appear to use migration blockers in two ways: > >> > >> (1) Prevent migration for an indefinite time, typically due to use of > >>

[PATCH for-6.2 00/23] tcg: gdb singlestep reorg

2021-07-21 Thread Richard Henderson
Based-on: <20210720195439.626594-1-richard.hender...@linaro.org> ("tcg: breakpoint reorg") Consolidate all handling for gdb singlestep to 4 lines in cpu_tb_exec. Drop all of the code from target/*. Note that nios2 and sparc, lacked support for gdb singlestep entirely, which was a bit of a

[PATCH for-6.2 02/23] target/alpha: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index de6c0a8439..cfb0c3d675 100644 ---

[PATCH for-6.2 04/23] target/cris: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/cris/translate.c | 16 1 file changed, 16 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index a84b753349..59325b388a 100644 --- a/target/cris/translate.c

[PATCH for-6.2 09/23] target/i386: Drop check for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/i386/helper.h | 1 - target/i386/tcg/misc_helper.c | 8 target/i386/tcg/translate.c | 4 +--- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/target/i386/helper.h

[PATCH for-6.2 18/23] target/riscv: Remove exit_tb and lookup_and_goto_ptr

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically, which means we don't need to do anything in the wrappers. Signed-off-by: Richard Henderson --- target/riscv/translate.c | 29 +-- .../riscv/insn_trans/trans_privileged.c.inc | 4 +--

[PATCH for-6.2 21/23] target/sh4: Drop check for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/sh4/helper.h| 1 - target/sh4/op_helper.c | 5 - target/sh4/translate.c | 14 +++--- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/target/sh4/helper.h

[PATCH for-6.2 12/23] target/microblaze: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7e465b629a..437bbed6d6

[PATCH for-6.2 15/23] target/openrisc: Drop checks for singlestep_enabled

2021-07-21 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index d6ea536744..7e1aace63a 100644

[PATCH v6 2/5] hw/nvme: use symbolic names for registers

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen Add the NvmeBarRegs enum and use these instead of explicit register offsets. Signed-off-by: Klaus Jensen Reviewed-by: Gollu Appalanaidu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Keith Busch --- include/block/nvme.h | 29 -

[PATCH v6 1/5] hw/nvme: split pmrmsc register into upper and lower

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen The specification uses a set of 32 bit PMRMSCL and PMRMSCU registers to make up the 64 bit logical PMRMSC register. Make it so. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 31 --- hw/nvme/ctrl.c | 10 ++ 2 files changed,

[PATCH v6 0/5] hw/nvme: fix mmio read

2021-07-21 Thread Klaus Jensen
From: Klaus Jensen Fix mmio read issues on big-endian hosts. The core issue is that values in the BAR is not stored in little endian as required. Fix that and add a regression test for this. This required a bit of cleanup, so it blew up into a series. v6: * "hw/nvme: split pmrmsc register

[PATCH] usb: fix usb-host dependency check

2021-07-21 Thread Gerd Hoffmann
Fixes: 627302afb2f8 ("usb: build usb-host as module") Reported-by: Programmingkid Signed-off-by: Gerd Hoffmann --- hw/usb/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/meson.build b/hw/usb/meson.build index 3ca61279374d..de853d780dd8 100644 ---

[PATCH v3 4/4] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-07-21 Thread David Hildenbrand
virtio-mem logically plugs/unplugs memory within a sparse memory region and notifies via the RamDiscardManager interface when parts become plugged (populated) or unplugged (discarded). Currently, we end up (via the two users) 1) zeroing all logically unplugged/discarded memory during TPM resets.

[PATCH v2 12/13] ui/vdagent: send release when no clipboard owner

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index bc8347f995..efb4546045 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -345,6 +345,24 @@

[PATCH v2 10/13] ui/vdagent: use qemu_clipboard_info helper

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index 362064213c..bc8347f995 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -47,7 +47,6 @@

Re: [PATCH for-6.2 10/23] target/m68k: Drop checks for singlestep_enabled

2021-07-21 Thread Laurent Vivier
Le 21/07/2021 à 08:41, Richard Henderson a écrit : > GDB single-stepping is now handled generically. > > Signed-off-by: Richard Henderson > --- > target/m68k/translate.c | 44 + > 1 file changed, 9 insertions(+), 35 deletions(-) > > diff --git

Re: [PATCH v3 2/4] vhost-user-rng-pci: Add vhost-user-rng-pci implementation

2021-07-21 Thread Alex Bennée
Mathieu Poirier writes: > This patch provides a PCI bus interface to the vhost-user-rng backed. > The implentation is similar to what was done for vhost-user-i2c-pci and > vhost-user-fs-pci. > > Signed-off-by: Mathieu Poirier > diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build >

Re: [PATCH v6 6/6] hmp: add virtio commands

2021-07-21 Thread Jonah Palmer
On 7/13/21 10:40 PM, Jason Wang wrote: 在 2021/7/12 下午6:35, Jonah Palmer 写道: +void hmp_virtio_queue_status(Monitor *mon, const QDict *qdict) +{ +    Error *err = NULL; +    const char *path = qdict_get_try_str(qdict, "path"); +    int queue = qdict_get_int(qdict, "queue"); +    VirtQueueStatus

Re: [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-21 Thread Paolo Bonzini
On 20/07/21 14:53, Markus Armbruster wrote: When migrate_add_blocker(blocker, ) is followed by Just a nit, Paolo error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). This is the case in vfio_migration_probe().

[PATCH v2 6/6] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots

2021-07-21 Thread David Hildenbrand
We already don't ever migrate memory that corresponds to discarded ranges as managed by a RamDiscardManager responsible for the mapped memory region of the RAMBlock. virtio-mem uses this mechanism to logically unplug parts of a RAMBlock. Right now, we still populate zeropages for the whole usable

[PATCH 2/2] Revert "qxl: add migration blocker to avoid pre-save assert"

2021-07-21 Thread Gerd Hoffmann
This reverts commit 86dbcdd9c7590d06db89ca256c5eaf0b4aba8858. The pre-save assert is gone now, so the migration blocker is not needed any more. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.h | 1 - hw/display/qxl.c | 31 --- 2 files changed, 32 deletions(-)

[PATCH 0/2] qxl: remove assert and migration blocker

2021-07-21 Thread Gerd Hoffmann
Gerd Hoffmann (2): qxl: remove assert in qxl_pre_save. Revert "qxl: add migration blocker to avoid pre-save assert" hw/display/qxl.h | 1 - hw/display/qxl.c | 35 +++ 2 files changed, 3 insertions(+), 33 deletions(-) -- 2.31.1

[PATCH for-6.1? v2 0/3] linux-aio: limit the batch size to reduce queue latency

2021-07-21 Thread Stefano Garzarella
Since it's a performance regression, if possible we could include it in 6.1-rc1. There shouldn't be any particular criticism. v1: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01526.html v2: - s/bacth/batch/ [stefanha] - limit the batch with the number of available events

[PATCH for-6.1? v2 2/3] iothread: add aio-max-batch parameter

2021-07-21 Thread Stefano Garzarella
The `aio-max-batch` parameter will be propagated to AIO engines and it will be used to control the maximum number of queued requests. When there are in queue a number of requests equal to `aio-max-batch`, the engine invokes the system call to forward the requests to the kernel. This parameter

Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-21 Thread Paolo Bonzini
On 20/07/21 03:00, Eric Blake wrote: Deceptively simple; all the work was in the previous patch writing up the forwarding visitor. I still wonder if Kevin's QAPI aliases will do this more gracefully, but if we're trying to justify this as a bug fix worthy of 6.1, this is certainly a smaller

[PATCH v2 19/22] target/loongarch: Add disassembler

2021-07-21 Thread Song Gao
This patch add support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao --- MAINTAINERS |1 + disas/loongarch.c | 2511 +++ disas/meson.build |1 + include/disas/dis-asm.h |2 + meson.build

[PATCH v2 08/22] target/loongarch: Add fixed point shift instruction translation

2021-07-21 Thread Song Gao
This patch implement fixed point shift instruction translation. This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao --- target/loongarch/insns.decode | 26 +++

[PATCH v2 11/22] target/loongarch: Add fixed point atomic instruction translation

2021-07-21 Thread Song Gao
This patch implement fixed point atomic instruction translation. This includes: - LL.{W/D}, SC.{W/D} - AM{SWAP/ADD/AND/OR/XOR/MAX/MIN}[_DB].{W/D} - AM{MAX/MIN}[_DB].{WU/DU} Signed-off-by: Song Gao --- target/loongarch/insns.decode | 44 + target/loongarch/trans.inc.c | 210

[PATCH v2 09/22] target/loongarch: Add fixed point bit instruction translation

2021-07-21 Thread Song Gao
This patch implement fixed point bit instruction translation. This includes: - EXT.W.{B/H} - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} - BYTEPICK.{W/D} - REVB.{2H/4H/2W/D} - REVH.{2W/D} - BITREV.{4B/8B}, BITREV.{W/D} - BSTRINS.{W/D}, BSTRPICK.{W/D} - MASKEQZ, MASKNEZ Signed-off-by: Song Gao ---

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-21 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/20/21 11:53 PM, Philippe Mathieu-Daudé wrote: >> On 7/20/21 11:08 PM, Richard Henderson wrote: >>> On 7/20/21 10:56 AM, Peter Maydell wrote: On Tue, 20 Jul 2021 at 20:54, Richard Henderson wrote: > > This will allow a breakpoint hack to

[PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-21 Thread Song Gao
This patch add main translation routines and basic functions for translation. Signed-off-by: Song Gao --- target/loongarch/helper.h| 10 + target/loongarch/op_helper.c | 27 +++ target/loongarch/translate.c | 485 +++ target/loongarch/translate.h |

[PATCH v2 17/22] target/loongarch: Add floating point load/store instruction translation

2021-07-21 Thread Song Gao
This patch implement floating point load/store instruction translation. This includes: - FLD.{S/D}, FST.{S/D} - FLDX.{S/D}, FSTX.{S/D} - FLD{GT/LE}.{S/D}, FST{GT/LE}.{S/D} Signed-off-by: Song Gao --- target/loongarch/insns.decode | 24 target/loongarch/trans.inc.c | 257

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 11:54:45AM +0200, Gerd Hoffmann wrote: > > ObjectClass *module_object_class_by_name(const char *typename) > > { > > ObjectClass *oc; > > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_class_by_name(const char > > *typename) > > oc =

[PATCH v6 02/33] block: introduce blk_replace_bs

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Add function to change bs inside blk. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/sysemu/block-backend.h | 1 + block/block-backend.c | 8 2 files changed, 9 insertions(+) diff --git a/include/sysemu/block-backend.h

[PATCH v6 15/33] block/copy-before-write: cbw_init(): rename variables

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
One more step closer to real .bdrv_open() handler: use more usual names for bs being initialized and its state. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/copy-before-write.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-)

[PATCH v6 09/33] block/backup: move cluster size calculation to block-copy

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
The main consumer of cluster-size is block-copy. Let's calculate it here instead of passing through backup-top. We are going to publish copy-before-write filter soon, so it will be created through options. But we don't want for now to make explicit option for cluster-size, let's continue to

[PATCH v6 13/33] block/copy-before-write: bdrv_cbw_append(): replace child at last

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Refactor the function to replace child at last. Thus we don't need to revert it and code is simplified. block-copy state initialization being done before replacing the child doesn't need any drained section. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz ---

[PATCH v6 31/33] iotests/image-fleecing: rename tgt_node

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Actually target of backup(sync=None) is not a final backup target: image fleecing is intended to be used with external tool, which will copy data from fleecing node to some real backup target. Also, we are going to add a test case for "push backup with fleecing", where instead of exporting

[PATCH v6 17/33] block/copy-before-write: bdrv_cbw_append(): drop unused compress arg

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.h | 1 - block/backup.c| 2 +- block/copy-before-write.c | 7 +++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/block/copy-before-write.h b/block/copy-before-write.h index

[PATCH v6 22/33] qapi: publish copy-before-write filter

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- qapi/block-core.json | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 675d8265eb..59d3e5e42d 100644 --- a/qapi/block-core.json

Re: [PATCH] This is a test mail

2021-07-21 Thread Peter Maydell
On Wed, 21 Jul 2021 at 00:53, Shuuichirou Ishii wrote: > > This is a test mail to check the behavior of my mail > because it is not listed in the ML of qemu-devel. > I may send several test mails. > > I apologize and thank you for your patience. > > Shuuichirou Ishii (1): > This is a test mail

[PATCH v6 25/33] iotests.py: VM: add own __enter__ method

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
In superclass __enter__ method is defined with return value type hint 'QEMUMachine'. So, mypy thinks that return value of VM.__enter__ is QEMUMachine. Let's redefine __enter__ in VM class, to give it correct type hint. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz ---

  1   2   3   4   >