Re: [RFC PATCH v4 4/4] Enable custom CSR logic for Andes AX25 and A25

2021-08-06 Thread Bin Meng
On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai wrote: > > From: Ruinalnd ChuanTzu Tsai > > In this patch we enabled custom CSR logic for Andes AX25 and A25 logic. > Hence csr_andes.inc.c and andes_cpu_bits.h is added. > > Signed-off-by: Dylan Jhong > --- > target/riscv/andes_cpu_bits.h

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread David Hildenbrand
According to the PoP: "When the enhanced-DAT facility 1 is not installed, or when the facility is installed but the multiple-block control is zero, general register R 2 contains a real address. When the enhanced-DAT facility 1 is installed and the multiple-block control is one, gen-

Re: [PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro

2021-08-06 Thread David Hildenbrand
On 06.08.21 06:15, Thomas Huth wrote: On 05/08/2021 21.34, Eduardo Habkost wrote: Use the SCLP_EVENT_BUS macro instead of manually calling OBJECT_CHECK. Signed-off-by: Eduardo Habkost --- Cc: Cornelia Huck Cc: Thomas Huth Cc: Halil Pasic Cc: Christian Borntraeger Cc: Richard Henderson

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Qiang Liu
On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: > > On 04/08/2021 08.51, Qiang Liu wrote: > > xlnx_dp_read allows an out-of-bounds read at its default branch because > > of an improper index. > > > > According to > >

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread Thomas Huth
On 06/08/2021 09.34, David Hildenbrand wrote: On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At least in the kernel people will

Re: [PATCH v1 02/12] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: The last bit has to be ignored. Signed-off-by: David Hildenbrand --- target/s390x/tcg/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index

Re: [PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-06 Thread David Hildenbrand
On 06.08.21 04:46, Eduardo Habkost wrote: We have a SCLPEventsBus struct type defined, but no QOM type checkers are declared for the type. Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and have a SCLP_EVENT_BUS typecast wrapper defined. Signed-off-by: Eduardo Habkost --- Changes

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: The access type is unused. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 0620b1803e..167f1b1455

Re: [PATCH 1/2] virtio: add a way to disable a queue

2021-08-06 Thread Jason Wang
在 2021/8/2 下午4:42, Laurent Vivier 写道: On 02/08/2021 06:50, Jason Wang wrote: 在 2021/7/30 上午3:19, Laurent Vivier 写道: Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue by setting vring.num to 0 (or num_default). This is needed to be able to disable a guest driver from

Re: [PATCH v1 02/12] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE

2021-08-06 Thread Thomas Huth
On 06/08/2021 08.19, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: The last bit has to be ignored. Signed-off-by: David Hildenbrand ---   target/s390x/tcg/mem_helper.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/tcg/mem_helper.c

Re: [PATCH v1 02/12] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE

2021-08-06 Thread David Hildenbrand
On 06.08.21 08:25, Thomas Huth wrote: On 06/08/2021 08.19, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: The last bit has to be ignored. Signed-off-by: David Hildenbrand ---   target/s390x/tcg/mem_helper.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: For RRBE, SSKE, and ISKE, we're dealing with real addresses, so we have to convert to an absolute address first. Signed-off-by: David Hildenbrand --- target/s390x/tcg/mem_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-06 Thread 蔡傳資
Hi Bin and Alistair, >> +#if defined(CONFIG_RISCV_CUSTOM) >> +static void setup_custom_csr(CPURISCVState *env, >> + riscv_custom_csr_operations csr_map_struct[] >> + ) { >{ should be put to the next line, per QEMU coding convention.

[PATCH] net/colo: check vnet_hdr_support flag when using virtio-net

2021-08-06 Thread Tao Xu
When COLO use only one vnet_hdr_support parameter between COLO network filter(filter-mirror, filter-redirector or filter-rewriter and colo-compare, packet will not be parsed correctly. Acquire network driver related to COLO, if it is nirtio-net, check vnet_hdr_support flag of COLO network filter

Re: [PATCH v7 08/10] qapi: Use 'if': { 'any': ... } where appropriate

2021-08-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 5, 2021 at 5:57 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Signed-off-by: Marc-André Lureau >> > Reviewed-by: Stefan Hajnoczi >> > Tested-by: John Snow >> > Reviewed-by: Markus

Re: [PATCH 1/2] virtio: add a way to disable a queue

2021-08-06 Thread Laurent Vivier
On 06/08/2021 08:25, Jason Wang wrote: > > 在 2021/8/2 下午4:42, Laurent Vivier 写道: >> On 02/08/2021 06:50, Jason Wang wrote: >>> 在 2021/7/30 上午3:19, Laurent Vivier 写道: Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue by setting vring.num to 0 (or num_default).

Re: [PATCH v1 06/12] s390x/mmu_helper: fixup mmu_translate() documentation

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Looks like we forgot to adjust documentation of one parameter. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/mmu_helper.c

How does qemu detect the completion of interrupt execution?

2021-08-06 Thread Duo jia
I am simulating a device. When an interrupt occurs, another interrupt comes, and the second interrupt will not be triggered because the first interrupt has not yet finished. I want to know whether qemu can detect whether the interrupt has been executed, will there be a callback here? Or how can I

Re: [PATCH v7 09/10] qapi: add 'not' condition operation

2021-08-06 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > For the sake of completeness, introduce the 'not' condition. > > Signed-off-by: Marc-André Lureau > --- [...] > diff --git a/tests/qapi-schema/enum-if-invalid.err > b/tests/qapi-schema/enum-if-invalid.err > index

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread Thomas Huth
On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the multiple-block    control is zero, general register R 2 contains a real    address. When the enhanced-DAT facility 1 is   

Re: [PATCH] Use EGL device extension in display initialization.

2021-08-06 Thread Marc-André Lureau
Hi On Fri, Aug 6, 2021 at 2:28 AM Eugene Huang wrote: > This patch enables running generic EGL devices such as Nvidia’s in > headless mode. It assumes single device. More work is needed to support > multiple devices. > > > > Signed-off-by: Eugene Huang > Thanks for the patch. It isn't

Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-06 Thread Bin Meng
On Fri, Aug 6, 2021 at 2:08 PM Ruinland Chuan-Tzu Tsa(蔡傳資) wrote: > > > Hi Bin and Alistair, > > > >> +#if defined(CONFIG_RISCV_CUSTOM) > >> +static void setup_custom_csr(CPURISCVState *env, > >> + riscv_custom_csr_operations csr_map_struct[] > >> +

Re: [PATCH for-6.2 3/6] s390-sclp-events-bus: Set instance_size

2021-08-06 Thread David Hildenbrand
On 05.08.21 21:34, Eduardo Habkost wrote: We have a SCLPEventsBus struct defined, but the struct is not used at the TypeInfo definition. This works today but will break silently if anybody adds a new field to SCLPEventsBus. Set instance_size properly to avoid problems in the future.

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Thomas Huth
On 06/08/2021 09.00, Qiang Liu wrote: On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: On 04/08/2021 08.51, Qiang Liu wrote: xlnx_dp_read allows an out-of-bounds read at its default branch because of an improper index. According to

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:11, Thomas Huth wrote: On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the multiple-block    control is zero, general register R 2 contains a real    address.

Re: [RESEND RFC] hw/arm/smmuv3: add device properties to disable cached iotlb

2021-08-06 Thread chenxiang (M)
Hi Eric, 在 2021/8/5 16:10, Eric Auger 写道: Hi Chenxiang, On 8/5/21 9:48 AM, chenxiang (M) wrote: Hi Eric, 在 2021/8/5 0:26, Eric Auger 写道: Hi Chenxiang, On 8/4/21 10:49 AM, chenxiang wrote: From: Xiang Chen It splits invalidations into ^2 range invalidations in the patch 6d9cd115b("

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:22, Thomas Huth wrote: On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute

Re: [PATCH v1 11/12] hw/s390x/s390-skeys: check if an address is valid before dumping the key

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's validate the given address and report a proper error in case it's not. All call paths now properly check the validity of the given GFN. Remove the TODO. The errors inside the getter and setter should only trigger if something really goes wrong

Re: [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2

2021-08-06 Thread Pankaj Gupta
> >> In the real SMP hardware topology world, it's much more likely that > >> we have high cores-per-socket counts and few sockets totally. While > >> the current preference of sockets over cores in smp parsing results > >> in a virtual cpu topology with low cores-per-sockets counts and a > >>

[PATCH for-6.2 v3 01/12] job: Context changes in job_completed_txn_abort()

2021-08-06 Thread Max Reitz
Finalizing the job may cause its AioContext to change. This is noted by job_exit(), which points at job_txn_apply() to take this fact into account. However, job_completed() does not necessarily invoke job_txn_apply() (through job_completed_txn_success()), but potentially also

[PATCH for-6.2 v3 00/12] mirror: Handle errors after READY cancel

2021-08-06 Thread Max Reitz
Hi, v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00705.html v2 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00747.html Changes in v3: - Patch 1: After adding patch 11, I got a failed assertion in tests/unit/test-block-iothread

[PATCH for-6.2 v3 10/12] mirror: Stop active mirroring after force-cancel

2021-08-06 Thread Max Reitz
Once the mirror job is force-cancelled (job_is_cancelled() is true), we should not generate new I/O requests. This applies to active mirroring, too, so stop it once the job is cancelled. (We must still forward all I/O requests to the source, though, of course, but those are not really I/O

[PATCH for-6.2 v3 11/12] mirror: Do not clear .cancelled

2021-08-06 Thread Max Reitz
Clearing .cancelled before leaving the main loop when the job has been soft-cancelled is no longer necessary since job_is_cancelled() only returns true for jobs that have been force-cancelled. Therefore, this only makes a differences in places that call job_cancel_requested(). In block/mirror.c,

Re: How does qemu detect the completion of interrupt execution?

2021-08-06 Thread Peter Maydell
On Fri, 6 Aug 2021 at 07:24, Duo jia wrote: > I am simulating a device. When an interrupt occurs, another interrupt > comes, and the second interrupt will not be triggered because the > first interrupt has not yet finished. > > I want to know whether qemu can detect whether the interrupt has been

Re: intermittent failure, s390 host, x86-64 guest, vhost-user-blk test

2021-08-06 Thread Peter Maydell
On Thu, 5 Aug 2021 at 18:39, Peter Maydell wrote: > > On Wed, 4 Aug 2021 at 15:33, Peter Maydell wrote: > > > > On Wed, 4 Aug 2021 at 14:43, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 04, 2021 at 01:40:37PM +0100, Peter Maydell wrote: > > > > Saw this intermittent as part of my ad-hoc CI

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 19:42:35 +0530 (IST) Ani Sinha wrote: > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > On Thu, 5 Aug 2021, Igor Mammedov wrote: > > > > > > > On Mon, 26 Jul 2021 22:27:43 +0530 > > > > Ani Sinha wrote: > > >

Re: [PATCH v7 09/10] hw/arm/virt: add ITS support in virt GIC

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:01 -0400 Shashi Mallela wrote: > Included creation of ITS as part of virt platform GIC > initialization. This Emulated ITS model now co-exists with kvm > ITS and is enabled in absence of kvm irq kernel support in a > platform. > > Signed-off-by: Shashi Mallela >

Re: [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2

2021-08-06 Thread wangyanan (Y)
On 2021/8/6 12:41, Pankaj Gupta wrote: In the real SMP hardware topology world, it's much more likely that we have high cores-per-socket counts and few sockets totally. While the current preference of sockets over cores in smp parsing results in a virtual cpu topology with low cores-per-sockets

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the

Re: [PATCH for-6.1 v5 1/1] machine: Disallow specifying topology parameters as zero

2021-08-06 Thread wangyanan (Y)
A gentle ping ... Will this patch be picked up soon for 6.1 or is there anything else to tweak? Thanks, Yanan On 2021/7/23 17:57, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it

[PATCH for-6.2 v3 05/12] job: @force parameter for job_cancel_sync{, _all}()

2021-08-06 Thread Max Reitz
Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass force=true. The replication block driver

[PATCH for-6.2 v3 04/12] job: Force-cancel jobs in a failed transaction

2021-08-06 Thread Max Reitz
When a transaction is aborted, no result matters, and so all jobs within should be force-cancelled. Signed-off-by: Max Reitz --- job.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/job.c b/job.c index 3fe23bb77e..24e7c4fcb7 100644 --- a/job.c +++ b/job.c @@ -766,7

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 06/08/2021 10.23, David Hildenbrand wrote: On 06.08.21 10:22, Thomas Huth wrote: On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real().

Re: [PATCH v1 11/12] hw/s390x/s390-skeys: check if an address is valid before dumping the key

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:53, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: Let's validate the given address and report a proper error in case it's not. All call paths now properly check the validity of the given GFN. Remove the TODO. The errors inside the getter and setter should only

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's enable storage keys lazily under TCG, just as we do under KVM. Only fairly old Linux versions actually make use of storage keys, so it can be kind of wasteful to allocate quite some memory and track changes and references if nobody cares. We

[PATCH for-6.2 v3 09/12] mirror: Check job_is_cancelled() earlier

2021-08-06 Thread Max Reitz
We must check whether the job is force-cancelled early in our main loop, most importantly before any `continue` statement. For example, we used to have `continue`s before our current checking location that are triggered by `mirror_flush()` failing. So, if `mirror_flush()` kept failing,

[PATCH for-6.2 v3 12/12] iotests: Add mirror-ready-cancel-error test

2021-08-06 Thread Max Reitz
Test what happens when there is an I/O error after a mirror job in the READY phase has been cancelled. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy --- .../tests/mirror-ready-cancel-error | 143 ++

Re: [RFC PATCH v4 3/4] Adding Andes AX25 and A25 CPU model

2021-08-06 Thread 蔡傳資
Hi Bin and Alistair, >> Adding Andes AX25 and A25 CPU model into cpu.h and cpu.c without > The latest RISC-V core from Andes is AX45 and A45. Should we just > support the latest one? Maybe we can have them all ? AX25 and A25 is still in production, and we still have new clients using these CPU

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At least in the kernel people will really complain if you do that (because it

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:36, Thomas Huth wrote: On 06/08/2021 09.34, David Hildenbrand wrote: On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size check. Interestingly, we're already

Re: [PATCH v1 09/12] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's use the guest_phys_blocks API to get physical memory regions that are well defined inside our physical address space and migrate the storage keys of these. This is a prepearation for having memory besides initial ram defined in

Re: [PATCH v1 10/12] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Handle it similar to migration. Assert that we're holding the BQL, to make sure we don't see concurrent modifications. Signed-off-by: David Hildenbrand --- hw/s390x/s390-skeys.c | 50 ++- 1 file changed,

Re: Win32 and ACCEL macro/function

2021-08-06 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 11:00:24PM -0400, Eduardo Habkost wrote: > Hello, > > I'm looking for help dealing with a naming conflict when building > QEMU for Windows hosts. > > The summary is: I'm trying to replace the ACCEL() macro in > include/qemu/accel.h with an inline function, but the ACCEL

[PULL 0/2] Linux user for 6.1 patches

2021-08-06 Thread Laurent Vivier
to 030912e01c0385b6b09e76549c1a8a04b624f49a: linux-user/elfload: byteswap i386 registers when dumping core (2021-08-05 12:17:30 +0200) linux-user pull request 20210806 Fix endianness and addresses in i386 linux-user target

[PULL 1/2] linux-user: fix guest/host address mixup in i386 setup_rt_frame()

2021-08-06 Thread Laurent Vivier
From: Ilya Leoshkevich setup_rt_frame() passes siginfo and ucontext host addresses to guest signal handlers, causing problems when e.g. emulating x86_64 on s390x. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20210803171858.148394-1-...@linux.ibm.com>

[PATCH for-6.2 v3 07/12] job: Add job_cancel_requested()

2021-08-06 Thread Max Reitz
Most callers of job_is_cancelled() actually want to know whether the job is on its way to immediate termination. For example, we refuse to pause jobs that are cancelled; but this only makes sense for jobs that are really actually cancelled. A mirror job that is cancelled during READY with

[PATCH for-6.2 v3 02/12] mirror: Keep s->synced on error

2021-08-06 Thread Max Reitz
An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only that they were at some point (and at

[PATCH for-6.2 v3 03/12] mirror: Drop s->synced

2021-08-06 Thread Max Reitz
As of HEAD^, there is no meaning to s->synced other than whether the job is READY or not. job_is_ready() gives us that information, too. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin

[PATCH for-6.2 v3 08/12] mirror: Use job_is_cancelled()

2021-08-06 Thread Max Reitz
mirror_drained_poll() returns true whenever the job is cancelled, because "we [can] be sure that it won't issue more requests". However, this is only true for force-cancelled jobs, so use job_is_cancelled(). Signed-off-by: Max Reitz --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH v4 3/4] Adding Andes AX25 and A25 CPU model

2021-08-06 Thread Bin Meng
On Fri, Aug 6, 2021 at 2:12 PM Ruinland Chuan-Tzu Tsa(蔡傳資) wrote: > > Hi Bin and Alistair, > > >> Adding Andes AX25 and A25 CPU model into cpu.h and cpu.c without > > > The latest RISC-V core from Andes is AX45 and A45. Should we just > > support the latest one? > > Maybe we can have them all ? >

Re: [RFC PATCH 00/13] Support UXL field in mstatus

2021-08-06 Thread Alistair Francis
On Thu, Aug 5, 2021 at 5:15 PM LIU Zhiwei wrote: > > > On 2021/8/5 下午2:01, Alistair Francis wrote: > > On Thu, Aug 5, 2021 at 12:55 PM LIU Zhiwei wrote: > >> This patch set implements UXL field in mstatus register. Programmer can > >> change > >> UXLEN by writting to this field. So that you can

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:13:21 -0400 "Michael S. Tsirkin" wrote: > On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote: > > Also to be noted that there is a stub for acpi_get_i386_pci_host() which > > simply returns NULL. This activates when CONFIG_PC is disabled. It is this > > stub that

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-08-06 Thread Joao Martins
[sorry for the thread necromancy -- got preempted in other stuff and am slowly coming back to this] On 6/28/21 3:32 PM, Igor Mammedov wrote: > On Wed, 23 Jun 2021 14:04:19 +0100 > Joao Martins wrote: > >> On 6/23/21 12:39 PM, Igor Mammedov wrote: >>> On Wed, 23 Jun 2021 10:37:38 +0100 >>> Joao

Re: [PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 15:34:26 -0400 Eduardo Habkost wrote: > The macro never worked and never will, because the > AcpiGedX86State type never existed. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc:

Re: [PATCH for-6.2 6/6] Use PCI_HOST_BRIDGE macro

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 15:34:31 -0400 Eduardo Habkost wrote: > OBJECT_CHECK(PciHostState, ..., TYPE_PCI_HOST_BRIDGE) is exactly > what the PCI_HOST_BRIDGE macro does. We can just use the macro > instead of using OBJECT_CHECK manually. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size check. Interestingly, we're already

Re: [PATCH v1 08/12] s390x/mmu_helper: avoid setting the storage key if nothing changed

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Avoid setting the key if nothing changed. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index

[PULL 2/2] linux-user/elfload: byteswap i386 registers when dumping core

2021-08-06 Thread Laurent Vivier
From: Ilya Leoshkevich Core dumps from emulating x86_64 on big-endian hosts contain incorrect register values. Signed-off-by: Ilya Leoshkevich Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210803172013.148446-1-...@linux.ibm.com> Signed-off-by: Laurent Vivier

[PATCH for-6.2 v3 06/12] jobs: Give Job.force_cancel more meaning

2021-08-06 Thread Max Reitz
We largely have two cancel modes for jobs: First, there is actual cancelling. The job is terminated as soon as possible, without trying to reach a consistent result. Second, we have mirror in the READY state. Technically, the job is not really cancelled, but it just is a different completion

Re: [PATCH v8] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-08-06 Thread Ilya Leoshkevich
On Fri, 2021-08-06 at 07:25 +0200, Thomas Huth wrote: > On 05/08/2021 00.51, Ilya Leoshkevich wrote: > > Verify that s390x-specific uc_mcontext.psw.addr is reported > > correctly > > and that signal handling interacts properly with debugging. > > > > Signed-off-by: Ilya Leoshkevich > > --- > >

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Ani Sinha
On Fri, 6 Aug 2021, Igor Mammedov wrote: > On Thu, 5 Aug 2021 19:42:35 +0530 (IST) > Ani Sinha wrote: > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > > > > > On Thu, 5 Aug 2021, Igor Mammedov wrote: > > > > > > > > >

[PATCH v1 4/4] gitlab-ci: Fix ..._RUNNER_AVAILABLE variables and document them

2021-08-06 Thread Alex Bennée
From: Thomas Huth The patch that recently introduced the S390X_RUNNER_AVAILABLE variable in custom-runners.yml missed that the bottom half of the file is rather about aarch64 than s390x. Thus rename the S390X_RUNNER_AVAILABLE to AARCH64_RUNNER_AVAILABLE in those jobs. Finally mention both

[PATCH v1 2/4] gitlab-ci: Merge "build-disabled" with "build-without-default-features"

2021-08-06 Thread Alex Bennée
From: Thomas Huth Both jobs are testing more or less the same thing (building QEMU with features disabled), so we are wasting precious CI cycles here by doing this twice. Merge the jobs by using --without-default-features by default and just adding some additional --disable-... switches which

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Thomas Huth
On 06/08/2021 16.13, Cornelia Huck wrote: On Fri, Aug 06 2021, David Hildenbrand wrote: On 06.08.21 11:42, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: -static void qemu_s390_skeys_init(Object *obj) +static int qemu_s390_skeys_enabled(S390SKeysState *ss) { -

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread Philippe Mathieu-Daudé
On 8/6/21 1:30 PM, David Hildenbrand wrote: > On 06.08.21 13:19, Cornelia Huck wrote: >> On Thu, Aug 05 2021, David Hildenbrand wrote: >> >>> schib->pmcw.chars is 32bit, not 16bit. This fixes the kvm-unit-tests >>> "css" test, which fails with: >>> >>>    FAIL: Channel Subsystem: measurement

[PATCH] vhost-user: add missing space in error message

2021-08-06 Thread Alyssa Ross
This would previously give error messages like > Received unexpected msg type.Expected 0 received 1 Signed-off-by: Alyssa Ross --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 16:17, Philippe Mathieu-Daudé wrote: >> On 8/6/21 1:30 PM, David Hildenbrand wrote: >>> On 06.08.21 13:19, Cornelia Huck wrote: On Thu, Aug 05 2021, David Hildenbrand wrote: > schib->pmcw.chars is 32bit, not 16bit. This

[PATCH] meson: fix logic for gnutls check

2021-08-06 Thread Alyssa Ross
The logic before was if not get_option('gnutls').auto() or have_system Which is equivalent to if get_option('gnutls').enabled() or get_option('gnutls').disabled() or have_system This means that the check for gnutls is performed even if gnutls is disabled, which means that the

Re: [PATCH v3 03/10] virtiofsd: Use lo_inode_open() instead of openat()

2021-08-06 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:27PM +0200, Max Reitz wrote: > The xattr functions want a non-O_PATH FD, so they reopen the lo_inode.fd > with the flags they need through /proc/self/fd. > > Similarly, lo_opendir() needs an O_RDONLY FD. Instead of the > /proc/self/fd trick, it just uses openat(fd,

Re: [PATCH 1/6] docs/about/removed-features: Document removed CLI options from QEMU v2.12

2021-08-06 Thread Paolo Bonzini
On 06/08/21 17:10, Thomas Huth wrote: + +``-no-kvm-pit`` (removed in 2.12) +' + +There is no replacement, since this was just a dummy option that has been +ignored. The same effect (plus also disabling the KVM IOAPIC) can be obtained with "-M

[PATCH v2 1/7] docs/devel: create "Community & Governance" subsection

2021-08-06 Thread John Snow
Plonk the Code of Conduct and Conflict Resolution Policy guides into a new "Community & Governance" subsection. Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell --- docs/devel/index.rst| 3 +-- docs/devel/section-community-governance.rst | 9

[PATCH v2 4/7] docs/devel: create TCG subsection

2021-08-06 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell --- docs/devel/index.rst | 6 +- docs/devel/section-tcg.rst | 12 2 files changed, 13 insertions(+), 5 deletions(-) create mode 100644 docs/devel/section-tcg.rst diff --git

[PATCH v1 1/4] plugins/execlog: removed unintended "s" at the end of log lines.

2021-08-06 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210803151428.125323-1-ma.mando...@gmail.com> --- contrib/plugins/execlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 11:42, Thomas Huth wrote: >> On 05/08/2021 17.28, David Hildenbrand wrote: >>> -static void qemu_s390_skeys_init(Object *obj) >>> +static int qemu_s390_skeys_enabled(S390SKeysState *ss) >>>{ >>> -QEMUS390SKeysState *skeys =

Re: [PATCH v3 01/10] virtiofsd: Limit setxattr()'s creds-dropped region

2021-08-06 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:25PM +0200, Max Reitz wrote: > We only need to drop/switch our credentials for the (f)setxattr() call > alone, not for the openat() or fchdir() around it. > > (Right now, this may not be that big of a problem, but with inodes being > identified by file handles

Re: [PATCH v3 02/10] virtiofsd: Add TempFd structure

2021-08-06 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:26PM +0200, Max Reitz wrote: > We are planning to add file handles to lo_inode objects as an > alternative to lo_inode.fd. That means that everywhere where we > currently reference lo_inode.fd, we will have to open a temporary file > descriptor that needs to be

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Alexander Bulekov
On 210804 1451, Qiang Liu wrote: > xlnx_dp_read allows an out-of-bounds read at its default branch because > of an improper index. > > According to > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html > (DP Module), registers 0x3A4/0x3A4/0x3AC are allowed. >

[PATCH 6/6] docs/about/removed-features: Document removed machines from older QEMU versions

2021-08-06 Thread Thomas Huth
These machines had been removed in the QEMU v2.6 up to 4.0 time frame. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index

[PATCH 5/6] docs/about/removed-features: Document removed devices from older QEMU versions

2021-08-06 Thread Thomas Huth
These devices had been removed/replaced in QEMU v2.12 and v4.0. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 568a2c725b..ffb82c4a99 100644

[PATCH 2/6] docs/about/removed-features: Document removed CLI options from QEMU v3.0

2021-08-06 Thread Thomas Huth
These CLI options had been removed/replaced in QEMU v3.0. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 35

Re: [PATCH] vhost-user: add missing space in error message

2021-08-06 Thread Laurent Vivier
Le 06/08/2021 à 16:39, Alyssa Ross a écrit : > This would previously give error messages like > >> Received unexpected msg type.Expected 0 received 1 > > Signed-off-by: Alyssa Ross > --- > hw/virtio/vhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] meson: fix logic for gnutls check

2021-08-06 Thread Paolo Bonzini
On 06/08/21 16:49, Alyssa Ross wrote: The logic before was if not get_option('gnutls').auto() or have_system Which is equivalent to if get_option('gnutls').enabled() or get_option('gnutls').disabled() or have_system This means that the check for gnutls is performed even if

Re: [PATCH 1/6] docs/about/removed-features: Document removed CLI options from QEMU v2.12

2021-08-06 Thread Paolo Bonzini
On 06/08/21 17:10, Thomas Huth wrote: + +``-no-kvm-pit`` (removed in 2.12) +' + +There is no replacement, since this was just a dummy option that has been +ignored. The same effect (plus also disabling the KVM IOAPIC) can be obtained with "-machine

[PATCH v2 0/7] docs/devel: Organize devel manual into further subsections

2021-08-06 Thread John Snow
It's a bit cluttered. On my way to converting the QAPI/QMP documents to ReST I thought it could do with another organizational level to help make sense of things a bit more quickly. V2: - Move decodetree into TCG subsection - Rebase, add QOM/QAPI/QMP docs into API subsection John Snow (7):

[PATCH v2 5/7] docs/devel: create "Subsystem APIs" subsection

2021-08-06 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell --- docs/devel/index.rst | 10 +- docs/devel/section-subsystems.rst | 16 2 files changed, 17 insertions(+), 9 deletions(-) create mode 100644 docs/devel/section-subsystems.rst

[PATCH v2 3/7] docs/devel: create "Testing & Debugging" subsection

2021-08-06 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell --- docs/devel/index.rst | 6 +- docs/devel/section-testing-debugging.rst | 12 2 files changed, 13 insertions(+), 5 deletions(-) create mode 100644

[PATCH v2 6/7] docs/devel: create "QEMU API" section

2021-08-06 Thread John Snow
Signed-off-by: John Snow --- docs/devel/index.rst | 4 +--- docs/devel/section-api.rst | 10 ++ 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 docs/devel/section-api.rst diff --git a/docs/devel/index.rst b/docs/devel/index.rst index b146ce00f7a..9f9e96204fc

[PATCH v2 2/7] docs/devel: create "Developing QEMU" subsection

2021-08-06 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell --- docs/devel/index.rst | 6 +- docs/devel/section-development.rst | 12 2 files changed, 13 insertions(+), 5 deletions(-) create mode 100644 docs/devel/section-development.rst diff

  1   2   3   >