Re: [PATCH 07/12] mac_via: move VIA1 reset logic from mac_via_reset() to mos6522_q800_via1_reset()

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > After this change mac_via_reset() is now empty and can be removed. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH 08/12] mac_via: move VIA1 realize logic from mac_via_realize() to mos6522_q800_via1_realize()

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c | 86 --- > 1 file changed, 44 insertions(+), 42 deletions(-) > Reviewed-by: Laurent Vivier

Re: [PATCH 10/12] mac_via: remove explicit viaN prefix from VIA IRQ gpios

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > Now that q800 VIA1 and VIA2 are completely separate devices there is no need > to > add a specific device prefix to ensure that the IRQ lines remain separate. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/q800.c| 10 -- >

Re: [PATCH 0/5] qapi: Another round of minor fixes and cleanups

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 8:54 AM Markus Armbruster wrote: > Markus Armbruster (5): > qapi: Fix a botched type annotation > qapi: Drop Indentation.__bool__() > qapi: Bury some unused code in class Indentation > tests/qapi-schema: Cover 'not' condition with empty argument > qapi: Fix

Re: [PATCH 06/12] mac_via: move q800 VIA1 timer variables to q800 VIA1 VMStateDescription

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > These variables are already present in MOS6522Q800VIA1State and so it is just > the VMStateDescription move that is needed. > > With this change the mac_via VMStateDescription is now empty and can be > removed > completely. > > Signed-off-by:

Re: [PATCH 05/12] mac_via: move ADB variables to MOS6522Q800VIA1State

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > The ADB is accessed using clock and data pins on q800 VIA1 port B and so can > be > moved to MOS6522Q800VIA1State. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/q800.c| 6 +- > hw/misc/mac_via.c | 169

Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction

2021-09-08 Thread Richard Henderson
On 9/8/21 6:54 AM, Alistair Francis wrote: @@ -967,6 +967,16 @@ void riscv_cpu_do_interrupt(CPUState *cs) write_tval = true; tval = env->badaddr; break; +case RISCV_EXCP_ILLEGAL_INST: +if (riscv_feature(env,

Re: [PATCH 04/12] mac_via: move PRAM/RTC variables to MOS6522Q800VIA1State

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > The PRAM/RTC is accessed using clock and data pins on q800 VIA1 port B and so > can be moved to MOS6522Q800VIA1State. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c | 135 +++--- >

Re: [PATCH 03/12] mac_via: move PRAM contents and block backend to MOS6522Q800VIA1State

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > The PRAM contents are accessed using clock and data pins on q800 VIA1 port B > and so can be moved to MOS6522Q800VIA1State. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c | 59 --- >

Re: [PATCH 02/12] mac_via: move last_b variable into q800 VIA1 VMStateDescription

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > This variable is already present in MOS6522Q800VIA1State and can be moved > immediately into the q800 VIA1 VMStateDescription. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 01/12] mac_via: introduce new VMStateDescription for q800 VIA1 and VIA2

2021-09-08 Thread Laurent Vivier
Le 30/08/2021 à 12:24, Mark Cave-Ayland a écrit : > Move the parent mos6522 objects from vmstate_mac_via into the new > VMStateDescription > structures to begin the process of splitting MacVIAState into separate VIA1 > and > VIA2 devices. > > Signed-off-by: Mark Cave-Ayland > --- >

Re: [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug

2021-09-08 Thread Igor Mammedov
On Wed, 8 Sep 2021 09:41:39 +0530 Ani Sinha wrote: > Change caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to > Q35") > selects an IO address range for acpi based PCI hotplug for q35 arbitrarily. It > starts at address 0x0cc4 and ends at 0x0cdb. It was assumed that this

Re: [PATCH v6 09/12] target/hexagon: import parser for idef-parser

2021-09-08 Thread Richard Henderson
On 9/7/21 8:08 PM, Taylor Simpson wrote: diff --git a/target/hexagon/idef-parser/parser-helpers.h b/target/hexagon/idef-parser/parser-helpers.h +#define OUT_IMPL(c, locp, x)\ +_Generic(*x,\ +char: str_print, \

Re: [PATCH] hw/ssi: imx_spi: Improve chip select handling

2021-09-08 Thread Bin Meng
On Wed, Sep 8, 2021 at 2:29 PM Bin Meng wrote: > > On Sun, Sep 5, 2021 at 10:08 AM Guenter Roeck wrote: > > > > On 9/4/21 4:19 PM, Philippe Mathieu-Daudé wrote: > > > On 9/5/21 1:06 AM, Bin Meng wrote: > > >> On Sun, Sep 5, 2021 at 1:13 AM Guenter Roeck wrote: > > >>> > > >>> On 9/2/21 12:29

Re: [PATCH] hw/ssi: imx_spi: Improve chip select handling

2021-09-08 Thread Bin Meng
On Sun, Sep 5, 2021 at 10:08 AM Guenter Roeck wrote: > > On 9/4/21 4:19 PM, Philippe Mathieu-Daudé wrote: > > On 9/5/21 1:06 AM, Bin Meng wrote: > >> On Sun, Sep 5, 2021 at 1:13 AM Guenter Roeck wrote: > >>> > >>> On 9/2/21 12:29 PM, Peter Maydell wrote: > On Thu, 2 Sept 2021 at 17:09,

Re: [PATCH v2 1/3] target/riscv: Set the opcode in DisasContext

2021-09-08 Thread Richard Henderson
On 9/8/21 6:54 AM, Alistair Francis wrote: From: Alistair Francis Signed-off-by: Alistair Francis --- target/riscv/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index e356fc6c46..25670be435

Re: [PATCH v4 2/4] hw/intc: Upgrade the SiFive CLINT implementation to RISC-V ACLINT

2021-09-08 Thread Bin Meng
On Tue, Aug 31, 2021 at 7:07 PM Anup Patel wrote: > > The RISC-V ACLINT is more modular and backward compatible with > original SiFive CLINT so instead of duplicating the original > SiFive CLINT implementation we upgrade the current SiFive CLINT > implementation to RISC-V ACLINT implementation. >

Re: [PATCH] fuzz: fix unbound variable in build.sh

2021-09-08 Thread Paolo Bonzini
On 07/09/21 13:08, Alexander Bulekov wrote: -if [ "$GITLAB_CI" != "true" ]; then +if [ -z ${GITLAB_CI+x} ]; then I would slightly prefer to have "${GITLAB_CI+x}", since "test" in general doesn't like parameters that go away: $ [ = abc ] bash: [: =: unary operator expected What you wrote

Re: [qemu-web RFC] CONTRIBUTING.md: Mention maintainers

2021-09-08 Thread Paolo Bonzini
On 07/09/21 15:40, Thomas Huth wrote: we should maybe have a pointer to the information on https://www.qemu.org/contribute/ instead? Yes - right now contribute/ links to the old blog post for "Improve the web site", but I guess it couuld just go to

Re: [PATCH v4 00/33] Qemu SGX virtualization

2021-09-08 Thread Paolo Bonzini
On 07/09/21 11:51, Yang Zhong wrote: Paolo, I have moved hmp and qmp codes to target/i386/monitor.c and also fixed the issue with test tool(tests/qtest/test-hmp). This issue is caused by 'machine none' test in the hmp, the previous patches only covered qmp test in 'machine none'

<    1   2   3   4