Re: [PATCH v4 10/33] i386: Add get/set/migrate support for SGX_LEPUBKEYHASH MSRs

2021-09-14 Thread Philippe Mathieu-Daudé
On 7/19/21 1:21 PM, Yang Zhong wrote: > From: Sean Christopherson > > On real hardware, on systems that supports SGX Launch Control, those > MSRs are initialized to digest of Intel's signing key; on systems that > don't support SGX Launch Control, those MSRs are not available but > hardware

Re: [PATCH v4 04/33] i386: Add 'sgx-epc' device to expose EPC sections to guest

2021-09-14 Thread Philippe Mathieu-Daudé
On 7/19/21 1:21 PM, Yang Zhong wrote: > From: Sean Christopherson > > SGX EPC is enumerated through CPUID, i.e. EPC "devices" need to be > realized prior to realizing the vCPUs themselves, which occurs long > before generic devices are parsed and realized. Because of this, > do not allow

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: > On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: > > Add a page listing QEMU sponsors and displaying their logos. > > > > Logo sources: > > - https://www.rackspace.com/es/newsroom/media-kit > > -

Re: [PATCH v3 08/10] qcow2-refcount: improve style of check_refcounts_l1()

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: - use g_autofree for l1_table - better name for size in bytes variable - reduce code blocks nesting - whitespaces, braces, newlines Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 98

Re: [RFC PATCH 2/7] accel/tcg: Split out adjust_signal_pc

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 12:05 AM, Richard Henderson wrote: > Split out a function to adjust the raw signal pc into a > value that could be passed to cpu_restore_state. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 8 +++ > accel/tcg/user-exec.c | 50

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 7:41 AM, Thomas Huth wrote: > On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: >> Add a page listing QEMU sponsors and displaying their logos. >> >> Logo sources: >> - https://www.rackspace.com/es/newsroom/media-kit >> - https://developer.arm.com/solutions/infrastructure/works-on-arm

Re: [PULL 0/6] Vga 20210910 patches

2021-09-14 Thread Gerd Hoffmann
On Fri, Sep 10, 2021 at 05:52:55PM +0100, Peter Maydell wrote: > On Fri, 10 Sept 2021 at 14:19, Gerd Hoffmann wrote: > > > > The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2: > > > > Merge remote-tracking branch > > 'remotes/mcayland/tags/qemu-openbios-20210908' into

Re: [PATCH 03/22] qapi: Convert simple union KeyValue to flat one

2021-09-14 Thread Gerd Hoffmann
On Mon, Sep 13, 2021 at 02:39:13PM +0200, Markus Armbruster wrote: > Simple unions predate flat unions. Having both complicates the QAPI > schema language and the QAPI generator. We haven't been using simple > unions in new code for a long time, because they are less flexible and > somewhat

Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 07:17:11AM +0200, Thomas Huth wrote: > On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote: > > Without the webrick bundle, jekyll fails to start: > > > >$ bundle exec jekyll serve > >Ignoring ffi-1.11.1 because its extensions are not built. Try: gem > > pristine

Re: [RFC PATCH 3/7] accel/tcg: Split out handle_sigsegv_accerr_write

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 12:05 AM, Richard Henderson wrote: > This is the major portion of handle_cpu_signal which is specific > to tcg, handling the page protections for the translations. > Most of the rest will migrate to linux-user/ shortly. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
13.09.2021 14:16, Hanna Reitz wrote: On 20.07.21 13:38, Vladimir Sementsov-Ogievskiy wrote: Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy ---  

Re: [PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Hanna Reitz
On 14.09.21 09:44, Vladimir Sementsov-Ogievskiy wrote: 13.09.2021 14:16, Hanna Reitz wrote: On 20.07.21 13:38, Vladimir Sementsov-Ogievskiy wrote: Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course.

Re: [PATCH v2] docs: add supported host CPU architectures section

2021-09-14 Thread Marc-André Lureau
Hi On Mon, Sep 13, 2021 at 6:28 PM Peter Maydell wrote: > On Mon, 13 Sept 2021 at 14:10, wrote: > > > > From: Marc-André Lureau > > > > I was looking for such documentation, but couldn't find it. Add it to > > the build-platform.rst document. > > > > Signed-off-by: Marc-André Lureau > > ---

Re: [PATCH v3 4/6] qapi: Apply aliases in qobject-input-visitor

2021-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.09.2021 um 17:16 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > When looking for an object in a struct in the external representation, >> > check not only the currently visited struct, but also whether an alias >> > in the current StackObject

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 10:20 AM, Daniel P. Berrangé wrote: > On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: >> On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: >>> Add a page listing QEMU sponsors and displaying their logos. >>> >>> Logo sources: >>> -

Re: [PATCH v6 2/6] spapr_numa.c: scrap 'legacy_numa' concept

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:35 -0300 Daniel Henrique Barboza wrote: > When first introduced, 'legacy_numa' was a way to refer to guests that > either wouldn't be affected by associativity domain calculations, namely > the ones with only 1 NUMA node, and pre 5.2 guests that shouldn't be > affected

Re: [RFC PATCH 1/7] include/exec: Move cpu_signal_handler declaration

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 12:05 AM, Richard Henderson wrote: > There is nothing target specific about this. The implementation > is host specific, but the declaration is 100% common. Same as v3 ;) https://www.mail-archive.com/qemu-devel@nongnu.org/msg830412.html Reviewed-by: Philippe Mathieu-Daudé >

Re: [PATCH v4 00/33] Qemu SGX virtualization

2021-09-14 Thread Philippe Mathieu-Daudé
On 7/19/21 1:21 PM, Yang Zhong wrote: > This series is Qemu SGX virtualization implementation rebased on latest > Qemu release. The numa support for SGX will be sent in another patchset > once this basic SGX patchset are merged. > backends/hostmem-epc.c | 118 ++ >

Re: [PATCH V2] util: Remove redundant checks in the openpty()

2021-09-14 Thread Alex Chen
Hi all, This patch has been reviewed by Peter. who can help merge it? Thanks, Alex On 2020/11/2 18:55, AlexChen wrote: > As we can see from the following function call stack, amaster and aslave > can not be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). > In addition, according to

Re: [PATCH v3 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: We'll reuse the function to fix wrong L2 entry bitmap. Support it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 18 +++--- 1 file changed, 15 insertions(+), 3

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.09.2021 um 17:28 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > +/* Can still specify the real member name with alias support */ >> > +v = visitor_input_test_init(data, "{ 'foo': 42 }"); >> > +visit_type_AliasStruct1(v, NULL, , _abort); >> >

[PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Cédric Le Goater
The current way the mask is built can overflow with a 64-bit decrementer. Use sextract64() instead. Cc: Luis Fernando Fujita Pires Fixes: a8dafa525181 ("target/ppc: Implement large decrementer support for TCG") Signed-off-by: Cédric Le Goater --- v2: replaced MAKE_64BIT_MASK by sextract64

Re: [PATCH v3 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) Reviewed-by:

Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 7:17 AM, Thomas Huth wrote: > On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote: >> Without the webrick bundle, jekyll fails to start: >> >>    $ bundle exec jekyll serve >>    Ignoring ffi-1.11.1 because its extensions are not built. Try: gem >> pristine ffi --version 1.11.1 >>   

Re: [PATCH v4 23/33] sgx-epc: Add the reset interface for sgx-epc virt device

2021-09-14 Thread Philippe Mathieu-Daudé
On 7/19/21 1:21 PM, Yang Zhong wrote: > If the VM is reset, we need make sure sgx virt epc in clean status. > Once the VM is reset, and sgx epc virt device will be reseted by > reset callback registered by qemu_register_reset(). Since this epc > virt device depend on backend, this reset will call

Re: [PATCH v6 1/6] spapr_numa.c: split FORM1 code into helpers

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:34 -0300 Daniel Henrique Barboza wrote: > The upcoming FORM2 NUMA affinity will support asymmetric NUMA topologies > and doesn't need be concerned with all the legacy support for older > pseries FORM1 guests. > > We're also not going to calculate associativity domains

[PATCH v3 00/17] iotests: support zstd

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
These series makes tests pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). v3: 02-04,06,08,14,17: add Hanna's r-b 07 iotests.py: filter out successful output of qemu-img create fix subject handle 149, 237 and 296

[PATCH v3 09/17] iotest 302: use img_info_log() helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default

[PATCH v3 08/17] iotests.py: filter compression type out

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type

[PATCH v3 12/17] iotests: massive use _qcow2_dump_header

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts)

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-14 Thread Stefano Garzarella
On Mon, Sep 13, 2021 at 09:46:48AM -0400, Michael S. Tsirkin wrote: On Mon, Sep 13, 2021 at 02:51:42PM +0200, Stefano Garzarella wrote: On Fri, Sep 10, 2021 at 02:35:53AM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 09, 2021 at 10:02:12AM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 09,

[PATCH v3 16/17] iotest 214: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/214 | 2 +-

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Cédric Le Goater
Hello Peter D, > +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) > +{ > +MachineClass *mc = MACHINE_CLASS(oc); > +AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc); > + > +mc->desc = "Facebook Fuji BMC (Cortex-A7)"; > +amc->soc_name = "ast2600-a3"; > +

[PULL 0/5] Migration.next patches

2021-09-14 Thread Juan Quintela
The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Peter Delevoryas
> On Sep 14, 2021, at 3:56 AM, Cédric Le Goater wrote: > >  > Hello Peter D, > >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) >> +{ >> +MachineClass *mc = MACHINE_CLASS(oc); >> +AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc); >> + >> +mc->desc =

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 14:46, Hanna Reitz wrote: On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero  

[PATCH 1/3] target/arm: Don't skip M-profile reset entirely in user mode

2021-09-14 Thread Peter Maydell
Currently all of the M-profile specific code in arm_cpu_reset() is inside a !defined(CONFIG_USER_ONLY) ifdef block. This is unintentional: it happened because originally the only M-profile-specific handling was the setup of the initial SP and PC from the vector table, which is system-emulation

[PATCH v4 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Split checking for reserved bits out of aligned offset check. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 10 +- 2 files changed, 10 insertions(+), 1

Re: [PATCH 2/3] hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35

2021-09-14 Thread Igor Mammedov
On Tue, 14 Sep 2021 10:24:09 +0530 Ani Sinha wrote: > Change caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to > Q35") > selects an IO address range for acpi based PCI hotplug for q35 arbitrarily. It > starts at address 0x0cc4 and ends at 0x0cdb. At the time when the patch

Re: [PATCH 3/3] bios-tables-test: Update ACPI DSDT table golden blobs for q35

2021-09-14 Thread Igor Mammedov
On Tue, 14 Sep 2021 10:24:10 +0530 Ani Sinha wrote: > We have modified the IO address range for ACPI pci hotplug in q35. See change: > > 36f98d0d4f ("hw/i386/acpi: fix conflicting IO address range for acpi pci > hotplug in q35") > > The ACPI DSDT table golden blobs must be regenrated in order

[PULL 0/5] Misc patches

2021-09-14 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) are available in the Git repository at:

[PULL 3/5] chardev: Propagate error from logfile opening

2021-09-14 Thread marcandre . lureau
From: Michal Privoznik If a chardev has a logfile the file is opened using qemu_open_old() which does the job, but since @errp is not propagated into qemu_open_internal() we lose much more accurate error and just report "Unable to open logfile $errno". When using plain files, it's probably okay

[PATCH v3 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/iotests.py | 36 +-- 1

[PATCH v3 06/17] iotest 065: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz ---

[PATCH v3 15/17] iotests 60: more accurate set dirty bit in qcow2 header

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of two parts of the bitmap   - for unallocated all

Re: [RFC v3 12/32] rust: provide a common crate for QEMU

2021-09-14 Thread Marc-André Lureau
Hi Paolo On Mon, Sep 13, 2021 at 9:18 PM Paolo Bonzini wrote: > On 07/09/21 14:19, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This crates provides common bindings and facilities for QEMU C API > > shared by various projects. > > > > Most importantly, it defines the

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of

Re: [PATCH v6 3/6] spapr: introduce spapr_numa_associativity_reset()

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:36 -0300 Daniel Henrique Barboza wrote: > Introducing a new NUMA affinity, FORM2, requires a new mechanism to > switch between affinity modes after CAS. Also, we want FORM2 data > structures and functions to be completely separated from the existing > FORM1 code,

[PATCH v4 01/10] qcow2-refcount: improve style of check_refcounts_l2()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
- don't use same name for size in bytes and in entries - use g_autofree for l2_table - add whitespace - fix block comment style Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 47

[PATCH v4 03/10] qcow2: introduce qcow2_parse_compressed_l2_entry() helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Add helper to parse compressed l2_entry and use it everywhere instead of open-coding. Note, that in most places we move to precise coffset/csize instead of sector-aligned. Still it should work good enough for updating refcounts. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Stefan Hajnoczi
On Tue, Sep 14, 2021 at 10:26:45AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 10:20 AM, Daniel P. Berrangé wrote: > > On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: > >> On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: > >>> Add a page listing QEMU sponsors and displaying

[PATCH v5 05/21] target/loongarch: Add fixed point shift instruction translation

2021-09-14 Thread Song Gao
This patch implement fixed point shift instruction translation. This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang ---

[PATCH v5 08/21] target/loongarch: Add fixed point atomic instruction translation

2021-09-14 Thread Song Gao
This patch implement fixed point atomic instruction translation. This includes: - LL.{W/D}, SC.{W/D} - AM{SWAP/ADD/AND/OR/XOR/MAX/MIN}[_DB].{W/D} - AM{MAX/MIN}[_DB].{WU/DU} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- target/loongarch/insn_trans/trans_atomic.c | 133

[PATCH v5 04/21] target/loongarch: Add fixed point arithmetic instruction translation

2021-09-14 Thread Song Gao
This patch implement fixed point arithemtic instruction translation. This includes: - ADD.{W/D}, SUB.{W/D} - ADDI.{W/D}, ADDU16ID - ALSL.{W[U]/D} - LU12I.W, LU32I.D LU52I.D - SLT[U], SLT[U]I - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I - AND, OR, NOR, XOR, ANDN, ORN - MUL.{W/D}, MULH.{W[U]/D[U]} -

[PATCH v5 17/21] LoongArch Linux User Emulation

2021-09-14 Thread Song Gao
Implementation of linux user emulation for LoongArch. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- accel/tcg/user-exec.c | 15 ++ configure | 5 + include/elf.h | 2 + linux-user/elfload.c

[PATCH v5 10/21] target/loongarch: Add floating point arithmetic instruction translation

2021-09-14 Thread Song Gao
This patch implement floating point arithmetic instruction translation. This includes: - F{ADD/SUB/MUL/DIV}.{S/D} - F{MADD/MSUB/NMADD/NMSUB}.{S/D} - F{MAX/MIN}.{S/D} - F{MAXA/MINA}.{S/D} - F{ABS/NEG}.{S/D} - F{SQRT/RECIP/RSQRT}.{S/D} - F{SCALEB/LOGB/COPYSIGN}.{S/D} - FCLASS.{S/D} Signed-off-by:

Re: [PATCH 0/3] target/arm: Set FPSCR.LTPSIZE for user-mode

2021-09-14 Thread Richard Henderson
On 9/14/21 5:07 AM, Peter Maydell wrote: Peter Maydell (3): target/arm: Don't skip M-profile reset entirely in user mode target/arm: Always clear exclusive monitor on reset target/arm: Consolidate ifdef blocks in reset Reviewed-by: Richard Henderson r~

[PATCH v5 11/21] target/loongarch: Add floating point comparison instruction translation

2021-09-14 Thread Song Gao
This patch implement floating point comparison instruction translation. This includes: - FCMP.cond.{S/D} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- target/loongarch/fpu_helper.c| 60 target/loongarch/helper.h| 9 +

Re: [PATCH v5 05/21] target/loongarch: Add fixed point shift instruction translation

2021-09-14 Thread Richard Henderson
On 9/14/21 6:00 AM, Song Gao wrote: This patch implement fixed point shift instruction translation. This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao Signed-off-by: XiaoJuan

Re: [PATCH] virtio-balloon: Fix page-poison subsection name

2021-09-14 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 14.09.21 15:17, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The subsection name for page-poison was typo'd as: > > > >vitio-balloon-device/page-poison > > > > Note the missing 'r' in virtio. > > > > When

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-14 Thread Hanna Reitz
On 19.08.21 12:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to the request alignment and where

Re: [PULL v4 00/23] target-arm queue

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 21:05, Peter Maydell wrote: > > v3->v4: Windows headers define an INT type which clashed > with an enum value name in arm_gicv3_its.c... > > The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: > > Merge remote-tracking branch

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-14 Thread Kevin Wolf
Am 14.09.2021 um 10:59 hat Markus Armbruster geschrieben: > >> > +/* You can't use more than one option at the same time */ > >> > +v = visitor_input_test_init(data, "{ 'foo': 42, 'nested': { 'foo': > >> > 42 } }"); > >> > +visit_type_AliasStruct3(v, NULL, , ); > >> > +

[PATCH v3 14/17] iotests: bash tests: filter compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir

Re: [PULL 00/14] aspeed queue

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 17:13, Cédric Le Goater wrote: > > The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-09-13' > into staging (2021-09-13 11:00:30 +0100) > > are available in the Git repository

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-14 Thread Michael S. Tsirkin
On Tue, Sep 14, 2021 at 12:42:09PM +0200, Stefano Garzarella wrote: > On Mon, Sep 13, 2021 at 09:46:48AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 13, 2021 at 02:51:42PM +0200, Stefano Garzarella wrote: > > > On Fri, Sep 10, 2021 at 02:35:53AM -0400, Michael S. Tsirkin wrote: > > > > On

[PATCH v4 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/block/qcow2.h b/block/qcow2.h index b8b1093b61..58fd7f1678

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 13:14, Joel Stanley wrote: > The upstream device tree uses 2G: > > https://elixir.bootlin.com/linux/v5.15-rc1/source/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi#L20 > > It's unfortunate we limit the defaults given very few (no one?) is > using this model on a

Re: [RFC v6] virtio/vsock: add two more queues for datagram types

2021-09-14 Thread Stefan Hajnoczi
On Mon, Sep 13, 2021 at 10:18:43PM +, Jiang Wang wrote: > Datagram sockets are connectionless and unreliable. > The sender does not know the capacity of the receiver > and may send more packets than the receiver can handle. > > Add two more dedicate virtqueues for datagram sockets, > so that

[PATCH v5 02/21] target/loongarch: Add core definition

2021-09-14 Thread Song Gao
This patch add target state header, target definitions and initialization routines. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- target/loongarch/cpu-param.h | 19 +++ target/loongarch/cpu.c | 285 +++ target/loongarch/cpu.h |

Re: [RFC PATCH v2] accel/tcg: re-factor plugin_inject_cb so we can assert insn_idx is valid

2021-09-14 Thread Richard Henderson
On 9/14/21 5:04 AM, Alex Bennée wrote: Coverity doesn't know enough about how we have arranged our plugin TCG ops to know we will always have incremented insn_idx before injecting the callback. Let us assert it for the benefit of Coverity and protect ourselves from accidentally breaking the

[PATCH v5 15/21] target/loongarch: Add branch instruction translation

2021-09-14 Thread Song Gao
This patch implement branch instruction translation. This includes: - BEQ, BNE, BLT[U], BGE[U] - BEQZ, BNEZ - B - BL - JIRL - BCEQZ, BCNEZ Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_branch.c | 85

[PULL 2/5] meson.build: fix comment typo

2021-09-14 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7d7d14a4bc..2711cbb789 100644 --- a/meson.build +++ b/meson.build @@ -78,7 +78,7 @@ endif

Re: [PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Richard Henderson
On 9/14/21 2:47 AM, Cédric Le Goater wrote: On 9/14/21 11:19 AM, Peter Maydell wrote: /* Truncate value to decr_width and sign extend for simplicity */ -value &= ((1ULL << nr_bits) - 1); +value = sextract64(value, 0, nr_bits); negative = !!(value & (1ULL << (nr_bits - 1)));

Re: Add a unit test to exercize support for ACPI hotplug on multifunction bridges in q35

2021-09-14 Thread Ani Sinha
Ping On Mon, Sep 6, 2021 at 15:09 Ani Sinha wrote: > Hi Igor/Michael : > > Added a unit test to exercize the following commit : > > d7346e614f4ec353 ("acpi: x86: pcihp: add support hotplug on multifunction > bridges") > > I had sent just the unit test earlier but since the review is getting >

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.09.2021 um 10:59 hat Markus Armbruster geschrieben: >> >> > +/* You can't use more than one option at the same time */ >> >> > +v = visitor_input_test_init(data, "{ 'foo': 42, 'nested': { 'foo': >> >> > 42 } }"); >> >> > +visit_type_AliasStruct3(v, NULL, ,

Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-14 Thread LIU Zhiwei
On 2021/9/11 下午10:00, Philipp Tomsich wrote: Assume clzw being executed on a register that is not sign-extended, such as for the following sequence that uses (1ULL << 63) | 392 as the operand to clzw: bseti a2, zero, 63 addia2, a2, 392 clzwa3, a2 The correct

Re: [qemu-web PATCH] Update FUSE block export blog post

2021-09-14 Thread Hanna Reitz
On 07.09.21 19:52, Eric Blake wrote: On Mon, Sep 06, 2021 at 06:29:16PM +0200, Hanna Reitz wrote: Because I forgot to CC Thomas on the discussion adding this post, it was merged prematurely. This patch updates the post to incorporate the feedback I received on it: Overall, nice! I see it's

Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-14 Thread Philipp Tomsich
On Tue 14. Sep 2021 at 11:15, LIU Zhiwei wrote: > > On 2021/9/11 下午10:00, Philipp Tomsich wrote: > > Assume clzw being executed on a register that is not sign-extended, such > > as for the following sequence that uses (1ULL << 63) | 392 as the operand > > to clzw: > > bseti a2, zero, 63

[PATCH v3 05/17] iotest 303: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/303

[PATCH v3 11/17] iotests/common.rc: introduce _qcow2_dump_header helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v3 5/6] qapi: Add support for aliases

2021-09-14 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 06.09.2021 um 17:24 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> >>> > Introduce alias definitions for object types (structs and unions). This >>> > allows using the same QAPI type and visitor for many syntax variations

Re: [PULL 00/14] aspeed queue

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 12:58 PM, Cédric Le Goater wrote: > On 9/14/21 12:51 PM, Peter Maydell wrote: >> On Mon, 13 Sept 2021 at 17:13, Cédric Le Goater wrote: >>> >>> The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: >>> >>> Merge remote-tracking branch

[PULL 1/5] multifd: Implement yank for multifd send side

2021-09-14 Thread Juan Quintela
From: Lukas Straub To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-09-01T17:58:57+0200 using

[RFC PATCH v2] accel/tcg: re-factor plugin_inject_cb so we can assert insn_idx is valid

2021-09-14 Thread Alex Bennée
Coverity doesn't know enough about how we have arranged our plugin TCG ops to know we will always have incremented insn_idx before injecting the callback. Let us assert it for the benefit of Coverity and protect ourselves from accidentally breaking the assumption and triggering harder to grok

[PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here are some good refactorings and new (qemu-img check) checks for qcow2. 06 qcow2-refcount: check_refcounts_l2(): check l2_bitmap don't fix unallocated cluster with allocated subclusters (no strong opinion how to do it correctly) drop Eric's r-b keep Kirill's t-b (I

[PATCH v4 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We'll reuse the function to fix wrong L2 entry bitmap. Support it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

[PATCH v4 04/10] qcow2-refcount: introduce fix_l2_entry_by_zero()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Split fix_l2_entry_by_zero() out of check_refcounts_l2() to be reused in further patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 87 +- 1 file changed, 60 insertions(+), 27

[PATCH v4 02/10] qcow2: compressed read: simplify cluster descriptor passing

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Let's pass the whole L2 entry and not bother with L2E_COMPRESSED_OFFSET_SIZE_MASK. It also helps further refactoring that adds generic qcow2_parse_compressed_l2_entry() helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Hanna

[PATCH v4 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index

[PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist

2021-09-14 Thread Thomas Huth
The virtiofsd currently crashes on s390x when doing something like this in the guest: mkdir -p /mnt/myfs mount -t virtiofs myfs /mnt/myfs touch /mnt/myfs/foo.txt stat -f /mnt/myfs/foo.txt The problem is that the fstatfs64 syscall is called in this case from the virtiofsd. We have to put it

[PATCH v4 08/10] qcow2-refcount: improve style of check_refcounts_l1()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
- use g_autofree for l1_table - better name for size in bytes variable - reduce code blocks nesting - whitespaces, braces, newlines Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 98 +- 1 file

Re: [PATCH v6 5/6] spapr: move FORM1 verifications to post CAS

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:38 -0300 Daniel Henrique Barboza wrote: > FORM2 NUMA affinity is prepared to deal with empty (memory/cpu less) > NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM > device that has a different latency than the original NUMA node from the > regular

Re: [PATCH v3] docs: add supported host CPU architectures section

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 13:25, wrote: > > From: Marc-André Lureau > > I was looking for such documentation, but couldn't find it. Add it to > the build-platform.rst document. > > Signed-off-by: Marc-André Lureau > --- > docs/about/build-platforms.rst | 33 + >

Re: [PATCH 1/3] bios-tables-test: allow changes in DSDT ACPI tables for q35

2021-09-14 Thread Igor Mammedov
On Tue, 14 Sep 2021 10:24:08 +0530 Ani Sinha wrote: > We are going to commit a change to fix IO address range allocated for acpi pci > hotplug in q35. This affects DSDT tables. This change allows DSDT table > modification so that unit tests are not broken. > > Signed-off-by: Ani Sinha

[PATCH v5 03/21] target/loongarch: Add main translation routines

2021-09-14 Thread Song Gao
This patch add main translation routines and basic functions for translation. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/helper.h| 9 +++ target/loongarch/internals.h | 1 - target/loongarch/op_helper.c | 22 ++

[PATCH v5 01/21] target/loongarch: Add README

2021-09-14 Thread Song Gao
This patch give an introduction to the LoongArch target. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- MAINTAINERS | 5 target/loongarch/README | 76 + 2 files changed, 81 insertions(+) create mode 100644

Re: [PATCH RFC v2 04/16] vfio-user: connect vfio proxy to remote server

2021-09-14 Thread Stefan Hajnoczi
On Mon, Sep 13, 2021 at 05:23:33PM +, John Johnson wrote: > >> On Sep 9, 2021, at 10:25 PM, John Johnson > >> wrote: > >>> On Sep 8, 2021, at 11:29 PM, Stefan Hajnoczi wrote: > >>> On Thu, Sep 09, 2021 at 05:11:49AM +, John Johnson wrote: > I did look at coroutines, but they

  1   2   3   4   >