[PATCH 27/30] tcg/loongarch: Register the JIT

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target.c.inc | 44 ++ 1 file changed, 44 insertions(+) diff --git a/tcg/loongarch/tcg-target.c.inc b/tcg/loongarch/tcg-target.c.inc index 107682e1fa..59adc92d26 100644 --- a/tcg/loongarch/tcg-target.c.inc +++

[PATCH 16/30] tcg/loongarch: Implement shl/shr/sar/rotl/rotr ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 1 + tcg/loongarch/tcg-target.c.inc | 91 ++ 2 files changed, 92 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index 417c97549a..8630d1ee6e

[PATCH 23/30] tcg/loongarch: Add softmmu load/store helpers, implement qemu_ld/qemu_st ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 2 + tcg/loongarch/tcg-target.c.inc | 344 + 2 files changed, 346 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index

[PATCH 06/30] tcg/loongarch: Define the operand constraints

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-str.h | 26 tcg/loongarch/tcg-target.c.inc | 48 ++ 2 files changed, 74 insertions(+) create mode 100644 tcg/loongarch/tcg-target-con-str.h diff --git

[PATCH 19/30] tcg/loongarch: Implement br/brcond ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 1 + tcg/loongarch/tcg-target.c.inc | 52 ++ 2 files changed, 53 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index 57b2846d82..bcbf0780ff

[PATCH 24/30] tcg/loongarch: Implement tcg_target_qemu_prologue

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target.c.inc | 66 ++ 1 file changed, 66 insertions(+) diff --git a/tcg/loongarch/tcg-target.c.inc b/tcg/loongarch/tcg-target.c.inc index 0b6f16bde0..10df007087 100644 --- a/tcg/loongarch/tcg-target.c.inc +++

[PATCH 02/30] MAINTAINERS: Add tcg/loongarch entry with myself as maintainer

2021-09-20 Thread WANG Xuerui
I wrote the initial code, so I should maintain it of course. Signed-off-by: WANG Xuerui --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6c20634d63..0e9942cc00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3109,6 +3109,11 @@ S: Maintained

[PATCH 13/30] tcg/loongarch: Implement deposit/extract ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 1 + tcg/loongarch/tcg-target.c.inc | 21 + 2 files changed, 22 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index 385f503552..b0751c4bb0 100644

[PATCH 11/30] tcg/loongarch: Implement sign-/zero-extension ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 1 + tcg/loongarch/tcg-target.c.inc | 82 ++ 2 files changed, 83 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index 5cc4407367..7e459490ea

[PATCH 17/30] tcg/loongarch: Implement neg/add/sub ops

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch/tcg-target-con-set.h | 2 ++ tcg/loongarch/tcg-target.c.inc | 47 ++ 2 files changed, 49 insertions(+) diff --git a/tcg/loongarch/tcg-target-con-set.h b/tcg/loongarch/tcg-target-con-set.h index 8630d1ee6e..58b5c487e2

Re: [PULL 00/35] tcg patch queue

2021-09-20 Thread Philippe Mathieu-Daudé
On 9/20/21 15:14, Philippe Mathieu-Daudé wrote: > On 9/20/21 12:07, Peter Maydell wrote: >> On Thu, 16 Sept 2021 at 16:30, Richard Henderson >> wrote: >>> >>> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: >>> >>> Merge remote-tracking branch

Re: [PATCH v2] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 14:38, Kevin Townsend wrote: > > Hi Peter, > > Thanks for the review, and sorry for the slow reply, just getting back from > holidays myself. > > On Thu, 26 Aug 2021 at 17:39, Peter Maydell wrote: >> >> >> So if I'm reading the datasheet correctly, the LM303DLHC is >>

Re: [PATCH v8 4/7] spapr_numa.c: rename numa_assoc_array to FORM1_assoc_array

2021-09-20 Thread Daniel Henrique Barboza
On 9/20/21 06:21, Greg Kurz wrote: On Fri, 17 Sep 2021 18:27:59 -0300 Daniel Henrique Barboza wrote: Introducing a new NUMA affinity, FORM2, requires a new mechanism to switch between affinity modes after CAS. Also, we want FORM2 data structures and functions to be completely separated

Re: [PATCH v6 02/10] ACPI ERST: specification for ERST support

2021-09-20 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:31 -0400 Eric DeVolder wrote: > Information on the implementation of the ACPI ERST support. > > Signed-off-by: Eric DeVolder modulo missing parts documentation looks good to but I'm tainted at this point (after so many reviews) so libvirt folks (CCed) can take look

Re: [PATCH v2] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-20 Thread Kevin Townsend
Hi Peter, Thanks for the review, and sorry for the slow reply, just getting back from holidays myself. On Thu, 26 Aug 2021 at 17:39, Peter Maydell wrote: > > So if I'm reading the datasheet correctly, the LM303DLHC is > really two completely distinct i2c devices in a single > package with

Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-09-20 Thread Richard Henderson
On 9/20/21 1:08 AM, Peter Maydell wrote: On Mon, 20 Sept 2021 at 02:29, Richard Henderson wrote: On 8/26/21 6:45 AM, Peter Maydell wrote: I don't think you should need to special case AArch64 vs AArch32 like this; you can do env->exception.vaddress = pc; env->exception.fsr =

Re: [PULL 00/21] riscv-to-apply queue

2021-09-20 Thread Peter Maydell
On Thu, 16 Sept 2021 at 22:49, Alistair Francis wrote: > > From: Alistair Francis > > The following changes since commit d1fe59377bbbf91dfded1f08ffe3c636e9db8dc0: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-6.2-pull-request' into staging > (2021-09-16 16:02:31

Re: [PULL 00/35] tcg patch queue

2021-09-20 Thread Richard Henderson
On 9/20/21 3:07 AM, Peter Maydell wrote: This seems to result in a failure on the s390x all-linux-static CI job: https://gitlab.com/qemu-project/qemu/-/jobs/1604251543 due to a core dump running the 'trap' test. Curious. I can't reproduce this on s390x.ci.qemu.org manually. r~

Re: [PATCH v12 00/10] hvf: Implement Apple Silicon Support

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 11:11, Peter Maydell wrote: > > On Thu, 16 Sept 2021 at 16:54, Alexander Graf wrote: > > > > Now that Apple Silicon is widely available, people are obviously excited > > to try and run virtualized workloads on them, such as Linux and Windows. > > > > This patch set

Re: [PULL 00/35] tcg patch queue

2021-09-20 Thread Philippe Mathieu-Daudé
On 9/20/21 12:07, Peter Maydell wrote: > On Thu, 16 Sept 2021 at 16:30, Richard Henderson > wrote: >> >> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: >> >> Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' >> into staging (2021-09-15

Re: [PATCH v6 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-09-20 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:30 -0400 Eric DeVolder wrote: > Following the guidelines in tests/qtest/bios-tables-test.c, this > change adds empty placeholder files per step 1 for the new ERST > table, and excludes resulting changed files in bios-tables-test-allowed-diff.h > per step 2. > I'd move

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-20 Thread Jose R. Ziviani
On Mon, Sep 20, 2021 at 07:15:32AM +0200, Gerd Hoffmann wrote: > Hi, > > > Yes, I really like your approach, makes more sense indeed. But, how do I > > get the core modules that other modules depend on? > > > > I see that Kconfig already has something in this line: > > > > config VGA (from

Re: [PATCH RESEND 2/2] memory: Add tracepoint for dirty sync

2021-09-20 Thread Paolo Bonzini
On 17/08/21 18:07, David Hildenbrand wrote: If we want to make it start/end pair, I can do that too.  But the 1st patch will still be wanted. Yeah, absolutely, not complaining about the name, it will be valuable to have! You could have start/end tracepoints for

Re: [PATCH RESEND 2/2] memory: Add tracepoint for dirty sync

2021-09-20 Thread Paolo Bonzini
On 17/08/21 18:05, Peter Xu wrote: I'm also wondering whether kvm-smram needs a whole bitmap as I don't know what RAM would be touched within system manager mode (as I thought it should only touch a very limited range and should be defined somewhere), but that's off-topic. The kvm-smram dirty

Re: [PATCH] target/i386: Fix memory leak in sev_read_file_base64()

2021-09-20 Thread Paolo Bonzini
On 20/08/21 19:05, Philippe Mathieu-Daudé wrote: On 8/20/21 6:56 PM, Peter Maydell wrote: In sev_read_file_base64() we call g_file_get_contents(), which allocates memory for the file contents. We then base64-decode the contents (which allocates another buffer for the decoded data), but forgot

Re: [PULL 00/35] tcg patch queue

2021-09-20 Thread Philippe Mathieu-Daudé
On 9/20/21 12:07, Peter Maydell wrote: > On Thu, 16 Sept 2021 at 16:30, Richard Henderson > wrote: >> >> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: >> >> Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' >> into staging (2021-09-15

[PATCH v2] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-20 Thread Eric Auger
The PL031 currently is not able to report guest RTC change to the QMP monitor as opposed to mc146818 or spapr RTCs. This patch adds the call to qapi_event_send_rtc_change() when the Load Register is written. The value which is reported corresponds to the difference between the guest reference time

RE: [PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread Luis Fernando Fujita Pires
From: Cédric Le Goater > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() to extract the signed values and remove the logic to handle > negative values which has become useless. > > Cc: Luis Fernando Fujita Pires > Fixes: a8dafa525181 ("target/ppc:

[PATCH 4/5] block: bdrv_insert_node(): don't use bdrv_open()

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Use bdrv_new_open_driver_opts() instead of complicated bdrv_open(). Among other extra things bdrv_open() also check for white-listed formats, which we don't want for internal node creation: currently backup doesn't work when copy-before-write filter is not white-listed. As well block-stream

Re: [PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-20 Thread Eric Auger
Hi Peter, On 9/16/21 8:24 PM, Peter Maydell wrote: > On Thu, 16 Sept 2021 at 18:19, Eric Auger wrote: >> Hi Peter, >> On 9/16/21 3:32 PM, Peter Maydell wrote: >>> None of the other users of qapi_event_send_rtc_change() >>> seem to have to track the baseline time like this. Shouldn't >>> this be

[PATCH 5/5] iotests/image-fleecing: declare requirement of copy-before-write

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Now test fails if copy-before-write is not white-listed. Let's skip test instead. Fixes: c0605985696a19ef034fa25d04f53f3b3b383896 Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/5] block: bdrv_insert_node(): doc and style

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
- options & flags is common pair for open-like functions, let's use it - add a comment that specifies use of @options Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index

[PATCH 2/5] block: bdrv_insert_node(): fix and improve error handling

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
- use ERRP_GUARD(): function calls error_prepend(), so it must use ERRP_GUARD(), otherwise error_prepend() would not be called when passed errp is error_fatal - drop error propagation, handle return code instead - for symmetry, do error_prepend() for the second failure Signed-off-by:

[PATCH 0/5] Fix not white-listed copy-before-write

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Hi all! As reported in https://bugzilla.redhat.com/show_bug.cgi?id=2004812 backup don't work when copy-before-write is not white-listed. Yes, we do need copy-before-write filter for backup to work (like we always use copy-on-read filter in block-stream). The problem is that in bdrv_insert_node()

[PATCH 1/5] block: implement bdrv_new_open_driver_opts()

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Add version of bdrv_new_open_driver() that supports QDict options. We'll use it in further commit. Simply add one more argument to bdrv_new_open_driver() is worse, as there are too many invocations of bdrv_new_open_driver() to update then. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [RFC PATCH] docs/specs: QMP configuration design specification

2021-09-20 Thread Mirela Grujic
Hi, We haven't got any feedback on this, anyone, please? Thanks, Mirela On 6/28/21 11:55 AM, Mirela Grujic wrote: Hi, While implementing a prototype we run into a couple of challenges. We're not sure whether our current implementation would be acceptable and whether there is a better

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
02.08.2021 21:54, Vladimir Sementsov-Ogievskiy wrote: Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting there BdrvChild objects. To be able to select any kind of

[PATCH v3 1/3] monitor/hmp: correctly invert password argument detection again

2021-09-20 Thread Stefan Reiter
Commit cfb5387a1d 'hmp: remove "change vnc TARGET" command' claims to remove the HMP "change vnc" command, but doesn't actually do that. Instead it rewires it to use 'qmp_change_vnc_password', and in the process inverts the argument detection - ignoring the first issue, this inversion is wrong, as

[PATCH v3 3/3] monitor: refactor set/expire_password and allow VNC display id

2021-09-20 Thread Stefan Reiter
It is possible to specify more than one VNC server on the command line, either with an explicit ID or the auto-generated ones à la "default", "vnc2", "vnc3", ... It is not possible to change the password on one of these extra VNC displays though. Fix this by adding a "display" parameter to the

[PATCH v3 0/3] VNC-related HMP/QMP fixes

2021-09-20 Thread Stefan Reiter
Since the removal of the generic 'qmp_change' command, one can no longer replace the 'default' VNC display listen address at runtime (AFAIK). For our users who need to set up a secondary VNC access port, this means configuring a second VNC display (in addition to our standard one for web-access),

[PATCH v3 2/3] monitor/hmp: add support for flag argument with value

2021-09-20 Thread Stefan Reiter
Adds support for the "-xS" parameter type, where "-x" denotes a flag name and the "S" suffix indicates that this flag is supposed to take an arbitrary string parameter. These parameters are always optional, the entry in the qdict will be omitted if the flag is not given. Signed-off-by: Stefan

how do I run a single acceptance test?

2021-09-20 Thread Peter Maydell
Hi; I'm trying to bisect a problem that's causing an acceptance test failure, but docs/devel/testing.rst doesn't have any info about how to run just one acceptance test rather than the whole lot via 'make check-acceptance'. Is this possible? (It's pretty slow to have to run the whole thing,

Re: [PATCH v12 00/10] hvf: Implement Apple Silicon Support

2021-09-20 Thread Peter Maydell
On Thu, 16 Sept 2021 at 16:54, Alexander Graf wrote: > > Now that Apple Silicon is widely available, people are obviously excited > to try and run virtualized workloads on them, such as Linux and Windows. > > This patch set implements a fully functional version to get the ball > going on that.

Re: [PULL 00/35] tcg patch queue

2021-09-20 Thread Peter Maydell
On Thu, 16 Sept 2021 at 16:30, Richard Henderson wrote: > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' > into staging (2021-09-15 18:55:59 +0100) > > are available in the Git

Re: [PULL 41/56] block/copy-before-write: make public block driver

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
20.09.2021 12:41, Kevin Wolf wrote: Am 01.09.2021 um 17:16 hat Hanna Reitz geschrieben: From: Vladimir Sementsov-Ogievskiy Finally, copy-before-write gets own .bdrv_open and .bdrv_close handlers, block_init() call and becomes available through bdrv_open(). To achieve this: - cbw_init gets

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2021-09-20 Thread Christian Ehrhardt 
Yeah Sebastian, a new ticket (with a reference to this bug as being similar) would be preferred. ** Changed in: qemu (Ubuntu) Assignee: Christian Ehrhardt  (paelzer) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Thanks a lot for reviewing! 20.09.2021 09:44, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting

Re: [PATCH RFC 1/5] qapi: Enable enum member introspection to show more than name

2021-09-20 Thread Peter Krempa
On Mon, Sep 20, 2021 at 11:08:59 +0200, Markus Armbruster wrote: > Peter Krempa writes: > > > On Wed, Sep 15, 2021 at 21:24:21 +0200, Markus Armbruster wrote: > >> The next commit will add feature flags to enum members. There's a > >> problem, though: query-qmp-schema shows an enum type's

Re: [PULL 41/56] block/copy-before-write: make public block driver

2021-09-20 Thread Kevin Wolf
Am 01.09.2021 um 17:16 hat Hanna Reitz geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Finally, copy-before-write gets own .bdrv_open and .bdrv_close > handlers, block_init() call and becomes available through bdrv_open(). > > To achieve this: > > - cbw_init gets unused flags argument

Re: [PATCH v8 5/7] spapr: move FORM1 verifications to post CAS

2021-09-20 Thread Greg Kurz
On Fri, 17 Sep 2021 18:28:00 -0300 Daniel Henrique Barboza wrote: > FORM2 NUMA affinity is prepared to deal with empty (memory/cpu less) > NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM > device that has a different latency than the original NUMA node from the > regular

Re: [PATCH v8 4/7] spapr_numa.c: rename numa_assoc_array to FORM1_assoc_array

2021-09-20 Thread Greg Kurz
On Fri, 17 Sep 2021 18:27:59 -0300 Daniel Henrique Barboza wrote: > Introducing a new NUMA affinity, FORM2, requires a new mechanism to > switch between affinity modes after CAS. Also, we want FORM2 data > structures and functions to be completely separated from the existing > FORM1 code,

Re: [PATCH v12 06/10] hvf: arm: Implement -cpu host

2021-09-20 Thread Peter Maydell
On Thu, 16 Sept 2021 at 17:08, Philippe Mathieu-Daudé wrote: > > On 9/16/21 5:54 PM, Alexander Graf wrote: > > Now that we have working system register sync, we push more target CPU > > properties into the virtual machine. That might be useful in some > > situations, but is not the typical case

Re: [PATCH RFC 1/5] qapi: Enable enum member introspection to show more than name

2021-09-20 Thread Markus Armbruster
Peter Krempa writes: > On Wed, Sep 15, 2021 at 21:24:21 +0200, Markus Armbruster wrote: >> The next commit will add feature flags to enum members. There's a >> problem, though: query-qmp-schema shows an enum type's members as an >> array of member names (SchemaInfoEnum member @values). If it

Re: [PATCH v3 3/6] target/arm: Take an exception if PC is misaligned

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 03:48, Richard Henderson wrote: > > For A64, any input to an indirect branch can cause this. > > For A32, many indirect branch paths force the branch to be aligned, > but BXWritePC does not. This includes the BX instruction but also > other interworking changes to PC.

Re: [PATCH] block/file-posix: Limit max_iov to IOV_MAX

2021-09-20 Thread Daniel P . Berrangé
CC'ing qemu-block list On Sat, Sep 18, 2021 at 12:06:58PM +0800, lishan wrote: > AIO read/write. The size of iocb->aio_nbytes in the kernel cannot exceed > UIO_MAXIOV = 1024. > max_segments read from the block device layer may be greater than UIO_MAXIOV, > this causes the ioq_submit interface to

Re: [PATCH RFC 1/5] qapi: Enable enum member introspection to show more than name

2021-09-20 Thread Markus Armbruster
Eric Blake writes: > On Wed, Sep 15, 2021 at 09:24:21PM +0200, Markus Armbruster wrote: >> The next commit will add feature flags to enum members. There's a >> problem, though: query-qmp-schema shows an enum type's members as an >> array of member names (SchemaInfoEnum member @values). If it

Re: [PATCH v8 3/7] spapr_numa.c: parametrize FORM1 macros

2021-09-20 Thread Greg Kurz
On Fri, 17 Sep 2021 18:27:58 -0300 Daniel Henrique Barboza wrote: > The next preliminary step to introduce NUMA FORM2 affinity is to make > the existing code independent of FORM1 macros and values, i.e. > MAX_DISTANCE_REF_POINTS, NUMA_ASSOC_SIZE and VCPU_ASSOC_SIZE. This patch > accomplishes

Re: [PULL 0/2] virtiofs queue

2021-09-20 Thread Peter Maydell
On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' > into staging (2021-09-15

Re: [PATCH v3 07/10] tests/acpi: add test cases for VIOT

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:20:02 +0100 Jean-Philippe Brucker wrote: > Add two test cases for VIOT, one on the q35 machine and the other on > virt. To test complex topologies the q35 test has two PCIe buses that > bypass the IOMMU (and are therefore not described by VIOT), and two > buses that are

Re: [PATCH v3 01/10] hw/acpi: Add VIOT table

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:19:56 +0100 Jean-Philippe Brucker wrote: > Add a function that generates a Virtual I/O Translation table (VIOT), > describing the topology of paravirtual IOMMUs. The table is created when > instantiating a virtio-iommu device. It contains a virtio-iommu node and > PCI

[PULL 13/14] hw/arm/aspeed: Allow machine to set UART default

2021-09-20 Thread Cédric Le Goater
From: Peter Delevoryas When you run QEMU with an Aspeed machine and a single serial device using stdio like this: qemu -machine ast2600-evb -drive ... -serial stdio The guest OS can read and write to the UART5 registers at 0x1E784000 and it will receive from stdin and write to stdout. The

Re: [PATCH v3 10/10] tests/acpi: add expected VIOT blob for q35 machine

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:20:05 +0100 Jean-Philippe Brucker wrote: > The VIOT table generated for the q35 test is: I'd squash this into previous patch > [000h 4]Signature : "VIOT"[Virtual I/O > Translation Table] > [004h 0004 4] Table Length :

Re: [PATCH v3 05/10] pc: Allow instantiating a virtio-iommu device

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:20:00 +0100 Jean-Philippe Brucker wrote: > Allow instantiating a virtio-iommu device by adding an ACPI Virtual I/O > Translation table (VIOT), which describes the relation between the > virtio-iommu and the endpoints it manages. > > Add a hotplug handler for virtio-iommu

[PULL 11/14] arm/aspeed: Add DPS310 to Witherspoon and Rainier

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley Witherspoon uses the DPS310 as a temperature sensor. Rainier uses it as a temperature and humidity sensor. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Message-Id: <20210629142336.750058-5-...@kaod.org> Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 4

[PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-20 Thread Cédric Le Goater
From: Peter Delevoryas This adds a new machine type "fuji-bmc" based on the following device tree: https://github.com/torvalds/linux/blob/40cb6373b46/arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dts Most of the i2c devices are not there, they're added here:

[PULL 04/14] watchdog: aspeed: Fix sequential control writes

2021-09-20 Thread Cédric Le Goater
From: Andrew Jeffery The logic in the handling for the control register required toggling the enable state for writes to stick. Rework the condition chain to allow sequential writes that do not update the enable state. Fixes: 854123bf8d4b ("wdt: Add Aspeed watchdog device model") Signed-off-by:

[PULL 10/14] hw/misc: Add Infineon DPS310 sensor model

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley This contains some hardcoded register values that were obtained from the hardware after reading the temperature. It does enough to test the Linux kernel driver. The FIFO mode, IRQs and operation modes other than the default as used by Linux are not modelled. Signed-off-by:

[PULL 06/14] hw: aspeed_gpio: Clarify GPIO controller name

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley There are two GPIO controllers in the ast2600; one is 3.3V and the other is 1.8V. Signed-off-by: Joel Stanley Reviewed-by: Rashmica Gupta Reviewed-by: Cédric Le Goater Message-Id: <20210713065854.134634-4-j...@jms.id.au> Signed-off-by: Cédric Le Goater ---

Re: [PATCH] block/file-posix: Limit max_iov to IOV_MAX

2021-09-20 Thread Kevin Wolf
Am 18.09.2021 um 09:33 hat lishan geschrieben: > AIO read/write. The size of iocb->aio_nbytes in the kernel cannot exceed > UIO_MAXIOV = 1024. > max_segments read from the block device layer may be greater than UIO_MAXIOV, > this causes the ioq_submit interface to return a -22(-EINVAL) error

[PULL 03/14] watchdog: aspeed: Sanitize control register values

2021-09-20 Thread Cédric Le Goater
From: Andrew Jeffery While some of the critical fields remain the same, there is variation in the definition of the control register across the SoC generations. Reserved regions are adjusted, while in other cases the mutability or behaviour of fields change. Introduce a callback to sanitize the

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 06:07, David Gibson wrote: > On Sat, Sep 18, 2021 at 01:01:35PM -0700, Richard Henderson wrote: > > We dropped host support for sparcv8 (true 32-bit) a long time ago. > > We only support sparcv9 in ilp32 (sparcv8plus) and lp64 (sparc64). > > We really need to update >

[PULL 05/14] hw: aspeed_gpio: Simplify 1.8V defines

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley There's no need to define the registers relative to the 0x800 offset where the controller is mapped, as the device is instantiated as it's own model at the correct memory address. Simplify the defines and remove the offset to save future confusion. Signed-off-by: Joel

[PULL 02/14] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a

2021-09-20 Thread Cédric Le Goater
From: Guenter Roeck According to its dts file in the Linux kernel, we need mac0 and mac1 enabled instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which doesn't even have the third interface. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Message-Id:

Re: [PATCH v3 04/10] hw/arm/virt: Reject instantiation of multiple IOMMUs

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:19:59 +0100 Jean-Philippe Brucker wrote: > We do not support instantiating multiple IOMMUs. Before adding a > virtio-iommu, check that no other IOMMU is present. This will detect > both "iommu=smmuv3" machine parameter and another virtio-iommu instance. > > Fixes:

[PULL 09/14] aspeed: Emulate the AST2600A3

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley This is the latest revision of the ASPEED 2600 SoC. As there is no need to model multiple revisions of the same SoC for the moment, update the SCU AST2600 to model the A3 revision instead of the A1 and adapt the AST2600 SoC and machines. Reset values are taken from v8 of the

[PULL 12/14] hw/arm/aspeed: Initialize AST2600 UART clock selection registers

2021-09-20 Thread Cédric Le Goater
From: Peter Delevoryas UART5 is typically used as the default debug UART on the AST2600, but UART1 is also designed to be a debug UART. All the AST2600 UART's have semi-configurable clock rates through registers in the System Control Unit (SCU), but only UART5 works out of the box with

[PULL 07/14] misc/pca9552: Fix LED status register indexing in pca955x_get_led()

2021-09-20 Thread Cédric Le Goater
From: Andrew Jeffery There was a bit of a thinko in the state calculation where every odd pin in was reported in e.g. "pwm0" mode rather than "off". This was the result of an incorrect bit shift for the 2-bit field representing each LED state. Fixes: a90d8f84674d ("misc/pca9552: Add qom set and

[PULL 01/14] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb

2021-09-20 Thread Cédric Le Goater
From: Guenter Roeck Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it. Signed-off-by: Guenter Roeck Reviewed-by: Joel Stanley Reviewed-by: Cédric Le

Re: [PATCH v2 05/53] docs/devel: document expectations for HMP commands in the future

2021-09-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > We no longer wish to have commands implemented in HMP only. All commands > should start with a QMP implementation and the HMP merely be a shim > around this. To reduce the burden of implementing QMP commands where > there is low expectation of machine usage,

[PULL 08/14] arm/aspeed: rainier: Add i2c eeproms and muxes

2021-09-20 Thread Cédric Le Goater
From: Joel Stanley These are the devices documented by the Rainier device tree. With this we can see the guest discovering the multiplexers and probing the eeprom devices: i2c i2c-2: Added multiplexed i2c bus 16 i2c i2c-2: Added multiplexed i2c bus 17 i2c i2c-2: Added multiplexed i2c bus 18

[PULL 00/14] aspeed queue

2021-09-20 Thread Cédric Le Goater
-aspeed-20210920 for you to fetch changes up to febbe308bf9477767ca92e8ed5f265b0001fcef9: hw/arm/aspeed: Add Fuji machine type (2021-09-20 08:50:59 +0200) Aspeed patches : * MAC enablement fixes (Guenter) * Watchdog and pca9552

Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 02:29, Richard Henderson wrote: > > On 8/26/21 6:45 AM, Peter Maydell wrote: > > I don't think you should need to special case AArch64 vs AArch32 like this; > > you can do > > env->exception.vaddress = pc; > > env->exception.fsr = the_fsr; > >

Re: [PATCH v3 01/10] hw/acpi: Add VIOT table

2021-09-20 Thread Igor Mammedov
On Tue, 14 Sep 2021 15:19:56 +0100 Jean-Philippe Brucker wrote: > Add a function that generates a Virtual I/O Translation table (VIOT), > describing the topology of paravirtual IOMMUs. The table is created when > instantiating a virtio-iommu device. It contains a virtio-iommu node and > PCI

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2021-09-20 Thread Igor Mammedov
On Fri, 6 Aug 2021 16:18:09 -0400 "Annie.li" wrote: > Hello Igor, > > This is an old patch, but it does what we need. > I am getting a little bit lost about not implementing fixed hardware > sleep button, can you please clarify? thank you! > > On 7/20/2017 10:59 AM, Igor Mammedov wrote: > > On

Re: [PATCH v2 04/53] docs/devel: add example of command returning unstructured text

2021-09-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > This illustrates how to add a QMP command returning unstructured text, > following the guidelines added in the previous patch. The example uses > a simplified version of 'info roms'. > > Signed-off-by: Daniel P. Berrangé > --- >

Re: [PATCH v2 01/53] docs/devel: rename file for writing monitor commands

2021-09-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > The file already covers writing new style HMP commands, in addition to > the QMP commands, so it deserves a more general name. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/index.rst| 2 +- >

Re: [PATCH v2 03/53] docs/devel: document expectations for QAPI data modelling for QMP

2021-09-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > Traditionally we have required that newly added QMP commands will model > any returned data using fine grained QAPI types. This is good for > commands that are intended to be consumed by machines, where clear data > representation is very important. Commands that

Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs

2021-09-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > The new headings reflect the intended structure of the document and will > better suit additions that follow. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/writing-monitor-commands.rst | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread Cédric Le Goater
On 9/20/21 09:34, David Gibson wrote: On Mon, Sep 20, 2021 at 08:12:02AM +0200, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater So.. all the functions here are called *set_irq*, but you've named the tracepoints *irq_set*. Yes. I did that on purpose to identify easily the PPC IRQ

Re: [PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:02AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater So.. all the functions here are called *set_irq*, but you've named the tracepoints *irq_set*. It's not a big deal, but it seems like it would be less confusing if you flipped that around to match

Re: [PATCH v2 0/2] Require hypervisor privilege for tlbie[l] when PSR=0 and HR=1.

2021-09-20 Thread David Gibson
On Fri, Sep 17, 2021 at 08:47:49AM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > While working on FreeBSD radix support, Leandro Lupori (CC'ed) noticed > that the latest build still fails in KVM but works in TCG[1]. This > difference occurs because the current

Re: [PATCH v4 1/4] target/ppc: Convert debug to trace events (exceptions)

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:00AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied to ppc-for-6.2, thanks. > --- > target/ppc/excp_helper.c | 38 ++ > target/ppc/trace-events | 8 > 2 files changed, 18 insertions(+), 28

Re: [PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:03AM +0200, Cédric Le Goater wrote: > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() to extract the signed values and remove the logic to > handle negative values which has become useless. > > Cc: Luis Fernando Fujita

Re: [PATCH v4 2/4] target/ppc: Replace debug messages by asserts for unknown IRQ pins

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:01AM +0200, Cédric Le Goater wrote: > If an unknown pin of the IRQ controller is raised, something is very > wrong in the QEMU model. It is better to abort. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-6.2, thanks. > --- > hw/ppc/ppc.c | 24

Re: high cpu usage in idle state

2021-09-20 Thread Ali Vatankhah
Thank a lot Peter and Philippe On 9/19/21 20:46, Philippe Mathieu-Daudé wrote: > In the "infinite loop exception" case, '-d int' might be sufficient, > before using 'exec/cpu', since you'll see the exception raise over > and over. I tried -d int and see that a lot of exceptions are rising in

Re: [RFC PATCH] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

2021-09-20 Thread Ani Sinha
On Mon, 20 Sep 2021, Igor Mammedov wrote: > > > > > diff --git a/tests/qtest/bios-tables-test.c > > > > > b/tests/qtest/bios-tables-test.c > > > > > index 51d3a4e239..c92b70e8b8 100644 > > > > > --- a/tests/qtest/bios-tables-test.c > > > > > +++ b/tests/qtest/bios-tables-test.c > > > > > @@

[PATCH v3 1/3] tests/acpi/bios-tables-test: add and allow changes to a new q35 DSDT table blob

2021-09-20 Thread Ani Sinha
We are adding a new unit test to cover the acpi hotplug support in q35 for multi-function bridges. This test uses a new table DSDT.multi-bridge. We need to allow changes in DSDT acpi table for addition of this new unit test. Signed-off-by: Ani Sinha --- tests/data/acpi/q35/DSDT.multi-bridge

[PATCH v3 0/3] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

2021-09-20 Thread Ani Sinha
This patchset adds a unit test to exercize acpi hotplug support for multifunction bridges on q35 machines. This support was added with the commit: d7346e614f4ec ("acpi: x86: pcihp: add support hotplug on multifunction bridges") changelist: v1 : initial RFC patch. v2: incorporated some of the

[PATCH v3 3/3] tests/acpi/bios-tables-test: update DSDT blob for multifunction bridge test

2021-09-20 Thread Ani Sinha
We added a new unit test for testing acpi hotplug on multifunction bridges in q35 machines. Here, we update the DSDT table gloden master blob for this unit test. Following is the ASL diff between the original DSDT table and the modified DSDT table due to the unit test: @@ -5,13 +5,13 @@ * *

[PATCH v3 2/3] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

2021-09-20 Thread Ani Sinha
commit d7346e614f4ec ("acpi: x86: pcihp: add support hotplug on multifunction bridges") added ACPI hotplug descriptions for cold plugged bridges for functions other than 0. For all other devices, the ACPI hotplug descriptions are limited to function 0 only. This change adds unit tests for this

<    1   2   3   4   5   >