Re: [PATCH] vhost: Fix last queue index of devices with no cvq

On Tue, Nov 2, 2021 at 5:09 AM Jason Wang wrote: > > On Mon, Nov 1, 2021 at 4:59 PM Eugenio Perez Martin > wrote: > > > > On Mon, Nov 1, 2021 at 4:34 AM Jason Wang wrote: > > > > > > On Fri, Oct 29, 2021 at 10:16 PM Eugenio Pérez > > > wrote: > > > > > > > > The -1 assumes that all devices wi

Re: [PATCH] vhost: Fix last queue index of devices with no cvq

On Tue, Nov 2, 2021 at 2:59 PM Eugenio Perez Martin wrote: > > On Tue, Nov 2, 2021 at 5:09 AM Jason Wang wrote: > > > > On Mon, Nov 1, 2021 at 4:59 PM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Nov 1, 2021 at 4:34 AM Jason Wang wrote: > > > > > > > > On Fri, Oct 29, 2021 at 10:16 PM E

Re: [PATCH 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

On Oct 27 18:49, Lukasz Maniak wrote: > On Tue, Oct 26, 2021 at 08:20:12PM +0200, Klaus Jensen wrote: > > On Oct 7 18:23, Lukasz Maniak wrote: > > > Hi, > > > > > > This series of patches is an attempt to add support for the following > > > sections of NVMe specification revision 1.4: > > > > >

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. even I know, I know, I am Spanis

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: > Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > > case, and the device may have a pair number of queues. >

Re: [RFC PATCH v5 12/26] vhost: Route guest->host notification through shadow virtqueue

On Tue, Nov 2, 2021 at 6:36 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > +/** > > + * Enable or disable shadow virtqueue in a vhost vdpa device. > > + * > > + * This function is idempotent, to call it many times with the same value > > for > > + * enable_svq will simply r

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

Eugenio Pérez wrote: > Command to set shadow virtqueue mode. > > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela You need to keep care of: Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling unstable interfaces When this hit the tree, you need to drop the x- an

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

"Michael S. Tsirkin" wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the >> > case, and the device

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. > > To fix this, just resort to the lower even number of queues. > > Fix

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

On Tue, Nov 02, 2021 at 10:44:08AM +1100, Gavin Shan wrote: > > Yeah, I agree. I don't have strong sense to expose these empty nodes > for now. Please ignore the patch. > So were describing empty numa nodes on the command line ever a reasonable thing to do? What happens on x86 machine types when

Re: [PATCH] meson.build: Allow to disable OSS again

On 29/10/2021 11.32, Philippe Mathieu-Daudé wrote: On 10/29/21 09:13, Thomas Huth wrote: If sys/soundcard.h is available, it is currently not possible to disable OSS with the --disable-oss or --without-default-features configure switches. Improve the check in meson.build to fix this. Fixes: 874

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

在 2021/10/30 上午2:35, Eugenio Pérez 写道: If device supports host notifiers, this makes one jump less (kernel) to deliver SVQ notifications to it. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 2 ++ hw/virtio/vhost-shadow-virtqueue.c | 23 ++- 2 f

Re: [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding

在 2021/10/30 上午2:35, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There are no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices uses forced IOMMU, this means that SVQ is not usable at t

Re: [PATCH] meson.build: Allow to disable OSS again

On 11/2/21 08:45, Thomas Huth wrote: > On 29/10/2021 11.32, Philippe Mathieu-Daudé wrote: >> On 10/29/21 09:13, Thomas Huth wrote: >>> If sys/soundcard.h is available, it is currently not possible to >>> disable OSS with the --disable-oss or --without-default-features >>> configure switches. Improv

Issue with acpi hotplug on pcie root ports in case of q35 + ovmf + machine type 6.1

Hi list, Have you experienced any acpi hotplugging issue while using q35 + ovmf + machine type 6.1? According to the error message in guest kernel, It seems qemu with ovmf doesn't prepare enough resource in PCI space for acpi hotplugging on multifunction bridges. Please refer to issue#705 f

Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq

On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote: > > On Sat, Oct 30, 2021 at 2:44 AM Eugenio Pérez wrote: > > > > This allows it to test if the guest has aknowledge an invalid transport > > feature for SVQ. This will include packed vq layout or event_idx, > > where VirtIO device needs help from S

Re: [PATCH v2] failover: specify an alternate MAC address

On 01/11/2021 10:39, Michael S. Tsirkin wrote: On Wed, Oct 27, 2021 at 11:59:45AM +0200, Laurent Vivier wrote: If the guest driver doesn't support the STANDBY feature, by default we keep the virtio-net device and don't hotplug the VFIO device, but in some cases, user can prefer to use the VFIO d

Re: [RFC PATCH v5 23/26] util: Add iova_tree_alloc

On Tue, Nov 2, 2021 at 7:35 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > This iova tree function allows it to look for a hole in allocated > > regions and return a totally new translation for a given translated > > address. > > > > It's usage is mainly to allow devices to

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

On Tue, Nov 2, 2021 at 8:36 AM Juan Quintela wrote: > > Eugenio Pérez wrote: > > Command to set shadow virtqueue mode. > > > > Signed-off-by: Eugenio Pérez > > Reviewed-by: Juan Quintela > > You need to keep care of: > > Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling

Re: [PATCH v8 00/29] Add LoongArch linux-user emulation support

Hi, On 11/1/21 10:51, Song Gao wrote: > > This series only support linux-user emulation. > More about LoongArch at: https://github.com/loongson/ > > The latest kernel: > * https://github.com/loongson/linux/tree/loongarch-next > create mode 100644 target/loongarch/insn_trans/trans_arith.c >

Re: [PATCH v1 00/12] virtio-mem: Expose device memory via multiple memslots

On 01.11.21 23:15, Michael S. Tsirkin wrote: > On Wed, Oct 27, 2021 at 02:45:19PM +0200, David Hildenbrand wrote: >> This is the follow-up of [1], dropping auto-detection and vhost-user >> changes from the initial RFC. >> >> Based-on: 20211011175346.15499-1-da...@redhat.com >> >> A virtio-mem devic

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

On Tue, Nov 2, 2021 at 8:25 AM Juan Quintela wrote: > > Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > > case, and the device may have a pair number of queues. >

Re: [PATCH v8 02/29] target/loongarch: Add core definition

On 11/1/21 10:51, Song Gao wrote: > This patch adds target state header, target definitions > and initialization routines. > > Reviewed-by: Richard Henderson > Signed-off-by: Song Gao > Signed-off-by: Xiaojuan Yang > --- > target/loongarch/cpu-param.h | 19 +++ > target/loongarch/cpu.c

[PATCH v5 1/6] tests/acceptance: Extract QemuBaseTest from Test

The Avocado Test::fetch_asset() is handy to download artifacts before running tests. The current class is named Test but only tests system emulation. As we want to test user emulation, refactor the common code as QemuBaseTest. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé -

[PATCH v5 2/6] tests/acceptance: Make pick_default_qemu_bin() more generic

Make pick_default_qemu_bin() generic to find qemu-system or qemu-user binaries. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- v5: Use PEP3135 --- tests/acceptance/avocado_qemu/__init__.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/te

[PATCH v5 5/6] tests/acceptance: Add bFLT loader linux-user test

Add a very quick test that runs a busybox binary in bFLT format: $ AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py JOB ID : db94d5960ce564c50904d666a7e259148c27e88f JOB LOG: ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job

[PATCH v5 0/6] tests/acceptance: Add bFLT loader linux-user test

Since v4: - rebased - addressed Willian review comments Since v3: - rebased - addressed Wainer review comments from v2 - rename avocado_qemu.Test -> QemuSystemTest Since v2: - rebased tests/acceptance/avocado_qemu/__init__.py patches - extract has_cmd() from virtiofs_submounts.py - check cpio ava

[PATCH v5 4/6] tests/acceptance: Share useful helpers from virtiofs_submounts test

Move the useful has_cmd()/has_cmds() helpers from the virtiofs test to the avocado_qemu public class. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 57 ++ tests/ac

[PATCH v5 6/6] tests/acceptance: Rename avocado_qemu.Test -> QemuSystemTest

To run user-mode emulation tests, we introduced the avocado_qemu.QemuUserTest which inherits from avocado_qemu.QemuBaseTest. System-mode emulation tests are based on the avocado_qemu.Test class, which also inherits avocado_qemu.QemuBaseTest. To avoid confusion, rename it as avocado_qemu.QemuSystemT

[PATCH v5 3/6] tests/acceptance: Introduce QemuUserTest base class

Similarly to the 'System' Test base class with methods for testing system emulation, the QemuUserTest class contains methods useful to test user-mode emulation. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- v5: Use PEP3135, use

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

On Tue, Nov 2, 2021 at 8:55 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > If device supports host notifiers, this makes one jump less (kernel) to > > deliver SVQ notifications to it. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-shadow-virtqueue.h | 2

Re: [PATCH v2] failover: specify an alternate MAC address

On Tue, Nov 02, 2021 at 09:14:51AM +0100, Laurent Vivier wrote: > On 01/11/2021 10:39, Michael S. Tsirkin wrote: > > On Wed, Oct 27, 2021 at 11:59:45AM +0200, Laurent Vivier wrote: > > > If the guest driver doesn't support the STANDBY feature, by default > > > we keep the virtio-net device and don'

Re: [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machine property

On 10/26/21 17:11, Eduardo Habkost wrote: > The i440fx and Q35 machine types are both hardcoded to use the > legacy SMBIOS 2.1 (32-bit) entry point. This is a sensible > conservative choice because SeaBIOS only supports SMBIOS 2.1 > > EDK2, however, can also support SMBIOS 3.0 (64-bit) entry point

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

+Markus/Eduardo On 11/1/21 18:33, Peter Maydell wrote: > On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: >> >> The ID can be used to indicate SMBus modules when adding >> dynamic devices to them. >> >> Signed-off-by: Hao Wu >> --- >> hw/arm/npcm7xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> d

Re: [PATCH 1/2] migration: provide an error message to migration_cancel()

Laurent Vivier wrote: > This avoids to call migrate_get_current() in the caller function > whereas migration_cancel() already needs the pointer to the current > migration state. > > Signed-off-by: Laurent Vivier Reviewed-by: Juan Quintela queued. > error_setg(&err, "RAM block '%s' r

Re: [PATCH 2/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Laurent Vivier wrote: > As the guest OS is paused, we will never receive the unplug event > from the kernel and the migration cannot continue. > > Signed-off-by: Laurent Vivier Reviewed-by: Juan Quintela queued. I can't think of a better solution.

Re: [PATCH v1 1/2] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread

Emanuele Giuseppe Esposito wrote: > init_dirty_bitmap_migration assumes the iothread lock (BQL) > to be held, but instead it isn't. > > Instead of adding the lock to qemu_savevm_state_setup(), > follow the same pattern as the other ->save_setup callbacks > and lock+unlock inside dirty_bitmap_save_

Re: [PATCH] nvmm: Fix support for stable version

Reviewed-by: Kamil Rytarowski Paolo, could you please merge it? On 13.10.2021 15:54, nia wrote: > NVMM user version 1 is the version being shipped with netbsd-9, > which is the most recent stable branch of NetBSD. This makes it > possible to use the NVMM accelerator on the most recent NetBSD > r

Re: [PATCH 2/9] qapi: Mark unstable QMP parts with feature 'unstable'

Am 29.10.2021 um 15:07 hat Eric Blake geschrieben: > On Mon, Oct 25, 2021 at 07:25:25AM +0200, Markus Armbruster wrote: > > Add special feature 'unstable' everywhere the name starts with 'x-', > > except for InputBarrierProperties member x-origin and > > MemoryBackendProperties member x-use-canonic

Re: [PATCH v1 1/2] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread

Juan Quintela wrote: > Emanuele Giuseppe Esposito wrote: >> init_dirty_bitmap_migration assumes the iothread lock (BQL) >> to be held, but instead it isn't. >> >> Instead of adding the lock to qemu_savevm_state_setup(), >> follow the same pattern as the other ->save_setup callbacks >> and lock+un

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > From: Marcel Apfelbaum > > > > > > Q35 has now ACPI hotplug enabled by default fo

Re: [PATCH v2] hmp: Add shortcut to stop command to match cont

On Sat, Oct 30, 2021 at 11:49:37AM +0200, BALATON Zoltan wrote: > Some commands such as quit or cont have one letter alternatives but > stop is missing that. Add stop|s to match cont|c for consistency and > convenience. > > Signed-off-by: BALATON Zoltan > --- > c2: Fixed typo in commit title > >

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

Hi Daniel, On Tue, Nov 2, 2021 at 11:24 AM Daniel P. Berrangé wrote: > On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > > Fro

Re: [PATCH 4/5] hw/core: Remove uses of QERR_PROPERTY_VALUE_BAD

On 10/30/21 01:01, Philippe Mathieu-Daudé wrote: QERR_PROPERTY_VALUE_BAD definition is obsolete since 2015 (commit 4629ed1e989, "qerror: Finally unused, clean up"). Replace the two uses and drop the definition. Signed-off-by: Philippe Mathieu-Daudé --- include/qapi/qmp/qerror.h | 3 --- h

Re: [PATCH 0/5] hw/core: Remove uses of obsolete QERR_ definitions

On 10/30/21 01:01, Philippe Mathieu-Daudé wrote: QERR_ definitions are obsolete since 2015... Remove their uses in hw/core/. Philippe Mathieu-Daudé (5): hw/core: Remove use of QERR_UNSUPPORTED hw/core: Remove use of QERR_FEATURE_DISABLED hw/core: Remove uses of QERR_DEVICE_NO_HOTPLUG

Re: [PULL 00/22] Python patches

On 11/1/21 1:29 PM, John Snow wrote: The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e: Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into staging (2021-10-30 11:31:41 -0700) are available in the Git repository at: https://gitlab.com/jsnow

Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO

On 11/1/21 3:35 PM, Peter Maydell wrote: On Mon, 1 Nov 2021 at 19:28, Richard Henderson wrote: On 10/26/21 3:12 AM, Alexander Graf wrote: Apple's Hypervisor.Framework forwards cache operations as MMIO traps into user space. For MMIO however, these have no meaning: There is no cache attached t

Re: [PATCH v2 0/5] hw/arm: Add NPCM7XX Tachometer Device

On 11/1/21 1:50 PM, Hao Wu wrote: Is this reply to a wrong thread? I thought it was applied a long time ago. Probably. r~ Thanks, On Mon, Nov 1, 2021 at 10:33 AM Richard Henderson > wrote: On Thu, 11 Mar 2021 at 13:11, Hao Wu mailto:wuhao...@googl

Re: [RFC PATCH 00/15] job: replace AioContext lock with job_mutex

On Fri, Oct 29, 2021 at 12:38:59PM -0400, Emanuele Giuseppe Esposito wrote: > RFC: not sure if the current patch organization is correct. > Bisecting in patches in between this serie would cause tests > to deadlock. Patch series must be bisectable. It will be necessary to fix this. Stefan signa

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

Hi, > On Thu, 28 Oct 2021 at 05:51, Simon Glass wrote: > > On Tue, 26 Oct 2021 at 00:46, Ilias Apalodimas > > wrote: .. > > Linux actually doesn't care if the U-Boot properties are in the tree, > > so long as we have proper bindings. My point here is we only need > > either: > > > > a. one dev

Re: [RFC PATCH 01/15] jobs: add job-common.h

On Fri, Oct 29, 2021 at 12:39:00PM -0400, Emanuele Giuseppe Esposito wrote: > job-common.h contains all struct and common function that currently > are in job.h and will be shared by job-monitor and job-driver in > the next commits. > > No functional change intended. > > Signed-off-by: Emanuele G

Re: [RFC PATCH 02/15] job.c: make job_lock/unlock public

On Fri, Oct 29, 2021 at 12:39:01PM -0400, Emanuele Giuseppe Esposito wrote: > job mutex will be used to protect the job struct elements and list, > replacing AioContext locks. > > Right now use a shared lock for all jobs, in order to keep things > simple. Once the AioContext lock is gone, we can i

Re: [PATCH 02/13] target/riscv: Extend pc for runtime pc write

On 11/1/21 9:48 PM, LIU Zhiwei wrote: On 2021/11/1 下午6:33, Richard Henderson wrote: On 11/1/21 6:01 AM, LIU Zhiwei wrote: In some cases, we must restore the guest PC to the address of the start of the TB, such as when the instruction counter hit zero. So extend pc register according to current

Re: [PATCH 03/13] target/riscv: Ignore the pc bits above XLEN

On 11/1/21 6:01 AM, LIU Zhiwei wrote: The read from PC for translation is in cpu_get_tb_cpu_state, before translation. Signed-off-by: LIU Zhiwei --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_help

Re: [RFC PATCH 03/15] job-common.h: categorize fields in struct Job

On Fri, Oct 29, 2021 at 12:39:02PM -0400, Emanuele Giuseppe Esposito wrote: > Categorize the fields in struct Job to understand which need > to be protected by the job muutex and which not. s/muutex/mutex/ (__) `\--(oo) ||(__) .o( moo-tex ) ||w--|| BTW "which ones nee

Re: [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding

On Tue, Nov 2, 2021 at 8:59 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > Initial version of shadow virtqueue that actually forward buffers. There > > are no iommu support at the moment, and that will be addressed in future > > patches of this series. Since all vhost-vdpa d

Re: [PATCH] vhost: Fix last queue index of devices with no cvq

On Tue, Nov 2, 2021 at 8:04 AM Jason Wang wrote: > > On Tue, Nov 2, 2021 at 2:59 PM Eugenio Perez Martin > wrote: > > > > On Tue, Nov 2, 2021 at 5:09 AM Jason Wang wrote: > > > > > > On Mon, Nov 1, 2021 at 4:59 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Mon, Nov 1, 2021 at 4:34 A

Re: [PATCH v4 02/22] target/riscv: Implement SGEIP bit in hip and hie CSRs

On Tue, Nov 2, 2021 at 12:22 PM Bin Meng wrote: > > On Tue, Oct 26, 2021 at 2:43 PM Anup Patel wrote: > > > > A hypervsior can optionally take guest external interrupts using > > typo: hypervisor Okay, I will update. > > > SGEIP bit of hip and hie CSRs. > > > > Signed-off-by: Anup Patel > > Re

Re: [PATCH v2 3/3] KVM: SVM: add migration support for nested TSC scaling

On 01/11/21 14:23, Maxim Levitsky wrote: Signed-off-by: Maxim Levitsky --- target/i386/cpu.c | 5 + target/i386/cpu.h | 4 target/i386/kvm/kvm.c | 15 +++ target/i386/machine.c | 23 +++ 4 files changed, 47 insertions(+) It's easier to m

Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO

On Tue, 2 Nov 2021 at 10:01, Richard Henderson wrote: > > On 11/1/21 3:35 PM, Peter Maydell wrote: > > On Mon, 1 Nov 2021 at 19:28, Richard Henderson > > wrote: > >> > >> On 10/26/21 3:12 AM, Alexander Graf wrote: > >>> Apple's Hypervisor.Framework forwards cache operations as MMIO traps > >>> in

Re: [PATCH v2 0/5] hw/arm: Add NPCM7XX Tachometer Device

On Tue, 2 Nov 2021 at 10:03, Richard Henderson wrote: > > On 11/1/21 1:50 PM, Hao Wu wrote: > > Is this reply to a wrong thread? I thought it was applied a long time ago. > > Probably. Possibly you meant this 5-patch NPCM7xx series ? https://patchew.org/QEMU/20211008002628.1958285-1-wuhao...@goog

Re: [PATCH 2/2] qtest/am53c974-test: add test for cancelling in-flight requests

On 01/11/21 19:35, Mark Cave-Ayland wrote: Based upon the qtest reproducer posted to Gitlab issue #663 at https://gitlab.com/qemu-project/qemu/-/issues/663. Signed-off-by: Mark Cave-Ayland --- tests/qtest/am53c974-test.c | 36 1 file changed, 36 insertion

Re: [PATCH v4 02/22] target/riscv: Implement SGEIP bit in hip and hie CSRs

On Tue, Nov 2, 2021 at 6:24 PM Anup Patel wrote: > > On Tue, Nov 2, 2021 at 12:22 PM Bin Meng wrote: > > > > On Tue, Oct 26, 2021 at 2:43 PM Anup Patel wrote: > > > > > > A hypervsior can optionally take guest external interrupts using > > > > typo: hypervisor > > Okay, I will update. > > > > >

Re: [RFC PATCH 08/15] job.c: minor adjustments in preparation to job-driver

29.10.2021 19:39, Emanuele Giuseppe Esposito wrote: job_event_* functions can be all static, as they are not used outside job.c Add also missing notifier initialization for the on_idle list in job_create(). Signed-off-by: Emanuele Giuseppe Esposito --- job.c | 13 +++-- 1 file chang

Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

Hello, On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/25/21 13:33, BALATON Zoltan wrote: This is the same as posted before just omitting the two patches that are optimisations by caching the func0 and avoiding QOM casts which could not be measured to have an effect but these reamainin

Re: [RFC PATCH 07/15] job-driver.h: add helper functions

29.10.2021 19:39, Emanuele Giuseppe Esposito wrote: These functions will be useful when job_lock is globally applied, as they will allow drivers to access the job struct fields without worrying about the job lock. Now that we are done with the job API header split, update also the comments in bl

Re: [PATCH 0/3] SEV: fixes for -kernel launch with incompatible OVMF

Hi Dov, Overall the patch looks good, only question I have is that now we are enforce qemu to hash the kernel, initrd and cmdline unconditionally for any of the SEV guest launches. This requires anyone wanting to calculating the expected measurement need to account for it. Should we make the hash

[PATCH v2] meson.build: Allow to disable OSS again

If sys/soundcard.h is available, it is currently not possible to disable OSS with the --disable-oss or --without-default-features configure switches. Improve the check in meson.build to fix this. Fixes: 87430d5b13 ("configure, meson: move audio driver detection to Meson") Signed-off-by: Thomas Hut

[PULL 01/12] hw/sd: add nuvoton MMC

From: Shengtan Mao Signed-off-by: Shengtan Mao Signed-off-by: Hao Wu Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Reviewed-by: Tyrone Ting Reviewed-by: Peter Maydell Message-Id: <20211008002628.1958285-2-wuhao...@google.com> [rth: Fix typos of "nonexistent"] Signed-off-by: Richard Henderson

[PULL 02/12] hw/arm: Add Nuvoton SD module to board

From: Shengtan Mao Signed-off-by: Shengtan Mao Signed-off-by: Hao Wu Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Reviewed-by: Tyrone Ting Reviewed-by: Peter Maydell Message-Id: <20211008002628.1958285-3-wuhao...@google.com> Signed-off-by: Richard Henderson --- include/hw/arm/npcm7xx.h |

[PULL 05/12] tests/qtest: add qtests for npcm7xx sdhci

From: Shengtan Mao Signed-off-by: Shengtan Mao Signed-off-by: Hao Wu Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Reviewed-by: Tyrone Ting Reviewed-by: Peter Maydell Message-Id: <20211008002628.1958285-6-wuhao...@google.com> Signed-off-by: Richard Henderson --- tests/qtest/npcm7xx_sdhci-t

[PULL 00/12] target/arm patch queue

The following changes since commit dd61b91c080cdfba1360a5ea1e4693fffb3445b0: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-10-29' into staging (2021-10-29 19:42:36 -0700) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-ar

[PULL 06/12] target/arm: Advertise MVE to gdb when present

From: Peter Maydell Cortex-M CPUs with MVE should advertise this fact to gdb, using the org.gnu.gdb.arm.m-profile-mve XML feature, which defines the VPR register. Presence of this feature also tells gdb to create pseudo-registers Q0..Q7, so we do not need to tell gdb about them separately. Note

[PULL 04/12] tests/qtest/libqos: add SDHCI commands

From: Shengtan Mao Signed-off-by: Shengtan Mao Signed-off-by: Hao Wu Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Reviewed-by: Tyrone Ting Reviewed-by: Peter Maydell Message-Id: <20211008002628.1958285-5-wuhao...@google.com> Signed-off-by: Richard Henderson --- tests/qtest/libqos/sdhci-cm

[PULL 03/12] hw/arm: Attach MMC to quanta-gbs-bmc

From: Shengtan Mao Signed-off-by: Shengtan Mao Signed-off-by: Hao Wu Reviewed-by: Hao Wu Reviewed-by: Tyrone Ting Reviewed-by: Peter Maydell Message-Id: <20211008002628.1958285-4-wuhao...@google.com> Signed-off-by: Richard Henderson --- hw/arm/npcm7xx_boards.c | 20 1

[PULL 10/12] target/arm: Use tcg_constant_i64() in do_sat_addsub_64()

From: Philippe Mathieu-Daudé The immediate value used for comparison is constant and read-only. Move it to the constant pool. This frees a TCG temporary for unsigned saturation opcodes. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-5-f

[PULL 08/12] target/arm: Introduce store_cpu_field_constant() helper

From: Philippe Mathieu-Daudé Similarly to the store_cpu_field() helper which takes a TCG temporary, store its value to the CPUState, introduce the store_cpu_field_constant() helper which store a constant to CPUState (without using any TCG temporary). Suggested-by: Richard Henderson Signed-off-b

[PULL 19/60] hw/core: Add TCGCPUOps.record_sigsegv

Add a new user-only interface for updating cpu state before raising a signal. This will replace tlb_fill for user-only and should result in less boilerplate for each guest. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/hw/core/tcg-cpu-ops.h | 26 +

[PULL 07/12] target/arm: Use tcg_constant_i32() in op_smlad()

From: Philippe Mathieu-Daudé Avoid using a TCG temporary for a read-only constant. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-2-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed,

[PULL 01/60] accel/tcg: Split out adjust_signal_pc

Split out a function to adjust the raw signal pc into a value that could be passed to cpu_restore_state. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- v2: Adjust pc in place; return MMUAccessType. --- include/exec/exec-all.h | 10 ++

[PULL 09/12] target/arm: Use the constant variant of store_cpu_field() when possible

From: Philippe Mathieu-Daudé When using a constant variable, we can replace the store_cpu_field() call by store_cpu_field_constant() which avoid using TCG temporaries. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-4-f4...@amsat.org> Si

[PULL 12/12] hw/arm/virt: Rename default_bus_bypass_iommu

From: Jean-Philippe Brucker Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was in

[PULL 15/60] linux-user/host/riscv: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Reviewed-by: Warner Losh Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- linux-user/host/riscv/host-signal.h | 86 +- accel/tcg/user-exec.c | 134 2 fil

[PULL 02/60] accel/tcg: Move clear_helper_retaddr to cpu loop

Currently there are only two places that require we reset this value before exiting to the main loop, but that will change. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 3 ++- accel/tcg/user-exec.c | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-)

[PULL 11/12] target/arm: Use tcg_constant_i32() in gen_rev16()

From: Philippe Mathieu-Daudé Since the mask is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-6-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/arm/tran

[PULL 04/60] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller

Remove the comment about siglongjmp. We do use sigsetjmp in the main cpu loop, but we do not save the signal mask as most exits from the cpu loop do not require them. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 14 ++ 1 file changed, 2 inse

[PULL 22/60] target/arm: Use cpu_loop_exit_sigsegv for mte tag lookup

Use the new os interface for raising the exception, rather than calling arm_cpu_tlb_fill directly. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a

[PULL 06/60] linux-user: Reorg handling for SIGSEGV

Add stub host-signal.h for all linux-user hosts. Add new code replacing cpu_signal_handler. Full migration will happen one host at a time. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Signed-off-by: Richard Henderson --- linux-user/host/aarch64/host-

[PULL 03/60] accel/tcg: Split out handle_sigsegv_accerr_write

This is the major portion of handle_cpu_signal which is specific to tcg, handling the page protections for the translations. Most of the rest will migrate to linux-user/ shortly. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- v2: Pass guest add

[PULL 07/60] linux-user/host/x86: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Drop the *BSD code, to be re-created under bsd-user/ later. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- linux-user/host/i386/host-signal.h | 26 - linux-user/host/x32/host-signal.h| 2 +- linux-user/ho

[PULL 27/60] target/i386: Implement x86_cpu_record_sigsegv

Record cr2, error_code, and exception_index. That last means that we must exit to cpu_loop ourselves, instead of letting exception_index being overwritten. Use the maperr parameter to properly set PG_ERROR_P_MASK. Reviewed by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Rich

[PULL 00/60] accel/tcg patch queue

The following changes since commit dd61b91c080cdfba1360a5ea1e4693fffb3445b0: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-10-29' into staging (2021-10-29 19:42:36 -0700) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tc

[PULL 10/60] linux-user/host/sparc: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Drop the *BSD code, to be re-created under bsd-user/ later. Drop the Solaris code as completely unused. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- linux-user/host/sparc/host-signal.h | 55 +++

[PULL 05/60] configure: Merge riscv32 and riscv64 host architectures

The existing code for safe-syscall.inc.S will compile without change for riscv32 and riscv64. We may also drop the meson.build stanza that merges them for tcg/. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- con

[PULL 35/60] target/riscv: Make riscv_cpu_tlb_fill sysemu only

The fallback code in cpu_loop_exit_sigsegv is sufficient for riscv linux-user. Remove the code from cpu_loop that raised SIGSEGV. Reviewed-by: Warner Losh Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/riscv/cpu_loop.c | 7 -

[PULL 08/60] linux-user/host/ppc: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Drop the *BSD code, to be re-created under bsd-user/ later. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- linux-user/host/ppc/host-signal.h | 26 +- linux-user/host/ppc64/host-signal.h | 2 +- accel/tcg/us

[PULL 36/60] target/s390x: Use probe_access_flags in s390_probe_access

Not sure why the user-only code wasn't rewritten to use probe_access_flags at the same time that the sysemu code was converted. For the purpose of user-only, this is an exact replacement. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/s390x/tcg/mem_helper.c | 1

[PULL 11/60] linux-user/host/arm: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Drop the *BSD code, to be re-created under bsd-user/ later. Reviewed-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/host/arm/host-signal.h | 31 - accel/tcg/u

[PULL 12/60] linux-user/host/aarch64: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Drop the *BSD code, to be re-created under bsd-user/ later. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- linux-user/host/aarch64/host-signal.h | 75 - accel/tcg/user-exec.c | 94 +

[PULL 13/60] linux-user/host/s390: Populate host_signal.h

Split host_signal_pc and host_signal_write out of user-exec.c. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/host/s390/host-signal.h | 94 - linux-user/host/s390x/host-signal.h | 2 +- accel/tcg/user-e

  1   2   3   4   5   6   >