[PULL 13/30] linux-user/microblaze: Fix SIGFPE si_codes

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Fix a typo for ESR_EC_DIVZERO, which is integral not floating-point. Fix the if ladder for decoding floating-point exceptions. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-14-richard.hender...@linaro.org> Signed-off-by:

[PULL 04/30] linux-user/cris: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-5-richard.hender...@linaro.org> Signed-off-by:

[PULL 11/30] linux-user/m68k: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-12-richard.hender...@linaro.org> Signed-off-by:

[PULL 17/30] target/mips: Extract trap code into env->error_code

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Simplify cpu_loop by doing all of the decode in translate. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-18-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/mips/cpu_loop.c

[PULL 10/30] linux-user/i386: Use force_sig, force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Replace the local gen_signal with the generic functions that match how the kernel raises signals. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-11-richard.hender...@linaro.org>

[PULL 06/30] linux-user/hppa: Use the proper si_code for PRIV_OPR, PRIV_REG, OVERFLOW

2022-01-11 Thread Laurent Vivier
From: Richard Henderson These si_codes have been properly set by the kernel since the beginning. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-7-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/hppa/cpu_loop.c | 8

[PULL 03/30] linux-user/alpha: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 02/30] linux-user/alpha: Set FPE_FLTUNK for gentrap ROPRAND

2022-01-11 Thread Laurent Vivier
From: Richard Henderson This si_code was changed in 4cc13e4f6d441, for linux 4.17. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/cpu_loop.c | 2 +- 1 file

[PULL 07/30] linux-user: Remove TARGET_NSIGFPE

2022-01-11 Thread Laurent Vivier
From: Richard Henderson This define is unused, and we have no similar define for the other signal sub-codes. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 01/30] linux-user/alpha: Set TRAP_UNK for bugchk and unknown gentrap

2022-01-11 Thread Laurent Vivier
From: Richard Henderson These si_codes were changed in 535906c684fca, for linux 4.17. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/cpu_loop.c | 4 ++--

[PULL 05/30] linux-user/hppa: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP and missing si_code for SIGBUS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id:

[PULL 00/30] Linux user for 7.0 patches

2022-01-11 Thread Laurent Vivier
-for-7.0-pull-request for you to fetch changes up to 4f4e5567f856d9b841494b3b5216a37d2952ee54: linux-user: Implement capability prctls (2022-01-11 18:40:44 +0100) linux-user pull request 20220111 siginfo_t cleanup more prtctl() update

Re: [RFC qemu.qmp PATCH 17/24] Makefile: add build and publish targets

2022-01-11 Thread John Snow
On Fri, Dec 17, 2021 at 8:46 AM Daniel P. Berrangé wrote: > On Thu, Dec 16, 2021 at 06:35:23PM -0500, John Snow wrote: > > On Thu, Dec 16, 2021 at 5:48 AM Daniel P. Berrangé > > wrote: > > > > > On Wed, Dec 15, 2021 at 04:06:27PM -0500, John Snow wrote: > > > > Signed-off-by: John Snow > > > >

[PATCH] nbd/server.c: Remove unused field

2022-01-11 Thread Nir Soffer
NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that this field exists since the first git commit and was never used. Signed-off-by: Nir Soffer --- nbd/server.c | 1 - 1 file changed, 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c index 3927f7789d..ce5b2a1d02 100644 ---

[PATCH v3 04/10] hw/pci: Document pci_dma_map()

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 12 1 file changed, 12 insertions(+) diff --git a/include/hw/pci/pci.h

[PATCH v3 09/10] hw/dma: Move ScatterGatherEntry / QEMUSGList declarations around

2022-01-11 Thread Philippe Mathieu-Daudé
In the next commit we will use the dma_addr_t type in the QEMUSGList structure. Since currently dma_addr_t is defined after QEMUSGList, move the declarations to have dma_addr_t defined first. This is a pure code-movement patch. Suggested-by: David Hildenbrand Signed-off-by: Philippe

[PATCH v3 06/10] hw/rdma/rdma_utils: Rename rdma_pci_dma_map 'len' argument

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Various APIs use 'pval' naming for 'pointer to val'. rdma_pci_dma_map() uses 'plen' for 'PCI length', but since 'PCI' is already explicit in the function name, simplify and rename the argument 'len'. No logical change. Signed-off-by: Philippe Mathieu-Daudé

[PATCH v3 03/10] hw/pci: Restrict pci-bus stub to sysemu

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Neither tools nor user-mode emulation require the PCI bus stub. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Philippe Mathieu-Daudé --- stubs/meson.build | 2

Re: [PATCH v2 0/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-11 Thread Philippe Mathieu-Daudé
On 1/6/22 12:08, Michael S. Tsirkin wrote: > On Tue, Jan 04, 2022 at 09:54:22AM +0100, Philippe Mathieu-Daudé wrote: >> Since v1: >> - Addressed David review comment (stick to dma_addr_t type) >> - Addressed Peter review comment (incorrect doc string) > > > PCI things: > > Reviewed-by: Michael

[PATCH v3 10/10] hw/dma: Use dma_addr_t type definition when relevant

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Update the obvious places where dma_addr_t should be used (instead of uint64_t, hwaddr, size_t, int32_t types). This allows to have _addr_t type portable on 32/64-bit hosts. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Signed-off-by:

[PATCH v3 02/10] hw/nvram: Restrict fw_cfg QOM interface to sysemu and tools

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé fw_cfg QOM interface is required by system emulation and qemu-storage-daemon. User-mode emulation doesn't need it. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/meson.build | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v3 07/10] hw/scsi: Rename SCSIRequest::resid as 'residual'

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The 'resid' field is slightly confusing and could be interpreted as some ID. Rename it as 'residual' which is clearer to review. No logical change. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by:

[PATCH v3 00/10] hw/dma: Use dma_addr_t type definition when relevant

2022-01-11 Thread Philippe Mathieu-Daudé
Since v2: - Split meson patch restricting fw_cfg (Richard) - Reorder pci_dma_map() docstring (Peter, Richard) - Move QEMUSGList in previous patch (David) - Have dma_buf_read/dma_buf_write return dma_addr_t (Peter) - Drop 'propagate MemTxResult' patch (David) - Added R-b tags Since v1: - Addressed

[PATCH v3 08/10] hw/dma: Fix format string issues using dma_addr_t

2022-01-11 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c| 2 +- hw/rdma/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 205dfdc6622..6c727dd0c08 100644

[PATCH v3 05/10] hw/dma: Remove CONFIG_USER_ONLY check

2022-01-11 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé DMA API should not be included in user-mode emulation. If so, build should fail. Remove the CONFIG_USER_ONLY check. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v3 01/10] stubs: Restrict fw_cfg to system emulation

2022-01-11 Thread Philippe Mathieu-Daudé
fw_cfg_arch_key_name() stub is only required for sysemu. Signed-off-by: Philippe Mathieu-Daudé --- stubs/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/meson.build b/stubs/meson.build index 71469c1d50a..363f6fa785d 100644 --- a/stubs/meson.build +++

Re: [RFC PATCH v3 5/7] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote: > When building on macOS 12 we get: > > audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] >

[PATCH] virtiofsd: Do not support blocking flock

2022-01-11 Thread Sebastian Hasler
With the current implementation, blocking flock can lead to deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts to perform a blocking flock request. Signed-off-by: Sebastian Hasler --- tools/virtiofsd/passthrough_ll.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH v5 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-11 Thread Cédric Le Goater
On branch https://github.com/legoater/qemu/commits/powernv-7.0, I have merged :    ppc/pnv: Move root port allocation under pnv_pec_stk_default_phb_realize()    ppc/pnv: Add a 'rp_model' class attribute for the PHB4 PEC    ppc/pnv: Remove PHB4 version property preparing ground for :   

Re: [PATCH v5 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-11 Thread Daniel Henrique Barboza
On 1/11/22 12:47, Cédric Le Goater wrote: On 1/11/22 15:57, Daniel Henrique Barboza wrote: On 1/11/22 11:42, Cédric Le Goater wrote: On 1/11/22 14:10, Daniel Henrique Barboza wrote: This patch introduces pnv-phb4 user creatable devices that are created in a similar manner as pnv-phb3

[PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ

2022-01-11 Thread Peter Maydell
Fix a comment in qdev-core.h where we incorrectly referred to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. Signed-off-by: Peter Maydell --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index

[PATCH] tests: Fix typo in check-help output

2022-01-11 Thread Philippe Mathieu-Daudé
Fix typo in 'make check-help' output. Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 4c564cf7899..3aba6224009 100644 --- a/tests/Makefile.include +++

Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ

2022-01-11 Thread Philippe Mathieu-Daudé
On 1/11/22 18:26, Peter Maydell wrote: > Fix a comment in qdev-core.h where we incorrectly referred > to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. > > Signed-off-by: Peter Maydell > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe

[PATCH v2 12/13] hw/intc/arm_gicv3_its: Check indexes before use, not after

2022-01-11 Thread Peter Maydell
In a few places in the ITS command handling functions, we were doing the range-check of an event ID or device ID only after using it as a table index; move the checks to before the uses. This misordering wouldn't have very bad effects because the tables are in guest memory anyway. Signed-off-by:

Re: [RFC PATCH v3 4/7] hvf: Remove deprecated hv_vcpu_flush() calls

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:58PM +0100, Philippe Mathieu-Daudé wrote: > When building on macOS 12, we get: > > In file included from ../target/i386/hvf/hvf.c:59: > ../target/i386/hvf/vmx.h:174:5: error: 'hv_vcpu_flush' is deprecated: first > deprecated in macOS 11.0 - This API has no

[PATCH v2 10/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapd()

2022-01-11 Thread Peter Maydell
Fix process_mapd() to consistently return CMD_STALL for memory errors and CMD_CONTINUE for parameter errors, as we claim in the comments that we do. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- hw/intc/arm_gicv3_its.c | 10 -- 1 file

[PATCH v2 09/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapc()

2022-01-11 Thread Peter Maydell
Fix process_mapc() to consistently return CMD_STALL for memory errors and CMD_CONTINUE for parameter errors, as we claim in the comments that we do. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- hw/intc/arm_gicv3_its.c | 8 +++- 1 file changed, 3

[PATCH] hw/arm: kudo add lm75s behind bus 1 switch at 75

2022-01-11 Thread Patrick Venture
Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/arm/npcm7xx_boards.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 7d0f3148be..d701e5cc55 100644 --- a/hw/arm/npcm7xx_boards.c +++

[PATCH v2 07/13] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting

2022-01-11 Thread Peter Maydell
Refactor process_its_cmd() so that it consistently uses the structure do thing; if (error condition) { return early; } do next thing; rather than doing some of the work nested inside if (not error) code blocks. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by:

[PATCH v2 05/13] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions

2022-01-11 Thread Peter Maydell
When an ITS detects an error in a command, it has an implementation-defined (CONSTRAINED UNPREDICTABLE) choice of whether to ignore the command, proceeding to the next one in the queue, or to stall the ITS command queue, processing nothing further. The behaviour required when the read of the

Re: [PULL 06/26] target/ppc: Improve logging in Radix MMU

2022-01-11 Thread Cédric Le Goater
On 1/11/22 17:51, Peter Maydell wrote: On Tue, 4 Jan 2022 at 07:31, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater Reviewed-by: Richard Henderson Message-Id: <20211222071002.1568894-1-...@kaod.org> Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 55

[PATCH v2 06/13] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()

2022-01-11 Thread Peter Maydell
Fix process_its_cmd() to consistently return CMD_STALL for memory errors and CMD_CONTINUE for parameter errors, as we claim in the comments that we do. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- hw/intc/arm_gicv3_its.c | 22 +++---

Re: [PATCH 8/8] tools/vhost-user-video: Add initial vhost-user-video vmm

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > This vmm translates from virtio-video v3 protocol and writes > to a v4l2 mem2mem stateful decoder/encoder device [1]. v3 was > chosen as that is what the virtio-video Linux frontend driver > implements. > > This allows for testing with the v4l2 vicodec test codec [2] >

Re: [RFC PATCH v3 1/7] configure: Allow passing extra Objective C compiler flags

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:55PM +0100, Philippe Mathieu-Daudé wrote: > We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment > variables, or via configure --extra-cflags / --extra-cxxflags / > --extra-ldflags options. Provide similar behavior for Objective C: > use existing flags

[PATCH v2 03/13] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value

2022-01-11 Thread Peter Maydell
process_its_cmd() returns a bool, like all the other process_ functions. However we were putting its return value into 'res', not 'result', which meant we would ignore it when deciding whether to continue or stall the command queue. Fix the typo. Signed-off-by: Peter Maydell Reviewed-by: Alex

[PATCH v2 11/13] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code

2022-01-11 Thread Peter Maydell
The ITS has several tables which all share a similar format, described by the TableDesc struct: the guest may configure them to be a single-level table or a two-level table. Currently we open-code the process of finding the table entry in all the functions which read or write the device table or

[PATCH v2 04/13] hw/intc/arm_gicv3_its: Don't use data if reading command failed

2022-01-11 Thread Peter Maydell
In process_cmdq(), we read 64 bits of the command packet, which contain the command identifier, which we then switch() on to dispatch to an appropriate sub-function. However, if address_space_ldq_le() reports a memory transaction failure, we still read the command identifier out of the data and

[PATCH v2 13/13] hw/intc/arm_gicv3_its: Range-check ICID before indexing into collection table

2022-01-11 Thread Peter Maydell
In process_its_cmd(), we read an ICID out of the interrupt table entry, and then use it as an index into the collection table. Add a check that it is within range for the collection table first. This check is not strictly necessary, because: * we range check the ICID from the guest before

Re: [PATCH v6 09/23] target/riscv: Implement AIA local interrupt priorities

2022-01-11 Thread Anup Patel
On Mon, Jan 10, 2022 at 6:38 PM Frank Chang wrote: > > Anup Patel 於 2021年12月30日 週四 下午8:38寫道: >> >> From: Anup Patel >> >> The AIA spec defines programmable 8-bit priority for each local interrupt >> at M-level, S-level and VS-level so we extend local interrupt processing >> to consider AIA

[PATCH v2 01/13] hw/intc/arm_gicv3_its: Fix event ID bounds checks

2022-01-11 Thread Peter Maydell
In process_its_cmd() and process_mapti() we must check the event ID against a limit defined by the size field in the DTE, which specifies the number of ID bits minus one. Convert this code to our num_foo convention: * change the variable names * use uint64_t and 1ULL when calculating the number

[PATCH v2 02/13] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention

2022-01-11 Thread Peter Maydell
The bounds check on the number of interrupt IDs is correct, but doesn't match our convention; change the variable name, initialize it to the 2^n value rather than (2^n)-1, and use >= instead of > in the comparison. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée ---

[PATCH v2 08/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapti()

2022-01-11 Thread Peter Maydell
Fix process_mapti() to consistently return CMD_STALL for memory errors and CMD_CONTINUE for parameter errors, as we claim in the comments that we do. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- hw/intc/arm_gicv3_its.c | 28

[PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-11 Thread Peter Maydell
I've been working on the ITS to add support for the GICv4 functionality. In the course of that I found a handful of bugs in it and also some places where the code benefited from refactoring to make it a better base to put in the GICv4 parts. This patchset is just the bugfixes and cleanups, because

RFC: QMP configuration - allocating/setting qdev array properties?

2022-01-11 Thread Mirela Grujic
Hi, While working on a prototype and configuring a whole machine using QMP we run into the following scenario. Some device models use array properties. The array is allocated when len- property is set, then, individual elements of the array can be set as any other property (see

Re: [PULL 06/26] target/ppc: Improve logging in Radix MMU

2022-01-11 Thread Peter Maydell
On Tue, 4 Jan 2022 at 07:31, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater > Reviewed-by: Richard Henderson > Message-Id: <20211222071002.1568894-1-...@kaod.org> > Signed-off-by: Cédric Le Goater > --- > target/ppc/mmu-radix64.c | 55 +--- > 1

Re: [PATCH v7 0/6] ARM virt: Support CPU cluster topology

2022-01-11 Thread Peter Maydell
On Fri, 7 Jan 2022 at 08:32, Yanan Wang wrote: > > This v7 series enables the support for CPU cluster topology on > ARM virt machines. The generic infrastructure for CPU cluster > parameter has been in upstream. > The patches in this series do: > - Enable CPU cluster support on ARM virt

Re: [PATCH 0/8] virtio: Add vhost-user based Video decode

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > This series adds support for virtio-video decoder devices in Qemu > and also provides a vhost-user-video vmm implementation. This brings up a bunch of failures in CI: https://gitlab.com/stsquad/qemu/-/pipelines/445691849/failures A bunch are probably solved with

Re: [PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG

2022-01-11 Thread Jean-Philippe Brucker
Hi Michael, On Tue, Jan 11, 2022 at 10:40:28AM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote: > > Hi Jean, Michael, > > > > On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote: > > > Replace the VIRTIO_IOMMU_F_BYPASS feature with > > >

Re: [RFC PATCH v3 3/7] hvf: Make hvf_get_segments() / hvf_put_segments() local

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:57PM +0100, Philippe Mathieu-Daudé wrote: > Both hvf_get_segments/hvf_put_segments() functions are only > used within x86hvf.c: do not declare them as public API. > Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman > Signed-off-by: Philippe

Re: [PATCH 7/8] hw/display: add vhost-user-video-pci

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > Add boiler plate code for vhost-user-video-pci. > > Example > -device vhost-user-video-pci,chardev=video,id=video > -chardev socket,path=video.sock,id=video > > Signed-off-by: Peter Griffin Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 4/8] vhost-user-video: add meson subdir build logic

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > Signed-off-by: Peter Griffin > --- > tools/meson.build | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/tools/meson.build b/tools/meson.build > index 3e5a0abfa2..3314b5efc5 100644 > --- a/tools/meson.build > +++ b/tools/meson.build > @@ -24,3 +24,12

Re: [PATCH 3/8] vhost-user-video: boiler plate code for vhost-user-video device

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > Signed-off-by: Peter Griffin > --- > hw/display/Kconfig | 5 + > hw/display/meson.build | 3 + > hw/display/vhost-user-video.c| 386 +++ > include/hw/virtio/vhost-user-video.h | 41 +++ > 4 files

Re: [PATCH 1/6] target/arm: Fault on invalid TCR_ELx.TxSZ

2022-01-11 Thread Peter Maydell
On Thu, 6 Jan 2022 at 18:27, Peter Maydell wrote: > > On Wed, 8 Dec 2021 at 23:16, Richard Henderson > wrote: > > > > Without FEAT_LVA, the behaviour of programming an invalid value > > is IMPLEMENTATION DEFINED. With FEAT_LVA, programming an invalid > > minimum value requires a Translation

Re: [PATCH v3 0/3] block: Minor vhost-user-blk fixes

2022-01-11 Thread Kevin Wolf
Am 07.01.2022 um 11:54 hat Philippe Mathieu-Daudé geschrieben: > - Add vhost-user-blk help to qemu-storage-daemon, > - Do not list vhost-user-blk in BlockExportType when > CONFIG_VHOST_USER_BLK_SERVER is disabled. Thanks, applied to the block branch. Kevin

Re: [PATCH v5 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-11 Thread Cédric Le Goater
On 1/11/22 15:57, Daniel Henrique Barboza wrote: On 1/11/22 11:42, Cédric Le Goater wrote: On 1/11/22 14:10, Daniel Henrique Barboza wrote: This patch introduces pnv-phb4 user creatable devices that are created in a similar manner as pnv-phb3 devices, allowing the user to interact with the

Re: [PATCH v2] block-backend: prevent dangling BDS pointers across aio_poll()

2022-01-11 Thread Stefan Hajnoczi
On Mon, Jan 10, 2022 at 07:57:05PM +0100, Hanna Reitz wrote: > On 14.12.21 15:35, Stefan Hajnoczi wrote: > > The BlockBackend root child can change when aio_poll() is invoked. This > > happens when a temporary filter node is removed upon blockjob > > completion, for example. > > > > Functions in

Re: [PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG

2022-01-11 Thread Michael S. Tsirkin
On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote: > Hi Jean, Michael, > > On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote: > > Replace the VIRTIO_IOMMU_F_BYPASS feature with > > VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch > > global bypass on and off. > > >

[PATCH v3 2/2] iotests/stream-error-on-reset: New test

2022-01-11 Thread Stefan Hajnoczi
From: Hanna Reitz Test the following scenario: - Simple stream block in two-layer backing chain (base and top) - The job is drained via blk_drain(), then an error occurs while the job settles the ongoing request - And so the job completes while in blk_drain() This was reported as a segfault,

Re: [PATCH 0/8] virtio: Add vhost-user based Video decode

2022-01-11 Thread Michael S. Tsirkin
On Thu, Dec 09, 2021 at 02:55:53PM +, Peter Griffin wrote: > This series adds support for virtio-video decoder devices in Qemu > and also provides a vhost-user-video vmm implementation. > > The vhost-user-video vmm currently parses virtio-vido v3 protocol > (as that is what the Linux frontend

[PATCH v3 1/2] block-backend: prevent dangling BDS pointers across aio_poll()

2022-01-11 Thread Stefan Hajnoczi
The BlockBackend root child can change when aio_poll() is invoked. This happens when a temporary filter node is removed upon blockjob completion, for example. Functions in block/block-backend.c must be aware of this when using a blk_bs() pointer across aio_poll() because the BlockDriverState

[PATCH v3 0/2] block-backend: prevent dangling BDS pointers across aio_poll()

2022-01-11 Thread Stefan Hajnoczi
This series fixes use-after-free bugs when blk->root changes across aio_poll(). For example, a temporary filter node can be removed by a blockjob when a drained section begins. If the caller doesn't hold a ref on the BDS then it will have been freed. Hanna Reitz (1):

Re: [PATCH 0/1] Fix -device JSON support wrt hotplug

2022-01-11 Thread Kevin Wolf
Am 05.01.2022 um 13:38 hat Daniel P. Berrangé geschrieben: > Libvirt switched to using -device JSON support, but we discovered in > testing that it is broken for hotplug, never sending DEVICE_DELETED > events. This is caused by a subtle refcount leak. Oops, so I fell again in the trap of this

Re: cirrus-ci: FreeBSD failure (lttng-ust package not found)

2022-01-11 Thread Warner Losh
On Tue, Jan 11, 2022 at 6:49 AM Daniel P. Berrangé wrote: > On Tue, Jan 11, 2022 at 02:11:14PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Alex, > > > > I am getting this failure for the x64-freebsd-*-build jobs [1, 2]: > > > > pkg: No packages available to install matching 'lttng-ust' have been

Re: [PATCH v5 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-11 Thread Daniel Henrique Barboza
On 1/11/22 11:42, Cédric Le Goater wrote: On 1/11/22 14:10, Daniel Henrique Barboza wrote: This patch introduces pnv-phb4 user creatable devices that are created in a similar manner as pnv-phb3 devices, allowing the user to interact with the PHBs directly instead of creating PCI Express

qemu-efi-aarch64 package

2022-01-11 Thread Khaled Mohammed
Dears, Hope this mail finds you well, Currently I’m trying to install the “qemu-efi-aarch64” package for centos 7 but it is not available. Is there any alternative or something I can do to make it work ? Thanks in advance, Khaled.

Re: [PATCH 2/8] MAINTAINERS: Add virtio-video section

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > Add myself as maintainer of the virtio-video files added > in this series. > > Signed-off-by: Peter Griffin Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2022-01-11 Thread Eric DeVolder
Ani, I'll change this from the g_assert_not_reached() back to STATUS_FAILED. Alas I realized I didn't do the last step in producing the new ACPI tables in the patchset, so even though I just put out v12, I'll need to do a followup v13 with the missing tables. Thanks! eric On 1/11/22 02:35, Ani

[PATCH] hw/vhost-user-i2c: Add support for VIRTIO_I2C_F_ZERO_LENGTH_REQUEST

2022-01-11 Thread Viresh Kumar
VIRTIO_I2C_F_ZERO_LENGTH_REQUEST is a mandatory feature, that must be implemented by everyone. Add its support. Signed-off-by: Viresh Kumar --- hw/virtio/vhost-user-i2c.c | 10 -- include/hw/virtio/vhost-user-i2c.h | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-)

Re: [PATCH 1/8] vhost-user-video: Add a README.md with cheat sheet of commands

2022-01-11 Thread Alex Bennée
Peter Griffin writes: > Signed-off-by: Peter Griffin > --- > tools/vhost-user-video/README.md | 98 > 1 file changed, 98 insertions(+) > create mode 100644 tools/vhost-user-video/README.md > > diff --git a/tools/vhost-user-video/README.md >

Re: [PATCH v2] target/arm/cpu64: Use 32-bit GDBstub when running in 32-bit KVM mode

2022-01-11 Thread Ard Biesheuvel
On Tue, 11 Jan 2022 at 15:11, Peter Maydell wrote: > > On Sat, 8 Jan 2022 at 15:10, Ard Biesheuvel wrote: > > > > When running under KVM, we may decide to run the CPU in 32-bit mode, by > > setting the 'aarch64=off' CPU option. In this case, we need to switch to > > the 32-bit version of the GDB

Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes

2022-01-11 Thread Fabian Ebner
Am 28.10.21 um 21:37 schrieb Markus Armbruster: Markus Armbruster writes: Stefan Reiter writes: Since the removal of the generic 'qmp_change' command, one can no longer replace the 'default' VNC display listen address at runtime (AFAIK). For our users who need to set up a secondary VNC

Re: [PATCH] target/s390x: Fix 32-bit shifts

2022-01-11 Thread David Hildenbrand
On 10.01.22 19:59, Ilya Leoshkevich wrote: > Both 32- and 64-bit shifts use lowest 6 address bits. The current code > special-cases 32-bit shifts to use only 5 bits, which is not correct. > I assume for 32-bit shifts, we could only shift by 31, not by 32 or bigger. So it's impossible to zero out

Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-11 Thread Marc Zyngier
On Tue, 11 Jan 2022 13:58:49 +, Peter Maydell wrote: > > On Sat, 8 Jan 2022 at 13:42, Marc Zyngier wrote: > > > > On 2022-01-07 20:23, Richard Henderson wrote: > > > On 1/7/22 7:01 AM, Marc Zyngier wrote: > > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu, > > >>

Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-11 Thread Peter Maydell
On Sat, 8 Jan 2022 at 13:42, Marc Zyngier wrote: > > On 2022-01-07 20:23, Richard Henderson wrote: > > On 1/7/22 7:01 AM, Marc Zyngier wrote: > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu, > >> Error **errp) > >> return; > >> } > >> -/*

Re: [PATCH v5 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-11 Thread Cédric Le Goater
On 1/11/22 14:10, Daniel Henrique Barboza wrote: This patch introduces pnv-phb4 user creatable devices that are created in a similar manner as pnv-phb3 devices, allowing the user to interact with the PHBs directly instead of creating PCI Express Controllers that will create a certain amount of

Re: [PATCH] clock-vmstate: Add missing END_OF_LIST

2022-01-11 Thread Alex Bennée
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv > > Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider") > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Alex Bennée -- Alex Bennée

cirrus-ci: FreeBSD failure (lttng-ust package not found)

2022-01-11 Thread Philippe Mathieu-Daudé
Hi Alex, I am getting this failure for the x64-freebsd-*-build jobs [1, 2]: pkg: No packages available to install matching 'lttng-ust' have been found in the repositories Do you know it this is fixed in your testing/next branch? Thanks, Phil. [1]

Re: [PATCH v2] target/arm/cpu64: Use 32-bit GDBstub when running in 32-bit KVM mode

2022-01-11 Thread Peter Maydell
On Sat, 8 Jan 2022 at 15:10, Ard Biesheuvel wrote: > > When running under KVM, we may decide to run the CPU in 32-bit mode, by > setting the 'aarch64=off' CPU option. In this case, we need to switch to > the 32-bit version of the GDB stub too, so that GDB has the correct view > of the CPU state.

[PATCH v5 2/5] ppc/pnv: move PHB4 XSCOM init to phb4_realize()

2022-01-11 Thread Daniel Henrique Barboza
The 'stack->phb_regs_mr' PHB4 passthrough XSCOM initialization relies on 'stack->phb' being not NULL. Moving 'stack->phb_regs_mr' region_init() and add_subregion() to phb4_realize() time is a natural thing to do since it's strictly PHB related. The remaining XSCOM initialization is also related

Re: [PULL 0/2] SD/MMC patches for 2022-01-08

2022-01-11 Thread Peter Maydell
On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote: > > Hi Richard, > > This is the SD/MMC PR that ought to be sent previously. > > The following changes since commit b5a3d8bc9146ba22a25116cb748c97341bf99737: > > Merge tag 'pull-misc-20220103' of https://gitlab.com/rth7680/qemu into >

Re: [PATCH] clock-vmstate: Add missing END_OF_LIST

2022-01-11 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 11 Jan 2022 at 10:19, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv > > > > Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider") >

[PATCH v4 20/23] multifd: Support for zero pages transmission

2022-01-11 Thread Juan Quintela
This patch adds counters and similar. Logic will be added on the following patch. Signed-off-by: Juan Quintela --- migration/multifd.h| 13 - migration/multifd.c| 22 +++--- migration/trace-events | 2 +- 3 files changed, 32 insertions(+), 5 deletions(-)

Re: [PATCH v3 4/6] migration: Remove masking for compression

2022-01-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Remove the mask in the call to ram_release_pages(). Nothing else does > it, and if the offset has that bits set, we have a lot of trouble. > > Signed-off-by: Juan Quintela Yeh I think that comes from ram_save_target_page which does: ram_addr_t

Re: [PATCH v4 0/3] hw/net: Move MV88W8618 network device out of hw/arm/ directory

2022-01-11 Thread Peter Maydell
On Fri, 7 Jan 2022 at 18:44, Philippe Mathieu-Daudé wrote: > > This series simply extract the MV88W8618 device from the ARM > machine in hw/arm/ and move it to hw/net/. > > Since v3: > - Rebased on latest main/master Applied to target-arm.next, thanks. -- PMM

[PATCH v4 23/23] migration: Export ram_release_page()

2022-01-11 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.h | 2 ++ migration/ram.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/ram.h b/migration/ram.h index c515396a9a..6dca396a6b 100644 --- a/migration/ram.h +++ b/migration/ram.h @@ -66,6 +66,8 @@ int

[PATCH v5 5/5] ppc/pnv: turn pnv_phb4_update_regions() into static

2022-01-11 Thread Daniel Henrique Barboza
Its only callers are inside pnv_phb4.c. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 52 +- include/hw/pci-host/pnv_phb4.h | 1 - 2 files changed, 26 insertions(+), 27 deletions(-) diff --git

[PATCH v4 21/23] multifd: Zero pages transmission

2022-01-11 Thread Juan Quintela
This implements the zero page dection and handling. Signed-off-by: Juan Quintela --- Add comment for offset (dave) --- migration/multifd.h | 4 migration/multifd.c | 36 ++-- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 07/14] vfio-user: run vfio-user context

2022-01-11 Thread Jag Raman
> On Jan 11, 2022, at 4:36 AM, Stefan Hajnoczi wrote: > > On Mon, Jan 10, 2022 at 05:56:25PM +, John Levon wrote: >> On Thu, Jan 06, 2022 at 01:35:32PM +, Stefan Hajnoczi wrote: >> >>> +static void vfu_object_attach_ctx(void *opaque) >>> +{ >>> +VfuObject *o = opaque;

Re: [PATCH v3 5/6] migration: simplify do_compress_ram_page

2022-01-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > The goto is not needed at all. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c >

[PATCH v5 1/5] ppc/pnv: set phb4 properties in stk_realize()

2022-01-11 Thread Daniel Henrique Barboza
Moving all phb4 properties setup to stk_realize() keeps this logic in a single place instead of having it scattered between stk_realize() and pec_realize(). 'phb->index' can be retrieved using stack->stack_no and pnv_phb4_pec_get_phb_id(), deprecating the use of 'phb-id' alias that was being used

<    1   2   3   4   >