[PULL 37/61] hw/riscv: Remove macros for ELF BIOS image names

2022-01-21 Thread Alistair Francis
From: Anup Patel Now that RISC-V Spike machine can use BIN BIOS images, we remove the macros used for ELF BIOS image names. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Signed-off-by: Alistair Francis --- include/hw/riscv/boot.h | 2 -- hw/riscv/spike.c

Re: [RFC PATCH 2/7] x86: Add AMX XTILECFG and XTILEDATA components

2022-01-21 Thread Yang Zhong
On Tue, Jan 18, 2022 at 01:39:59PM +0100, Paolo Bonzini wrote: > On 1/10/22 09:23, Tian, Kevin wrote: > >> > >>AMX XTILECFG and XTILEDATA are managed by XSAVE feature > >>set. State component 17 is used for 64-byte TILECFG register > >>(XTILECFG state) and component 18 is used for 8192 bytes >

[PULL 61/61] target/riscv: Relax UXL field for debugging

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-24-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/csr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/csr.c

Re: [PATCH 1/3] qsd: Add pre-init argument parsing pass

2022-01-21 Thread Markus Armbruster
Hanna Reitz writes: > On 20.01.22 17:00, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 19.01.2022 um 14:44 hat Hanna Reitz geschrieben: On 19.01.22 13:58, Markus Armbruster wrote: > Hanna Reitz writes: > >> We want to add a --daemonize argument to QSD's command

Re: [RFC PATCH 4/7] x86: Add XFD faulting bit for state components

2022-01-21 Thread Yang Zhong
On Tue, Jan 18, 2022 at 01:52:51PM +0100, Paolo Bonzini wrote: > On 1/7/22 10:31, Yang Zhong wrote: > >-uint32_t need_align; > >+uint32_t need_align, support_xfd; > > These can be replaced by a single field "uint32_t ecx". > > You can add also macros like > > #define

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Thomas Huth
On 20/01/2022 16.13, Peter Maydell wrote: On Fri, 30 Jul 2021 at 16:12, Peter Maydell wrote: "make check-acceptance" takes way way too long. I just did a run on an arm-and-aarch64-targets-only debug build and it took over half an hour, and this despite it skipping or cancelling 26 out of 58

Re: [PATCH] target/ppc/mmu_common: Fix SRR1/MSR error code on Book-E

2022-01-21 Thread Vitaly Cheptsov
Hi Cédric, > This looks correct and even fixing an issue that Mario reported > on the TCG e6500 CPU with a kernel + KVM compiled in : > > > https://lore.kernel.org/all/R5JFVM$911e343ff81933b99d53fd0992d88...@locati.it/ > > KVM has some issues also with the e6500 but that's another problem > I

Re: [PATCH 1/3] qsd: Add pre-init argument parsing pass

2022-01-21 Thread Markus Armbruster
Hanna Reitz writes: > On 21.01.22 07:10, Markus Armbruster wrote: >> Hanna Reitz writes: >> >>> On 20.01.22 17:00, Markus Armbruster wrote: Kevin Wolf writes: > Am 19.01.2022 um 14:44 hat Hanna Reitz geschrieben: >> On 19.01.22 13:58, Markus Armbruster wrote: >>> Hanna

Re: [PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 11:36, Philippe Mathieu-Daudé wrote: > Correct the libvirt-ci repository URL to avoid this warning when > cloning / refreshing the submodule: > > warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ > > Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build

Re: [RFC PATCH v5 14/14] target/riscv: rvk: expose zbk* and zk* properties

2022-01-21 Thread Weiwei Li
在 2022/1/21 上午8:35, Alistair Francis 写道: On Wed, Jan 19, 2022 at 11:09 PM Weiwei Li wrote: Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair Thanks for your comments. Regards, Weiwei Li --- target/riscv/cpu.c | 13 + 1 file

[PATCH 2/2] block/export: Add vhost-user-blk resize support

2022-01-21 Thread Xie Yongji
To support block resize, this updates the capacity field in configuration space and use vu_notify_config_change() to notify the vhost-user master on the block resize callback. Signed-off-by: Xie Yongji --- block/export/vhost-user-blk-server.c | 16 1 file changed, 16

Re: [PATCH v4 1/8] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v1] include: hw: remove ibex_plic.h

2022-01-21 Thread Alistair Francis
On Fri, Jan 21, 2022 at 3:50 PM Alistair Francis wrote: > > From: Wilfred Mallawa > > This patch removes the left-over/unused `ibex_plic.h` file. Previously > used by opentitan, which now follows the RISC-V standard and uses the > SiFivePlicState. > > Fixes: 434e7e021 ("hw/intc: Remove the Ibex

[PULL 40/61] target/riscv: Don't save pc when exception return

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei As pc will be written by the xepc in exception return, just ignore pc in translation. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-3-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis ---

[PULL 50/61] target/riscv: Alloc tcg global for cur_pm[mask|base]

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Replace the array of pm_mask/pm_base with scalar variables. Remove the cached array value in DisasContext. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-13-zhiwei_...@c-sky.com Signed-off-by: Alistair

[PATCH v2] hw/nvme: fix CVE-2021-3929

2022-01-21 Thread Klaus Jensen
From: Klaus Jensen This fixes CVE-2021-3929 "locally" by denying DMA to the iomem of the device itself. This still allows DMA to MMIO regions of other devices (e.g. doing P2P DMA to the controller memory buffer of another NVMe device). Fixes: CVE-2021-3929 Reported-by: Qiuhao Li Reviewed-by:

Re: [PATCH] target/ppc/mmu_common: Fix SRR1/MSR error code on Book-E

2022-01-21 Thread Cédric Le Goater
Hello Vitaly On 1/21/22 01:02, Vitaly Cheptsov wrote: Hello, PowerPC e500mc defines MSR bit 35 differently from most other PowerPC variants. In particular, for e500mc this is GS (Guest Supervisor) bit[1], while for others it is NOEXEC GUARD bit[2]. QEMU ignores this architectural difference

Re: [PATCH v11 3/4] softmmu/dirtylimit: implement virtual CPU throttle

2022-01-21 Thread Peter Xu
On Fri, Jan 21, 2022 at 04:07:24PM +0800, Hyman Huang wrote: > Hi, Peter, i'm working on simplifying the algorithm. > Current throttle logic is like the following: > > 1. If error value(|quota - current|) less than 25MB/s, we assert throttle > already done and do nothing. > > 2. Start to

[PULL 53/61] target/riscv: Split out the vill from vtype

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei We need not specially process vtype when XLEN changes. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-16-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 1 +

Re: [RFC PATCH 3/7] x86: Grant AMX permission for guest

2022-01-21 Thread Yang Zhong
On Tue, Jan 18, 2022 at 02:06:55PM +0100, Paolo Bonzini wrote: > Sorry, hit send on the wrong window. This is the only patch that > will require a bit more work. > > On 1/18/22 13:52, Paolo Bonzini wrote: > >>@@ -124,6 +150,8 @@ void x86_cpus_init(X86MachineState *x86ms, > >>int

[PATCH v4 8/8] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.cirrus.yml

[PULL 57/61] target/riscv: Adjust vector address with mask

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei The mask comes from the pointer masking extension, or the max value corresponding to XLEN bits. Signed-off-by: LIU Zhiwei Acked-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: 20220120122050.41546-20-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis ---

[PULL 44/61] target/riscv: Ignore the pc bits above XLEN

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei The read from PC for translation is in cpu_get_tb_cpu_state, before translation. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-7-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis ---

[PULL 46/61] target/riscv: Use gdb xml according to max mxlen

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-9-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 8 ++--- target/riscv/gdbstub.c | 71

Re: [PATCH v8 00/23] QEMU RISC-V AIA support

2022-01-21 Thread Alistair Francis
On Fri, Jan 21, 2022 at 2:02 AM Anup Patel wrote: > > Hi Alistair, > > On Wed, Jan 19, 2022 at 8:56 PM Anup Patel wrote: > > > > From: Anup Patel > > > > The advanced interrupt architecture (AIA) extends the per-HART local > > interrupt support. Along with this, it also adds IMSIC (MSI

[PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Philippe Mathieu-Daudé via
Refresh lcitool submodule and the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-

Re: [PATCH v1] include: hw: remove ibex_plic.h

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 06:50, Alistair Francis wrote: > From: Wilfred Mallawa > > This patch removes the left-over/unused `ibex_plic.h` file. Previously > used by opentitan, which now follows the RISC-V standard and uses the > SiFivePlicState. > > Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC") >

Re: [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/20/22 12:30, Philippe Mathieu-Daudé wrote: > From: Michael Tokarev > > For a long time, we assumed that libxml2 is neecessary for parallels > block format support (block/parallels*). However, this format actually > does not use libxml [*]. Since this is the only user of libxml2 in > while

[PATCH v4 3/8] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-21 Thread Philippe Mathieu-Daudé via
The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by: Daniel P. Berrangé

Re: [PATCH v3 10/19] block: introduce fleecing block driver

2022-01-21 Thread Vladimir Sementsov-Ogievskiy
20.01.2022 19:11, Hanna Reitz wrote: On 22.12.21 18:40, Vladimir Sementsov-Ogievskiy wrote: Introduce a new driver, that works in pair with copy-before-write to improve fleecing. Without fleecing driver, old fleecing scheme looks as follows: [guest]    |    |root    v [copy-before-write]

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Markus Armbruster
Thomas Huth writes: > On 20/01/2022 16.13, Peter Maydell wrote: >> On Fri, 30 Jul 2021 at 16:12, Peter Maydell wrote: >>> >>> "make check-acceptance" takes way way too long. I just did a run >>> on an arm-and-aarch64-targets-only debug build and it took over >>> half an hour, and this despite

[PULL 60/61] target/riscv: Enable uxl field write

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-23-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 3 +++ target/riscv/csr.c | 28 ++-- 2

[PULL 36/61] hw/riscv: spike: Allow using binary firmware as bios

2022-01-21 Thread Alistair Francis
From: Anup Patel Currently, we have to use OpenSBI firmware ELF as bios for the spike machine because the HTIF console requires ELF for parsing "fromhost" and "tohost" symbols. The latest OpenSBI can now optionally pick-up HTIF register address from HTIF DT node so using this feature spike

[PULL 55/61] target/riscv: Remove VILL field in VTYPE

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Acked-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-18-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/riscv/cpu.h

[PULL 54/61] target/riscv: Adjust vsetvl according to XLEN

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-17-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 5 + target/riscv/vector_helper.c | 7 +-- 2 files

[PULL 41/61] target/riscv: Sign extend link reg for jal and jalr

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-4-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/translate.c| 4 +--- target/riscv/insn_trans/trans_rvi.c.inc | 4 +--- 2 files changed, 2

[PULL 56/61] target/riscv: Fix check range for first fault only

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Only check the range that has passed the address translation. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-19-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/vector_helper.c |

[PULL 48/61] target/riscv: Adjust csr write mask with XLEN

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Write mask is representing the bits we care about. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-11-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/op_helper.c|

Re: [PATCH v11 3/4] softmmu/dirtylimit: implement virtual CPU throttle

2022-01-21 Thread Hyman Huang
Again, I won't ask for a good algorithm as the 1st version, but then I think it's nicer we have the simplest algorithm merged first, which should be very easy to verify. Hi, Peter, i'm working on simplifying the algorithm. Current throttle logic is like the following: 1. If error

[PATCH v4 6/8] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies

[PULL 35/61] target/riscv: rvv-1.0: Allow Zve32f extension to be turned on

2022-01-21 Thread Alistair Francis
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Message-id: 20220118014522.13613-18-frank.ch...@sifive.com Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index

[PULL 33/61] target/riscv: rvv-1.0: Add Zve32f support for widening type-convert insns

2022-01-21 Thread Alistair Francis
From: Frank Chang Vector widening conversion instructions are provided to and from all supported integer EEWs for Zve32f extension. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Message-id: 20220118014522.13613-16-frank.ch...@sifive.com Signed-off-by: Alistair Francis ---

Re: [RFC PATCH 1/7] x86: Fix the 64-byte boundary enumeration for extended state

2022-01-21 Thread Yang Zhong
On Tue, Jan 18, 2022 at 01:37:20PM +0100, Paolo Bonzini wrote: > On 1/11/22 03:22, Yang Zhong wrote: > > Thanks Kevin, I will update this in next version. > > Also: > > The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] > indicate whether the extended state component locates >

Re: [PATCH 1/3] qsd: Add pre-init argument parsing pass

2022-01-21 Thread Hanna Reitz
On 21.01.22 07:10, Markus Armbruster wrote: Hanna Reitz writes: On 20.01.22 17:00, Markus Armbruster wrote: Kevin Wolf writes: Am 19.01.2022 um 14:44 hat Hanna Reitz geschrieben: On 19.01.22 13:58, Markus Armbruster wrote: Hanna Reitz writes: We want to add a --daemonize argument to

Re: [PATCH v5 28/31] block.c: assert BQL lock held in bdrv_co_invalidate_cache

2022-01-21 Thread Emanuele Giuseppe Esposito
On 20/01/2022 14:48, Kevin Wolf wrote: Am 20.01.2022 um 14:22 hat Paolo Bonzini geschrieben: On 1/19/22 19:34, Kevin Wolf wrote: So if we go back to a bdrv_invalidate_cache() that does all the graph manipulations (and asserts that we're in the main loop) and then have a much smaller

[PATCH v4 1/8] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v4 7/8] tests/lcitool: Remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Update lcitool's qemu.yml and refresh the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-

Re: [PATCH 1/3] qsd: Add pre-init argument parsing pass

2022-01-21 Thread Hanna Reitz
On 21.01.22 11:27, Markus Armbruster wrote: Hanna Reitz writes: On 21.01.22 07:10, Markus Armbruster wrote: Hanna Reitz writes: On 20.01.22 17:00, Markus Armbruster wrote: Kevin Wolf writes: Am 19.01.2022 um 14:44 hat Hanna Reitz geschrieben: On 19.01.22 13:58, Markus Armbruster

[PULL 43/61] target/riscv: Create xl field in env

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Current xlen has been used in helper functions and many other places. The computation of current xlen is not so trivial, so that we should recompute it as little as possible. Fortunately, xlen only changes in very seldom cases, such as exception, misa write, mstatus write, cpu

[PULL 34/61] target/riscv: rvv-1.0: Add Zve32f support for narrowing type-convert insns

2022-01-21 Thread Alistair Francis
From: Frank Chang Vector narrowing conversion instructions are provided to and from all supported integer EEWs for Zve32f extension. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Message-id: 20220118014522.13613-17-frank.ch...@sifive.com Signed-off-by: Alistair Francis ---

[PULL 42/61] target/riscv: Sign extend pc for different XLEN

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei When pc is written, it is sign-extended to fill the widest supported XLEN. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-5-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis ---

[PULL 45/61] target/riscv: Extend pc for runtime pc write

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei In some cases, we must restore the guest PC to the address of the start of the TB, such as when the instruction counter hits zero. So extend pc register according to current xlen for these cases. Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair

[PATCH 1/2] libvhost-user: Add vu_notify_config_change() to support config change notify

2022-01-21 Thread Xie Yongji
This adds a new API vu_notify_config_change() to support sending VHOST_USER_SLAVE_CONFIG_CHANGE_MSG message to notify that the configuration space has changed. Signed-off-by: Xie Yongji --- subprojects/libvhost-user/libvhost-user.c | 20

Re: [RESEND] target/riscv: Enable bitmanip Zicbo[m,z,p] instructions

2022-01-21 Thread Christoph Müllner
On Tue, Jan 18, 2022 at 9:31 PM Atish Patra wrote: > > On Tue, Jan 18, 2022 at 8:48 AM Christoph Muellner > wrote: > > > > The RISC-V base cache management operation ISA extension has been > > ratified [1]. This patch adds support for the defined instructions > > and CSRs. > > > > [1]

[PATCH v4 0/8] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
Missing review: Patch #2 (new) Refresh lcitool to latest and remove libxml2 (mjt). v4: - Fixed typos and cleaned checkpatch.pl (thuth) - Corrected libvirt-ci submodule URL v3: - fix 'refresh' helper to update cirrus-ci files (danpb) v2: - rebased (testing/next) - include mjt's libxml2 removal

[PATCH v4 5/8] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from

[PULL 39/61] target/riscv: Adjust pmpcfg access with mxl

2022-01-21 Thread Alistair Francis
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-id: 20220120122050.41546-2-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis --- target/riscv/csr.c | 19 +++ target/riscv/pmp.c | 12 2 files

[PATCH] target/ppc/mmu_common: Fix SRR1/MSR error code on Book-E

2022-01-21 Thread Vitaly Cheptsov
Book-E architecture does not set the error code in 31:27 bits of SRR1, but instead uses these bits for custom fields such as GS (Guest Supervisor). Wrongly setting these fields will result in QEMU crashes when attempting to execute not executable code due to the attempts to use Guest Supervisor

[PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Philippe Mathieu-Daudé via
Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 11:36:17AM +0100, Philippe Mathieu-Daudé wrote: > Correct the libvirt-ci repository URL to avoid this warning when > cloning / refreshing the submodule: > > warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ > > Fixes: 4ebb040f1fd ("tests: integrate

Re: [PATCH v4 8/8] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Thomas Huth
On 21/01/2022 13.23, Alex Bennée wrote: Peter Maydell writes: On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: No objection, but it's no replacement for looking into why these tests are so slow. The #1 reason for things being slow is not giving a damn :) See previous messages in

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 07:30:55AM -0700, Warner Losh wrote: > On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé > wrote: > > > On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > > > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > > > > Refresh lcitool submodule and the

[PATCH] docs: expand firmware descriptor to allow flash without NVRAM

2022-01-21 Thread Daniel P . Berrangé
The current firmware descriptor schema for flash requires that both the executable to NVRAM template paths be provided. This is fine for the most common usage of EDK2 builds in virtualization where the separate _CODE and _VARS files are provided. With confidential computing technology like AMD

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Peter Maydell
On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: > No objection, but it's no replacement for looking into why these tests > are so slow. > > The #1 reason for things being slow is not giving a damn :) See previous messages in the thread -- the test starts a full-fat guest OS including UEFI

Re: [PULL 00/61] riscv-to-apply queue

2022-01-21 Thread Peter Maydell
-20 > 16:13:17 +) > > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20220121-1 > > for you to fetch changes up to f297245f6a780f496fb171af6fcd21ff3e6783c3: > > target/riscv: Relax UX

Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes

2022-01-21 Thread Fabian Ebner
Am 28.10.21 um 21:37 schrieb Markus Armbruster: Markus Armbruster writes: 8< diff --git a/qapi/ui.json b/qapi/ui.json index 5292617b44..39ca0b5ead 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -69,8 +69,10 @@ 'base': { 'protocol': 'DisplayProtocol', 'password':

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Warner Losh
On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé wrote: > On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > > > Refresh lcitool submodule and the generated files by running: > > > > > >$ make lcitool-refresh > > > > > >

Re: [PATCH v2] vl: Add support to set properties when using JSON syntax for -device via -set option

2022-01-21 Thread Markus Armbruster
MkfsSion writes: > On 2022/1/19 22:08, Markus Armbruster wrote: [...] >> I don't think we should try to make -set work when using JSON arguments. >> > Thanks for your detailed review. You're welcome! > The following is my opinion towards implementing -set option for JSON > arguments. >

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 15:34, Daniel P. Berrangé wrote: > On Fri, Jan 21, 2022 at 07:30:55AM -0700, Warner Losh wrote: >> On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé >> wrote: >> >>> On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote:

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: Refresh lcitool submodule and the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-

Re: [PATCH v4 6/8] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU

Re: [PATCH v3 14/16] job.c: use job_get_aio_context()

2022-01-21 Thread Emanuele Giuseppe Esposito
On 19/01/2022 11:31, Paolo Bonzini wrote: diff --git a/blockjob.c b/blockjob.c index cf1f49f6c2..468ba735c5 100644 --- a/blockjob.c +++ b/blockjob.c @@ -155,14 +155,16 @@ static void child_job_set_aio_ctx(BdrvChild *c, AioContext *ctx,   bdrv_set_aio_context_ignore(sibling->bs, ctx,

[PATCH v5 5/7] tests/lcitool: Refresh submodule and remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Refresh lcitool submodule, update qemu.yml and refresh the generated files by running: $ make lcitool-refresh Note: This refreshment also removes libudev dependency on Fedora and CentOS due to libvirt-ci commit 18bfaee ("mappings: Improve

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-21 Thread Akihiko Odaki
On Fri, Jan 21, 2022 at 9:19 PM Vladislav Yaroshchuk wrote: > > > чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : >> >> On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: >> > Create separate netdevs for each vmnet operating mode: >> > - vmnet-host >> > - vmnet-shared >> > -

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 12:23:23PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: > >> No objection, but it's no replacement for looking into why these tests > >> are so slow. > >> > >> The #1 reason for things being slow is not

[PATCH v6 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
This is my last respin on this series which is fully reviewed. Refresh lcitool to latest and remove libxml2 (mjt). v6: - update libvirt-ci submodule to remove lttng-ust from FreeBSD runners v5: - update scripts/meson-buildoptions.sh (thuth) - squash libvirt-ci updates (thuth) v4: - Fixed typos

[PATCH v6 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

Re: [PATCH v4 02/12] mm/memfd: Introduce MFD_INACCESSIBLE flag

2022-01-21 Thread Steven Price
On 18/01/2022 13:21, Chao Peng wrote: > Introduce a new memfd_create() flag indicating the content of the > created memfd is inaccessible from userspace. It does this by force > setting F_SEAL_INACCESSIBLE seal when the file is created. It also set > F_SEAL_SEAL to prevent future sealing, which

Re: [PATCH v6 07/12] hw/ssi: Add a model of Xilinx Versal's OSPI flash memory controller

2022-01-21 Thread Francisco Iglesias
Hi Luc, All the suggestions and corrections look good to me so brought them in in v7! Thank you very much reviewing! Best regards, Francisco Iglesias On [2022 Jan 18] Tue 22:46:32, Luc Michel wrote: > Hi Francisco, > > Impressive beast :-) Nicely done. Maybe I would have split it in a >

Re: [PATCH v4 7/8] tests/lcitool: Remove libxml2

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: The previous commit removed all uses of libxml2. Update lcitool's qemu.yml and refresh the generated files by running: $ make lcitool-refresh Could you merge patch 4/8 and 7/8 so that there is only one refreshment patch in your series?

Re: [PATCH v13 1/7] net/vmnet: add vmnet dependency and customizable option

2022-01-21 Thread Vladislav Yaroshchuk
Hi Roman, чт, 20 янв. 2022 г. в 10:14, Roman Bolshakov : > On Thu, Jan 13, 2022 at 08:22:13PM +0300, Vladislav Yaroshchuk wrote: > > vmnet.framework dependency is added with 'vmnet' option > > to enable or disable it. Default value is 'auto'. > > > > vmnet features to be used are available since

[PATCH] tests/qtest/ide-test: Remove bad retry_isa test

2022-01-21 Thread Thomas Huth
The retry_isa test is not doing what it was intended for: The test_retry_flush() function ignores the machine parameter completely and thus this test does not get run with the "isapc" machine. Moreover, in the course of time, the test_retry_flush() has been changed to depend on PCI-related

Re: Help with ppc e500 tlb usage

2022-01-21 Thread Cédric Le Goater
Hello Jesse, ( For some reason, your email never reached my mailbox. In the future, could please also Cc: qemu-devel@nongnu.org. ) On 1/18/22 20:40, Jesse Millwood wrote: Hello, I'm trying to get the e500 to set the initial tlb entry to mirror what the platform expects. I have made some

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-21 Thread Vladislav Yaroshchuk
чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Sure I'm late to the party but what if we add only one

[PATCH v5 2/7] gitmodules: Correct libvirt-ci submodule URL

2022-01-21 Thread Philippe Mathieu-Daudé via
Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Reviewed-by: Daniel P. Berrangé

[PATCH v5 6/7] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff

[PATCH v5 7/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from

[RFC PATCH] tests/qtest: attempt to enable tests for virtio-gpio (!working)

2022-01-21 Thread Alex Bennée
We don't have a virtio-gpio implementation in QEMU and only support a vhost-user backend. The QEMU side of the code is minimal so it should be enough to instantiate the device and pass some vhost-user messages over the control socket. To do this we hook into the existing vhost-user-test code and

Re: [PATCH v3 14/16] job.c: use job_get_aio_context()

2022-01-21 Thread Emanuele Giuseppe Esposito
On 19/01/2022 11:31, Paolo Bonzini wrote: diff --git a/job.c b/job.c index f16a4ef542..8a5b710d9b 100644 --- a/job.c +++ b/job.c @@ -566,7 +566,7 @@ void job_enter_cond_locked(Job *job, bool(*fn)(Job *job))   job->busy = true;   real_job_unlock();   job_unlock(); -   

Re: [PATCH v3 03/16] job.h: define locked functions

2022-01-21 Thread Emanuele Giuseppe Esposito
On 19/01/2022 11:44, Paolo Bonzini wrote: On 1/5/22 15:01, Emanuele Giuseppe Esposito wrote: These functions assume that the job lock is held by the caller, to avoid TOC/TOU conditions. Therefore, their name must end with _locked. Introduce also additional helpers that define _locked

[PATCH v6 7/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from

[PATCH v6 4/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > > Refresh lcitool submodule and the generated files by running: > > > >$ make lcitool-refresh > > > > Reviewed-by: Daniel P. Berrangé > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Thomas Huth
On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Alex Bennée
Peter Maydell writes: > On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: >> No objection, but it's no replacement for looking into why these tests >> are so slow. >> >> The #1 reason for things being slow is not giving a damn :) > > See previous messages in the thread -- the test starts

Re: [PATCH] hw/armv7m: Fix broken VMStateDescription

2022-01-21 Thread Alex Bennée
Peter Maydell writes: > In commit d5093d961585f02 we added a VMStateDescription to > the TYPE_ARMV7M object, to handle migration of its Clocks. > However a cut-and-paste error meant we used the wrong struct > name in the VMSTATE_CLOCK() macro arguments. The result was > that attempting a

[PATCH v5 4/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies

[PATCH v5 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[PATCH v5 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
Series fully reviewed. Refresh lcitool to latest and remove libxml2 (mjt). v5: - update scripts/meson-buildoptions.sh (thuth) - squash libvirt-ci updates (thuth) v4: - Fixed typos and cleaned checkpatch.pl (thuth) - Corrected libvirt-ci submodule URL v3: - fix 'refresh' helper to update

  1   2   3   >