Re: [PULL 18/20] block/nbd: drop connection_co

2022-02-03 Thread Fabian Ebner
Am 02.02.22 um 15:21 schrieb Hanna Reitz: > On 02.02.22 14:53, Eric Blake wrote: >> On Wed, Feb 02, 2022 at 12:49:36PM +0100, Fabian Ebner wrote: >>> Am 27.09.21 um 23:55 schrieb Eric Blake: From: Vladimir Sementsov-Ogievskiy OK, that's a big rewrite of the logic.

Re: [RFC] thread-pool: Add option to fix the pool size

2022-02-03 Thread Daniel P . Berrangé
On Thu, Feb 03, 2022 at 10:53:07AM +, Stefan Hajnoczi wrote: > On Wed, Feb 02, 2022 at 06:52:34PM +0100, Nicolas Saenz Julienne wrote: > > The thread pool regulates itself: when idle, it kills threads until > > empty, when in demand, it creates new threads until full. This behaviour > >

[PATCH] MAINTAINERS: take over seccomp from Eduardo Otubo

2022-02-03 Thread Daniel P . Berrangé
Eduardo has indicated that he no longer has time to be involved in a QEMU aintainership role. As one of the more frequent contributors of patches and design ideas to seccomp, I'll take over. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] MAINTAINERS: take over seccomp from Eduardo Otubo

2022-02-03 Thread Eduardo Otubo
On Thu, Feb 3, 2022 at 11:51 AM Daniel P. Berrangé wrote: > > Eduardo has indicated that he no longer has time to be involved in > a QEMU aintainership role. As one of the more frequent contributors > of patches and design ideas to seccomp, I'll take over. > > Signed-off-by: Daniel P. Berrangé >

Re: [PATCH 1/2] hw/char/renesas_sci: Add fifo buffer to backend interface.

2022-02-03 Thread Yoshinori Sato
On Wed, 02 Feb 2022 03:54:45 +0900, Peter Maydell wrote: > > On Tue, 1 Feb 2022 at 17:47, Yoshinori Sato > wrote: > > > > On Tue, 01 Feb 2022 15:48:58 +0900, > > Thomas Huth wrote: > > > > > > On 31/01/2022 10.42, Yoshinori Sato wrote: > > > If you describe it like this, it sounds like you're

Re: [PATCH 01/12] introduce BDRV_POLL_WHILE_UNLOCKED

2022-02-03 Thread Emanuele Giuseppe Esposito
On 26/01/2022 11:49, Stefan Hajnoczi wrote: > On Tue, Jan 18, 2022 at 11:27:27AM -0500, Emanuele Giuseppe Esposito wrote: >> Same as BDRV_POLL_WHILE, but uses AIO_WAIT_WHILE_UNLOCKED. >> >> Signed-off-by: Emanuele Giuseppe Esposito >> --- >> include/block/block-global-state.h | 5 + >> 1

[PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of the Xilinx ZynqMP CRF. At the moment this is mostly a stub model. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- include/hw/misc/xlnx-zynqmp-crf.h | 213 hw/misc/xlnx-zynqmp-crf.c | 267

[PATCH v2 6/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP APU Control

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the ZynqMP APU Control device. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 4 +++- hw/arm/xlnx-zynqmp.c | 25 +++-- 2 files changed, 26

[PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2)

2022-02-03 Thread Laurent Vivier
This series adds more qtest test cases to test virtio-net failover feature. New tests are focused on the behavior when the feature is not available. Laurent Vivier (7): tests/qtest: failover: clean up pathname of tests tests/qtest: failover: use a macro for check_one_card() tests/qtest:

Re: [PATCH] target/ppc: Fix radix logging

2022-02-03 Thread Cédric Le Goater
On 2/3/22 15:39, Greg Kurz wrote: On Thu, 3 Feb 2022 15:21:45 +0100 Cédric Le Goater wrote: ppc_radix64_partition_scoped_xlate() logs the host page protection bits variable but it is uninitialized since it is set later in ppc_radix64_check_prot(). Remove the Remove the what ? Arg ...

Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status

2022-02-03 Thread Peter Lieven
Am 01.02.22 um 15:39 schrieb Kevin Wolf: > Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben: >> V1->V2: >> Patch 1: Treat a hole just like an unallocated area. [Ilya] >> Patch 2: Apply workaround only for pre-Quincy librbd versions and >> ensure default striping and non child

[PATCH 6/7] tests/qtest: failover: test migration if the guest doesn't support failover

2022-02-03 Thread Laurent Vivier
The primary device is not plugged and the migration is done only with the standby device Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 142 ++ 1 file changed, 142 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c

[PATCH v1] hw/arm/xlnx-zynqmp: 'Or' the QSPI / QSPI DMA IRQs

2022-02-03 Thread Francisco Iglesias
'Or' the IRQs coming from the QSPI and QSPI DMA models. This is done for avoiding the situation where one of the models incorrectly deasserts an interrupt asserted from the other model (which will result in that the IRQ is lost and will not reach guest SW). Signed-off-by: Francisco Iglesias ---

Re: [PULL 0/6] hppa target updates and fixes

2022-02-03 Thread Peter Maydell
On Wed, 2 Feb 2022 at 18:11, Helge Deller wrote: > > The following changes since commit 91f5f7a5df1fda8c34677a7c49ee8a4bb5b56a36: > > Merge remote-tracking branch > 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging > (2022-01-12 11:51:47 +) > > are available in

Re: [PATCH RFC 13/15] migration: Add postcopy-preempt capability

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Firstly, postcopy already preempts precopy due to the fact that we do > unqueue_page() first before looking into dirty bits. > > However that's not enough, e.g., when there're host huge page enabled, when > sending a precopy huge page, a postcopy request

Re: [PATCH 17/20] tcg/i386: Implement avx512 min/max/abs

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 20/20] tcg/i386: Implement bitsel for avx512

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > The general ternary logic operation can implement BITSEL. > Funnel the 4-operand operation into three variants of the > 3-operand instruction, depending on input operand overlap. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 19/20] tcg/i386: Implement more logical operations for avx512

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > The general ternary logic operation can implement > NOT, ORC, NAND, NOR, EQV. Can we not fall back to expanding to use SSE if we don't have AVX512 available or is that done by the exiting fallback expansion? Anyway: Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 0/8] virtio: Add vhost-user based Video decode

2022-02-03 Thread Peter Griffin
Hi Alex, On Tue, 11 Jan 2022, Alex Bennée wrote: > > Peter Griffin writes: > > > This series adds support for virtio-video decoder devices in Qemu > > and also provides a vhost-user-video vmm implementation. > > This brings up a bunch of failures in CI: > >

[PATCH v2 0/6] hw/arm: zynqmp: Add CRF and APU control to support PSCI

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the necessary modeling to support some of our firmware tests at EL3 implementing PSCI (TBM). These are the test-cases that were previously relying on QEMU's builtin PSCI emulation. I've only tested this on top of Peter's recent PSCI emulation fixes. Cheers,

[PATCH v2 2/6] target/arm: Make rvbar settable after realize

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make the rvbar property settable after realize. This is done in preparation to model the ZynqMP's runtime configurable rvbar. Signed-off-by: Edgar E. Iglesias --- target/arm/cpu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 4/7] tests/qtest: failover: check missing guest feature

2022-02-03 Thread Laurent Vivier
If QEMU provides the VIRTIO_NET_F_STANDBY feature but the guest doesn't the primary device must be kept hidden Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 33 +++ 1 file changed, 33 insertions(+) diff --git

Re: [PATCH RFC 07/15] migration: Introduce postcopy channels on dest node

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Postcopy handles huge pages in a special way that currently we can only have > one "channel" to transfer the page. > > It's because when we install pages using UFFDIO_COPY, we need to have the > whole > huge page ready, it also means we need to have a temp

Re: Notes on Generating Python signatures for QMP RPCs

2022-02-03 Thread Markus Armbruster
John Snow writes: > On Thu, Jan 27, 2022 at 9:03 AM Markus Armbruster wrote: >> >> John Snow writes: >> >> > Hiya, I was experimenting with $subject and ran into a few points of >> > interest. This is basically an informal status report from me. I've >> > CC'd some of the usual suspects for

Re: [PATCH 14/20] tcg/i386: Expand vector word rotate as avx512vbmi2 shift-double

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > While there are no specific 16-bit rotate instructions, there > are double-word shifts, which can perform the same operation. > > Signed-off-by: Richard Henderson Even hackbox can't utilise these - maybe it's time to request a upgrade for my dev box ;-)

[PATCH v2 5/6] hw/misc: Add a model of the Xilinx ZynqMP APU Control

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of the Xilinx ZynqMP APU Control. Signed-off-by: Edgar E. Iglesias --- include/hw/misc/xlnx-zynqmp-apu-ctrl.h | 95 + hw/misc/xlnx-zynqmp-apu-ctrl.c | 254 + hw/misc/meson.build| 1 + 3 files

[PATCH 2/2] iotests: Test blockdev-reopen with iothreads and throttling

2022-02-03 Thread Kevin Wolf
The 'throttle' block driver implements .bdrv_co_drain_end, so blockdev-reopen will have to wait for it to complete in the polling loop at the end of qmp_blockdev_reopen(). This makes AIO_WAIT_WHILE() release the AioContext lock, which causes a crash if the lock hasn't correctly been taken.

[PATCH 2/7] tests/qtest: failover: use a macro for check_one_card()

2022-02-03 Thread Laurent Vivier
This allows g_assert() to correctly report the line number of the error in the test case. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 47 ++- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/tests/qtest/virtio-net-failover.c

Re: [PATCH v2] hw/rx: rx-gdbsim DTB load address aligned of 16byte.

2022-02-03 Thread Yoshinori Sato
On Wed, 02 Feb 2022 21:46:22 +0900, Philippe Mathieu-Daudé via wrote: > > On 2/2/22 11:30, Yoshinori Sato wrote: > > Linux kernel required alined address of DTB. > > But missing align in dtb load function. > > Fixed to load to the correct address. > > > > v2 changes. > > Use ROUND_DOWN macro. >

[PATCH] target/riscv: fix inverted checks for ext_zb[abcs]

2022-02-03 Thread Philipp Tomsich
While changing to the use of cfg_ptr, the conditions for REQUIRE_ZB[ABCS] inadvertently became inverted and slipped through the initial testing (which used RV64GC_XVentanaCondOps as a target). This fixes the regression. Tested against SPEC2017 w/ GCC 12 (prerelease) for RV64GC_zba_zbb_zbc_zbs.

Re: [PATCH RFC 15/15] tests: Add postcopy preempt test

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > tests/qtest/migration-test.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index

Re: [PATCH 15/20] tcg/i386: Remove rotls_vec from tcg_target_op_def

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > There is no such instruction on x86, so we should > not be pretending it has arguments. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 06/13] hw/intc/arm_gicv3_its: Fix address calculation in get_ite() and update_ite()

2022-02-03 Thread Peter Maydell
On Thu, 3 Feb 2022 at 03:59, Richard Henderson wrote: > > On 2/2/22 06:32, Peter Maydell wrote: > > In get_ite() and update_ite() we work with a 12-byte in-guest-memory > > table entry, which we intend to handle as an 8-byte value followed by > > a 4-byte value. Unfortunately the calculation of

Re: [PATCH 4/8] vhost-user-video: add meson subdir build logic

2022-02-03 Thread Peter Griffin
Hi Alex, Thanks for reviewing. On Tue, 11 Jan 2022, Alex Bennée wrote: > > Peter Griffin writes: > > > Signed-off-by: Peter Griffin > > --- > > tools/meson.build | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/tools/meson.build b/tools/meson.build > > index

Re: [PATCH 0/4] target/arm: SVE fixes versus VHE

2022-02-03 Thread Peter Maydell
On Thu, 27 Jan 2022 at 06:34, Richard Henderson wrote: > > Fix two problems described in > > https://lore.kernel.org/qemu-devel/6cdfd5de-2465-adca-73b3-9c66945cf...@huawei.com/ > > with some other minor code cleanup. > Applied to target-arm.next, thanks. -- PMM

Re: [PATCH 10/12] block.c: add subtree_drains where needed

2022-02-03 Thread Emanuele Giuseppe Esposito
On 19/01/2022 10:47, Paolo Bonzini wrote: > > About this: > >> + * TODO: this is called by job_unref with lock held, because >> + * afterwards it calls bdrv_try_set_aio_context. >> + * Once all of this is fixed, take care of removing >> + * the aiocontext lock

[PATCH v2 4/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP CRF

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the ZynqMP CRF - Clock Reset FPD device. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 ++ hw/arm/xlnx-zynqmp.c | 16 2 files changed, 18

[PATCH] target/ppc: Fix radix logging

2022-02-03 Thread Cédric Le Goater
ppc_radix64_partition_scoped_xlate() logs the host page protection bits variable but it is uninitialized since it is set later in ppc_radix64_check_prot(). Remove the Fixes: Coverity CID 1468942 Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 8 ++-- 1 file changed, 2

Re: [PATCH 09/12] jobs: ensure sleep in job_sleep_ns is fully performed

2022-02-03 Thread Emanuele Giuseppe Esposito
On 26/01/2022 12:21, Stefan Hajnoczi wrote: > On Tue, Jan 18, 2022 at 11:27:35AM -0500, Emanuele Giuseppe Esposito wrote: >> If a drain happens while a job is sleeping, the timeout >> gets cancelled and the job continues once the drain ends. >> This is especially bad for the sleep performed in

Re: [PATCH v6 0/7] target/riscv: Add XVentanaCondOps and supporting infrastructure changes

2022-02-03 Thread Philipp Tomsich
Alistair, there's a fix for a regression (inverted condition) caused by the changes to the REQUIRE_ZB[ABCS] heading your way. Thanks, Philipp. On Wed, 2 Feb 2022 at 07:36, Alistair Francis wrote: > On Wed, Feb 2, 2022 at 2:03 PM Philipp Tomsich > wrote: > > > > > > In adding our first

Re: [PATCH 18/20] tcg/i386: Implement avx512 multiply

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status

2022-02-03 Thread Stefano Garzarella
On Thu, Feb 03, 2022 at 12:42:30PM +0100, Peter Lieven wrote: Am 01.02.22 um 15:39 schrieb Kevin Wolf: Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben: V1->V2: Patch 1: Treat a hole just like an unallocated area. [Ilya] Patch 2: Apply workaround only for pre-Quincy librbd versions and

[PATCH 3/7] tests/qtest: failover: check the feature is correctly provided

2022-02-03 Thread Laurent Vivier
Check QEMU provides the VIRTIO_NET_F_STANDBY if failover is on, and doesn't if failover is off Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 139 ++ 1 file changed, 86 insertions(+), 53 deletions(-) diff --git

[PATCH 0/2] block: Fix crash in blockdev-reopen with iothreads

2022-02-03 Thread Kevin Wolf
Kevin Wolf (2): block: Lock AioContext for drain_end in blockdev-reopen iotests: Test blockdev-reopen with iothreads and throttling blockdev.c | 11 ++- tests/qemu-iotests/245 | 36 +--- tests/qemu-iotests/245.out | 4 ++-- 3 files

[PATCH 5/7] tests/qtest: failover: check migration with failover off

2022-02-03 Thread Laurent Vivier
If failover is off, the primary device is not plugged and the migration is done only with the standby device. On destination, the primary device must not be plugged. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 133 ++ 1 file changed, 133

[PATCH 1/2] block: Lock AioContext for drain_end in blockdev-reopen

2022-02-03 Thread Kevin Wolf
bdrv_subtree_drained_end() requires the caller to hold the AioContext lock for the drained node. Not doing this for nodes outside of the main AioContext leads to crashes when AIO_WAIT_WHILE() needs to wait and tries to temporarily release the lock. Fixes: 3908b7a8994fa5ef7a89aa58cd5a02fc58141592

Re: [PATCH] target/ppc: Fix radix logging

2022-02-03 Thread Greg Kurz
On Thu, 3 Feb 2022 15:21:45 +0100 Cédric Le Goater wrote: > ppc_radix64_partition_scoped_xlate() logs the host page protection > bits variable but it is uninitialized since it is set later in > ppc_radix64_check_prot(). Remove the > Remove the what ? > Fixes: Coverity CID 1468942 >

Re: [PATCH 00/20] tcg: vector improvements

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > Add some opcodes for compound logic operations that were so > far marked as TODO. Implement those for PPC and S390X. > > We do not want to implement 512-bit width operations, because > those trigger a cluster clock slowdown on the current set of > Intel cpus. But

Re: [PATCH 16/20] tcg/i386: Expand scalar rotate with avx512 insns

2022-02-03 Thread Alex Bennée
Richard Henderson writes: > Expand 32-bit and 64-bit scalar rotate with VPRO[LR]V; > expand 16-bit scalar rotate with VPSHLDV. > > Signed-off-by: Richard Henderson Again couldn't test but looks sane: Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 0/8] virtio: Add vhost-user based Video decode

2022-02-03 Thread Peter Griffin
Hi Michael, Apologies for the delaying in replying to you, I didn't see your email until now whilst replying to Alex review feedback. On Tue, 11 Jan 2022, Michael S. Tsirkin wrote: > On Thu, Dec 09, 2021 at 02:55:53PM +, Peter Griffin wrote: > > This series adds support for virtio-video

Re: [PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-03 Thread Christian Schoenebeck
On Donnerstag, 3. Februar 2022 07:20:05 CET Vitaly Chikunov wrote: > On Thu, Feb 03, 2022 at 07:55:41AM +0300, Vitaly Chikunov wrote: > > Christian, > > > > On Wed, Feb 02, 2022 at 05:55:45PM +0100, Christian Schoenebeck wrote: > > > On Freitag, 28. Januar 2022 23:33:26 CET Vitaly Chikunov wrote:

Re: [PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-03 Thread Christian Schoenebeck
On Freitag, 28. Januar 2022 23:33:26 CET Vitaly Chikunov wrote: > `struct dirent' returned from readdir(3) could be shorter than > `sizeof(struct dirent)', thus memcpy of sizeof length will overread > into unallocated page causing SIGSEGV. Example stack trace: > > #0 0x559ebeed

Re: [PATCH 0/8] virtio: Add vhost-user based Video decode

2022-02-03 Thread Michael S. Tsirkin
On Thu, Feb 03, 2022 at 12:10:17PM +, Peter Griffin wrote: > Hi Michael, > > Apologies for the delaying in replying to you, I didn't see your email until > now > whilst replying to Alex review feedback. > > On Tue, 11 Jan 2022, Michael S. Tsirkin wrote: > > > On Thu, Dec 09, 2021 at

[PATCH 1/7] tests/qtest: failover: clean up pathname of tests

2022-02-03 Thread Laurent Vivier
clearly indentify parameters, hotplug and migration tests Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c index

Re: [PATCH RFC 11/15] migration: Add pss.postcopy_requested status

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This boolean flag shows whether the current page during migration is triggered > by postcopy or not. Then in ram_save_host_page() and deeper stack we'll be > able to have a reference on the priority of this page. > > Signed-off-by: Peter Xu Reviewed-by:

Re: [PATCH 1/8] vhost-user-video: Add a README.md with cheat sheet of commands

2022-02-03 Thread Peter Griffin
Hi Alex, Thanks for your review :) On Tue, 11 Jan 2022, Alex Bennée wrote: > > Peter Griffin writes: > > > Signed-off-by: Peter Griffin > > --- > > tools/vhost-user-video/README.md | 98 > > 1 file changed, 98 insertions(+) > > create mode 100644

Re: Notes on Generating Python signatures for QMP RPCs

2022-02-03 Thread Daniel P . Berrangé
On Wed, Jan 26, 2022 at 01:58:19PM -0500, John Snow wrote: > (1) QAPI types the return of many commands as an empty object. That's > literally indeed what happens on the wire, and it makes sense in that > if these commands were ever to return anything, it is a "compatible > evolution" to include

Re: [RFC] thread-pool: Add option to fix the pool size

2022-02-03 Thread Stefan Hajnoczi
On Wed, Feb 02, 2022 at 06:52:34PM +0100, Nicolas Saenz Julienne wrote: > The thread pool regulates itself: when idle, it kills threads until > empty, when in demand, it creates new threads until full. This behaviour > doesn't play well with latency sensitive workloads where the price of >

Re: [PATCH v2] Fix %#0 misuses

2022-02-03 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > On 2/2/22 19:34, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Joe Perches pointed out on lkml [1] that the format special %# (which > > adds 0x) is included in the character count, i.e.: > > > >printf("0:

Re: [PATCH 3/8] vhost-user-video: boiler plate code for vhost-user-video device

2022-02-03 Thread Peter Griffin
Hi Alex, Thanks for reviewing. On Tue, 11 Jan 2022, Alex Bennée wrote: > > Peter Griffin writes: > > > Signed-off-by: Peter Griffin > > --- > > hw/display/Kconfig | 5 + > > hw/display/meson.build | 3 + > > hw/display/vhost-user-video.c| 386

Re: [RFC 4/5] target/riscv: Add *envcfg* CSRs support

2022-02-03 Thread Heiko Stübner
Hi Atish, Am Donnerstag, 20. Januar 2022, 21:07:34 CET schrieb Atish Patra: > The RISC-V privileged specification v1.12 defines few execution > environment configuration CSRs that can be used enable/disable > extensions per privilege levels. > > Add the basic support for these CSRs. > >

[PATCH v2 1/6] hw/arm/xlnx-zynqmp: Add an unimplemented SERDES area

2022-02-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add an unimplemented SERDES (Serializer/Deserializer) area. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 +- hw/arm/xlnx-zynqmp.c | 5 + 2 files changed, 6

Re: [PATCH RFC 09/15] migration: Add postcopy_thread_create()

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Postcopy create threads. A common manner is we init a sem and use it to sync > with the thread. Namely, we have fault_thread_sem and listen_thread_sem and > they're only used for this. > > Make it a shared infrastructure so it's easier to create yet

Re: [PATCH 10/12] block.c: add subtree_drains where needed

2022-02-03 Thread Emanuele Giuseppe Esposito
On 02/02/2022 18:38, Paolo Bonzini wrote: > On 2/2/22 16:37, Emanuele Giuseppe Esposito wrote: >> So we have disk B with backing file C, and new disk A that wants to have >> backing file C. >> >> I think I understand what you mean, so in theory the operation would be >> - create new child >> -

Re: [PATCH 05/12] test-bdrv-drain.c: adapt test to the coming subtree drains

2022-02-03 Thread Emanuele Giuseppe Esposito
On 19/01/2022 10:18, Paolo Bonzini wrote: > On 1/18/22 17:27, Emanuele Giuseppe Esposito wrote: >> - First of all, inconsistency between block_job_create under >> aiocontext lock that internally calls blk_insert_bs and therefore >> bdrv_replace_child_noperm, and blk_insert_bs that is called two

Re: [RFC PATCH 11/15] exec/cpu: Make address_space_init/reloading_memory_map target agnostic

2022-02-03 Thread Philippe Mathieu-Daudé via
On 26/5/21 21:01, Richard Henderson wrote: On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote: cpu_address_space_init() and cpu_reloading_memory_map() don't have to be target specific. Remove this limitation to be able to build softmmu/cpus.c once for all targets. Signed-off-by: Philippe

[PATCH v2] hw/smbios: fix memory corruption for large guests due to handle overlap

2022-02-03 Thread Ani Sinha
The current implementation of smbios table handle assignment does not leave enough gap between tables 17 and table 19 for guests with larger than 8 TB of memory. This change fixes this issue. This change calculates if additional space between the tables need to be set aside and then reserves that

Re: [RFC] thread-pool: Add option to fix the pool size

2022-02-03 Thread Stefan Hajnoczi
On Thu, Feb 03, 2022 at 10:56:49AM +, Daniel P. Berrangé wrote: > On Thu, Feb 03, 2022 at 10:53:07AM +, Stefan Hajnoczi wrote: > > On Wed, Feb 02, 2022 at 06:52:34PM +0100, Nicolas Saenz Julienne wrote: > > > The thread pool regulates itself: when idle, it kills threads until > > > empty,

[PATCH 7/7] tests/qtest: failover: migration abort test with failover off

2022-02-03 Thread Laurent Vivier
Test abort during active migration when failover is disabled from QEMU or from guest side. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 180 ++ 1 file changed, 180 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c

[PATCH] target/ppc: Remove PowerPC 601 CPUs

2022-02-03 Thread Cédric Le Goater
The PowerPC 601 processor is the first generation of processors to implement the PowerPC architecture. It was designed as a bridge processor and also could execute most of the instructions of the previous POWER architecture. It was found on the first Macs and IBM RS/6000 workstations. There is

[PATCH] hvf: arm: Add simple dirty bitmap tracking

2022-02-03 Thread Alexander Graf
The actual tracking of dirty bitmap updates is happening in architecture code. So far, the aarch64 hvf code has not updated QEMU's dirty bitmap at all. The net result of that is that the VGA device's framebuffer would not update. This patch adds simplistic dirty bitmap updates. Unfortunately hvf

Re: [PATCH RFC 08/15] migration: Dump ramblock and offset too when non-same-page detected

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > In ram_load_postcopy() we'll try to detect non-same-page case and dump error. > This error is very helpful for debugging. Adding ramblock & offset into the > error log too. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [PATCH RFC 12/15] migration: Move migrate_allow_multifd and helpers into migration.c

2022-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This variable, along with its helpers, is used to detect whether multiple > channel will be supported for migration. In follow up patches, there'll be > other capability that requires multi-channels. Hence move it outside multifd > specific code and make

[PATCH 3/7] block/nbd: Assert there are no timers when closed

2022-02-03 Thread Hanna Reitz
Our two timers must not remain armed beyond nbd_clear_bdrvstate(), or they will access freed data when they fire. This patch is separate from the patches that actually fix the issue (HEAD^^ and HEAD^) so that you can run the associated regression iotest (281) on a configuration that reproducibly

[PATCH 7/7] iotests/281: Let NBD connection yield in iothread

2022-02-03 Thread Hanna Reitz
Put an NBD block device into an I/O thread, and then read data from it, hoping that the NBD connection will yield during that read. When it does, the coroutine must be reentered in the block device's I/O thread, which will only happen if the NBD block driver attaches the connection's QIOChannel

[RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-03 Thread Halil Pasic
Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. the driver must accept it if offered by the device. The virtio specification says that the driver SHOULD accept the ACCESS_PLATFORM feature if offered, and that the device MAY fail to operate if ACCESS_PLATFORM was offered

[PATCH 13/27] configure, meson: move coroutine options to meson_options.txt

2022-02-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- meson.build | 11 +-- meson_options.txt | 4 scripts/meson-buildoptions.sh | 7 +++ 4 files changed, 20 insertions(+), 33 deletions(-) diff --git

[PATCH 24/27] qga/vss-win32: require widl/midl, remove pre-built TLB file

2022-02-03 Thread Paolo Bonzini
From: Marc-André Lureau There are no good reason anymore to keep a pre-built file in the repository. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 4 qga/meson.build | 2 ++ qga/vss-win32/meson.build | 9 +

Re: [PATCH] armv7m_nvic: set DHCSR.DEBUGEN when debugger is attached

2022-02-03 Thread Alex Bennée
Valentin Ghita writes: > The DEBUGEN bit is set by the debugger when it is connected to the > core. Software can use this bit to check if a debug session is active. > > Add a function in gdbstub to check if the debugger is attached to a CPU > and use this information when the DHCSR register

Re: [PULL 0/6] hppa target updates and fixes

2022-02-03 Thread Helge Deller
On 2/3/22 16:42, Peter Maydell wrote: > On Wed, 2 Feb 2022 at 18:11, Helge Deller wrote: >> >> The following changes since commit 91f5f7a5df1fda8c34677a7c49ee8a4bb5b56a36: >> >> Merge remote-tracking branch >> 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging >>

[PATCH v2 09/21] softmmu/cpus: Code movement

2022-02-03 Thread Philippe Mathieu-Daudé via
We want cpu_thread_is_idle() to use cpus_accel, so declare this variable earlier. Signed-off-by: Philippe Mathieu-Daudé --- softmmu/cpus.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 7f15106dd9..538e1714af 100644 ---

[PATCH v2 08/21] accel/hax: Introduce CONFIG_HAX_IS_POSSIBLE

2022-02-03 Thread Philippe Mathieu-Daudé via
Mirror "sysemu/kvm.h" #ifdef'ry to define CONFIG_HAX_IS_POSSIBLE, expose hax_allowed to hax_enabled() macro. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- accel/stubs/hax-stub.c| 2 ++ include/sysemu/hax.h | 18 -- target/i386/hax/hax-all.c

Re: [PULL v2 00/14] Misc patches for 2022-01-27

2022-02-03 Thread Peter Maydell
On Fri, 28 Jan 2022 at 10:18, Paolo Bonzini wrote: > > The following changes since commit aeb0ae95b7f18c66158792641cb6ba0cde5789ab: > > Merge remote-tracking branch > 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2022-01-22 > 12:03:22 +) > > are available in the Git

[PATCH 5/7] iotests/281: Test lingering timers

2022-02-03 Thread Hanna Reitz
Prior to "block/nbd: Delete reconnect delay timer when done" and "block/nbd: Delete open timer when done", both of those timers would remain scheduled even after successfully (re-)connecting to the server, and they would not even be deleted when the BDS is deleted. This test constructs exactly

[PATCH] audio/dbus: Fix building with modules enabled on macOS

2022-02-03 Thread Philippe Mathieu-Daudé via
When configuring QEMU with --enable-modules we get on macOS: --- stderr --- Dependency ui-dbus cannot be satisfied ui-dbus depends on pixman and opengl, so add these dependencies to audio-dbus. Fixes: 739362d420 ("audio: add "dbus" audio backend") Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH 14/27] configure, meson: move smbd options to meson_options.txt

2022-02-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 26 ++ meson.build | 15 +-- meson_options.txt | 4 net/slirp.c | 16 scripts/meson-buildoptions.py | 1 +

[PATCH 05/27] configure, meson: move AF_ALG test to meson

2022-02-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 36 --- crypto/meson.build| 4 +++- meson.build | 16 +++- meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 5 files changed,

[PATCH 09/27] configure, meson: move image format options to meson_options.txt

2022-02-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/meson.build | 47 +++--- configure | 73 --- meson.build | 16 meson_options.txt | 16 scripts/meson-buildoptions.sh | 24

[PATCH 27/27] configure, meson: move CONFIG_IASL to a Meson option

2022-02-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 4 +--- meson.build | 12 meson_options.txt | 2 ++ scripts/meson-buildoptions.py | 1 + 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/configure b/configure index

Re: [PATCH 22/27] configure, meson: replace VSS SDK checks and options with --enable-vss-sdk

2022-02-03 Thread Marc-André Lureau
Hi On Thu, Feb 3, 2022 at 10:02 PM Paolo Bonzini wrote: > From: Marc-André Lureau > > The VSS headers are part of standard MS VS SDK, at least since version > 15, and probably before that. > > They are also included with MinGW, although currently broken. > > Let's streamline a bit the options,

[PATCH 19/27] meson: drop --with-win-sdk

2022-02-03 Thread Paolo Bonzini
From: Marc-André Lureau It's no longer used. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 29 - meson.build | 5 - 2 files changed, 34 deletions(-) diff --git a/configure b/configure index e25de48b3e..3fb28891d3 100755 ---

[PATCH 16/27] meson: refine check for whether to look for virglrenderer

2022-02-03 Thread Paolo Bonzini
The check should be performed even if !have_system, as long as there is some hope that vhost-user-gpu will be built. Store into have_vhost_user_gpu whether vhost-user-gpu will be built; we will also use the variable to decide whether to look for libepoxy. Signed-off-by: Paolo Bonzini ---

Re: [PATCH v3 1/3] qmp: Support for querying stats

2022-02-03 Thread Mark Kanda
On 2/3/2022 12:30 PM, Daniel P. Berrangé wrote: On Thu, Feb 03, 2022 at 12:12:57PM -0600, Mark Kanda wrote: Thanks Daniel, On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote: +# +# Since: 7.0 +## +{ 'enum' : 'StatType', + 'data' : [ 'cumulative', 'instant', 'peak', + 'linear-hist',

Re: [PATCH v3 1/3] qmp: Support for querying stats

2022-02-03 Thread Daniel P . Berrangé
On Thu, Feb 03, 2022 at 12:12:57PM -0600, Mark Kanda wrote: > Thanks Daniel, > > On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote: > > > +# > > > +# Since: 7.0 > > > +## > > > +{ 'enum' : 'StatType', > > > + 'data' : [ 'cumulative', 'instant', 'peak', > > > + 'linear-hist', 'log-hist',

Re: [PATCH v5 3/9] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-03 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Add some code to parse extended "struct fuse_init_in". And use a local > variable "flag" to represent 64 bit flags. This will make it easier > to add more features without having to worry about two 32bit flags (->flags > and ->flags2) in "fuse_struct_in".

Re: [PATCH v3 1/3] qmp: Support for querying stats

2022-02-03 Thread Paolo Bonzini
On 2/3/22 19:12, Mark Kanda wrote: I added the 'unknown' member here (and in other enums) to handle situations where QEMU is behind KVM in terms of enumerating the various stat types, units, etc. I feel this will be a semi-common scenario (old QEMU on a new kernel) and with 'unknown', QEMU

Re: [PATCH v1] hw/arm/xlnx-zynqmp: 'Or' the QSPI / QSPI DMA IRQs

2022-02-03 Thread Philippe Mathieu-Daudé via
On 3/2/22 16:17, Francisco Iglesias wrote: 'Or' the IRQs coming from the QSPI and QSPI DMA models. This is done for avoiding the situation where one of the models incorrectly deasserts an interrupt asserted from the other model (which will result in that the IRQ is lost and will not reach guest

[PATCH 05/10] qtest: Add missing 'hw/qdev-core.h' include

2022-02-03 Thread Philippe Mathieu-Daudé via
Add "hw/qdev-core.h" to avoid when refactoring include/: softmmu/qtest.c:404:9: error: use of undeclared identifier 'NamedGPIOList' NamedGPIOList *ngl; ^ Signed-off-by: Philippe Mathieu-Daudé --- softmmu/qtest.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [RFC PATCH 0/4] improve coverage of vector backend

2022-02-03 Thread Alex Bennée
Taylor Simpson writes: >> -Original Message- >> From: Alex Bennée >> Sent: Thursday, February 3, 2022 12:26 PM >> To: Taylor Simpson >> Cc: richard.hender...@linaro.org; qemu-devel@nongnu.org; qemu- >> a...@nongnu.org; f...@euphon.net; berra...@redhat.com; >> f4...@amsat.org;

[PATCH v2 13/21] softmmu/runstate: Clean headers

2022-02-03 Thread Philippe Mathieu-Daudé via
Add the missing 'qemu/log.h' header and remove the unused 'exec/exec-all.h' one. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- softmmu/runstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/runstate.c b/softmmu/runstate.c index

  1   2   3   >