Re: [PATCH v5 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-17 Thread David Miller
Will submit patch later today, thanks

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki wrote: >> >> On Thu, Feb 17, 2022 at 8:58 PM wrote: >> > >> > From: Marc-André Lureau >> > >> > Hi, >> > >> > In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console",

[PULL v2 5/5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Christian Schoenebeck
From: Vitaly Chikunov `struct dirent' returned from readdir(3) could be shorter (or longer) than `sizeof(struct dirent)', thus memcpy of sizeof length will overread into unallocated page causing SIGSEGV. Example stack trace: #0 0x559ebeed v9fs_co_readdir_many

[PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-17 Thread Haiyue Wang
The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b13619cff40141bb1fc3615b This leads to build failure: ../util/fdmon-io_uring.c: In function ‘add_poll_remove_sqe’: ../util/fdmon-io_uring.c:182:36: error: passing

Re: [PATCH v5 11/20] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU

2022-02-17 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 09:35:04AM -0500, Emanuele Giuseppe Esposito wrote: > Once job lock is used and aiocontext is removed, mirror has > to perform job operations under the same critical section, > using the helpers prepared in previous commit. > > Note: at this stage, job_{lock/unlock} and

[PATCH] migration: NULL transport_data after freeing

2022-02-17 Thread Hanna Reitz
migration_incoming_state_destroy() NULLs all objects it frees after they are freed, presumably so that a subsequent call to the same function will not free them again, unless new objects have been created in the meantime. transport_data is the exception, and it shows exactly this problem: When an

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki wrote: > On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki > wrote: > >> > >> On Thu, Feb 17, 2022 at 8:58 PM wrote: > >> > > >> > From: Marc-André Lureau > >> > > >> >

[PULL v2 2/5] tests/9pfs: fix mkdir() being called twice

2022-02-17 Thread Christian Schoenebeck
The 9p test cases use mkdtemp() to create a temporary directory for running the 'local' 9p tests with real files/dirs. Unlike mktemp() which only generates a unique file name, mkdtemp() also creates the directory, therefore the subsequent mkdir() was wrong and caused errors on some systems.

[PULL v2 4/5] tests/9pfs: Use g_autofree and g_autoptr where possible

2022-02-17 Thread Christian Schoenebeck
From: Greg Kurz It is recommended to use g_autofree or g_autoptr as it reduces the odds of introducing memory leaks in future changes. Signed-off-by: Greg Kurz Message-Id: <20220201151508.190035-3-gr...@kaod.org> Reviewed-by: Christian Schoenebeck Signed-off-by: Christian Schoenebeck ---

Re: [PATCH] tcg: Remove dh_alias indirection for dh_typecode

2022-02-17 Thread Keith Packard via
Richard Henderson writes: > Reported-by: Keith Packard > Signed-off-by: Richard Henderson Looks good to me, and it passes my very simple test when run on s390. Tested-by: Keith Packard -- -keith signature.asc Description: PGP signature

Re: [PATCH v2 9/9] spapr: implement nested-hv capability for the virtual hypervisor

2022-02-17 Thread Cédric Le Goater
On 2/16/22 13:30, Nicholas Piggin wrote: Excerpts from Nicholas Piggin's message of February 16, 2022 9:38 pm: Excerpts from Cédric Le Goater's message of February 16, 2022 8:52 pm: On 2/16/22 11:25, Nicholas Piggin wrote: This implements the Nested KVM HV hcall API for spapr under TCG. The

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-17 Thread Eugenio Perez Martin
On Tue, Feb 8, 2022 at 4:58 AM Jason Wang wrote: > > > 在 2022/2/1 上午2:58, Eugenio Perez Martin 写道: > > On Sun, Jan 30, 2022 at 5:03 AM Jason Wang wrote: > >> > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > >>> First half of the buffers forwarding part, preparing vhost-vdpa > >>> callbacks to SVQ to

[PULL v2 3/5] tests/9pfs: Fix leak of local_test_path

2022-02-17 Thread Christian Schoenebeck
From: Greg Kurz local_test_path is allocated in virtio_9p_create_local_test_dir() to hold the path of the temporary directory. It should be freed in virtio_9p_remove_local_test_dir() when the temporary directory is removed. Clarify the lifecycle of local_test_path while here. Based-on:

[PULL v2 1/5] tests/9pfs: use g_autofree where possible

2022-02-17 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: --- tests/qtest/virtio-9p-test.c | 90 +++- 1 file changed, 27 insertions(+), 63 deletions(-) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c index

[PULL v2 0/5] 9p queue (previous 2022-02-10)

2022-02-17 Thread Christian Schoenebeck
/pull-9p-20220217 for you to fetch changes up to e64e27d5cb103b7764f1a05b6eda7e7fedd517c5: 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread (2022-02-17 16:57:58 +0100) 9pfs: fixes and cleanup * Fifth patch

[PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 09:57:11 +) are available in the Git repository at:

[PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Kernel version 5.17 has increased the size of "struct fuse_init_in" struct. Previously this struct was 16 bytes and now it has been extended to 64 bytes in size. Once qemu headers are updated to latest, it will expect to receive 64 byte size struct (for protocol version major

[PULL 07/12] virtiofsd: Move core file creation code in separate function

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal

Re: Portable inline asm to get address of TLS variable

2022-02-17 Thread Serge Guelton
On Thu, Feb 17, 2022 at 12:40:40PM +0100, Paolo Bonzini wrote: > On 2/17/22 10:28, Stefan Hajnoczi wrote: > >>But going against ABI and toolchain in this way is really no long-term > >>solution. You need to switch to stackless co-routines, or we need to > >>provide proper ABI-level support for

[PATCH v2 2/3] i386: Hyper-V Enlightened MSR bitmap feature

2022-02-17 Thread Vitaly Kuznetsov
The newly introduced enlightenment allow L0 (KVM) and L1 (Hyper-V) hypervisors to collaborate to avoid unnecessary updates to L2 MSR-Bitmap upon vmexits. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt| 10 ++ target/i386/cpu.c | 2 ++ target/i386/cpu.h

[PATCH v4 2/3] hw/smbios: fix overlapping table handle numbers with large memory vms

2022-02-17 Thread Ani Sinha
The current smbios table implementation splits the main memory in 16 GiB (DIMM like) chunks. With the current smbios table assignment code, we can have only 512 such chunks before the 16 bit handle numbers in the header for tables 17 and 19 conflict. A guest with more than 8 TiB of memory will hit

[PATCH v2 3/3] i386: Hyper-V XMM fast hypercall input feature

2022-02-17 Thread Vitaly Kuznetsov
Hyper-V specification allows to pass parameters for certain hypercalls using XMM registers ("XMM Fast Hypercall Input"). When the feature is in use, it allows for faster hypercalls processing as KVM can avoid reading guest's memory. KVM supports the feature since v5.14. Rename

[PATCH v4 3/3] hw/smbios: add assertion to ensure handles of tables 19 and 32 do not collide

2022-02-17 Thread Ani Sinha
Since change dcf359832eec02 ("hw/smbios: fix table memory corruption with large memory vms") we reserve additional space between handle numbers of tables 17 and 19 for large VMs. This may cause table 19 to collide with table 32 in their handle numbers for those large VMs. This change adds an

Re: [PATCH v5 08/20] jobs: protect jobs with job_lock/unlock

2022-02-17 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 09:35:01AM -0500, Emanuele Giuseppe Esposito wrote: > diff --git a/block/replication.c b/block/replication.c > index 55c8f894aa..a03b28726e 100644 > --- a/block/replication.c > +++ b/block/replication.c > @@ -149,7 +149,9 @@ static void replication_close(BlockDriverState

Re: [PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

2022-02-17 Thread Pierre Morel
On 2/17/22 15:20, Daniel P. Berrangé wrote: On Thu, Feb 17, 2022 at 02:41:22PM +0100, Pierre Morel wrote: S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets, and the level 3, containing sockets are the books. We introduce here

Re: [PATCH v17] qapi: introduce 'x-query-x86-cpuid' QMP command.

2022-02-17 Thread Vladimir Sementsov-Ogievskiy
Ping :) Any hope that we will merge it one day?) 21.01.2022 19:39, Vladimir Sementsov-Ogievskiy wrote: From: Valeriy Vdovin Introducing new QMP command 'query-x86-cpuid'. This command can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid

Re: [PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

2022-02-17 Thread Pierre Morel
On 2/17/22 16:32, Daniel P. Berrangé wrote: On Thu, Feb 17, 2022 at 04:30:06PM +0100, Pierre Morel wrote: On 2/17/22 15:20, Daniel P. Berrangé wrote: On Thu, Feb 17, 2022 at 02:41:22PM +0100, Pierre Morel wrote: S390 CPU topology may have up to 5 topology containers. The first container

Re: Portable inline asm to get address of TLS variable

2022-02-17 Thread Paolo Bonzini
On 2/17/22 16:02, Serge Guelton wrote: I took a quick look at C++20 coroutines since they are available in compilers but the primitives look hard to use even from C++, let alone >from C. They're C++ only in GCC, too. I really think that QEMU should be compilable in C++, but I'm not sure how

Re: qemu crash 100% CPU with Ubuntu10.04 guest (solved)

2022-02-17 Thread Kashyap Chamarthy
On Thu, Feb 17, 2022 at 12:07:15PM +1100, Ben Smith wrote: > Hi All, Hi, > I'm cross-posting this from Reddit qemu_kvm, in case it helps in some > way. I know my setup is ancient and unique; let me know if you would > like more info. > > Symptoms: > 1. Ubuntu10.04 32-bit guest locks up randomly

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 07:08, Alice Frosi wrote: > > On Fri, Jan 28, 2022 at 6:04 PM Stefan Hajnoczi wrote: > > > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 14:12, Stefano Garzarella wrote: > > On Mon, Feb 14, 2022 at 02:01:52PM +, Stefan Hajnoczi wrote: > >On Mon, 14 Feb 2022 at 07:11, Jason Wang wrote: > >> > >> On Fri, Jan 28, 2022 at 11:47 PM Stefan Hajnoczi > >> wrote: > >> > > >> > Dear QEMU, KVM, and rust-vmm

Re: [PATCH v5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Christian Schoenebeck
On Mittwoch, 16. Februar 2022 19:18:21 CET Vitaly Chikunov wrote: > `struct dirent' returned from readdir(3) could be shorter (or longer) > than `sizeof(struct dirent)', thus memcpy of sizeof length will overread > into unallocated page causing SIGSEGV. Example stack trace: > > #0

[PATCH v2 1/3] i386: Use hv_build_cpuid_leaf() for HV_CPUID_NESTED_FEATURES

2022-02-17 Thread Vitaly Kuznetsov
Previously, HV_CPUID_NESTED_FEATURES.EAX CPUID leaf was handled differently as it was only used to encode the supported eVMCS version range. In fact, there are also feature (e.g. Enlightened MSR-Bitmap) bits there. In preparation to adding these features, move HV_CPUID_NESTED_FEATURES leaf

[PATCH v2 0/3] i386: Add support for Hyper-V Enlightened MSR-Bitmap and XMM fast hypercall input features

2022-02-17 Thread Vitaly Kuznetsov
'XMM fast hypercall input feature' is supported by KVM since v5.14, it allows for faster Hyper-V hypercall processing. 'Enlightened MSR-Bitmap' is a new nested specific enlightenment speeds up L2 vmexits by avoiding unnecessary updates to L2 MSR-Bitmap. KVM support for the feature on Intel CPUs

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

2022-02-17 Thread Eric Blake
On Wed, Feb 16, 2022 at 02:44:52PM +0100, Markus Armbruster wrote: > > > > +## > > +# @NbdExportMultiConn: > > +# > > +# Possible settings for advertising NBD multiple client support. > > +# > > +# @off: Do not advertise multiple clients. > > +# > > +# @on: Allow multiple clients (for writable

Re: [PATCH v5 09/20] jobs: add job lock in find_* functions

2022-02-17 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 09:35:02AM -0500, Emanuele Giuseppe Esposito wrote: > diff --git a/blockdev.c b/blockdev.c > index c5fba4d157..08408cd44b 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -3311,7 +3311,10 @@ out: > aio_context_release(aio_context); > } > > -/* Get a block job using

Re: Portable inline asm to get address of TLS variable

2022-02-17 Thread Stefan Hajnoczi
On Thu, Feb 17, 2022 at 04:02:16PM +0100, Serge Guelton wrote: > On Thu, Feb 17, 2022 at 12:40:40PM +0100, Paolo Bonzini wrote: > > On 2/17/22 10:28, Stefan Hajnoczi wrote: > > >>But going against ABI and toolchain in this way is really no long-term > > >>solution. You need to switch to stackless

Re: [PATCH 1/1] numa: check mem or memdev in numa configuration

2022-02-17 Thread Li Zhang
On 2/17/22 2:33 PM, Igor Mammedov wrote: On Thu, 17 Feb 2022 13:24:08 +0100 Li Zhang wrote: On 2/17/22 11:25 AM, Igor Mammedov wrote: On Thu, 17 Feb 2022 10:38:32 +0100 Li Zhang wrote: On 2/17/22 10:10 AM, Igor Mammedov wrote: On Wed, 16 Feb 2022 17:36:13 +0100 Li Zhang wrote:

Re: Portable inline asm to get address of TLS variable

2022-02-17 Thread Serge Guelton
> I took a quick look at C++20 coroutines since they are available in > compilers but the primitives look hard to use even from C++, let alone > from C. Same story here :-/

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-17 Thread Jag Raman
> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: > > On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman wrote: >> >> The compiler path that cmake gets from meson is corrupted. It results in >> the following error: >> | -- The C compiler identification is unknown >> | CMake Error at

Re: [PATCH 1/6] block/io.c: fix bdrv_child_cb_drained_begin invocations from a coroutine

2022-02-17 Thread Emanuele Giuseppe Esposito
On 14/02/2022 12:57, Paolo Bonzini wrote: > On 2/14/22 11:27, Emanuele Giuseppe Esposito wrote: >> Anyways, I think that in addition to the fix in this patch, we should >> also fix bdrv_parent_drained_begin_single(poll=true) in >> bdrv_replace_child_noperm, with something similar to what is

[PATCH v4 0/3] fix overlapping table handle numbers with large memory vms

2022-02-17 Thread Ani Sinha
This patchset tries to address the issue raised in https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . Patch 2 and patch 3 are dependent on patch 1. Patch 1 makes some code cleanup to make thing more readable and also is a preparatory patch for patches 2 and 3. Patch 2 is the actual fix. Patch

[PATCH v4 1/3] hw/smbios: code cleanup - use macro definitions for table header handles

2022-02-17 Thread Ani Sinha
This is a minor cleanup. Using macro definitions makes the code more readable. It is at once clear which tables use which handle numbers in their header. It also makes it easy to calculate the gaps between the numbers and update them if needed. Reviewed-by: Igor Mammedov Signed-off-by: Ani Sinha

Re: [PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

2022-02-17 Thread Daniel P . Berrangé
On Thu, Feb 17, 2022 at 04:30:06PM +0100, Pierre Morel wrote: > > > On 2/17/22 15:20, Daniel P. Berrangé wrote: > > On Thu, Feb 17, 2022 at 02:41:22PM +0100, Pierre Morel wrote: > > > S390 CPU topology may have up to 5 topology containers. > > > The first container above the cores is level 2,

Re: [PATCH v17] qapi: introduce 'x-query-x86-cpuid' QMP command.

2022-02-17 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Ping :) Any hope that we will merge it one day?) Up to the x86 CPU maintainers: Paolo & Marcelo.

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki wrote: > On Thu, Feb 17, 2022 at 8:58 PM wrote: > > > > From: Marc-André Lureau > > > > Hi, > > > > In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console", > Akihiko > > Odaki reported a number of issues with the GL and D-Bus

[PATCH v2 05/12] ui/console: move dcl compatiblity check to a callback

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau As expected from the "compatible_dcl" comment, a simple comparison of ops isn't enough. The following patch will fix a regression introduced by this limited check by extending the compatibility callback for egl-headless. For now, this patch simply replaces the the

[PATCH v2 06/12] ui/console: egl-headless is compatible with non-gl listeners

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau Fix a regression introduced by commit 5e79d516e ("ui: split the GL context in a different object"). Reported-by: Akihiko Odaki Signed-off-by: Marc-André Lureau --- ui/egl-headless.c | 8 1 file changed, 8 insertions(+) diff --git a/ui/egl-headless.c

[PATCH v2 04/12] ui/console: move check for compatible GL context

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau Move GL context compatibility check in dpy_compatible_with(), and use recommended error reporting. Signed-off-by: Marc-André Lureau --- ui/console.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/ui/console.c b/ui/console.c

Re: [PATCH v4 7/7] hw/mips/gt64xxx_pci: Resolve gt64120_register()

2022-02-17 Thread BALATON Zoltan
On Thu, 17 Feb 2022, Bernhard Beschow wrote: Now that gt64120_register() lost its pic parameter, there is an opportunity to remove it. gt64120_register() is old style by wrapping qdev API, and the new style is to use qdev directly. So take the opportunity and modernize the code. Suggested-by:

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Wed, Feb 16, 2022 at 07:40:14PM +, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The following changes since commit > > >

Re: [PATCH] tcg: Remove dh_alias indirection for dh_typecode

2022-02-17 Thread Christian Ehrhardt
On Thu, Feb 17, 2022 at 4:48 AM Richard Henderson wrote: > > The dh_alias redirect is intended to handle TCG types as distinguished > from C types. TCG does not distinguish signed int from unsigned int, > because they are the same size. However, we need to retain this > distinction for

Re: [PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-17 Thread Ani Sinha
On Thu, 17 Feb 2022, Igor Mammedov wrote: > On Mon, 14 Feb 2022 19:42:35 +0530 > > > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2023977 > s/buglink/Resolves/ > OK I am curious about this one. Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html , If your patch

[PATCH v6 01/11] s390x: SCLP: reporting the maximum nested topology entries

2022-02-17 Thread Pierre Morel
The maximum nested topology entries is used by the guest to know how many nested topology are available on the machine. Currently, reporting SCLP reports 0, which is the equivalent of reporting the default value of 2. Let's use the default SCLP value of 2 and increase this value in the future

Re: [RFC PATCH 3/3] tests/tcg/ppc64le: Use vector types instead of __int128

2022-02-17 Thread Matheus K. Ferst
On 17/02/2022 05:09, Cédric Le Goater wrote: On 2/8/22 21:31, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst LLVM/Clang doesn't like inline asm with __int128, use a vector type instead. Signed-off-by: Matheus Ferst --- Alternatively, we could pass VSR values in GPR pairs, as we

Re: [PATCH v5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Vitaly Chikunov
On Thu, Feb 17, 2022 at 10:26:37AM +0100, Christian Schoenebeck wrote: > On Mittwoch, 16. Februar 2022 19:18:21 CET Vitaly Chikunov wrote: > > `struct dirent' returned from readdir(3) could be shorter (or longer) > > than `sizeof(struct dirent)', thus memcpy of sizeof length will overread > > into

[PATCH v6 04/11] s390x: CPU topology: CPU topology migration

2022-02-17 Thread Pierre Morel
Both source and target must have the same configuration regarding the activation of Perform Topology Function and Store Topology System Information. Signed-off-by: Pierre Morel --- target/s390x/cpu.h | 2 ++ target/s390x/cpu_features_def.h.inc | 1 + target/s390x/cpu_models.c

Re: [PATCH v4 00/12] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-02-17 Thread Chao Peng
On Tue, Feb 08, 2022 at 08:33:18PM +0200, Mike Rapoport wrote: > (addded linux-api) > > On Tue, Jan 18, 2022 at 09:21:09PM +0800, Chao Peng wrote: > > This is the v4 of this series which try to implement the fd-based KVM > > guest private memory. The patches are based on latest kvm/queue branch >

[PATCH] MAINTAINERS: Update the files in the FreeBSD section

2022-02-17 Thread Thomas Huth
The FreeBSD CI definitions now reside in other files than .cirrs.yml. Update the entry in MAINTAINERS accordingly. Signed-off-by: Thomas Huth --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81aa31b5e1..38da514214 100644 ---

[PATCH v2 08/12] ui/console: move console compatibility check to dcl_display_console()

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau The current checks are done at registration time only. However, if a DCL has no specific console specified, it may be switched dynamically with console_select() later on. Let's move the checks when displaychangelistener_display_console() is called, which includes

[PATCH v2 07/12] ui/dbus: associate the DBusDisplayConsole listener with the given console

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau DBusDisplayConsole is specific to a given QemuConsole. Fixes: commit 142ca628 ("ui: add a D-Bus display backend") Reported-by: Akihiko Odaki Signed-off-by: Marc-André Lureau --- ui/dbus.h | 3 +++ ui/dbus-console.c | 27 +-- ui/dbus.c

RE: [PATCH v2 1/3] virtio-crypto: header update

2022-02-17 Thread Gonglei (Arei)
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:44 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualizat...@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; qemu-devel@nongnu.org; >

Re: [PATCH 1/1] numa: check mem or memdev in numa configuration

2022-02-17 Thread Li Zhang
On 2/17/22 11:25 AM, Igor Mammedov wrote: On Thu, 17 Feb 2022 10:38:32 +0100 Li Zhang wrote: On 2/17/22 10:10 AM, Igor Mammedov wrote: On Wed, 16 Feb 2022 17:36:13 +0100 Li Zhang wrote: If there is no mem or memdev in numa configuration, it always reports the error as the following:

[PATCH v2 10/12] ui/shader: free associated programs

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/shader.c b/ui/shader.c index 4c80fc831f68..ab448c41d4c6 100644 --- a/ui/shader.c +++ b/ui/shader.c @@ -172,5 +172,8 @@ void qemu_gl_fini_shader(QemuGLShader *gls)

[PATCH v2 12/12] ui/dbus: fix texture sharing

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau The DBus listener naively create, update and destroy textures without taking into account other listeners. The texture were shared, but texture update was unnecessarily duplicated. Teach DisplayGLCtx to do optionally shared texture handling. This is only implemented for

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-17 Thread Eugenio Perez Martin
On Tue, Feb 8, 2022 at 9:16 AM Jason Wang wrote: > > > 在 2022/2/1 下午7:25, Eugenio Perez Martin 写道: > > On Sun, Jan 30, 2022 at 7:47 AM Jason Wang wrote: > >> > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > >>> @@ -272,6 +590,28 @@ void vhost_svq_set_svq_kick_fd(VhostShadowVirtqueue > >>> *svq, int

Re: [PATCH v3 10/37] target/ppc: Move Vector Compare Not Equal or Zero to decodetree

2022-02-17 Thread Matheus K. Ferst
On 11/02/2022 01:41, Richard Henderson wrote: On 2/10/22 23:34, matheus.fe...@eldorado.org.br wrote: +static void gen_vcmpnez_vec(unsigned vece, TCGv_vec t, TCGv_vec a, TCGv_vec b) +{ +    TCGv_vec t0, t1, zero; + +    t0 = tcg_temp_new_vec_matching(t); +    t1 = tcg_temp_new_vec_matching(t);

Re: [PATCH] tcg: Remove dh_alias indirection for dh_typecode

2022-02-17 Thread Alex Bennée
Richard Henderson writes: > The dh_alias redirect is intended to handle TCG types as distinguished > from C types. TCG does not distinguish signed int from unsigned int, > because they are the same size. However, we need to retain this > distinction for dh_typecode, lest we fail to extend

Re: [PATCH v4 04/12] mm/shmem: Support memfile_notifier

2022-02-17 Thread Chao Peng
On Fri, Feb 11, 2022 at 03:40:09PM -0800, Andy Lutomirski wrote: > On 1/18/22 05:21, Chao Peng wrote: > > It maintains a memfile_notifier list in shmem_inode_info structure and > > implements memfile_pfn_ops callbacks defined by memfile_notifier. It > > then exposes them to memfile_notifier via >

[PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

2022-02-17 Thread Pierre Morel
S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets, and the level 3, containing sockets are the books. We introduce here the drawers, drawers is the level containing books. Let's add drawers, level4, containers to the CPU topology.

[PATCH v6 11/11] s390x: topology: documentation

2022-02-17 Thread Pierre Morel
The use of the S390x CPU topology is explain in a new documentation file. Signed-off-by: Pierre Morel --- docs/system/s390x/numa-cpu-topology.rst | 273 1 file changed, 273 insertions(+) create mode 100644 docs/system/s390x/numa-cpu-topology.rst diff --git

Re: [PATCH 1/1] numa: check mem or memdev in numa configuration

2022-02-17 Thread Igor Mammedov
On Thu, 17 Feb 2022 13:24:08 +0100 Li Zhang wrote: > On 2/17/22 11:25 AM, Igor Mammedov wrote: > > On Thu, 17 Feb 2022 10:38:32 +0100 > > Li Zhang wrote: > > > >> On 2/17/22 10:10 AM, Igor Mammedov wrote: > >>> On Wed, 16 Feb 2022 17:36:13 +0100 > >>> Li Zhang wrote: > >>> > If

[PATCH v6 09/11] s390x: topology: Adding drawers to STSI

2022-02-17 Thread Pierre Morel
Let's add STSI support for the container level 4, drawers, and provide the information back to the guest. Signed-off-by: Pierre Morel --- hw/s390x/cpu-topology.c | 137 +--- include/hw/s390x/cpu-topology.h | 19 - include/hw/s390x/sclp.h | 2 +-

[PATCH v6 10/11] s390x: topology: implementing numa for the s390x topology

2022-02-17 Thread Pierre Morel
S390x CPU Topology allows a non uniform repartition of the CPU inside the topology containers, sockets, books and drawers. We use numa to place the CPU inside the right topology container and report the non uniform topology to the guest. Note that s390x needs CPU0 to belong to the topology and

[PATCH v6 00/11] s390x: CPU Topology

2022-02-17 Thread Pierre Morel
Hi, The goal of this series is to implement CPU topology for S390, it improves the preceeding series with the implementation of books and drawers, of non uniform CPU topology and with documentation. To use these patches, you will need the Linux series version 5. You find it there:

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-02-17 Thread Chao Peng
On Tue, Jan 25, 2022 at 09:20:39PM +0100, Maciej S. Szmigiero wrote: > On 18.01.2022 14:21, Chao Peng wrote: > > KVM_MEM_PRIVATE is not exposed by default but architecture code can turn > > on it by implementing kvm_arch_private_memory_supported(). > > > > Also private memslot cannot be movable

[PATCH v6 05/11] s390x: kvm: topology: interception of PTF instruction

2022-02-17 Thread Pierre Morel
When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension. The PTF instructions with function code 0 and 1 are

Re: [PATCH v5 05/20] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED

2022-02-17 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 09:34:58AM -0500, Emanuele Giuseppe Esposito wrote: > Same as AIO_WAIT_WHILE macro, but if we are in the Main loop > do not release and then acquire ctx_ 's aiocontext. > > Once all Aiocontext locks go away, this macro will replace > AIO_WAIT_WHILE. > > Signed-off-by:

[PULL 03/12] linux-headers: Update headers to v5.17-rc1

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Update headers to 5.17-rc1. I need latest fuse changes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-3-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- include/standard-headers/asm-x86/kvm_para.h | 1 +

[PULL 01/12] virtiofsd: Do not support blocking flock

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Sebastian Hasler With the current implementation, blocking flock can lead to deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts to perform a blocking flock request. Signed-off-by: Sebastian Hasler Message-Id:

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert
to staging (2022-02-16 > 09:57:11 +) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20220217 > > for you to fetch changes up to e138ec4ac86ea71d10ecd032edc433290776a5f2: > > virtiofsd: Add basic suppor

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki >> > wrote: >> >> >> >> On Thu, Feb

[PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Add capability to enable and parse security context as sent by client and put into fuse_req. Filesystems now can get security context from request and set it on files during creation. Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-6-vgo...@redhat.com>

[PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal ->capable keeps track of what capabilities kernel supports and ->wants keep track of what capabilities filesytem wants. Right now these fields are 32bit in size. But now fuse has run out of bits and capabilities can now have bit number which are higher than 31. That means 32

[PULL 07/12] virtiofsd: Move core file creation code in separate function

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal

Re: [PATCH] migration: NULL transport_data after freeing

2022-02-17 Thread Dr. David Alan Gilbert
* Hanna Reitz (hre...@redhat.com) wrote: > migration_incoming_state_destroy() NULLs all objects it frees after they > are freed, presumably so that a subsequent call to the same function > will not free them again, unless new objects have been created in the > meantime. > > transport_data is the

[PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Add some code to parse extended "struct fuse_init_in". And use a local variable "flag" to represent 64 bit flags. This will make it easier to add more features without having to worry about two 32bit flags (->flags and ->flags2) in "fuse_struct_in". Signed-off-by: Vivek Goyal

[PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Soon we will be able to create and also set security context on the file atomically using /proc/self/task/tid/attr/fscreate knob. If this knob is available on the system, first set the knob with the desired context and then create the file. It will be created with the context

[PULL 11/12] virtiofsd: Add an option to enable/disable security label

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Provide an option "-o security_label/no_security_label" to enable/disable security label functionality. By default these are turned off. If enabled, server will indicate to client that it is capable of handling one security label during file creation. Typically this is

[PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz Honor the expected behavior of syncfs() to synchronously flush all data and metadata to disk on linux systems. If virtiofsd is started with '-o announce_submounts', the client is expected to send a FUSE_SYNCFS request for each individual submount. In this case, we just create a

[PULL 09/12] virtiofsd: Create new file with security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal This patch adds support for creating new file with security context as sent by client. It basically takes three paths. - If no security context enabled, then it continues to create files without security context. - If security context is enabled and but security.selinux has

[PULL 10/12] virtiofsd: Create new file using O_TMPFILE and set security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal If guest and host policies can't work with each other, then guest security context (selinux label) needs to be set into an xattr. Say remap guest security.selinux xattr to trusted.virtiofs.security.selinux. That means setting "fscreate" is not going to help as that's ony

Re: [PATCH v2 00/15] target/arm: Implement LVA, LPA, LPA2 features

2022-02-17 Thread Alex Bennée
Peter Maydell writes: > On Thu, 10 Feb 2022 at 04:04, Richard Henderson > wrote: >> >> Changes for v2: >> * Introduce FIELD_SEX64, instead of open-coding w/ sextract64. >> * Set TCR_EL1 more completely for user-only. >> * Continue to bound tsz within aa64_va_parameters; >> provide

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 9:25 PM Akihiko Odaki wrote: > On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki > wrote: > >> > >> On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau > >> wrote: > >> > > >> > Hi > >> > > >>

[PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

2022-02-17 Thread Lukasz Maniak
Changes since v4: - Added hello world example for SR-IOV to the docs - Moved AER initialization from nvme_init_ctrl to nvme_init_state - Fixed division by zero issue in calculation of vqfrt and vifrt capabilities Knut Omang (2): pcie: Add support for Single Root I/O Virtualization (SR/IOV)

Re: [PATCH] ppc/spapr: Advertise StoreEOI for POWER10 compat guests

2022-02-17 Thread Cédric Le Goater
Unfortunately, this patch breaks migration under TCG because the XIVE source flag is not updated on the target side. KVM is not impacted because the emulated sources are not used. This needs to be addressed in a v2. That said, even without this patch, TCG migration is broken. some CPUs on the

[PATCH v5 06/15] hw/nvme: Add support for Primary Controller Capabilities

2022-02-17 Thread Lukasz Maniak
Implementation of Primary Controller Capabilities data structure (Identify command with CNS value of 14h). Currently, the command returns only ID of a primary controller. Handling of remaining fields are added in subsequent patches implementing virtualization enhancements. Signed-off-by: Lukasz

[PATCH v5 01/15] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2022-02-17 Thread Lukasz Maniak
From: Knut Omang This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang --- hw/pci/meson.build | 1 + hw/pci/pci.c| 100 +--- hw/pci/pcie.c

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:36 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 9:25 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki >> > wrote: >> >> >> >> On Fri, Feb

[PATCH v5 05/15] hw/nvme: Add support for SR-IOV

2022-02-17 Thread Lukasz Maniak
This patch implements initial support for Single Root I/O Virtualization on an NVMe device. Essentially, it allows to define the maximum number of virtual functions supported by the NVMe controller via sriov_max_vfs parameter. Passing a non-zero value to sriov_max_vfs triggers reporting of

  1   2   3   >