[PATCH v3 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15

These are raised by guest instructions, and should not fall through into the default abort case. Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/m68k/cpu_loop.c b/linux-user/m68k/cpu_loop.c index

[PATCH v3 01/17] target/m68k: Raise the TRAPn exception with the correct pc

Rather than adjust the PC in all of the consumers, raise the exception with the correct PC in the first place. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 1 - target/m68k/op_helper.c| 9 - target/m68k/translate.c| 2 +- 3 files

Re: [PULL 0/8] s390x and misc fixes

On 15/03/2022 20.30, Peter Maydell wrote: On Tue, 15 Mar 2022 at 18:58, Peter Maydell wrote: On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote: Hi Peter! The following changes since commit 352998df1c53b366413690d95b35f76d0721ebed: Merge tag 'i2c-20220314' of

[PATCH v2] MAINTAINERS: change Vladimir's email address

Old vsement...@virtuozzo.com is not accessible anymore. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: @ya.ru mailbox works bad with mailing lists and git send-email command, @mail.ru works normally. Probably, I'll have to change the email again in the near future. May be not. But I think

[PATCH v3 13/17] target/m68k: Implement FTRAPcc

Signed-off-by: Richard Henderson --- target/m68k/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 6118f9fcfb..14f8c702c1 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@

[PATCH v3 05/17] target/m68k: Remove retaddr in m68k_interrupt_all

The only value this variable holds is now env->pc. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/target/m68k/op_helper.c

Re: [PATCH v3 0/3] Fixes for building on Solaris 11.4.42 CBE

On Tue, Mar 15, 2022 at 10:52:24PM -0500, Andrew Deason wrote: > With these minor fixes, I can build qemu on Solaris 11.4.42 CBE > (Oracle's new rolling release thing), using '--disable-rdma > --enable-modules --disable-dbus-display --target-list=x86_64-softmmu'. > I'm just interested in the guest

Re: [PATCH v3 2/3] hw/i386/acpi-build: Avoid 'sun' identifier

On Tue, Mar 15, 2022 at 10:52:26PM -0500, Andrew Deason wrote: > On Solaris, 'sun' is #define'd to 1, which causes errors if a variable > is named 'sun'. Slightly change the name of the var for the Slot User > Number so we can build on Solaris. > > Reviewed-by: Ani Sinha > Signed-off-by: Andrew

[PATCH 00/27] Misc fixes and cleanups for 7.0?

From: Marc-André Lureau Hi, Various clean-up and fixes patches that might be worth it for 7.0. Some of the patches have been posted and reviewed before. Marc-André Lureau (27): m68k/nios2-semi: fix gettimeofday() result check meson: remove bsd_oses meson: use chardev_ss dependencies

[PATCH 01/27] m68k/nios2-semi: fix gettimeofday() result check

From: Marc-André Lureau gettimeofday() returns 0 for success. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- target/m68k/m68k-semi.c | 2 +- target/nios2/nios2-semi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/27] Drop qemu_foo() socket API wrapper

From: Marc-André Lureau The socket API wrappers were initially introduced in commit 00aa0040 ("Wrap recv to avoid warnings"), but made redundant with commit a2d96af4 ("osdep: add wrappers for socket functions") which fixes the win32 declarations and thus removed the earlier warnings.

[PATCH 15/27] util: remove needless includes

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- util/cutils.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index c9b91e7535a8..53346138c970 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -27,8 +27,6 @@

[PATCH 13/27] Move HOST_LONG_BITS to compiler.h

From: Marc-André Lureau This will help to make common code independent. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 3 +++ include/qemu/osdep.h| 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/compiler.h

[PATCH v3 16/17] linux-user/strace: Adjust get_thread_area for m68k

Unlike i386, m68k get_thread_area has no arguments. Signed-off-by: Richard Henderson --- linux-user/strace.list | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/strace.list b/linux-user/strace.list index 278596acd1..72e17b1acf 100644 --- a/linux-user/strace.list +++

[PATCH 25/27] include/qapi: add g_autoptr support for qobject types

From: Marc-André Lureau Add small inline wrappers for qobject_unref() calls, which is a macro. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qbool.h | 6 ++ include/qapi/qmp/qdict.h | 6 ++ include/qapi/qmp/qlist.h | 8 +++- include/qapi/qmp/qnull.h | 6 ++

[PATCH v3 08/17] target/m68k: Fix address argument for EXCP_TRACE

According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), Trace (and others) is supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. Create gen_raise_exception_format2 to record the trapping pc in env->mmu.ar. Update

[PATCH v3 11/17] target/m68k: Implement TPF in terms of TRAPcc

TPF stands for "trap false", and is a long-form nop for ColdFire. Re-use the immediate consumption code from trapcc; the insn will already expand to a nop because of the TCG_COND_NEVER test within do_trapcc. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 18 +- 1

Re: [PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

Hi Pierre, On 2022/2/17 21:41, Pierre Morel wrote: S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets, and the level 3, containing sockets are the books. We introduce here the drawers, drawers is the level containing books.

Re: [PATCH v2 04/10] block.c: bdrv_replace_child_noperm: first remove the child, and then call ->detach()

Unfortunately this patch is not safe: theoretically ->detach can call bdrv_unapply_subtree_drain, and if it polls, will can call a bh that for example reads the graph, finding it in an inconsistent state, since it is between the two writes QLIST_REMOVE(child, next_parent); and QLIST_REMOVE(child,

[PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau --- audio/audio.h | 4 +-- block/qcow2.h

[PATCH 03/27] meson: use chardev_ss dependencies

From: Marc-André Lureau chardev subsystem/library doesn't use gnutls. Use the dedicated chardev_ss.dependencies() instead. Signed-off-by: Marc-André Lureau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[PATCH 04/27] meson: add util dependency for oslib-posix on freebsd

From: Marc-André Lureau kinfo_getproc() requires it. Signed-off-by: Marc-André Lureau --- util/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/meson.build b/util/meson.build index f6ee74ad0c85..bb0b010662d7 100644 --- a/util/meson.build +++

[PATCH 26/27] tests: replace free_all() usage with g_auto

From: Marc-André Lureau Use more idiomatic glib/auto-style code. Signed-off-by: Marc-André Lureau --- tests/unit/check-qobject.c | 127 - 1 file changed, 40 insertions(+), 87 deletions(-) diff --git a/tests/unit/check-qobject.c b/tests/unit/check-qobject.c

[PATCH 23/27] tests: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/unit/check-qobject.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/unit/check-qobject.c b/tests/unit/check-qobject.c index c1713d15af4e..c3d50e99949a 100644 --- a/tests/unit/check-qobject.c +++

Re: [PATCH] softmmu/physmem: Use qemu_madvise

On 16.03.22 05:04, Andrew Deason wrote: > We have a thin wrapper around madvise, called qemu_madvise, which > provides consistent behavior for the !CONFIG_MADVISE case, and works > around some platform-specific quirks (some platforms only provide > posix_madvise, and some don't offer all 'advise'

Re: [PATCH v2 05/10] block.c: bdrv_replace_child_noperm: first call ->attach(), and then add child

Unfortunately this patch is not safe: theoretically ->attach can call bdrv_apply_subtree_drain, and if it polls, will can call a bh that for example reads the graph, finding it in an inconsistent state, since it is between the two writes QLIST_INSERT_HEAD(>children, child, next); and

[PATCH 12/27] Simplify HOST_LONG_BITS

From: Marc-André Lureau Simplify the macro, not depending on headers defines, but compiler predefined __SIZEOF__POINTER__ only. Available since gcc 4.3 and clang 2.8. Signed-off-by: Marc-André Lureau Acked-by: Richard Henderson --- include/qemu/osdep.h | 8 +--- 1 file changed, 1

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Mon, 14 Mar 2022 14:25:41 + David Woodhouse wrote: > The check on x86ms->apic_id_limit in pc_machine_done() had two problems. > > Firstly, we need KVM to support the X2APIC API in order to allow IRQ > delivery to APICs >= 255. So we need to call/check kvm_enable_x2apic(), > which was

Re: [PATCH 2/4] intel_iommu: Support IR-only mode without DMA translation

On Mon, 2022-03-14 at 18:27 -0400, Michael S. Tsirkin wrote: > On Mon, Mar 14, 2022 at 03:45:47PM +, David Woodhouse wrote: > > It's the opposite of a feature — it's turning the feature *off* ;) > > Right. Still - do you believe it's appropriate in soft freeze > and if yes why? > Not sure I

[PATCH 27/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/qapi-forward-visitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/qapi-forward-visitor.c b/qapi/qapi-forward-visitor.c index 4ea7e0bec3f5..e36d9bc9ba7e 100644 --- a/qapi/qapi-forward-visitor.c +++

[PATCH v3 06/17] target/m68k: Fix address argument for EXCP_CHK

According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), CHK, CHK2 (and others) are supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. Create a raise_exception_format2 function to centralize recording of the trapping pc in

[PATCH v3 14/17] tests/tcg/m68k: Add trap.c

Test various trap instructions: chk, div, trap, trapv, trapcc, ftrapcc, and the signals and addresses that we expect from them. Signed-off-by: Richard Henderson --- tests/tcg/m68k/trap.c | 129 + tests/tcg/m68k/Makefile.target | 3 + 2 files changed,

[PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad usage, if the config header wasn't included before.

[PATCH 14/27] scripts/modinfo-collect: remove unused/dead code

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- scripts/modinfo-collect.py | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py index 61b90688c6dc..4e7584df6676 100755 --- a/scripts/modinfo-collect.py +++

[PATCH v3 10/17] target/m68k: Implement TRAPcc

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ linux-user/m68k/cpu_loop.c | 1 + target/m68k/cpu.c | 1 + target/m68k/op_helper.c| 6 + target/m68k/translate.c| 49

[PATCH v3 12/17] target/m68k: Implement TRAPV

Signed-off-by: Richard Henderson --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 86e5e16f71..6118f9fcfb 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -4911,6 +4911,14 @@

[PATCH v3 15/17] linux-user/strace: Fix print_syscall_err

Errors are not all negative numbers, but only the top 4k. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 2cdbf030ba..f235118fb6

[PATCH v5] ui/cocoa: Use NSWindow's ability to resize

This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 539

[PATCH] audio/mixeng: Do not declare unused variables

The unused variables when FLOAT_MIXENG is defined caused warnings on Apple clang version 13.1.6 (clang-1316.0.21.2). Signed-off-by: Akihiko Odaki --- audio/mixeng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index

Re: [PATCH v2 1/2] target/riscv: cpu: Fixup indentation

On 3/15/22 18:59, Alistair Francis wrote: From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Richard Henderson r~

[PULL v2 0/7] s390x and misc fixes

Hi Peter! The following changes since commit d6f229f9a0592c4d5beb0a5c4e024231c27680d3: Update version for v7.0.0-rc0 release (2022-03-15 23:07:40 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-03-15v2 for you to fetch changes up to

[PATCH 17/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- qapi/qmp-dispatch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index d378bccac73b..0990873ec8ec 100644 --- a/qapi/qmp-dispatch.c +++

[PATCH v3 07/17] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0

According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), Zero Div (and others) is supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. While the N, Z and V flags are documented to be undefine on DIV0, the C flag is documented

[PATCH v3 17/17] target/m68k: Mark helper_raise_exception as noreturn

Also mark raise_exception_ra and raise_exception, lest we generate a warning about helper_raise_exception returning. Signed-off-by: Richard Henderson --- target/m68k/helper.h| 2 +- target/m68k/op_helper.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2 2/2] target/riscv: Allow software access to MIP SEIP

On 3/15/22 18:59, Alistair Francis wrote: +if (mask & MIP_SEIP) { +env->software_seip = new_val & MIP_SEIP; +} +new_val |= env->external_seip << IRQ_S_EXT; You can move the second statement inside the if as well, since you don't need bits in new_val set that are not in

Re: [PATCH v4 2/2] target/riscv: Enable Zicbo[m,z,p] instructions

On Wed, Feb 16, 2022 at 9:18 PM Christoph Muellner wrote: > > The RISC-V base cache management operation ISA extension has been > ratified. This patch adds support for the defined instructions. > > The cmo.prefetch instructions are nops for QEMU (no emulation of the memory > hierarchy, no illegal

Re: [PATCH v1 5/8] mailmap/gitdm: more fixes for bad tags and authors

Alex Bennée writes: > I was running some historical tags for the last 10 years and got the > following warnings: > > git log --use-mailmap --numstat --since "June 2010" | ~/src/gitdm.git/gitdm > -n -l 5 > alar...@ddci.com is an author name, probably not what you want > bad utf-8 ('utf-8'

Re: [PATCH] softmmu/physmem: Use qemu_madvise

On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: > > On 16.03.22 05:04, Andrew Deason wrote: > > We have a thin wrapper around madvise, called qemu_madvise, which > > provides consistent behavior for the !CONFIG_MADVISE case, and works > > around some platform-specific quirks (some

Re: [PATCH] softmmu/physmem: Use qemu_madvise

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: > > > > On 16.03.22 05:04, Andrew Deason wrote: > > > We have a thin wrapper around madvise, called qemu_madvise, which > > > provides consistent behavior for the !CONFIG_MADVISE case, and

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, 2022-03-16 at 10:04 +0100, Igor Mammedov wrote: > Well, I retested with the latest upstream kernel (both guest and host), > and adding kvm_enable_x2apic() is not sufficient as guest according > to your patches in kernel caps max APICID at 255 unless kvm-msi-ext-dest-id > is enabled. And

[PATCH 09/27] compiler.h: replace QEMU_SENTINEL with G_GNUC_NULL_TERMINATED

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h| 2 -- include/qom/object.h

[PATCH 08/27] compiler.h: replace QEMU_WARN_UNUSED_RESULT with G_GNUC_WARN_UNUSED_RESULT

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu-common.h | 2 +-

[PATCH 11/27] osdep: poison HOST_WORDS_BIGENDIAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Suggested-by: Richard Henderson --- include/qemu/osdep.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 322103aadbdc..7175ee53a217 100644 --- a/include/qemu/osdep.h +++

[PATCH 19/27] meson: fix CONFIG_ATOMIC128 check

From: Marc-André Lureau The current testing code isn't correct and matching QEMU usage: testfile.c: In function 'main': testfile.c:5:11: error: incorrect number of arguments to function '__atomic_load' 5 | y = __atomic_load(, 0); | ^ testfile.c:6:7: error:

[PATCH 16/27] util: remove the net/net.h dependency

From: Marc-André Lureau Move qemu_ether_ntoa() which is only needed in net/. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- include/qemu-common.h | 1 - net/announce.c| 13 + util/cutils.c | 14 -- 3

[PATCH 21/27] qga: remove bswap.h include

From: Marc-André Lureau Apparently not needed anymore. Signed-off-by: Marc-André Lureau --- qga/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 15fd3a4149f4..b9dd19918e47 100644 --- a/qga/main.c +++ b/qga/main.c @@ -27,7 +27,6 @@ #include

[PATCH 20/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/string-output-visitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c index 5506c933deef..71ddc92b7b98 100644 --- a/qapi/string-output-visitor.c +++

[PATCH 22/27] error-report: replace error progname with glib functions

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/qemu/error-report.h | 2 -- qemu-io.c| 10 +- softmmu/vl.c | 2 +- storage-daemon/qemu-storage-daemon.c | 2 +- trace/control.c | 2

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > I still remember you mentioned the upper layer softwares can have > > > assumption on using only 1 pair of socket for migration, I think that > > > makes > > >

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On 16/03/2022 12.15, Halil Pasic wrote: On Wed, 16 Mar 2022 11:28:59 +0100 Thomas Huth wrote: On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On Wed, 16 Mar 2022 13:53:07 +0400 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace a config-time define with a compile time condition > define (compatible with clang and gcc) that must be declared prior to > its usage. This avoids having a global configure time define,

Re: [PATCH v2] tests/avocado: starts PhoneServer upfront

Beraldo Leal writes: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a free port, then we save this

Re: [PATCH 2/2] target/arm: Log fault address for M-profile faults

Peter Maydell writes: > For M-profile, the fault address is not always exposed to the guest > in a fault register (for instance the BFAR bus fault address register > is only updated for bus faults on data accesses, not instruction > accesses). Currently we log the address only if we're

Re: [PATCH 17/27] qapi: remove needless include

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Reviewed-by: Richard Henderson > --- > qapi/qmp-dispatch.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c > index d378bccac73b..0990873ec8ec

Re: [PULL 0/8] s390x and misc fixes

On 3/15/22 20:30, Peter Maydell wrote: coredata.CoreData File "/Users/pm215/src/qemu-for-merges/meson/mesonbuild/coredata.py", line 1003, in load obj = pickle.load(f) File "/Users/pm215/src/qemu-for-merges/meson/mesonbuild/mesonlib/universal.py", line 2076, in __setstate__

[PATCH 3/3] hw/display/vga: Report a proper error when adding a 2nd ISA VGA

QEMU currently abort()s if the user tries to add a second ISA VGA device, for example: $ ./qemu-system-x86_64 -device isa-vga -device isa-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) $ ./qemu-system-x86_64 -device isa-cirrus-vga -device isa-cirrus-vga RAMBlock

Re: [PATCH 00/27] Misc fixes and cleanups for 7.0?

On Wed, Mar 16, 2022 at 01:51:56PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Various clean-up and fixes patches that might be worth it for 7.0. > Some of the patches have been posted and reviewed before. FYI, something went wrong with this posting, as it

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

Hi On Wed, Mar 16, 2022 at 5:00 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Hi > > > > On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wrote: > >> > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > Use more idiomatic

Re: [PATCH 16/27] util: remove the net/net.h dependency

On 16/3/22 10:54, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Move qemu_ether_ntoa() which is only needed in net/. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- include/qemu-common.h | 1 - net/announce.c| 13

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

On 16/03/2022 14.16, Philippe Mathieu-Daudé wrote: On 16/3/22 10:52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by:

Re: Call for GSoC and Outreachy project ideas for summer 2022

Hey Stefan! On 16.03.22 14:16, Stefan Hajnoczi wrote: On Mon, 14 Feb 2022 at 13:58, Stefan Hajnoczi wrote: On Wed, 9 Feb 2022 at 14:50, Alexander Graf wrote: On 28.01.22 16:47, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2022

Re: [PATCH 13/27] Move HOST_LONG_BITS to compiler.h

On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This will help to make common code independent. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 3 +++ include/qemu/osdep.h| 3 --- 2 files changed, 3

Re: [PATCH v2 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

On Tue, Mar 15, 2022 at 07:38:12PM +0800, Yongji Xie wrote: > On Tue, Mar 15, 2022 at 5:48 PM Stefan Hajnoczi wrote: > > > > On Tue, Feb 15, 2022 at 06:59:40PM +0800, Xie Yongji wrote: > > > VDUSE [1] is a linux framework that makes it possible to implement > > > software-emulated vDPA devices in

[PATCH v2] tests/migration: Introduce dirty-ring-size option into guestperf

From: Hyman Huang(黄勇) Guestperf tool does not enable diry ring feature when test migration by default. To support dirty ring migration performance test, introduce dirty-ring-size option into guestperf tools, which ranges in [1024, 65536]. To set dirty ring size with 4096 during migration test:

[PATCH-for-7.0 v2] qga/vss-win32: fix compilation with clang++

This fixes: qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *' char *msg = NULL, *nul = strchr(text, '('); ^ ~ Signed-off-by: Helge Konetzka Reviewed-by: Marc-André Lureau

Re: [PATCH 0/3] coroutine: use QEMU_DEFINE_STATIC_CO_TLS()

On Mon, Mar 07, 2022 at 03:38:50PM +, Stefan Hajnoczi wrote: > The coroutine implementation uses __thread variables internally. Compiler > optimizations may cache Thread-Local Storage values across > qemu_coroutine_yield(), leading to stale values being used after the coroutine > is re-entered

Re: [PATCH 2/3] hw/display: Allow vga_common_init() to return errors

Thomas Huth writes: > On 16/03/2022 14.32, Philippe Mathieu-Daudé wrote: >> On 16/3/22 14:24, Thomas Huth wrote: >>> The vga_common_init() function currently cannot report errors to its >>> caller. But in the following patch, we'd need this possibility, so >>> let's change it to take an "Error

Re: [RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu

On 3/16/22 11:24, Daniel P. Berrangé wrote: On Wed, Mar 16, 2022 at 10:54:55AM +0100, Damien Hedde wrote: It takes an input file containing raw qmp commands (concatenated json dicts) and send all commands one by one to a qmp server. When one command fails, it exits. As a convenience, it can

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: > On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 4/3/22 17:46, Kevin Wolf wrote: >>> From: Emanuele Giuseppe Esposito >>> >>> All the global state (GS) API functions will check that >>> qemu_in_main_thread() returns true.

[PATCH 02/27] meson: remove bsd_oses

From: Marc-André Lureau It is unused. Signed-off-by: Marc-André Lureau --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index bae62efc9c33..784e91753630 100644 --- a/meson.build +++ b/meson.build @@ -44,7 +44,6 @@ config_host_data =

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, Mar 16, 2022 at 10:37:49AM +, David Woodhouse wrote: > On Wed, 2022-03-16 at 05:56 -0400, Michael S. Tsirkin wrote: > > On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > > > Yep, that's the guest operating system's choice. Not a qemu problem. > > > > > > Even if you

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, 2022-03-16 at 05:56 -0400, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > > Yep, that's the guest operating system's choice. Not a qemu problem. > > > > Even if you have the split IRQ chip, if you boot a guest without kvm- > >

Re: [PATCH v2 1/6] block: Support passing NULL ops to blk_set_dev_ops()

On Tue, Mar 15, 2022 at 03:30:22PM -0400, John Snow wrote: > On Tue, Mar 15, 2022 at 4:47 AM Stefan Hajnoczi wrote: > > > > On Mon, Mar 14, 2022 at 03:09:35PM -0400, John Snow wrote: > > > On Mon, Mar 14, 2022 at 1:23 PM Stefan Hajnoczi > > > wrote: > > > > > > > > On Tue, Feb 15, 2022 at

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. I'm getting this crash: $

Re: [PATCH v2] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

On Fri, Mar 11, 2022 at 5:46 PM Weiwei Li wrote: > > For csrrs and csrrc, if rs1 specifies a register other than x0, holding > a zero value, the instruction will still attempt to write the unmodified > value back to the csr and will cause side effects > > v2: > * change to explictly pass "bool

Re: [PATCH experiment 00/16] C++20 coroutine backend

On Wed, Mar 16, 2022 at 12:32:48PM +, Stefan Hajnoczi wrote: > On Tue, Mar 15, 2022 at 06:29:50PM +0100, Paolo Bonzini wrote: > > On 3/15/22 15:24, Peter Maydell wrote: > > > On Tue, 15 Mar 2022 at 14:09, Stefan Hajnoczi wrote: > > > > Also, once C++ is available people will > > > > start

[PATCH v21 7/9] softmmu/dirtylimit: Implement dirty page rate limit

From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query

[PATCH v3 2/3] util/main-loop: Introduce the main loop into QOM

'event-loop-base' provides basic property handling for all 'AioContext' based event loops. So let's define a new 'MainLoopClass' that inherits from it. This will permit tweaking the main loop's properties through qapi as well as through the command line using the '-object' keyword[1]. Only one

[PATCH v2] docs/tcg-plugins: document QEMU_PLUGIN behaviour

QEMU plugins can be loaded via command line arguments or via the QEMU_PLUGIN environment variable. Currently, only the first method is documented. Let's document QEMU_PLUGIN. As drive-by cleanup, this patch fixes the path to the plugins in the same section of the documentation. Signed-off-by:

Re: [PULL 0/8] s390x and misc fixes

On 3/16/22 14:19, Peter Maydell wrote: I'm not sure why we're passing this explicitly to the linker anyway, though. According to the commit message the idea is to add libc++ automatically when you have C++ sources, libgfortran when you have Fortran sources etc. independent of the language

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

On 16/3/22 15:46, Emanuele Giuseppe Esposito wrote: Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that

[RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu

It takes an input file containing raw qmp commands (concatenated json dicts) and send all commands one by one to a qmp server. When one command fails, it exits. As a convenience, it can also wrap the qemu process to avoid having to start qemu in background. When wrapping qemu, the program returns

Re: [PULL 0/8] s390x and misc fixes

On 3/15/22 19:58, Peter Maydell wrote: This results in every "Linking" step on my macos box producing the warning: ld: warning: directory not found for option '-Lns/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0' This was reported already back in January

Re: [PATCH experiment 00/16] C++20 coroutine backend

On Wed, Mar 16, 2022 at 12:08:33AM +0100, Paolo Bonzini wrote: > On 3/15/22 16:55, Daniel P. Berrangé wrote: > > Expecting maintainers to enforce a subset during code review feels > > like it would be a tedious burden, that will inevitably let stuff > > through because humans are fallible,

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Use more idiomatic glib/auto-style code. > > Signed-off-by: Marc-André Lureau This is a bit of an improvement, but by its own, it's a rather weak justification for the previous patch. Do you have more uses of g_autoptr in the

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

Hi On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Use more idiomatic glib/auto-style code. > > > > Signed-off-by: Marc-André Lureau > > This is a bit of an improvement, but by its own, it's a rather weak >

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On 16/3/22 14:04, Philippe Mathieu-Daudé wrote: On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as

Kshitij Suri writes: > From: "kshitij.suri" > > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema > of

Re: [PATCH 24/27] Remove trailing ; after G_DEFINE_AUTO macro

On 16/3/22 10:54, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The macro doesn't need it. Signed-off-by: Marc-André Lureau --- configure| 2 +- nbd/server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

Hi On Wed, Mar 16, 2022 at 5:30 PM Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lur...@redhat.com wrote: > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > > index 3baa5e3790f7..f2bd050e3b9a 100644 > > --- a/include/qemu/compiler.h > > +++

  1   2   3   4   >