Re: [PATCH v4 00/18] iotests: add enhanced debugging info to qemu-img failures

2022-03-21 Thread Hanna Reitz
On 21.03.22 17:23, John Snow wrote: On Mon, Mar 21, 2022, 11:50 AM Hanna Reitz wrote: On 21.03.22 14:14, Hanna Reitz wrote: > On 18.03.22 22:14, John Snow wrote: >> On Fri, Mar 18, 2022 at 9:36 AM Hanna Reitz wrote: >>> On 18.03.22 00:49, John Snow wrote: Hiya!

[PULL 1/2] target/i386: kvm: do not access uninitialized variable on older kernels

2022-03-21 Thread Paolo Bonzini
KVM support for AMX includes a new system attribute, KVM_X86_XCOMP_GUEST_SUPP. Commit 19db68ca68 ("x86: Grant AMX permission for guest", 2022-03-15) however did not fully consider the behavior on older kernels. First, it warns too aggressively. Second, it invokes the KVM_GET_DEVICE_ATTR ioctl

[PULL 7/8] hw/sd/sdhci: Prohibit DMA accesses to devices

2022-03-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé The issue reported by OSS-Fuzz produces the following backtrace: ==447470==ERROR: AddressSanitizer: heap-buffer-overflow READ of size 1 at 0x6152a080 thread T0 #0 0x71766d47 in sdhci_read_dataport hw/sd/sdhci.c:474:18 #1 0x7175f139 in sdhci_read

Re: [PATCH 10/15] iotests/245: fixup

2022-03-21 Thread Eric Blake
On Fri, Mar 18, 2022 at 04:36:50PM -0400, John Snow wrote: > (Merge with prior patch.) > > Signed-off-by: John Snow > --- > tests/qemu-iotests/242 | 2 +- > tests/qemu-iotests/245 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Okay, now that I've looked at the fixups, and played

[PATCH v5 04/18] iotests: make qemu_img raise on non-zero rc by default

2022-03-21 Thread John Snow
re-write qemu_img() as a function that will by default raise a VerboseProcessException (extended from CalledProcessException) on non-zero return codes. This will produce a stack trace that will show the command line arguments and return code from the failed process run. Users that want something

[PATCH v1 7/9] aspeed/soc : Add AST1030 support

2022-03-21 Thread Jamin Lin
From: Steven Lee The embeded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee ---

[PATCH v1 5/9] aspeed/timer: Add AST1030 support.

2022-03-21 Thread Jamin Lin
From: Steven Lee ast1030 tmc(timer controller) is identical to ast2600 tmc. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/timer/aspeed_timer.c | 17 + include/hw/timer/aspeed_timer.h | 1 + 2 files changed, 18 insertions(+) diff

[PATCH v1 8/9] aspeed: Add an AST1030 eval board

2022-03-21 Thread Jamin Lin
From: Steven Lee The image should be supplied with ELF binary. $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 2 +- hw/arm/aspeed_minibmc.c | 129

[PATCH v1 9/9] test/avocado/machine_aspeed.py: Add ast1030 test case

2022-03-21 Thread Jamin Lin
Add test case to test "ast1030-evb" machine with zephyr os Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- tests/avocado/machine_aspeed.py | 36 + 1 file changed, 36 insertions(+) create mode 100644

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-21 Thread Jason Wang
On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: > > With MQ enabled vdpa device and non-MQ supporting guest e.g. > booting vdpa with mq=on over OVMF of single vqp, it's easy > to hit assert failure as the following: > > ../hw/virtio/vhost-vdpa.c:560: vhost_vdpa_get_vq_index: Assertion `idx >=

[PATCH v1 0/9] Add support for AST1030 SoC

2022-03-21 Thread Jamin Lin
The patch series supports ADC, SCU, SMC, TIMER, and WDT for AST1030 SoC. Add avocado test case for "ast1030-evb" machine. Test steps: 1. Download image from https://github.com/AspeedTech-BMC/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip 2. Extract the zip file to obtain zephyr.elf

[PATCH v1 4/9] aspeed/wdt: Add AST1030 support

2022-03-21 Thread Jamin Lin
From: Steven Lee AST1030 wdt controller is similiar to AST2600's wdt, but it has extra registers. Introduce ast1030 object class and increse the number of regs(offset) of ast1030 model. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/watchdog/wdt_aspeed.c

Re: [PATCH for-7.1 0/9] spapr: add drc->index, remove spapr_drc_index()

2022-03-21 Thread David Gibson
On Mon, Mar 21, 2022 at 04:58:47AM -0300, Daniel Henrique Barboza wrote: > > > On 3/21/22 00:55, David Gibson wrote: > > On Fri, Mar 18, 2022 at 02:33:11PM -0300, Daniel Henrique Barboza wrote: > > > Hi, > > > > > > I decided to make this change after realizing that (1) spapr_drc_index() > > >

Re: [PATCH v1 0/1] hw/gpio Add ASPEED GPIO model for AST1030

2022-03-21 Thread Jamin Lin
The 03/21/2022 10:55, Cédric Le Goater wrote: > Hello Jamin, > > On 3/21/22 10:14, Jamin Lin wrote: > > 1. Add GPIO read/write trace event. > > 2. Support GPIO index mode for write operation. > > It did not support GPIO index mode for read operation. > > 3. AST1030 integrates one set of Parallel

[PATCH v1 1/9] aspeed/adc: Add AST1030 support

2022-03-21 Thread Jamin Lin
From: Steven Lee Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/adc/aspeed_adc.c | 16 include/hw/adc/aspeed_adc.h | 1 + 2 files changed, 17 insertions(+)

Re: [PATCH v1 1/1] test/avocado/machine_aspeed.py: Add ast1030 test case

2022-03-21 Thread Jamin Lin
The 03/21/2022 17:39, Thomas Huth wrote: > On 21/03/2022 10.16, Jamin Lin wrote: > > Add test case to test "ast1030-evb" machine with zephyr os > > > > Signed-off-by: Jamin Lin > > --- > > tests/avocado/machine_aspeed.py | 36 + > > 1 file changed, 36

[PATCH v2 0/1] cmpxchg and lock cmpxchg should not touch accumulator

2022-03-21 Thread Wei Li
Bug: https://gitlab.com/qemu-project/qemu/-/issues/508 This series fix a bug reported on issues 508. The problem is cmpxchg and lock cmpxchg would touch accumulator when they should not do that. Changes from v1 * cmpxchg uses the lock cmpxchg path whenever mod != 3 to reduce code duplication.

[PATCH v2 1/1] fix cmpxchg and lock cmpxchg instruction

2022-03-21 Thread Wei Li
One question is that we can reduce more code duplication if we use - if(foo){ tcg_gen_atomic_cmpxchg_tl(oldv, s->A0, cmpv, newv, s->mem_index, ot | MO_LE); gen_extu(ot, oldv); gen_extu(ot, cmpv); }else{

[PATCH v1 3/9] aspeed/wdt: Fix ast2500/ast2600 default reload value.

2022-03-21 Thread Jamin Lin
From: Steven Lee Per ast2500_2520_datasheet_v1.8 and ast2600v11.pdf, the default value of WDT00 and WDT04 is 0x014FB180 for ast2500/ast2600. Add default_status and default_reload_value attributes for storing counter status and reload value as they are different from ast2400. Signed-off-by: Troy

[PATCH v1 6/9] aspeed/scu: Add AST1030 support

2022-03-21 Thread Jamin Lin
From: Steven Lee Per ast1030_v07.pdf, AST1030 SOC doesn't have SCU300, the pclk divider selection is defined in SCU310[11:8]. Add a get_apb_freq function and a class init handler for ast1030. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/misc/aspeed_scu.c

[PATCH v1 2/9] aspeed/smc: Add AST1030 support

2022-03-21 Thread Jamin Lin
From: Steven Lee AST1030 spi controller's address decoding unit is 1MB that is identical to ast2600, but fmc address decoding unit is 512kb. Introduce seg_to_reg and reg_to_seg handlers for ast1030 fmc controller. In addition, add ast1030 fmc, spi1, and spi2 class init handler. Signed-off-by:

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-21 Thread Xiaoyao Li
On 3/18/2022 10:07 PM, Philippe Mathieu-Daudé wrote: Hi, On 17/3/22 14:58, Xiaoyao Li wrote: TDX VM needs to boot with Trust Domain Virtual Firmware (TDVF). Unlike that OVMF is mapped as rom device, TDVF needs to be mapped as private memory. This is because TDX architecture doesn't provide

Re: [PATCH v4] tests: Do not treat the iotests as separate meson test target anymore

2022-03-21 Thread Hanna Reitz
On 18.03.22 18:36, Thomas Huth wrote: On 18/03/2022 18.04, Hanna Reitz wrote: On 10.03.22 08:50, Thomas Huth wrote: If there is a failing iotest, the output is currently not logged to the console anymore. To get this working again, we need to run the meson test runner with "--print-errorlogs"

[PATCH v3 4/6] vduse-blk: implements vduse-blk export

2022-03-21 Thread Xie Yongji
This implements a VDUSE block backends based on the libvduse library. We can use it to export the BDSs for both VM and container (host) usage. The new command-line syntax is: $ qemu-storage-daemon \ --blockdev file,node-name=drive0,filename=test.img \ --export

[PATCH qemu] ppc/spapr/ddw: Add 2M pagesize

2022-03-21 Thread Alexey Kardashevskiy
Recently the LoPAPR spec got a new 2MB pagesize to support in Dynamic DMA Windows API (DDW), this adds the new flag. Linux supports it since https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=38727311871 Signed-off-by: Alexey Kardashevskiy --- PHYP added support for

Re: [PATCH for-7.1 0/9] spapr: add drc->index, remove spapr_drc_index()

2022-03-21 Thread Daniel Henrique Barboza
On 3/21/22 00:55, David Gibson wrote: On Fri, Mar 18, 2022 at 02:33:11PM -0300, Daniel Henrique Barboza wrote: Hi, I decided to make this change after realizing that (1) spapr_drc_index() always return the same index value for the DRC regardless of machine or device state and (2) we call

Re: [RFC PATCH v3 16/36] i386/tdx: Set kvm_readonly_mem_enabled to false for TDX VM

2022-03-21 Thread Xiaoyao Li
On 3/19/2022 1:11 AM, Isaku Yamahata wrote: On Thu, Mar 17, 2022 at 09:58:53PM +0800, Xiaoyao Li wrote: TDX only supports readonly for shared memory but not for private memory. In the view of QEMU, it has no idea whether a memslot is used by shared memory of private. Thus just mark

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-21 Thread Stefano Garzarella
On Sat, Mar 19, 2022 at 02:23:18PM +0100, Ilya Dryomov wrote: On Sat, Mar 19, 2022 at 1:40 PM Ilya Dryomov wrote: On Fri, Mar 18, 2022 at 9:25 AM Stefano Garzarella wrote: > > On Thu, Mar 17, 2022 at 07:27:05PM +0100, Peter Lieven wrote: > > > > > >> Am 17.03.2022 um 17:26 schrieb Stefano

Re: [PATCH v2] target/i386: kvm: do not access uninitialized variable on older kernels

2022-03-21 Thread Peter Krempa
On Sun, Mar 20, 2022 at 20:39:14 +0100, Paolo Bonzini wrote: > KVM support for AMX includes a new system attribute, KVM_X86_XCOMP_GUEST_SUPP. > Commit 19db68ca68 ("x86: Grant AMX permission for guest", 2022-03-15) however > did not fully consider the behavior on older kernels. First, it warns >

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-21 Thread Stefano Garzarella
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote: Am 18.03.2022 um 17:47 schrieb Stefano Garzarella : On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote: Am 18.03.2022 um 09:25 schrieb Stefano Garzarella : On Thu, Mar 17, 2022 at 07:27:05PM +0100, Peter Lieven

Re: Proposal for a regular upstream performance testing

2022-03-21 Thread Lukáš Doktor
Dear qemu developers, you might remember the "replied to" email from a bit over year ago to raise a discussion about a qemu performance regression CI. On KVM forum I presented https://www.youtube.com/watch?v=Cbm3o4ACE3Y=PLbzoR-pLrL6q4ZzA4VRpy42Ua4-D2xHUR=9 some details about my testing

[PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-21 Thread Jason Wang
We use to warn on wrong rid2pasid entry. But this error could be triggered by the guest and could happens during initialization. So let's don't warn in this case. Signed-off-by: Jason Wang --- hw/i386/intel_iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH v3 33/36] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() for TDs

2022-03-21 Thread Xiaoyao Li
On 3/19/2022 1:31 AM, Isaku Yamahata wrote: On Thu, Mar 17, 2022 at 09:59:10PM +0800, Xiaoyao Li wrote: For TDs, only MSR_IA32_UCODE_REV in kvm_init_msrs() can be configured by VMM, while the features enumerated/controlled by other MSRs except MSR_IA32_UCODE_REV in kvm_init_msrs() are not

[RFC PATCH v2 1/1] hw/arm/realview: replace 'qemu_split_irq' with 'TYPE_SPLIT_IRQ'

2022-03-21 Thread Zongyuan Li
Signed-off-by: Zongyuan Li --- hw/arm/realview.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 7b424e94a5..97ace560bf 100644 --- a/hw/arm/realview.c +++ b/hw/arm/realview.c @@ -13,9

[RFC PATCH v2 0/1] Replace 'qemu_irq_split' with 'TYPE_SPLIT_IRQ'

2022-03-21 Thread Zongyuan Li
This is a WIP patch set trying to resolve https://gitlab.com/qemu-project/qemu/-/issues/811 which will totally replace 'qemu_irq_split' with use QOM object 'TYPE_SPLIT_IRQ' device. I just want to make sure I'm on the right way, so only 'realview' module is modified. Changes since v1: 1.

[PULL 3/3] target/ppc: Replicate Double->Single-Precision result

2022-03-21 Thread Cédric Le Goater
From: Lucas Coutinho Power ISA v3.1 formalizes the previously undefined result in words 1 and 3 to be a copy of the result in words 0 and 2. This affects: xvcvsxdsp, xvcvuxdsp, xvcvdpsp. And the previously undefined result in word 1 to be a copy of the result in word 0. This affects:

[PULL 2/3] target/ppc: Replicate double->int32 result for some vector insns

2022-03-21 Thread Cédric Le Goater
From: Richard Henderson Power ISA v3.1 formalizes the previously undefined result in words 1 and 3 to be a copy of the result in words 0 and 2. This affects: xscvdpsxws, xscvdpuxws, xvcvdpsxws, xvcvdpuxws. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/852 Signed-off-by: Richard

[PATCH v3 0/6] Support exporting BDSs via VDUSE

2022-03-21 Thread Xie Yongji
Hi all, Last few months ago, VDUSE (vDPA Device in Userspace) [1] has been merged into Linux kernel as a framework that make it possible to emulate a vDPA device in userspace. This series aimed at implementing a VDUSE block backend based on the qemu-storage-daemon infrastructure. To support

[PATCH v3 2/6] linux-headers: Add vduse.h

2022-03-21 Thread Xie Yongji
This adds vduse header to linux headers so that the relevant VDUSE API can be used in subsequent patches. Signed-off-by: Xie Yongji --- linux-headers/linux/vduse.h | 306 scripts/update-linux-headers.sh | 2 +- 2 files changed, 307 insertions(+), 1

Re: [PATCH v9 10/14] target/riscv: rvk: add support for sha512 related instructions for RV64 in zknh extension

2022-03-21 Thread Alistair Francis
On Fri, Mar 18, 2022 at 2:26 PM Weiwei Li wrote: > > - add sha512sum0, sha512sig0, sha512sum1 and sha512sig1 instructions > > Co-authored-by: Zewen Ye > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- >

Re: [RFC PATCH v3 18/36] i386/tdvf: Introduce function to parse TDVF metadata

2022-03-21 Thread Xiaoyao Li
On 3/19/2022 1:19 AM, Isaku Yamahata wrote: On Thu, Mar 17, 2022 at 09:58:55PM +0800, Xiaoyao Li wrote: diff --git a/hw/i386/tdvf.c b/hw/i386/tdvf.c new file mode 100644 index ..02da1d2c12dd --- /dev/null +++ b/hw/i386/tdvf.c @@ -0,0 +1,196 @@ +/* + * SPDX-License-Identifier:

[PULL 0/3] ppc queue

2022-03-21 Thread Cédric Le Goater
The following changes since commit 2058fdbe81e2985c226a026851dd26b146d3395c: Merge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into staging (2022-03-19 11:28:54 +) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-ppc-20220321

[PATCH v3 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-03-21 Thread Xie Yongji
VDUSE [1] is a linux framework that makes it possible to implement software-emulated vDPA devices in userspace. This adds a library as a subproject to help implementing VDUSE backends in QEMU. [1] https://www.kernel.org/doc/html/latest/userspace-api/vduse.html Signed-off-by: Xie Yongji ---

[PATCH v3 1/6] block: Support passing NULL ops to blk_set_dev_ops()

2022-03-21 Thread Xie Yongji
This supports passing NULL ops to blk_set_dev_ops() so that we can remove stale ops in some cases. Signed-off-by: Xie Yongji --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index e0e1aff4b1..35457a6a1d

[PATCH V2 2/4] intel-iommu: drop VTDBus

2022-03-21 Thread Jason Wang
We introduce VTDBus structure as an intermediate step for searching the address space. This works well with SID based matching/lookup. But when we want to support SID plus PASID based address space lookup, this intermediate steps turns out to be a burden. So the patch simply drops the VTDBus

[PATCH V2 0/4] PASID support for Intel IOMMU

2022-03-21 Thread Jason Wang
Hi All: This series tries to introduce PASID support for Intel IOMMU. The work is based on the previous scalabe mode support by implement the ECAP_PASID. A new "x-pasid-mode" is introduced to enable this mode. All internal vIOMMU codes were extended to support PASID instead of the current

[PULL 1/3] ppc64: Avoid pt_regs struct definition

2022-03-21 Thread Cédric Le Goater
From: Khem Raj Remove pt_regs indirection and instead reference gp_regs directly, this makes it portable across musl/glibc Use PT_* constants defined in asm/ptrace.h Move the file to ppc64 subdir and leave ppc empty Fixes ../qemu-6.2.0/linux-user/host/ppc64/../ppc/host-signal.h:16:32: error:

Re: [RFC PATCH v3 06/36] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES

2022-03-21 Thread Xiaoyao Li
On 3/18/2022 10:08 AM, Isaku Yamahata wrote: On Thu, Mar 17, 2022 at 09:58:43PM +0800, Xiaoyao Li wrote: diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index e3b94373b316..bed337e5ba18 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -14,10 +14,77 @@ #include

Re: [RFC PATCH v3 27/36] i386/tdx: Disable SMM for TDX VMs

2022-03-21 Thread Xiaoyao Li
On 3/17/2022 9:59 PM, Xiaoyao Li wrote: TDX doesn't support SMM and VMM cannot emulate SMM for TDX VMs because VMM cannot manipulate TDX VM's memory. Disable SMM for TDX VMs and error out if user requests to enable SMM. Signed-off-by: Xiaoyao Li --- target/i386/kvm/tdx.c | 13 +

Re: [PATCH 1/3] spapr: Ignore nested KVM hypercalls when not running TCG

2022-03-21 Thread David Gibson
On Fri, Mar 18, 2022 at 10:41:19AM -0300, Fabiano Rosas wrote: > David Gibson writes: > > > On Thu, Mar 17, 2022 at 02:20:47PM -0300, Fabiano Rosas wrote: > >> It is possible that nested KVM hypercalls reach QEMU while we're > >> running KVM. The spapr virtual hypervisor implementation of the

Re: [RFC PATCH v3 09/36] KVM: Introduce kvm_arch_pre_create_vcpu()

2022-03-21 Thread Xiaoyao Li
On 3/19/2022 12:56 AM, Isaku Yamahata wrote: On Thu, Mar 17, 2022 at 09:58:46PM +0800, Xiaoyao Li wrote: Introduce kvm_arch_pre_create_vcpu(), to perform arch-dependent work prior to create any vcpu. This is for i386 TDX because it needs call TDX_INIT_VM before creating any vcpu.

[PATCH v3 5/6] vduse-blk: Add vduse-blk resize support

2022-03-21 Thread Xie Yongji
To support block resize, this uses vduse_dev_update_config() to update the capacity field in configuration space and inject config interrupt on the block resize callback. Signed-off-by: Xie Yongji Reviewed-by: Stefan Hajnoczi --- block/export/vduse-blk.c | 20 1 file

[PATCH v3 6/6] libvduse: Add support for reconnecting

2022-03-21 Thread Xie Yongji
To support reconnecting after restart or crash, VDUSE backend might need to resubmit inflight I/Os. This stores the metadata such as the index of inflight I/O's descriptors to a shm file so that VDUSE backend can restore them during reconnecting. Signed-off-by: Xie Yongji ---

Re: [PATCH v4] tests: Do not treat the iotests as separate meson test target anymore

2022-03-21 Thread Thomas Huth
On 21/03/2022 10.06, Hanna Reitz wrote: On 18.03.22 18:36, Thomas Huth wrote: On 18/03/2022 18.04, Hanna Reitz wrote: On 10.03.22 08:50, Thomas Huth wrote: If there is a failing iotest, the output is currently not logged to the console anymore. To get this working again, we need to run the

Re: [PATCH v3 02/11] target/s390x: vxeh2: vector convert short/32b

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Signed-off-by: David Miller > Reviewed-by: Richard Henderson > Message-Id: <20220307020327.3003-2-dmiller...@gmail.com> > Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [RFC PATCH-for-7.0 v4 0/2] cocoa: run qemu_init in the main thread

2022-03-21 Thread Akihiko Odaki
On 2022/03/21 18:14, Paolo Bonzini wrote: On 3/19/22 14:56, Philippe Mathieu-Daudé wrote:    1. Move setgid and setuid calls after [+NSApplication    sharedApplication] to let NSApplication initialize as the original    user. Another possibility is to move the code up to "[QemuApplication

Re: Proposal for a regular upstream performance testing

2022-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2022 at 09:46:12AM +0100, Lukáš Doktor wrote: > Dear qemu developers, > > you might remember the "replied to" email from a bit over year ago to raise a > discussion about a qemu performance regression CI. On KVM forum I presented >

Re: [PATCH v2 2/3] docs: rSTify MailingLists wiki; move it to QEMU Git

2022-03-21 Thread Kashyap Chamarthy
On Tue, Mar 15, 2022 at 04:12:50PM +, Peter Maydell wrote: > On Tue, 15 Mar 2022 at 16:00, Kashyap Chamarthy wrote: > > > > On Tue, Mar 15, 2022 at 02:25:05PM +0100, Thomas Huth wrote: > > > On 14/03/2022 11.49, Kashyap Chamarthy wrote: > > > > [...] > > > > > At least the "users" mailing

Re: Proposal for a regular upstream performance testing

2022-03-21 Thread Lukáš Doktor
Hello Stefan, Dne 21. 03. 22 v 10:42 Stefan Hajnoczi napsal(a): > On Mon, Mar 21, 2022 at 09:46:12AM +0100, Lukáš Doktor wrote: >> Dear qemu developers, >> >> you might remember the "replied to" email from a bit over year ago to raise >> a discussion about a qemu performance regression CI. On

Re: [PATCH v3 03/11] target/s390x: vxeh2: vector string search

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Signed-off-by: David Miller > Message-Id: <20220307020327.3003-3-dmiller...@gmail.com> > [rth: Rewrite helpers; fix validation of m6.] > Signed-off-by: Richard Henderson > --- > > The substring search was incorrect, in that

Re: comparison of coroutine backends

2022-03-21 Thread Stefan Hajnoczi
On Fri, Mar 18, 2022 at 09:48:37AM +0100, Paolo Bonzini wrote: > Hi all, > > based on the previous discussions here is a comparison of the various > possibilities for implementing coroutine backends in QEMU and the > respective advantages and disadvantages. > > I'm adding a third possibility for

Re: [PATCH 0/3] qga: Implement guest-network-get-interfaces for Solaris

2022-03-21 Thread Michal Prívozník
On 3/20/22 22:38, Andrew Deason wrote: > This implements the guest agent guest-network-get-interfaces command on > Solaris. Solaris provides a getifaddrs() that's very similar to the Linux one, > so the implementation is mostly the same. > > Andrew Deason (3): > qga/commands-posix: Use

Re: [PATCH 3/3] qga/commands-posix: Fix listing ifaces for Solaris

2022-03-21 Thread Michal Prívozník
On 3/20/22 22:38, Andrew Deason wrote: > The code for guest-network-get-interfaces needs a couple of small > adjustments for Solaris: > > - The results from SIOCGIFHWADDR are documented as being in ifr_addr, > not ifr_hwaddr (ifr_hwaddr doesn't exist on Solaris). > > - The implementation of

Re: [RFC PATCH-for-7.0 v4 0/2] cocoa: run qemu_init in the main thread

2022-03-21 Thread Paolo Bonzini
On 3/19/22 14:56, Philippe Mathieu-Daudé wrote:    1. Move setgid and setuid calls after [+NSApplication    sharedApplication] to let NSApplication initialize as the original    user. Another possibility is to move the code up to "[QemuApplication sharedApplication]" from main() to

Re: [PATCH v3 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

2022-03-21 Thread David Hildenbrand
On 20.03.22 02:14, David Miller wrote: > Is this waiting on me for anything? > I wanted to ensure this is wrapped up before starting a new project. This fell through the cracks because I wasn't cc-ed by Richard on this series. I'll try reviewing this week. -- Thanks, David / dhildenb

Re: [PATCH v3 01/11] tcg: Implement tcg_gen_{h,w}swap_{i32,i64}

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > Swap half-words (16-bit) and words (32-bit) within a larger value. > Mirrors functions of the same names within include/qemu/bitops.h. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg-op.h | 6 ++ > tcg/tcg-op.c | 30

Re: Account creation on QEMU Wiki

2022-03-21 Thread Daniel P . Berrangé
On Sun, Mar 20, 2022 at 06:04:17PM -0400, Ben Westover wrote: > Hello, > > I'd like to create an account on the QEMU Wiki, but as it says on the main > page, account creation is currently disabled to reduce spam. > It says to ask someone with an existing account to create one for me, but I >

Memory leak in via_isa_realize()

2022-03-21 Thread Thomas Huth
Hi! FYI, I'm seeing a memory leak in via_isa_realize() when building QEMU with sanitizers enabled or when running QEMU through valgrind: $ valgrind --leak-check=full --show-leak-kinds=definite ./qemu-system-mips64el --nographic -M fuloong2e ==210405== Memcheck, a memory error detector

Re: [PATCH v1 0/1] hw/gpio Add ASPEED GPIO model for AST1030

2022-03-21 Thread Cédric Le Goater
Hello Jamin, On 3/21/22 10:14, Jamin Lin wrote: 1. Add GPIO read/write trace event. 2. Support GPIO index mode for write operation. It did not support GPIO index mode for read operation. 3. AST1030 integrates one set of Parallel GPIO Controller Is the AST1030 a new SoC you are developing ? We

Re: [PATCH RESEND 1/2] hw/vfio/pci-quirks: Resolve redundant property getters

2022-03-21 Thread Bernhard Beschow
Am 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow : >The QOM API already provides getters for uint64 and uint32 values, so reuse >them. > >Signed-off-by: Bernhard Beschow >Reviewed-by: Philippe Mathieu-Daudé >--- > hw/vfio/pci-quirks.c | 34 +- > 1 file

Re: [PATCH v2 2/3] docs: rSTify MailingLists wiki; move it to QEMU Git

2022-03-21 Thread Peter Maydell
On Mon, 21 Mar 2022 at 09:55, Kashyap Chamarthy wrote: > > On Tue, Mar 15, 2022 at 04:12:50PM +, Peter Maydell wrote: > > On Tue, 15 Mar 2022 at 16:00, Kashyap Chamarthy wrote: > > > > > > On Tue, Mar 15, 2022 at 02:25:05PM +0100, Thomas Huth wrote: > > > > On 14/03/2022 11.49, Kashyap

Re: Memory leak in via_isa_realize()

2022-03-21 Thread Peter Maydell
On Mon, 21 Mar 2022 at 10:31, Thomas Huth wrote: > FYI, I'm seeing a memory leak in via_isa_realize() when building > QEMU with sanitizers enabled or when running QEMU through valgrind: > Same problem happens with qemu-system-ppc64 and the pegasos2 machine. > > No clue how to properly fix this...

Re: [PATCH v3 04/11] target/s390x: vxeh2: Update for changes to vector shifts

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Prior to vector enhancements 2, the shift count was supposed to be equal > for each byte lest the result be unpredictable, which allowed us to assume > that the shift count was the same, and optimize accordingly. > > With

Re: [PATCH v2 2/3] docs: rSTify MailingLists wiki; move it to QEMU Git

2022-03-21 Thread Kashyap Chamarthy
On Mon, Mar 21, 2022 at 11:01:28AM +, Peter Maydell wrote: > On Mon, 21 Mar 2022 at 09:55, Kashyap Chamarthy wrote: [...] > > > Yes, I think that about/ should have a document something like > > > "Contacting the project" or "Support", which could tell users about not > > > just > > > the

Re: [PATCH v3 05/11] target/s390x: vxeh2: vector shift double by bit

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Signed-off-by: David Miller > Message-Id: <20220307020327.3003-4-dmiller...@gmail.com> > [rth: Split out of larger patch.] > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate_vx.c.inc | 47

Re: [PATCH v3 11/11] target/s390x: Fix writeback to v1 in helper_vstl

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > Copy-paste error from vector load length -- do not write > zeros back to v1 after storing from v1. Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH") Reviewed-by: David Hildenbrand > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v3 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to cpu max

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller QEMU is in soft freeze now. We'll have to perform that change for the new 7.1 machine only, so we have to fixup the qemu model for the 7.0 machine. Subject should be "... to qemu CPU model" > > Signed-off-by: David Miller >

Re: [PATCH qemu 00/13] Add tail agnostic behavior for rvv instructions

2022-03-21 Thread Weiwei Li
在 2022/3/21 下午3:50, eop Chen 写道: Hi WeiWei, Thanks for reviewing this PR. === Regarding to possible behaviors on agnostic elements to mask instructions, I want to ask for you and other's opinion on this proposed PR

Re: [PATCH v3 06/11] target/s390x: vxeh2: vector {load, store} elements reversed

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Signed-off-by: David Miller > Message-Id: <20220307020327.3003-5-dmiller...@gmail.com> > [rth: Use new hswap and wswap tcg expanders.] > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate_vx.c.inc | 84

Re: [PATCH v3 07/11] target/s390x: vxeh2: vector {load, store} byte reversed elements

2022-03-21 Thread David Hildenbrand
On 08.03.22 02:53, Richard Henderson wrote: > From: David Miller > > Signed-off-by: David Miller > Message-Id: <20220307020327.3003-6-dmiller...@gmail.com> > [rth: Split out elements (plural) from element (scalar) > Use tcg little-endian memory ops, plus hswap and wswap.] > Signed-off-by:

Re: [PATCH v2 2/3] qapi: nbd-export: allow select bitmaps by node/name pair

2022-03-21 Thread Vladimir Sementsov-Ogievskiy
17.03.2022 00:28, Eric Blake wrote: On Tue, Mar 15, 2022 at 12:32:25AM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Hi all! Current logic of relying on search through backing chain is not safe neither convenient. Sometimes it leads to necessity of extra

Re: [PATCH v5 1/8] migration: Export ram_transferred_ram()

2022-03-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.h | 2 ++ > migration/ram.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/migration/ram.h b/migration/ram.h > index

<    1   2   3