* Daniel P. Berrangé (berra...@redhat.com) wrote:
> The only user of the hooks is RDMA which provides a QIOChannel backed
> impl of QEMUFile. It can thus use the qemu_file_get_ioc() method.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Dr. David Alan Gilbert
> ---
>
On Tue, 7 Jun 2022 at 21:33, Richard Henderson
wrote:
>
> Mirror the properties for SVE. The main difference is
> that any arbitrary set of powers of 2 may be supported,
> and not the stricter constraints that apply to SVE.
>
> Include a property to control FEAT_SME_FA64, as failing
> to
It does not mutate the buffer.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
---
include/block/block_int-io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/block/block_int-io.h b/include/block/block_int-io.h
index bb454200e5..d4d3bed783 100644
---
On Tue, 7 Jun 2022 at 21:33, Richard Henderson
wrote:
>
> These functions are not used outside cpu64.c,
> so make them static.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.h | 3 ---
> target/arm/cpu64.c | 4 ++--
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
On Wed, Jun 08, 2022 at 10:55:30PM +0200, Klaus Jensen wrote:
>
> Keith, is this a bug in the kernel? If the code here would expect the
> doorbell buffer to be updated for the admin queue as well, would we
> break?
The admin queue has to be created before db buffer can be set up, so we can't
They currently return the value of their 'bytes' parameter on success.
Make them return 0 instead, for consistency with other I/O functions and
in preparation to implement them using generated_co_wrapper. This also
makes it clear that short reads/writes are not possible.
The few callers that
Just as done in the block API, mark functions in virtio-blk
that are called also from iothread(s).
We know such functions are IO because many are blk_* callbacks,
running always in the device iothread, and remaining are propagated
from the leaf IO functions (if a function calls a IO_CODE
Use bdrv_pwrite_sync() instead of calling bdrv_pwrite() and bdrv_flush()
separately.
Signed-off-by: Alberto Faria
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
---
block/qcow2.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
On Sun, 5 Jun 2022 at 17:16, Richard Henderson
wrote:
>
> Since DDI0487F.a, the RW bit is RAO/WI. When specifically
> targeting such a cpu, e.g. cortex-a76, it is legitimate to
> ignore the bit within the secure monitor.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1062
>
All the callbacks below are always running in the main loop.
The callbacks are the following:
- start/stop_ioeventfd: these are the callbacks where
blk_set_aio_context(iothread) is done, so they are called in the main
loop.
- save and load: called during migration, when VM is stopped from
On 6/8/22 14:17, Warner Losh wrote:
Warner Losh (6):
bsd-user/freebsd/os-syscall.c: lock_iovec
bsd-user/freebsd/os-syscall.c: unlock_iovec
bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate
bsd-user/bsd-file.h: Add implementations for read, pread, readv and
preadv
virtio_queue_aio_attach_host_notifier() and
virtio_queue_aio_attach_host_notifier_nopoll() run always in the
main loop, so there is no need to protect them with AioContext
lock.
On the other side, virtio_queue_aio_detach_host_notifier() runs
in a bh in the iothread context, but it is always
On Sun, 5 Jun 2022 at 17:14, Richard Henderson
wrote:
>
> These bits do not depend on whether or not el1 supports aa32.
>
> Signed-off-by: Richard Henderson
Isn't this effectively reverting commit 10d0ef3e6cfe2, which
got applied as a bug fix last year ?
In particular, the reason we need to
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf,
On 6/8/22 14:17, Warner Losh wrote:
+static inline abi_long do_bsd_exit(void *cpu_env, abi_long arg1)
+{
+#ifdef TARGET_GPROF
+_mcleanup();
+#endif
+gdb_exit(arg1);
+qemu_plugin_user_exit();
+/* XXX: should free thread stack and CPU env here */
+_exit(arg1);
+
I think you
On Thu, 9 Jun 2022, Gerd Hoffmann wrote:
On Wed, May 18, 2022 at 12:37:18PM +0200, Paolo Bonzini wrote:
On 5/17/22 21:47, BALATON Zoltan wrote:
On Mon, 9 May 2022, BALATON Zoltan wrote:
On Mon, 2 May 2022, BALATON Zoltan wrote:
On Sat, 23 Apr 2022, BALATON Zoltan wrote:
During trying to
On Wed, Jun 8, 2022 at 1:50 PM Stefan Hajnoczi wrote:
> Yes, that's fine. My main concern is that callers have been audited when
> errnos are changed. If you switch bdrv_{pread,pwrite}() to -EIO and have
> audited callers, then I'm happy.
>
> Consistent -EINVAL would be nice in the future, but I
On Mon, 6 Jun 2022 at 15:34, Lucas Mateus Castro(alqotel)
wrote:
>
> The QEMU documentation mentions that lines should be up to 80
> characters and that the script checkpatch will warn at 100 characters,
> but the script warns at 80 characters and throw and error at 90, so
> this commit changes
On 6/7/22 18:58, Hanna Reitz wrote:
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
Now the indirection is not actually used, we can safely reduce it to
simple pointer.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/snapshot.c | 39 +--
1
From: Bernhard Beschow
Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci
generic class init function' already resolved redundant code which in
turn rendered piix3-ide-xen redundant.
Signed-off-by: Bernhard Beschow
Reviewed-by: Anthony PERARD
Message-Id:
On 6/9/22 00:24, Alex Bennée wrote:
--- a/configs/targets/riscv64-linux-user.mak
+++ b/configs/targets/riscv64-linux-user.mak
@@ -2,4 +2,5 @@ TARGET_ARCH=riscv64
TARGET_BASE_ARCH=riscv
TARGET_ABI_DIR=riscv
TARGET_XML_FILES= gdb-xml/riscv-64bit-cpu.xml gdb-xml/riscv-32bit-fpu.xml
From: Bernhard Beschow
The comment is based on commit message
ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk
unplug option'. Since it seems to describe design decisions and
limitations that still apply it seems worth having.
Signed-off-by: Bernhard Beschow
Thanks Laszlo, I really appreciate the detailed explanation and
feedback!
On Thu, 2022-06-09 at 09:45 +0200, Laszlo Ersek wrote:
> (a) your original (non-functional) use case:
>
> qemu-system-x86_64 \
> -no-user-config \
> -nodefaults \
> -machine q35,accel=kvm \
> -m 1G \
>
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> With this change, all QEMUFile usage is backed by QIOChannel at
> last.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/savevm.c | 42 --
> 1 file changed,
On 6/8/22 14:49, Hanna Reitz wrote:
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
To be used in further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 48
1 file changed, 48 insertions(+)
Looking at
From: Paolo Bonzini
Remove usage of aio_context_acquire by always submitting asynchronous
AIO to the current thread's LinuxAioState.
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block/file-posix.c | 3 ++-
block/linux-aio.c | 13 ++---
s->rq is pointing to the the VirtIOBlockReq list, and this list is
read/written in:
virtio_blk_reset = main loop, but caller calls ->stop_ioeventfd() and
drains, so no iothread runs in parallel
virtio_blk_save_device = main loop, but VM is stopped (migration), so
iothread has no work on request
On 6/7/22 18:55, Hanna Reitz wrote:
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
bs->file and bs->backing are a kind of duplication of part of
bs->children. But very useful diplication, so let's not drop them at
all:)
We should manage bs->file and bs->backing in same place, where we
It is read from IO_CODE and written with BQL held,
so setting it as atomic should be enough.
Also remove the aiocontext lock that was sporadically
taken around the set.
Signed-off-by: Emanuele Giuseppe Esposito
---
block/block-backend.c | 6 +++---
hw/block/virtio-blk.c | 4
2 files
On 6/9/22 01:23, Pavel Dovgalyuk wrote:
This patch introduces Octeon-specific decoder and implements
check-bit-and-jump instructions.
Signed-off-by: Pavel Dovgalyuk
--
v2 changes:
- Changed insn field description and simplified the jumps
(suggested by Richard Henderson)
---
On 09/06/2022 16.15, Claudio Fontana wrote:
On 6/9/22 13:27, Claudio Fontana wrote:
On 6/9/22 10:57, Daniel P. Berrangé wrote:
On Thu, Jun 09, 2022 at 10:47:24AM +0200, Thomas Huth wrote:
On 08/06/2022 17.51, Paolo Bonzini wrote:
On 6/3/22 19:35, Thomas Huth wrote:
On 03/06/2022 19.26,
On 6/9/22 13:27, Claudio Fontana wrote:
> On 6/9/22 10:57, Daniel P. Berrangé wrote:
>> On Thu, Jun 09, 2022 at 10:47:24AM +0200, Thomas Huth wrote:
>>> On 08/06/2022 17.51, Paolo Bonzini wrote:
On 6/3/22 19:35, Thomas Huth wrote:
> On 03/06/2022 19.26, Claudio Fontana wrote:
>> On
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Jun 09, 2022 at 01:56:00PM +0100, Peter Maydell wrote:
> > On Tue, 24 May 2022 at 12:46, Daniel P. Berrangé
> > wrote:
> > >
> > > The qemu_update_position method name gives the misleading impression
> > > that it is changing the
From: Ni Xun
When check queue state in the vhost_dev_set_log routine, it miss the error
routine check, this patch also check queue state in error case.
Fixes: 1e5a050f5798 ("check queue state in the vhost_dev_set_log
routine")
Signed-off-by: Ni Xun
Reviewed-by: Zhigang Lu
---
-dm.git
tags/pull-xen-20220609
for you to fetch changes up to 6a8a8b62bdc8e3d7c5fc0f82ef4583707183b12f:
include/hw/ide: Unexport pci_piix3_xen_ide_unplug() (2022-06-09 14:47:42
+0100)
Xen patches
- PIIX3-IDE Xen cleanup
i) Binding of the socket to source ip address and port on the non-default
interface has been implemented for multi-FD connection, which was not
necessary earlier because the binding was on the default interface itself.
ii) Created an end to end connection between all multi-FD source and
On Tue, 24 May 2022 at 12:46, Daniel P. Berrangé wrote:
>
> The qemu_update_position method name gives the misleading impression
> that it is changing the current file offset. Most of the files are
> just streams, however, so there's no concept of a file offset in the
> general case.
>
> What
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
This flag is set/checked prior to calling a device's MemoryRegion
handlers, and set when device code initiates DMA. The purpose of this
flag is to prevent two types of DMA-based reentrancy issues:
1.) mmio -> dma -> mmio
From: Bernhard Beschow
This function was declared in a generic and public header, implemented
in a device-specific source file but only used in xen_platform. Given its
'aux' parameter, this function is more xen-specific than piix-specific.
Also, the hardcoded magic constants seem to be generic
i) Dynamically decide appropriate source and destination ip pairs for the
corresponding multi-FD channel to be connected.
ii) Removed the support for setting the number of multi-fd channels from qmp
commands. As now all multiFD parameters will be passed via qmp: migrate
command or
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Define a new qdev input gpio for handling incoming PS2 IRQs, and then wire up
> the
> PS2 keyboard and mouse devices to use it. At the same time set update_irq()
> and
> update_arg to NULL in ps2_kbd_init() and ps2_mouse_init() to ensure
On 6/8/22 20:16, Anup Patel wrote:
On Wed, Jun 8, 2022 at 10:23 PM Richard Henderson
wrote:
On 6/8/22 09:14, Anup Patel wrote:
+struct isa_ext_data isa_edata_arr[] = {
static const?
Using const is fine but we can't use "static const" because
the "struct isa_ext_data" has a pointer to
On 6/7/22 13:53, Hanna Reitz wrote:
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
test_parallel_perm_update() does two things that we are going to
restrict in the near future:
1. It updates bs->file field by hand. bs->file will be managed
automatically by generic code (together
On 6/8/22 16:47, Alistair Francis wrote:
From: Alistair Francis
When running a 32-bit guest, with a e64 vmv.v.x and vl_eq_vlmax set to
true the `tcg_debug_assert(vece <= MO_32)` will be triggered inside
tcg_gen_gvec_dup_i32().
This patch checks that condition and instead uses
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Jun 09, 2022 at 12:07:31PM +0200, Claudio Fontana wrote:
> > Hello all,
> >
> > it would be really good to be able to rely on this command or something
> > similar,
> > to be able to know the approximate size of a migration before
On 6/8/22 12:23, Alex Williamson wrote:
The following changes since commit 9b1f58854959c5a9bdb347e3e04c252ab7fc9ef5:
Merge tag 'pull-la-20220606' of https://gitlab.com/rth7680/qemu into staging
(2022-06-06 16:16:01 -0700)
are available in the Git repository at:
Remove usage of aio_context_acquire by always submitting work items
to the current thread's ThreadPool.
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block/file-posix.c| 19 +--
block/file-win32.c| 2 +-
block/qcow2-threads.c | 2 +-
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Define a new qdev input gpio for handling incoming PS2 IRQs, and then wire up
> the
> PS2 keyboard and mouse devices to use it. At the same time set update_irq()
> and
> update_arg to NULL in ps2_kbd_init() and ps2_mouse_init() to ensure
On Sun, 22 May 2022 at 19:23, Mark Cave-Ayland
wrote:
>
> Now that all the PS2 devices have been converted to use GPIOs the update_irq()
> callback function and the update_arg parameter can be removed.
>
> This allows these arguments to be completely removed from ps2_kbd_init() and
>
Just remove some AioContext lock in LinuxAioState and ThreadPool.
Not related to anything specific, so I decided to send it as
a separate patch.
These patches are taken from Paolo's old draft series.
Emanuele Giuseppe Esposito (1):
thread-pool: use ThreadPool from the running thread
Paolo
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This means that it is no longer necessary to call qemu_register_reset()
> manually
> within i8042_realizefn().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/pckbd.c | 10 +-
> 1 file changed, 9 insertions(+), 1
On Sun, 5 Jun 2022 at 01:16, wrote:
>
> From: Lucas Ramage
>
> Buglink: https://gitlab.com/qemu-project/qemu/-/issues/527
> Signed-off-by: Lucas Ramage
> ---
> docs/devel/{blkdebug.txt => blkdebug.rst} | 8 +-
> docs/devel/{blkverify.txt => blkverify.rst} | 12 ++---
>
error_report() only works once monitor_init_globals_core() has been
called, which is not the case when parsing the --daemonize option. Use
fprintf(stderr, ...) instead.
Fixes: 2525edd85fec53e23fda98974a15e3b3c8957596 ("qsd: Add --daemonize")
Signed-off-by: Hanna Reitz
---
After writing the PID file, we register an exit notifier to unlink it
when the process terminates. However, if the process has changed its
working directory in the meantime (e.g. in os_setup_post() when
daemonizing), this will not work when the PID file path was relative.
Therefore, pass the
Hi,
> > > > (1) add refresh_rate
> > > > (2) update users one by one
> > > > (3) finally drop update_interval when no user is left.
> > > >
> > > > thanks,
> > > > Gerd
> > > >
> > >
> > > I think 1 and 3 should have to be done once since refresh_rate and
> > > update_interval would
i) Modified the format of qemu monitor command: ‘migrate-incoming’ by adding
a list, each element in the list is to open listeners with a given number
of multiFD channels.
ii) Qemu starts with -incoming flag defer and -multi-fd-incoming defer to
allow the modified 'migrate-incoming'
On Thu, Jun 09 2022, Paolo Bonzini wrote:
> Make virtio_mmio_soft_reset reset the virtio device, which is performed by
> both the "soft" and the "hard" reset; and then call virtio_mmio_soft_reset
> from virtio_mmio_reset to emphasize that the latter is a superset of the
> former.
>
>
On 2022/06/09 21:02, Gerd Hoffmann wrote:
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote:
On 2022/06/09 19:28, Gerd Hoffmann wrote:
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -139,6 +139,7 @@ typedef struct QemuUIInfo {
int yoff;
uint32_t
On Thu, Jun 09, 2022 at 01:56:00PM +0100, Peter Maydell wrote:
> On Tue, 24 May 2022 at 12:46, Daniel P. Berrangé wrote:
> >
> > The qemu_update_position method name gives the misleading impression
> > that it is changing the current file offset. Most of the files are
> > just streams, however,
Hi,
I'm interested in investigating the possibility of running applications in a
virtualized/isolated manner to minimize access to the OS
(Windows/Linux/Android). Preferably there should be no or minimal software
changes to the guest OS or application binary.
Generally applications in an OS
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote:
> On 2022/06/09 19:28, Gerd Hoffmann wrote:
> > > --- a/include/ui/console.h
> > > +++ b/include/ui/console.h
> > > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo {
> > > int yoff;
> > > uint32_t width;
> > >
On Thu, Jun 09 2022, Paolo Bonzini wrote:
> All calls to virtio_bus_reset are preceded by virtio_bus_stop_ioeventfd,
> move the call in virtio_bus_reset: that makes sense and clarifies
> that the vdc->reset function is called with ioeventfd already stopped.
>
> Signed-off-by: Paolo Bonzini
>
As of now, the multi-FD feature supports connection over the default network
only. This Patchset series is a Qemu side implementation of providing multiple
interfaces support for multi-FD. This enables us to fully utilize dedicated or
multiple NICs in case bonding of NICs is not possible.
On 2022/06/09 19:28, Gerd Hoffmann wrote:
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -139,6 +139,7 @@ typedef struct QemuUIInfo {
int yoff;
uint32_t width;
uint32_t height;
+uint32_t refresh_rate;
} QemuUIInfo;
/* cursor data format is 32bit
On Thu, 9 Jun 2022 11:30:14 +0200
Igor Mammedov wrote:
> On Wed, 8 Jun 2022 09:53:05 -0400
> Igor Mammedov wrote:
>
> > Changelog:
> > since v1:
> > * add tis 2.0 clarification to commit message (Ani Sinha)
> > * rebase on top of pci tree
> > * pick up acks
>
> tests fail
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consists of multi-FD connection parameters: source
and destination uris and of the number of multi-fd channels between each
pair.
ii) Information of all multi-FD connection parameters’
Currently, the exit notifier for unlinking the PID file is registered
unconditionally. Limit it to only when we actually do create a PID
file.
Signed-off-by: Hanna Reitz
---
softmmu/vl.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/softmmu/vl.c
On Thu, Jun 09 2022, Paolo Bonzini wrote:
> Call virtio_bus_reset instead of virtio_reset, so that the function
> need not receive the VirtIODevice.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/s390x/virtio-ccw.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
Reviewed-by:
On 6/9/22 05:13, Iris Chen wrote:
From: Iris Chen
Signed-off-by: Iris Chen
---
Addressed all comments from V1. The biggest change: removed
object_class_property_add.
Reviewed-by: Cédric Le Goater
Thanks,
C.
hw/block/m25p80.c | 37 +++
Hi,
QEMU (the system emulator) and the storage daemon (QSD) write their PID
to the given file when you specify --pidfile. They keep the path around
and register exit handlers (QEMU uses an exit notifier, QSD an atexit()
function) to unlink this file when the process terminates. These
handlers
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Move ps2_kbd_init() and ps2_mouse_init() from lasips2_initfn() to
> lasips2_realize.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/lasips2.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git
After writing the PID file, we register an atexit() handler to unlink it
when the process terminates. However, if the process has changed its
working directory in the meantime (e.g. in os_setup_post() when
daemonizing), this will not work when the PID file path was relative.
Therefore, pass the
On 6/9/22 10:57, Daniel P. Berrangé wrote:
> On Thu, Jun 09, 2022 at 10:47:24AM +0200, Thomas Huth wrote:
>> On 08/06/2022 17.51, Paolo Bonzini wrote:
>>> On 6/3/22 19:35, Thomas Huth wrote:
On 03/06/2022 19.26, Claudio Fontana wrote:
> On 6/3/22 18:42, Thomas Huth wrote:
>> The
If we go directly to GLOBAL_STATE_CODE, IO_CODE or IO_OR_GS_CODE
definition, we just find that they "mark and check that the function
is part of the {category} API".
However, ther is no definition on what {category} API is, they are
in include/block/block-*.h
Therefore, add a comment that refers
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Now that the register memory regions are exposed as SysBus memory regions,
> move
> the mapping of the LASIPS2 registers from lasips2_initfn() to the HPPA machine
> (which is its only user).
>
> Signed-off-by: Mark Cave-Ayland
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Add a qdev gpio input in lasips2_init() by taking the existing
> lasips2_port_set_irq()
> function, updating it accordingly and then renaming to lasips2_set_irq(). Use
> these
> new qdev gpio inputs to wire up the PS2 keyboard and mouse
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Move the initialisation of the keyboard and mouse memory regions to
> lasips2_init()
> and expose them as SysBus memory regions.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/lasips2.c | 18 ++
> 1 file changed,
Expected AML change:
ISA devices under separate _SB.PCI0.ISA scope are moved
directly under Device(ISA) node.
Example from PC machine, and q35 have similar changes:
{
Name (_ADR, 0x0001) // _ADR: Address
OperationRegion (P40C, PCI_Config, 0x60, 0x04)
-
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Add a new pl050_init() function which initialises a qdev input gpio for
> handling
> incoming PS2 IRQs, and then wire up the PS2 device to use it. At the same time
> set update_irq() and update_arg to NULL in ps2_kbd_init() and
On Thu, Jun 09 2022, Paolo Bonzini wrote:
> If the queue PFN is set to zero on a virtio-mmio device, the device is reset.
> In that case however the virtio_bus_stop_ioeventfd function was not
> called; add it so that the behavior is similar to when status is set to 0.
>
> Signed-off-by: Paolo
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> When QOMifying a device it is typical to use _init() as the suffix for an
> instance_init function, however this name is already in use by the legacy
> LASIPS2
> wrapper function. Eventually the wrapper function will be removed, but for
Signed-off-by: Igor Mammedov
---
v3:
- count in DSDT.cxl that just was merged upstream
---
tests/qtest/bios-tables-test-allowed-diff.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This is in preparation for handling vmstate_register() within the device.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/lasips2.c | 17 -
> include/hw/input/lasips2.h | 1 +
> 2 files changed, 17
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This consolidates the logic of raising the PS2 IRQ into one single function.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Currently lasip2_init() creates a new LASIPS2State directly which is used by
> the HPPA
> machine. Introduce a new LASIPS2 QOM type that will soon be used to allow the
> HPPA
> machine to be wired up using standard qdev GPIOs.
>
>
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This enables the IRQ to be wired up using qdev_connect_gpio_out() in
> lasips2_initfn().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/lasips2.c | 8
> include/hw/input/lasips2.h | 2 ++
> 2 files changed, 6
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This allows both IRQs to be declared as a single qdev gpio array.
>
> Signed-off-by: Mark Cave-Ayland
> ---
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This can be improved once the ps2_kbd_init() and ps2_mouse_init() functions
> have
> been removed, but for now move the existing logic from lasi_initfn() to
> lasi_init(). At the same time explicitly set keyboard port id to 0, even if it
On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland
wrote:
>
> This allows the I8042_MMIO reset function to be registered directly within the
> DeviceClass rather than using qemu_register_reset() directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/pckbd.c | 13 ++---
> 1 file
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This function is no longer used outside of ps2.c and so can be declared
> static.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> Define the gpio for the PS2 output IRQ in ps2_init() and add logic to
> optionally
> use it in ps2_raise_irq() and ps2_lower_irq() if the gpio is connected. If the
> gpio is not connected then call the legacy update_irq() function as
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This allows the QOM types in lasips2.c to be used elsewhere by simply
> including
> lasips2.h.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland
wrote:
>
> Move ps2_kbd_init() and ps2_mouse_init() from i8042_mm_init() to
> i8042_mmio_realize() to further reduce the initialisation logic done in
> i8042_mm_init().
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Peter Maydell
thanks
-- PMM
Daniel P. Berrangé writes:
> The GitLab variable comparisons don't have shell like semantics where
> an unset variable compares equal to empty string. We need to explicitly
> test against 'null' to detect an unset variable.
>
> Signed-off-by: Daniel P. Berrangé
Queued to testing/next,
On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland
wrote:
>
> This enables use to expose the register memory region of the I8042_MMIO device
> using sysbus_init_mmio().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/pckbd.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git
On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland
wrote:
>
> Move the initialisation of the register memory region to the I8042_MMIO device
> realize function.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/input/pckbd.c | 12 +++-
> include/hw/input/i8042.h | 1 +
> 2 files
On Wed, 8 Jun 2022 at 03:43, Richard Henderson
wrote:
>
> Semihosting is not enabled for nios2-linux-user.
True, but maybe it ought to be (in an ideal world)?
Anyway, as far as this patch goes
Reviewed-by: Peter Maydell
If we ever add semihosting support to linux-user nios2 it's
easy enough
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
wrote:
>
> This consolidates the logic of lowering the PS2 IRQ into one single function.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland
wrote:
>
> This allows the KBDState mask value to be set using a qdev property rather
> than directly in i8042_mm_init().
>
> Signed-off-by: Mark Cave-Ayland
> ---
Reviewed-by: Peter Maydell
thanks
-- PMM
On Thu, Jun 09, 2022 at 10:38:53AM +0100, Daniel P. Berrangé wrote:
> On Tue, May 31, 2022 at 01:23:27PM -0700, Dongwon Kim wrote:
> > New integer array parameter, 'monitor' is for specifying the target
> > displays where individual QEMU windows are placed upon launching.
> >
> > The array
201 - 300 of 420 matches
Mail list logo
