Re: [RFC PATCH v5 2/4] target/riscv: smstateen check for h/senvcfg

2022-06-16 Thread Alistair Francis
On Thu, Jun 16, 2022 at 4:54 PM Alistair Francis wrote: > > On Sat, Jun 4, 2022 at 2:16 AM Mayuresh Chitale > wrote: > > > > Accesses to henvcfg, henvcfgh and senvcfg are allowed > > only if corresponding bit in mstateen0/hstateen0 is > > enabled. Otherwise an illegal instruction trap is > >

Re: [RFC PATCH v5 2/4] target/riscv: smstateen check for h/senvcfg

2022-06-16 Thread Alistair Francis
On Sat, Jun 4, 2022 at 2:16 AM Mayuresh Chitale wrote: > > Accesses to henvcfg, henvcfgh and senvcfg are allowed > only if corresponding bit in mstateen0/hstateen0 is > enabled. Otherwise an illegal instruction trap is > generated. > > Signed-off-by: Mayuresh Chitale > --- > target/riscv/csr.c

Re: [RFC PATCH v5 2/4] target/riscv: smstateen check for h/senvcfg

2022-06-16 Thread Alistair Francis
On Sat, Jun 4, 2022 at 2:16 AM Mayuresh Chitale wrote: > > Accesses to henvcfg, henvcfgh and senvcfg are allowed > only if corresponding bit in mstateen0/hstateen0 is > enabled. Otherwise an illegal instruction trap is > generated. > > Signed-off-by: Mayuresh Chitale Reviewed-by: Alistair

Re: New "IndustryStandard" fw_cfg?

2022-06-16 Thread Gerd Hoffmann
On Thu, Jun 16, 2022 at 01:49:11PM +0800, Xiaoyao Li wrote: > On 6/16/2022 1:37 PM, Gerd Hoffmann wrote: > >Hi, > > > > > Per my understanding, Unaccepted Memory in UEFI is introduced for > > > confidential VMs, i.e., for Intel TDX and AMD SEV-SNP. The only reason > > > UEFI/OVMF reports

Re: [RFC PATCH v5 4/4] target/riscv: smstateen check for AIA/IMSIC

2022-06-16 Thread Alistair Francis
On Sat, Jun 4, 2022 at 2:15 AM Mayuresh Chitale wrote: > > If smstateen is implemented then accesses to AIA > registers CSRS, IMSIC CSRs and other IMSIC registers > is controlled by setting of corresponding bits in > mstateen/hstateen registers. Otherwise an illegal > instruction trap or virtual

Re: New "IndustryStandard" fw_cfg?

2022-06-16 Thread Xiaoyao Li
On 6/15/2022 8:46 AM, Xu, Min M wrote: I would like to add more engineers (Confidential Computing Reviewers in EDK2 community and Intel's QEMU engineers) in this mail thread. -Original Message- From: Dionna Amalie Glaze Sent: Wednesday, June 15, 2022 2:09 AM To: qemu-devel@nongnu.org

Re: [RFC PATCH v5 3/4] target/riscv: smstateen check for fcsr

2022-06-16 Thread Alistair Francis
On Sat, Jun 4, 2022 at 2:08 AM Mayuresh Chitale wrote: > > If smstateen is implemented and sstateen0.fcsr is clear > then the floating point operations must return illegal > instruction exception. > > Signed-off-by: Mayuresh Chitale > --- > target/riscv/csr.c | 24 > 1

Re: [PATCH 1/8] migration: Implemented new parameter stream_content

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 01:19:57PM +0300, nikita.laps...@openvz.org wrote: > From: Nikita Lapshin > > This new optional parameter contains inormation about migration > stream parts to be sent (such as RAM, block, bitmap). This looks > better than using capabilities to solve problem of dividing >

[PULL 6/7] tests/9pfs: guard recent 'Twalk' behaviour fix

2022-06-16 Thread Christian Schoenebeck
Previous 9p patch fixed 'Twalk' request handling, which was previously not behaving as specified by the 9p2000 protocol spec. This patch adds a new test case which guards the new 'Twalk' behaviour in question. More specifically: it sends a 'Twalk' request where the 1st path component is valid,

[PULL 1/7] tests/9pfs: walk to non-existent dir

2022-06-16 Thread Christian Schoenebeck
Expect ENOENT Rlerror response when trying to walk to a non-existent directory. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Based-on: Message-Id: <1f5aa50ace3ba3861ea31e367518282065a6.1647339025.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 30

Re: [PATCH v2 1/2] hw/nvme: Implement shadow doorbell buffer support

2022-06-16 Thread Jinhao Fan
> On Jun 16, 2022, at 6:40 PM, Klaus Jensen wrote: > > This wont work for drivers that *do* rely on updating the buffer for > admin queues, so we should read it regardless of the value of the queue > id (since we are now updating it through the "Keith Hack^TM"). Sure. Sorry I forgot to update

[PATCH v17 13/13] target/loongarch: Update README

2022-06-16 Thread Song Gao
Add linux-user emulation introduction Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/README | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/target/loongarch/README

[PATCH v17 10/13] target/loongarch: remove unused include hw/loader.h

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 0013582a3a..bf163a8dce 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -18,7 +18,6 @@

[PATCH 4/9] error-report: simplify print_loc()

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Pass the program name as "prefix" argument to print_loc() if printing with "details". This allows to get rid of monitor_cur() call in print_loc(). Signed-off-by: Marc-André Lureau --- util/error-report.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v17 07/13] target/loongarch: remove badaddr from CPULoongArch

2022-06-16 Thread Song Gao
We can use CSR_BADV to replace badaddr. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.h | 2 -- target/loongarch/gdbstub.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h index

Re: [QEMU PATCH v2 6/6] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-06-16 Thread Igor Mammedov
On Mon, 30 May 2022 11:40:47 +0800 Robert Hoo wrote: suggest to put this patch as the 1st in series (well you can rebase it on current master and post that right away for merging since it doesn't really depend on other patches, and post new patches on top (whenever they are ready) will use

[PATCH 2/9] error-report: misc comment fix

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- util/error-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/error-report.c b/util/error-report.c index 5edb2e604061..98f242b75bbf 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -390,7

[PATCH 1/9] monitor: make error_vprintf_unless_qmp() static

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Not needed outside monitor.c. Remove the needless stub. Signed-off-by: Marc-André Lureau --- include/monitor/monitor.h | 1 - monitor/monitor.c | 3 ++- stubs/error-printf.c | 5 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git

[PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-16 Thread Jinhao Fan
This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU NVMe. The Doorbell Buffer Config admin command is implemented for the guest to enable shadow doobell buffer. When this feature is enabled, each SQ/CQ is associated with two buffers, i.e., Shadow Doorbell buffer and EventIdx buffer.

[PATCH 6/9] error-report: add a callback to overwrite error_vprintf

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau error_vprintf() is implemented in monitor.c, which overrides the default implementation from stubs/, while avoiding a direct dependency to the monitor from error-report.c. However, the stub solution isn't working when moving error-report.c and stubs/error-printf.c in a

[PATCH v7 12/18] block_job: rename block_job functions called with job_mutex held

2022-06-16 Thread Emanuele Giuseppe Esposito
Just as for the job API, rename block_job functions that are always called under job lock. No functional change intended. Signed-off-by: Emanuele Giuseppe Esposito --- block.c | 3 ++- block/backup.c | 4 ++-- blockdev.c | 12 +++- blockjob.c

[PATCH v7 14/18] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext

2022-06-16 Thread Emanuele Giuseppe Esposito
We are always using the given bs AioContext, so there is no need to take the job ones (which is identical anyways). This also reduces the point we need to check when protecting job.aio_context field. Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito --- block/commit.c | 4

[PATCH v7 01/18] job.c: make job_mutex and job_lock/unlock() public

2022-06-16 Thread Emanuele Giuseppe Esposito
job mutex will be used to protect the job struct elements and list, replacing AioContext locks. Right now use a shared lock for all jobs, in order to keep things simple. Once the AioContext lock is gone, we can introduce per-job locks. To simplify the switch from aiocontext to job lock,

[PATCH v3 16/17] migration/snapshot: Precopy load implemented

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin Load snapshot from qcow2 file. This part also work only with ram part and send vmstate part as it was saved previously without parsing. Here also migration code was reused but now it is savevm part. Tool replace ram handlers as it did before in tool save part but now it is

[PULL 5/7] 9pfs: fix 'Twalk' to only send error if no component walked

2022-06-16 Thread Christian Schoenebeck
Current implementation of 'Twalk' request handling always sends an 'Rerror' response if any error occured. The 9p2000 protocol spec says though: " If the first element cannot be walked for any reason, Rerror is returned. Otherwise, the walk will return an Rwalk message containing nwqid qids

Re: [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation

2022-06-16 Thread Christian Schoenebeck
On Dienstag, 15. März 2022 11:10:25 CEST Christian Schoenebeck wrote: > Currently the implementation of 'Twalk' does not behave exactly as specified > by the 9p2000 protocol specification. Actual fix is patch 5; see the > description of that patch for details of what this overall fix and series >

Re: [PATCH 0/4] hw/nvme: add support for TP4084

2022-06-16 Thread Klaus Jensen
On Jun 8 03:28, Niklas Cassel via wrote: > Hello there, > > considering that Linux v5.19-rc1 is out which includes support for > NVMe TP4084: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/nvme/host/core.c?id=354201c53e61e493017b15327294b0c8ab522d69 > > I

Re: [PATCH V8 06/39] cpr: reboot mode

2022-06-16 Thread Daniel P . Berrangé
On Wed, Jun 15, 2022 at 07:51:53AM -0700, Steve Sistare wrote: > Provide the cpr-save and cpr-load functions for live update. These save and > restore VM state, with minimal guest pause time, so that qemu may be updated > to a new version in between. > > cpr-save stops the VM and saves vmstate

[PULL 2/7] tests/9pfs: Twalk with nwname=0

2022-06-16 Thread Christian Schoenebeck
Send Twalk request with nwname=0. In this case no QIDs should be returned by 9p server; this is equivalent to walking to dot. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: --- tests/qtest/virtio-9p-test.c | 22 ++ 1 file changed, 22 insertions(+)

Re: [QEMU PATCH v2 1/6] tests/acpi: allow SSDT changes

2022-06-16 Thread Igor Mammedov
On Mon, 30 May 2022 11:40:42 +0800 Robert Hoo wrote: > Signed-off-by: Robert Hoo > Reviewed-by: Jingqi Liu Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h

[PATCH] hw/i386/postcard.c: New ISA POST card device

2022-06-16 Thread Lev Kujawski
Move the ioport80 memory functionality within hw/i386/pc.c into a new ISA POST card device capable of being instantiated at different ports. Emulate actual i440FX hardware by storing the value written to the port, regardless of the presence of a POST card, a behavior relied upon by firmware for

Re: Corrupted display changing screen colour depth in qemu-system-ppc/MacOS

2022-06-16 Thread Gerd Hoffmann
On Thu, Jun 16, 2022 at 09:54:46AM +0100, Mark Cave-Ayland wrote: > Hi all, > > Howard pointed me off-list to a corrupted screen display issue experienced > when changing the screen colour depth in MacOS under qemu-system-ppc. I was > able to reproduce it here, and noticed from the output that

Re: [PATCH] hw/riscv: virt: pass random seed to fdt

2022-06-16 Thread Alistair Francis
On Thu, Jun 16, 2022 at 8:01 PM Jason A. Donenfeld wrote: > > Hi Alistair, > > On Thu, Jun 16, 2022 at 12:32:36PM +1000, Alistair Francis wrote: > > Applied to riscv-to-apply.next with the full stop removed > > Great, thanks. Just wondering: am I looking in the right repo? I don't > see it here:

[PATCH v17 11/13] target/loongarch: Adjust functions and structure to support user-mode

2022-06-16 Thread Song Gao
Some functions and member of the structure are different with softmmu-mode So we need adjust them to support user-mode. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c| 21 ++- target/loongarch/cpu.h| 6

[PATCH v17 00/13] Add LoongArch linux-user emulation support

2022-06-16 Thread Song Gao
Hi All, This series add support linux-user emulation. As the LoongArch kernel had merged into 5.19-rc1, you can see the latest kernel at https://kernel.org Need review patches: 0002-linux-user-Add-LoongArch-signal-support.patch 0007-target-loongarch-remove-badaddr-from-CPULoongArch.patch

[PATCH v17 05/13] linux-user: Add LoongArch cpu_loop support

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- linux-user/loongarch64/cpu_loop.c | 96 + linux-user/loongarch64/target_cpu.h | 34 ++ 2 files changed, 130 insertions(+) create mode 100644

Re: Corrupted display changing screen colour depth in qemu-system-ppc/MacOS

2022-06-16 Thread Mark Cave-Ayland
On 16/06/2022 13:07, Gerd Hoffmann wrote: On Thu, Jun 16, 2022 at 09:54:46AM +0100, Mark Cave-Ayland wrote: Hi all, Howard pointed me off-list to a corrupted screen display issue experienced when changing the screen colour depth in MacOS under qemu-system-ppc. I was able to reproduce it here,

Re: [PATCH] target/riscv/pmp: guard against PMP ranges with a negative size

2022-06-16 Thread Nicolas Pitre
On Thu, 16 Jun 2022, Alistair Francis wrote: > On Thu, Jun 16, 2022 at 7:12 AM Nicolas Pitre wrote: > > > > For a TOR entry to match, the stard address must be lower than the end > > address. Normally this is always the case, but correct code might still > > run into the following scenario: > >

[PATCH v17 08/13] target/loongarch: Fix missing update CSR_BADV

2022-06-16 Thread Song Gao
loongarch_cpu_do_interrupt() should update CSR_BADV for some EXCCODE. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index

[PATCH 0/9] Preliminary patches for subproject split

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is another subset of the large "subproject(qga)"" series I intend to send soon after (https://gitlab.com/marcandre.lureau/qemu/-/commits/qga). Thanks Marc-André Lureau (9): monitor: make error_vprintf_unless_qmp() static error-report: misc comment fix

[PATCH v17 09/13] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception

2022-06-16 Thread Song Gao
Raising EXCCODE_BCE instead of EXCCODE_ADEM for helper_asrtle_d/asrtgt_d. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 2 ++ target/loongarch/op_helper.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target/loongarch/cpu.c

[PATCH 3/9] error-report: introduce "detailed" variable

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Let's use a more explicit variable "detailed" instead of calling monitor_cur() multiple times. Signed-off-by: Marc-André Lureau --- util/error-report.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/error-report.c b/util/error-report.c

[PATCH 8/9] scripts/qapi-gen: add -i option

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Replace hard-coded "qemu/osdep.h" include with a qapi-gen option to specify the headers to include. This will allow to substitute QEMU osdep.h with glib.h for example, for projects with different global headers. For historical reasons, we can keep the default as

[PATCH 9/9] scripts/qapi: add required system includes to visitor

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau The generated visitor code includes abort() & assert(), we shouldn't rely on the global "-i" headers to include the necessary system headers. Signed-off-by: Marc-André Lureau --- scripts/qapi/visit.py | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v7 02/18] job.h: categorize fields in struct Job

2022-06-16 Thread Emanuele Giuseppe Esposito
Categorize the fields in struct Job to understand which ones need to be protected by the job mutex and which don't. Signed-off-by: Emanuele Giuseppe Esposito --- include/qemu/job.h | 61 +++--- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git

[PATCH v7 07/18] jobs: add job lock in find_* functions

2022-06-16 Thread Emanuele Giuseppe Esposito
Both blockdev.c and job-qmp.c have TOC/TOU conditions, because they first search for the job and then perform an action on it. Therefore, we need to do the search + action under the same job mutex critical section. Note: at this stage, job_{lock/unlock} and job lock guard macros are *nop*.

[PATCH v7 04/18] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED

2022-06-16 Thread Emanuele Giuseppe Esposito
Same as AIO_WAIT_WHILE macro, but if we are in the Main loop do not release and then acquire ctx_ 's aiocontext. Once all Aiocontext locks go away, this macro will replace AIO_WAIT_WHILE. Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito --- include/block/aio-wait.h | 17

Re: [PATCH v5 1/5] hw/i386: add 4g boundary start to X86MachineState

2022-06-16 Thread Igor Mammedov
On Fri, 20 May 2022 11:45:28 +0100 Joao Martins wrote: > Rather than hardcoding the 4G boundary everywhere, introduce a > X86MachineState property @above_4g_mem_start and use it so far it's just field not a property /fix commit message/ > accordingly. > > This is in preparation for relocating

[PATCH v7 18/18] block_job_query: remove atomic read

2022-06-16 Thread Emanuele Giuseppe Esposito
Not sure what the atomic here was supposed to do, since job.busy is protected by the job lock. Since the whole function is called under job_mutex, just remove the atomic. Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito --- blockjob.c | 2 +- 1 file changed, 1

Re: [PATCH v2 1/2] hw/nvme: Implement shadow doorbell buffer support

2022-06-16 Thread Klaus Jensen
On Jun 15 22:49, Jinhao Fan wrote: > Implement Doorbel Buffer Config command (Section 5.7 in NVMe Spec 1.3) > and Shadow Doorbel buffer & EventIdx buffer handling logic (Section 7.13 > in NVMe Spec 1.3). For queues created before the Doorbell Buffer Config > command, the nvme_dbbuf_config function

Re: [PATCH] tests/vm: do not specify -bios option

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 10:30:25AM +0200, Paolo Bonzini wrote: > When running from the build tree, the executable is able to find > the BIOS on its own; when running from the source tree, a firmware > blob should already be installed and there is no guarantee that > the one in the source tree

[PATCH v3 17/17] migration/snapshot: Postcopy load implemented

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin It is a modified load part from previous patch. Implemented new rp listen thread for snapshot-tool. Also implemented functions for starting postcopy. This mode can be turned on by specifying --postcopy flag. Signed-off-by: Nikita Lapshin --- include/qemu-snapshot.h |

[PULL 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent

2022-06-16 Thread Christian Schoenebeck
Extend previously added test case by checking that fid was unaffected by 'Twalk' request (i.e. when 2nd path component of request being invalid). Do that by subsequently sending a 'Tgetattr' request with the fid previously used for 'Twalk'; that 'Tgetattr' request should return an 'Rlerror'

[PULL 0/7] 9p queue 2022-06-16

2022-06-16 Thread Christian Schoenebeck
The following changes since commit 9ac873a46963098441be920ef7a2eaf244a3352d: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-06-15 09:47:24 -0700) are available in the Git repository at: https://github.com/cschoenebeck/qemu.git tags/pull-9p-20220616

[PULL 4/7] 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()

2022-06-16 Thread Christian Schoenebeck
The local variable 'name_idx' is used in two loops in function v9fs_walk(). Let the first loop use its own variable 'nwalked' instead, which we will use in subsequent patch as the number of (requested) path components successfully walked by background I/O thread. Signed-off-by: Christian

[PULL 3/7] tests/9pfs: compare QIDs in fs_walk_none() test

2022-06-16 Thread Christian Schoenebeck
Extend previously added fs_walk_none() test by comparing the QID of the root fid with the QID of the cloned fid. They should be equal. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <5bbe9c6931b4600a9a23742f5ff2d38c1188237d.1647339025.git.qemu_...@crudebyte.com> ---

Re: [PATCH v3 11/17] migration/qemu-file: Fix qemu_ftell() for non-writable file

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 01:28:05PM +0300, nikita.laps...@openvz.org wrote: > From: Nikita Lapshin > > qemu_ftell() will return wrong value for non-writable QEMUFile. > This happens due to call qemu_fflush() inside qemu_ftell(), this > function won't flush if file is readable. Well the return

Re: [QEMU PATCH v2 3/6] acpi/nvdimm: NVDIMM _DSM Spec supports revision 2

2022-06-16 Thread Igor Mammedov
On Mon, 30 May 2022 11:40:44 +0800 Robert Hoo wrote: > The Intel Optane PMem DSM Interface, Version 2.0 [1], is the up-to-date > spec for NVDIMM _DSM definition, which supports revision_id == 2. > > Nevertheless, Rev.2 of NVDIMM _DSM has no functional change on those Label > Data _DSM

[PATCH v17 02/13] linux-user: Add LoongArch signal support

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 312 + linux-user/loongarch64/target_signal.h | 13 ++ 2 files changed, 325 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode 100644

[PATCH v17 01/13] linux-user: Add LoongArch generic header files

2022-06-16 Thread Song Gao
This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h - target_resource.h - target_structs.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WANG Xuerui ---

[PATCH v17 04/13] linux-user: Add LoongArch syscall support

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/loongarch64/syscall_nr.h | 312 linux-user/loongarch64/target_syscall.h | 48 linux-user/syscall_defs.h | 6

[PATCH v17 03/13] linux-user: Add LoongArch elf support

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/elfload.c| 91 + linux-user/loongarch64/target_elf.h | 12 2 files changed, 103 insertions(+) create mode

[PATCH v17 06/13] scripts: add loongarch64 binfmt config

2022-06-16 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9cb723f443..1f4e2cd19d 100755 ---

[PATCH v17 12/13] default-configs: Add loongarch linux-user support

2022-06-16 Thread Song Gao
This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: WANG Xuerui --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644

[PATCH v3 1/2] hw/nvme: Implement shadow doorbell buffer support

2022-06-16 Thread Jinhao Fan
Implement Doorbel Buffer Config command (Section 5.7 in NVMe Spec 1.3) and Shadow Doorbel buffer & EventIdx buffer handling logic (Section 7.13 in NVMe Spec 1.3). For queues created before the Doorbell Buffer Config command, the nvme_dbbuf_config function tries to associate each existing SQ and CQ

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-06-16 Thread Igor Mammedov
On Mon, 30 May 2022 11:40:45 +0800 Robert Hoo wrote: > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which > depricates corresponding _DSM Functions defined by PMEM _DSM Interface spec > [2]. > > In this implementation, we do 2 things > 1. Generalize the QEMU<->ACPI BIOS

[PATCH 7/9] qapi: move QEMU-specific dispatch code in monitor

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Make QMP-dispatch code free from QEMU-specific OOB dispatch/async coroutine handling. This will allow to move the base code to qemu-common, and clear other users from potential mis-ususe (QGA doesn't have OOB or coroutine). To do that, introduce an optional callback

[PATCH v3 2/2] hw/nvme: Add trace events for shadow doorbell buffer

2022-06-16 Thread Jinhao Fan
When shadow doorbell buffer is enabled, doorbell registers are lazily updated. The actual queue head and tail pointers are stored in Shadow Doorbell buffers. Add trace events for updates on the Shadow Doorbell buffers and EventIdx buffers. Also add trace event for the Doorbell Buffer Config

[PATCH 5/9] error-report: introduce ErrorReportDetailedFunc

2022-06-16 Thread marcandre . lureau
From: Marc-André Lureau Remove monitor dependency from error printing code, by allowing programs to set a callback for when to use "detailed" reporting or not. Signed-off-by: Marc-André Lureau --- include/qemu/error-report.h | 4 +++- bsd-user/main.c | 2 +-

Re: [PATCH 1/8] migration: Implemented new parameter stream_content

2022-06-16 Thread Nikita
On 6/16/22 1:32 PM, Daniel P. Berrangé wrote: On Thu, Jun 16, 2022 at 01:19:57PM +0300, nikita.laps...@openvz.org wrote: From: Nikita Lapshin This new optional parameter contains inormation about migration stream parts to be sent (such as RAM, block, bitmap). This looks better than using

Re: [PATCH v3 11/17] migration/qemu-file: Fix qemu_ftell() for non-writable file

2022-06-16 Thread Nikita
On 6/16/22 2:20 PM, Daniel P. Berrangé wrote: On Thu, Jun 16, 2022 at 01:28:05PM +0300, nikita.laps...@openvz.org wrote: From: Nikita Lapshin qemu_ftell() will return wrong value for non-writable QEMUFile. This happens due to call qemu_fflush() inside qemu_ftell(), this function won't flush

[PULL 03/10] docs/cxl: Add switch documentation

2022-06-16 Thread Michael S. Tsirkin
From: Jonathan Cameron Switches were already introduced, but now we support them update the documentation to provide an example in diagram and qemu command line parameter forms. Signed-off-by: Jonathan Cameron Message-Id: <20220616145126.8002-4-jonathan.came...@huawei.com> Signed-off-by:

[PULL 00/10] virtio,pc,pci: fixes,cleanups,features

2022-06-16 Thread Michael S. Tsirkin
The following changes since commit def6fd6c9ce9e00a30cdd0066e0fde206b3f3d2f: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-06-16 07:13:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[PULL 06/10] virtio-iommu: Use recursive lock to avoid deadlock

2022-06-16 Thread Michael S. Tsirkin
From: Zhenzhong Duan When switching address space with mutex lock hold, mapping will be replayed for assigned device. This will trigger relock deadlock. Also release the mutex resource in unrealize routine. Signed-off-by: Zhenzhong Duan Message-Id:

[PULL 01/10] pci-bridge/cxl_upstream: Add a CXL switch upstream port

2022-06-16 Thread Michael S. Tsirkin
From: Jonathan Cameron An initial simple upstream port emulation to allow the creation of CXL switches. The Device ID has been allocated for this use. Signed-off-by: Jonathan Cameron Message-Id: <20220616145126.8002-2-jonathan.came...@huawei.com> Signed-off-by: Michael S. Tsirkin Reviewed-by:

[PULL 02/10] pci-bridge/cxl_downstream: Add a CXL switch downstream port

2022-06-16 Thread Michael S. Tsirkin
From: Jonathan Cameron Emulation of a simple CXL Switch downstream port. The Device ID has been allocated for this use. Signed-off-by: Jonathan Cameron Message-Id: <20220616145126.8002-3-jonathan.came...@huawei.com> Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin

[PULL 05/10] virtio-iommu: Add bypass mode support to assigned device

2022-06-16 Thread Michael S. Tsirkin
From: Zhenzhong Duan Currently assigned devices can not work in virtio-iommu bypass mode. Guest driver fails to probe the device due to DMA failure. And the reason is because of lacking GPA -> HPA mappings when VM is created. Add a root container memory region to hold both bypass memory region

[PULL 04/10] virtio/vhost-user: Fix wrong vhost notifier GPtrArray size

2022-06-16 Thread Michael S. Tsirkin
From: Yajun Wu In fetch_or_create_notifier, idx begins with 0. So the GPtrArray size should be idx + 1 and g_ptr_array_set_size should be called with idx + 1. This wrong GPtrArray size causes fetch_or_create_notifier return an invalid address. Passing this invalid pointer to

[PULL 07/10] virtio-iommu: Add an assert check in translate routine

2022-06-16 Thread Michael S. Tsirkin
From: Zhenzhong Duan With address space switch supported, dma access translation only happen after endpoint is attached to a non-bypass domain. Signed-off-by: Zhenzhong Duan Message-Id: <20220613061010.2674054-4-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[PULL 08/10] crypto: Introduce RSA algorithm

2022-06-16 Thread Michael S. Tsirkin
From: zhenwei pi There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge them into one. Then virtio-crypto gets request

[PULL 09/10] vhost: also check queue state in the vhost_dev_set_log error routine

2022-06-16 Thread Michael S. Tsirkin
From: Ni Xun When check queue state in the vhost_dev_set_log routine, it miss the error routine check, this patch also check queue state in error case. Fixes: 1e5a050f5798 ("check queue state in the vhost_dev_set_log routine") Signed-off-by: Ni Xun Reviewed-by: Zhigang Lu Message-Id:

[PULL 10/10] acpi/erst: fix fallthrough code upon validation failure

2022-06-16 Thread Michael S. Tsirkin
From: Ani Sinha At any step when any validation fail in check_erst_backend_storage(), there is no need to continue further through other validation checks. Further, by continuing even when record_size is 0, we run the risk of triggering a divide by zero error if we continued with other

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-06-16 Thread Dr. David Alan Gilbert
* Het Gala (het.g...@nutanix.com) wrote: > i) Modified the format of the qemu monitor command : 'migrate' by adding a > list, >each element in the list consists of multi-FD connection parameters: source >and destination uris and of the number of multi-fd channels between each > pair. >

Re: [PATCH 0/4] Multiple interface support on top of Multi-FD

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 03:44:09PM +0530, manish.mishra wrote: > > On 16/06/22 1:46 pm, Daniel P. Berrangé wrote: > > On Wed, Jun 15, 2022 at 08:14:26PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Fri, Jun 10, 2022 at 05:58:31PM +0530,

Re: [PATCH 3/4] Establishing connection between any non-default source and destination pair

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 07:33:04AM +, Het Gala wrote: > i) Binding of the socket to source ip address and port on the non-default >interface has been implemented for multi-FD connection, which was not >necessary earlier because the binding was on the default interface itself. > > ii)

Re: New "IndustryStandard" fw_cfg?

2022-06-16 Thread Gerd Hoffmann
Hi, > After re-read and re-think, I think the problem is better to state as: we > need an interface for QEMU to tell OVMF how much memory it needs to accept, > from [Minimum to All]. So for the case that user wants to boot an > partial-enabled confidential VMs (like current Linux TDX and SNP

[PULL 15/21] configure: update list of preserved environment variables

2022-06-16 Thread Paolo Bonzini
INSTALL and LIBTOOL are not used anymore, but OBJCFLAGS is new and was not listed. Signed-off-by: Paolo Bonzini --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 4b12a8094c..d41c7eddff 100755 --- a/configure +++ b/configure @@

[PULL 02/21] kvm: Support for querying fd-based stats

2022-06-16 Thread Paolo Bonzini
From: Mark Kanda Add support for querying fd-based KVM stats - as introduced by Linux kernel commit: cb082bfab59a ("KVM: stats: Add fd-based API to read binary stats data") This allows the user to analyze the behavior of the VM without access to debugfs. Signed-off-by: Mark Kanda

[PULL 14/21] virtio-mmio: cleanup reset

2022-06-16 Thread Paolo Bonzini
Make virtio_mmio_soft_reset reset the virtio device, which is performed by both the "soft" and the "hard" reset; and then call virtio_mmio_soft_reset from virtio_mmio_reset to emphasize that the latter is a superset of the former. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-mmio.c | 17

[PULL 11/21] s390x: simplify virtio_ccw_reset_virtio

2022-06-16 Thread Paolo Bonzini
Call virtio_bus_reset instead of virtio_reset, so that the function need not receive the VirtIODevice. Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/s390x/virtio-ccw.c

[PULL 17/21] tests/vm: allow running tests in an unconfigured source tree

2022-06-16 Thread Paolo Bonzini
tests/vm/Makefile.include used to assume that it could run in an unconfigured source tree, and Cirrus CI relies on that. It was however broken by commit f4c66f1705 ("tests: use tests/venv to run basevm.py-based scripts", 2022-06-06), which co-opted the virtual environment being used by avocado

[PULL 20/21] meson: put cross compiler info in a separate section

2022-06-16 Thread Paolo Bonzini
While at it, remove a dead assignment and simply inline the value of the "target" variable, which is used just once. Signed-off-by: Paolo Bonzini --- meson.build | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index

Re: [PATCH] tests/vm: do not specify -bios option

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 10:30:25AM +0200, Paolo Bonzini wrote: > When running from the build tree, the executable is able to find > the BIOS on its own; when running from the source tree, a firmware > blob should already be installed and there is no guarantee that > the one in the source tree

[PATCH v2 2/2] tests/qtest/i440fx-test.c: Enable full test of i440FX PAM operation

2022-06-16 Thread Lev Kujawski
With the prior patch in this series adding support for RE^WE PAM semantics, the '#ifndef BROKEN' segments of test_i440fx_pam can now be enabled. Additionally: - Verify that changing attributes does not affect the initial contents of the PAM region; - Verify that that the first new mask is

[PATCH v2 1/2] hw/pci-host/pam.c: Fully support RE^WE semantics of i440FX PAM

2022-06-16 Thread Lev Kujawski
The Programmable Attribute Registers (PAM) of QEMU's emulated i440FX chipset now fully support the exclusive Read Enable (RE) and Write Enable (WE) modes by forwarding reads of the applicable PAM region to RAM and writes to the bus or vice versa, respectively. The prior behavior for the RE case

Re: [PATCH 0/4] Multiple interface support on top of Multi-FD

2022-06-16 Thread manish.mishra
On 16/06/22 1:46 pm, Daniel P. Berrangé wrote: On Wed, Jun 15, 2022 at 08:14:26PM +0100, Dr. David Alan Gilbert wrote: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Fri, Jun 10, 2022 at 05:58:31PM +0530, manish.mishra wrote: On 09/06/22 9:17 pm, Daniel P. Berrangé wrote: On Thu, Jun

[PATCH 5/8] Add block part of migration stream

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin This patch enables and disable block in migration stream. Signed-off-by: Nikita Lapshin --- migration/migration.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index ad789915ce..d81f3c6891 100644

[PATCH v3 04/17] migration: Add dirty-bitmaps part of migration stream

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin This patch enables and disable dirty-bitmaps in migration stream. Signed-off-by: Nikita Lapshin --- migration/migration.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index bbf9b6aad1..ad789915ce

[PATCH v3 07/17] migration: analyze-migration script changed

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin This script is used for RAM capabilities test. But it cannot work in case of no vm description in migration stream. So new flag is added to allow work this script with ram-only migration stream. Signed-off-by: Nikita Lapshin --- scripts/analyze-migration.py | 19

[PATCH 5/8] migration: Add block part of migration stream

2022-06-16 Thread nikita . lapshin
From: Nikita Lapshin This patch enables and disable block in migration stream. Signed-off-by: Nikita Lapshin --- migration/migration.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index ad789915ce..d81f3c6891 100644

  1   2   3   >