Re: [PATCH] m68k: use correct variable name in boot info string macro

2022-06-25 Thread Laurent Vivier
Le 25/06/2022 à 17:23, Jason A. Donenfeld a écrit : Every time this macro is used, the caller is passing in "parameters_base", so this bug wasn't spotted. But the actual macro variable name is "base", so use that instead. Signed-off-by: Jason A. Donenfeld --- hw/m68k/bootinfo.h | 2 +- 1

[PATCH v4 1/2] hw: canokey: Remove HS support as not compliant to the spec

2022-06-25 Thread MkfsSion
Canokey core currently using 16 bytes as maximum packet size for control endpoint, but to run the device in high-speed a 64 bytes maximum packet size is required according to USB 2.0 specification. Since we don't acutally need to run the device in high-speed, simply don't assign high member in

[PATCH v4] docs/system/devices/canokey: Document limitations on usb-ehci

2022-06-25 Thread MkfsSion
Suggested-by: Hongren (Zenithal) Zheng Signed-off-by: YuanYang Meng --- v4: Adopt Zenithal's suggestion of repharsing the limitation docs/system/devices/canokey.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst

[PATCH qemu] m68k: virt: pass RNG seed via bootinfo block

2022-06-25 Thread Jason A. Donenfeld
This commit wires up bootinfo's RNG seed attribute so that Linux VMs can have their RNG seeded from the earliest possible time in boot, just like the "rng-seed" device tree property on those platforms. The link contains the corresponding Linux patch. Link:

[PATCH] m68k: use correct variable name in boot info string macro

2022-06-25 Thread Jason A. Donenfeld
Every time this macro is used, the caller is passing in "parameters_base", so this bug wasn't spotted. But the actual macro variable name is "base", so use that instead. Signed-off-by: Jason A. Donenfeld --- hw/m68k/bootinfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH qemu] m68k: virt: pass RNG seed via bootinfo block

2022-06-25 Thread Laurent Vivier
Le 25/06/2022 à 17:44, Jason A. Donenfeld a écrit : This commit wires up bootinfo's RNG seed attribute so that Linux VMs can have their RNG seeded from the earliest possible time in boot, just like the "rng-seed" device tree property on those platforms. The link contains the corresponding Linux

[PATCH 2/2] Convert fw_cfg.rst to reStructuredText syntax

2022-06-25 Thread Simon Sapin
And add it to specs/index.rst Signed-off-by: Simon Sapin --- docs/specs/fw_cfg.rst | 211 +++--- docs/specs/index.rst | 1 + 2 files changed, 119 insertions(+), 93 deletions(-) diff --git docs/specs/fw_cfg.rst docs/specs/fw_cfg.rst index

[PATCH v25 4/8] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util

Re: [PATCH v2 02/11] bsd-user: Implement symlink, symlinkat, readlink and readlinkat

2022-06-25 Thread Richard Henderson
On 6/24/22 14:47, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 74 +++ bsd-user/freebsd/os-syscall.c | 16 2 files changed, 90 insertions(+) Reviewed-by:

Re: [PATCH v2 11/11] bsd-user: Remove stray 'inline' from do_bsd_close

2022-06-25 Thread Richard Henderson
On 6/24/22 14:47, Warner Losh wrote: In the last series, I inadvertantly didn't remove this inline, but did all the others. Remove it for consistency. Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson

Re: [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()

2022-06-25 Thread Alex Bennée
Shaobo Song writes: > This fixes a bug in POSIX-compliant environments. Since we had allocated > a buffer named 'tcg-jit' with read-write access protections we need a int > type to combine these access flags and return it, whereas we had > inexplicably > return a bool type. It may

[PATCH v25 3/8] migration/dirtyrate: Refactor dirty page rate calculation

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it

Re: [PATCH 2/2] Convert fw_cfg.rst to reStructuredText syntax

2022-06-25 Thread Simon Sapin
On 25/06/2022 18:14, Simon Sapin wrote: And add it to specs/index.rst I meant to add to this commit message: This is part of https://gitlab.com/qemu-project/qemu/-/issues/527 -- Simon Sapin

[PATCH 1/2] Rename docs/specs/fw_cfg.txt to .rst

2022-06-25 Thread Simon Sapin
This is a separate commit in order to make reviewing the next one easier. Signed-off-by: Simon Sapin --- docs/specs/{fw_cfg.txt => fw_cfg.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/specs/{fw_cfg.txt => fw_cfg.rst} (100%) diff --git docs/specs/fw_cfg.txt

[PATCH] Add some documentation for "dtb" devices tree blobs

2022-06-25 Thread Simon Sapin
Signed-off-by: Simon Sapin --- docs/specs/device-trees.rst| 57 ++ docs/specs/index.rst | 1 + docs/system/arm/virt.rst | 5 +- docs/system/arm/xlnx-versal-virt.rst | 3 +- docs/system/ppc/ppce500.rst

[PATCH v25 7/8] softmmu/dirtylimit: Implement dirty page rate limit

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query

[PATCH v25 8/8] tests: Add dirty page rate limit test

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vcpu-dirty-limit". Signed-off-by: Hyman Huang(黄勇)

Booting bare-metal RISC-V virt (Was: [PATCH] Add some documentation for "dtb" devices tree blobs)

2022-06-25 Thread Simon Sapin
On 26/06/2022 00:34, Simon Sapin wrote: +On startup, the dtb is memory-mapped and its address is passed to the guest +in a target-specific way: + +* Arm: :ref:`arm-baremetal` +* **TODO**: document other targets Hello, My current interest is playing with bare-metal / freestanding RISC-V, using

Re: [PATCH v3 22/51] target/arm: Trap AdvSIMD usage when Streaming SVE is active

2022-06-25 Thread Richard Henderson
On 6/24/22 14:38, Peter Maydell wrote: Can we use this solution in the short term, and fix up advsimd while coverting it to decodetree? I'm more and more convinced we'll want this sooner than later. Yeah, I guess so. Is it possible to do the SVE stuff the right long-term way and have the

Re: [PATCH v2 04/11] bsd-user: Implement freebsd11_mknod, freebsd11_mknodat and mknodat

2022-06-25 Thread Richard Henderson
On 6/24/22 14:47, Warner Losh wrote: These implement both the old-pre INO64 mknod variations, as well as the now current INO64 variant. To implement the old stuff, we use some linker magic to bind to the old versions of these functions. Signed-off-by: Stacey Son Signed-off-by: Michal Meloun

[PATCH v25 0/8] support dirty restraint on vCPU

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) v25: - rebase master - fix 32-bit and non-Linux(freebsd) build failures use qatomic_read_i64() to replace qatomic_read() move the DIRTYLIMIT_TOLERANCE_RANGE MARCO out of 'linux' scope. Please review, thanks ! Yong. v24: - add "Acked-by: Peter Xu " tag in (PATCH

[PATCH v25 1/8] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c | 23 +-- 1 file changed, 13 insertions(+), 10

[PATCH v25 5/8] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu --- accel/kvm/kvm-all.c| 5 + accel/stubs/kvm-stub.c | 5 + include/sysemu/kvm.h | 2 ++ 3 files changed, 12 insertions(+)

[PATCH v25 2/8] cpus: Introduce cpu_list_generation_id

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement.

[PATCH v25 6/8] softmmu/dirtylimit: Implement virtual CPU throttle

2022-06-25 Thread huangy81
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇)

Re: [PATCH] Add some documentation for "dtb" devices tree blobs

2022-06-25 Thread Simon Sapin
On 26/06/2022 00:34, Simon Sapin wrote: diff --git qemu-options.hx qemu-options.hx index 377d22fbd8..eea75ddb37 100644 --- qemu-options.hx +++ qemu-options.hx @@ -38,6 +38,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \ "hmat=on|off controls ACPI HMAT support