Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Ani Sinha
On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > I even wouldn't mind if you put your python stuff in a new directory like > > tests/pytests/ for example, as long as it downloads your binaries separately > > - as I

Re: [PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-07-01 Thread Cédric Le Goater
Adding Markus, On 6/23/22 19:37, Patrick Venture wrote: On Thu, Jun 23, 2022 at 10:16 AM Cédric Le Goater mailto:c...@kaod.org>> wrote: On 6/23/22 17:28, Patrick Venture wrote: > > > On Wed, Jun 22, 2022 at 10:48 AM Jae Hyun Yoo mailto:quic_jaeh...@quicinc.com>

[RFC v1] util/aio: Keep notification disabled as much as possible

2022-07-01 Thread Chao Gao
When measuring FIO read performance (cache=writethrough, bs=4k, iodepth=64) in VMs, we observe ~80K/s notifications (e.g., EPT_MISCONFIG) from guest to qemu. Currently, poll_set_started(ctx,false) is called in try_poll_mode() to enable virtqueue notification in below 4 cases: 1. ctx->poll_ns is

[PATCH v2] microvm: turn off io reservations for pcie root ports

2022-07-01 Thread Gerd Hoffmann
The pcie host bridge has no io window on microvm, so io reservations will not work. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 4b3b1dd262f1..06f779e1aaee 100644 ---

Re: [PATCH v5 07/12] net: stream: add unix socket

2022-07-01 Thread Laurent Vivier
On 30/06/2022 11:28, Dr. David Alan Gilbert wrote: * Laurent Vivier (lviv...@redhat.com) wrote: Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/stream.c| 106 +--- qemu-options.hx | 1 + 2 files changed, 102

[PATCH 08/11] target/loongarch: Fix the meaning of ECFG reg's VS field

2022-07-01 Thread Xiaojuan Yang
By the manual of LoongArch CSR, the VS field(18:16 bits) of ECFG reg means that the number of instructions between each exception entry is 2^VS. Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/loongarch/cpu.c

[PATCH 07/11] hw/rtc/ls7a_rtc: Fix 'calculate' spelling errors

2022-07-01 Thread Xiaojuan Yang
Fix 'calculate' spelling errors. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index 85cd2d22a5..e8b75701e4 100644 --- a/hw/rtc/ls7a_rtc.c +++ b/hw/rtc/ls7a_rtc.c @@

Re: [PATCH] Add some documentation for "dtb" devices tree blobs

2022-07-01 Thread Peter Maydell
On Sat, 25 Jun 2022 at 23:39, Simon Sapin wrote: > > Signed-off-by: Simon Sapin > --- > docs/specs/device-trees.rst| 57 ++ > docs/specs/index.rst | 1 + > docs/system/arm/virt.rst | 5 +- >

Re: [PATCH v3 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-07-01 Thread Gerd Hoffmann
Hi, > > +# @monitor: Array of numbers, each of which represents physical > > +# monitor where GTK window containing a given VC will be > > +# placed. Each monitor number in the array will be > > +# associated with a virtual-console starting from

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > > I even wouldn't mind if you put your python stuff in a new directory like > > > tests/pytests/ for

Re: [PATCH v2 02/10] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-07-01 Thread Hanna Reitz
On 16.06.22 16:26, John Snow wrote: In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Hanna Reitz

Re: [QEMU PATCH v2 3/6] acpi/nvdimm: NVDIMM _DSM Spec supports revision 2

2022-07-01 Thread Robert Hoo
On Thu, 2022-06-16 at 13:38 +0200, Igor Mammedov wrote: > On Mon, 30 May 2022 11:40:44 +0800 > Robert Hoo wrote: > > > The Intel Optane PMem DSM Interface, Version 2.0 [1], is the up-to- > > date > > spec for NVDIMM _DSM definition, which supports revision_id == 2. > > > > Nevertheless, Rev.2

Re: [PATCH 3/3] gitlab: honour QEMU_CI variable in edk2/opensbi jobs

2022-07-01 Thread Daniel P . Berrangé
On Fri, Jul 01, 2022 at 07:13:44AM +0530, Richard Henderson wrote: > On 6/29/22 22:36, Daniel P. Berrangé wrote: > > +# In forks, if QEMU_CI=1 is set, then create manual job > > +# if the branch/tag starts with 'edk2' > > +- if: '$QEMU_CI == "1" && $CI_PROJECT_NAMESPACE !=

[PATCH 03/11] hw/rtc/ls7a_rtc: Remove unimplemented device in realized function

2022-07-01 Thread Xiaojuan Yang
Remove the unimplemented device when realized ls7a RTC, as it is not uesd. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index 780144b9da..f1e7a660e9 100644 --- a/hw/rtc/ls7a_rtc.c +++

[PATCH v2 00/11] Fix bugs for LoongArch virt machine

2022-07-01 Thread Xiaojuan Yang
This series fix some bugs for LoongArch virt machine. Including RTC device emulation, ECFG reg emulation, timer clear function, and IPI device function, etc. Xiaojuan Yang (11): hw/rtc/ls7a_rtc: Fix uninitialied bugs and toymatch writing function hw/rtc/ls7a_rtc: Fix timer call back function

Re: [RFC PATCH v4 10/11] qemu-sockets: introduce socket_uri()

2022-07-01 Thread Laurent Vivier
On 29/06/2022 13:26, Markus Armbruster wrote: Laurent Vivier writes: Format a string URI from a SocketAddress. Original code from hmp-cmds.c:SocketAddress_to_str() Replace 'tcp:' by 'inet:' (because 'inet' can be also 'udp'). This one's merely misleading. Replace 'tcp:' by 'vsock:' with

[PATCH 01/11] hw/rtc/ls7a_rtc: Fix uninitialied bugs and toymatch writing function

2022-07-01 Thread Xiaojuan Yang
1. Initialize the tm struct in toymatch_write() and ls7a_toy_start() to fix uninitialized bugs. 2. Fix toymatch_val_to_time function. By the document, when we calculate the expiration year, we should first get current year, and replace the 0-5 bits with toymatch's 26-31 bits. Fixes:

Re: [PATCH v4 04/45] target/arm: Mark ADR as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:26, Richard Henderson wrote: > > Mark ADR as a non-streaming instruction, which should trap > if full a64 support is not enabled in streaming mode. > > Removing entries from sme-fa64.decode is an easy way to see > what remains to be done. > > Signed-off-by: Richard

RE: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Felix xq > Queißner > Sent: Tuesday, June 28, 2022 12:44 AM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; th...@redhat.com; Felix "xq" Queißner > > Subject: [PATCH] gtk: Add

Re: [PATCH v3] ui/cocoa: Take refresh rate into account

2022-07-01 Thread Gerd Hoffmann
On Tue, Jun 21, 2022 at 09:51:38AM +0100, Peter Maydell wrote: > On Mon, 20 Jun 2022 at 21:29, Akihiko Odaki wrote: > > > > Retreieve the refresh rate of the display and reflect it with > > dpy_set_ui_info() and update_displaychangelistener(), allowing the > > guest and DisplayChangeListener to

Re: [PATCH v3 3/4] docs: rSTify GettingStartedDevelopers wiki; move it to QEMU Git

2022-07-01 Thread Peter Maydell
On Mon, 6 Jun 2022 at 17:43, Kashyap Chamarthy wrote: > > Converted the wiki[1] from Markdown to rST using: > > $> pandoc -f Mediawiki -t rst getting-started-developers.wiki > -o getting-started-developers.rst > > It's a 1-1 conversion (I double-checked to the best I could). I've

Re: [QEMU PATCH v2 6/6] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-07-01 Thread Robert Hoo
On Thu, 2022-06-16 at 14:35 +0200, Igor Mammedov wrote: > On Mon, 30 May 2022 11:40:47 +0800 > Robert Hoo wrote: > > suggest to put this patch as the 1st in series > (well you can rebase it on current master and > post that right away for merging since it doesn't > really depend on other

[PATCH 09/11] target/loongarch: Add lock when writing timer clear reg

2022-07-01 Thread Xiaojuan Yang
There is such error info when running linux kernel: tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()). calling stack: #0 in raise () at /lib64/libc.so.6 #1 in abort () at /lib64/libc.so.6 #2 in g_assertion_message_expr.cold () at /lib64/libglib-2.0.so.0

[PATCH 10/11] hw/intc/loongarch_ipi: Fix ipi device access of 64bits

2022-07-01 Thread Xiaojuan Yang
In general loongarch ipi device, 32bit registers is emulated, however for anysend/mailsend device only 64bit register access is supported. So separate the ipi memory region into two regions, including 32 bits and 64 bits. Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_ipi.c | 38

Re: [PATCH] block/rbd: support driver-specific reopen

2022-07-01 Thread Hanna Reitz
On 13.04.22 14:26, Raphael Pour wrote: This patch completes the reopen functionality for an attached RBD where altered driver options can be passed to. This is necessary to move RBDs between ceph clusters without interrupting QEMU, where some ceph settings need to be adjusted. The

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread kra...@redhat.com
On Fri, Jul 01, 2022 at 09:14:02AM +, Zhang, Chen wrote: > > > > Signed-off-by: Felix "xq" Queißner > > Thanks your patch, but please use your real name to sign a patch. > For the details: > docs/devel/submitting-a-patch.rst Hmm? Felix Queißner looks like a real name to me ... take

Re: [PATCH v2 0/3] CanoKey: Fix xHCI compatibility and CCID ZLP

2022-07-01 Thread Gerd Hoffmann
On Thu, Jun 23, 2022 at 11:16:39PM +0800, Hongren (Zenithal) Zheng wrote: > On Mon, Jun 13, 2022 at 08:12:38PM +0800, Hongren (Zenithal) Zheng wrote: > > > --- > > v2: > > * use usb_ep_get instead of recording ep_in_pointer > > as suggested by kraxel > > * CI result for v2 is at > >

Re: [PATCH v2 01/10] tests/qemu-iotests: hotfix for 307, 223 output

2022-07-01 Thread Hanna Reitz
On 16.06.22 16:26, John Snow wrote: Fixes: 58a6fdcc Signed-off-by: John Snow Tested-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Hanna

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-01 Thread Robert Hoo
On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote: > On Mon, 30 May 2022 11:40:45 +0800 > Robert Hoo wrote: > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > which > > depricates corresponding _DSM Functions defined by PMEM _DSM > > Interface spec > > [2]. > > > >

[PATCH 04/11] hw/rtc/ls7a_rtc: Add reset function

2022-07-01 Thread Xiaojuan Yang
Add ls7a rtc reset function to delete timers and clear regs when rtc reset. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index f1e7a660e9..eb10cdb451 100644 ---

[PATCH 05/11] hw/rtc/ls7a_rtc: Fix rtc enable and disable function

2022-07-01 Thread Xiaojuan Yang
Fix ls7a rtc enable and disable function. When rtc disabled, it do not support to read or write, but the real time is still continue, so we need not neither save the time nor update the rtc offset. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 60

[PATCH 06/11] hw/rtc/ls7a_rtc: Use tm struct pointer as arguments in toy_time_to_val()

2022-07-01 Thread Xiaojuan Yang
Use pointer as arguments in toy_time_to_val() instead of struct tm. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index a36aeea9dd..85cd2d22a5 100644 ---

[PATCH 11/11] hw/intc/loongarch_ipi: Fix mail send and any send function

2022-07-01 Thread Xiaojuan Yang
By the document of ipi mailsend device, byte is written only when the mask bit is 0. The original code discards mask bit and overwrite the data always, this patch fixes the issue. Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_ipi.c | 45 ++--- 1 file

[PATCH 02/11] hw/rtc/ls7a_rtc: Fix timer call back function

2022-07-01 Thread Xiaojuan Yang
Replace qemu_irq_pulse with qemu_irq_raise in ls7a_timer_cb function to keep consistent with hardware behavior when raise irq. Signed-off-by: Xiaojuan Yang --- hw/rtc/ls7a_rtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 01:20:30PM +0530, Ani Sinha wrote: > On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Jul 01, 2022 at

Re: [PATCH v4 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:26, Richard Henderson wrote: > > This new behaviour is in the ARM pseudocode function > AArch64.CheckFPAdvSIMDEnabled, which applies to AArch32 > via AArch32.CheckAdvSIMDOrFPEnabled when the EL to which > the trap would be delivered is in AArch64 mode. > > Given that

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Ani Sinha
On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > > > I even wouldn't mind if you put

Re: [PATCH v3 0/4] rSTify a few more docs; move them to QEMU Git

2022-07-01 Thread Kashyap Chamarthy
Ping. Thomas/Peter: when you get some time, please have a look at this. On Mon, Jun 06, 2022 at 06:55:47PM +0200, Kashyap Chamarthy wrote: > On Mon, Jun 06, 2022 at 06:49:49PM +0200, Kashyap Chamarthy wrote: > > Oops, messed up v3's cover-letter subject; now fixed. Sorry. > > Sigh, instead of

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Gerd Hoffmann
Hi, > But a bit more verbosity might be nice, too.  What about “Display the tab > bar for switching between the various graphical interfaces (e.g. VGA and > virtual console character devices) by default”?  (Note the imperative on > “Display”, I think we generally use the imperative to document

Re: [PATCH v3 0/4] rSTify a few more docs; move them to QEMU Git

2022-07-01 Thread Peter Maydell
On Fri, 1 Jul 2022 at 09:53, Kashyap Chamarthy wrote: > > Ping. > > Thomas/Peter: when you get some time, please have a look at this. I reviewed the one patch that had neither already got an R-by or some review comments. thanks -- PMM

Re: [PATCH v4 01/45] target/arm: Handle SME in aarch64_cpu_dump_state

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:25, Richard Henderson wrote: > > Dump SVCR, plus use the correct access check for Streaming Mode. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell Dumping the actual ZA storage seems like it would be more annoying than useful :-) thanks -- PMM

Re: [PATCH v3] ui/cocoa: Take refresh rate into account

2022-07-01 Thread Peter Maydell
On Fri, 1 Jul 2022 at 11:11, Gerd Hoffmann wrote: > > On Tue, Jun 21, 2022 at 09:51:38AM +0100, Peter Maydell wrote: > > On Mon, 20 Jun 2022 at 21:29, Akihiko Odaki wrote: > > > > > > Retreieve the refresh rate of the display and reflect it with > > > dpy_set_ui_info() and

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Ani Sinha
On Fri, Jul 1, 2022 at 3:12 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 01:20:30PM +0530, Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > > > On Fri, Jul 1, 2022 at 12:23 PM

Re: [PATCH v4 05/45] target/arm: Mark RDFFR, WRFFR, SETFFR as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:26, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 2/2] hw: m25p80: add tests for BP and TB bit write protect

2022-07-01 Thread Cédric Le Goater
On 6/27/22 20:52, Iris Chen wrote: Signed-off-by: Iris Chen Palmettos are getting old (2014). We might want to change the machine model to an ast2600 one. Anyhow, these are very good tests for both m25p80 and aspeed-smc models. Reviewed-by: Cédric Le Goater Thanks, C. ---

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > I even wouldn't mind if you put your python stuff in a new directory like > tests/pytests/ for example, as long as it downloads your binaries separately > - as I wrote in another mail, the avocado framework rather looks like an >

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-07-01 Thread Cédric Le Goater
> Thanks for the new device. It helps me see where to expand on PMBus. Thanks for adding the whole pmbus infrastructure! It’s really useful. And thanks for the review. Off-topic, but I’ve been meaning to reach out to you guys (Google engineers working on QEMU for OpenBMC)

RE: [RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Andrew Melnichenko > Sent: Wednesday, June 29, 2022 6:43 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Thomas Huth ;

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-07-01 Thread Leonardo Brás
On Tue, 2022-06-28 at 17:56 +0100, Dr. David Alan Gilbert wrote: > * Leonardo Bras Soares Passos (leob...@redhat.com) wrote: > > On Tue, Jun 28, 2022 at 10:52 AM Dr. David Alan Gilbert > > wrote: > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Tue, Jun 28, 2022 at

Re: [PATCH 1/2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-01 Thread Cédric Le Goater
Even for a simple addition a quick intro is always nice to have. On 6/27/22 20:52, Iris Chen wrote: Signed-off-by: Iris Chen Too bad that we are modeling 5 bits with 5 bools but given the layout it makes the code easier to read. LGTM. Reviewed-by: Cédric Le Goater Thanks, C. ---

Re: [PATCH 1/2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-01 Thread Francisco Iglesias
Hi Iris, Looks good, a couple of minor comments below! On [2022 Jun 27] Mon 11:52:33, Iris Chen wrote: > Signed-off-by: Iris Chen > --- > hw/block/m25p80.c | 74 +++ > 1 file changed, 62 insertions(+), 12 deletions(-) > > diff --git

Re: [PATCH v4 07/45] target/arm: Mark PMULL, FMMLA as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:28, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson > --- > target/arm/sme-fa64.decode | 2 -- > target/arm/translate-sve.c | 18

Re: [PATCH v4 08/45] target/arm: Mark FTSMUL, FTMAD, FADDA as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:28, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 09/45] target/arm: Mark SMMLA, UMMLA, USMMLA as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:25, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

API to change the vendor of IDE disk

2022-07-01 Thread Alex
Dear Qemu Genius This is zaifeng (wzf_develo...@foxmail.com) (WeChat ID: QemuKVM). Yes, I am a cloud engineer. (๑•̀ㅂ•́)و✧ MayIaskyousomequestionsaboutQemu? Here is the problem: If you use IDE disk on a Windows VM, "QEMU HARDDISK" could be found from device

[PATCH 2/3] hw/i386/pc: Always place CXL Memory Regions after device_memory

2022-07-01 Thread Jonathan Cameron via
Previously broken_reserved_end was taken into account, but Igor Mammedov identified that this could lead to a clash between potential RAM being mapped in the region and CXL usage. Hence always add the size of the device_memory memory region. This only affects the case where the

[PATCH 1/3] hw/machine: Clear out left over CXL related pointer from move of state handling to machines.

2022-07-01 Thread Jonathan Cameron via
This got left behind in the move of the CXL setup code from core files to the machines that support it. Link: https://gitlab.com/qemu-project/qemu/-/commit/1ebf9001fb2701e3c00b401334c8f3900a46adaa Signed-off-by: Jonathan Cameron --- include/hw/boards.h | 1 - 1 file changed, 1 deletion(-)

[PATCH 00/17] acpi:pc/q35: minor PCI refactoring/cleanups

2022-07-01 Thread Igor Mammedov
Flushing out ACPI PCI cleanups that preceed conversion of DSDT PCI slots ennumeration to AcpiDevAmlIf interface. It's is mostly collection of patches thraet removes code duplication, we've accumulated around PCI relaterd AML in DSDT. git: https://gitlab.com/imammedo/qemu.git x86_pci_cleanups

[PATCH 01/17] tests: acpi: whitelist pc/q35 DSDT due to HPET AML move

2022-07-01 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 32 + 1 file changed, 32 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..a7aa428fab 100644 ---

[PATCH 04/17] tests: acpi: whitelist pc/q35 DSDT due to HPET AML move

2022-07-01 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 34 + 1 file changed, 34 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..452145badd 100644 ---

[PATCH 06/17] x86: acpi: _DSM: use Package to pass parameters

2022-07-01 Thread Igor Mammedov
Numer of possible arguments to pass to a method is limited in ACPI. The following patches will need to pass over more parameters to PDSM method, will hit that limit. Prepare for this by passing structure (Package) to method, which let us workaround arguments limitation. Pass to PDSM all standard

[PATCH RESEND 03/11] target/ppc: Move slbie to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 7 +++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 13 -

[PATCH 13/17] tests: acpi: update expected blobs

2022-07-01 Thread Igor Mammedov
Expected change: -Name (_SUN, 0x0X) // _SUN: Slot User Number Name (_ADR, 0xY) // _ADR: Address ... +Name (_SUN, 0xX) // _SUN: Slot User Number Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 14

[PATCH RESEND 10/11] target/ppc: Move slbsync to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/insn32.decode | 2 ++ target/ppc/translate.c | 17 - target/ppc/translate/storage-ctrl-impl.c.inc | 14 ++ 3 files changed, 16 insertions(+), 17

Re: [PATCH] qga: add command 'guest-get-cpustats'

2022-07-01 Thread Marc-André Lureau
Hi On Fri, Jul 1, 2022 at 7:11 AM zhenwei pi wrote: > A vCPU thread always reaches 100% utilization when: > - guest uses idle=poll > - disable HLT vm-exit > - enable MWAIT > > Add new guest agent command 'guest-get-cpustats' to get guest CPU > statistics, we can know the guest workload and how

Re: [PATCH 03/12] pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk()

2022-07-01 Thread Eric Farman
On Tue, 2022-06-28 at 15:10 +0200, Thomas Huth wrote: > The logic of trying an final ISO or ECKD boot on virtio-block devices > is > very weird: Since the geometry hardly ever matches in > virtio_disk_is_scsi(), > virtio_blk_setup_device() always sets a "guessed" disk geometry via >

Re: [PATCH v4 16/45] target/arm: Handle SME in sve_access_check

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:39, Richard Henderson wrote: > > The pseudocode for CheckSVEEnabled gains a check for Streaming > SVE mode, and for SME present but SVE absent. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 22 -- > 1 file changed, 16

[PATCH 09/17] x86: acpi: cleanup PCI device _DSM duplication

2022-07-01 Thread Igor Mammedov
add ASUN variable to hotpluggable slots and use it instead of _SUN which has the same value to reuse _DMS code on both branches (hot- and non-hotpluggable). No functional change. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 56 +--- 1 file

[PATCH RESEND 01/11] target/ppc: receive DisasContext explicitly in GEN_PRIV

2022-07-01 Thread Lucas Coutinho
From: Matheus Ferst GEN_PRIV and related CHK_* macros just assumed that variable named "ctx" would be in scope when they are used, and that it would be a pointer to DisasContext. Change these macros to receive the pointer explicitly. Reviewed-by: Leandro Lupori Signed-off-by: Matheus Ferst

[PATCH RESEND 00/11] target/ppc: Implement slbiag move slb* to decodetree

2022-07-01 Thread Lucas Coutinho
Resent after rebasing and fixing conflicts with master. Add Leandro Lupori as reviewer. Based-on: <20220624191424.190471-1-leandro.lup...@eldorado.org.br> Implement the following PowerISA v3.0 instuction: slbiag: SLB Invalidate All Global X-form Move the following PowerISA v3.0 instuction to

[PATCH 15/17] x86: pci: acpi: reorder Device's _DSM method

2022-07-01 Thread Igor Mammedov
align _DSM method in empty slot descriptor with a populated slot position. Expected change: +Device (SE8) +{ +Name (_ADR, 0x001D) // _ADR: Address +Name (ASUN, 0x1D) Method (_DSM, 4, Serialized) // _DSM:

[PATCH RESEND 07/11] target/ppc: Move slbmfev to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 2 ++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 12

[PATCH RESEND 09/11] target/ppc: Move slbfee to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 2 ++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 26 ---

[PATCH RESEND 05/11] target/ppc: Move slbia to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 5 + target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 17 -

Re: [PATCH] qga: add command 'guest-get-cpustats'

2022-07-01 Thread Konstantin Kostiuk
On Fri, Jul 1, 2022 at 4:53 PM Marc-André Lureau wrote: > Hi > > On Fri, Jul 1, 2022 at 7:11 AM zhenwei pi wrote: > >> A vCPU thread always reaches 100% utilization when: >> - guest uses idle=poll >> - disable HLT vm-exit >> - enable MWAIT >> >> Add new guest agent command 'guest-get-cpustats'

Re: [PATCH 01/12] pc-bios/s390-ccw: Add a proper prototype for main()

2022-07-01 Thread Eric Farman
On Tue, 2022-06-28 at 15:10 +0200, Thomas Huth wrote: > Older versions of Clang complain if there is no prototype for main(). > Add one, and while we're at it, make sure that we use the same type > for main.c and netmain.c - since the return value does not matter, > declare the return type of

Re: [PATCH v4 12/45] target/arm: Mark gather prefetch as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:42, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap if full > a64 support is not enabled in streaming mode. In this case, introduce > PRF_ns (prefetch non-streaming) to handle the checks. > > Signed-off-by: Richard Henderson >

Re: [PATCH v4 11/45] target/arm: Mark gather/scatter load/store as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:38, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 1/2] target/riscv: Fixup MSECCFG minimum priv check

2022-07-01 Thread Bin Meng
On Thu, Jun 30, 2022 at 7:31 AM Alistair Francis wrote: > > From: Alistair Francis > > There is nothing in the RISC-V spec that mandates version 1.12 is > required for ePMP and there is currently hardware [1] that implements > ePMP (a draft version though) with the 1.11 priv spec. > > 1:

Re: [PATCH v4 13/45] target/arm: Mark LDFF1 and LDNF1 as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:28, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup

2022-07-01 Thread Jonathan Cameron via
Three more or less less unrelated fixes for recently added CXL code. Jonathan Cameron (3): hw/machine: Clear out left over CXL related pointer from move of state handling to machines. hw/i386/pc: Always place CXL Memory Regions after device_memory hw/cxl: Fix size of constant in

[PATCH 17/17] x86: pci: acpi: deduplate PCI slots creation

2022-07-01 Thread Igor Mammedov
No functional change nor AML bytcode change. Consolidate code that generates empty and populated slots descriptors. Beside of eliminating duplication, it helps to consolidate conditions for generating parts of Device{} desriptor in one place, which makes code more compact and easier to read.

[PATCH 11/17] tests: acpi: whitelist pc/q35 DSDT before moving _ADR field

2022-07-01 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..1983fa596b 100644 ---

[PATCH 08/17] tests: acpi: whitelist pc/q35 DSDT before switching _DSM to use ASUN

2022-07-01 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..1983fa596b 100644 ---

[PATCH RESEND 04/11] target/ppc: Move slbieg to decodetree

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 1 + target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 13 -

[PATCH RESEND 02/11] target/ppc: add macros to check privilege level

2022-07-01 Thread Lucas Coutinho
From: Matheus Ferst Equivalent to CHK_SV and CHK_HV, but can be used in decodetree methods. Reviewed-by: Leandro Lupori Signed-off-by: Matheus Ferst Signed-off-by: Lucas Coutinho --- target/ppc/translate.c | 21 +

[PATCH RESEND 11/11] target/ppc: Implement slbiag

2022-07-01 Thread Lucas Coutinho
Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 1 + target/ppc/insn32.decode | 4 +++ target/ppc/mmu-hash64.c | 27 target/ppc/translate/storage-ctrl-impl.c.inc | 14

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-01 Thread Peter Maydell
On Fri, 15 Oct 2021 at 16:01, Kevin Wolf wrote: > QDicts are both what QMP natively uses and what the keyval parser > produces. Going through QemuOpts isn't useful for either one, so switch > the main device creation function to QDicts. By sharing more code with > the -object/object-add code

Re: [PATCH] ebpf: replace deprecated bpf_program__set_socket_filter

2022-07-01 Thread Peter Maydell
On Wed, 8 Jun 2022 at 09:17, Jason Wang wrote: > > On Tue, May 31, 2022 at 1:40 PM Zhang, Chen wrote: > > > > > > > > > -Original Message- > > > From: Qemu-devel > > bounces+chen.zhang=intel@nongnu.org> On Behalf Of Haochen Tong > > > Sent: Saturday, May 28, 2022 3:07 AM > > > To:

Re: [PATCH 2/2] target/riscv: Ibex: Support priv version 1.11

2022-07-01 Thread Bin Meng
On Thu, Jun 30, 2022 at 7:31 AM Alistair Francis wrote: > > From: Alistair Francis > > The Ibex CPU supports version 1.11 of the priv spec [1], so let's > correct that in QEMU as well. > > 1: https://ibex-core.readthedocs.io/en/latest/01_overview/compliance.html > > Signed-off-by: Alistair

Re: [PATCH v4 15/45] target/arm: Add SME enablement checks

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:32, Richard Henderson wrote: > > These functions will be used to verify that the cpu > is in the correct state for a given instruction. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 1/2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-01 Thread Francisco Iglesias
On [2022 Jul 01] Fri 14:23:17, Cédric Le Goater wrote: > On 7/1/22 13:40, Francisco Iglesias wrote: > > Hi Iris, > > > > Looks good, a couple of minor comments below! > > > > On [2022 Jun 27] Mon 11:52:33, Iris Chen wrote: > > > Signed-off-by: Iris Chen > > > --- > > > hw/block/m25p80.c | 74

[PATCH 03/17] tests: acpi: update expected blobs after HPET move

2022-07-01 Thread Igor Mammedov
HPET AML moved after PCI host bridge description (no functional change) diff example for PC machine: @@ -54,47 +54,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) } } -Scope (_SB) -{ -Device (HPET) -{ -Name (_HID, EisaId

Re: [PATCH v4 06/45] target/arm: Mark BDEP, BEXT, BGRP, COMPACT, FEXPA, FTSSEL as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:28, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson > --- > target/arm/sme-fa64.decode | 3 --- > target/arm/translate-sve.c | 22

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-07-01 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote: > but I thought you were suggesting we built bits every time the test is run? In my opinion 3 scenarios are worth supporting: - people not touching ACPI, including users - simply don't run the tests, comparing tables with expected

Re: [PATCH v4 14/45] target/arm: Mark LD1RO as non-streaming

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:49, Richard Henderson wrote: > > Mark these as a non-streaming instructions, which should trap > if full a64 support is not enabled in streaming mode. > > Signed-off-by: Richard Henderson > --- > target/arm/sme-fa64.decode | 3 --- > target/arm/translate-sve.c | 2 ++ >

[PATCH 3/3] hw/cxl: Fix size of constant in interleave granularity function.

2022-07-01 Thread Jonathan Cameron via
Whilst the interleave granularity is always small enough that this isn't a real problem (much less than 4GiB) let's change the constant to ULL to fix the coverity warning. Reported-by: Peter Maydell Fixes: 829de299d1 ("hw/cxl/component: Add utils for interleave parameter encoding/decoding")

[PATCH 10/17] tests: acpi: update expected blobs

2022-07-01 Thread Igor Mammedov
It's expected that hotpluggable slots will, get ASUN variable and use that instead of _SUN with its _DSM method. For example: @@ -979,8 +979,9 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) Device (S18) { -Name (_SUN,

[PATCH 12/17] x86: pci: acpi: reorder Device's _ADR and _SUN fields

2022-07-01 Thread Igor Mammedov
no functional change, align order of fields in empty slot descriptor with a populated slot ordering. Expected diff: -Name (_SUN, 0x0X) // _SUN: Slot User Number Name (_ADR, 0xY) // _ADR: Address ... +Name (_SUN, 0xX) // _SUN: Slot User

[PATCH 07/17] tests: acpi: update expected blobs

2022-07-01 Thread Igor Mammedov
An intermediate blobs update to keep changes (last 2 patches) reviewable. Includes refactored PDSM that uses Package argument for custom parameters. = PDSM taking package as arguments Return (Local0) } -Method (PDSM, 6, Serialized) +Method (PDSM, 5,

  1   2   >