Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This is just moving qapi-gen.py and related subdir to qemu-common, to > ease review and proceed step by step. The following patches will move > related necessary code, tests etc. > > Signed-off-by: Marc-André Lureau As moved

Re: [PATCH v3] hw/i386: place setup_data at fixed place in memory

2022-08-05 Thread Paolo Bonzini
On 8/5/22 01:04, Jason A. Donenfeld wrote: +/* Nothing else uses this part of the hardware mapped region */ +setup_data_base = 0xf - 0x1000; Isn't this where the BIOS lives? I don't think this works. Does it work to place setup_data at the end of the cmdline file instead of

Re: Regression in -readconfig [memory] size (was: [PULL 13/27] machine: add mem compound property)

2022-08-05 Thread Daniel P . Berrangé
On Fri, Aug 05, 2022 at 11:30:12AM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Paolo Bonzini writes: > > > >> Make -m syntactic sugar for a compound property "-machine > >> mem.{size,max-size,slots}". The new property does not have > >> the magic conversion to megabytes

[PATCH] pc-bios/s390-ccw: Fix booting with logical block size < physical block size

2022-08-05 Thread Thomas Huth
For accessing single blocks during boot, it's the logical block size that matters. (Physical block sizes are rather interesting e.g. for creating file systems with the correct alignment for speed reasons etc.). So the s390-ccw bios has to use the logical block size for calculating sector numbers

[PATCH 1/1] tests/qtest: add scenario for -readconfig handling

2022-08-05 Thread Daniel P . Berrangé
This test of -readconfig validates the last three regressions we have fixed with -readconfig: * Interpretation of memory size units as MiB not bytes * Allow use of [spice] * Allow use of [object] Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 +

Re: [PATCH v2 12/20] ppc/ppc405: QOM'ify EBC

2022-08-05 Thread BALATON Zoltan
On Fri, 5 Aug 2022, Cédric Le Goater wrote: On 8/4/22 21:26, BALATON Zoltan wrote: On Thu, 4 Aug 2022, Peter Maydell wrote: On Thu, 4 Aug 2022 at 19:03, BALATON Zoltan wrote: I was trying to find out how to do it but I don't understand QOM enough to answer the simple question of how to get

Re: [PATCH v10 21/21] job: remove unused functions

2022-08-05 Thread Kevin Wolf
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > These public functions are not used anywhere, thus can be dropped. > Also, since this is the final job API that doesn't use AioContext > lock and replaces it with job_lock, adjust all remaining function > documentation to clearly

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Emanuele Giuseppe Esposito
Am 05/08/2022 um 15:22 schrieb Emanuele Giuseppe Esposito: > > > Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: >> On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: >>> The aim of this series is to reorganize bdrv_try_set_aio_context >>> and drop BDS ->set_aio_context and

Re: [PATCH] hw/ppc: ppc440_uc: avoid multiply overflow in dcr_write_dma()

2022-08-05 Thread BALATON Zoltan
On Fri, 5 Aug 2022, Daniel Henrique Barboza wrote: Coverity reports a OVERFLOW_BEFORE_WIDEN issue in dcr_write_dma(). When handling the DMA0_CR switch we're doing a multiplication between two integers (count and width), and the product is assigned to an uint64_t (xferlen). The int32 product can

<    1   2   3