Re: [PATCH v2 0/8] vhost-user-blk: dynamically resize config space based on features

> ping Apologies for the late review - busy week. First pass looks good but will review comprehensively tomorrow or over the weekend.

Re: [PATCH 15/42] hw/isa/piix3: Prefer pci_address_space() over get_system_memory()

On 1/9/22 18:25, Bernhard Beschow wrote: get_system_memory() accesses global state while pci_address_space() uses whatever has been passed to the device instance, so avoid the global. Moreover, PIIX4 uses pci_address_space() here as well. Signed-off-by: Bernhard Beschow --- hw/isa/piix3.c |

[RFC 2/4] tcg/plugins: Automatically define CURRENT_PLUGIN

Use plugin filenames to set the preprocessor variable CURRENT_PLUGIN as a string during plugin compilation. Signed-off-by: Andrew Fasano --- contrib/plugins/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index

[RFC 0/4] Support interactions between TCG plugins

Hello, I'm requesting comments on the following series of patches expanding the TCG plugin system to add the "QEMU Plugin-to-Plugin (QPP)" interface that allows for interactions between TCG plugins. The goal of this interface is to enable plugins to expand on other plugins and reduce code

[RFC 4/4] tcg/plugins: Add example pair of QPP plugins

The first plugin, qpp_srv exposes two functions and one callback that other plugins can leverage. These functions are described in the corresponding header file. The second plugin, qpp_client, imports this header file, registers its own function to run on a qpp_srv-provided callback, and directly

[PATCH 1/4] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

This commit adds most of an implementation of the OpenTitan Always-On Timer. The documentation for this timer is found here: https://docs.opentitan.org/hw/ip/aon_timer/doc/ The implementation includes most of the watchdog features; it does not implement the wakeup timer. An important note: the

[PATCH 4/4] hw/timer: ibex_timer.c: Add support for writes to mtime

1. Adds fields to hold the value of mtime in timer_upper0 and timer_lower0. 2. Changes the read and write functions to use the mtime fields. 3. Updates the value of mtime in update_mtime() by extrapolating the time elapsed. This will need to change if/when the prescalar is implemented.

Re: [PATCH 13/42] hw/isa/piix3: Add size constraints to rcr_ops

On 1/9/22 18:25, Bernhard Beschow wrote: According to the PIIX3 datasheet, the reset control register is one byte in size. Moreover, PIIX4 has it, so add it to PIIX3 as well. Signed-off-by: Bernhard Beschow --- hw/isa/piix3.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v3 00/15] Support VIRTIO_F_RING_RESET for virtio-net, vhost-net kernel in virtio pci-modern

Do you have any comments about this patch set? Thanks 在 2022/8/25 16:08, Kangjie Xu 写道: The virtio queue reset function has already been defined in the virtio spec 1.2. The relevant virtio spec information is here: https://github.com/oasis-tcs/virtio-spec/issues/124

Re: [Qemu-devel] [RFC PATCH] Add qemu .clang-format

On 9/1/2022 7:55 PM, Alex Bennée wrote: > > "Wang, Lei" writes: > >> On 9/1/2022 4:12 PM, Daniel P. Berrangé wrote: >>> On Thu, Sep 01, 2022 at 09:08:33AM +0800, Wang, Lei wrote: On 8/31/2022 6:39 PM, Daniel P. Berrangé wrote: > On Wed, Aug 31, 2022 at 05:18:34PM +0800, Wang, Lei

Re: [PATCH 32/42] hw/isa/piix4: Rename wrongly named method

On 1/9/22 18:26, Bernhard Beschow wrote: This method post-loads the southbridge, not the IDE device. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[RFC 1/4] docs/tcg-plugins: describe QPP API

Describe how multiple TCG plugins can interact using the QEMU Plugin-to-Plugin API (QPP) with both callbacks and direct function calls. Signed-off-by: Andrew Fasano --- docs/devel/tcg-plugins.rst | 76 ++ 1 file changed, 76 insertions(+) diff --git

<    1   2   3   4