Re: [PATCH v5 35/43] tcg: Pass number of arguments to tcg_emit_op() / tcg_op_insert_*()

2022-12-26 Thread Philippe Mathieu-Daudé
On 25/12/22 00:57, Richard Henderson wrote: From: Philippe Mathieu-Daudé In order to have variable size allocated TCGOp, pass the number of arguments we use (and would allocate) up to tcg_op_alloc(). This alters tcg_emit_op(), tcg_op_insert_before() and tcg_op_insert_after() prototypes. In

[PATCH] i.MX7D: Connect IRQs to GPIO devices.

2022-12-26 Thread Jean-Christophe Dubois
IRQs were not associated to the various GPIO devices inside i.MX7D. This patch brings the i.MX7D on par with i.MX6. Signed-off-by: Jean-Christophe Dubois --- hw/arm/fsl-imx7.c | 31 ++- include/hw/arm/fsl-imx7.h | 15 +++ 2 files changed, 45

Re: [PATCH v5 01/43] tcg: convert tcg/README to rst

2022-12-26 Thread Philippe Mathieu-Daudé
On 25/12/22 00:56, Richard Henderson wrote: From: Mark Cave-Ayland Convert tcg/README to rst and move it to docs/devel as a new "TCG Intermediate Representation" page. There are a few minor changes to improve the aesthetic of the final output which are as follows: - Rename the title from

Re: [PATCH v2] qga-win: choose the right libpcre version to include in MSI package

2022-12-26 Thread Konstantin Kostiuk
the series was merged Best Regards, Konstantin Kostiuk. On Tue, Dec 13, 2022 at 9:20 PM Konstantin Kostiuk wrote: > Reviewed-by: Konstantin Kostiuk > Tested-by: Konstantin Kostiuk > > On Tue, Dec 13, 2022 at 5:13 PM Andrey Drobyshev < > andrey.drobys...@virtuozzo.com> wrote: > >> According

Re: [PATCH 0/2] qemu-ga-win: 'guest-get-fsinfo' command wont query storage devices of bus type USB

2022-12-26 Thread Konstantin Kostiuk
the series was merged Best Regards, Konstantin Kostiuk. On Mon, Nov 21, 2022 at 8:38 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Sun, Nov 20, 2022 at 6:09 PM Kfir Manor wrote: > > > > guest-get-fsinfo won't query storage devices of bus-type USB ( >

Re: [PATCH] qga: Add initial OpenBSD and NetBSD support

2022-12-26 Thread Konstantin Kostiuk
the series was merged Best Regards, Konstantin Kostiuk. On Thu, Nov 17, 2022 at 10:50 AM Konstantin Kostiuk wrote: > Reviewed-by: Konstantin Kostiuk > > On Sun, Nov 13, 2022 at 9:32 PM Philippe Mathieu-Daudé > wrote: > >> On 12/11/22 12:40, Brad Smith wrote: >> > qga: Add initial OpenBSD

Re: [PATCH v5 4/4] x86: re-enable rng seeding via SetupData

2022-12-26 Thread Jason A. Donenfeld
On Mon, Dec 26, 2022 at 03:43:04PM +0100, Jason A. Donenfeld wrote: > On Mon, Dec 26, 2022 at 03:24:07PM +0100, Jason A. Donenfeld wrote: > > Hi, > > > > I'm currently stumped at the moment, so adding linux-mm@ and x86@. Still > > working on it though. Details of where I'm at are below the quote

[PATCH v3 3/7] {hw/i2c,docs/system/arm}: Allwinner TWI/I2C Emulation

2022-12-26 Thread Strahinja Jankovic
This patch implements Allwinner TWI/I2C controller emulation. Only master-mode functionality is implemented. The SPL boot for Cubieboard expects AXP209 PMIC on TWI0/I2C0 bus, so this is first part enabling the TWI/I2C bus operation. Since both Allwinner A10 and H3 use the same module, it is

[PATCH v3 1/7] hw/misc: Allwinner-A10 Clock Controller Module Emulation

2022-12-26 Thread Strahinja Jankovic
During SPL boot several Clock Controller Module (CCM) registers are read, most important are PLL and Tuning, as well as divisor registers. This patch adds these registers and initializes reset values from user's guide. Signed-off-by: Strahinja Jankovic Reviewed-by: Niek Linnenbank ---

[PATCH v3 2/7] hw/misc: Allwinner A10 DRAM Controller Emulation

2022-12-26 Thread Strahinja Jankovic
During SPL boot several DRAM Controller registers are used. Most important registers are those related to DRAM initialization and calibration, where SPL initiates process and waits until certain bit is set/cleared. This patch adds these registers, initializes reset values from user's guide and

[PATCH v3 4/7] hw/misc: AXP209 PMU Emulation

2022-12-26 Thread Strahinja Jankovic
This patch adds minimal support for AXP-209 PMU. Most important is chip ID since U-Boot SPL expects version 0x1. Besides the chip ID register, reset values for two more registers used by A10 U-Boot SPL are covered. Signed-off-by: Strahinja Jankovic --- MAINTAINERS | 2 +

[PATCH v3 5/7] hw/arm: Add AXP209 to Cubieboard

2022-12-26 Thread Strahinja Jankovic
SPL Boot for Cubieboard expects AXP209 connected to I2C0 bus. Signed-off-by: Strahinja Jankovic Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 + hw/arm/cubieboard.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index

[PATCH v3 6/7] hw/arm: Allwinner A10 enable SPL load from MMC

2022-12-26 Thread Strahinja Jankovic
This patch enables copying of SPL from MMC if `-kernel` parameter is not passed when starting QEMU. SPL is copied to SRAM_A. The approach is reused from Allwinner H3 implementation. Tested with Armbian and custom Yocto image. Signed-off-by: Strahinja Jankovic Reviewed-by: Niek Linnenbank ---

[PATCH] coverity: physmem: use simple assertions instead of modelling

2022-12-26 Thread Vladimir Sementsov-Ogievskiy
Unfortunately Coverity doesn't follow the logic aroung "len" and "l" variables in stacks finishing with flatview_{read,write}_continue() and generate a lot of OVERRUN false-positives. When small buffer (2 or 4 bytes) is passed to mem read/write path, Coverity assumes the worst case of sz=8 in

[PATCH v3 0/7] Enable Cubieboard A10 boot SPL from SD card

2022-12-26 Thread Strahinja Jankovic
This patch series adds missing Allwinner A10 modules needed for successful SPL boot: - Clock controller module - DRAM controller - I2C0 controller (added also for Allwinner H3 since it is the same) - AXP-209 connected to I2C0 bus It also updates Allwinner A10 emulation so SPL is copied from

[PATCH v3 7/7] tests/avocado: Add SD boot test to Cubieboard

2022-12-26 Thread Strahinja Jankovic
Cubieboard now can boot directly from SD card, without the need to pass `-kernel` parameter. Update Avocado tests to cover this functionality. Signed-off-by: Strahinja Jankovic --- tests/avocado/boot_linux_console.py | 47 + 1 file changed, 47 insertions(+) diff

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-26 Thread Bin Meng
On Fri, Dec 23, 2022 at 6:04 PM Bin Meng wrote: > > On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza > wrote: > > > > This will make the code more in line with what the other boards are > > doing. We'll also avoid an extra check to machine->kernel_filename since > > we already checked

Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test

2022-12-26 Thread Daniel Henrique Barboza
On 12/26/22 10:56, Bin Meng wrote: On Sat, Dec 24, 2022 at 11:52 AM Bin Meng wrote: Hi, On Fri, Dec 23, 2022 at 2:25 PM Bin Meng wrote: Hi Anup, On Fri, Dec 23, 2022 at 12:56 AM Anup Patel wrote: On Thu, Dec 22, 2022 at 6:27 PM Bin Meng wrote: On Thu, Dec 22, 2022 at 6:47 PM Daniel

Re: [PATCH 10/11] alsaaudio: change default playback settings

2022-12-26 Thread Volker Rümelin
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 5f50dfa0bf..0cc982e61f 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -913,17 +913,14 @@ static void *alsa_audio_init(Audiodev *dev)   alsa_init_per_direction(aopts->in);   alsa_init_per_direction(aopts->out);   -   

Re: [PATCH v5 4/4] x86: re-enable rng seeding via SetupData

2022-12-26 Thread Jason A. Donenfeld
Hi, I'm currently stumped at the moment, so adding linux-mm@ and x86@. Still working on it though. Details of where I'm at are below the quote below. On Sat, Dec 24, 2022 at 05:21:46AM +0100, Jason A. Donenfeld wrote: > On Sat, Dec 24, 2022 at 04:09:08AM +0100, Jason A. Donenfeld wrote: > > Hi

Re: [PATCH v5 4/4] x86: re-enable rng seeding via SetupData

2022-12-26 Thread Jason A. Donenfeld
On Mon, Dec 26, 2022 at 03:24:07PM +0100, Jason A. Donenfeld wrote: > Hi, > > I'm currently stumped at the moment, so adding linux-mm@ and x86@. Still > working on it though. Details of where I'm at are below the quote below. > > On Sat, Dec 24, 2022 at 05:21:46AM +0100, Jason A. Donenfeld

Re: [PATCH] hw/audio/c97: fix abort in audio_calloc()

2022-12-26 Thread Volker Rümelin
Am 25.12.22 um 13:13 schrieb Qiang Liu: Hi Qiang, I didn't receive your email probably because the reverse DNS entry of your mail server isn't setup correctly. This is from the mail header of the qemu-devel mailing list server. X-Host-Lookup-Failed: Reverse DNS lookup failed for

Re: [PATCH] scripts/coverity-scan/model.c: update address_space_*_cached

2022-12-26 Thread Vladimir Sementsov-Ogievskiy
On 12/24/22 14:22, Philippe Mathieu-Daudé wrote: On 23/12/22 21:43, Vladimir Sementsov-Ogievskiy wrote: Make prototypes correspond to their origins. Also drop address_space_rw_cached() which doesn't exist anywhere in the code. Signed-off-by: Vladimir Sementsov-Ogievskiy ---  

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-26 Thread Daniel Henrique Barboza
On 12/26/22 10:49, Bin Meng wrote: On Fri, Dec 23, 2022 at 6:04 PM Bin Meng wrote: On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza wrote: This will make the code more in line with what the other boards are doing. We'll also avoid an extra check to machine->kernel_filename since we

Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test

2022-12-26 Thread Bin Meng
On Sat, Dec 24, 2022 at 11:52 AM Bin Meng wrote: > > Hi, > > On Fri, Dec 23, 2022 at 2:25 PM Bin Meng wrote: > > > > Hi Anup, > > > > On Fri, Dec 23, 2022 at 12:56 AM Anup Patel wrote: > > > > > > On Thu, Dec 22, 2022 at 6:27 PM Bin Meng wrote: > > > > > > > > On Thu, Dec 22, 2022 at 6:47 PM

Re: [PATCH 10/11] alsaaudio: change default playback settings

2022-12-26 Thread Volker Rümelin
Am 21.12.22 um 12:03 schrieb Christian Schoenebeck: On Sunday, December 18, 2022 6:15:38 PM CET Volker Rümelin wrote: The currently used default playback settings in the ALSA audio backend are a bit unfortunate. With a few emulated audio devices, audio playback does not work properly. Here is a

Re: [PATCH 0/2] qga: Add ZFS TRIM support for FreeBSD

2022-12-26 Thread Konstantin Kostiuk
Hi Alexander, Can you please rebase your changes to the current master? I failed to apply these patches. Best Regards, Konstantin Kostiuk. On Tue, Nov 15, 2022 at 8:46 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > Move Linux-specific FS TRIM code to commands-linux.c and add

Re: [PATCH 13/15] hw/riscv/spike.c: simplify create_fdt()

2022-12-26 Thread Daniel Henrique Barboza
On 12/23/22 10:06, Bin Meng wrote: On Thu, Dec 22, 2022 at 2:29 AM Daniel Henrique Barboza wrote: 'mem_size' and 'cmdline' aren't being used and the MachineState pointer is being retrieved via a MACHINE() macro. Remove 'mem_size' and 'cmdline' and add MachineState as a parameter. Why do

[PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState

2022-12-26 Thread Bin Meng
At present for some unknown reason the HTIF registers (fromhost & tohost) are defined in the RISC-V CPUArchState. It should really be put in the HTIFState struct as it is only meaningful to HTIF. Signed-off-by: Bin Meng --- include/hw/char/riscv_htif.h | 8 target/riscv/cpu.h

Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-26 Thread Tobias Röhmel
Thanks for all the help, I learned a lot! Best regards, Tobias On 19.12.22 18:05, Peter Maydell wrote: On Tue, 6 Dec 2022 at 10:25, wrote: From: Tobias Röhmel Sorry for the "Reviewed-by" messup. I missed that on the explanation page. Thanks again for the review :) v6: patch 5: - I also

Re: [PATCH] qga: Add initial OpenBSD and NetBSD support

2022-12-26 Thread Brad Smith
On 12/26/2022 9:02 AM, Konstantin Kostiuk wrote: the series was merged Thank you.

[PATCH 06/12] hw/char: riscv_htif: Remove forward declarations for non-existent variables

2022-12-26 Thread Bin Meng
There are forward declarations for 'vmstate_htif' and 'htif_io_ops' in riscv_htif.h however there are no definitions in the C codes. Signed-off-by: Bin Meng --- include/hw/char/riscv_htif.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/char/riscv_htif.h

[PATCH 02/12] hw/char: riscv_htif: Drop {to, from}host_size in HTIFState

2022-12-26 Thread Bin Meng
These are not used anywhere. Drop them. Signed-off-by: Bin Meng --- include/hw/char/riscv_htif.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h index f888ac1b30..3eccc1914f 100644 --- a/include/hw/char/riscv_htif.h +++

[PATCH v3 3/3] vdpa: commit all host notifier MRs in a single MR transaction

2022-12-26 Thread Longpeng(Mike)
From: Longpeng This allows the vhost-vdpa device to batch the setup of all its MRs of host notifiers. This significantly reduces the device starting time, e.g. the time spend on setup the host notifier MRs reduce from 423ms to 32ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices

[PATCH 11/12] hw/riscv/boot.c: Introduce riscv_find_firmware()

2022-12-26 Thread Bin Meng
Rename previous riscv_find_firmware() to riscv_find_bios(), and introduce a new riscv_find_firmware() to implement the first half part of the work done in riscv_find_and_load_firmware(). This new API is helpful for machine that wants to know the final chosen firmware file name but does not want

[PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments

2022-12-26 Thread Bin Meng
Spike machine now supports OpenSBI plain binary bios image, so the comments are no longer valid. Signed-off-by: Bin Meng --- hw/riscv/spike.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index 8606331f61..ab0a945f8b 100644 --- a/hw/riscv/spike.c

[PATCH 12/12] hw/riscv: spike: Decouple create_fdt() dependency to ELF loading

2022-12-26 Thread Bin Meng
At present create_fdt() calls htif_uses_elf_symbols() to determine whether to insert a property for the HTIF. This unfortunately creates a hidden dependency to riscv_load_{firmware,kernel} that create_fdt() must be called after the ELF {firmware,kernel} image has been loaded. Decouple such

[PATCH v3 1/3] vhost: simplify vhost_dev_enable_notifiers

2022-12-26 Thread Longpeng(Mike)
From: Longpeng Simplify the error path in vhost_dev_enable_notifiers by using vhost_dev_disable_notifiers directly. Signed-off-by: Longpeng --- hw/virtio/vhost.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c

[PATCH v3 0/3] two optimizations to speed up the start time

2022-12-26 Thread Longpeng(Mike)
From: Longpeng Changes v3->v2: - cleanup the code [Philippe] Changes v2->v1: Patch-1: - remove vq_init_count [Jason] Patch-2: - new added. [Jason] v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg922499.html Longpeng (Mike) (3): vhost: simplify vhost_dev_enable_notifiers

[PATCH v3 2/3] vhost: configure all host notifiers in a single MR transaction

2022-12-26 Thread Longpeng(Mike)
From: Longpeng This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices (vdpa_sim_blk, 64vq per

[PATCH 00/12] hw/riscv: Improve Spike HTIF emulation fidelity

2022-12-26 Thread Bin Meng
At present the 32-bit OpenSBI generic firmware image does not boot on Spike, only 64-bit image can. This is due to the HTIF emulation does not implement the proxy syscall interface which is required for the 32-bit HTIF console output. An OpenSBI bug fix [1] is also needed when booting the plain

[PATCH 04/12] hw/char: riscv_htif: Use conventional 's' for HTIFState

2022-12-26 Thread Bin Meng
QEMU source codes tend to use 's' to represent the hardware state. Let's use it for HTIFState. Signed-off-by: Bin Meng --- hw/char/riscv_htif.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/hw/char/riscv_htif.c

[PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers

2022-12-26 Thread Bin Meng
The Spike HTIF is poorly documented. The only relevant info we can get from the internet is from Andrew Waterman at [1]. Add a comment block before htif_handle_tohost_write() to explain the tohost register format, and use meaningful macros intead of magic numbers in the codes. While we are here,

[PATCH 10/12] hw/riscv/boot.c: introduce riscv_default_firmware_name()

2022-12-26 Thread Bin Meng
From: Daniel Henrique Barboza Some boards are duplicating the 'riscv_find_and_load_firmware' call because the 32 and 64 bits images have different names. Create a function to handle this detail instead of hardcoding it in the boards. Ideally we would bake this logic inside

[PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region

2022-12-26 Thread Bin Meng
struct HTIFState has 3 members for address space and memory region, and are initialized during htif_mm_init(). But they are actually useless. Drop them. Signed-off-by: Bin Meng --- include/hw/char/riscv_htif.h | 7 ++- hw/char/riscv_htif.c | 7 ++- hw/riscv/spike.c

[PATCH 09/12] hw/riscv/boot.c: make riscv_find_firmware() static

2022-12-26 Thread Bin Meng
From: Daniel Henrique Barboza The only caller is riscv_find_and_load_firmware(), which is in the same file. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Message-Id:

[PATCH 07/12] hw/char: riscv_htif: Support console output via proxy syscall

2022-12-26 Thread Bin Meng
At present the HTIF proxy syscall is unsupported. On RV32, only device 0 is supported so there is no console device for RV32. The only way to implement console funtionality on RV32 is to support the SYS_WRITE syscall. With this commit, the Spike machine is able to boot the 32-bit OpenSBI generic