[PULL 1/5] scripts/ci: remove unnecessary checks from CentOS playbook

2023-02-07 Thread Paolo Bonzini
Since this playbook is meant for a CentOS 8 install, no need to check the facts. Signed-off-by: Paolo Bonzini --- scripts/ci/org.centos/stream/8/build-environment.yml | 4 1 file changed, 4 deletions(-) diff --git a/scripts/ci/org.centos/stream/8/build-environment.yml

[PULL 2/5] scripts/ci: support CentOS Stream 8 in build-environment.yaml

2023-02-07 Thread Paolo Bonzini
Update the CI playbook so that it is able to prepare a system with a fresh CentOS Stream 8 install, rather than just support RHEL. Signed-off-by: Paolo Bonzini --- scripts/ci/setup/build-environment.yml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PULL 5/5] scripts/ci: bump CentOS Python to 3.8

2023-02-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .../ci/org.centos/stream/8/build-environment.yml | 2 +- scripts/ci/org.centos/stream/8/x86_64/configure| 1 + scripts/ci/setup/build-environment.yml | 14 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git

[PULL 0/5] Update CentOS 8 custom runner to use Python 3.8

2023-02-07 Thread Paolo Bonzini
The following changes since commit b52388129bf0097954515c097e83e6112de1b579: Merge tag 'pull-tcg-20230204' of https://gitlab.com/rth7680/qemu into staging (2023-02-04 19:12:41 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream-py38 for you

[PULL 3/5] scripts/ci: add capstone development packages

2023-02-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- scripts/ci/org.centos/stream/8/build-environment.yml | 9 + scripts/ci/setup/build-environment.yml | 11 +++ 2 files changed, 20 insertions(+) diff --git a/scripts/ci/org.centos/stream/8/build-environment.yml

Re: [RFC PATCH 0/5] Deprecate/rename singlestep command line option

2023-02-07 Thread Thomas Huth
On 07/02/2023 12.01, Peter Maydell wrote: On Mon, 6 Feb 2023 at 20:18, Thomas Huth wrote: On 06/02/2023 18.13, Peter Maydell wrote: The command line option '-singlestep' and its HMP equivalent the 'singlestep' command are very confusingly named, because they have nothing to do with

PSA: git:// access to git.qemu.org has been shut down

2023-02-07 Thread Paolo Bonzini
The only way to access git.qemu.org is now via HTTPS at either https://gitlab.com/qemu-project/qemu or https://git.qemu.org/qemu.git. Paolo

Re: [PATCH v15 06/11] s390x/cpu topology: interception of PTF instruction

2023-02-07 Thread Nina Schoetterl-Glausch
On Tue, 2023-02-07 at 10:59 +0100, Pierre Morel wrote: > > On 2/6/23 19:34, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: > > > When the host supports the CPU topology facility, the PTF > > > instruction with function code 2 is interpreted by the SIE, >

Re: [PATCH 3/3] target: Set `CF_PCREL` for arm and i386 frontends

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 11:43, Anton Johansson via wrote: Signed-off-by: Anton Johansson --- target/arm/cpu-param.h | 2 -- target/arm/cpu.c| 5 + target/i386/cpu-param.h | 4 target/i386/cpu.c | 5 + 4 files changed, 10 insertions(+), 6 deletions(-) Better to split in 2

Re: [PATCH 2/3] Replace `TARGET_TB_PCREL` with `CF_PCREL`

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 11:43, Anton Johansson via wrote: Signed-off-by: Anton Johansson --- accel/tcg/cpu-exec.c| 8 +++ accel/tcg/internal.h| 10 accel/tcg/perf.c| 2 +- accel/tcg/tb-jmp-cache.h| 48 ++---

Re: [RFC PATCH 0/5] Deprecate/rename singlestep command line option

2023-02-07 Thread Peter Maydell
On Mon, 6 Feb 2023 at 20:18, Thomas Huth wrote: > > On 06/02/2023 18.13, Peter Maydell wrote: > > The command line option '-singlestep' and its HMP equivalent > > the 'singlestep' command are very confusingly named, because > > they have nothing to do with single-stepping the guest (either > >

Re: [PATCH v15 05/11] s390x/cpu topology: resetting the Topology-Change-Report

2023-02-07 Thread Nina Schoetterl-Glausch
On Tue, 2023-02-07 at 10:24 +0100, Pierre Morel wrote: > > On 2/6/23 18:52, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: > > > During a subsystem reset the Topology-Change-Report is cleared > > > by the machine. > > > Let's ask KVM to clear the

[PATCH 1/3] include/exec: Introduce `CF_PCREL`

2023-02-07 Thread Anton Johansson via
Adds a new field to TranslationBlock.cflags denoting whether or not the instructions of a given translation block are pc-relative. This field aims to replace the macro `TARGET_TB_PCREL`. Signed-off-by: Anton Johansson --- include/exec/exec-all.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 0/3] Replace TARGET_TB_PCREL with CF_PCREL

2023-02-07 Thread Anton Johansson via
This patchset entirely replaces the macro TARGET_TB_PCREL with a field in TranslationBlock.cflags called CF_PCREL, and is a first step towards removing target-specific assumptions from non-target/ directories. The grand goal is to allow for heterogeneous QEMU binaries consisting of multiple

[PATCH 2/3] Replace `TARGET_TB_PCREL` with `CF_PCREL`

2023-02-07 Thread Anton Johansson via
Signed-off-by: Anton Johansson --- accel/tcg/cpu-exec.c| 8 +++ accel/tcg/internal.h| 10 accel/tcg/perf.c| 2 +- accel/tcg/tb-jmp-cache.h| 48 ++--- accel/tcg/tb-maint.c| 8 +++ accel/tcg/translate-all.c

[PATCH 3/3] target: Set `CF_PCREL` for arm and i386 frontends

2023-02-07 Thread Anton Johansson via
Signed-off-by: Anton Johansson --- target/arm/cpu-param.h | 2 -- target/arm/cpu.c| 5 + target/i386/cpu-param.h | 4 target/i386/cpu.c | 5 + 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h index

Re: [PATCH 4/4] pcie: add trace-point for power indicator transitions

2023-02-07 Thread Vladimir Sementsov-Ogievskiy
Thanks for reviewing! On 05.02.23 13:56, Philippe Mathieu-Daudé wrote: On 4/2/23 18:47, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   hw/pci/pcie.c   | 20   hw/pci/trace-events |  3 +++   2 files changed, 23 insertions(+)

Re: Call for GSoC and Outreachy project ideas for summer 2023

2023-02-07 Thread Alberto Faria
On Tue, Feb 7, 2023 at 10:23 AM Alberto Faria wrote: > On Mon, Feb 6, 2023 at 9:22 PM Stefan Hajnoczi wrote: > > Great that you're interesting, Alberto! Both sound feasible. I would > > like to co-mentor the zoned storage project or can at least commit to > > being available to help because

Re: Call for GSoC and Outreachy project ideas for summer 2023

2023-02-07 Thread Alberto Faria
On Mon, Feb 6, 2023 at 9:22 PM Stefan Hajnoczi wrote: > Great that you're interesting, Alberto! Both sound feasible. I would > like to co-mentor the zoned storage project or can at least commit to > being available to help because zoned storage is currently on my mind > anyway :). Perfect, I'll

Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

2023-02-07 Thread Andrew Jones
On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote: > On 6/2/23 11:54, Andrea Bolognani wrote: > > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote: > > > +object_class_property_add(oc, "acpi", "OnOffAuto", > > > + virt_get_acpi,

Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

2023-02-07 Thread Andrew Jones
On Tue, Feb 07, 2023 at 09:50:29AM +0100, Philippe Mathieu-Daudé wrote: > On 6/2/23 13:56, Gerd Hoffmann wrote: > > On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote: > > > On 6/2/23 11:54, Andrea Bolognani wrote: > > > > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L

Re: [QEMU][PATCH v5 00/10] Introduce xenpvh machine for arm architecture

2023-02-07 Thread David Woodhouse
On Tue, 2023-01-31 at 14:51 -0800, Vikram Garhwal wrote: > > Hi, > This series add xenpvh machine for aarch64. Motivation behind creating xenpvh > machine with IOREQ and TPM was to enable each guest on Xen aarch64 to have > it's > own unique and emulated TPM. > > This series does following: >   

[PULL 12/25] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-02-07 Thread Cédric Le Goater
From: Peter Delevoryas Allows users to specify binary data to initialize an EEPROM, allowing users to emulate data programmed at manufacturing time. - Added init_rom and init_rom_size attributes to TYPE_AT24C_EE - Added at24c_eeprom_init_rom helper function to initialize attributes - If -drive

[PULL 19/25] hw/arm/aspeed_ast10x0: Add various unimplemented peripherals

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Based on booting Zephyr demo from [1] running QEMU with '-d unimp' and checking missing devices in [2]. [1] https://github.com/AspeedTech-BMC/zephyr/releases/tag/v00.01.07 [2] https://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/dts/arm/aspeed/ast10x0.dtsi

[PULL 08/25] tests/avocado/machine_aspeed.py: Mask systemd services to speed up SDK boot

2023-02-07 Thread Cédric Le Goater
Reviewed-by: Joel Stanley Message-Id: <20230119123449.531826-8-...@kaod.org> Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py

[PULL 21/25] hw/arm/aspeed_ast10x0: Map the secure SRAM

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Some SRAM appears to be used by the Secure Boot unit and crypto accelerators. Name it 'secure sram'. Note, the SRAM base address was already present but unused (the 'SBC' index is used for the MMIO peripheral). Interestingly using CFLAGS=-Winitializer-overrides

[PULL 13/25] hw/arm/aspeed: Add aspeed_eeprom.c

2023-02-07 Thread Cédric Le Goater
From: Peter Delevoryas - Create aspeed_eeprom.c and aspeed_eeprom.h - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files - Include aspeed_eeprom.h in aspeed.c - Add fby35_bmc_fruid data - Use new at24c_eeprom_init_rom helper to initialize BMC FRUID EEPROM with data from

[PULL 03/25] aspeed: Add Supermicro X11 SPI machine type

2023-02-07 Thread Cédric Le Goater
From: Guenter Roeck supermicrox11-bmc is configured with ast2400-a1 SoC. This does not match the Supermicro documentation for X11 BMCs, and it does not match the devicetree file in the Linux kernel. As it turns out, some Supermicro X11 motherboards use AST2400 SoCs, while others use AST2500.

[PULL 01/25] tests/avocado: Introduce file_truncate()

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20230120134314.81956-2-phi...@linaro.org [ clg: remove image_pow2ceil_expand() factoring ] Signed-off-by: Cédric Le Goater --- tests/avocado/boot_linux_console.py | 5 + 1 file changed, 5

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-07 Thread Thomas Huth
On 06/02/2023 15.50, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 02:09:57PM +0100, Thomas Huth wrote: On 06/02/2023 13.49, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology

Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

2023-02-07 Thread Sunil V L
On Tue, Feb 07, 2023 at 09:50:29AM +0100, Philippe Mathieu-Daudé wrote: > On 6/2/23 13:56, Gerd Hoffmann wrote: > > On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote: > > > On 6/2/23 11:54, Andrea Bolognani wrote: > > > > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L

[PULL 00/25] aspeed queue

2023-02-07 Thread Cédric Le Goater
The following changes since commit 6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b: Merge tag 'pull-ppc-20230205' of https://gitlab.com/danielhb/qemu into staging (2023-02-05 16:49:09 +) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20230207

[PULL 20/25] hw/arm/aspeed_ast10x0: Map I3C peripheral

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Since I don't have access to the datasheet, the relevant values were found in: https://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/dts/arm/aspeed/ast10x0.dtsi Reviewed-by: Peter Delevoryas Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater

[PULL 11/25] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-02-07 Thread Cédric Le Goater
From: Peter Delevoryas aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard Link:

Re: [PATCH v4 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-02-07 Thread Christian Schoenebeck
On Monday, February 6, 2023 6:37:16 AM CET Shi, Guohuai wrote: [...] > > I know, it's an n-square performance issue and what I already wrote in the > > summary of the linked original suggestion [1] in v3 before, quote: > > > > + Relatively straight-forward to implement. > > > > + No (major)

[PULL 15/25] hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize'

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region sizes at larger offsets. Here we are interested in the I/O region size, so rename as

[PULL 17/25] hw/watchdog/wdt_aspeed: Log unimplemented registers as UNIMP level

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Add more Aspeed watchdog registers from [*]. Since guests can righteously access them, log the access at 'unimplemented' level instead of 'guest-errors'. [*] https://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/drivers/watchdog/wdt_aspeed.c#L31 Signed-off-by:

[PULL 05/25] avocado/boot_linux_console.py: Update ast2600 test

2023-02-07 Thread Cédric Le Goater
From: Joel Stanley Update the test_arm_ast2600_debian test to - the latest Debian kernel - use the Rainier machine instead of Tacoma Both of which contains support for more hardware and thus exercises more of the hardware Qemu models. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le

[PULL 06/25] m25p80: Add the is25wp256 SFPD table

2023-02-07 Thread Cédric Le Goater
From: Guenter Roeck Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2: xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp Cc: Michael Walle Cc: Tudor Ambarus Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Reviewed-by:

[PULL 23/25] hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé This SoC uses a Cortex-M4F. QEMU only implements a M4, which is good enough. Add a TODO note in case the M4F is added. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater ---

Re: [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-07 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> The QERR_ macros are leftovers from the days of "rich" error objects. >> We've been trying to reduce their remaining use. >> >> Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat >> imprecise error message >> >> (qemu)

[PULL 16/25] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé When booting the Zephyr demo in [1] we get: aspeed.io: unimplemented device write (size 4, offset 0x185128, value 0x030f1ff1) <-- aspeed.io: unimplemented device write (size 4, offset 0x18512c, value 0x03f1) This corresponds to this Zephyr code [2]:

[PULL 07/25] tests/avocado/machine_aspeed.py: update buildroot tests

2023-02-07 Thread Cédric Le Goater
Use buildroot 2022.11 based images plus some customization : - Linux version is bumped to 6.0.9 and kernel is built with a custom config similar to what OpenBMC provides. - U-Boot is switched to the one provided by OpenBMC for better support. - defconfigs includes more target tools for

[PULL 18/25] hw/misc/aspeed_hace: Do not crash if address_space_map() failed

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé address_space_map() can fail: uart:~$ hash test sha256_test tv[0]: Segmentation fault: 11 Thread 3 "qemu-system-arm" received signal SIGSEGV, Segmentation fault. gen_acc_mode_iov (req_len=0x718b7778, id=, iov=0x718b7780, s=0x56ce0bd0)

[PULL 09/25] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr

2023-02-07 Thread Cédric Le Goater
These globals were moved to MachineClass by commit 71ae9e94d9 ("pc: Move option_rom_has_mr/rom_file_has_mr globals to MachineClass"). Finish cleanup. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley Signed-off-by:

[PULL 24/25] tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 board

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Add a very quick test that runs some commands in a Zephyr shell: $ tests/venv/bin/avocado --show=app,console run -t os:zephyr tests/avocado (2/2) tests/avocado/machine_aspeed.py:AST1030Machine.test_ast1030_zephyros_1_07: console: *** Booting Zephyr OS build

[PULL 14/25] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-02-07 Thread Cédric Le Goater
From: Peter Delevoryas EEPROM's are a form of non-volatile memory. After power-cycling an EEPROM, I would expect the I2C state machine to be reset to default values, but I wouldn't really expect the memory to change at all. The current implementation of the at24c EEPROM resets its internal

[PULL 25/25] aspeed/sdmc: Drop unnecessary scu include

2023-02-07 Thread Cédric Le Goater
From: Joel Stanley The model includes aspeed_scu.h but doesn't appear to require it. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230124062022.298230-1-j...@jms.id.au> Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_sdmc.c

[PULL 04/25] hw/net: Fix read of uninitialized memory in ftgmac100

2023-02-07 Thread Cédric Le Goater
From: Stephen Longfield With the `size += 4` before the call to `crc32`, the CRC calculation would overrun the buffer. Size is used in the while loop starting on line 1009 to determine how much data to write back, with the last four bytes coming from `crc_ptr`, so do need to increase it, but

[PULL 22/25] hw/arm/aspeed_ast10x0: Map HACE peripheral

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Since I don't have access to the datasheet, the relevant values were found in: https://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/dts/arm/aspeed/ast10x0.dtsi Before on Zephyr: uart:~$ hash test sha256_test tv[0]:hash_final error sha384_test

[PULL 02/25] tests/avocado: Truncate M2S-FG484 SOM SPI flash to 16MiB

2023-02-07 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé The M2S-FG484 SOM uses a 16 MiB SPI flash (Spansion S25FL128SDPBHICO). Since the test asset is bigger, truncate it to the correct size to avoid when running the test_arm_emcraft_sf2 test: qemu-system-arm: device requires 16777216 bytes, block backend provides

[PULL 10/25] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-02-07 Thread Cédric Le Goater
From: Peter Delevoryas This helper is useful in board initialization because lets users initialize and realize an EEPROM on an I2C bus with a single function call. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard Link:

Re: [PATCH v15 06/11] s390x/cpu topology: interception of PTF instruction

2023-02-07 Thread Pierre Morel
On 2/6/23 19:34, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by

Re: [PATCH] target/riscv: Remove .min_priv_ver restriction from RVV CSRs

2023-02-07 Thread Bin Meng
On Tue, Feb 7, 2023 at 4:45 PM wrote: > > From: Frank Chang > > The RVV specification does not require that the core needs to support > the privileged specification v1.12.0 to support RVV, and there is no > dependency from ISA level. This commit removes the restriction. > > Signed-off-by: Frank

Re: [PATCH] char: do not double-close fd when failing to add client

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 10:35, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The caller is already closing the fd on failure. Fixes: c3054a6e6a ("char: Factor out qmp_add_client() parts and move to chardev/") Signed-off-by: Marc-André Lureau --- chardev/char.c | 2 -- 1 file changed, 2

Re: vhost-user (virtio-fs) migration: back end state

2023-02-07 Thread Hanna Czenczek
On 06.02.23 22:02, Juan Quintela wrote: Stefan Hajnoczi wrote: On Mon, 6 Feb 2023 at 07:36, Hanna Czenczek wrote: Hi Stefan, For true virtio-fs migration, we need to migrate the daemon’s (back end’s) state somehow. I’m addressing you because you had a talk on this topic at KVM Forum 2021.

[PATCH] char: do not double-close fd when failing to add client

2023-02-07 Thread marcandre . lureau
From: Marc-André Lureau The caller is already closing the fd on failure. Fixes: c3054a6e6a ("char: Factor out qmp_add_client() parts and move to chardev/") Signed-off-by: Marc-André Lureau --- chardev/char.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/chardev/char.c b/chardev/char.c

Re: [PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2023-02-07 Thread Cédric Le Goater
[ Cc: Titus, since he is maintainer of some sensor models already ] On 2/7/23 07:51, Philippe Mathieu-Daudé wrote: On 7/2/23 00:24, Hao Wu wrote: Hi, It seems like this patch set is reviewed but never merged. Who should take this patch set? What are our next steps for them? Having some

Re: [PATCH] MAINTAINERS: add myself maintainer for the clock framework

2023-02-07 Thread Philippe Mathieu-Daudé
On 11/2/21 09:53, Luc Michel wrote: Also add Damien as a reviewer. Signed-off-by: Luc Michel --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) +Clock framework +M: Luc Michel +R: Damien Hedde FTR Damien address is bouncing. +S: Maintained +F: include/hw/clock.h +F:

Re: [PATCH v15 05/11] s390x/cpu topology: resetting the Topology-Change-Report

2023-02-07 Thread Pierre Morel
On 2/6/23 18:52, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: During a subsystem reset the Topology-Change-Report is cleared by the machine. Let's ask KVM to clear the Modified Topology Change Report (MTCR) bit of the SCA in the case of a subsystem

Re: [PULL 03/38] pflash: Only read non-zero parts of backend image

2023-02-07 Thread Cédric Le Goater
On 2/7/23 09:38, Kevin Wolf wrote: Am 06.02.2023 um 16:54 hat Cédric Le Goater geschrieben: On 1/20/23 13:25, Kevin Wolf wrote: From: Xiang Zheng Currently we fill the VIRT_FLASH memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a

Re: [PATCH 0/4] hw: QOM housekeeping around IOTHREAD / IRQ types

2023-02-07 Thread Philippe Mathieu-Daudé
Hi Peter, On 13/1/23 21:01, Philippe Mathieu-Daudé wrote: - remove unused code - use recent QOM macros - use CamelCase typedef Philippe Mathieu-Daudé (4): iothread: Remove unused IOThreadClass / IOTHREAD_CLASS hw/irq: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() hw/or-irq:

Re: [PATCH] MAINTAINERS: Cover RCU documentation

2023-02-07 Thread Philippe Mathieu-Daudé
Ping? On 19/1/23 11:26, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fe50d01e3..73e9cb33f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2812,6 +2812,8 @@ F:

Re: vhost-user (virtio-fs) migration: back end state

2023-02-07 Thread Hanna Czenczek
On 06.02.23 17:27, Stefan Hajnoczi wrote: On Mon, 6 Feb 2023 at 07:36, Hanna Czenczek wrote: Hi Stefan, For true virtio-fs migration, we need to migrate the daemon’s (back end’s) state somehow. I’m addressing you because you had a talk on this topic at KVM Forum 2021. :) As far as I

Re: [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > The stubbed out Rocker monitor commands are the last remaining users > of QERR_FEATURE_DISABLED. They fail like this: > > (qemu) info rocker

Re: [PATCH] MAINTAINERS: add myself to ui/ and audio/

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 09:56, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Helping out with patch review & queue handling. Thanks! Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Marc-André Lureau --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat > imprecise error message > > (qemu) x_colo_lost_heartbeat > Error:

Re: [PATCH v2 07/10] hw/ide/piix: Require an ISABus only for user-created instances

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 00:40, Bernhard Beschow wrote: Am 5. Februar 2023 22:32:03 UTC schrieb Mark Cave-Ayland : On 05/02/2023 22:21, BALATON Zoltan wrote: On Sun, 5 Feb 2023, Mark Cave-Ayland wrote: On 26/01/2023 21:17, Bernhard Beschow wrote: Internal instances now defer interrupt wiring to the caller

[PATCH] MAINTAINERS: add myself to ui/ and audio/

2023-02-07 Thread marcandre . lureau
From: Marc-André Lureau Helping out with patch review & queue handling. Signed-off-by: Marc-André Lureau --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa10ecaeb9..337a7d8857 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2478,6 +2478,7

Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. > This macro never existed. The reference got added in commit > e3d4d25206a "guest agent: add guest agent RPCs/commands" along with > QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, >

Re: [PATCH 07/12] hw/acpi: Move QMP command to hw/core/

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > qmp_query_vm_generation_id() in stubs/vmgenid.c is the last user of > QERR_UNSUPPORTED outside qga/. Unlike the stubs we just dropped, it > is

Re: [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > acpi_table_add() is only ever called on behalf of CLI option > -acpitable. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386, > it is

Re: [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > smbios_entry_add() is only ever called on behalf of CLI option > -smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 | >

Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

2023-02-07 Thread Philippe Mathieu-Daudé
On 6/2/23 13:56, Gerd Hoffmann wrote: On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote: On 6/2/23 11:54, Andrea Bolognani wrote: On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote: +object_class_property_add(oc, "acpi", "OnOffAuto", +

Re: [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague > error message > > (qemu) nmi > Error: this feature or command is not

Re: [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The only way cpu_get_note_size() can return a negative value is > integer overflow in the non-stub versions, which is a programming > error. The stub version is not actually reachable, because the > cpu_get_dump_info() stub will fail first. Use assert(). This gets >

Re: [PATCH 02/12] dump: Improve error message when target doesn't support memory dump

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague > error message > > (qemu) dump-guest-memory mumble > Error: this

Re: [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h"

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > authz/listfile.c | 1 - > backends/cryptodev-vhost.c | 1 - > backends/rng.c | 1 - > backends/vhost-user.c | 1 - > block/backup.c | 1 - > block/commit.c

[PATCH] target/riscv: Remove .min_priv_ver restriction from RVV CSRs

2023-02-07 Thread frank . chang
From: Frank Chang The RVV specification does not require that the core needs to support the privileged specification v1.12.0 to support RVV, and there is no dependency from ISA level. This commit removes the restriction. Signed-off-by: Frank Chang --- target/riscv/csr.c | 21

[PATCH] x86: Don't add RNG seed to Linux cmdline for SEV guests

2023-02-07 Thread Dov Murik
Recent feature to supply RNG seed to the guest kernel modifies the kernel command-line by adding extra data at its end; this breaks measured boot with SEV and OVMF, and possibly signed boot. Specifically SEV doesn't miss this feature because it uses UEFI/OVMF which has its own way of getting

Re: [PATCH 00/12] error: Reduce qerror.h usage a bit more

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 08:51, Markus Armbruster wrote: This series gets rid of two out of 15 remaining QERR_ macros and confines use of one more to qga/. Bonus: better error messages. Markus Armbruster (12): error: Drop superfluous #include "qapi/qmp/qerror.h" dump: Improve error message when target

Re: [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 08:51, Markus Armbruster wrote: The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_FEATURE_DISABLED, and improve the slightly awkward error message (qemu) info hotpluggable-cpus

Re: [PATCH 09/12] replay: Simplify setting replay blockers

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 08:51, Markus Armbruster wrote: replay_add_blocker() takes an Error *. All callers pass one created like this: error_setg(, QERR_REPLAY_NOT_SUPPORTED, "some feature"); Folding this into replay_add_blocker() simplifies the callers, losing a bit of generality we haven't needed in

Re: [PULL 03/38] pflash: Only read non-zero parts of backend image

2023-02-07 Thread Kevin Wolf
Am 06.02.2023 um 16:54 hat Cédric Le Goater geschrieben: > On 1/20/23 13:25, Kevin Wolf wrote: > > From: Xiang Zheng > > > > Currently we fill the VIRT_FLASH memory space with two 64MB NOR images > > when using persistent UEFI variables on virt board. Actually we only use > > a very

Re: [PATCH 02/12] dump: Improve error message when target doesn't support memory dump

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 08:51, Markus Armbruster wrote: The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague error message (qemu) dump-guest-memory mumble Error:

<    1   2   3   4