[PATCH] hw/ide/ahci: trace ncq write command as write instead of read

2023-02-17 Thread Fiona Ebner
Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events") Signed-off-by: Fiona Ebner --- Or should it be sorted alphabetically below execute_ncq_command_unsup? I felt read and write belong close together and this reflects the positions in the code. hw/ide/ahci.c | 4 ++--

Re: [PATCH 2/5] spapr/ddw: Remove confuse return value in spapr_phb_get_free_liobn()

2023-02-17 Thread Daniel Henrique Barboza
On 2/16/23 09:25, Philippe Mathieu-Daudé wrote: The '1' returned value isn't used because spapr_phb_get_free_liobn_cb() isn't called recursively (it is only called once in spapr_phb_get_free_liobn()). The next commit will convert object_child_foreach() handlers to return a boolean indicating

[PATCH v2 4/5] hw/nvme: basic directives support

2023-02-17 Thread Jesper Devantier
From: Gollu Appalanaidu Add support for the Directive Send and Recv commands and the Identify directive. Signed-off-by: Klaus Jensen Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 40 +++- hw/nvme/nvme.h | 2 ++ include/block/nvme.h |

[PATCH v2 5/5] hw/nvme: flexible data placement emulation

2023-02-17 Thread Jesper Devantier
From: Jesper Devantier Add emulation of TP4146 ("Flexible Data Placement"). Signed-off-by: Jesper Devantier Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 703 ++- hw/nvme/ns.c | 142 + hw/nvme/nvme.h | 85 +-

[PATCH v2 2/5] hw/nvme: store a pointer to the NvmeSubsystem in the NvmeNamespace

2023-02-17 Thread Jesper Devantier
From: Niklas Cassel Each NvmeNamespace can be used by serveral controllers, but a NvmeNamespace can at most belong to a single NvmeSubsystem. Store a pointer to the NvmeSubsystem, if the namespace was realized with a NvmeSubsystem. Signed-off-by: Niklas Cassel Signed-off-by: Klaus Jensen ---

[PATCH v2 3/5] hw/nvme: add basic endurance group support

2023-02-17 Thread Jesper Devantier
From: Klaus Jensen Add the mandatory Endurance Group identify data structures and log pages. For now, all namespaces in a subsystem belongs to a single Endurance Group. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 48 +++- hw/nvme/ns.c

[PATCH v2 1/5] hw/nvme: move adjustment of data_units{read,written}

2023-02-17 Thread Jesper Devantier
From: Joel Granados In order to return the units_{read/written} required by the SMART log we need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply by 1000. This is a prep patch that moves this adjustment to where the SMART log is calculated in order to use the stats struct

Re: [PATCH v1 0/2] vhost: memslot handling improvements

2023-02-17 Thread Michael S. Tsirkin
On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote: > Following up on my previous work to make virtio-mem consume multiple > memslots dynamically [1] that requires precise accounting between used vs. > reserved memslots, I realized that vhost makes this extra hard by > filtering out

Re: [PATCH v1 0/2] vhost: memslot handling improvements

2023-02-17 Thread David Hildenbrand
On 17.02.23 15:20, Michael S. Tsirkin wrote: On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote: Following up on my previous work to make virtio-mem consume multiple memslots dynamically [1] that requires precise accounting between used vs. reserved memslots, I realized that

Re: [PATCH v3 08/10] qmp: teach 'getfd' to import sockets on win32

2023-02-17 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > A process with enough capabilities can duplicate a socket to QEMU. > Modify 'getfd' to import it and add it to the monitor fd list, so it can > be later used by other commands. > > Note that we actually store the SOCKET in the FD

Re: [PATCH v2] Adding new machine Tiogapass in QEMU

2023-02-17 Thread karthikeyan Pasupathi
Noted. Thanks, Cédric On Fri, Feb 17, 2023 at 1:19 PM Cédric Le Goater wrote: > Hello Karthikeyan, > > On 2/16/23 19:43, Karthikeyan Pasupathi wrote: > > This patch support Tiogapass in QEMU environment. > > and introduced EEPROM BMC FRU data support "add tiogapass_bmc_fruid data" > > along

[PATCH] vhost: svq: fix uninitialized variable

2023-02-17 Thread Laurent Vivier
The problem has been reported by gcc with CFLAGS=-O3: .../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’: .../hw/virtio/vhost-shadow-virtqueue.c:538:12: error: ‘len’ may be used uninitialized [-Werror=maybe-uninitialized] 538 | return len; |^~~

Re: Proposed way forward Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Paolo Bonzini
On 2/17/23 12:37, Daniel P. Berrangé wrote: So basically I'm suggesting we take a combination of John's series here, and Paolo's series. John's last patch would change so that our dockerfiles grab docutils with pip instead of disabling docs build on centos8. Then look at introducing the use of

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Stefan Weil via
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: Which 32-bit hosts are still useful, and why? Citing my previous mail: I now checked all downloads of the latests installers since 2022-12-30. qemu-w32-setup-20221230.exe – 509 different IP addresses

Re: CXL 2.0 memory pooling emulation

2023-02-17 Thread Jonathan Cameron via
On Thu, 16 Feb 2023 15:52:31 -0500 Gregory Price wrote: > On Thu, Feb 16, 2023 at 06:00:57PM +, Jonathan Cameron wrote: > > On Wed, 15 Feb 2023 04:10:20 -0500 > > Gregory Price wrote: > > > > > On Wed, Feb 15, 2023 at 03:18:54PM +, Jonathan Cameron via wrote: > > > > On Wed, 8 Feb

[PATCH 0/2] hw/timer: Reduce 'hw/ptimer.h' inclusion

2023-02-17 Thread Philippe Mathieu-Daudé
Yet another "try to reduce build-time" series. Philippe Mathieu-Daudé (2): qemu/typedefs: Sort in case-insensitive alphabetical order (again) hw/timer: Reduce 'hw/ptimer.h' inclusion hw/display/xlnx_dp.c | 1 + hw/net/can/xlnx-zynqmp-can.c | 1 +

[PATCH 2/2] hw/timer: Reduce 'hw/ptimer.h' inclusion

2023-02-17 Thread Philippe Mathieu-Daudé
"hw/ptimer.h" API is mostly used by timer / watchdog device models. Since the SoC / machines only access the ptimer via reference, they don't need its definition: the declartion is enough. On order to reduce the inclusion on the source files, forward-declare 'ptimer_state' in "qemu/typedefs.h".

Proposed way forward Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Daniel P . Berrangé
On Thu, Feb 09, 2023 at 07:31:40PM -0500, John Snow wrote: > Howdy, this series increases our minimum python version to 3.7. ..snip... So based on the discussion in this thread I see the following as the key take aways: * Use of newer Meson feature We need newer meson in order to

Re: Lost partition tables on ide-hd + ahci drive

2023-02-17 Thread Fiona Ebner
Am 16.02.23 um 17:15 schrieb Mike Maslenkin: > Makes sense for disks without partition table. > But wouldn't Linux or any other OS write at least 4K bytes in that case? Yes, it does here. > Who may want to write 512 bytes for any purposes except for boot > sector nowadays.. >From a quick test,

[PATCH 1/2] qemu/typedefs: Sort in case-insensitive alphabetical order (again)

2023-02-17 Thread Philippe Mathieu-Daudé
Following the recommendation added in commit a98c370c46 ("typedefs: (Re-)sort entries alphabetically"), and similarly to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort again the type definitions (in case-insensitive alphabetical order, using 'sort --ignore-case'). Signed-off-by:

[PATCH v1 2/2] hw: allwinner-i2c: Fix TWI_CNTR_INT_FLAG

2023-02-17 Thread qianfanguijin
From: qianfan Zhao TWI_CNTR_INT_FLAG is W1C(write 1 to clear and write 0 has non-effect) register, we should lower interrupt when the guest write this bit. The linux kernel will hang in irq handler(mv64xxx_i2c_intr) if no device connected on the i2c bus, next is the trace log: [7.004130]

[PATCH v1 1/2] hw: allwinner-i2c: Make the trace message more readable

2023-02-17 Thread qianfanguijin
From: qianfan Zhao Next is an example when allwinner_i2c_rw enabled: allwinner_i2c_rw write CNTR[0x0c]: 50 { M_STP BUS_EN } allwinner_i2c_rw write CNTR[0x0c]: e4 { A_ACK M_STA BUS_EN INT_EN } allwinner_i2c_rw read CNTR[0x0c]: cc { A_ACK INT_FLAG BUS_EN INT_EN } allwinner_i2c_rw read

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? Which 32-bit hosts does Linux still

Re: [PULL 02/10] fuzz: add fuzz_reset API

2023-02-17 Thread Darren Kenny
I know this is a pull request, but if you prefer to have all the patches with and R-b, you can add mine here too, but I'll leave it up to you. Reviewed-by: Darren Kenny Thanks, Darren. On Thursday, 2023-02-16 at 23:08:47 -05, Alexander Bulekov wrote: > As we are converting most fuzzers to

Re: QAPI unions as branches / unifying struct and union types

2023-02-17 Thread Het Gala
On 14/02/23 3:46 pm, Markus Armbruster wrote: Het Gala writes: On 10/02/23 12:54 pm, Markus Armbruster wrote: Daniel P. Berrangé writes: [...] +## +# @MigrateAddress: +# +# The options available for communication transport mechanisms for migration +# +# Since 8.0 +## +{ 'union' :

Re: [PATCH] vhost: svq: fix uninitialized variable

2023-02-17 Thread Eugenio Perez Martin
On Fri, Feb 17, 2023 at 11:42 AM Laurent Vivier wrote: > > The problem has been reported by gcc with CFLAGS=-O3: > > .../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’: > .../hw/virtio/vhost-shadow-virtqueue.c:538:12: > error: ‘len’ may be used uninitialized

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > > > Which 32-bit hosts are still useful, and why? > > > Citing my previous mail: > >I now checked all downloads of the latests installers since 2022-12-30. >

Re: [PATCH v1 0/2] vhost: memslot handling improvements

2023-02-17 Thread David Hildenbrand
On 16.02.23 17:04, Stefan Hajnoczi wrote: Acked-by: Stefan Hajnoczi Thanks! -- Thanks, David / dhildenb

Re: [PATCH v3] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-17 Thread Christian Schoenebeck
On Friday, February 17, 2023 8:11:43 AM CET Dorinda Bassey wrote: > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > both an audio sink and source. This backend is available on most systems > > Add Pipewire entry points for QEMU Pipewire audio backend > Add wrappers for

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 10:06:49AM +0100, Markus Armbruster wrote: > Thomas Huth writes: > > > On 15/02/2023 20.05, Markus Armbruster wrote: > >> The discussion under PATCH 6 makes me think there's a bit of confusion > >> about the actual impact of dropping support for Python 3.6. Possibly > >>

Re: Lost partition tables on ide-hd + ahci drive

2023-02-17 Thread Aaron Lauterer
I am a bit late, but nonetheless, some comments inline. On 2/15/23 11:53, Fiona Ebner wrote: Am 14.02.23 um 19:21 schrieb John Snow: On Thu, Feb 2, 2023 at 7:08 AM Fiona Ebner wrote: Hi, over the years we've got 1-2 dozen reports[0] about suddenly missing/corrupted MBR/partition tables. The

Re: [PATCH 00/23] block: Lock the graph, part 2 (BlockDriver callbacks)

2023-02-17 Thread Emanuele Giuseppe Esposito
Am 03/02/2023 um 16:21 schrieb Kevin Wolf: > After introducing the graph lock in a previous series, this series > actually starts making widespread use of it. > > Most of the BlockDriver callbacks access the children list in some way, > so you need to hold the graph lock to call them. The

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Claudio Fontana
On 1/30/23 12:44, Thomas Huth wrote: > Testing 32-bit host OS support takes a lot of precious time during the QEMU > contiguous integration tests, and considering that many OS vendors stopped > shipping 32-bit variants of their OS distributions and most hardware from > the past >10 years is

[PATCH v2 0/5] Support Flexible Data Placement (FDP)

2023-02-17 Thread Jesper Devantier
From: Jesper Wendel Devantier Flexible Data Placement (FDP) is a newly introduced enhancement of the NVM command set introduced by the NVM Express, Inc. organization as TP 4146. FDP aims to extend the NVM command set to enable host-guided data placement. FDP-enabled namespaces can be used as

Re: [PATCH v2 0/2] fix for #285

2023-02-17 Thread Emilio Cota
Ping. This fixes a bug (admittedly with a big hammer) that affects users with heavily multi-threaded user-mode workloads. Thanks, Emilio On Sun, Feb 05, 2023 at 11:37:56 -0500, Emilio Cota wrote: > Changes since v1: > > - Add configure check to only use QTree if Glib still

Re: [PATCH v2 01/13] vdpa net: move iova tree creation from init to start

2023-02-17 Thread Eugenio Perez Martin
On Fri, Feb 17, 2023 at 8:39 AM Si-Wei Liu wrote: > > > > On 2/15/2023 11:35 PM, Eugenio Perez Martin wrote: > > On Thu, Feb 16, 2023 at 3:15 AM Si-Wei Liu wrote: > >> > >> > >> On 2/14/2023 11:07 AM, Eugenio Perez Martin wrote: > >>> On Tue, Feb 14, 2023 at 2:45 AM Si-Wei Liu wrote: > >

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Thomas Huth
On 17/02/2023 10.06, Markus Armbruster wrote: Thomas Huth writes: ... My view on all this is a bit more pragmatic. For a human developer, the difference between "dnf install python-sphinx" and "pip install sphinx" is, in my opinion, close to negligible. Really no comparison to "git-clone

Re: [PATCH v2 3/3] virtio-scsi: reset SCSI devices from main loop thread

2023-02-17 Thread Kevin Wolf
Am 10.02.2023 um 15:32 hat Stefan Hajnoczi geschrieben: > When an IOThread is configured, the ctrl virtqueue is processed in the > IOThread. TMFs that reset SCSI devices are currently called directly > from the IOThread and trigger an assertion failure in blk_drain(): > >

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Markus Armbruster
I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why? Please note my question is not about the cost of keeping them (or savings from not keeping them), it's about the

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Markus Armbruster
Stefan Weil writes: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > >> Which 32-bit hosts are still useful, and why? > > > Citing my previous mail: > >I now checked all downloads of the latests installers since 2022-12-30. > >qemu-w32-setup-20221230.exe – 509

Re: [PATCH] vhost: svq: fix uninitialized variable

2023-02-17 Thread Laurent Vivier
On 2/17/23 12:24, Eugenio Perez Martin wrote: On Fri, Feb 17, 2023 at 11:42 AM Laurent Vivier wrote: The problem has been reported by gcc with CFLAGS=-O3: .../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’: .../hw/virtio/vhost-shadow-virtqueue.c:538:12: error: ‘len’ may be

Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of read

2023-02-17 Thread Philippe Mathieu-Daudé
On 17/2/23 11:31, Fiona Ebner wrote: Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events") Oops Signed-off-by: Fiona Ebner --- Or should it be sorted alphabetically below execute_ncq_command_unsup? No, there is no convention... I felt read and write belong close together and

[RFC PATCH] docs/about/build-platforms: Refine the distro support policy

2023-02-17 Thread Thomas Huth
Our distro support policy has been written with a best-effort estimation of what users and developers need. However, as we now know, the support for older long-term distributions can get really troublesome for upstream development, since it is for example close to impossible to keep the code for

Re: Lost partition tables on ide-hd + ahci drive

2023-02-17 Thread Fiona Ebner
Am 16.02.23 um 15:17 schrieb Mike Maslenkin: > Does additional comparison make a sense here: check for LBA == 0 and > then check MBR signature bytes. > Additionally it’s easy to check buffer_is_zero() result or even print > FIS contents under these conditions. > Data looks like a part of guest

[PULL 17/22] block: Assert non-coroutine context for bdrv_open_inherit()

2023-02-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-14-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito Reviewed-by: Hanna Czenczek Signed-off-by: Kevin Wolf --- block.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index

[PULL 22/22] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-17 Thread Kevin Wolf
From: Andrey Zhadchenko The last return statement should return true, as we already evaluated that start == next_dirty Also, fix hbitmap_status() description in header Cc: qemu-sta...@nongnu.org Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()") Signed-off-by:

[PULL 19/22] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-17 Thread Kevin Wolf
From: Stefano Garzarella bdrv_append() is called with bs_top AioContext held, but bdrv_attach_child_noperm() could change the AioContext of bs_top. bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from commit 2398747128 ("block: Don't poll in bdrv_replace_child_noperm()").

[PULL 16/22] block: Fix bdrv_co_create_opts_simple() to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
bdrv_co_create_opts_simple() runs in a coroutine. Therefore it is not allowed to open images directly. Fix the call to use the corresponding no_co_wrapper instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-13-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

[PULL 11/22] qed: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine. Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-8-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

Re: [PATCH v1 2/2] hw: allwinner-i2c: Fix TWI_CNTR_INT_FLAG

2023-02-17 Thread Strahinja Jankovic
Hi, I tried running Avocado tests for cubieboard with following command: ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes avocado --show=app,console run-t machine:cubieboard tests/avocado/boot_linux_console.py Without this patch all tests pass: RESULTS: PASS 3 | ERROR 0 |

[PATCH v3 1/1] vhost-user-fs: add migration type property

2023-02-17 Thread Anton Kuchin
Migration of vhost-user-fs device requires transfer of FUSE internal state from backend. There is no standard way to do it now so by default migration must be blocked. But if this state can be externally transferred by orchestrator give it an option to explicitly allow migration. Signed-off-by:

Re: [PATCH 07/12] testing: update ubuntu2004 to ubuntu2204

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 11:35:44AM -0500, John Snow wrote: > On Thu, Feb 16, 2023, 2:44 PM Daniel P. Berrangé > wrote: > > > On Thu, Feb 16, 2023 at 01:15:30PM -0500, John Snow wrote: > > > On Wed, Feb 15, 2023 at 2:25 PM Alex Bennée > > wrote: > > > > > > > > The 22.04 LTS release has been out

[PULL 0/9] Fourth RISC-V PR for QEMU 8.0

2023-02-17 Thread Palmer Dabbelt
The following changes since commit 417296c8d8588f782018d01a317f88957e9786d6: tests/qtest/netdev-socket: Raise connection timeout to 60 seconds (2023-02-09 11:23:53 +) are available in the Git repository at: https://github.com/palmer-dabbelt/qemu.git tags/pull-riscv-to-apply-20230217

[PULL 9/9] target/riscv: Fix vslide1up.vf and vslide1down.vf

2023-02-17 Thread Palmer Dabbelt
From: LIU Zhiwei vslide1up_##BITWIDTH is used by the vslide1up.vx and vslide1up.vf. So its scalar input should be uint64_t to hold the 64 bits float register.And the same for vslide1down_##BITWIDTH. This bug is caught when run these instructions on qemu-riscv32. Signed-off-by: LIU Zhiwei

Re: [RFC PATCH] docs/about/build-platforms: Refine the distro support policy

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 03:44:23PM +0100, Paolo Bonzini wrote: > On 2/17/23 14:26, Thomas Huth wrote: > > Note: These changes mean that openSUSE is not considered as supported > > anymore (since version 15.0 has been released in May 2018), and > > RHEL/CentOS 8 will not be supported anymore in 3

[PULL 00/22] Block layer patches

2023-02-17 Thread Kevin Wolf
The following changes since commit 6dffbe36af79e26a4d23f94a9a1c1201de99c261: Merge tag 'migration-20230215-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-02-16 13:09:51 +) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git

Re: [PATCH v2 1/4] util/cacheflush: fix cache on windows-arm64

2023-02-17 Thread Peter Maydell
On Thu, 16 Feb 2023 at 13:49, Pierrick Bouvier wrote: > > ctr_el0 access is privileged on this platform and fails as an illegal > instruction. > > Windows does not offer a way to flush data cache from userspace, and > only FlushInstructionCache is available in Windows API. > > The generic

Re: Runnig solaris binary(32 bit) on linux(64 bit)

2023-02-17 Thread Peter Maydell
On Thu, 16 Feb 2023 at 19:39, David Woodhouse wrote: > > On Thu, 2023-02-16 at 09:29 -1000, Richard Henderson wrote: > > On 2/16/23 09:02, David Woodhouse wrote: > > > It wouldn't be beyond the wit of man to extend qemu-user to support the > > > similar personality variations for SCO/Solaris/etc.

Re: [RFC v5 0/3] migration: reduce time of loading non-iterable vmstate

2023-02-17 Thread Peter Xu
Hello, Chuang, On Fri, Feb 17, 2023 at 04:11:19PM +0800, Chuang Xu wrote: > Error 1 was triggered by our sanity check. I try to add RCU_READ_LOCK_GUARD() > in address_space_init() and it works. But I'm not sure if this code change is > appropriate. If this change is not appropriate, we may need

Re: [RFC PATCH] docs/about/build-platforms: Refine the distro support policy

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 04:55:49PM +0100, Markus Armbruster wrote: > Thomas Huth writes: > > > Our distro support policy has been written with a best-effort > > estimation of what users and developers need. However, as we now > > know, the support for older long-term distributions can get really

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Reinoud Zandijk
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? NetBSD runs on a bunch of 32 bit-only

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Paolo Bonzini
On 2/17/23 11:47, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why?

Re: Call for GSoC and Outreachy project ideas for summer 2023

2023-02-17 Thread Stefan Hajnoczi
On Fri, 17 Feb 2023 at 11:23, Stefano Garzarella wrote: > > Hi Stefan, > > On Fri, Jan 27, 2023 at 10:17:40AM -0500, Stefan Hajnoczi wrote: > >Dear QEMU, KVM, and rust-vmm communities, > >QEMU will apply for Google Summer of Code 2023 > >(https://summerofcode.withgoogle.com/) and has been

[PATCH v4] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-17 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns the

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 05:06:42PM +0100, Reinoud Zandijk wrote: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > > I feel the discussion petered out without a conclusion. > > > > I don't think letting the status quo win by inertia is a good outcome > > here. > > > > Which

Re: [PATCH 07/12] testing: update ubuntu2004 to ubuntu2204

2023-02-17 Thread John Snow
On Fri, Feb 17, 2023, 12:14 PM Daniel P. Berrangé wrote: > On Fri, Feb 17, 2023 at 11:35:44AM -0500, John Snow wrote: > > On Thu, Feb 16, 2023, 2:44 PM Daniel P. Berrangé > > wrote: > > > > > On Thu, Feb 16, 2023 at 01:15:30PM -0500, John Snow wrote: > > > > On Wed, Feb 15, 2023 at 2:25 PM Alex

Re: [PATCH v3 06/11] bsd-user: Helper routines h2g_old_sysctl

2023-02-17 Thread Richard Henderson
On 2/16/23 13:33, Warner Losh wrote: h2g_old_sysctl does the byte swapping in the data to return it to the target for the 'well known' types. For most of the types, either the data is returned verbatim (strings, byte size, opaque we don't know about) or it's returned with byte swapping (for all

[PULL 7/9] target/riscv: Smepmp: Skip applying default rules when address matches

2023-02-17 Thread Palmer Dabbelt
From: Himanshu Chauhan When MSECCFG.MML is set, after checking the address range in PMP if the asked permissions are not same as programmed in PMP, the default permissions are applied. This should only be the case when there is no matching address is found. This patch skips applying default

Re: [PATCH 2/2] hw/timer: Reduce 'hw/ptimer.h' inclusion

2023-02-17 Thread Richard Henderson
On 2/17/23 04:18, Philippe Mathieu-Daudé wrote: "hw/ptimer.h" API is mostly used by timer / watchdog device models. Since the SoC / machines only access the ptimer via reference, they don't need its definition: the declartion is enough. On order to reduce the inclusion on the source files,

[PATCH 4/6] hw/cxl: QMP based poison injection support

2023-02-17 Thread Jonathan Cameron via
Inject poison using qmp command cxl-inject-poison to add an entry to the poison list. For now, the poison is not returned CXL.mem reads, but only via the mailbox command Get Poison List. See CXL rev 3.0, sec 8.2.9.8.4.1 Get Poison list (Opcode 4300h) Kernel patches to use this interface here:

Re: [PATCH v1 2/4] linux-user: fix sockaddr_in6 endianness

2023-02-17 Thread Philippe Mathieu-Daudé
On 17/2/23 17:35, Mathis Marion wrote: From: Mathis Marion Fields sin6_flowinfo and sin6_scope_id use the host byte order, so there is a conversion to be made when host and target endianness differ. Signed-off-by: Mathis Marion --- linux-user/syscall.c | 6 ++ 1 file changed, 6

[PATCH 3/6] hw/cxl: Introduce cxl_device_get_timestamp() utility function

2023-02-17 Thread Jonathan Cameron via
From: Ira Weiny There are new users of this functionality coming shortly so factor it out from the GET_TIMESTAMP mailbox command handling. Signed-off-by: Ira Weiny Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-device-utils.c | 15 +++ hw/cxl/cxl-mailbox-utils.c | 11

Re: [RFC PATCH] docs/about/build-platforms: Refine the distro support policy

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 02:26:31PM +0100, Thomas Huth wrote: > Our distro support policy has been written with a best-effort > estimation of what users and developers need. However, as we now > know, the support for older long-term distributions can get really > troublesome for upstream

[PATCH] [PATCH] disas/riscv Fix ctzw disassemble

2023-02-17 Thread Ivan Klokov
Due to typo in opcode list, ctzw is disassembled as clzw instruction. Signed-off-by: Ivan Klokov --- disas/riscv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/riscv.c b/disas/riscv.c index ddda687c13..d0639cd047 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@

Re: [RFC PATCH] docs: build-platforms: refine requirements on Python build dependencies

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 01:41:50PM +0100, Paolo Bonzini wrote: > Historically, the critical dependency for both building and running > QEMU has been the distro packages. Because QEMU is written in C and C's > package management has been tied to distros (at least if you do not want > to bundle

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Peter Maydell
On Fri, 17 Feb 2023 at 09:56, Thomas Huth wrote: > > On 17/02/2023 10.06, Markus Armbruster wrote: > > Thomas Huth writes: > ... > > My view on all this is a bit more pragmatic. > > > > For a human developer, the difference between "dnf install > > python-sphinx" and "pip install sphinx" is, in

Re: [RFC PATCH] docs: build-platforms: refine requirements on Python build dependencies

2023-02-17 Thread Markus Armbruster
Paolo Bonzini writes: > Historically, the critical dependency for both building and running > QEMU has been the distro packages. Because QEMU is written in C and C's > package management has been tied to distros (at least if you do not want > to bundle libraries with the binary, otherwise I

[PATCH] [PATCH] disas/riscv Fix ctzw disassemble

2023-02-17 Thread Ivan Klokov
Due to typo in opcode list, ctzw is disassembled as clzw instruction. Fixes: 02c1b569a15b ("disas/riscv: Add Zb[abcs] instructions") Signed-off-by: Ivan Klokov --- v2: - added fixes line --- disas/riscv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/riscv.c

Re: [PATCH 2/2] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2023-02-17 Thread Jonathan Cameron via
On Tue, 31 Jan 2023 16:38:47 + Jonathan Cameron via wrote: > From: Gregory Price > > This commit enables each CXL Type-3 device to contain one volatile > memory region and one persistent region. > > Two new properties have been added to cxl-type3 device initialization: >

[PATCH v1 3/4] linux-user: add target to host netlink conversions

2023-02-17 Thread Mathis Marion
From: Mathis Marion Added conversions for: - IFLA_MTU - IFLA_TXQLEN - IFLA_AF_SPEC AF_INET6 IFLA_INET6_ADDR_GEN_MODE These relate to the libnl functions rtnl_link_set_mtu, rtnl_link_set_txqlen, and rtnl_link_inet6_set_addr_gen_mode. Signed-off-by: Mathis Marion --- linux-user/fd-trans.c | 64

[PATCH v1 2/4] linux-user: fix sockaddr_in6 endianness

2023-02-17 Thread Mathis Marion
From: Mathis Marion Fields sin6_flowinfo and sin6_scope_id use the host byte order, so there is a conversion to be made when host and target endianness differ. Signed-off-by: Mathis Marion --- linux-user/syscall.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/syscall.c

[PATCH v1 1/4] linux-user: fix timerfd read endianness conversion

2023-02-17 Thread Mathis Marion
From: Mathis Marion When reading the expiration count from a timerfd, the endianness of the 64bit value read is the one of the host, just as for eventfds. Signed-off-by: Mathis Marion --- linux-user/fd-trans.c | 10 +++--- linux-user/fd-trans.h | 1 + linux-user/syscall.c | 8 ++--

[PATCH v1 4/4] linux-user: handle netlink flag NLA_F_NESTED

2023-02-17 Thread Mathis Marion
From: Mathis Marion Newer kernel versions require this flag to be present contrary to older ones. Depending on the libnl version it is added or not. Typically when using rtnl_link_inet6_set_addr_gen_mode, the netlink packet generated may contain the following attribute: with libnl 3.4

Re: Call for GSoC and Outreachy project ideas for summer 2023

2023-02-17 Thread German Maglione
Hi Stefan, Sorry for being so late, if it is still possible I would like to propose the following project: === A sandboxing tool for virtiofsd === ''Summary:''' Create a tool that runs virtiofsd in a sandboxed environment Virtiofs is a shared file system that lets virtual machines access a

[PATCH v2 2/2] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2023-02-17 Thread Jonathan Cameron via
From: Gregory Price This commit enables each CXL Type-3 device to contain one volatile memory region and one persistent region. Two new properties have been added to cxl-type3 device initialization: [volatile-memdev] and [persistent-memdev] The existing [memdev] property has been

Re: [RFC PATCH] docs/about/build-platforms: Refine the distro support policy

2023-02-17 Thread Thomas Huth
On 17/02/2023 16.06, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 02:26:31PM +0100, Thomas Huth wrote: ... I'm also not so comfortable dropping the only version of SLES that we explicitly target, when we don't know when their new major release will arrive. Let's hope that the next major

[PULL 05/22] block-coroutine-wrapper: Introduce no_co_wrapper

2023-02-17 Thread Kevin Wolf
Some functions must not be called from coroutine context. The common pattern to use them anyway from a coroutine is running them in a BH and letting the calling coroutine yield to be woken up when the BH is completed. Instead of manually writing such wrappers, add support for generating them to

Re: Call for GSoC and Outreachy project ideas for summer 2023

2023-02-17 Thread Stefano Garzarella
Hi Stefan, On Fri, Jan 27, 2023 at 10:17:40AM -0500, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2023 (https://summerofcode.withgoogle.com/) and has been accepted into Outreachy May 2023 (https://www.outreachy.org/). You can now

Re: [PATCH 07/12] testing: update ubuntu2004 to ubuntu2204

2023-02-17 Thread John Snow
On Thu, Feb 16, 2023, 2:44 PM Daniel P. Berrangé wrote: > On Thu, Feb 16, 2023 at 01:15:30PM -0500, John Snow wrote: > > On Wed, Feb 15, 2023 at 2:25 PM Alex Bennée > wrote: > > > > > > The 22.04 LTS release has been out for almost a year now so its time > > > to update all the remaining images

[PATCH v3 0/1] virtio-fs: implement option for stateless migration.

2023-02-17 Thread Anton Kuchin
v3: - Remove migration_type from migration stream - Use enum type for migration_type - Get rid of useless cast - Fix typos - Reword commit message v2: - Use device property instead of migration capability Anton Kuchin (1): vhost-user-fs: add migration type property

Re: [PATCH v3 04/11] bsd-user: various helper routines for sysctl

2023-02-17 Thread Richard Henderson
On 2/16/23 13:33, Warner Losh wrote: cap_memory - Caps the memory to just below MAXINT scale_to_guest_pages - Account for difference in host / guest page size h2g_long_sat - converts a int64_t to a int32_t, saturating at max / min values h2g_ulong_sat - converts a uint64_t to a uint32_t,

[PATCH 5/6] hw/cxl: Add poison injection via the mailbox.

2023-02-17 Thread Jonathan Cameron via
Very simple implementation to allow testing of corresponding kernel code. Note that for now we track each 64 byte section independently. Whilst a valid implementation choice, it may make sense to fuse entries so as to prove out more complex corners of the kernel code. Signed-off-by: Jonathan

Re: [PULL 02/10] fuzz: add fuzz_reset API

2023-02-17 Thread Alexander Bulekov
On 230217 1048, Darren Kenny wrote: > I know this is a pull request, but if you prefer to have all the patches > with and R-b, you can add mine here too, but I'll leave it up to you. > > Reviewed-by: Darren Kenny > Thank you Darren - I missed that this one wasn't reviewed..

[PULL 03/22] configure: Enable -Wthread-safety if present

2023-02-17 Thread Kevin Wolf
This enables clang's thread safety analysis (TSA), which we'll use to statically check the block graph locking. Signed-off-by: Kevin Wolf Message-Id: <20221207131838.239125-9-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito Signed-off-by: Kevin Wolf Message-Id:

[PULL 10/22] qcow2: Fix open/create to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine, as does qcow2_do_open(). Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-7-kw...@redhat.com> Reviewed-by:

[PULL 07/22] luks: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine. Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-4-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

[PULL 15/22] vpc: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine. Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-12-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

[PULL 06/22] block: Create no_co_wrappers for open functions

2023-02-17 Thread Kevin Wolf
Images can't be opened in coroutine context because opening needs to change the block graph. Add no_co_wrappers so that coroutines have a simple way of opening images in a BH instead. At the same time, mark the wrapped functions as no_coroutine_fn. Signed-off-by: Kevin Wolf Message-Id:

[PULL 13/22] vhdx: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine. Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-10-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

[PULL 14/22] vmdk: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

2023-02-17 Thread Kevin Wolf
.bdrv_co_create implementations run in a coroutine. Therefore they are not allowed to open images directly. Fix the calls to use the corresponding no_co_wrappers instead. Signed-off-by: Kevin Wolf Message-Id: <20230126172432.436111-11-kw...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito

  1   2   3   >