Re: MAINTAINERS still leaves more files uncovered than I'd like

On 02/10/2023 08.18, Philippe Mathieu-Daudé wrote: Hi Markus, On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org>

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > This patch handles QAPI enum types and generates its equivalent in Go. > > Basically, Enums are being handled as strings in Golang. > > 1. For each QAPI enum, we will define a string type in Go to be the >assigned type of this specific

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

On Mon, Oct 2, 2023 at 3:07 PM John Snow wrote: > > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > Basically, Enums are being handled as strings in Golang. > > > > 1. For each QAPI enum, we will define a

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 22:38, Alex Williamson wrote: > On Mon, 2 Oct 2023 21:41:55 +0200 > Laszlo Ersek wrote: > >> On 10/2/23 21:26, Alex Williamson wrote: >>> On Mon, 2 Oct 2023 20:24:11 +0200 >>> Laszlo Ersek wrote: >>> On 10/2/23 16:41, Alex Williamson wrote: > On Mon, 2 Oct 2023 15:38:10

Re: [PATCH] MAINTAINERS: Add section for overall sensors

02.10.2023 21:26, Thomas Huth : On 20/02/2023 12.02, Philippe Mathieu-Daudé wrote: Sensor devices depend on some bus, not a particular board. While merged for a particular board, sensor devices don't depend on it. They depend on a bus technology, and can be used by any board exposing such bus.

Re: [PATCH v2 4/5] ramfb: make migration conditional

On Mon, 2 Oct 2023 21:41:55 +0200 Laszlo Ersek wrote: > On 10/2/23 21:26, Alex Williamson wrote: > > On Mon, 2 Oct 2023 20:24:11 +0200 > > Laszlo Ersek wrote: > > > >> On 10/2/23 16:41, Alex Williamson wrote: > >>> On Mon, 2 Oct 2023 15:38:10 +0200 > >>> Cédric Le Goater wrote: > >>>

[PATCH v3 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

(1) The virtio-1.2 specification writes: > 3 General Initialization And Device Operation > 3.1 Device Initialization > 3.1.1 Driver Requirements: Device Initialization > > [...] > > 7. Perform device-specific setup, including

[PATCH v3 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

v2: - http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com - https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-ler...@redhat.com/ v3 picks up tags from Phil, Eugenio and Albert, and updates the commit message on patch#7 according to Eugenio's

[PATCH v3 3/7] vhost-user: factor out "vhost_user_write_sync"

The tails of the "vhost_user_set_vring_addr" and "vhost_user_set_u64" functions are now byte-for-byte identical. Factor the common tail out to a new function called "vhost_user_write_sync". This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vhost) Cc:

[PATCH v3 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply

The "vhost_set_vring" function already centralizes the common parts of "vhost_user_set_vring_num", "vhost_user_set_vring_base" and "vhost_user_set_vring_enable". We'll want to allow some of those callers to wait for a reply. Therefore, rebase "vhost_set_vring" from just "vhost_user_write" to

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 16:41, Alex Williamson wrote: > On Mon, 2 Oct 2023 15:38:10 +0200 > Cédric Le Goater wrote: > >> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> RAMFB migration was unsupported until now, let's make it conditional. >>> The following patch will

Re: [PATCH v2 4/5] ramfb: make migration conditional

On Mon, 2 Oct 2023 20:24:11 +0200 Laszlo Ersek wrote: > On 10/2/23 16:41, Alex Williamson wrote: > > On Mon, 2 Oct 2023 15:38:10 +0200 > > Cédric Le Goater wrote: > > > >> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> RAMFB migration was

Re: [PATCH v1 2/9] qapi: golang: Generate qapi's alternate types in Go

On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > This patch handles QAPI alternate types and generates data structures > in Go that handles it. > > Alternate types are similar to Union but without a discriminator that > can be used to identify the underlying value on the wire. It is needed

Re: [PATCH] MAINTAINERS: Add section for overall sensors

On 20/02/2023 12.02, Philippe Mathieu-Daudé wrote: Sensor devices depend on some bus, not a particular board. While merged for a particular board, sensor devices don't depend on it. They depend on a bus technology, and can be used by any board exposing such bus. In order to help merging sensor

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 21:26, Alex Williamson wrote: > On Mon, 2 Oct 2023 20:24:11 +0200 > Laszlo Ersek wrote: > >> On 10/2/23 16:41, Alex Williamson wrote: >>> On Mon, 2 Oct 2023 15:38:10 +0200 >>> Cédric Le Goater wrote: >>> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: > From:

Re: [PATCH v2 1/7] vhost-user: strip superfluous whitespace

On 9/6/23 09:12, Albert Esteve wrote: > > > On Thu, Aug 31, 2023 at 9:14 AM Laszlo Ersek > wrote: > > On 8/30/23 15:40, Laszlo Ersek wrote: > > Cc: "Michael S. Tsirkin" mailto:m...@redhat.com>> > (supporter:vhost) > > Cc: Eugenio Perez Martin

Re: [PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

On Tue, Sep 26, 2023 at 10:40:27PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Quotting from Markus in his replies: > > Quoting > > Suggest something like "Markus recently wrote:" Will do. > > > migrate-set-parameters sets migration parameters, and > >

[PATCH v3 5/7] vhost-user: hoist "write_sync", "get_features", "get_u64"

In order to avoid a forward-declaration for "vhost_user_write_sync" in a subsequent patch, hoist "vhost_user_write_sync" -> "vhost_user_get_features" -> "vhost_user_get_u64" just above "vhost_set_vring". This is purely code movement -- no observable change. Cc: "Michael S. Tsirkin"

[PATCH v3 4/7] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"

At this point, only "vhost_user_write_sync" calls "enforce_reply"; embed the latter into the former. This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German Maglione Cc: Liu Jiang Cc: Sergio Lopez Pascual Cc: Stefano

[PATCH v3 2/7] vhost-user: tighten "reply_supported" scope in "set_vring_addr"

In the vhost_user_set_vring_addr() function, we calculate "reply_supported" unconditionally, even though we'll only need it if "wait_for_reply" is also true. Restrict the scope of "reply_supported" to the minimum. This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin"

[PATCH v3 1/7] vhost-user: strip superfluous whitespace

Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German Maglione Cc: Liu Jiang Cc: Sergio Lopez Pascual Cc: Stefano Garzarella Signed-off-by: Laszlo Ersek Reviewed-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Tested-by: Albert Esteve Reviewed-by:

Re: [PATCH v2 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

On 02/10/2023 16:51, Cédric Le Goater wrote: The hw/ppc/fw_cfg.c file contains the implementation of fw_cfg_arch_key_name(), used by the common nvram model. List it under mac99 machine next to the mac_nvram model. Cc: Mark Cave-Ayland Reviewed-by: Daniel Henrique Barboza Signed-off-by:

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

On Tue, Sep 26, 2023 at 10:43:22PM +0200, Markus Armbruster wrote: > Loophole... Here's the stupidest solution that could possibly work: > > ## > # @MigrationParameter: > # > # TODO: elide from generated documentation (type is used only > # internally, and not visible in

Re: [PATCH v1 2/9] qapi: golang: Generate qapi's alternate types in Go

On Fri, Sep 29, 2023 at 8:37 AM Daniel P. Berrangé wrote: > > On Fri, Sep 29, 2023 at 02:23:22PM +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Sep 28, 2023 at 03:51:50PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 27, 2023 at 01:25:37PM +0200, Victor Toso wrote: > > > > This patch

Re: [PATCH] pci: SLT must be RO

On Mon, Oct 02, 2023 at 01:39:16PM +0200, Marcin Juszkiewicz wrote: > W dniu 8.09.2023 o 15:29, Marcin Juszkiewicz pisze: > > W dniu 31.08.2023 o 12:05, Marcin Juszkiewicz pisze: > > > W dniu 30.08.2023 o 23:48, Michael S. Tsirkin pisze: > > > > current code sets PCI_SEC_LATENCY_TIMER to WO, but

Re: [PULL v3 00/16] tricore queue

29.09.2023 09:39, Bastian Koppelmann: - Add FTOU, CRCN, FTOHP, and HPTOF insns Changes from v2: - Replaced %ld with PRIu64 for patch 13 - Dropped patches 15 - 19,

Re: [PATCH V2 04/10] hw/acpi: Init GED framework with cpu hotplug events

On 9/30/23 10:19, Salil Mehta wrote: ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI events when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM then maps or demultiplexes the event by evaluating _EVT method. This change adds the support of cpu

Re: [PATCH V2 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

On 9/30/23 10:19, Salil Mehta wrote: CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based on PCI and is IO port based and hence existing cpus AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control

Re: [PATCH V2 08/10] physmem: Add helper function to destroy CPU AddressSpace

On 9/30/23 10:19, Salil Mehta wrote: Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta --- include/exec/cpu-common.h | 8

Re: [PULL 0/6] tcg patch queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/14] Tracing patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Mon, Oct 2, 2023 at 5:09 AM Simon Rowe wrote: > > On Thursday, 28 September 2023 Fiona Ebner wrote: > > > > > AFAICT, yes, because the DMA callback is invoked before resetting the > > state now. But not 100% sure if it can't be triggered in some other way, > > maybe Simon knows more? I don't

Re: [PATCH V2 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

On 9/30/23 10:19, Salil Mehta wrote: CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée --- hw/acpi/cpu.c

Re: [PATCH 0/8] migration fixes

On Tue, Oct 03, 2023 at 01:55:35AM +0300, Michael Tokarev wrote: > 18.09.2023 20:28, Fabiano Rosas wrote: > > This series contains fixes for the two currently know failures that > > show up in migration tests plus a set of fixes for some theoretical > > race conditions around QEMUFile handling. >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > > On Wed, 30 Aug 2023 at

Re: [PULL 0/6] tcg patch queue

On 10/2/23 15:46, Michael Tokarev wrote: 28.09.2023 22:41, Richard Henderson wrote Mini PR, aimed at fixing the mips and ovmf regressions. r~ accel/tcg: Always require can_do_io, for #1866

Re: [PATCH V2 09/10] gdbstub: Add helper function to unregister GDB register space

On 9/30/23 10:19, Salil Mehta wrote: Add common function to help unregister the GDB Register Space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta --- gdbstub/gdbstub.c | 14 ++ include/exec/gdbstub.h | 5 + 2 files changed, 19

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > > > On 8/30/23 14:10, Stefan

Re: [PATCH 0/8] migration fixes

18.09.2023 20:28, Fabiano Rosas wrote: This series contains fixes for the two currently know failures that show up in migration tests plus a set of fixes for some theoretical race conditions around QEMUFile handling. Patch 1 addresses the issue found in the postcopy/preempt/plain test:

Re: [PATCH V2 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

On 9/30/23 10:19, Salil Mehta wrote: KVM vCPU creation is done once during the initialization of the VM when Qemu threads are spawned. This is common to all the architectures. ^^^ thread is spawned. Hot-unplug of vCPU results in destruction of the vCPU objects in QOM but

Re: [PATCH V2 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

On 9/30/23 10:19, Salil Mehta wrote: ACPI GED shall be used to convey to the guest kernel about any CPU hot-(un)plug events. Therefore, existing ACPI GED framework inside QEMU needs to be enhanced to support CPU hotplug state and events. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu

Re: [PATCH 3/4] hw/ppc/spapr_hcall: Rename {softmmu -> tcgppc}_resize_hpt_prepare/commit

On Mon, Oct 02, 2023 at 04:38:53PM +0200, Philippe Mathieu-Daudé wrote: > We use the 'kvmppc' prefix for KVM specific functions: > > $ git grep \ kvmppc_ | wc -l >402 > > Following the same pattern for TCG specific functions, > use the 'tcgppc' prefix (which is clearer than 'softmmu').

Re: [PATCH 4/4] hw/ppc/spapr: Rename 'softmmu' -> 'tcg'

On Mon, Oct 02, 2023 at 04:38:54PM +0200, Philippe Mathieu-Daudé wrote: > spapr_softmmu.c isn't related to having a soft MMU, but having > the TCG accelerator. Rename it using the 'tcg' suffix. That's not really accurate. The functions in there absolutely are about the emulated MMU. They're not

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

One more question: Why is the disabled state not needed by regular (non-vhost) virtio-net devices? On Mon, 2 Oct 2023 at 17:12, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > >

Re: [PULL 0/2] Firmware/seabios 20230929 patches

On Fri, 29 Sept 2023 at 07:30, Gerd Hoffmann wrote: > > The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa: > > migration: Move return path cleanup to main migration thread (2023-09-27 > 13:58:02 -0400) > > are available in the Git repository at: > >

Re: [PULL 0/6] tcg patch queue

28.09.2023 22:41, Richard Henderson wrote Mini PR, aimed at fixing the mips and ovmf regressions. r~ accel/tcg: Always require can_do_io, for #1866 Richard Henderson

Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub

On 9/30/23 10:19, Salil Mehta wrote: ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta ---

Re: [PATCH 0/8] migration fixes

03.10.2023 02:29, Peter Xu: On Tue, Oct 03, 2023 at 01:55:35AM +0300, Michael Tokarev wrote: What can be done for -stable? At least the whole thing applies cleanly to 8.1. It seems v8.0.5 needs at least a few conflict resolutions. As I stated in recent 8.0.5 stable announce, it was the

Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan

On 9/30/23 10:19, Salil Mehta wrote: OSPM evaluates _EVT method to map the event. The cpu hotplug event eventually results in start of the cpu scan. Scan figures out the cpu and the kind of event(plug/unplug) and notifies it back to the guest. The change in this patch updates the GED AML _EVT

Re: [PULL 00/13] Migration 20231002 patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 00/16] tricore queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/56] -Wshadow=local patches patches for 2023-09-29

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: MAINTAINERS still leaves more files uncovered than I'd like

Hi Markus, On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel/87mw8rumhb@blackfin.pond.sub.org/ I updated

[PATCH v9 2/4] hw/display: introduce virtio-dmabuf

This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices, associated to a UUID. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functions that reside in the virtio-dmabuf file. For

[PATCH v9 1/4] util/uuid: add a hash function

Add hash function to uuid module using the djb2 hash algorithm. Add a couple simple unit tests for the hash function, checking collisions for similar UUIDs. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Albert Esteve --- include/qemu/uuid.h| 2 ++ tests/unit/test-uuid.c | 27

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

On 9/7/23 23:53, Denis V. Lunev wrote: Unfortunately 271 IO test is broken if started in non-cached mode. Commits commit a6b257a08e3d72219f03e461a52152672fec0612 Author: Nir Soffer Date: Tue Aug 13 21:21:03 2019 +0300 file-posix: Handle undetectable alignment and

Re: [PATCH v2] mailmap: update email addresses for Luc Michel

On 29/9/23 16:03, Luc Michel wrote: Map my old and now invalid work email addresses to my personal one. Signed-off-by: Luc Michel --- Please ignore v1 sent with wrong e-mail address. --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v9 4/4] libvhost-user: handle shared_object msg

In the libvhost-user library we need to handle VHOST_USER_GET_SHARED_OBJECT requests, and add helper functions to allow sending messages to interact with the virtio shared objects hash table. Signed-off-by: Albert Esteve --- subprojects/libvhost-user/libvhost-user.c | 120 ++

[PATCH v9 3/4] vhost-user: add shared_object msg

Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add or remove themselves as virtio exporters, or lookup for virtio dma-buf shared objects. The action taken

[PATCH v9 0/4] Virtio shared dma-buf

v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html v3 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg06126.html v4 link ->

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 03:56:03AM +0200, Laszlo Ersek wrote: > On 10/1/23 21:25, Michael S. Tsirkin wrote: > > Not this actually - v2 of this. > > Thank you, but: > > - Stefan's question should be answered still IMO (although if you pick > up this series, then that could be interpreted as "QEMU

[PATCH v2 4/4] target/i386: Add get/set/migrate support for FRED MSRs

FRED CPU states are managed in 9 new FRED MSRs, in addtion to a few existing CPU registers and MSRs, e.g., CR4.FRED and MSR_IA32_PL0_SSP. Save/restore/migrate FRED MSRs if FRED is exposed to the guest. Tested-by: Shan Kang Signed-off-by: Xin Li --- target/i386/cpu.h | 26

[PATCH v2 3/4] target/i386: enumerate VMX nested-exception support

Allow VMX nested-exception support to be exposed in KVM guests, thus nested KVM guests can enumerate it. Tested-by: Shan Kang Signed-off-by: Xin Li --- scripts/kvm/vmxcap | 1 + target/i386/cpu.c | 1 + target/i386/cpu.h | 1 + 3 files changed, 3 insertions(+) diff --git

[PATCH v2 2/4] target/i386: mark CR4.FRED not reserved

The CR4.FRED bit, i.e., CR4[32], is no longer a reserved bit when FRED is exposed to guests, otherwise it is still a reserved bit. Tested-by: Shan Kang Signed-off-by: Xin Li --- target/i386/cpu.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h

[PATCH v2 1/4] target/i386: add support for FRED in CPUID enumeration

FRED, i.e., the Intel flexible return and event delivery architecture, defines simple new transitions that change privilege level (ring transitions). The new transitions defined by the FRED architecture are FRED event delivery and, for returning from events, two FRED return instructions. FRED

[PATCH v2 0/4] target/i386: add support for FRED

This patch set adds support for the Intel flexible return and event delivery (FRED) architecture to allow Qemu to run KVM guests with FRED enabled. The FRED architecture defines simple new transitions that change privilege level (ring transitions). The FRED architecture was designed with the

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Mon, 2 Oct 2023 09:15:58 +0200 Klaus Jensen wrote: > On Sep 15 21:27, Alistair Francis wrote: > > From: Wilfred Mallawa > > > > Setup Data Object Exchance (DOE) as an extended capability for the NVME > > controller and connect SPDM to it (CMA) to it. > > > > Signed-off-by: Wilfred Mallawa

Re: MAINTAINERS still leaves more files uncovered than I'd like

On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel/87mw8rumhb@blackfin.pond.sub.org/ I updated my findings

Re: [PATCH v2 2/2] elf2dmp: check array bounds in pdb_get_file_size

On 1/10/23 01:53, Viktor Prutyanov wrote: Index in file_size array must be checked against num_files, because the entries we are looking for may be absent in the PDB. Fixes: Coverity CID 1521597 Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 13 + 1 file changed, 9

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Sep 15 21:27, Alistair Francis wrote: > From: Wilfred Mallawa > > Setup Data Object Exchance (DOE) as an extended capability for the NVME > controller and connect SPDM to it (CMA) to it. > > Signed-off-by: Wilfred Mallawa > Signed-off-by: Alistair Francis > --- > docs/specs/index.rst

Re: [PATCH] MAINTAINERS: Add include folder to the hw/char/ section

On 29/9/23 14:44, Thomas Huth wrote: The "Character devices" section only covers hw/char/ but misses the corresponding include/hw/char/ folder. Add it now. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/9] hw/acpi: Add ACPI CPU hotplug init stub

Hi Salil, On 29/9/23 17:47, Salil Mehta wrote: From: Alex Bennée Sent: Friday, September 29, 2023 3:27 PM To: Salil Mehta Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- phili...@linaro.org; Jonathan Cameron ; lpieral...@kernel.org; peter.mayd...@linaro.org;

Re: [PATCH v3 0/8] qemu-img: rebase: add compression support

On 9/19/23 20:57, Andrey Drobyshev wrote: > v2 --> v3: > * Patch 3/8: fixed logic in the if statement, so that we align on blk >when blk_old_backing == NULL; > * Patch 4/8: comment fix; > * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)" >statements. > > v2:

Re: [PATCH] linux-user/hppa: Fix struct target_sigcontext layout

On 30/9/23 23:27, Richard Henderson wrote: Use abi_ullong not uint64_t so that the alignment of the field and therefore the layout of the struct is correct. Signed-off-by: Richard Henderson --- linux-user/hppa/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [PATCH] build: Remove --enable-gprof

On 30/9/23 20:18, Richard Henderson wrote: This build option has been deprecated since 8.0. Remove all CONFIG_GPROF code that depends on that, including one errant check using TARGET_GPROF. Signed-off-by: Richard Henderson --- docs/about/deprecated.rst | 14 -- meson.build

Re: [PATCH v8 1/4] util/uuid: add a hash function

On Sun, Oct 1, 2023 at 10:15 PM Michael S. Tsirkin wrote: > On Fri, Sep 08, 2023 at 05:47:40PM +0200, Albert Esteve wrote: > > Add hash function to uuid module using the > > djb2 hash algorithm. > > > > Add a couple simple unit tests for the hash > > function, checking collisions for similar

Re: [PATCH] crypto: only include tls-cipher-suites in emulators

On 28/9/23 09:49, Paolo Bonzini wrote: tls-cipher-suites is an object that is used to inject TLS configuration into the guest (via fw_cfg). It is never used for host-side TLS operation, and therefore it need not be available in the tools. Signed-off-by: Paolo Bonzini --- crypto/meson.build

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > >> > > >> (1) The virtio-1.0 specification > > >>

Re: [PATCH] MAINTAINERS: add standard-headers to Hosts/LINUX

Hi Cornelia, On 29/9/23 16:30, Cornelia Huck wrote: The files in there are updated via update-linux-headers.sh. So F: or X: (exclusion)? Regardless, Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cornelia Huck --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] MAINTAINERS: Add the CI-related doc files to the CI section

On 29/9/23 15:16, Thomas Huth wrote: The docs/devel/ci* were not covered yet, add them to MAINTAINERS so that the right people are put on CC: for related patches. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] mailmap: Fix Andrey Drobyshev author email

On 26/9/23 12:28, andrey.drobys...@virtuozzo.com wrote: From: Andrey Drobyshev This fixes authorship of commits 2848289168, 52b10c9c0c as the mailing list rewrote the "From:" field in the corresponding patches. See commit 3bd2608db7 ("maint: Add .mailmap entries for patches claiming list

Re: [PATCH] target/arm/kvm64.c: Remove unused include

On 25/9/23 13:04, Peter Maydell wrote: The include of hw/arm/virt.h in kvm64.c is unnecessary and also a layering violation since the generic KVM code shouldn't need to know anything about board-specifics. The include line is an accidental leftover from commit 15613357ba53a4763, where we

Re: [PATCH v2 1/3] i386/a-b-bootblock: factor test memory addresses out into constants

Ping! :) 19.09.2023, 13:23, "Daniil Tatianin" :So that we have less magic numbers to deal with. This also allows us toreuse these in the following commits.Signed-off-by: Daniil Tatianin Reviewed-by: Peter Xu --- tests/migration/i386/a-b-bootblock.S | 9

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Fri, Sep 15, 2023 at 09:27:23PM +1000, Alistair Francis wrote: > --- /dev/null > +++ b/docs/specs/spdm.rst > @@ -0,0 +1,56 @@ > +== > +QEMU Security Protocols and Data Models (SPDM) Support >

[PATCH 08/19] parallels: Make mark_used() and mark_unused() global functions

We will need these functions in parallels-ext.c too. Let them be global functions parallels_mark_used() and parallels_mark_unused(). Signed-off-by: Alexander Ivanov --- block/parallels.c | 22 -- block/parallels.h | 5 + 2 files changed, 17 insertions(+), 10

[PATCH 03/19] parallels: Move host clusters allocation to a separate function

For parallels images extensions we need to allocate host clusters without any connection to BAT. Move host clusters allocation code to allocate_host_clusters(). Signed-off-by: Alexander Ivanov --- block/parallels.c | 124 -- block/parallels.h | 4 ++

[PATCH 16/19] parallels: Check unused clusters in parallels_check_leak()

Since we have used bitmap, leak check is useless. Transform parallels_truncate_unused_clusters() to parallels_check_unused_clusters() helper and use it in leak check. Signed-off-by: Alexander Ivanov --- block/parallels.c | 112 ++ 1 file changed, 63

[PATCH 14/19] parallels: Truncate images on the last used cluster

On an image closing there can be unused clusters in the end of the image. Truncate these clusters and update data_end field. Signed-off-by: Alexander Ivanov --- block/parallels.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/block/parallels.c

[PATCH 19/19] tests: Add parallels format support to image-fleecing

Use a different bitmap name for parallels images because their has own ID format, and can't contain an arbitrary string. Replace hardcoded 'qcow2' format to iotests.imgfmt. Add 'parallels' to supported formats. Signed-off-by: Alexander Ivanov --- tests/qemu-iotests/tests/image-fleecing | 13

[PATCH 11/19] parallels: Handle L1 entries equal to one

If all the bits in a dirty bitmap cluster are ones, the cluster shouldn't be written. Instead the corresponding L1 entry should be set to 1. Check if all bits in a memory region are ones and set 1 to L1 entries corresponding clusters filled with ones. Signed-off-by: Alexander Ivanov ---

[PATCH 17/19] tests: Add parallels images support to test 165

Use a different bitmap name for parallels images because their has own ID format, and can't contain an arbitrary string. Replace image reopen by shutdown/launch VM because parallels images doesn't support reopen. Signed-off-by: Alexander Ivanov --- tests/qemu-iotests/165 | 42

[PATCH 00/19] parallels: Add full dirty bitmap support

Parallels format driver: * make some preparation * add dirty bitmap saving * make dirty bitmap RW * fix broken checks * refactor leak check * add parallels format support to several tests Alexander Ivanov (19): parallels: Move inactivation code to a separate function parallels: Add

[PATCH 02/19] parallels: Add mark_unused() helper

Add a helper to set unused areas in used bitmap. Signed-off-by: Alexander Ivanov --- block/parallels.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block/parallels.c b/block/parallels.c index d5b333d5a4..b5e19ff921 100644 --- a/block/parallels.c +++ b/block/parallels.c

[PATCH 06/19] parallels: Add a note about used bitmap in parallels_check_duplicate()

In parallels_check_duplicate() We use a bitmap for duplication detection. This bitmap is not related to used_bmap field in BDRVParallelsState. Add a comment about it to avoid confusion. Signed-off-by: Alexander Ivanov --- block/parallels.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH 05/19] parallels: Recreate used bitmap in parallels_check_leak()

In parallels_check_leak() file can be truncated. In this case the used bitmap would not comply to the file. Recreate the bitmap after file truncation. Signed-off-by: Alexander Ivanov --- block/parallels.c | 8 1 file changed, 8 insertions(+) diff --git a/block/parallels.c

RE: [PATCH RFC V2 02/37] cpus-common: Add common CPU utility for possible vCPUs

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 4:54 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

On Thu, Sep 28, 2023 at 09:14:07AM +0530, Ani Sinha wrote: > > > > On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > >> Code changes that addresses all compiler complaints coming from enabling > >> -Wshadow flags.

RE: [PATCH 07/22] exec/cpu: Introduce the CPU address space destruction function

Hi Phillipe, This patch has been taken as it is from ARM's RFC and the common patch-set mentioned below. So SOBs are all wrong everywhere. Original RFC posted in the year 2020. [1] https://lore.kernel.org/qemu-devel/20200613213629.21984-23-salil.me...@huawei.com/ Recently posted RFC V2 [2]

Re: [PATCH v4 16/18] virtio-mem: Expose device memory dynamically via multiple memslots if enabled

On 30.09.23 19:31, Maciej S. Szmigiero wrote: On 26.09.2023 20:57, David Hildenbrand wrote: Having large virtio-mem devices that only expose little memory to a VM is currently a problem: we map the whole sparse memory region into the guest using a single memslot, resulting in one gigantic

  1   2   3   >