[PATCH v2 1/3] migration/doc: Add documentation for backwards compatiblity

2023-10-17 Thread Juan Quintela
State what are the requeriments to get migration working between qemu versions. And once there explain how one is supposed to implement a new feature/default value and not break migration. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Xu Signed-off-by: Juan Quintela ---

Re: [PATCH v2 01/27] vfio: Rename VFIOContainer into VFIOLegacyContainer

2023-10-17 Thread Cédric Le Goater
Hello, On 10/16/23 10:31, Zhenzhong Duan wrote: From: Eric Auger In the prospect to introduce a base object for the VFIOContainer and derive into the existing legacy container and the iommufd based container, let's rename the existing one into VFIOLegacyContainer. This is just an incremental

Re: [PATCH v2 02/27] vfio: Introduce base object for VFIOContainer and targetted interface

2023-10-17 Thread Cédric Le Goater
On 10/16/23 10:31, Zhenzhong Duan wrote: From: Eric Auger Introduce a dumb VFIOContainer base object and its targetted interface. This is willingly not a QOM object because we don't want it to be visible from the user interface. The VFIOContainer will be smoothly populated in subsequent

Re: [PATCH qemu v3 0/1] Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

2023-10-17 Thread Peter Maydell
On Tue, 17 Oct 2023 at 11:44, ~h0lyalg0rithm wrote: > > Remove NULL check for g_new changes > > Suraj Shirvankar (1): > Switch memory management calls to new coding conventions Hi; it looks like you forgot to remove some of the NULL-checks; the ones for the g_malloc() changes also are

Re: [RFC PATCH] target/m68k: Use i128 for 128-bit load/store in m68k_copy_line()

2023-10-17 Thread Richard Henderson
On 10/17/23 05:27, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20231013175109.124308-1-richard.hender...@linaro.org> tcg: Add tcg_gen_{ld,st}_i128 RFC because unsure and untested... --- target/m68k/translate.c | 14 -- 1 file changed, 4

Re: [PATCH v5 2/7] migration: migrate 'inc' command option is deprecated.

2023-10-17 Thread Markus Armbruster
Juan Quintela writes: > Use blockdev-mirror with NBD instead. > > Reviewed-by: Thomas Huth > Acked-by: Stefan Hajnoczi > Signed-off-by: Juan Quintela > > --- > > Improve documentation and style (thanks Markus) > --- > docs/about/deprecated.rst | 8 > qapi/migration.json

Re: [PATCH v5 5/7] migration: Deprecate old compression method

2023-10-17 Thread Markus Armbruster
Juan Quintela writes: > Signed-off-by: Juan Quintela > Acked-by: Stefan Hajnoczi > Acked-by: Peter Xu > --- > docs/about/deprecated.rst | 8 > qapi/migration.json | 79 +-- > migration/options.c | 13 +++ > 3 files changed, 72

[PATCH 5/7] hw/dma: Declare link using static DEFINE_PROP_LINK() macro

2023-10-17 Thread Philippe Mathieu-Daudé
Declare link statically using DEFINE_PROP_LINK(). Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/xilinx_axidma.c | 6 ++ hw/dma/xlnx-zdma.c | 7 ++- hw/dma/xlnx_csu_dma.c | 13 - 3 files changed, 8 insertions(+), 18 deletions(-) diff --git a/hw/dma/xilinx_axidma.c

[PATCH 4/7] hw/scsi/virtio-scsi: Use VIRTIO_SCSI_COMMON() macro

2023-10-17 Thread Philippe Mathieu-Daudé
Access QOM parent with the proper QOM VIRTIO_SCSI_COMMON() macro. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 45b95ea070..fa53f0902c 100644 ---

Re: [PATCH v4] migration: Allow user to specify available switchover bandwidth

2023-10-17 Thread Markus Armbruster
Peter Xu writes: > Migration bandwidth is a very important value to live migration. It's > because it's one of the major factors that we'll make decision on when to > switchover to destination in a precopy process. > > This value is currently estimated by QEMU during the whole live migration >

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-17 Thread Jason Gunthorpe
On Tue, Oct 17, 2023 at 09:21:16AM -0600, Alex Williamson wrote: > Do we therefore need some programatic means for the kernel driver to > expose the node configuration to userspace? What interfaces would > libvirt like to see here? Is there an opportunity that this could > begin to define

Re: [PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

2023-10-17 Thread Peter Xu
On Tue, Oct 17, 2023 at 08:32:02AM +0200, Markus Armbruster wrote: > I can see two useful QAPI generator features: Agreed. > > * Improved handling of missing member documentation > > Problem: many members lack documentation. We silently generate > documentation like > >

Re: [PATCH v2 3/3] arm/kvm: convert to read_sys_reg64

2023-10-17 Thread Cornelia Huck
On Tue, Oct 17 2023, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 15:25, Cornelia Huck wrote: >> >> We can use read_sys_reg64 to get the SVE_VLS register instead of >> calling GET_ONE_REG directly. >> >> Suggested-by: Gavin Shan >> Signed-off-by: Cornelia Huck >> --- >> target/arm/kvm64.c |

[PATCH] MAINTAINERS: Add include/hw/intc/loongson_liointc.h to the Loongson-3 virt section

2023-10-17 Thread Thomas Huth
The corresponding .c file is already listed here, so we should mention the header here, too. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d0a21cfd9f..c3eb4f90ef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH] MAINTAINERS: Add include/hw/openrisc/ to the OpenRISC section

2023-10-17 Thread Thomas Huth
hw/openrisc/ is already listed here, so we should mention the folder for the headers here, too. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d9767b80f7..60cec3f701 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH v5 4/7] migration: Deprecate block migration

2023-10-17 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> # >> +# @deprecated: Member @block-incremental is deprecated. Use > > Two spaces between sentences for consistency, please. Done. At least here I did the copy and paste right. >> diff --git a/migration/block.c b/migration/block.c >> index

[PATCH v2 09/11] hw/hppa: Provide RTC and DebugOutputPort on CPU #0

2023-10-17 Thread deller
From: Helge Deller For SeaBIOS-hppa, the RTC and DebugOutputPort were in the I/O area of the LASI chip of the emulated B160L machine. Since we will add other machines without a LASI chip, move the emulated devices into the I/O area of CPU#0 instead. Signed-off-by: Helge Deller ---

[PATCH v2 10/11] hw/hppa: Split out machine creation

2023-10-17 Thread deller
From: Helge Deller This is a preparation patch to allow the creation of additional hppa machine. It splits out the creation of the machine into a - machine_HP_common_init_cpus(), and a - machine_HP_common_init_tail() function. This will allow to reuse the basic functions which are common to

[PATCH v2 08/11] hw/hppa: Export machine name, BTLBs, power-button address via fw_cfg

2023-10-17 Thread deller
From: Helge Deller Provide necessary info to SeaBIOS-hppa. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index c6d8deffcf..de925259ea 100644 ---

[PATCH v2 07/11] hw/hppa: Require at least SeaBIOS-hppa version 10

2023-10-17 Thread deller
From: Helge Deller The new SeaBIOS-hppa version 10 includes initial support for PA2.0 CPUs. Additionally update copyright and drop commented-out code. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 11/11] hw/hppa: Add new HP C3700 machine

2023-10-17 Thread deller
From: Helge Deller Add code to create an emulated C3700 machine. It includes the following components: - HP Powerbar SP2 Diva BMC card (serial port only) - PCI 4x serial card (for serial ports #1-#4) - USB OHCI controller with USB keyboard and USB mouse Signed-off-by: Helge Deller ---

[PATCH v2 02/11] pci_ids/tulip: Add PCI vendor ID for HP and use it in tulip

2023-10-17 Thread deller
From: Helge Deller Signed-off-by: Helge Deller --- hw/net/tulip.c | 2 +- include/hw/pci/pci_ids.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/tulip.c b/hw/net/tulip.c index 915e5fb595..11d866e431 100644 --- a/hw/net/tulip.c +++ b/hw/net/tulip.c @@

[PATCH v2 04/11] MAINTAINERS: Add Astro PCI host for hppa machines

2023-10-17 Thread deller
From: Helge Deller Signed-off-by: Helge Deller --- MAINTAINERS | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ceea4c2bf2..68d086a0f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c HP-PARISC

[PATCH] hw/audio/pcspk: Inline pcspk_init()

2023-10-17 Thread Philippe Mathieu-Daudé
pcspk_init() is a legacy init function, inline and remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/audio/pcspk.h | 10 -- hw/i386/pc.c | 3 ++- hw/isa/i82378.c | 5 - hw/mips/jazz.c | 5 - 4 files changed, 10 insertions(+), 13

Re: [PATCH 2/2] target/arm: Implement Neoverse N2 CPU model

2023-10-17 Thread Alex Bennée
Peter Maydell writes: > Implement a model of the Neoverse N2 CPU. This is an Armv9.0-A > processor very similar to the Cortex-A710. The differences are: > * no FEAT_EVT > * FEAT_DGH (data gathering hint) > * FEAT_NV (not yet implemented in QEMU) > * Statistical Profiling Extension (not

Re: [PATCH v5 4/7] migration: Deprecate block migration

2023-10-17 Thread Markus Armbruster
Juan Quintela writes: > It is obsolete. It is better to use driver-mirror with NBD instead. > > CC: Kevin Wolf > CC: Eric Blake > CC: Stefan Hajnoczi > CC: Hanna Czenczek > > Signed-off-by: Juan Quintela > Acked-by: Stefan Hajnoczi > --- > docs/about/deprecated.rst | 10 ++ >

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-17 Thread Ankit Agrawal
>> -device >>vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \ >> -object >>nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8 > > Why didn't we just implement start and count in the base object (or a > list)? It seems

[PATCH 7/7] hw/usb: Declare link using static DEFINE_PROP_LINK() macro

2023-10-17 Thread Philippe Mathieu-Daudé
Pull the 'dma' property to the core XHCI type, declare its link statically using DEFINE_PROP_LINK(). Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-xhci-sysbus.c | 4 hw/usb/hcd-xhci.c| 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-17 Thread Stefan Hajnoczi
On Wed, Oct 11, 2023 at 02:14:26PM +0800, lv.mengz...@zte.com.cn wrote: > From: hujian > > During the stop of dataplane for virtio-blk, > virtio_bus_cleanup_host_notifier() is be > called to clean up notifier at the end, if polled ioeventfd, > virtio_blk_handle_output() > is used to handle io

Re: [PULL 19/25] gdbstub: Replace gdb_regs with an array

2023-10-17 Thread Fabiano Rosas
Alex Bennée writes: > From: Akihiko Odaki > > An array is a more appropriate data structure than a list for gdb_regs > since it is initialized only with append operation and read-only after > initialization. > > Signed-off-by: Akihiko Odaki > Reviewed-by: Alistair Francis > Message-Id:

Re: [PATCH v3 2/3] migration/docs: How to migrate when hosts have different features

2023-10-17 Thread Juan Quintela
Peter Xu wrote: > On Mon, May 15, 2023 at 10:32:00AM +0200, Juan Quintela wrote: >> +$ qemu-system-x86_64 -cpu host,pcid=off,stibp=off >> + >> +Host B: >> + >> +$ qemu-system-x86_64 -cpu host,taa-no=off > > Since we're using cpu as example, shall we at least mention at the end that > we don't

Re: [PATCH v3 3/3] migration/doc: We broke backwards compatibility

2023-10-17 Thread Juan Quintela
Peter Xu wrote: > On Mon, May 15, 2023 at 10:32:01AM +0200, Juan Quintela wrote: >> When we detect that we have broken backwards compantibility in a >> released version, we can't do anything for that version. But once we >> fix that bug on the next released version, we can "mitigate" that >>

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-17 Thread Ankit Agrawal
>> An admin can provide the range of nodes using numa-node-start and >> numa-node-count and link it to a device by providing its id. The following >> sample creates 8 nodes and link them to the device dev0: >> >> -numa node,nodeid=2 \ >> -numa node,nodeid=3 \ >> -numa

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-17 Thread Peter Xu
On Tue, Oct 17, 2023 at 02:38:48AM +0200, William Roche wrote: > On 10/16/23 18:48, Peter Xu wrote: > > On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: > > > diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c > > > index 5e95c496bb..e8db6380c1 100644 > > > ---

[PATCH v2 2/3] migration/doc: How to migrate when hosts have different features

2023-10-17 Thread Juan Quintela
Sometimes devices have different features depending of things outside of qemu. For instance the kernel. Document how to handle that cases. Signed-off-by: Juan Quintela Acked-by: Peter Xu --- If you have some example to put here, I am all ears. I guess that virtio-* with some features that

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-17 Thread Alex Williamson
On Tue, 17 Oct 2023 14:00:54 + Ankit Agrawal wrote: > >> -device > >>vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \ > >> -object > >>nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8 > >> > > > > Why didn't

[PATCH v2 0/3] Migration Documentation for backward compatibility

2023-10-17 Thread Juan Quintela
Hi This series contains the documentation for migration. It is intentded for both qemu developers and developers of management applications. Please, review. Juan Quintela (3): migration/doc: Add documentation for backwards compatiblity migration/doc: How to migrate when hosts have

Re: [PATCH 2/4] qapi: introduce device-sync-config

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
On 17.10.23 17:57, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not triggered interrupt to the guest or just not available (not supported by

Re: [PATCH v4] migration: Allow user to specify available switchover bandwidth

2023-10-17 Thread Peter Xu
On Tue, Oct 17, 2023 at 04:12:40PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Migration bandwidth is a very important value to live migration. It's > > because it's one of the major factors that we'll make decision on when to > > switchover to destination in a precopy process. > >

[PATCH] configure: define "pkg-config" in addition to "pkgconfig"

2023-10-17 Thread Paolo Bonzini
Meson used to allow both "pkgconfig" and "pkg-config" entries in machine files; the former was used for dependency lookup and the latter was used as return value for "find_program('pkg-config')", which is a less common use-case and one that QEMU does not need. This inconsistency is going to be

[PATCH v2 03/11] hw/pci-host: Add Astro system bus adapter found on PA-RISC machines

2023-10-17 Thread deller
From: Helge Deller The 64-bit PA-RISC machines use a Astro system bus adapter (SBA) with Elroy PCI host chips. Later generation Astro chips were named Pluto, Ike and REO. Signed-off-by: Helge Deller --- hw/pci-host/astro.c | 876

[PATCH v2 06/11] pci-host: Wire up new Astro/Elroy PCI bridge

2023-10-17 Thread deller
From: Helge Deller Allow the Astro source to be built. Signed-off-by: Helge Deller --- hw/hppa/Kconfig | 1 + hw/pci-host/Kconfig | 4 hw/pci-host/meson.build | 1 + 3 files changed, 6 insertions(+) diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig index 5dd8b5b21e..ff8528aaa8

[PATCH v2 05/11] lasips2: LASI PS/2 devices are not user-createable

2023-10-17 Thread deller
From: Helge Deller Those PS/2 ports are created with the LASI controller when a 32-bit PA-RISC machine is created. Mark them not user-createable to avoid showing them in the qemu device list. Signed-off-by: Helge Deller Cc: qemu-sta...@nongnu.org --- hw/input/lasips2.c | 2 ++ 1 file

[PATCH v2 00/11] target/hppa: Add emulation of a C3700 HP-PARISC workstation

2023-10-17 Thread deller
From: Helge Deller This series adds a new PA-RISC machine emulation for the HP-PARISC C3700 workstation. The physical HP C3700 machine has a PA2.0 (64-bit) CPU, in contrast to the existing emulation of a B160L workstation which is a 32-bit only machine and where it's Dino PCI controller isn't

[PATCH v8 3/7] block: make bdrv_find_child() function public

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
To be reused soon for blockdev-replace functionality. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 13 + blockdev.c | 14 -- include/block/block_int-io.h | 2 ++ 3 files changed, 15 insertions(+), 14 deletions(-) diff

[PATCH v8 5/7] block: bdrv_get_xdbg_block_graph(): report export ids

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
Currently for block exports we report empty blk names. That's not good. Let's try to find corresponding block export and report its id. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 4 block/export/export.c | 13 + include/block/export.h

[PATCH v8 6/7] iotests.py: introduce VM.assert_edges_list() method

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
Add an alternative method to check block graph, to be used in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

[PATCH v8 7/7] iotests: add filter-insertion

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
Demonstrate new blockdev-replace API for filter insertion and removal. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/filter-insertion | 236 ++ tests/qemu-iotests/tests/filter-insertion.out | 5 + 2 files changed, 241 insertions(+) create mode

[PATCH v8 1/7] block-backend: blk_root(): drop const specifier on return type

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
We'll need get non-const child pointer for graph modifications in further commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-backend.c | 2 +- include/sysemu/block-backend-global-state.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v8 0/7] blockdev-replace

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
Hi all! This series presents a new command blockdev-replace, which helps to insert/remove filters anywhere in the block graph. It can: - replace qdev block-node by qdev-id - replace export block-node by export-id - replace any child of parent block-node by node-name and child name So

[PATCH v8 4/7] qapi: add x-blockdev-replace command

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
Add a command that can replace bs in following BdrvChild structures: - qdev blk root child - block-export blk root child - any child of BlockDriverState selected by child-name Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 56

[PATCH v8 2/7] block/export: add blk_by_export_id()

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
We need it for further blockdev-replace functionality. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/export/export.c | 18 ++ include/sysemu/block-backend-global-state.h | 1 + 2 files changed, 19 insertions(+) diff --git a/block/export/export.c

[PATCH v4 0/5] gdbstub and TCG plugin improvements

2023-10-17 Thread Akihiko Odaki
This series extracts fixes and refactorings that can be applied independently from "[PATCH v9 00/23] plugins: Allow to read registers". The patch "target/riscv: Move MISA limits to class" was replaced with patch "target/riscv: Move misa_mxl_max to class" since I found instances may have different

[PATCH v4 2/5] target/riscv: Remove misa_mxl validation

2023-10-17 Thread Akihiko Odaki
It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki --- target/riscv/tcg/tcg-cpu.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/target/riscv/tcg/tcg-cpu.c

[PATCH v4 3/5] target/riscv: Move misa_mxl_max to class

2023-10-17 Thread Akihiko Odaki
misa_mxl_max is common for all instances of a RISC-V CPU class so they are better put into class. Signed-off-by: Akihiko Odaki --- target/riscv/cpu-qom.h | 1 + target/riscv/cpu.h | 3 +- hw/riscv/boot.c| 2 +- target/riscv/cpu.c | 118

[PATCH v4 5/5] plugins: Remove an extra parameter

2023-10-17 Thread Akihiko Odaki
copy_call() has an unused parameter so remove it. Signed-off-by: Akihiko Odaki --- accel/tcg/plugin-gen.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 39b3c9351f..78b331b251 100644 --- a/accel/tcg/plugin-gen.c

[PATCH v4 4/5] target/riscv: Validate misa_mxl_max only once

2023-10-17 Thread Akihiko Odaki
misa_mxl_max is now a class member and initialized only once for each class. This also moves the initialization of gdb_core_xml_file which will be referenced before realization in the future. Signed-off-by: Akihiko Odaki --- target/riscv/cpu.c | 21 +

[PATCH v4 1/5] gdbstub: Check if gdb_regs is NULL

2023-10-17 Thread Akihiko Odaki
cpu->gdb_regs may be NULL if no coprocessor is registered. Fixes: 73c392c26b ("gdbstub: Replace gdb_regs with an array") Signed-off-by: Akihiko Odaki --- gdbstub/gdbstub.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/gdbstub/gdbstub.c

Re: [PATCH 3/4] [WTF] avoid qemu_del_nic() in xen_netdev_unrealize() on shutdown

2023-10-17 Thread David Woodhouse
On Tue, 2023-10-17 at 19:25 +0100, David Woodhouse wrote: > From: David Woodhouse > > When QEMU is exiting, qemu_cleanup() calls net_cleanup(), which deletes > the NIC from underneath the xen-net-device. When xen_netdev_unrealize() > is later called via the xenbus exit notifier, it crashes. > >

Re: [PULL 00/38] Migration 20231017 patches

2023-10-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/9] virtio-gpu patches

2023-10-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v13 01/18] gdbstub: Add num_regs member to GDBFeature

2023-10-17 Thread Akihiko Odaki
Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to replace the magic numbers in code later. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée ---

[PATCH v13 00/18] plugins: Allow to read registers

2023-10-17 Thread Akihiko Odaki
Based-on: <20231017185406.13381-1-akihiko.od...@daynix.com> ("[PATCH v4 0/5] gdbstub and TCG plugin improvements") I and other people in the University of Tokyo, where I research processor design, found TCG plugins are very useful for processor design exploration. The feature we find missing is

[PATCH v13 03/18] gdbstub: Introduce GDBFeatureBuilder

2023-10-17 Thread Akihiko Odaki
GDBFeatureBuilder unifies the logic to generate dynamic GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Richard Henderson --- include/exec/gdbstub.h | 20 ++ gdbstub/gdbstub.c | 59 ++ 2 files changed, 79 insertions(+) diff --git

[PATCH v4 2/4] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-17 Thread BALATON Zoltan
The Articia S is a generic chipset supporting several different CPUs that were among others used on some PPC boards. This is a minimal emulation of the parts needed for emulating the AmigaOne board. Signed-off-by: BALATON Zoltan --- hw/pci-host/Kconfig | 5 + hw/pci-host/articia.c

[PATCH v4 1/4] via-ide: Fix legacy mode emulation

2023-10-17 Thread BALATON Zoltan
The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default to avoid confusion. Instead move setting the BARs to a callback on writing the PCI config

[PATCH v4 0/4] Add emulation of AmigaOne XE board

2023-10-17 Thread BALATON Zoltan
Changes in v4: - Found typo in comment in patch 1 so ended up rewording it again trying to make it more concise. Also take the idea of using range_covers_byte from Mark's patch - Added RFC patch for avocado test (untested, I don't have Avocado) Changes in v3: - Update values, comment and commit

[RFC PATCH v4 4/4] tests/avocado: Add test for amigaone board

2023-10-17 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- I have no idea if this works so testing and corrections are welcome but this could be a basic test. Booting further is a bit more involved as we'd need alternative VGA BIOS and selecting menu items in the firmware to allow CD boot so I did not try to automate

[PATCH v13 04/18] target/arm: Use GDBFeature for dynamic XML

2023-10-17 Thread Akihiko Odaki
In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Acked-by: Richard Henderson --- target/arm/cpu.h | 21 +++

[PATCH v13 08/18] gdbstub: Use GDBFeature for GDBRegisterState

2023-10-17 Thread Akihiko Odaki
Simplify GDBRegisterState by replacing num_regs and xml members with one member that points to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée --- gdbstub/gdbstub.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gdbstub/gdbstub.c

[PATCH v13 16/18] plugins: Use different helpers when reading registers

2023-10-17 Thread Akihiko Odaki
This avoids optimizations incompatible when reading registers. Signed-off-by: Akihiko Odaki --- accel/tcg/plugin-helpers.h | 3 ++- include/exec/plugin-gen.h | 4 ++-- include/hw/core/cpu.h | 4 ++-- include/qemu/plugin.h | 3 +++ plugins/plugin.h | 5 +++--

[PATCH v13 12/18] hw/core/cpu: Remove gdb_get_dynamic_xml member

2023-10-17 Thread Akihiko Odaki
This function is no longer used. Signed-off-by: Akihiko Odaki --- include/hw/core/cpu.h | 4 target/arm/cpu.h | 6 -- target/ppc/cpu.h | 1 - target/arm/cpu.c | 1 - target/arm/gdbstub.c | 18 -- target/ppc/cpu_init.c | 3 --- target/ppc/gdbstub.c

[PATCH v13 11/18] gdbstub: Infer number of core registers from XML

2023-10-17 Thread Akihiko Odaki
GDBFeature has the num_regs member so use it where applicable to remove magic numbers. Signed-off-by: Akihiko Odaki --- include/hw/core/cpu.h | 3 ++- target/s390x/cpu.h | 2 -- gdbstub/gdbstub.c | 5 - target/arm/cpu.c| 1 - target/arm/cpu64.c | 1 -

[PATCH v4 3/4] hw/ppc: Add emulation of AmigaOne XE board

2023-10-17 Thread BALATON Zoltan
The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware with patches to support AmigaOS and is very similar to pegasos2 so can be easily emulated sharing most code with pegasos2. The reason to emulate it is that AmigaOS comes in different versions for AmigaOne and PegasosII which

[PATCH v13 02/18] gdbstub: Introduce gdb_find_static_feature()

2023-10-17 Thread Akihiko Odaki
This function is useful to determine the number of registers exposed to GDB from the XML name. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- include/exec/gdbstub.h | 2 ++ gdbstub/gdbstub.c | 13

[PATCH v13 06/18] target/riscv: Use GDBFeature for dynamic XML

2023-10-17 Thread Akihiko Odaki
In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki --- target/riscv/cpu.h | 5 +-- target/riscv/cpu.c | 4 +--

[PATCH v13 07/18] gdbstub: Use GDBFeature for gdb_register_coprocessor

2023-10-17 Thread Akihiko Odaki
This is a tree-wide change to introduce GDBFeature parameter to gdb_register_coprocessor(). The new parameter just replaces num_regs and xml parameters for now. GDBFeature will be utilized to simplify XML lookup in a following change. Signed-off-by: Akihiko Odaki Acked-by: Alex Bennée ---

[PATCH v13 05/18] target/ppc: Use GDBFeature for dynamic XML

2023-10-17 Thread Akihiko Odaki
In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Richard Henderson --- target/ppc/cpu-qom.h | 4 ++-- target/ppc/cpu.h

[PATCH v13 18/18] contrib/plugins: Allow to log registers

2023-10-17 Thread Akihiko Odaki
This demonstrates how a register can be read from a plugin. Signed-off-by: Akihiko Odaki --- docs/devel/tcg-plugins.rst | 10 +++- contrib/plugins/execlog.c | 120 +++-- 2 files changed, 97 insertions(+), 33 deletions(-) diff --git a/docs/devel/tcg-plugins.rst

[PATCH v13 17/18] plugins: Allow to read registers

2023-10-17 Thread Akihiko Odaki
It is based on GDB protocol to ensure interface stability. The timing of the vcpu init hook is also changed so that the hook will get called after GDB features are initialized. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1706 Signed-off-by: Akihiko Odaki ---

Re: [PATCH v2 04/11] MAINTAINERS: Add Astro PCI host for hppa machines

2023-10-17 Thread BALATON Zoltan
On Tue, 17 Oct 2023, Helge Deller wrote: On 10/17/23 18:19, BALATON Zoltan wrote: On Tue, 17 Oct 2023, del...@kernel.org wrote: From: Helge Deller Signed-off-by: Helge Deller --- MAINTAINERS | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Is this better squashed in the previous

[PATCH v13 14/18] gdbstub: Expose functions to read registers

2023-10-17 Thread Akihiko Odaki
gdb_find_feature() and gdb_find_feature_register() find registers. gdb_read_register() actually reads registers. Signed-off-by: Akihiko Odaki --- include/exec/gdbstub.h | 5 + gdbstub/gdbstub.c | 31 ++- 2 files changed, 35 insertions(+), 1 deletion(-)

[PATCH v13 09/18] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb

2023-10-17 Thread Akihiko Odaki
Align the parameters of gdb_get_reg_cb and gdb_set_reg_cb with the gdb_read_register and gdb_write_register members of CPUClass to allow to unify the logic to access registers of the core and coprocessors in the future. Signed-off-by: Akihiko Odaki --- include/exec/gdbstub.h | 4 +-

[PATCH v13 10/18] gdbstub: Simplify XML lookup

2023-10-17 Thread Akihiko Odaki
Now we know all instances of GDBFeature that is used in CPU so we can traverse them to find XML. This removes the need for a CPU-specific lookup function for dynamic XMLs. Signed-off-by: Akihiko Odaki --- include/exec/gdbstub.h | 2 + gdbstub/gdbstub.c | 119

[PATCH v13 15/18] cpu: Call plugin hooks only when ready

2023-10-17 Thread Akihiko Odaki
The initialization and exit hooks will not affect the state of vCPU outside TCG context, but they may depend on the state of vCPU. Therefore, it's better to call plugin hooks after the vCPU state is fully initialized and before it gets uninitialized. Signed-off-by: Akihiko Odaki ---

[PATCH v13 13/18] gdbstub: Add members to identify registers to GDBFeature

2023-10-17 Thread Akihiko Odaki
These members will be used to help plugins to identify registers. The added members in instances of GDBFeature dynamically generated by CPUs will be filled in later changes. Signed-off-by: Akihiko Odaki --- include/exec/gdbstub.h | 3 +++ gdbstub/gdbstub.c | 10 --

Re: [PATCH v2 02/11] pci_ids/tulip: Add PCI vendor ID for HP and use it in tulip

2023-10-17 Thread BALATON Zoltan
On Tue, 17 Oct 2023, Helge Deller wrote: On 10/17/23 18:13, BALATON Zoltan wrote: On Tue, 17 Oct 2023, del...@kernel.org wrote: From: Helge Deller Signed-off-by: Helge Deller --- hw/net/tulip.c   | 2 +- include/hw/pci/pci_ids.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v2 02/11] pci_ids/tulip: Add PCI vendor ID for HP and use it in tulip

2023-10-17 Thread Helge Deller
On 10/17/23 21:19, BALATON Zoltan wrote: On Tue, 17 Oct 2023, Helge Deller wrote: On 10/17/23 18:13, BALATON Zoltan wrote: On Tue, 17 Oct 2023, del...@kernel.org wrote: From: Helge Deller Signed-off-by: Helge Deller --- hw/net/tulip.c   | 2 +- include/hw/pci/pci_ids.h | 2 ++ 2

Re: [PATCH v3 4/8] qemu-img: add chunk size parameter to compare_buffers()

2023-10-17 Thread Kevin Wolf
Am 19.09.2023 um 18:58 hat Andrey Drobyshev geschrieben: > Add @chsize param to the function which, if non-zero, would represent > the chunk size to be used for comparison. If it's zero, then > BDRV_SECTOR_SIZE is used as default chunk size, which is the previous > behaviour. > > In particular,

[PATCH v4 2/3] hw/arm: xlnx-versal-virt: Add AMD/Xilinx TRNG device

2023-10-17 Thread Tong Ho
Connect the support for Versal True Random Number Generator (TRNG) device. Warning: unlike the TRNG component in a real device from the Versal device familiy, the connected TRNG model is not of cryptographic grade and is not intended for use cases when cryptograpically strong TRNG is needed.

[PATCH v4 1/3] hw/misc: Introduce AMD/Xilix Versal TRNG device

2023-10-17 Thread Tong Ho
This adds a non-cryptographic grade implementation of the model for the True Random Number Generator (TRNG) component in AMD/Xilinx Versal device family. This implements all 3 modes defined by the actual hardware specs, all of which selectable by guest software at will at anytime: 1) PRNG mode,

[PATCH v4 0/3] AMD/Xilinx Versal TRNG support

2023-10-17 Thread Tong Ho
This series adds support for the True Random Number Generator (TRNG) in the AMD/Xilinx Versal family of devices. The series starts by introducing a non-cryptographic grade model of the TRNG controller in the Versal family of devices, followed by instantiating the model in Xilinx Versal machine.

[PATCH v4 3/3] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

2023-10-17 Thread Tong Ho
Signed-off-by: Tong Ho --- tests/qtest/meson.build | 2 +- tests/qtest/xlnx-versal-trng-test.c | 486 2 files changed, 487 insertions(+), 1 deletion(-) create mode 100644 tests/qtest/xlnx-versal-trng-test.c diff --git a/tests/qtest/meson.build

Re: [PATCH v2 06/11] pci-host: Wire up new Astro/Elroy PCI bridge

2023-10-17 Thread Helge Deller
On 10/17/23 18:29, BALATON Zoltan wrote: On Tue, 17 Oct 2023, del...@kernel.org wrote: From: Helge Deller Allow the Astro source to be built. It was addded 3 patches earlier. Shuold this also be in that patch or at least closer to it? I will move it closer. Helge If you think that

Re: [PATCH v2 08/11] hw/hppa: Export machine name, BTLBs, power-button address via fw_cfg

2023-10-17 Thread Helge Deller
On 10/17/23 18:33, BALATON Zoltan wrote: On Tue, 17 Oct 2023, del...@kernel.org wrote: From: Helge Deller Provide necessary info to SeaBIOS-hppa. If this is needed by the updated SeaBIOS in patch 1 shouldn't this come before that? SeaBIOS has default values, so it's not dependend on the

[PATCH 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2023-10-17 Thread Nabih Estefan
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Signed-off-by: Hao Wu --- tests/qtest/meson.build | 1 +

[PATCH 09/11] hw/net: GMAC Rx Implementation

2023-10-17 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx NOTE: At this point in development we believe this function is working as intended, and the kernel supports these findings, but we need

[PATCH 11/11] tests/qtest: Adding PCS Module test to GMAC Qtest

2023-10-17 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Signed-off-by: Nabih Estefan Diaz --- tests/qtest/npcm_gmac-test.c | 134 ++- 1 file changed, 133 insertions(+), 1 deletion(-) diff --git a/tests/qtest/npcm_gmac-test.c

[PATCH 10/11] hw/net: GMAC Tx Implementation

2023-10-17 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Signed-off-by: Nabih

[PATCH 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-10-17 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v2] Fixed bugs related to the RC functionality of the GMAC. Added and squashed patches related to that. [Changes since v1] Fixed some errors in formatting. Fixed a merge error that I didn't see in v1. Removed Nuvoton 8xx references since that is a separate

<    1   2   3   4   5   6   >