Re: [PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/vt82c686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index

[PATCH 2/4] hw/isa/pc87312: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/pc87312.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index ee23f3e164df..64dd17b537f2 100644 ---

[PATCH 0/4] Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Hi list, Now we already have the device_class_set_parent_realize() to set parent realize(), thus clean up the places where that helper was forgotten. Regards, Zhao --- Zhao Liu (4): hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize() hw/isa/pc87312:

[PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread Thomas Huth
For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device, and the code should reside in a separate file. Signed-off-by: Thomas Huth --- hw/ide/qdev-ide.h | 41

Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU

2024-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2024 at 10:57:32AM +0800, Zhao Liu wrote: > Hi Daniel, > > On Wed, Jan 31, 2024 at 10:28:42AM +, Daniel P. Berrangé wrote: > > Date: Wed, 31 Jan 2024 10:28:42 + > > From: "Daniel P. Berrangé" > > Subject: Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU > > > >

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > Multifd send side has two fields to indicate error quits: > > > > - MultiFDSendParams.quit > > - _send_state->exiting > > > > Merge them into the global one. The

Re: [PATCH 3/4] hw/intc/s390_flic: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/intc/s390_flic_kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c

Re: [PATCH 4/4] hw/arm/smmuv3: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/arm/smmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index

Re: [PATCH 2/4] hw/isa/pc87312: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/pc87312.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index

Re: [PATCH 04/14] migration/multifd: Postpone reset of MultiFDPages_t

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 12:27:51PM -0300, Fabiano Rosas wrote: > > +/* Reset a MultiFDPages_t* object for the next use */ > > +static void multifd_pages_reset(MultiFDPages_t *pages) > > +{ > > +/* > > + * We don't need to touch offset[] array, because it will be > > + * overwritten

[PATCH v2 1/2] system/memory.c: support unaligned access

2024-02-01 Thread Tomoyuki HIROSE
The previous code ignored 'impl.unaligned' and handled unaligned accesses as is. But this implementation cannot emulate specific registers of some devices that allow unaligned access such as xHCI Host Controller Capability Registers. This commit checks 'impl.unaligned' and if it is false, QEMU

[PATCH v2 2/2] hw/usb/hcd-xhci.c: allow unaligned access to Capability Registers

2024-02-01 Thread Tomoyuki HIROSE
According to xHCI spec rev 1.2, unaligned access to xHCI Host Controller Capability Registers is not prohibited. In Addition, the limit of access size is also unspecified. Actually, some real devices allow unaligned access and 8-byte access to these registers. This commit makes it possible to

[PATCH v2 0/2] support unaligned access for some xHCI registers

2024-02-01 Thread Tomoyuki HIROSE
v1 -> v2: * Improved the calculation of addresses and masks in memory.c. According to xHCI spec rev 1.2, unaligned access to xHCI Host Controller Capability Registers are not prohibited. But current implementation does not support unaligned access to 'MemoryRegion'. These patches contain 2

[PATCH 3/4] hw/intc/s390_flic: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/intc/s390_flic_kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c index

[PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/vt82c686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index d3e0f6d01fb6..a99eae4f6333 100644 ---

[PATCH 4/4] hw/arm/smmuv3: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/arm/smmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 68eeef3e1d4c..b3d8642a4990 100644 ---

[PATCH v6] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-02-01 Thread Shaoqin Huang
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide which PMU events are provided to the guest. Add a new option `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. Without the filter, all PMU events are exposed from host to guest by default. The usage of the

Re: [PATCH v4 37/47] hw/net/lasi_i82596: Re-enable build

2024-02-01 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse When converting to the shiny build-system-du-jour, a typo prevented the last_i82596 driver from being built. Correct the config option name to re-enable the build. And include "sysemu/sysemu.h" so it actually builds. Fixes:

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 31.01.24 11:17, Kevin Wolf wrote: Am 29.01.2024 um 17:30 hat Hanna Czenczek geschrieben: I don’t like using drain as a form of lock specifically against AioContext changes, but maybe Stefan is right, and we should use it in this specific case to get just the single problem fixed.  (Though

Re: [PATCH 5/5] hw/core: Remove transitional infrastructure from BusClass

2024-02-01 Thread Peter Maydell
On Wed, 31 Jan 2024 at 03:44, Zhao Liu wrote: > > On Fri, Jan 19, 2024 at 04:35:12PM +, Peter Maydell wrote: > > Date: Fri, 19 Jan 2024 16:35:12 + > > From: Peter Maydell > > Subject: [PATCH 5/5] hw/core: Remove transitional infrastructure from > > BusClass > > X-Mailer: git-send-email

[PATCH v6 6/6] target/riscv: Enable updates for pointer masking variables and thus enable pointer masking extension

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ded84f2e09..23d1692b59 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Jonathan Cameron via
On Thu, 1 Feb 2024 13:12:23 + Peter Maydell wrote: > On Thu, 1 Feb 2024 at 13:04, Jonathan Cameron via > wrote: > > > > > > > > root@localhost:~/devmem2# numactl --membind=1 touch a > > qemu: fatal: cpu_io_recompile: could not find TB for pc=(nil) > > Can you run QEMU under gdb

[PULL 14/17] hw/arm: Hook up FSI module in AST2600

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This patchset introduces IBM's Flexible Service Interface(FSI). Time for some fun with inter-processor buses. FSI allows a service processor access to the internal buses of a host POWER processor to perform configuration or debugging. FSI has long existed in POWER processes

[PULL 11/17] hw/fsi: Introduce IBM's cfam

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SBEFIFO and I2C

[PULL 06/17] hw/arm/aspeed: Check for CPU types in machine_run_board_init()

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Aspeed SoCs use a single CPU type (set as AspeedSoCClass::cpu_type). Convert it to a NULL-terminated array (of a single non-NULL element). Set MachineClass::valid_cpu_types[] to use the common machine code to provide hints when the requested CPU is invalid (see

Re: [PATCH v2 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote: > > If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged > helper functions that require additional functions for linking. The > reduced set of the linux-user functions works fine as stubs in this > case, so change the #ifdef

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 14:01, Jonathan Cameron wrote: > > Can you run QEMU under gdb and give the backtrace when it stops > > on the abort() ? That will probably have a helpful clue. I > > suspect something is failing to pass a valid retaddr in > > when it calls a load/store function. >

[PATCH v8 1/2] ppc: Enable 2nd DAWR support on Power10 PowerNV machine

2024-02-01 Thread Shivaprasad G Bhat
Extend the existing watchpoint facility from TCG DAWR0 emulation to DAWR1 on POWER10. Signed-off-by: Shivaprasad G Bhat --- target/ppc/cpu.c | 45 -- target/ppc/cpu.h |8 +- target/ppc/cpu_init.c| 15 +++

[PATCH v8 2/2] ppc: spapr: Enable 2nd DAWR on Power10 pSeries machine

2024-02-01 Thread Shivaprasad G Bhat
As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to find whether kvm supports 2nd DAWR or not. If it's supported, allow user to set the pa-feature

Re: [PATCH v2 2/3] hw/i2c/smbus_slave: Add object path on error prints

2024-02-01 Thread Peter Maydell
On Fri, 26 Jan 2024 at 00:56, Joe Komlodi wrote: > > The current logging doesn't tell us which specific smbus device is an > error state. > > Signed-off-by: Joe Komlodi > --- > hw/i2c/smbus_slave.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 15:17, Alex Bennée wrote: > > Peter Maydell writes: > > So, that looks like: > > * we call cpu_tb_exec(), which executes some generated code > > * that generated code calls the lookup_tb_ptr helper to see > >if we have a generated TB already for the address we're

Re: [PATCH v2 0/3] virt: wire up NS EL2 virtual timer IRQ

2024-02-01 Thread Peter Maydell
Ping for code review, please? thanks -- PMM On Mon, 22 Jan 2024 at 14:35, Peter Maydell wrote: > > This patchset wires up the NS EL2 virtual timer IRQ on the virt > board, similarly to what commit 058262e0a8b2 did for the sbsa-ref board. > > Version 1 was an RFC patchset, originally sent back

Re: [PATCH] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-02-01 Thread Peter Maydell
On Tue, 23 Jan 2024 at 11:03, Cédric Le Goater wrote: > > On 1/12/24 14:46, Peter Maydell wrote: > > The raven_io_ops MemoryRegionOps is the only one in the source tree > > which sets .valid.unaligned to indicate that it should support > > unaligned accesses and which does not also set

[PULL 13/17] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through

[PULL 10/17] hw/fsi: Introduce IBM's fsi-slave model

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address

[PULL 09/17] hw/fsi: Introduce IBM's FSI Bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg: - removed include/hw/fsi/engine-scratchpad.h and

[PULL 16/17] hw/fsi: Added FSI documentation

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Documentation for IBM FSI model. Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg : - Removed source file list - Fixed aspeed machine reference ] Signed-off-by: Cédric Le Goater --- docs/specs/fsi.rst | 122

[PULL 07/17] hw/fsi: Introduce IBM's Local bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery Signed-off-by: Ninad

[PULL v2 00/17] aspeed queue

2024-02-01 Thread Cédric Le Goater
The following changes since commit bd2e12310b18b51aefbf834e6d54989fd175976f: Merge tag 'qga-pull-2024-01-30' of https://github.com/kostyanf14/qemu into staging (2024-01-30 15:53:46 +) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20240201

Re: [PATCH v2 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote: > > Move the code to a separate file so that we do not have to compile > it anymore if CONFIG_ARM_V7M is not set. > > Signed-off-by: Thomas Huth > --- > target/arm/tcg/cpu-v7m.c | 290 + >

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Stefan Hajnoczi
On Thu, Feb 01, 2024 at 03:10:12PM +0100, Hanna Czenczek wrote: > On 31.01.24 21:35, Stefan Hajnoczi wrote: > > On Fri, Jan 26, 2024 at 04:24:49PM +0100, Hanna Czenczek wrote: > > > On 26.01.24 14:18, Kevin Wolf wrote: > > > > Am 25.01.2024 um 18:32 hat Hanna Czenczek geschrieben: > > > > > On

Re: [PATCH] pci-host: designware: Limit value range of iATU viewport register

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 06:00, Guenter Roeck wrote: > > The latest version of qemu (v8.2.0-869-g7a1dc45af5) crashes when booting > the mcimx7d-sabre emulation with Linux v5.11 and later. > > qemu-system-arm: ../system/memory.c:2750: memory_region_set_alias_offset: > Assertion `mr->alias' failed.

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Alex Bennée
Peter Maydell writes: > On Thu, 1 Feb 2024 at 14:01, Jonathan Cameron > wrote: >> > Can you run QEMU under gdb and give the backtrace when it stops >> > on the abort() ? That will probably have a helpful clue. I >> > suspect something is failing to pass a valid retaddr in >> > when it calls a

Re: [RFC PATCH v7] ppc: Enable 2nd DAWR support on p10

2024-02-01 Thread Shivaprasad G Bhat
Thanks for the review Nick! On 1/23/24 17:36, Nicholas Piggin wrote: On Wed Nov 22, 2023 at 5:32 PM AEST, Shivaprasad G Bhat wrote: Extend the existing watchpoint facility from TCG DAWR0 emulation to DAWR1 on POWER10. As per the PAPR, bit 0 of byte 64 in pa-features property indicates

Re: [PATCH v3 0/6] hw/{arm,xen} convert printfs to trace/reports

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 16:10, Manos Pitsidianakis wrote: > > This series changes some printfs to use the trace event framework. > Additionally, it converts some error/warning reporting fprintfs to > error_report/warn_report. > > v2 -> v3 > : > - addressed Peter Maydells's review > > v1 -> v2

Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU

2024-02-01 Thread Zhao Liu
Hi Daniel, On Thu, Feb 01, 2024 at 09:21:48AM +, Daniel P. Berrangé wrote: > Date: Thu, 1 Feb 2024 09:21:48 + > From: "Daniel P. Berrangé" > Subject: Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU > > On Thu, Feb 01, 2024 at 10:57:32AM +0800, Zhao Liu wrote: > > Hi Daniel, >

Re: [PATCH] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-02-01 Thread Cédric Le Goater
On 2/1/24 14:32, Peter Maydell wrote: On Tue, 23 Jan 2024 at 11:03, Cédric Le Goater wrote: On 1/12/24 14:46, Peter Maydell wrote: The raven_io_ops MemoryRegionOps is the only one in the source tree which sets .valid.unaligned to indicate that it should support unaligned accesses and which

Re: [PATCH v4] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-02-01 Thread Peter Maydell
On Tue, 30 Jan 2024 at 19:04, David Woodhouse wrote: > > From: David Woodhouse > > We can't just embed labels directly into files like qemu-options.hx which > are included from multiple top-level rST files, because Sphinx sees the > labels as duplicate:

[PATCH v6 1/6] target/riscv: Remove obsolete pointer masking extension code.

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Zjpm v0.8 is almost frozen and it's much simplier compared to the existing one: The newer version doesn't allow to specify custom mask or base for masking. Instead it allows only certain options for masking top bits. Signed-off-by: Alexey Baturo Acked-by: Alistair Francis

[PATCH v6 0/6] Pointer Masking update for Zjpm v0.8

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Hi, This patch series is rebased on https://github.com/alistair23/qemu/tree/riscv-to-apply.next Thanks [v5]: This patch series targets Zjpm v0.8 extension. The spec itself could be found here:

[PATCH v6 5/6] target/riscv: Update address modify functions to take into account pointer masking

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/translate.c | 22 -- target/riscv/vector_helper.c | 13 + 2 files changed, 29 insertions(+), 6 deletions(-) diff --git

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 31.01.24 21:35, Stefan Hajnoczi wrote: On Fri, Jan 26, 2024 at 04:24:49PM +0100, Hanna Czenczek wrote: On 26.01.24 14:18, Kevin Wolf wrote: Am 25.01.2024 um 18:32 hat Hanna Czenczek geschrieben: On 23.01.24 18:10, Kevin Wolf wrote: Am 23.01.2024 um 17:40 hat Hanna Czenczek geschrieben:

[PULL 02/17] hw/arm/aspeed: Remove dead code

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed: Adding new machine Tiogapass in QEMU"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Signed-off-by: Cédric Le Goater ---

[PATCH v8 0/2] ppc: Enable 2nd DAWR support on Power10

2024-02-01 Thread Shivaprasad G Bhat
Extends the existing watchpoint facility from TCG DAWR0 emulation to DAWR1 on Power10 for powernv in the first patch, and for pseries in the second patch with both TCG and KVM. --- Changelog: v7:

Re: [PATCH 04/14] migration/multifd: Postpone reset of MultiFDPages_t

2024-02-01 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jan 31, 2024 at 12:27:51PM -0300, Fabiano Rosas wrote: >> > +/* Reset a MultiFDPages_t* object for the next use */ >> > +static void multifd_pages_reset(MultiFDPages_t *pages) >> > +{ >> > +/* >> > + * We don't need to touch offset[] array, because it will be

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 01.02.24 15:28, Stefan Hajnoczi wrote: On Thu, Feb 01, 2024 at 03:10:12PM +0100, Hanna Czenczek wrote: On 31.01.24 21:35, Stefan Hajnoczi wrote: On Fri, Jan 26, 2024 at 04:24:49PM +0100, Hanna Czenczek wrote: On 26.01.24 14:18, Kevin Wolf wrote: Am 25.01.2024 um 18:32 hat Hanna Czenczek

Re: [PATCH v2 3/3] hw/i2c: smbus_slave: Reset state on reset

2024-02-01 Thread Peter Maydell
On Fri, 26 Jan 2024 at 00:56, Joe Komlodi wrote: > > If a reset comes while the SMBus device is not in its idle state, it's > possible for it to get confused on valid transactions post-reset. > > Signed-off-by: Joe Komlodi > --- > hw/i2c/smbus_slave.c | 9 + > 1 file changed, 9

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 01.02.24 16:25, Hanna Czenczek wrote: [...] It just seems simpler to me to not rely on the BB's context at all. Hm, I now see the problem is that the processing (and scheduling) is largely done in generic SCSI code, which doesn’t have access to virtio-scsi’s context, only to that of the

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: >> pet...@redhat.com writes: >> >> > From: Peter Xu >> > >> > Multifd send side has two fields to indicate error quits: >> > >> > - MultiFDSendParams.quit >> > - _send_state->exiting >> > >> > Merge them into

Re: [PATCH 0/2] system: Fix handling of '-serial none -serial something'

2024-02-01 Thread Peter Maydell
On Mon, 22 Jan 2024 at 16:36, Peter Maydell wrote: > > (This patchset fixes a bug reported by Bohdan Kostiv at > https://lore.kernel.org/qemu-devel/caa3sv1lq8ydunlcb5wqlvzjshffru0usbl_yyjw_m+db2ph...@mail.gmail.com/ > -- my patch 1 avoids a bug in his suggested change, and > patch 2 is new,

[PATCH v6 4/6] target/riscv: Add pointer masking tb flags

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h| 3 +++ target/riscv/cpu_helper.c | 3 +++ target/riscv/translate.c | 5 + 3 files changed, 11 insertions(+) diff --git a/target/riscv/cpu.h

Re: [PATCH v3 0/9] hw/arm: Check for CPU types in machine_run_board_init()

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 15:18, Philippe Mathieu-Daudé wrote: > > Series fully reviewed. > > Since v2: > - Rebased > - Remove default_cpu_type (Richard) > - Added R-b tags > > Since v1: > - Add missing QOM parent for CPU cores > - Dropped Aspeed changes (Cédric) > > Following Gavin recent CPU type

[PATCH v6 3/6] target/riscv: Add helper functions to calculate current number of masked bits for pointer masking

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.h| 4 +++ target/riscv/cpu_helper.c | 58 +++ 2 files changed, 62 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index

[PATCH v6 2/6] target/riscv: Add new CSR fields for S{sn, mn, m}pm extensions as part of Zjpm v0.8

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 8 target/riscv/cpu_bits.h | 3 +++ target/riscv/cpu_cfg.h | 3 +++ target/riscv/csr.c | 11 +++ target/riscv/machine.c | 10 +++--- target/riscv/pmp.c

[PULL 01/17] tests/avocado/machine_aspeed.py: Update buildroot images to 2023.11

2024-02-01 Thread Cédric Le Goater
Compared to mainline buildroot, these images have some customization : - Linux version is bumped to 6.6.3 and built with a custom config - U-Boot is switched to the one provided by OpenBMC for more support - defconfigs extra tools for dev See branch [1] for more details. There are a few changes

[PULL 04/17] hw/arm/aspeed: Init CPU defaults in a common helper

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater ---

[PULL 08/17] hw/fsi: Introduce IBM's scratchpad device

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers can be read or

[PULL 03/17] hw/arm/aspeed: Set default CPU count using aspeed_soc_num_cpus()

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Since commit b7f1a0cb76 ("arm/aspeed: Compute the number of CPUs from the SoC definition") Aspeed machines use the aspeed_soc_num_cpus() helper to set the number of CPUs. Use it for the ast1030-evb (commit 356b230ed1 "aspeed/soc: Add AST1030 support") and

[PULL 12/17] hw/fsi: Introduce IBM's FSI master

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driving CFAM engine

[PULL 15/17] hw/fsi: Added qtest

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Added basic qtests for FSI model. Signed-off-by: Ninad Palsule Acked-by: Thomas Huth [ clg: aspeed-fsi-test.c -> aspeed_fsi-test.c to match other filenames ] Signed-off-by: Cédric Le Goater --- tests/qtest/aspeed_fsi-test.c | 205 ++

[PULL 17/17] hw/fsi: Update MAINTAINER list

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Add maintainer for IBM FSI model Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg: - slight change in commit log - fixed file list ] Signed-off-by: Cédric Le Goater --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git

[PULL 05/17] hw/arm/aspeed: Introduce aspeed_soc_cpu_type() helper

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé In order to alter AspeedSoCClass::cpu_type in the next commit, introduce the aspeed_soc_cpu_type() helper to retrieve the per-SoC CPU type from AspeedSoCClass. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson

Re: [PATCH v2 1/3] hw/i2c: core: Add reset

2024-02-01 Thread Peter Maydell
On Fri, 26 Jan 2024 at 00:56, Joe Komlodi wrote: > > It's possible for a reset to come in the middle of a transaction, which > causes the bus to be in an old state when a new transaction comes in. > > Signed-off-by: Joe Komlodi > --- > hw/i2c/core.c| 30 +- >

Re: [PATCH] RISC-V: Report the QEMU vendor/arch IDs on virtual CPUs

2024-02-01 Thread Andrew Jones
On Wed, Jan 31, 2024 at 10:24:30AM -0800, Palmer Dabbelt wrote: > Right now we just report 0 for marchid/mvendorid in QEMU. That's legal, > but it's tricky for users that want to check if they're running on QEMU > to do so. This sets marchid to 42, which I've proposed as the QEMU > architecture

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Jonathan Cameron via
On Thu, 01 Feb 2024 15:17:53 + Alex Bennée wrote: > Peter Maydell writes: > > > On Thu, 1 Feb 2024 at 14:01, Jonathan Cameron > > wrote: > >> > Can you run QEMU under gdb and give the backtrace when it stops > >> > on the abort() ? That will probably have a helpful clue. I > >> >

Re: [RFC v1 3/3] hw/arm/virt-acpi-build.c: Enable CPU cache topology

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 11:08, Jonathan Cameron wrote: > > On Mon, 29 Jan 2024 00:14:23 -0800 > Sia Jee Heng wrote: > > > Introduced a 3-layer cache for the ARM virtual machine. > > > > Signed-off-by: Sia Jee Heng > > There are a bunch of CPU registers that also need updating to reflect the >

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-02-01 Thread David Woodhouse
On Thu, 2024-02-01 at 11:30 +0100, Thomas Huth wrote: > On 31/01/2024 15.18, David Woodhouse wrote: > > On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: > > > Don't we have to change nd->macaddr.a[0 to 2] with this hard-coded > > > MAC-prefix, too? > > > > I don't think so. > > > > We

Re: [PATCH 12/14] migration/multifd: multifd_send_prepare_header()

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 06:32:54PM -0300, Fabiano Rosas wrote: > > +if (!use_zero_copy_send) { > > +/* > > + * Only !zero_copy needs the header in IOV; zerocopy will > > + * send it separately. > > Could use the same spelling for both

Re: [PATCH 07/14] migration/multifd: Simplify locking in sender thread

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 05:21:06PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > The sender thread will yield the p->mutex before IO starts, trying to not > > block the requester thread. This may be unnecessary lock optimizations, > > because the requester

Re: [PULL 0/5] Block patches

2024-02-01 Thread Peter Maydell
On Tue, 30 Jan 2024 at 21:51, Stefan Hajnoczi wrote: > > The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: > > Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into > staging (2024-01-29 10:53:56 +) > > are available in the Git repository at: >

Re: [PULL 00/21] Trivial patches for 2024-01-31

2024-02-01 Thread Peter Maydell
On Wed, 31 Jan 2024 at 11:57, Michael Tokarev wrote: > > The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: > > Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into > staging (2024-01-29 10:53:56 +) > > are available in the Git repository at: >

Re: [PATCH v2] block/blkio: Make s->mem_region_alignment be 64 bits

2024-02-01 Thread Michael Tokarev
30.01.2024 15:20, Richard W.M. Jones : With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type

Re: [PATCH 09/88] esp: update TC check logic in do_dma_pdma_cb() to check for TC == 0

2024-02-01 Thread Mark Cave-Ayland
On 01/02/2024 10:46, Paolo Bonzini wrote: On Fri, Jan 12, 2024 at 1:55 PM Mark Cave-Ayland wrote: Invert the logic so that the end of DMA transfer check becomes one that checks for TC == 0 in the from device path in do_dma_pdma_cb(). Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 24

Re: [PATCH 1/3] gdbstub: Refactor fork() handling

2024-02-01 Thread Alex Bennée
Ilya Leoshkevich writes: > Prepare for implementing follow-fork-mode child: > * Introduce gdbserver_fork_start(), which for now is a no-op. > * Rename gdbserver_fork() to gdbserver_fork_end(), call it in both > parent and child processes, and pass the fork()'s return value to it. > * Factor

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message, thus avoid coredump in the build stage.

Re: [PATCH 2/3] gdbstub: Implement follow-fork-mode child

2024-02-01 Thread Alex Bennée
Ilya Leoshkevich writes: > Currently it's not possible to use gdbstub for debugging linux-user > code that runs in a forked child, which is normally done using the `set > follow-fork-mode child` GDB command. Purely on the protocol level, the > missing piece is the fork-events feature. > >

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
01.02.2024 15:11, Michael Tokarev wrote: 31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message,

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:50, Michael Tokarev wrote: > > 01.02.2024 15:11, Michael Tokarev wrote: > > 31.01.2024 11:13, Zhang Wen: > >> With this patch, qemu requires keyboard-config when libxkbcommon is found > >> on the system. So if the qemu is configured when libxkbcommon is installed > >>

Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:30, Alex Bennée wrote: > > This regressed qemu-system-xtensa: > > TESTtest_load_store on xtensa > qemu-system-xtensa: Some ROM regions are overlapping > These ROM regions might have been loaded by direct user request or by > default. > They could be

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 01.02.24 11:21, Kevin Wolf wrote: Am 01.02.2024 um 10:43 hat Hanna Czenczek geschrieben: On 31.01.24 11:17, Kevin Wolf wrote: Am 29.01.2024 um 17:30 hat Hanna Czenczek geschrieben: I don’t like using drain as a form of lock specifically against AioContext changes, but maybe Stefan is

Re: [PATCH] kconfig: use "select" to enable semihosting

2024-02-01 Thread Alex Bennée
Paolo Bonzini writes: > Just like all other dependencies, these can be expressed in Kconfig > files rather than in the default configurations. Queued to semihosting/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 5/5] kconfig: use "select" to enable semihosting

2024-02-01 Thread Alex Bennée
From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Message-Id: <20240129115809.1039924-1-pbonz...@redhat.com> Signed-off-by: Alex Bennée ---

Re: [PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: This might be premature but while streamling the avocado tests I s/streamling/streamlining/ ? realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be s/criss/cris/ used

Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2024 at 10:47:56AM +, Wentao Jia wrote: > Hi, Eugenio > > Thanks for you comments > > It is a dilemma, our team mainly work on smartNIC vDPA, features > implementation in the QEMU emulated devices is a certain workload for > us. In this case the implementation is mostly

Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Jonathan Cameron via
On Tue, 30 Jan 2024 13:50:18 +0530 Sajjan Rao wrote: > Hi Jonathan, > > The QEMU command line in the original email has been corrected back in > August 2023 based on the subsequent responses. > > My current QEMU command line reads like below. As you can see I am not > assigning numa to the CXL

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 13:04, Jonathan Cameron via wrote: > > root@localhost:~/devmem2# numactl --membind=1 touch a > qemu: fatal: cpu_io_recompile: could not find TB for pc=(nil) Can you run QEMU under gdb and give the backtrace when it stops on the abort() ? That will probably have a

Re: [External] Re: [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work

2024-02-01 Thread Fabiano Rosas
Hao Xiang writes: > On Wed, Jan 31, 2024 at 5:19 AM Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> > On Mon, Jan 29, 2024 at 09:51:06AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Mon, Jan 29, 2024 at 01:41:01AM +, Liu, Yuan1 wrote: >> >> >> Because this change

Re: [PATCH 1/6] vdpa: check for iova tree initialized at net_client_start

2024-02-01 Thread Eugenio Perez Martin
On Wed, Jan 31, 2024 at 11:07 AM Si-Wei Liu wrote: > > Hi Eugenio, > > Maybe there's some patch missing, but I saw this core dump when x-svq=on > is specified while waiting for the incoming migration on destination host: > > (gdb) bt > #0 0x5643b24cc13c in vhost_iova_tree_map_alloc

Re: [PATCH 13/14] migration/multifd: Move header prepare/fill into send_prepare()

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 06:42:57PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > This patch redefines the interfacing of ->send_prepare(). It further > > simplifies multifd_send_thread() especially on zero copy. > > > > Now with the new interface, we

[PATCH v2 3/3] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-02-01 Thread Taylor Simpson
Look for read-after-write instead of overlap of reads and writes HVX instructions with helpers have pass-by-reference semantics, so we check for overlaps of reads and writes within the same instruction. Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 88

  1   2   3   4   >