[PATCH] hw/us/bus.c PCAP adding 0xA in Windows version

Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show an example, when using a very common protocol to

[PATCH v6 22/41] Add GENET register structs. Part 3

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 88 ++ include/hw/net/bcm2838_genet.h | 88 ++ 2 files changed, 176 insertions(+) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index

[PATCH v6 19/41] Add GENET stub

Signed-off-by: Sergey Kambalin --- hw/misc/bcm2838_thermal.c| 2 +- hw/net/bcm2838_genet.c | 99 hw/net/meson.build | 2 + hw/net/trace-events | 16 + include/hw/arm/bcm2838_peripherals.h | 2 +

[PATCH v6 09/41] Add GPIO and SD to BCM2838 periph

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838_peripherals.c | 143 +++ include/hw/arm/bcm2838_peripherals.h | 8 ++ 2 files changed, 151 insertions(+) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index

[PATCH v6 03/41] Split out raspi machine common part

Pre-setup for raspberry pi 4 introduction Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/raspi.c | 112 ++-- include/hw/arm/raspi_platform.h | 21 ++ 2 files changed, 85 insertions(+), 48 deletions(-) diff --git

[PATCH v6 05/41] Add GIC-400 to BCM2838 SoC

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838.c | 167 ++- hw/arm/trace-events | 3 + include/hw/arm/bcm2838.h | 2 + include/hw/arm/bcm2838_peripherals.h | 37 ++ 4 files changed,

[PATCH v6 28/41] Implement GENET RX path

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 265 - include/hw/net/bcm2838_genet.h | 1 + 2 files changed, 265 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 4c9b39a3ca..61c1981e10 100644

[PATCH v6 06/41] Add BCM2838 GPIO stub

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/gpio/bcm2838_gpio.c | 153 + hw/gpio/meson.build| 5 +- include/hw/gpio/bcm2838_gpio.h | 40 + 3 files changed, 197 insertions(+), 1 deletion(-) create mode 100644

[PATCH v6 40/41] Append added properties to mailbox test

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index c96a9ba3f3..ff7c347e7c 100644 ---

[PATCH v6 02/41] Split out common part of peripherals

Pre-setup for BCM2838 introduction Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2835_peripherals.c | 198 +++ hw/arm/bcm2836.c | 24 ++-- include/hw/arm/bcm2835_peripherals.h | 29 +++- include/hw/arm/bcm2836.h

[PATCH v6 16/41] Add RPi4 RNG200

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 4 + hw/arm/bcm2838_peripherals.c | 17 ++ hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_rng200.c | 405 +++ hw/misc/meson.build | 1 +

[PATCH v6 29/41] Enable BCM2838 GENET controller

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 6 ++ hw/arm/bcm2838_peripherals.c | 11 +++ hw/arm/raspi4b.c | 20 +--- include/hw/arm/bcm2838_peripherals.h | 2 ++ 4 files changed, 20 insertions(+), 19

[PATCH v6 30/41] Add Rpi4b boot tests

Signed-off-by: Sergey Kambalin --- tests/avocado/boot_linux_console.py | 92 + 1 file changed, 92 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index a00202df3c..f5ec6de0f1 100644 ---

[PATCH v6 41/41] Add RPi4B to raspi.rst

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- docs/system/arm/raspi.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/system/arm/raspi.rst b/docs/system/arm/raspi.rst index d0a6f08b2b..c21b27744e 100644 --- a/docs/system/arm/raspi.rst +++

[PATCH v6 39/41] Add missed BCM2835 properties

Signed-off-by: Sergey Kambalin --- hw/misc/bcm2835_property.c | 21 + include/hw/arm/raspberrypi-fw-defs.h | 11 +++ 2 files changed, 32 insertions(+) diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index 5c48f8d743..bdd9a6bbce 100644

[PATCH v6 12/41] Add memory region for BCM2837 RPiVid ASB

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838_peripherals.c | 3 +++ include/hw/arm/bcm2838_peripherals.h | 2 ++ include/hw/arm/raspi_platform.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/arm/bcm2838_peripherals.c

[PATCH v6 18/41] Add clock_isp stub

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 6 ++ include/hw/arm/bcm2838_peripherals.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index 6badda3045..1f41028649 100644 ---

Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

On Fri, Feb 23, 2024 at 12:22 PM Alvin Chang via wrote: > > According to RISC-V Debug specification, the enabled privilege levels of Can you specify what version of the debug spec? Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to

Re: [PATCH 1/2] hw/xen: detect when running inside stubdomain

On Mon, Feb 19, 2024 at 1:17 PM Marek Marczykowski-Górecki wrote: > > Introduce global xen_is_stubdomain variable when qemu is running inside > a stubdomain instead of dom0. This will be relevant for subsequent > patches, as few things like accessing PCI config space need to be done >

Re: support on risc-v 128bits

On Mon, Feb 26, 2024 at 9:30 AM Jean-Christophe Énée wrote: > > hi, > i would like developpe my OS on risc-v 128 bits. > after search the support isn´t fully operational We have some basic 128-bit support, but it isn't complete. The RISC-V spec states: ``` The design of the RV128I base ISA is

[PATCH v6 36/41] Add mailbox property tests. Part 1

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.c| 1 - tests/qtest/bcm2838-mbox-property-test.c | 207 +++ tests/qtest/meson.build | 2 +- 3 files changed, 208 insertions(+), 2 deletions(-) create mode 100644

[PATCH v6 26/41] Implement GENET MDIO

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 126 - include/hw/net/bcm2838_genet.h | 3 +- 2 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 56ff6a6f39..1fae3ecbc2 100644

[PATCH v6 14/41] Add BCM2838 PCIE host

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 217 +- hw/arm/trace-events | 4 + include/hw/arm/bcm2838_pcie.h | 22 3 files changed, 241 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2838_pcie.c

[PATCH v6 21/41] Add GENET register structs. Part 2

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 89 ++ include/hw/net/bcm2838_genet.h | 89 ++ 2 files changed, 178 insertions(+) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index

[PATCH v6 08/41] Connect SD controller to BCM2838 GPIO

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/gpio/bcm2838_gpio.c | 52 +- include/hw/gpio/bcm2838_gpio.h | 5 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/hw/gpio/bcm2838_gpio.c b/hw/gpio/bcm2838_gpio.c index

[PATCH v6 34/41] Add mailbox tests tags. Part 2

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 152 ++ 1 file changed, 152 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 1360fbb8cf..b4f7b7b314 100644 --- a/tests/qtest/bcm2838-mailbox.h +++

[PATCH v6 13/41] Add BCM2838 PCIE Root Complex

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 82 +++ hw/arm/meson.build| 5 ++- include/hw/arm/bcm2838_pcie.h | 53 ++ 3 files changed, 139 insertions(+), 1 deletion(-) create mode 100644

[PATCH v6 37/41] Add mailbox property tests. Part 2

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 196 ++- 1 file changed, 195 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index acb421915b..b251d3f552 100644 ---

[PATCH v6 33/41] Add mailbox tests tags. Part 1

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 177 ++ 1 file changed, 177 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 9222b38bad..1360fbb8cf 100644 --- a/tests/qtest/bcm2838-mailbox.h +++

Re: [PATCH v6 1/3] hw/gpio: Implement STM32L4x5 GPIO

On Sat, Feb 24, 2024 at 8:55 PM Inès Varhol wrote: > > Features supported : > - the 8 STM32L4x5 GPIOs are initialized with their reset values > (except IDR, see below) > - input mode : setting a pin in input mode "externally" (using input > irqs) results in an out irq (transmitted to

[PATCH v6 27/41] Implement GENET TX path

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 221 - include/hw/net/bcm2838_genet.h | 17 +++ 2 files changed, 237 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 1fae3ecbc2..4c9b39a3ca 100644

Re: [PATCH v6 2/3] hw/arm: Connect STM32L4x5 GPIO to STM32L4x5 SoC

On Sat, Feb 24, 2024 at 8:56 PM Inès Varhol wrote: > > Signed-off-by: Arnaud Minier > Signed-off-by: Inès Varhol > Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > include/hw/arm/stm32l4x5_soc.h | 2 + > include/hw/gpio/stm32l4x5_gpio.h | 1 + >

[PATCH v6 11/41] Temporarily disable unimplemented rpi4b devices

This commit adds RPi4B device tree modifications: - disable pcie, rng200, thermal sensor and genet devices (they're going to be re-enabled in the following commits) - create additional memory region in device tree if RAM amount exceeds VC base address. Signed-off-by: Sergey Kambalin

[PATCH v6 20/41] Add GENET register structs. Part 1

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 37 include/hw/net/bcm2838_genet.h | 77 +- 2 files changed, 113 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index

[PATCH v6 23/41] Add GENET register structs. Part 4

Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 37 ++ 1 file changed, 37 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 1bd004785a..94c2f3ebca 100644 --- a/include/hw/net/bcm2838_genet.h +++

possible race condition in qemu nat layer or virtio-net

Hi all. I believe I spotted a race condition in virtio-net or qemu/kvm (but only when virtio-net is involved). To replicate, one needs a virtualization environment similar to Host: - debian 12 x86_64, kernel 6.1.0-18-amd64 - caching name server listening on 127.0.0.1 - qemu version 7.2.9

Intention to work on GSoC project

Hi, My name is Sahil and I go by the pseudonym 'valdaarhun' on Github. I have never contributed to QEMU before but I have used it a few times as an end user. I developed an interest in virtualization during my internship at VMware and would like to dive deeper in this subfield. My current

Re: [PATCH] hw/us/bus.c PCAP adding 0xA in Windows version

On Sun, 25 Feb 2024, benl...@fysnet.net wrote: Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show

Re: [PATCH 1/2] hw/xen: detect when running inside stubdomain

On Tue, Feb 20, 2024 at 1:50 AM Philippe Mathieu-Daudé wrote: > > On 19/2/24 19:16, Marek Marczykowski-Górecki wrote: > > Introduce global xen_is_stubdomain variable when qemu is running inside > > a stubdomain instead of dom0. This will be relevant for subsequent > > patches, as few things like

support on risc-v 128bits

hi, i would like developpe my OS on risc-v 128 bits. after search the support isn´t fully operational how can i help, and in the same learn risc-v 128 bits my coding skill is beginner, but i motivate and i learn spead. i'm waiting the complete guide of C to delanoy can you give me simple task

[PATCH v6 15/41] Enable BCM2838 PCIE

Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 9 + hw/arm/bcm2838_peripherals.c | 24 hw/arm/meson.build | 7 --- hw/arm/raspi4b.c | 1 - include/hw/arm/bcm2838_peripherals.h | 2 ++

[PATCH v6 17/41] Implement BCM2838 thermal sensor

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838_peripherals.c | 11 hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_thermal.c| 98 hw/misc/meson.build | 1 +

[PATCH v6 00/41] Raspberry Pi 4B machine

Introducing Raspberry Pi 4B model. It contains new BCM2838 SoC, PCIE subsystem, RNG200, Thermal sensor and Genet network controller. It can work with recent linux kernels 6.x.x. Two avocado tests was added to check that. Unit tests has been made as read/write operations via mailbox properties.

[PATCH v6 35/41] Add mailbox tests tags. Part 3

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 78 +++ 1 file changed, 78 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index b4f7b7b314..d753f17fb2 100644 --- a/tests/qtest/bcm2838-mailbox.h +++

[PATCH v6 32/41] Add mailbox test constants

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.c | 1 + tests/qtest/bcm2838-mailbox.h | 88 +++ 2 files changed, 89 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.c b/tests/qtest/bcm2838-mailbox.c index 0928a3dff8..1efd3c628a 100644 ---

[PATCH v6 01/41] Split out common part of BCM283X classes

Pre setup for BCM2838 introduction Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2836.c | 103 ++- hw/arm/raspi.c | 2 +- include/hw/arm/bcm2836.h | 26 +- 3 files changed, 84 insertions(+), 47

[PATCH v6 04/41] Introduce BCM2838 SoC

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838.c | 98 hw/arm/bcm2838_peripherals.c | 72 hw/arm/meson.build | 2 + include/hw/arm/bcm2838.h | 29

[PATCH v6 38/41] Add mailbox property tests. Part 3

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 213 ++- 1 file changed, 212 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index b251d3f552..c96a9ba3f3 100644 ---

[PATCH v6 10/41] Introduce Raspberry PI 4 machine

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2835_peripherals.c| 17 ++-- hw/arm/bcm2836.c| 2 + hw/arm/bcm2838.c| 2 + hw/arm/meson.build | 2 +- hw/arm/raspi.c | 27 -

[PATCH v6 25/41] Implement GENET register ops

Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 189 +++-- include/hw/net/bcm2838_genet.h | 2 + 2 files changed, 182 insertions(+), 9 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index be899b68f8..56ff6a6f39 100644

[PATCH v6 07/41] Implement BCM2838 GPIO functionality

Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/gpio/bcm2838_gpio.c | 193 - 1 file changed, 190 insertions(+), 3 deletions(-) diff --git a/hw/gpio/bcm2838_gpio.c b/hw/gpio/bcm2838_gpio.c index a312490bbd..69d15dbb49 100644 ---

[PATCH v6 31/41] Add mailbox test stub

Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.c | 60 +++ tests/qtest/bcm2838-mailbox.h | 37 + tests/qtest/meson.build | 1 + 3 files changed, 98 insertions(+) create mode 100644 tests/qtest/bcm2838-mailbox.c create

[PATCH v6 24/41] Add GENET register access macros

Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 76 ++ 1 file changed, 76 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 94c2f3ebca..e7a76cda81 100644 --- a/include/hw/net/bcm2838_genet.h +++

Re: [PATCH v2 1/2] hw/arm: Use TYPE_OR_IRQ when connecting STM32L4x5 EXTI fan-in IRQs

On Wed, Feb 21, 2024 at 4:42 AM Inès Varhol wrote: > > Fixes: 52671f69f7a4 ("[PATCH v8 0/3] Add device STM32L4x5 EXTI") > Signed-off-by: Inès Varhol Acked-by: Alistair Francis Alistair > --- > include/hw/arm/stm32l4x5_soc.h | 4 ++ > hw/arm/stm32l4x5_soc.c | 80

Re: [PULL 00/11] Test and misc patches

On Fri, 23 Feb 2024 at 19:10, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 3d54cbf269d63ff1d500b35b2bcf4565ff8ad485: > > Merge tag 'hw-misc-20240222' of https://github.com/philmd/qemu into staging > (2024-02-22 15:44:29 +) > > are available in the Git repository

Re: [PATCH V2 1/1] loongarch: Change the UEFI loading mode to loongarch

On 2/22/24 16:49, Andrea Bolognani wrote: > On Thu, Feb 22, 2024 at 04:10:20PM +0100, Philippe Mathieu-Daudé wrote: >> On 19/2/24 11:34, Xianglai Li wrote: >>> The UEFI loading mode in loongarch is very different >>> from that in other architectures:loongarch's UEFI code >>> is in rom, while other

Re: Trying to write data to i2c bus

Thank you Corey, * You can look at the git commits in hw/i2c around 37fa5ca42623 "hw/i2c: support multiple masters" for the changes that were done to support this. I saw a very good presentation in youtube about implementing i2c multi-master (I2C Multi-master and Controller Slave Mode in

Re: [PATCH 9/9] hw/i386/pc_{piix, q35}: Eliminate local pci_bus/pci_host variables

Am 21. Februar 2024 15:50:33 UTC schrieb "Philippe Mathieu-Daudé" : >On 8/2/24 23:03, Bernhard Beschow wrote: >> There is no advantage in having these local variables which 1/ needlessly >> have >> different identifiers in both machines and 2/ which are redundant to >> pcms->bus >> which is

Re: [PULL 14/25] hw/i386/pc: Confine system flash handling to pc_sysfw

Am 21.02.24 um 22:16 schrieb Philippe Mathieu-Daudé: > From: Bernhard Beschow > > Rather than distributing PC system flash handling across three files, let's > confine it to one. Now, pc_system_firmware_init() creates, configures and > cleans > up the system flash which makes the code easier to

Re: [PATCH v2] target/riscv: Fix shift count overflow

On 2/25/24 00:27, demin.han wrote: The result of (8 - 3 - vlmul) is negtive when vlmul >= 6, and results in wrong vill. Signed-off-by: demin.han --- Reviewed-by: Daniel Henrique Barboza target/riscv/vector_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH v5 2/3] hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2

On 24/2/24 20:10, Rayhan Faizel wrote: BCM2835 has three I2C controllers. All of them share the same interrupt line. Signed-off-by: Rayhan Faizel --- hw/arm/Kconfig | 1 + hw/arm/bcm2835_peripherals.c | 45 ++--

Re: [PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide

On 23/2/24 15:26, BALATON Zoltan wrote: Remove last two includes of hw/ide/intarnal.h outside of hw/ide and replace them with newly added public header to allow moving internal.h into hw/ide to really stop exposing it. Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files)

[PATCH v2 2/3] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide/

From: BALATON Zoltan Remove last two includes of hw/ide/intarnal.h outside of hw/ide and replace them with newly added public header to allow moving internal.h into hw/ide to really stop exposing it. Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files) Signed-off-by: BALATON

[PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

Rename "internal.h" as "ide_internal.h", and include it via its relative local path, instead of absolute to the project root path. Mechanical patch doing: $ sed -i -e 's#hw/ide/internal.h#ide_internal.h#' \ $(git grep -l hw/ide/internal) $ git mv hw/ide/internal.h

[PATCH v2 0/3] hw/ide: Make "ide_internal.h" really internal

Since v1: - Remove use of "ahci_internal.h" in SBSA-Ref - Rename "internal.h" -> "ide_internal.h" Supersedes: <20240223142633.933694e6...@zero.eik.bme.hu> BALATON Zoltan (1): hw/ide: Remove last two uses of ide/internal.h outside of hw/ide/ Philippe Mathieu-Daudé (2): hw/arm/sbsa-ref: Do

[PATCH v2 1/3] hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()

Use ahci_ide_create_devs() instead of open-coding it. Not accessing AHCIDevice internals anymore allows to remove "hw/ide/ahci_internal.h" (which isn't really a public header). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/sbsa-ref.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v3] target/riscv: Fix shift count overflow

The result of (8 - 3 - vlmul) is negative when vlmul >= 6, and results in wrong vill. Signed-off-by: demin.han --- Changes in v2: - Add vlen var Changes in v3: - Fix commit msg typo target/riscv/vector_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2 4/6] hw/i386/pc: Remove unneeded class attribute "kvmclock_enabled"

On 24/2/24 14:58, Bernhard Beschow wrote: PCMachineClass introduces the attribute into the class hierarchy and sets it to true. There is no sub class overriding the attribute. Commit 30d2a17b46e9 "hw/i386: Remove the deprecated machines 0.12 up to 0.15" removed the last overrides of this

Re: [PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide

On 25/2/24 18:08, BALATON Zoltan wrote: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: On 23/2/24 15:26, BALATON Zoltan wrote: Remove last two includes of hw/ide/intarnal.h outside of hw/ide and replace them with newly added public header to allow moving internal.h into hw/ide to really

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore or dash in file names? The headers Thomas added are using - as well as ahci-allwinner.c, only ahci_internal.h has _ (but there are others

Re: [PATCH v2] target/riscv: Fix shift count overflow

On 25/2/24 04:27, demin.han wrote: The result of (8 - 3 - vlmul) is negtive when vlmul >= 6, Typo "negative". and results in wrong vill. Signed-off-by: demin.han --- target/riscv/vector_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Files without license statement

Hi Paolo, I just noticed that scripts/fix-multiline-comments.sh has a copyright statement, but no license statement. Should that be fixed? It looks like there exist more files with the same problem (if it is a problem), for example docs/devel/loads-stores.rst (written by Peter). LICENSE

[Bug 2054889] Re: pcap streams are text files which insert 0xD in Windows version

Hi Benjamin, QEMU bug tracker is on GitLab: https://gitlab.com/qemu-project/qemu/-/issues But instead of re-opening the issue there, since you already figured the problem, do you mind directly post your patch? See guidelines there: https://www.qemu.org/docs/master/devel/submitting-a-patch.html

Re: [PATCH v2 1/3] hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()

On 25/2/24 18:16, Philippe Mathieu-Daudé wrote: Use ahci_ide_create_devs() instead of open-coding it. Not accessing AHCIDevice internals anymore allows to remove "hw/ide/ahci_internal.h" (which isn't really a public header). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/sbsa-ref.c | 9

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a

Re: [PULL 14/25] hw/i386/pc: Confine system flash handling to pc_sysfw

Am 25. Februar 2024 13:03:46 UTC schrieb "Volker Rümelin" : >Am 21.02.24 um 22:16 schrieb Philippe Mathieu-Daudé: >> From: Bernhard Beschow >> >> Rather than distributing PC system flash handling across three files, let's >> confine it to one. Now, pc_system_firmware_init() creates, configures

[Bug 2054889] Re: pcap streams are text files which insert 0xD in Windows version

I have sent a patch as directed. I hope it is correctly done. Thank you. Ben -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/2054889 Title: pcap streams are text files which insert 0xD in Windows

RE: [PATCH rfcv2 04/18] vfio: Add host iommu device instance into VFIODevice

Hi Eric, >-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 04/18] vfio: Add host iommu device instance into >VFIODevice > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> Either IOMMULegacyDevice or IOMMUFDDevice into VFIODevice, neither >> both. >> >> Signed-off-by:

Re: [PATCH v2 2/4] scripts/replay-dump.py: Update to current rr record format

On Wed Jan 31, 2024 at 7:36 AM AEST, John Snow wrote: > On Thu, Jan 25, 2024 at 11:09 AM Nicholas Piggin wrote: > > > > The v12 format support for replay-dump has a few issues still. This > > fixes async decoding; adds event, shutdown, and end decoding; fixes > > audio in / out events, fixes

Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

On Mon, Feb 26, 2024 at 11:16 AM Alvin Che-Chia Chang(張哲嘉) wrote: > > Hi Alistair, > > > -Original Message- > > From: Alistair Francis > > Sent: Monday, February 26, 2024 8:25 AM > > To: Alvin Che-Chia Chang(張哲嘉) > > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > >

RE: [PATCH rfcv2 11/18] intel_iommu: Add set/unset_iommu_device callback

>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 11/18] intel_iommu: Add >set/unset_iommu_device callback > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> From: Yi Liu >> >> This adds set/unset_iommu_device() implementation in Intel vIOMMU. >> In set call, a pointer to

Re: [PATCH v4 19/34] migration/multifd: Allow receiving pages without packets

On Tue, Feb 20, 2024 at 07:41:23PM -0300, Fabiano Rosas wrote: > Currently multifd does not need to have knowledge of pages on the > receiving side because all the information needed is within the > packets that come in the stream. > > We're about to add support to fixed-ram migration, which

Re: [PATCH 03/10] sh4: r2d: do not use usb_bus_find()

On 23/02/2024 13.43, Paolo Bonzini wrote: usb_bus_find() is always used with argument -1; it can be replaced with a search of the single USB bus on the machine. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/sh4/r2d.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v3 1/4] target/riscv: Add functions for common matching conditions of trigger

According to RISC-V Debug specification version 1.0 [1], there are several common matching conditions before firing a trigger, including the enabled privilege levels of the trigger. This commit adds trigger_common_match() to prepare the common matching conditions for the type 2/3/6 triggers. For

[Bug 2055003] Re: Qemu cmdline core dumped with more(8193 or more) cpus

** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Ubuntu on IBM Power Systems Bug Triage

Re: support on risc-v 128bits

On 26/2/24 00:57, Alistair Francis wrote: On Mon, Feb 26, 2024 at 9:30 AM Jean-Christophe Énée wrote: hi, i would like developpe my OS on risc-v 128 bits. after search the support isn´t fully operational We have some basic 128-bit support, but it isn't complete. The RISC-V spec states: ```

RE: [PATCH rfcv2 14/18] intel_iommu: Add a framework to check and sync host IOMMU cap/ecap

>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 14/18] intel_iommu: Add a framework to check >and sync host IOMMU cap/ecap > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> From: Yi Liu >> >> Add a framework to check and synchronize host IOMMU cap/ecap with >> vIOMMU

Re: [PATCH 4/4] replay: simple auto-snapshot mode for record

On Fri Aug 18, 2023 at 2:36 PM AEST, Pavel Dovgalyuk wrote: > On 14.08.2023 19:31, Nicholas Piggin wrote: > > record makes an initial snapshot when the machine is created, to enable > > reverse-debugging. Often the issue being debugged appears near the end of > > the trace, so it is important for

Re: [PATCH] hw/rtc/sun4v-rtc: Relicense to GPLv2-or-later

Peter Maydell writes: > The sun4v RTC device model added under commit a0e893039cf2ce0 in 2016 > was unfortunately added with a license of GPL-v3-or-later, which is > not compatible with other QEMU code which has a GPL-v2-only license. > > Relicense the code in the .c and the .h file to

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

Paolo Bonzini writes: > Once the Kconfig for hw/mips is cleaned up, it will be possible to build a > binary that does not include any USB host controller and therefore that > does not include the code guarded by CONFIG_USB. While the simpler > creation functions such as usb_create_simple can be

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

Paolo Bonzini writes: > usb_bus_find() is always used with argument -1; it can be replaced with > a search of the single USB bus on the machine. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini > --- > hw/ppc/sam460ex.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB

Paolo Bonzini writes: > Once the Kconfig for hw/mips is cleaned up, it will be possible to build a > binary that does not include any USB host controller and therefore that > does not include the code guarded by CONFIG_USB. While the simpler > creation functions such as usb_create_simple can be

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

Please ignore this one; I replied to the wrong patch by accident.

Re: [PATCH] migration: Free argv

On 2024/02/26 12:49, Peter Xu wrote: On Sun, Feb 25, 2024 at 02:54:01PM +0900, Akihiko Odaki wrote: exec_start_outgoing_migration() and exec_start_incoming_migration() leak argv because it uses g_steal_pointer() is used to pass argv qio_channel_command_new_spawn() while it does not free argv

Re: [PATCH v2 1/7] target/i386: mask high bits of CR3 in 32-bit mode

On Fri, Feb 23, 2024 at 02:09:42PM +0100, Paolo Bonzini wrote: > Date: Fri, 23 Feb 2024 14:09:42 +0100 > From: Paolo Bonzini > Subject: [PATCH v2 1/7] target/i386: mask high bits of CR3 in 32-bit mode > X-Mailer: git-send-email 2.43.0 > > CR3 bits 63:32 are ignored in 32-bit mode (either legacy

Re: [PATCH v2 3/7] target/i386: introduce function to query MMU indices

On Fri, Feb 23, 2024 at 02:09:44PM +0100, Paolo Bonzini wrote: > Date: Fri, 23 Feb 2024 14:09:44 +0100 > From: Paolo Bonzini > Subject: [PATCH v2 3/7] target/i386: introduce function to query MMU indices > X-Mailer: git-send-email 2.43.0 > > Remove knowledge of specific MMU indexes (other than

Re: [RFC PATCH v3 06/21] target/arm: Add support for Non-maskable Interrupt

On 2024/2/24 3:55, Richard Henderson wrote: > On 2/23/24 00:32, Jinjie Ruan via wrote: >> This only implements the external delivery method via the GICv3. >> >> Signed-off-by: Jinjie Ruan >> --- >> v3: >> - Not include CPU_INTERRUPT_NMI when FEAT_NMI not enabled >> - Add ARM_CPU_VNMI. >> -

Re: [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB

On 23/02/2024 13.44, Paolo Bonzini wrote: Once the Kconfig for hw/mips is cleaned up, it will be possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as

Re: [PATCH 09/10] usb: extract sysbus-ohci to a separate file

On 23/02/2024 13.44, Paolo Bonzini wrote: Split the sysbus version to a separate file so that it is not included in PCI-only machines, and adjust Kconfig for machines that do need sysbus-ohci. The copyrights are based on the time and employer of balrog and Paul Brook's contributions. While

Re: [PATCH v2 1/2] system/memory.c: support unaligned access

Hello, I would be happy if you could give me some comments. ping. On Thu, Feb 1, 2024 at 5:14 PM Tomoyuki HIROSE wrote: > > The previous code ignored 'impl.unaligned' and handled unaligned accesses > as is. But this implementation cannot emulate specific registers of some > devices that allow

  1   2   >