Re: [PATCH v4 08/10] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 10:16:01 -0800 nifan@gmail.com wrote: > From: Fan Ni > > Per CXL spec 3.1, two mailbox commands are implemented: > Add Dynamic Capacity Response (Opcode 4802h) 8.2.9.9.9.3, and > Release Dynamic Capacity (Opcode 4803h) 8.2.9.9.9.4. > > Signed-off-by: Fan Ni Hi Fan,

Re: [RFC PATCH] tests/vm: avoid re-building the VM images all the time

2024-02-26 Thread Alex Bennée
Alex Bennée writes: > There are two problems. > > The first is a .PHONY target will always evaluate which triggers a > full re-build of the VM images. Drop the requirement knowing that this > introduces a manual step on freshly configure build dirs. > > The second is a minor unrelated tweak to

Re: [PATCH v2] test/qtest: Add API functions to capture IRQ toggling

2024-02-26 Thread Philippe Mathieu-Daudé
On 14/11/23 00:01, Gustavo Romero wrote: Currently, the QTest API does not provide a function to capture when an IRQ line is raised or lowered, although the QTest Protocol already reports such IRQ transitions. As a consequence, it is also not possible to capture when an IRQ line is toggled.

Re: [PATCH v6 00/41] Raspberry Pi 4B machine

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:04, Sergey Kambalin wrote: > > Introducing Raspberry Pi 4B model. > It contains new BCM2838 SoC, PCIE subsystem, > RNG200, Thermal sensor and Genet network controller. > > It can work with recent linux kernels 6.x.x. > Two avocado tests was added to check that. > > Unit

Re: [PATCH v4 09/10] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 10:16:02 -0800 nifan@gmail.com wrote: > From: Fan Ni > > Since fabric manager emulation is not supported yet, the change implements > the functions to add/release dynamic capacity extents as QMP interfaces. > > Note: we skips any FM issued extent release request if the

Re: [RFC PATCH] tests/vm: avoid re-building the VM images all the time

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 18:06, Alex Bennée wrote: > > Alex Bennée writes: > > > There are two problems. > > > > The first is a .PHONY target will always evaluate which triggers a > > full re-build of the VM images. Drop the requirement knowing that this > > introduces a manual step on freshly

[PATCH v5 1/3] qdev: Add a granule_mode property

2024-02-26 Thread Eric Auger
Introduce a new enum type property allowing to set an IOMMU granule. Values are 4k, 8k, 16k, 64k and host. This latter indicates the vIOMMU granule will match the host page size. A subsequent patch will add such a property to the virtio-iommu device. Signed-off-by: Eric Auger Signed-off-by:

[PATCH v5 0/3] VIRTIO-IOMMU: Set default granule to host page size

2024-02-26 Thread Eric Auger
We used to set the default granule to 4kB but with VFIO assignment it makes more sense to use the actual host page size. Indeed when hotplugging a VFIO device protected by a virtio-iommu on a 64kB/64kB host/guest config, we currently get a qemu crash: "vfio: DMA mapping failed, unable to

[PATCH v5 3/3] virtio-iommu: Change the default granule to the host page size

2024-02-26 Thread Eric Auger
We used to set the default granule to 4KB but with VFIO assignment it makes more sense to use the actual host page size. Indeed when hotplugging a VFIO device protected by a virtio-iommu on a 64kB/64kB host/guest config, we current get a qemu crash: "vfio: DMA mapping failed, unable to continue"

[PATCH v5 2/3] virtio-iommu: Add a granule property

2024-02-26 Thread Eric Auger
This allows to choose which granule will be used by default by the virtio-iommu. Current page size mask default is qemu_target_page_mask so this translates into a 4K granule. Signed-off-by: Eric Auger --- v4 -> v5: - use -(n * KiB) (Phild) v3 -> v4: - granule_mode introduction moved to that

Re: [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize

2024-02-26 Thread Philippe Mathieu-Daudé
On 24/2/24 13:43, Akihiko Odaki wrote: Akihiko Odaki (10): ui/cocoa: Split [-QemuCocoaView handleEventLocked:] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:] ui/cocoa: Release specific mouse buttons ui/cocoa: Scale with NSView instead of Core

Re: [RFC PATCH] tests/vm: avoid re-building the VM images all the time

2024-02-26 Thread Daniel P . Berrangé
On Mon, Feb 26, 2024 at 05:46:39PM +, Alex Bennée wrote: > There are two problems. > > The first is a .PHONY target will always evaluate which triggers a > full re-build of the VM images. Drop the requirement knowing that this > introduces a manual step on freshly configure build dirs. For

Re: [PATCH v5 2/3] virtio-iommu: Add a granule property

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 19:11, Eric Auger wrote: This allows to choose which granule will be used by default by the virtio-iommu. Current page size mask default is qemu_target_page_mask so this translates into a 4K granule. Signed-off-by: Eric Auger --- v4 -> v5: - use -(n * KiB) (Phild) v3 -> v4: -

Re: [PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 23:11:12 +0800 Zhao Liu wrote: > On Wed, Feb 21, 2024 at 12:35:47PM +0100, Markus Armbruster wrote: > > Date: Wed, 21 Feb 2024 12:35:47 +0100 > > From: Markus Armbruster > > Subject: Re: [PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in > > ct3_realize() > > > >

Re: [PATCH 1/6] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 23:04:23 +0800 Zhao Liu wrote: > On Wed, Feb 21, 2024 at 12:31:06PM +0100, Markus Armbruster wrote: > > Date: Wed, 21 Feb 2024 12:31:06 +0100 > > From: Markus Armbruster > > Subject: Re: [PATCH 1/6] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in > >

Re: [PATCH v2 3/7] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-02-26 Thread Jonathan Cameron via
On Fri, 23 Feb 2024 16:56:49 +0800 Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be

Re: [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()

2024-02-26 Thread Jonathan Cameron via
On Fri, 23 Feb 2024 16:56:47 +0800 Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be

Re: [PATCH v2 5/7] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-02-26 Thread Jonathan Cameron via
On Fri, 23 Feb 2024 16:56:51 +0800 Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be

Re: [PATCH v6 14/41] Add BCM2838 PCIE host

2024-02-26 Thread Philippe Mathieu-Daudé
Hi Sergey, On 26/2/24 01:02, Sergey Kambalin wrote: Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 217 +- hw/arm/trace-events | 4 + include/hw/arm/bcm2838_pcie.h | 22 3 files changed, 241 insertions(+), 2

[PATCH v2.1 04/28] qemu-img: global option processing and error printing

2024-02-26 Thread Michael Tokarev
In order to correctly print executable name in various error messages, pass argv[0] to error_exit() function. This way, error messages will refer to actual executable name, which may be different from 'qemu-img'. For subcommands, pass original command name from the qemu-img argv[0], plus the

[PATCH 1/5] target/i386/cpu: Expose SMI# IRQ line via QDev

2024-02-26 Thread Philippe Mathieu-Daudé
In order to remove calls to cpu_interrupt() from hw/ code, expose the SMI# interrupt via QDev as named GPIO. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu-internal.h | 1 + target/i386/cpu-sysemu.c | 11 +++ target/i386/cpu.c | 2 ++ 3 files changed, 14

[PATCH v3 06/27] gdbstub: Use GDBFeature for gdb_register_coprocessor

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki This is a tree-wide change to introduce GDBFeature parameter to gdb_register_coprocessor(). The new parameter just replaces num_regs and xml parameters for now. GDBFeature will be utilized to simplify XML lookup in a following change. Signed-off-by: Akihiko Odaki Acked-by:

[PATCH v3 11/27] hw/core/cpu: Remove gdb_get_dynamic_xml member

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki This function is no longer used. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Message-Id: <20240103173349.398526-35-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-9-777047380...@daynix.com> Signed-off-by: Alex Bennée --- include/hw/core/cpu.h | 4

[PATCH 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper

2024-02-26 Thread Andrey Drobyshev
There's no need to check for the existence of the "chpasswd", "pw" executables, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 96 ++-- 1 file changed, 13 insertions(+), 83 deletions(-) diff --git

[PATCH v3 07/27] gdbstub: Use GDBFeature for GDBRegisterState

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki Simplify GDBRegisterState by replacing num_regs and xml members with one member that points to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240103173349.398526-31-alex.ben...@linaro.org> Message-Id:

[PATCH v3 16/27] linux-user: ensure nios2 processes queued work

2024-02-26 Thread Alex Bennée
While async processes are rare for linux-user we do use them from time to time. The most obvious one is tb_flush when we run out of translation space. We will also need this when we move plugin vcpu_init to an async task. Fix nios2 to follow its older, wiser and more stable siblings.

Re: [PATCH v12 02/10] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:]

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:43, Akihiko Odaki wrote: > > Instead of using mouse_event variable to tell to handle a mouse event > later, immediately call [-QemuCocoaView handleMouseEvent:buttons:]. > > Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v3 10/27] gdbstub: Infer number of core registers from XML

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki GDBFeature has the num_regs member so use it where applicable to remove magic numbers. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-34-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-8-777047380...@daynix.com> [AJB: remove core reg check from

Re: [PATCH v12 06/10] ui/cocoa: Let the platform toggle fullscreen

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:44, Akihiko Odaki wrote: > > It allows making the window full screen by clicking full screen button > provided by the platform (the left-top green button) and save some code. > > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 408 >

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-26 Thread Philippe Mathieu-Daudé
Hi, On 19/2/24 15:05, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Mark Cave-Ayland wrote: On 19/02/2024 13:05, Peter Maydell wrote: On Mon, 19 Feb 2024 at 12:49, Mark Cave-Ayland wrote: On 19/02/2024 12:00, BALATON Zoltan wrote: For new people trying to contribute to QEMU QDev is

Re: [PATCH v2 0/6] Simplify initialization of PC machines

2024-02-26 Thread Philippe Mathieu-Daudé
On 24/2/24 14:58, Bernhard Beschow wrote: The series aims to simplify the initialization process of all PC-based machines by streamlining redundant code. Bernhard Beschow (6): hw/i386/x86: Let ioapic_init_gsi() take parent as pointer hw/i386/pc: Rename "bus" attribute to "pcibus"

Re: [PATCH 1/7] qga/commands-posix: return fsinfo values directly as reported by statvfs

2024-02-26 Thread Konstantin Kostiuk
Best Regards, Konstantin Kostiuk. On Mon, Feb 26, 2024 at 7:02 PM Andrey Drobyshev < andrey.drobys...@virtuozzo.com> wrote: > Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to > GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo: > used = (f_blocks - f_bfree),

Re: [PATCH 5/6] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 23:09:49 +0800 Zhao Liu wrote: > On Wed, Feb 21, 2024 at 12:49:46PM +0100, Markus Armbruster wrote: > > Date: Wed, 21 Feb 2024 12:49:46 +0100 > > From: Markus Armbruster > > Subject: Re: [PATCH 5/6] hw/pci-bridge/cxl_upstream: Fix missing > > ERRP_GUARD() in

[PULL 0/2] Edk2 stable202402 20240226 patches

2024-02-26 Thread Gerd Hoffmann
The following changes since commit 4a4efae44f19528589204581e9e2fab69c5d39aa: Merge tag 'pull-hex-20240121' of https://github.com/quic/qemu into staging (2024-01-23 13:40:45 +) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/edk2-stable202402-20240226

Re: [PATCH v6 11/41] Temporarily disable unimplemented rpi4b devices

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 14:39, Peter Maydell wrote: On Mon, 26 Feb 2024 at 13:35, Philippe Mathieu-Daudé wrote: On 26/2/24 01:02, Sergey Kambalin wrote: +static void raspi4_modify_dtb(const struct arm_boot_info *info, void *fdt) +{ +uint64_t ram_size; + +/* Temporarily disable following devices

Re: [PATCH v6 18/41] Add clock_isp stub

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 01:02, Sergey Kambalin wrote: Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 6 ++ include/hw/arm/bcm2838_peripherals.h | 1 + 2 files changed, 7 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v6 41/41] Add RPi4B to raspi.rst

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 16:42, Peter Maydell wrote: > > On Mon, 26 Feb 2024 at 00:03, Sergey Kambalin wrote: > > > > Signed-off-by: Sergey Kambalin > > Reviewed-by: Peter Maydell > > --- > > docs/system/arm/raspi.rst | 11 +++ > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > >

Re: [PATCH v6 41/41] Add RPi4B to raspi.rst

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 16:52, Philippe Mathieu-Daudé wrote: > > On 26/2/24 17:43, Peter Maydell wrote: > > On Mon, 26 Feb 2024 at 16:42, Peter Maydell > > wrote: > >> > >> On Mon, 26 Feb 2024 at 00:03, Sergey Kambalin wrote: > >>> > >>> Signed-off-by: Sergey Kambalin > >>> Reviewed-by: Peter

[PATCH v3 20/27] plugins: create CPUPluginState and migrate plugin_mask

2024-02-26 Thread Alex Bennée
As we expand the per-vCPU data for plugins we don't want to pollute CPUState. For now this just moves the plugin_mask (renamed to event_mask) as the memory callbacks are accessed directly by TCG generated code. Message-Id: <20240223162202.1936541-21-alex.ben...@linaro.org> Reviewed-by: Pierrick

[PATCH v3 18/27] plugins: Use different helpers when reading registers

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki This avoids optimizations incompatible when reading registers. Signed-off-by: Akihiko Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240103173349.398526-37-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-12-777047380...@daynix.com> Signed-off-by: Alex Bennée

[PATCH v3 21/27] plugins: add an API to read registers

2024-02-26 Thread Alex Bennée
We can only request a list of registers once the vCPU has been initialised so the user needs to use either call the get function on vCPU initialisation or during the translation phase. We don't expose the reg number to the plugin instead hiding it behind an opaque handle. For now this is just the

Re: [PATCH 01/28] qemu-img: stop printing error twice in a few places

2024-02-26 Thread Michael Tokarev
26.02.2024 17:14, Daniel P. Berrangé : On Thu, Feb 22, 2024 at 12:15:42AM +0300, Michael Tokarev wrote: Currently we have: ./qemu-img resize none +10 qemu-img: Could not open 'none': Could not open 'none': No such file or directory stop printing the message twice, - local_err already

Re: [PATCH v6 18/41] Add clock_isp stub

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:08, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 6 ++ > include/hw/arm/bcm2838_peripherals.h | 1 + > 2 files changed, 7 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 33/41] Add mailbox tests tags. Part 1

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:08, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.h | 177 ++ > 1 file changed, 177 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 34/41] Add mailbox tests tags. Part 2

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:05, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.h | 152 ++ > 1 file changed, 152 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 32/41] Add mailbox test constants

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:10, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.c | 1 + > tests/qtest/bcm2838-mailbox.h | 88 +++ > 2 files changed, 89 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 35/41] Add mailbox tests tags. Part 3

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:08, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.h | 78 +++ > 1 file changed, 78 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 0/7] qga/commands-posix: replace code duplicating commands with a helper

2024-02-26 Thread Andrey Drobyshev
This series simply replaces repeating fork()/exec() pattern with a separate helper to avoid code duplication. It's easier to setup and use than g_spawn_async_with_pipes() (which we'd need since some commands require input). While here, also make qmp_guest_get_fsinfo return more straightforward

[PATCH 5/7] qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper

2024-02-26 Thread Andrey Drobyshev
There's no need to check for the existence of the hook executable, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/qga/commands-posix.c

[PATCH v3 12/27] gdbstub: Add members to identify registers to GDBFeature

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki These members will be used to help plugins to identify registers. The added members in instances of GDBFeature dynamically generated by CPUs will be filled in later changes. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-36-alex.ben...@linaro.org>

[PATCH 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper

2024-02-26 Thread Andrey Drobyshev
There's no need to check for the existence of "/sbin/hwclock", the exec() call will do that for us. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff --git a/qga/commands-posix.c

[PATCH v3 19/27] gdbstub: expose api to find registers

2024-02-26 Thread Alex Bennée
Expose an internal API to QEMU to return all the registers for a vCPU. The list containing the details required to called gdb_read_register(). Based-on: <20231025093128.33116-15-akihiko.od...@daynix.com> Cc: Akihiko Odaki Message-Id: <20240103173349.398526-38-alex.ben...@linaro.org>

[PATCH v3 08/27] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki Align the parameters of gdb_get_reg_cb and gdb_set_reg_cb with the gdb_read_register and gdb_write_register members of CPUClass to allow to unify the logic to access registers of the core and coprocessors in the future. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée

Re: [PATCH v4 02/10] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support

2024-02-26 Thread Jonathan Cameron via
On Wed, 21 Feb 2024 10:15:55 -0800 nifan@gmail.com wrote: > From: Fan Ni > > Per cxl spec r3.1, add dynamic capacity region representative based on > Table 8-165 and extend the cxl type3 device definition to include dc region > information. Also, based on info in 8.2.9.9.9.1, add 'Get

Re: [PATCH 04/28] qemu-img: global option processing and error printing

2024-02-26 Thread Michael Tokarev
26.02.2024 18:40, Daniel P. Berrangé : .. I'm not sure how, but this change seems to have broken the iotests. Just one example: Heh. Thank you for trying that. I wanted to do that but forgot. The reason is most likely the argv/argc handling (lack of optind reset). In the later change it is

Re: [RFC 8/8] qemu-options: Add the cache topology description of -smp

2024-02-26 Thread Jonathan Cameron via
On Tue, 20 Feb 2024 17:25:04 +0800 Zhao Liu wrote: > From: Zhao Liu > > Signed-off-by: Zhao Liu Hi, A trivial comment, but also a possibly more significant one about whether the defaults are correctly verified. Jonathan > --- > qemu-options.hx | 54

Re: [PATCH v6 31/41] Add mailbox test stub

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:07, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.c | 60 +++ > tests/qtest/bcm2838-mailbox.h | 37 + > tests/qtest/meson.build | 1 + > 3 files changed, 98

Re: [PATCH 04/28] qemu-img: global option processing and error printing

2024-02-26 Thread Michael Tokarev
26.02.2024 18:43, Michael Tokarev wrote: The reason is most likely the argv/argc handling (lack of optind reset). In the later change it is fixed but at that stage it's broken. Nope. GNU getopt_long really needs resetting the state. Or else it keeps return_in_order/permute/etc setting from

Re: [PATCH] Print tool binary names in ./configure --help

2024-02-26 Thread Stefan Hajnoczi
On Sat, 17 Feb 2024 at 08:21, Manos Pitsidianakis wrote: > > configure --help currently outputs the following line for the tools > option: > > -->8--- > ░░tcg░TCG░support░░ >

Re: [PATCH v6 41/41] Add RPi4B to raspi.rst

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:03, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > Reviewed-by: Peter Maydell > --- > docs/system/arm/raspi.rst | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/docs/system/arm/raspi.rst b/docs/system/arm/raspi.rst >

Re: [PATCH v6 11/41] Temporarily disable unimplemented rpi4b devices

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 16:06, Philippe Mathieu-Daudé wrote: > > On 26/2/24 14:39, Peter Maydell wrote: > > On Mon, 26 Feb 2024 at 13:35, Philippe Mathieu-Daudé > > wrote: > >> > >> On 26/2/24 01:02, Sergey Kambalin wrote: > >>> +static void raspi4_modify_dtb(const struct arm_boot_info *info,

Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure

2024-02-26 Thread Jonathan Cameron via
On Fri, 23 Feb 2024 12:42:23 + wrote: > From: Ankit Agrawal > > ACPI spec provides a scheme to associate "Generic Initiators" [1] > (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with > integrated compute or DMA engines GPUs) with Proximity Domains. This is >

[PATCH 3/7] qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper

2024-02-26 Thread Andrey Drobyshev
Also remove the G_GNUC_UNUSED attribute added in the previous commit from the helper. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c

[PATCH v3 26/27] docs/devel: document some plugin assumptions

2024-02-26 Thread Alex Bennée
While we attempt to hide implementation details from the plugin we shouldn't be totally obtuse. Let the user know what they can and can't expect with the various instrumentation options. Message-Id: <20240103173349.398526-44-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by:

[PATCH v3 14/27] plugins: add qemu_plugin_num_vcpus function

2024-02-26 Thread Alex Bennée
From: Pierrick Bouvier We now keep track of how many vcpus were started. This way, a plugin can easily query number of any vcpus at any point of execution, which unifies user and system mode workflows. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id:

[PATCH 1/7] qga/commands-posix: return fsinfo values directly as reported by statvfs

2024-02-26 Thread Andrey Drobyshev
Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo: used = (f_blocks - f_bfree), total = (f_blocks - f_bfree + f_bavail). These calculations might be obscure for the end user and require one to actually get into QGA

[PATCH v3 27/27] docs/devel: plugins can trigger a tb flush

2024-02-26 Thread Alex Bennée
From: Pierrick Bouvier When scoreboards need to be reallocated. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20240213094009.150349-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/devel/multi-thread-tcg.rst | 1 + 1 file changed, 1

[PATCH v3 13/27] plugins: remove previous n_vcpus functions from API

2024-02-26 Thread Alex Bennée
From: Pierrick Bouvier This information is already accessible using qemu_info_t during plugin install. We will introduce another function (qemu_plugin_num_vcpus) which represent how many cpus were enabled, by tracking new cpu indexes. It's a breaking change, so we bump API version.

[PATCH v3 23/27] contrib/plugins: fix imatch

2024-02-26 Thread Alex Bennée
We can't directly save the ephemeral imatch from argv as that memory will get recycled. Message-Id: <20240103173349.398526-40-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- contrib/plugins/execlog.c | 2 +- 1 file

[PATCH v3 17/27] cpu: call plugin init hook asynchronously

2024-02-26 Thread Alex Bennée
From: Pierrick Bouvier This ensures we run during a cpu_exec, which allows to call start/end exclusive from this init hook (needed for new scoreboard API introduced later). async work is run before any tb is translated/executed, so we can guarantee plugin init will be called before any other

[PATCH v3 05/27] target/riscv: Use GDBFeature for dynamic XML

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-29-alex.ben...@linaro.org>

Re: [PATCH v12 07/10] ui/cocoa: Remove normalWindow

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:44, Akihiko Odaki wrote: > > QemuCocoaView used to have fullScreenWindow but now it's gone, so we > do no longer have to call the window specifically "normalWindow". > Instead, refer to it with [-QemuCocoaView window]. > > Signed-off-by: Akihiko Odaki > --- >

Re: [PATCH v12 05/10] ui/cocoa: Fix pause label coordinates

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:43, Akihiko Odaki wrote: > > A subview is positioned in the superview so the superview's frame > should be used instead of one of the window to determine the > coordinates. > > Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v3 04/27] target/ppc: Use GDBFeature for dynamic XML

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Richard Henderson Message-Id:

Re: [PATCH v12 10/10] ui/cocoa: Remove stretch_video flag

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:44, Akihiko Odaki wrote: > > Evaluate [normalWindow styleMask] & NSWindowStyleMaskResizable instead. > > Signed-off-by: Akihiko Odaki > -- Reviewed-by: Peter Maydell thanks -- PMM

[RFC PATCH] tests/vm: avoid re-building the VM images all the time

2024-02-26 Thread Alex Bennée
There are two problems. The first is a .PHONY target will always evaluate which triggers a full re-build of the VM images. Drop the requirement knowing that this introduces a manual step on freshly configure build dirs. The second is a minor unrelated tweak to the Makefile also triggers an

Re: [PATCH v7 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2024-02-26 Thread Philippe Mathieu-Daudé
On 20/2/24 11:09, Laszlo Ersek wrote: (Cc'ing Kevin too) On 2/20/24 08:58, Philippe Mathieu-Daudé wrote: Hi Laszlo, Igor, Gerd, (old patch, now commit 5ce45c7a2b) On 26/1/17 02:44, Laszlo Ersek wrote: The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject

Re: [PATCH v6 38/41] Add mailbox property tests. Part 3

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:07, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mbox-property-test.c | 213 ++- > 1 file changed, 212 insertions(+), 1 deletion(-); Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 37/41] Add mailbox property tests. Part 2

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:07, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mbox-property-test.c | 196 ++- > 1 file changed, 195 insertions(+), 1 deletion(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 36/41] Add mailbox property tests. Part 1

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:06, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.c| 1 - > tests/qtest/bcm2838-mbox-property-test.c | 207 +++ > tests/qtest/meson.build | 2 +- > 3 files changed, 208

Re: [PATCH v6 39/41] Add missed BCM2835 properties

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:09, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/misc/bcm2835_property.c | 21 + > include/hw/arm/raspberrypi-fw-defs.h | 11 +++ > 2 files changed, 32 insertions(+) Reviewed-by: Peter Maydell thanks --

Re: [PATCH v6 40/41] Append added properties to mailbox test

2024-02-26 Thread Peter Maydell
On Mon, 26 Feb 2024 at 00:06, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mbox-property-test.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 01/28] qemu-img: stop printing error twice in a few places

2024-02-26 Thread Michael Tokarev
22.02.2024 00:15, Michael Tokarev : Currently we have: ./qemu-img resize none +10 qemu-img: Could not open 'none': Could not open 'none': No such file or directory This one needs expected-output tweaks for tests. /mjt

Re: [PATCH V1] migration: export fewer options

2024-02-26 Thread Steven Sistare
On 2/25/2024 9:40 PM, Peter Xu wrote: > On Fri, Feb 23, 2024 at 09:13:24AM -0800, Steve Sistare wrote: >> A small number of migration options are accessed by migration clients, >> but to see them clients must include all of options.h, which is mostly >> for migration core code. migrate_mode() in

Re: [PATCH v6 41/41] Add RPi4B to raspi.rst

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 17:43, Peter Maydell wrote: On Mon, 26 Feb 2024 at 16:42, Peter Maydell wrote: On Mon, 26 Feb 2024 at 00:03, Sergey Kambalin wrote: Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- docs/system/arm/raspi.rst | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH v3 03/27] target/arm: Use GDBFeature for dynamic XML

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Acked-by: Richard Henderson Message-Id:

[PATCH v3 00/27] maintainer updates for 9.0 pre-PR (tests, plugin register support)

2024-02-26 Thread Alex Bennée
The test patch is a simple house keeping one to clean up some inadvertent GPLv3 tagging to GPLv2-or-later. I've also increased the timeout for check-tcg due to TCI timesouts. The main bulk of this series is register reading support for TCG plugins. The main change to the API is that the

[PATCH 6/7] qga/commands-posix: use ga_run_command helper when suspending via sysfs

2024-02-26 Thread Andrey Drobyshev
We replace the direct call to open() with a "sh -c 'echo ...'" call, so that it becomes an executable command. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 36 1 file changed, 4 insertions(+), 32 deletions(-) diff --git a/qga/commands-posix.c

[PATCH 2/7] qga: introduce ga_run_command() helper for guest cmd execution

2024-02-26 Thread Andrey Drobyshev
When executing guest commands in *nix environment, we repeat the same fork/exec pattern multiple times. Let's just separate it into a single helper which would also be able to feed input data into the launched process' stdin. This way we can avoid code duplication. To keep the history more

[PATCH v3 15/27] plugins: fix order of init/idle/resume callback

2024-02-26 Thread Alex Bennée
From: Pierrick Bouvier We found that vcpu_init_hook was called *after* idle callback. vcpu_init is called from cpu_realize_fn, while idle/resume cb are called from qemu_wait_io_event (in vcpu thread). This change ensures we only call idle and resume cb only once a plugin was init for a given

[PATCH v3 09/27] gdbstub: Simplify XML lookup

2024-02-26 Thread Alex Bennée
From: Akihiko Odaki Now we know all instances of GDBFeature that is used in CPU so we can traverse them to find XML. This removes the need for a CPU-specific lookup function for dynamic XMLs. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Message-Id:

Re: [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons

2024-02-26 Thread Peter Maydell
On Sat, 24 Feb 2024 at 12:43, Akihiko Odaki wrote: > > ui/cocoa used to release all mouse buttons when it sees > NSEventTypeLeftMouseUp, NSEventTypeRightMouseUp, or > NSEventTypeOtherMouseUp, but it can instead release specific one > according to the delivered event. > > Signed-off-by: Akihiko

[PATCH v3 02/27] tests/tcg: bump TCG test timeout to 120s

2024-02-26 Thread Alex Bennée
This is less than ideal but easier than making sure we get all the iterations of the memory test. Update the comment accordingly. Message-Id: <20240223162202.1936541-3-alex.ben...@linaro.org> Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- tests/tcg/Makefile.target | 9 +++-- 1

[PATCH v3 22/27] tests/tcg: expand insn test case to exercise register API

2024-02-26 Thread Alex Bennée
This ensure we at least read every register the plugin API reports at least once during the check-tcg checks. Signed-off-by: Alex Bennée --- tests/plugin/insn.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c index

[PATCH v3 25/27] docs/devel: lift example and plugin API sections up

2024-02-26 Thread Alex Bennée
This makes them a bit more visible in the TCG emulation menu rather than hiding them away bellow the ToC limit. Message-Id: <20240103173349.398526-43-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé ---

[PATCH v2 3/6] hw/arm/exynos4210: Inline sysbus_create_varargs(EXYNOS4210_FIMD)

2024-02-26 Thread Philippe Mathieu-Daudé
We want to set another qdev property (a link) for the FIMD device, we can not use sysbus_create_varargs() which only passes sysbus base address and IRQs as arguments. Inline it so we can set the link property in the next commit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard

[PATCH v2 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-26 Thread Philippe Mathieu-Daudé
We want to set another qdev property (a link) for the pl110 and pl111 devices, we can not use sysbus_create_simple() which only passes sysbus base address and IRQs as arguments. Inline it so we can set the link property in the next commit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PATCH v2 0/6] hw: Remove sysbus_address_space()

2024-02-26 Thread Philippe Mathieu-Daudé
(all series reviewed) Since v1: - Rebased Pass address space as link property for devices where it seems to matter, otherwise just use get_system_memory(). Philippe Mathieu-Daudé (6): hw/arm: Inline sysbus_create_simple(PL110 / PL111) hw/display/pl110: Pass frame buffer memory region as

[PATCH v2 4/6] hw/display/exynos4210_fimd: Pass frame buffer memory region as link

2024-02-26 Thread Philippe Mathieu-Daudé
Add the Exynos4210fimdState::'framebuffer-memory' property. Have the board set it. We don't need to call sysbus_address_space() anymore. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/arm/exynos4210.c | 2 ++ hw/display/exynos4210_fimd.c | 19

[PATCH v2 6/6] hw/sysbus: Remove now unused sysbus_address_space()

2024-02-26 Thread Philippe Mathieu-Daudé
sysbus_address_space() is not more used, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/hw/sysbus.h | 1 - hw/core/sysbus.c| 5 - 2 files changed, 6 deletions(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index

  1   2   3   4   >