Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > Hi Cindy: > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > > > we need a crash in Non-standard image, here is the jira for this > > https://issues.redhat.com/browse/RHEL-28522 > > The root cause of the issue is that an IRQFD was used

[PATCH] hw/virtio: Fix packed virtqueue flush used_idx

2024-03-27 Thread Wafer
For indirect descriptors the elelm->ndescs was one, For direct descriptors the elele->ndesc was the numbe of entries. elem->ndescs = (desc_cache == _desc_cache) ? 1 : elem_entries; When flushing multiple elemes, the used_idx should be added to all the privious numeric entry value. Signed-off-by:

Re: [External] Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-27 Thread Ho-Ren (Jack) Chuang
On Tue, Mar 26, 2024 at 10:52 PM Huang, Ying wrote: > > "Ho-Ren (Jack) Chuang" writes: > > > The current implementation treats emulated memory devices, such as > > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > > (E820_TYPE_RAM). However, these emulated devices

RE: Questions about CXL device (type 3 memory) hotplug

2024-03-27 Thread Yuquan Wang
On Mon, May 22, 2023 at 05:11:39PM -0700, Dan Williams wrote: > Yasunori Gotou (Fujitsu) wrote: [...] Hi, all There was some confusions about CXL device hotplug when I recently tried to use Qemu to emulate CXL device hotplug and verify the relevant functions of kernel. > > Q1) Can PCIe hotplug

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Gerd Hoffmann
On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote: > Heh I've actually been using isapc over the past couple of weeks to fire up > some old programs in a Windows 3 VM :) I'm wondering why these use cases can't simply use the 'pc' machine type? The early pci chipsets of the 90-ies

Re: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:14 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove > PCMachineClass::enforce_aligned_dimm > X-Mailer: git-send-email 2.41.0 > >

RE: [PATCH v1 01/11] Introduce a common abstract struct HostIOMMUDevice

2024-03-27 Thread Duan, Zhenzhong
Hi Cédric, >-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v1 01/11] Introduce a common abstract struct >HostIOMMUDevice > >Hello Zhenzhong, > >On 3/19/24 12:58, Duan, Zhenzhong wrote: >> Hi Cédric, >> >>> -Original Message- >>> From: Cédric Le Goater >>> Sent:

RE: [PATCH v5 4/7] migration/multifd: add qpl compression method

2024-03-27 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Thursday, March 28, 2024 3:49 AM > To: Liu, Yuan1 > Cc: faro...@suse.de; qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Zou, Nanhai > Subject: Re: [PATCH v5 4/7] migration/multifd: add qpl compression method >

[PATCH for-9.0?] accel/tcg: Use CPUState.get_pc in cpu_io_recompile

2024-03-27 Thread Richard Henderson
Using log_pc produces the pc at the beginning of TB, not the actual pc installed by cpu_restore_state_from_tb, which could be any of the guest instructions within TB. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:33 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > > > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > > >

[PATCH 2/4] tests/avocado: ppc_hv_tests.py set alpine time before setup-alpine

2024-03-27 Thread Nicholas Piggin
If the time is wrong, setup-alpine SSL certificate checks can fail. setup-alpine is used to bring up the network, but it doesn't seem to to set NTP time before the failing SSL checks. This test has recently started failing presumably because the default time has now fallen too far behind. Fix

[PATCH 1/4] tests/avocado: Fix ppc_hv_tests.py xorriso dependency guard

2024-03-27 Thread Nicholas Piggin
For some reason the skipIf missing_deps() check fails to skip the test if it comes after the skipUnless lines, causing an error running on systems without xorriso. Avocado implements skipUnless is just an inverted skipIf, so it's not clear what the bug is or why this fixes it. For now it's enough

[PATCH 4/4] tests/avocado: Mark ppc_hv_tests.py as non-flaky after fixed console interaction

2024-03-27 Thread Nicholas Piggin
Now that exec_command doesn't incorrectly consume console output, and guest time is set correctly, ppc_hv_tests.py is working more reliably. Try marking it non-flaky. Signed-off-by: Nicholas Piggin --- tests/avocado/ppc_hv_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 0/4] tests/avocado: Fixes for ppc_hv_tests.py

2024-03-27 Thread Nicholas Piggin
This series is a bunch of fixes for ppc_hv_tests.py. It includes a generic avocado patch that I've posted before, but that seems to only really affect ppc_hv_tests.py (I haven't seen other tests wait for console after executing a command like this). If people feel patch 3 is too late for 9.0,

[PATCH 3/4] tests/avocado: exec_command should not consume console output

2024-03-27 Thread Nicholas Piggin
_console_interaction reads data from the console even when there is only an input string to send, and no output data to wait on. This can cause lines to be missed by wait_for_console_pattern calls that follows an exec_command. Fix this by not reading the console if there is no pattern to wait for.

Re: [PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:17AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:17 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated > pc-i440fx-2.2 machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.2

Re: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-03-27 Thread Zhao Liu
Hi Philippe, On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:23 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace > PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE > X-Mailer: git-send-email

Re: [PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:20AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:20 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp > field > X-Mailer: git-send-email 2.41.0 > > AcpiBuildState::rsdp is

Re: [PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:18AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:18 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove > PCMachineClass::resizable_acpi_blob > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 20/21] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:22AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:22 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 20/21] target/i386: Remove > X86CPU::kvm_no_smi_migration field > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug'

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:08AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:08 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to > 'acpi_memory_hotplug' > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH v2] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 4:43 PM Akihiko Odaki wrote: > > It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > checksum offloading is disabled so clear the bit. > > TCP/UDP checksum is usually offloaded when the peer requires virtio > headers because they can instruct the peer to

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:44 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > >

Re: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:16AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:16 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align > from memory_device_pre_plug() > X-Mailer: git-send-email 2.41.0 > >

[PATCH 0/3] target/ppc: fix tlb flushing race

2024-03-27 Thread Nicholas Piggin
ppc broadcast tlb flushes should be synchronised with other vCPUs, like all other architectures that support such operations seem to be doing. Fixing ppc removes the last caller of the non-synced TLB flush variants, we can remove some dead code. I'd like to merge patch 1 for 9.0, and hold patches

[PATCH 1/3] target/ppc: Fix broadcast tlbie synchronisation

2024-03-27 Thread Nicholas Piggin
With mttcg, broadcast tlbie instructions do not wait until other vCPUs have been kicked out of TCG execution before they complete (including necessary subsequent tlbsync, etc., instructions). This is contrary to the ISA, and it permits other vCPUs to use translations after the TLB flush. For

[PATCH 3/3] tcg/cputlb: remove other-cpu capability from TLB flushing

2024-03-27 Thread Nicholas Piggin
Some TLB flush operations can flush other CPUs. The problem with this is they used non-synced variants of flushes (i.e., that return before the destination has completed theflush). Since all TLB flush users need the synced variants and the last user of the non-synced flush was buggy, this is a

[PATCH 2/3] tcg/cputlb: Remove non-synced variants of global TLB flushes

2024-03-27 Thread Nicholas Piggin
These are no longer used. Signed-off-by: Nicholas Piggin --- docs/devel/multi-thread-tcg.rst | 13 ++-- include/exec/exec-all.h | 97 +- accel/tcg/cputlb.c | 103 3 files changed, 19 insertions(+), 194

Re: [PATCH-for-9.0 v2 05/19] hw/display: Restrict xen_register_framebuffer() call to Xen

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:01PM +0100, Philippe Mathieu-Daudé wrote: > Only call xen_register_framebuffer() when Xen is enabled. > > Signed-off-by: Philippe Mathieu-Daudé I don't think this patch is very useful but it's fine, so: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

2024-03-27 Thread Greg Kurz
On Wed, 27 Mar 2024 13:26:45 +0100 Christian Schoenebeck wrote: > On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote: > > On 3/27/24 07:14, Christian Schoenebeck wrote: > > > On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza > > > wrote: > > >> On

Re: [RFC] util/error-report: Add "error: " prefix for error-level report

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 01:36:07PM +0100, Thomas Huth wrote: [snip] > Sounds like a good idea to me, but I think you should then also remove > the hard-coded "error:" strings in the various error_reports(): Thanks Thomas! I missed this case, will remove these hard-code prefix first. > $ grep

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > On Wed, 27 Mar 2024 10:49:43 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > > > On Tue, 26 Mar 2024 14:29:58 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > > > Hi

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Peter Maydell
On Wed, 27 Mar 2024 at 13:23, Daniel P. Berrangé wrote: > > On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > > On Wed, 27 Mar 2024 10:49:43 + > > Daniel P. Berrangé wrote: > > It's question of whether we are willing to do unthinkable, > > i.e. to break QEMU <-> guest ABI for

Re: [PATCH] mem/cxl_type3: fix hpa to dpa logic

2024-03-27 Thread Jonathan Cameron via
On Tue, 26 Mar 2024 21:46:53 -0400 Yao Xingtao wrote: > In 3, 6, 12 interleave ways, we could not access cxl memory properly, > and when the process is running on it, a 'segmentation fault' error will > occur. > > According to the CXL specification '8.2.4.20.13 Decoder Protection', > there are

Re: [PATCH-for-9.1 v2 07/21] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:09AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:09 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 07/21] hw/i386/pc: Remove deprecated > pc-i440fx-2.1 machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.1

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-27 Thread Ani Sinha
> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: > > When using an IGVM file the configuration of the system firmware is > defined by IGVM directives contained in the file. Therefore the default > system firmware should not be initialized when an IGVM file has been > provided. > > This commit

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 01:27:58PM +, Peter Maydell wrote: > On Wed, 27 Mar 2024 at 13:23, Daniel P. Berrangé wrote: > > > > On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > > > On Wed, 27 Mar 2024 10:49:43 + > > > Daniel P. Berrangé wrote: > > > It's question of whether

[PATCH v6 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-03-27 Thread Ho-Ren (Jack) Chuang
Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang --- drivers/dax/kmem.c | 20 ++--

[PATCH v6 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-27 Thread Ho-Ren (Jack) Chuang
The current implementation treats emulated memory devices, such as CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory (E820_TYPE_RAM). However, these emulated devices have different characteristics than traditional DRAM, making it important to distinguish them. Thus, we

[PATCH v2] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-27 Thread Akihiko Odaki
It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear the bit. TCP/UDP checksum is usually offloaded when the peer requires virtio headers because they can instruct the peer to compute checksum. However, igb disables TX checksum offloading when

[PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-03-27 Thread Philippe Mathieu-Daudé
AcpiBuildState::rsdp is always NULL, remove it, simplifying acpi_build_update(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-16-phi...@linaro.org> --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

[PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.2 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 20/21] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-27 Thread Philippe Mathieu-Daudé
X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7 +-- 3 files changed, 1

[PATCH] riscv: thead: Add th.mxstatus CSR emulation

2024-03-27 Thread Christoph Müllner
The th.mxstatus CSR can be used to identify available custom extension on T-Head CPUs. The CSR is documented here: https://github.com/T-head-Semi/thead-extension-spec/pull/45 An important property of this patch is, that the th.mxstatus MAEE field is not set (indicating that XTheadMaee is not

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

2024-03-27 Thread Christian Schoenebeck
On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote: > On 3/27/24 05:47, Christian Schoenebeck wrote: > > On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote: > >> On 3/26/24 14:05, Greg Kurz wrote: > >>> On Tue, 26 Mar 2024 10:26:04 -0300 > >>> Daniel

Re: [PULL 00/15] riscv-to-apply queue

2024-03-27 Thread Michael Tokarev
26.03.2024 12:56, Alistair Francis пишет: On Tue, Mar 26, 2024 at 7:53 PM Michael Tokarev wrote: On 24.03.2024 21:12, Daniel Henrique Barboza wrote: On 3/24/24 12:07, Michael Tokarev wrote: Unfortunately this doesn't quite work, the following changes fail to apply to 8.2: 929e521a47

Re: [PATCH] tests/qtest: Standardize qtest function caller strings.

2024-03-27 Thread Het Gala
On 27/03/24 2:37 am, Fabiano Rosas wrote: Het Gala writes: Some comments, mostly just thinking out loud... For --> migrate // //O:/... For --> validate ///O:/O:/ /O:/O:/... Do we need an optional 'capability' element? I'm not sure how practical is to leave that as 'others', because

Re: vhost-user-blk reconnect issue

2024-03-27 Thread Stefano Garzarella
Hi Yajun, On Mon, Mar 25, 2024 at 10:54:13AM +, Yajun Wu wrote: Hi experts, With latest QEMU (8.2.90), we find two vhost-user-blk backend reconnect failure scenarios: Do you know if has it ever worked and so it's a regression, or have we always had this problem? Thanks, Stefano 1.

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

2024-03-27 Thread Christian Schoenebeck
On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote: > On 3/27/24 07:14, Christian Schoenebeck wrote: > > On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote: > >> On 3/27/24 05:47, Christian Schoenebeck wrote: > >>> On Tuesday, March 26, 2024 6:47:17

[PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Cc: Marek Vasut Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 - docs/about/deprecated.rst

Re: [RFC] util/error-report: Add "error: " prefix for error-level report

2024-03-27 Thread Thomas Huth
On 27/03/2024 12.46, Zhao Liu wrote: From: Zhao Liu When vreport() was introduced, there was no prefix for error-level (REPORT_TYPE_ERROR) report. The original reason is "To maintain compatibility we don't add anything here" as Alistair said in his RFC v3 series [1]. This was done in the

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: > On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > > On Tue, 26 Mar 2024 14:29:58 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > Hi Igor, > > > > > > On 26/3/24 14:08, Thomas Huth wrote: > > > > > > > >

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Please remind me, why didn't we

Re: [RFC PATCH-for-9.0 v2 09/19] hw/block/xen_blkif: Align structs with QEMU_ALIGNED() instead of #pragma

2024-03-27 Thread David Woodhouse
On 27 March 2024 13:31:52 GMT, Anthony PERARD wrote: >On Tue, Nov 14, 2023 at 03:38:05PM +0100, Philippe Mathieu-Daudé wrote: >> Except imported source files, QEMU code base uses >> the QEMU_ALIGNED() macro to align its structures. > >This patch only convert the alignment, but discard pack. We

Re: [PATCH for-9.1 v2 09/11] hostmem: add a new memory backend based on POSIX shm_open()

2024-03-27 Thread David Hildenbrand
On 27.03.24 11:23, Stefano Garzarella wrote: On Tue, Mar 26, 2024 at 03:45:52PM +0100, David Hildenbrand wrote: +mode = 0; +oflag = O_RDWR | O_CREAT | O_EXCL; +backend_name = host_memory_backend_get_name(backend); + +/* + * Some operating systems allow creating anonymous

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

2024-03-27 Thread Daniel Henrique Barboza
On 3/27/24 09:26, Christian Schoenebeck wrote: On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote: On 3/27/24 07:14, Christian Schoenebeck wrote: On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote: On 3/27/24 05:47, Christian Schoenebeck

How to add pcie-root-port and device behind it in C?

2024-03-27 Thread Marcin Juszkiewicz
I was going through Arm (S)BSA tests run against sbsa-ref. Many of them check for presence of other cards than "Root Complex Integrated Endpoint" ones. The "-device root-pcie-port" etc arguments can be used to add such ones but I was wondering how to add them directly in C code. Tried to find

Re: [PATCH-for-9.1 v2 04/21] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:06AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:06 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 04/21] hw/i386/acpi: Remove > PCMachineClass::legacy_acpi_table_size > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote:

Re: [PATCH-for-9.1 v2 09/21] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-27 Thread Zhao Liu
Hi Philippe, On Wed, Mar 27, 2024 at 10:51:11AM +0100, Philippe Mathieu-Daudé wrote: [snip] > diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c > index d802d2787f..f7c2501161 100644 > --- a/hw/i386/fw_cfg.c > +++ b/hw/i386/fw_cfg.c > @@ -63,8 +63,7 @@ void fw_cfg_build_smbios(PCMachineState

Re: [PATCH-for-9.0 v2 11/19] hw/xen/xen_arch_hvm: Rename prototypes using 'xen_arch_' prefix

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:07PM +0100, Philippe Mathieu-Daudé wrote: > Use a common 'xen_arch_' prefix for architecture-specific functions. > Rename xen_arch_set_memory() and xen_arch_handle_ioreq(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: David Woodhouse > Reviewed-by:

Re: [PATCH-for-9.1 v2 09/21] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-27 Thread Zhao Liu
> Since this parameter is always ture, then we can drop it and further > clean up the static flag "smbios_uuid_encoded" in hw/smbios/smbios.c. Oops, my email didn't sync up well, the next two patches were doing just that. Thanks, Zhao

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Tue, Mar 26, 2024 at 02:29:58PM +0100, Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 26/3/24 14:08, Thomas Huth wrote: > > > > s/iaspc/isapc/ in the subject > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > > > ISAPC machine was introduced 25 years ago and it's a lot of time since > > >

Re: [PATCH-for-9.0 v2 08/19] hw/xen: Remove unused Xen stubs

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:04PM +0100, Philippe Mathieu-Daudé wrote: > All these stubs are protected by a 'if (xen_enabled())' check. Are you sure? There's still nothing that prevent a compiler from wanting those, I don't think. Sure, often compilers will remove dead code in `if(0){...}`, but

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Cc: Marek Vasut Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS

Re: [PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:04 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove > XHCI_FLAG_FORCE_PCIE_ENDCAP flag > X-Mailer: git-send-email 2.41.0 > >

[PATCH v3] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-03-27 Thread Alexei Filippov
kvm_riscv_handle_sbi() may return not supported return code to not trigger qemu abort with vendor-specific sbi. Added SBI related return code's defines. Signed-off-by: Alexei Filippov Fixes: 4eb47125 ("target/riscv: Handle KVM_EXIT_RISCV_SBI exit") Reviewed-by: Daniel Henrique Barboza

Re: [PATCH-for-9.1 v2 03/21] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:05AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:05 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 03/21] hw/usb/hcd-xhci: Remove > XHCI_FLAG_SS_FIRST flag > X-Mailer: git-send-email 2.41.0 > > XHCI_FLAG_SS_FIRST was only

Re: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:12 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument > from smbios_set_defaults() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:13AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:13 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded', > simplify smbios_encode_uuid() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 10:26, Paolo Bonzini wrote: On 3/26/24 18:10, Philippe Mathieu-Daudé wrote: Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and inline

Re: [PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:03AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:03 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated > pc-i440fx-2.0 machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.0

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Thomas Huth
On 27/03/2024 14.09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote:

Re: [RFC PATCH-for-9.0 v2 09/19] hw/block/xen_blkif: Align structs with QEMU_ALIGNED() instead of #pragma

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:05PM +0100, Philippe Mathieu-Daudé wrote: > Except imported source files, QEMU code base uses > the QEMU_ALIGNED() macro to align its structures. This patch only convert the alignment, but discard pack. We need both or the struct is changed. > --- >

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-27 Thread Breno Leitao
On Wed, Mar 27, 2024 at 10:27:58AM +0800, Heng Qi wrote: > > > 在 2024/3/26 下午11:19, Breno Leitao 写道: > > There is a bug when setting the RSS options in virtio_net that can break > > the whole machine, getting the kernel into an infinite loop. > > > > Running the following command in any QEMU

Re: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:15AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:15 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align > argument from pc_dimm_pre_plug() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:19AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:19 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove > PCMachineClass::rsdp_in_ram > X-Mailer: git-send-email 2.41.0 > > PCMachineClass::rsdp_in_ram

Re: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 to 2.7 pc-i440fx machines

2024-03-27 Thread Zhao Liu
Hi Philippe, On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:21 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 > to 2.7 pc-i440fx machines > X-Mailer: git-send-email 2.41.0

Re: [PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove 'memory-hotplug-support' property

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:07AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:07 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove > 'memory-hotplug-support' property > X-Mailer: git-send-email 2.41.0 > > No external code sets

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > > > Hi Cindy: > > > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > > > > > we need a crash in Non-standard image, here is the jira for this > > >

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > > > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > > > > > > > Hi Cindy: > > > > > > > > On Wed, Mar 27, 2024 at 9:29 AM

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

2024-03-27 Thread Paolo Bonzini
On 3/26/24 18:10, Philippe Mathieu-Daudé wrote: Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and inline function to be added in the code base.

Re: [PATCH for-9.1 v2 02/11] libvhost-user: fail vu_message_write() if sendmsg() is failing

2024-03-27 Thread Stefano Garzarella
On Tue, Mar 26, 2024 at 03:36:52PM +0100, David Hildenbrand wrote: On 26.03.24 15:34, Eric Blake wrote: On Tue, Mar 26, 2024 at 02:39:27PM +0100, Stefano Garzarella wrote: In vu_message_write() we use sendmsg() to send the message header, then a write() to send the payload. If sendmsg() fails

[PATCH for-9.0 v2 1/7] qtest/virtio-9p-test.c: add '_path' in path vars

2024-03-27 Thread Daniel Henrique Barboza
Add a '_path' call in all variables that are receiving a full path via virtio_9p_test_path(). Aside from being more accurate with what the variable represents, this will allow us to use 'new_dir' and 'real_path' and so on to parametrize test values in the next patch. Signed-off-by: Daniel

[PATCH for-9.0 v2 4/7] qtest/virtio-9p-test.c: consolidate create file tests

2024-03-27 Thread Daniel Henrique Barboza
Similar to what was done with fs_create_dir() in the previous patch, and for the same reasons, let's consolidate fs_create_file() and fs_unlinkat_file() in a single test that has the same coverage: - fs_create_file() is removed; - rename fs_unlinkat_file() to fs_create_unlinkat_file(); - change

[PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::resizable_acpi_blob was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_build(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/acpi-build.c | 10 -- hw/i386/pc.c | 1

Re: [PATCH v2 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-03-27 Thread Conor Dooley
Christoph linked here on his submission to Linux of a fix for this, so I am reviving this to leave a couple comments :) On Thu, Feb 15, 2024 at 02:24:02PM +1000, Alistair Francis wrote: > On Mon, Feb 5, 2024 at 6:37 PM Christoph Müllner > wrote: > > On Mon, Feb 5, 2024 at 3:42 AM Alistair

Re: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread David Hildenbrand
void memory_device_pre_plug(MemoryDeviceState *md, MachineState *ms, -const uint64_t *legacy_align, Error **errp) +Error **errp) { const MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(md); Error *local_err = NULL; @@

Re: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-27 Thread David Hildenbrand
On 27.03.24 10:51, Philippe Mathieu-Daudé wrote: 'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-11-phi...@linaro.org> --- I was really confused for a second until I saw that this series is dependent

[RFC] util/error-report: Add "error: " prefix for error-level report

2024-03-27 Thread Zhao Liu
From: Zhao Liu When vreport() was introduced, there was no prefix for error-level (REPORT_TYPE_ERROR) report. The original reason is "To maintain compatibility we don't add anything here" as Alistair said in his RFC v3 series [1]. This was done in the context of inheriting the original

[PATCH] MAINTAINERS: Fix error-report.c entry

2024-03-27 Thread Zhao Liu
From: Zhao Liu The commit 15002f60f792 ("util: rename qemu-error.c to match its header name") renamed util/qemu-error.c to util/error-report.c but missed to change the corresponding entry. To avoid get_maintainer.pl failing, update the error-report.c entry. Signed-off-by: Zhao Liu ---

Re: Compiling QEMU with different optimization levels & -Werror=maybe-uninitialized

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 03:28:08PM +0400, Marc-André Lureau wrote: > Hi, > > Depending -Doptimization=, I get different results (GCC 13.2.1) > - g: produces -Werror=maybe-uninitialized errors > - 0: clean build > - 1: produces -Werror=maybe-uninitialized errors > - 2: clean build > - 3: produces

Re: [PULL 35/38] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

2024-03-27 Thread Thomas Huth
On 27/03/2024 06.41, Harsh Prateek Bora wrote: On 3/26/24 21:32, Peter Maydell wrote: On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote: From: Harsh Prateek Bora Introduce the nested PAPR hcalls: - H_GUEST_GET_STATE which is used to get state of a nested guest or    a guest

[PATCH] configure: Disable -Werror by default if sanitizers are enabled

2024-03-27 Thread Akihiko Odaki
!= enabled && meson_option_add "-Dtcg=$tcg" + test "$sanitizers" = yes && meson_option_add -Dsanitizers=true run_meson() { NINJA=$ninja $meson setup "$@" "$PWD" "$source_path" } --- base-commit: ba49d760eb04630e7b15f423ebecf6c871b8f77b change-id: 20240327-werror-5d2e974c3d7d Best regards, -- Akihiko Odaki

Re: [PATCH v4 1/2] kvm: add support for guest physical bits

2024-03-27 Thread Paolo Bonzini
On Wed, Mar 20, 2024 at 3:45 AM Xiaoyao Li wrote: > If users pass configuration like "-cpu > qemu64,phys-bits=52,host-phys-bits-limit=45", the cpu->guest_phys_bits > will be set to 45. I think this is not what we want, though the usage > seems insane. > > We can guard it as > > if

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > > > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > >

[PATCH-for-9.1 v2 07/21] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.1 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 09/21] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::smbios_uuid_encoded was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true, remove it. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 3 +-- hw/i386/pc.c | 1 - 3 files

[PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Philippe Mathieu-Daudé
'uuid_encoded' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/firmware/smbios.h | 3 +-- hw/arm/virt.c| 3 +-- hw/i386/fw_cfg.c | 2 +- hw/loongarch/virt.c | 2 +- hw/riscv/virt.c | 2 +- hw/smbios/smbios.c

[PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread Philippe Mathieu-Daudé
'legacy_align' is always NULL, remove it, simplifying memory_device_pre_plug(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-12-phi...@linaro.org> --- include/hw/mem/memory-device.h | 2 +- hw/i386/pc.c | 3 +--

  1   2   3   >