Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

On Tue, Apr 16, 2024 at 03:52:30PM +0200, Philippe Mathieu-Daudé wrote: > Date: Tue, 16 Apr 2024 15:52:30 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx > machines > X-Mailer: git-send-email 2.41.0 > > Similarly to the commit

Re: [PATCH v6 10/12] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions

On Mon, 15 Apr 2024 10:37:00 -0700 fan wrote: > On Fri, Apr 12, 2024 at 06:54:42PM -0400, Gregory Price wrote: > > On Mon, Mar 25, 2024 at 12:02:28PM -0700, nifan@gmail.com wrote: > > > From: Fan Ni > > > > > > All dpa ranges in the DC regions are invalid to access until an extent > > >

Re: [PATCH v6 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

On Mon, 15 Apr 2024 13:06:04 -0700 fan wrote: > From ce75be83e915fbc4dd6e489f976665b81174002b Mon Sep 17 00:00:00 2001 > From: Fan Ni > Date: Tue, 20 Feb 2024 09:48:31 -0800 > Subject: [PATCH 09/13] hw/cxl/events: Add qmp interfaces to add/release > dynamic capacity extents > > To simulate FM

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe

[PATCH RFC 18/26] migration: Add load_finish handler and associated functions

From: "Maciej S. Szmigiero" load_finish SaveVMHandler allows migration code to poll whether a device-specific asynchronous device state loading operation had finished. In order to avoid calling this handler needlessly the device is supposed to notify the migration code of its possible readiness

[PATCH RFC 07/26] migration/postcopy: pass PostcopyPChannelConnectData when connecting sending preempt socket

From: "Maciej S. Szmigiero" This will allow passing additional parameters there in the future. Signed-off-by: Maciej S. Szmigiero --- migration/postcopy-ram.c | 68 +++- 1 file changed, 61 insertions(+), 7 deletions(-) diff --git a/migration/postcopy-ram.c

[PATCH RFC 24/26] migration/multifd: Add migration_has_device_state_support()

From: "Maciej S. Szmigiero" Since device state transfer via multifd channels requires multifd channels with migration channel header and is currently not compatible with multifd compression add an appropriate query function so device can learn whether it can actually make use of it.

[PATCH RFC 15/26] migration/multifd: Zero p->flags before starting filling a packet

From: "Maciej S. Szmigiero" This way there aren't stale flags there. p->flags can't contain SYNC to be sent at the next RAM packet since syncs are now handled separately in multifd_send_thread. Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH RFC 26/26] vfio/migration: Multifd device state transfer support - send side

From: "Maciej S. Szmigiero" Implement the multifd device state transfer via additional per-device thread spawned from save_live_complete_precopy_async handler. Switch between doing the data transfer in the new handler and doing it in the old save_state handler depending on the

[PATCH RFC 19/26] migration: Add x-multifd-channels-device-state parameter

From: "Maciej S. Szmigiero" This parameter allows specifying how many multifd channels are dedicated to sending device state in parallel. It is ignored on the receive side. Signed-off-by: Maciej S. Szmigiero --- migration/migration-hmp-cmds.c | 7 + migration/options.c| 51

[PATCH RFC 22/26] migration/multifd: Convert multifd_send_pages::next_channel to atomic

From: "Maciej S. Szmigiero" This is necessary for multifd_send_pages() to be able to be called from multiple threads. Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c

[PATCH RFC 23/26] migration/multifd: Device state transfer support - send side

From: "Maciej S. Szmigiero" A new function multifd_queue_device_state() is provided for device to queue its state for transmission via a multifd channel. Signed-off-by: Maciej S. Szmigiero --- include/migration/misc.h | 4 + migration/multifd-zlib.c | 2 +- migration/multifd-zstd.c | 2

[PATCH RFC 08/26] migration: Allow passing migration header in migration channel creation

From: Avihai Horon Signed-off-by: Avihai Horon [MSS: Rewrite using MFDSendChannelConnectData/PostcopyPChannelConnectData] Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 14 -- migration/postcopy-ram.c | 14 -- 2 files changed, 24 insertions(+), 4

[PATCH RFC 20/26] migration: Add MULTIFD_DEVICE_STATE migration channel type

From: "Maciej S. Szmigiero" Signed-off-by: Maciej S. Szmigiero --- migration/channel.h | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/channel.h b/migration/channel.h index 4232ee649939..b985c952550d 100644 --- a/migration/channel.h +++ b/migration/channel.h @@ -33,6 +33,7 @@

[PATCH RFC 02/26] migration: Add migration channel header send/receive

From: Avihai Horon Add functions to send and receive migration channel header. Signed-off-by: Avihai Horon [MSS: Mark MigChannelHeader as packed, remove device id from it] Signed-off-by: Maciej S. Szmigiero --- migration/channel.c| 59 ++

[PATCH RFC 21/26] migration/multifd: Device state transfer support - receive side

From: "Maciej S. Szmigiero" Add a basic support for receiving device state via multifd channels - both dedicated ones or shared with RAM transfer. To differentiate between a device state and a RAM packet the packet header is read first. Depending whether MULTIFD_FLAG_DEVICE_STATE flag is

[PATCH RFC 14/26] migration/ram: Add load start trace event

From: "Maciej S. Szmigiero" There's a RAM load complete trace event but there wasn't its start equivalent. Signed-off-by: Maciej S. Szmigiero --- migration/ram.c| 1 + migration/trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index

RE: [PATCH v6 0/2] Implement SSH commands in QEMU GA for Windows

Hello Konstantin, Is there anything you would like to see addresses in this patch before it merges? This patch has been up for a bit and there hasn't been any activity in a while. Our team is motivated to get this merged, so let me know if there is anything I can do on my end to make the

[PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

From: "Maciej S. Szmigiero" VFIO device state transfer is currently done via the main migration channel. This means that transfers from multiple VFIO devices are done sequentially and via just a single common migration channel. Such way of transferring VFIO device state migration data reduces

[PATCH RFC 12/26] migration: Enable x-channel-header pseudo-capability

From: Avihai Horon Now that migration channel header has been implemented, enable it. Signed-off-by: Avihai Horon Signed-off-by: Maciej S. Szmigiero --- migration/options.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/options.c b/migration/options.c index

[PATCH RFC 09/26] migration: Add send/receive header for postcopy preempt channel

From: Avihai Horon Add send and receive migration channel header for postcopy preempt channel. Signed-off-by: Avihai Horon [MSS: Adapt to rewritten migration header passing commit] Signed-off-by: Maciej S. Szmigiero --- migration/channel.h | 1 + migration/migration.c| 5 +

[PATCH RFC 16/26] migration: Add save_live_complete_precopy_async{, wait} handlers

From: "Maciej S. Szmigiero" These SaveVMHandlers allow device to provide its own asynchronous transmission of the remaining data at the end of a precopy phase. The save_live_complete_precopy_async handler is supposed to start such transmission (for example, by launching appropriate threads)

[PATCH RFC 25/26] vfio/migration: Multifd device state transfer support - receive side

From: "Maciej S. Szmigiero" The multifd received data needs to be reassembled since device state packets sent via different multifd channels can arrive out-of-order. Therefore, each VFIO device state packet carries a header indicating its position in the stream. The last such VFIO device state

[PATCH RFC 10/26] migration: Add send/receive header for multifd channel

From: Avihai Horon Add send and receive migration channel header for multifd channel. Signed-off-by: Avihai Horon [MSS: Adapt to rewritten migration header passing commit] Signed-off-by: Maciej S. Szmigiero --- migration/channel.h | 1 + migration/migration.c | 16

[PATCH RFC 11/26] migration/options: Mapped-ram is not channel header compatible

From: "Maciej S. Szmigiero" Mapped-ram is only available for multifd migration without channel header - add an appropriate check to migration options. Signed-off-by: Maciej S. Szmigiero --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c

[PATCH RFC 17/26] migration: Add qemu_loadvm_load_state_buffer() and its handler

From: "Maciej S. Szmigiero" qemu_loadvm_load_state_buffer() and its load_state_buffer SaveVMHandler allow providing device state buffer to explicitly specified device via its idstr and instance id. Signed-off-by: Maciej S. Szmigiero --- include/migration/register.h | 15 +++

[PATCH RFC 01/26] migration: Add x-channel-header pseudo-capability

From: Avihai Horon Add x-channel-header pseudo-capability which indicates that a header should be sent through migration channels. The header is the first thing to be sent through a migration channel and it allows the destination to differentiate between the various channels (main, multifd and

[PATCH RFC 13/26] vfio/migration: Add save_{iterate, complete_precopy}_started trace events

From: "Maciej S. Szmigiero" This way both the start and end points of migrating a particular VFIO device are known. Add also a vfio_save_iterate_empty_hit trace event so it is known when there's no more data to send for that device. Signed-off-by: Maciej S. Szmigiero --- hw/vfio/migration.c

[PATCH RFC 04/26] multifd: change multifd_new_send_channel_create() param type

From: "Maciej S. Szmigiero" This function is called only with MultiFDSendParams type param so use this type explicitly instead of using an opaque pointer. Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH RFC 06/26] multifd: pass MFDSendChannelConnectData when connecting sending socket

From: "Maciej S. Szmigiero" This will allow passing additional parameters there in the future. Signed-off-by: Maciej S. Szmigiero --- migration/file.c| 5 ++- migration/multifd.c | 95 ++--- migration/multifd.h | 4 +- 3 files changed, 80

[PATCH RFC 03/26] migration: Add send/receive header for main channel

From: Avihai Horon Add send and receive migration channel header for main channel. Signed-off-by: Avihai Horon [MSS: Rename main channel -> default channel where it matches the current term] Signed-off-by: Maciej S. Szmigiero --- migration/channel.c | 9 + migration/migration.c | 82

[PATCH RFC 05/26] migration: Add a DestroyNotify parameter to socket_send_channel_create()

From: "Maciej S. Szmigiero" Makes managing the memory easier. Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 2 +- migration/postcopy-ram.c | 2 +- migration/socket.c | 6 -- migration/socket.h | 3 ++- 4 files changed, 8 insertions(+), 5 deletions(-) diff

Re: [PATCH v2 08/10] i386/sev: Implement ConfidentialGuestSupport functions for SEV

On Wed, Apr 03, 2024 at 12:11:39PM +0100, Roy Hopkins wrote: > The ConfidentialGuestSupport object defines a number of virtual > functions that are called during processing of IGVM directives to query > or configure initial guest state. In order to support processing of IGVM > files, these

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst

Re: [PATCH v2 05/10] i386/pc: Process IGVM file during PC initialization if present

On Wed, Apr 03, 2024 at 12:11:36PM +0100, Roy Hopkins wrote: > An IGVM file contains configuration of a guest that supports > confidential computing hardware. As part of the PC system > initialisation, the IGVM needs to be processed to apply this > configuration before the guest is started. > >

Re: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap

Hello, On 4/16/24 09:09, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Subject: Re: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap On 4/8/24 10:44, Zhenzhong Duan wrote: From: Yi Liu If check fails, the

[PATCH v1] virtio-mem: improve error message when unplug of device fails due to plugged memory

The error message is actually expressive, considering QEMU only. But when called from Libvirt, talking about "size" can be confusing, because in Libvirt "size" translates to the memory backend size in QEMU (maximum size) and "current" translates to the QEMU "size" property. Let's simply avoid

Re: [PATCH v2 01/10] meson: Add optional dependency on IGVM library

On Wed, Apr 03, 2024 at 12:11:32PM +0100, Roy Hopkins wrote: > The IGVM library allows Independent Guest Virtual Machine files to be > parsed and processed. IGVM files are used to configure guest memory > layout, initial processor state and other configuration pertaining to > secure virtual

Re: [PATCH v2 04/10] backends/igvm: Implement parsing and processing of IGVM files

On Wed, Apr 03, 2024 at 12:11:35PM +0100, Roy Hopkins wrote: > This commit adds an implementation of an IGVM loader which parses the > file specified as a pararameter to ConfidentialGuestSupport and provides > a function that uses the interface in the same object to configure and > populate guest

[PATCH v3 02/22] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

The pc-i440fx-2.0 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH v3 16/22] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

The pc-i440fx-2.2 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH v3 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

The pc-i440fx-2.3 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 4 ++--

[PATCH v3 07/22] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug'

acpi_memory_hotplug::is_enabled is set to %true once via ich9_lpc_initfn() -> ich9_pm_add_properties(). No need to check it, so remove now dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/acpi/ich9.c | 28 ++-- 1 file changed, 6

[PATCH v3 19/22] hw/i386/acpi: Remove AcpiBuildState::rsdp field

AcpiBuildState::rsdp is always NULL, remove it, simplifying acpi_build_update(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-16-phi...@linaro.org> Reviewed-by: Zhao Liu --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+),

[PATCH v3 08/22] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

The pc-i440fx-2.1 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH v3 06/22] hw/acpi/ich9: Remove 'memory-hotplug-support' property

No external code sets the 'memory-hotplug-support' property, remove it. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/acpi/ich9.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[PATCH v3 21/22] target/i386: Remove X86CPU::kvm_no_smi_migration field

X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7

[PATCH v3 22/22] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

PCMachineClass::acpi_data_size was only used by the pc-i440fx-2.0 machine, which got removed. Since it is constant, replace the class field by a definition (local to hw/i386/pc.c, since not used elsewhere). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH v3 00/22] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines

Missing review: 1 (new, extracted from 20) & 20 Since v2: - Addressed Zhao review comments Since v1: - Addressed Zhao and Thomas review comments Kill legacy code, because we need to evolve. I ended there via dynamic machine -> ICH9 -> legacy ACPI... This should also help Igor cleanups:

[PATCH v3 18/22] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

PCMachineClass::rsdp_in_ram was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_setup(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-15-phi...@linaro.org> Reviewed-by: Zhao Liu

[PATCH v3 14/22] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-11-phi...@linaro.org> Reviewed-by: David Hildenbrand Reviewed-by: Zhao Liu --- include/hw/mem/pc-dimm.h | 3 +-- hw/arm/virt.c| 2 +-

[PATCH v3 17/22] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

PCMachineClass::resizable_acpi_blob was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_build(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 3 --- hw/i386/acpi-build.c | 10 --

[PATCH v3 15/22] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

'legacy_align' is always NULL, remove it, simplifying memory_device_pre_plug(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-12-phi...@linaro.org> Reviewed-by: David Hildenbrand Reviewed-by: Zhao Liu --- include/hw/mem/memory-device.h | 2

Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

Hello, On 4/16/24 05:41, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Subject: Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device On 4/8/24 10:12, Zhenzhong Duan wrote: HIODLegacyVFIO represents a host IOMMU device under VFIO legacy container

[PATCH v3 11/22] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

'uuid_encoded' is always true, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/firmware/smbios.h | 3 +-- hw/arm/virt.c| 3 +-- hw/i386/fw_cfg.c | 2 +- hw/loongarch/virt.c | 2 +- hw/riscv/virt.c | 2 +-

[PATCH v3 09/22] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h'

x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by the pc-i440fx-2.1 machine, which got removed. Make it static, and remove its declaration. "kvm-cpu.h" is now empty, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH v3 05/22] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size

PCMachineClass::legacy_acpi_table_size was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify acpi_build(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c | 62

[PATCH v3 10/22] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

PCMachineClass::smbios_uuid_encoded was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true, remove it. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 3 +-- hw/i386/pc.c

[PATCH v3 13/22] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

PCMachineClass::enforce_aligned_dimm was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true. Remove it, simplifying pc_get_device_memory_range(). Update the comment in Avocado test_phybits_low_pse36(). Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v3 12/22] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid()

'smbios_encode_uuid' is always true, remove it, simplifying smbios_encode_uuid(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/smbios/smbios.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index

[PATCH v3 04/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify various functions in hcd-xhci.c. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/usb/hcd-xhci.h | 3 +-- hw/usb/hcd-xhci-nec.c | 2 --

[PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 4 ++-- hw/i386/pc_piix.c | 2 +- 2 files

[PATCH v3 03/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify usb_xhci_pci_realize(). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/usb/hcd-xhci.h | 1 - hw/usb/hcd-xhci-nec.c | 2 --

Re: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

On 28/3/24 05:10, Zhao Liu wrote: Hi Philippe, On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:23 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

Re: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

On 27/3/24 12:32, David Hildenbrand wrote: On 27.03.24 10:51, Philippe Mathieu-Daudé wrote: 'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-11-phi...@linaro.org> --- I was really confused for a

Re: [PATCH v2 03/10] backends/confidential-guest-support: Add functions to support IGVM

On Thu, Apr 04, 2024 at 10:00:53AM +0200, Philippe Mathieu-Daudé wrote: > Hi Roy, > > On 3/4/24 13:11, Roy Hopkins wrote: > > In preparation for supporting the processing of IGVM files to configure > > guests, this adds a set of functions to ConfidentialGuestSupport > > allowing configuration of

Re: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

On 28/3/24 03:54, Zhao Liu wrote: On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:14 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm X-Mailer: git-send-email

Re: [PATCH v2 02/10] backends/confidential-guest-support: Add IGVM file parameter

On Wed, Apr 03, 2024 at 12:11:33PM +0100, Roy Hopkins wrote: > In order to add support for parsing IGVM files for secure virtual > machines, a the path to an IGVM file needs to be specified as > part of the guest configuration. It makes sense to add this to > the ConfidentialGuestSupport object as

Re: [QEMU][PATCH v3 5/7] memory: add MemoryRegion map and unmap callbacks

On 16.04.24 13:32, Edgar E. Iglesias wrote: On Wed, Apr 10, 2024 at 8:56 PM Peter Xu wrote: On Wed, Apr 10, 2024 at 06:44:38PM +0200, Edgar E. Iglesias wrote: On Tue, Feb 27, 2024 at 11:37 PM Vikram Garhwal wrote: From: Juergen Gross In order to support mapping and unmapping guest

Re: [PATCH-for-9.1 v2 0/3] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET

On 22/3/24 17:14, Philippe Mathieu-Daudé wrote: 'NEED_CPU_H' guard target-specific code. Clarify by renaming as COMPILING_PER_TARGET. Philippe Mathieu-Daudé (3): gdbstub: Simplify #ifdef'ry in helpers.h hw/core: Remove check on NEED_CPU_H in tcg-cpu-ops.h exec: Rename NEED_CPU_H ->

Re: [PATCH] Add zh_TW Traditional Chinese translation

On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello wrote: > > From: Peter Dave Hello > Date: Tue, 16 Apr 2024 00:43:29 +0800 > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation > > This patch adds a basic zh_TW translation file for Taiwan Traditional > Chinese users. > >

Re: [PATCH] hw/s390x: Include missing 'cpu.h' header

On 22/3/24 17:28, Philippe Mathieu-Daudé wrote: "cpu.h" is implicitly included. Include it explicitly to avoid the following error when refactoring headers: hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 'TARGET_PAGE_SIZE' len = sac->peek_stattr(sas, addr /

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > wrote: > > > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > > > the function will get the vector incorrectly while

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, 16 Apr 2024 at 14:06, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell > wrote: > > Paolo's comment on CID 1468940 was to suggest "virtio_queue_vector > > should check VIRTIO_CONFIG_IRQ_IDX just like virtio_pci_get_notifier", > > incidentally. > > > Hi peter， > Really

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote: > > > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > > wrote: > > > > Hi; Coverity points out what it thinks is a problem

[PATCH] Add zh_TW Traditional Chinese translation

From: Peter Dave Hello Date: Tue, 16 Apr 2024 00:43:29 +0800 Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation This patch adds a basic zh_TW translation file for Taiwan Traditional Chinese users. Signed-off-by: Peter Dave Hello --- po/LINGUAS | 1 + po/zh_TW.po | 93

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, Apr 16, 2024 at 7:50 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > wrote: > > > Here we pass that through to kvm_virtio_pci_vector_use_one(). > > > In kvm_virtio_pci_vector_use_one()'s error-exit path

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > > the function will get the vector incorrectly while using > > VIRTIO_CONFIG_IRQ_IDX > > To fix this, we remove this

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > the function will get the vector incorrectly while using > VIRTIO_CONFIG_IRQ_IDX > To fix this, we remove this label and simplify the failure process > > Fixes: f9a09ca3ea ("vhost:

[PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

In function kvm_virtio_pci_vector_use_one(), in the undo label, the function will get the vector incorrectly while using VIRTIO_CONFIG_IRQ_IDX To fix this, we remove this label and simplify the failure process Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc:

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > wrote: > > > Hi; Coverity points out what it thinks is a problem in > > > this commit (CID 1543938): > > > Here we pass that through

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a slowish CI runner -- which suggests to me

Re: [PATCH for-9.0?] usb-storage: Fix BlockConf defaults

On Tue, 16 Apr 2024 at 10:26, Hanna Czenczek wrote: > > On 12.04.24 16:42, Kevin Wolf wrote: > > Commit 30896374 started to pass the full BlockConf from usb-storage to > > scsi-disk, while previously only a few select properties would be > > forwarded. This enables the user to set more

cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. https://gitlab.com/qemu-project/qemu/-/issues/2285 has the details with links to 8 CI jobs in the last week or so with timeouts, typically something like: 16/258 qemu:qtest+qtest-aarch64 /

Re: [PATCH v2] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`

On 4/14/24 12:28, Inès Varhol wrote: The messages for assertions using hexadecimal numbers will be easier to understand with `g_assert_cmphex`. Cases changed : "cmpuint.*0x", "cmpuint.*<<" Signed-off-by: Inès Varhol --- tests/qtest/aspeed_fsi-test.c | 20 ++--

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > wrote: > > Here we pass that through to kvm_virtio_pci_vector_use_one(). > > In kvm_virtio_pci_vector_use_one()'s error-exit path ("undo") > > it does > > vector = virtio_queue_vector(vdev,

Re: [PATCH] dma-helpers: Fix iovec alignment

adding John Snow to CC because he investigated this in 2020. On Fri, 12 Apr 2024, Eric Blake wrote: > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a > > dynamic field 'align' but introduced a bug.

Re: [QEMU][PATCH v3 5/7] memory: add MemoryRegion map and unmap callbacks

On Wed, Apr 10, 2024 at 8:56 PM Peter Xu wrote: > > On Wed, Apr 10, 2024 at 06:44:38PM +0200, Edgar E. Iglesias wrote: > > On Tue, Feb 27, 2024 at 11:37 PM Vikram Garhwal > > wrote: > > > > > From: Juergen Gross > > > > > > In order to support mapping and unmapping guest memory dynamically to >

Re: [PATCH] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

On 15/4/24 20:39, Thomas Huth wrote: The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly this purpose, which is meant to handle the

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell wrote: > > On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > > > From: Cindy Lu > > > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop() was

Re: [PATCH v5 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

Hi On Tue, Apr 16, 2024 at 3:11 AM wrote: > > From: Dongwon Kim > > This commit introduces dpy_gl_qemu_dmabuf_get_... helpers to extract > specific fields from the QemuDmaBuf struct. It also updates all instances > where fields within the QemuDmaBuf struct are directly accessed, replacing >

Re: [PULL 0/2] Misc HW patches for 2024-04-15

On Mon, 15 Apr 2024 at 15:56, Philippe Mathieu-Daudé wrote: > > The following changes since commit 824ebb92c39920a65b34a93d1bd462baf0d2d174: > > Merge tag 'pull-sp-20240412' of https://gitlab.com/rth7680/qemu into > staging (2024-04-13 09:43:46 +0100) > > are available in the Git repository

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

On 4/15/24 19:56, fan wrote: > From 4b9695299d3d4b22f83666f8ab79099ec9f9817f Mon Sep 17 00:00:00 2001 > From: Fan Ni > Date: Tue, 20 Feb 2024 09:48:30 -0800 > Subject: [PATCH 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox commands to > support add/release dynamic capacity response > > Per CXL

Re: [PULL 1/1] virtio-pci: fix use of a released vector

On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > From: Cindy Lu > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function >

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

On Wed, Apr 3, 2024 at 2:11 PM Akihiko Odaki wrote: > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > implicitly disables RSS even if the user explicitly requests it. Return > an error instead of implicitly disabling RSS if RSS is requested but not > available. > >

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

On Tue, Apr 16, 2024 at 10:14 AM Jason Wang wrote: > > On Tue, Apr 16, 2024 at 1:43 PM Yuri Benditovich > wrote: > > > > On Tue, Apr 16, 2024 at 7:00 AM Jason Wang wrote: > > > > > > On Mon, Apr 15, 2024 at 10:05 PM Yuri Benditovich > > > wrote: > > > > > > > > On Wed, Apr 3, 2024 at 2:11 PM

Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

On Tue, 16 Apr 2024, Nicholas Piggin wrote: On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote: On Wed, 10 Apr 2024, Nicholas Piggin wrote: On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI

Re: [PATCH v2 3/6] hw/ppc: SPI controller model - sequencer and shifter

Hello, Please rephrase the subject to something like: "ppc/pnv: Extend SPI model ..." Using a verb is preferable. On 4/9/24 19:56, Chalapathi V wrote: In this commit SPI shift engine and sequencer logic is implemented. Shift engine performs serialization and de-serialization according to

Re: [PATCH for-9.0?] usb-storage: Fix BlockConf defaults

On 12.04.24 16:42, Kevin Wolf wrote: Commit 30896374 started to pass the full BlockConf from usb-storage to scsi-disk, while previously only a few select properties would be forwarded. This enables the user to set more properties, e.g. the block size, that are actually taking effect. However,

Re: [RFC PATCH 0/4] target/riscv/kvm: QEMU support for KVM Guest Debug on RISC-V

On 4/9/24 06:43, Chao Du wrote: Hi Daniel and all, The KVM patches have been reviewd and are in the queue. https://lore.kernel.org/all/20240402062628.5425-1-duc...@eswincomputing.com/ Could you please review in the QEMU side ? Then I will rebase this series with your comments. Some Notes:

<    1   2   3   >