Re: [PATCH v11 19/21] i386: Add cache topology info in CPUCacheInfo

2024-04-30 Thread Tejus GK
On 24 Apr 2024, at 9:19 PM, Zhao Liu wrote: @@ -2140,6 +2164,7 @@ static const CPUCaches epyc_milan_cache_info = { .lines_per_tag = 1, .self_init = 1, .no_invd_sharing = true, +.share_level = CPU_TOPO_LEVEL_CORE, }, .l1i_cache = &(CPUCacheInfo) {

[PULL 19/19] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-30 Thread Thomas Huth
During the past months, the netbsd and openbsd jobs in the Cirrus-CI were broken most of the time - the setup to run a BSD in KVM on Cirrus-CI from gitlab via the cirrus-run script was very fragile, and since the jobs were not run by default, it used to bitrot very fast. Now Cirrus-CI also

[PULL 07/19] hw: misc: edu: fix 2 off-by-one errors

2024-04-30 Thread Thomas Huth
From: Chris Friedt In the case that size1 was zero, because of the explicit 'end1 > addr' check, the range check would fail and the error message would read as shown below. The correct comparison is 'end1 >= addr'. EDU: DMA range 0x4-0x3 out of bounds (0x4-0x40fff)! Resolves:

[PULL 12/19] hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size

2024-04-30 Thread Thomas Huth
"make check-qtest-aarch64" recently started failing on FreeBSD builds, and valgrind on Linux also detected that there is something fishy with the new stm32l4x5-usart: The code forgot to set the correct class_size here, so the various class_init functions in this file wrote beyond the allocated

[PULL 14/19] gitlab: migrate the s390x custom machine to 22.04

2024-04-30 Thread Thomas Huth
From: Alex Bennée 20.04 is dead (from QEMU's point of view), long live 22.04! Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID: <20240426153938.1707723-3-alex.ben...@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/custom-runners.yml | 2 +-

[PULL 18/19] .gitlab-ci.d/cirrus.yml: Shorten the runtime of the macOS and FreeBSD jobs

2024-04-30 Thread Thomas Huth
Cirrus-CI introduced limitations to the free CI minutes. To avoid that we are consuming them too fast, let's drop the usual targets that are not that important since they are either a subset of another target (like i386 or ppc being a subset of x86_64 or ppc64 respectively), or since there is

[PULL 16/19] hw/ide/core.c (cmd_read_native_max): Avoid limited device parameters

2024-04-30 Thread Thomas Huth
From: Lev Kujawski Always use the native CHS device parameters for the ATA commands READ NATIVE MAX ADDRESS and READ NATIVE MAX ADDRESS EXT, not those limited by the ATA command INITIALIZE_DEVICE_PARAMETERS (introduced in patch 176e4961, hw/ide/core.c: Implement ATA INITIALIZE_DEVICE_PARAMETERS

[PULL 06/19] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-8-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models_sysemu.c | 4 +--- 1 file

Re: [PATCH v3 08/16] aspeed/smc: support 64 bits dma dram address

2024-04-30 Thread Cédric Le Goater
On 4/19/24 08:00, Jamin Lin wrote: Hi Cedric, Hello Jamin, On 4/16/24 11:18, Jamin Lin wrote: AST2700 support the maximum dram size is 8GiB and has a "DMA DRAM Side Address High Part(0x7C)" register to support 64 bits dma dram address. Add helper routines functions to compute the dma dram

Re: [PATCH v5 3/5] migration: process_incoming_migration_co(): fix reporting s->error

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 30.04.24 11:06, Vladimir Sementsov-Ogievskiy wrote: On 29.04.24 22:32, Peter Xu wrote: On Mon, Apr 29, 2024 at 10:14:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to

Re: [PATCH v4 3/3] qapi: introduce device-sync-config

2024-04-30 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add command to sync config from vhost-user backend to the device. It > may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not > triggered interrupt to the guest or just not available (not supported > by vhost-user server). > > Command result

[PULL 00/19] Misc patches (s390x clean-ups, fixes for crashes, ...)

2024-04-30 Thread Thomas Huth
Hi Richard! The following changes since commit 5fee33d97a7f2e95716417bd164f2f5264acd976: Merge tag 'samuel-thibault' of https://people.debian.org/~sthibault/qemu into staging (2024-04-29 14:34:25 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git

[PULL 01/19] target/s390x/cpu_model: Make check_compatibility() return boolean

2024-04-30 Thread Thomas Huth
From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. With returned boolean, there's no need to check @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID:

[PULL 17/19] tests/qtest/ide-test: Verify READ NATIVE MAX ADDRESS is not limited

2024-04-30 Thread Thomas Huth
From: Lev Kujawski Verify that the ATA command READ NATIVE MAX ADDRESS returns the last valid CHS tuple for the native device rather than any limit established by INITIALIZE DEVICE PARAMETERS. Signed-off-by: Lev Kujawski Message-ID: <20221010085229.2431276-2-lku...@mailbox.org> Signed-off-by:

[PULL 03/19] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-30 Thread Thomas Huth
From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. So make kvm_s390_get_host_cpu_model() return boolean and check the returned boolean in get_max_cpu_model() instead of accessing @err. Signed-off-by: Zhao Liu Reviewed-by:

[PULL 10/19] stubs: Add missing qga stubs

2024-04-30 Thread Thomas Huth
From: Konstantin Kostiuk Compilation QGA without system and user fails ./configure --disable-system --disable-user --enable-guest-agent Link failure: /usr/bin/ld: libqemuutil.a.p/util_main-loop.c.o: in function `os_host_main_loop_wait': ../util/main-loop.c:303: undefined reference to

[PULL 04/19] target/s390x/cpu_models: Drop local @err in get_max_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-6-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.c | 4 +--- 1 file changed, 1

RE: [PATCH v3 08/16] aspeed/smc: support 64 bits dma dram address

2024-04-30 Thread Jamin Lin
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Tuesday, April 30, 2024 3:26 PM > To: Jamin Lin ; Peter Maydell > ; Andrew Jeffery ; > Joel Stanley ; Alistair Francis ; > Cleber > Rosa ; Philippe Mathieu-Daudé ; > Wainer dos Santos Moschetta ; Beraldo Leal > ; open

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-04-30 Thread Philippe Mathieu-Daudé
(Cc'ing migration maintainers) On 30/4/24 03:23, Song Gao wrote: vmstate does not save kvm_state_conter, which can cause VM recovery from disk to fail. Cc: qemu-sta...@nongnu.org Fixes: d11681c94f ("target/loongarch: Implement kvm_arch_init_vcpu") Signed-off-by: Song Gao ---

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.40, Philippe Mathieu-Daudé wrote: Hi Thomas, On 30/4/24 08:45, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213 for a

RE: [PATCH v3 08/19] backends/iommufd: Introduce helper function iommufd_backend_get_device_info()

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 08/19] backends/iommufd: Introduce helper >function iommufd_backend_get_device_info() > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> Introduce a helper function iommufd_backend_get_device_info() to get >> host IOMMU

Re: [PATCH v4 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-04-30 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Split vhost_user_blk_sync_config() out from > vhost_user_blk_handle_config_change(), to be reused in the following > commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/block/vhost-user-blk.c | 26 +++--- > 1 file

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Philippe Mathieu-Daudé
On 30/4/24 10:22, Thomas Huth wrote: On 30/04/2024 10.19, David Hildenbrand wrote: On 30.04.24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp

Re: [PULL 6/6] iotests: add backup-discard-source

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 30.04.24 12:13, Kevin Wolf wrote: Am 29.04.2024 um 20:39 hat Vladimir Sementsov-Ogievskiy geschrieben: [Add John] On 29.04.24 17:18, Richard Henderson wrote: On 4/29/24 04:51, Vladimir Sementsov-Ogievskiy wrote: Add test for a new backup option: discard-source. Signed-off-by: Vladimir

RE: [PATCH v3 07/19] vfio/container: Implement HostIOMMUDeviceClass::realize() handler

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 07/19] vfio/container: Implement >HostIOMMUDeviceClass::realize() handler > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> Utilize range_get_last_bit() to get host IOMMU address width and >> package it in

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Cédric Le Goater
On 4/30/24 11:45, Daniel P. Berrangé wrote: On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213

RE: [PATCH v3 11/19] backends/iommufd: Implement HostIOMMUDeviceClass::check_cap() handler

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 11/19] backends/iommufd: Implement >HostIOMMUDeviceClass::check_cap() handler > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> Suggested-by: Cédric Le Goater >> Signed-off-by: Zhenzhong Duan >> --- >>

[PATCH] target/sh4: Fix ADDV opcode

2024-04-30 Thread Philippe Mathieu-Daudé
The documentation says: ADDV Rm, RnRn + Rm -> Rn, overflow -> T But QEMU implementation was: ADDV Rm, RnRn + Rm -> Rm, overflow -> T Fix by filling the correct Rm register. Cc: qemu-sta...@nongnu.org Fixes: ad8d25a11f ("target-sh4: implement addv and subv using TCG")

Re: [PATCH v5 3/5] migration: process_incoming_migration_co(): fix reporting s->error

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 29.04.24 22:32, Peter Xu wrote: On Mon, Apr 29, 2024 at 10:14:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to use-after-free crash. Let's avoid it. Signed-off-by: Vladimir

RE: [PATCH v3 07/16] aspeed/smc: fix dma moving incorrect data length issue

2024-04-30 Thread Jamin Lin
Hi Cedric, > On 4/19/24 15:41, Cédric Le Goater wrote: > > On 4/16/24 11:18, Jamin Lin wrote: > >> DMA length is from 1 byte to 32MB for AST2600 and AST10x0 and DMA > >> length is from 4 bytes to 32MB for AST2500. > >> > >> In other words, if "R_DMA_LEN" is 0, it should move at least 1 byte > >>

Re: [PATCH v3 05/19] backends/host_iommu_device: Introduce HostIOMMUDeviceCaps

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: HostIOMMUDeviceCaps's elements map to the host IOMMU's capabilities. Different platform IOMMU can support different elements. Currently only two elements, type and aw_bits, type hints the host platform IOMMU type, i.e., INTEL vtd, ARM smmu, etc; aw_bits

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Philippe Mathieu-Daudé
Hi Thomas, On 30/4/24 08:45, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely cannot be fixed without breaking live

Re: [PATCH v3 08/19] backends/iommufd: Introduce helper function iommufd_backend_get_device_info()

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: Introduce a helper function iommufd_backend_get_device_info() to get host IOMMU related information through iommufd uAPI. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- include/sysemu/iommufd.h | 4

Re: [PATCH v4 2/2] target/s390x: flag te and cte as deprecated

2024-04-30 Thread David Hildenbrand
On 29.04.24 21:10, Collin Walling wrote: Add the CONSTRAINT_TRANSACTIONAL_EXE (cte) and TRANSACTIONAL_EXE (te) to the list of deprecated features. Signed-off-by: Collin Walling --- target/s390x/cpu_features.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/s390x/cpu_features.c

[PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely cannot be fixed without breaking live migration with old machine types, or

[PULL 02/19] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-3-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.c | 4

[PULL 08/19] hw: misc: edu: rename local vars in edu_check_range

2024-04-30 Thread Thomas Huth
From: Chris Friedt This serves to make the local variables a bit less ambiguous. The latter two arguments are named to match DMA_START, and DMA_SIZE. Signed-off-by: Chris Friedt Message-ID: <20221018122551.94567-2-cfri...@meta.com> Signed-off-by: Thomas Huth --- hw/misc/edu.c | 16

Re: [PATCH v5 4/5] migration: process_incoming_migration_co(): rework error reporting

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 29.04.24 22:39, Peter Xu wrote: On Mon, Apr 29, 2024 at 10:14:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: Unify error reporting in the function. This simplifies the following commit, which will not-exit-on-error behavior variant to the function. Signed-off-by: Vladimir

Re: [PATCH 04/41] target/sparc: Fix FMUL8x16A{U,L}

2024-04-30 Thread Mark Cave-Ayland
On 02/03/2024 05:15, Richard Henderson wrote: These instructions have f32 inputs, which changes the decode of the register numbers. While we're fixing things, use a common helper for both insns, extracting the 16-bit scalar in tcg beforehand. Signed-off-by: Richard Henderson ---

Re: [PATCH 0/5] hw/loongarch: Refine numa memory map

2024-04-30 Thread gaosong
Hi, 在 2024/3/18 下午4:01, Bibo Mao 写道: One LoongArch virt machine platform, there is limitation for memory map information. The minimum memory size is 256M and minimum memory size for numa node0 is 256M also. With qemu numa qtest, it is possible that memory size of numa node0 is 128M.

Re: [PULL 6/6] iotests: add backup-discard-source

2024-04-30 Thread Kevin Wolf
Am 29.04.2024 um 20:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > [Add John] > > On 29.04.24 17:18, Richard Henderson wrote: > > On 4/29/24 04:51, Vladimir Sementsov-Ogievskiy wrote: > > > Add test for a new backup option: discard-source. > > > > > > Signed-off-by: Vladimir

Re: [PATCH] MAINTAINERS: Update my email address

2024-04-30 Thread Philippe Mathieu-Daudé
On 29/4/24 17:49, Anthony PERARD wrote: From: Anthony PERARD Signed-off-by: Anthony PERARD --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, patch queued.

[PATCH] iotests/pylintrc: allow up to 10 similar lines

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
We want to have similar QMP objects in different tests. Reworking these objects to make common parts by calling some helper functions doesn't seem good. It's a lot more comfortable to see the whole QAPI request in one place. So, let's increase the limit, to unblock further commit "iotests: add

RE: [PATCH v3 02/19] vfio/container: Introduce HostIOMMUDeviceLegacyVFIO device

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 02/19] vfio/container: Introduce >HostIOMMUDeviceLegacyVFIO device > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> HostIOMMUDeviceLegacyVFIO represents a host IOMMU device under >VFIO >> legacy container backend. >> >> It

Re: QEMU Community Call Agenda Items (April 30th, 2024)

2024-04-30 Thread Peter Maydell
On Tue, 30 Apr 2024 at 08:36, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > * /machine to get the rtc-time property value > > This is an alias to the RTC device's "rtc-time" property. Only some > machines define it. Useful because the actual property depends on > machine type

RE: [PATCH v3 05/19] backends/host_iommu_device: Introduce HostIOMMUDeviceCaps

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 05/19] backends/host_iommu_device: Introduce >HostIOMMUDeviceCaps > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> HostIOMMUDeviceCaps's elements map to the host IOMMU's capabilities. >> Different platform IOMMU can

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > Old machine types often have bugs or work-arounds that affect our > possibilities to move forward with the QEMU code base (see for example > https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely > cannot be fixed

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.55, Daniel P. Berrangé wrote: On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213

Re: [PATCH 3/6] hw/acpi: Generic Port Affinity Structure support

2024-04-30 Thread Jonathan Cameron via
On Tue, 30 Apr 2024 08:55:12 +0200 Markus Armbruster wrote: > Jonathan Cameron writes: > > > On Tue, 23 Apr 2024 12:56:21 +0200 > > Markus Armbruster wrote: > > > >> Jonathan Cameron writes: > >> > >> > These are very similar to the recently added Generic Initiators > >> > but instead

[PATCH RESEND] virtio-net: fix bug 1451 aka "assert(!virtio_net_get_subqueue(nc)->async_tx.elem); "

2024-04-30 Thread Alexey Dobriyan
Reproducer from https://gitlab.com/qemu-project/qemu/-/issues/1451 creates small packet (1 segment, len = 10 == n->guest_hdr_len), then destroys queue. "if (n->host_hdr_len != n->guest_hdr_len)" is triggered, if body creates zero length/zero segment packet as there is nothing after guest header.

[PULL 05/19] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

2024-04-30 Thread Thomas Huth
From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. So make kvm_s390_apply_cpu_model() return boolean and check the returned boolean in apply_cpu_model() instead of accessing @err. Signed-off-by: Zhao Liu Reviewed-by: Thomas

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-30 Thread Markus Armbruster
Peter Xu writes: > On Mon, Apr 29, 2024 at 08:08:10AM -0500, Michael Galaxy wrote: >> Hi All (and Peter), > > Hi, Michael, > >> >> My name is Michael Galaxy (formerly Hines). Yes, I changed my last name >> (highly irregular for a male) and yes, that's my real last name: >>

[PULL 13/19] build-environment: make some packages optional

2024-04-30 Thread Thomas Huth
From: Alex Bennée Upgrading the s390x runner exposed some packages are not available for it. Add an additional optional stage we only enable for arm64/x86_64 for now. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID: <20240426153938.1707723-2-alex.ben...@linaro.org>

[PULL 15/19] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-30 Thread Thomas Huth
From: Alex Bennée The libssh bug references 18.04 which we are no longer running. We don't need to disable glusterfs because a linux-user build shouldn't be trying to link to it anyway. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID:

[PULL 09/19] hw: misc: edu: use qemu_log_mask instead of hw_error

2024-04-30 Thread Thomas Huth
From: Chris Friedt Log a guest error instead of a hardware error when the guest tries to DMA to / from an invalid address. Signed-off-by: Chris Friedt Message-ID: <20221018122551.94567-3-cfri...@meta.com> [thuth: Add missing #include statement, fix error reported by checkpatch.pl]

[PULL 11/19] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-30 Thread Thomas Huth
According to the comment in qga/meson.build, the test got disabled since there were problems with the fuzzing job. But instead of disabling this test completely, we should still be fine running it when fuzzing is disabled. Message-ID: <20240426162348.684143-1-th...@redhat.com> Reviewed-by:

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 09:15:03AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Apr 29, 2024 at 08:08:10AM -0500, Michael Galaxy wrote: > >> Hi All (and Peter), > > > > Hi, Michael, > > > >> > >> My name is Michael Galaxy (formerly Hines). Yes, I changed my last name > >>

Re: [PATCH v4 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 30.04.24 11:15, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/block/vhost-user-blk.c | 26

[PATCH v6 1/5] migration: move trace-point from migrate_fd_error to migrate_set_error

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
Cover more cases by trace-point. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/migration.c | 4 +++- migration/trace-events | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c

[PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
Now we do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's provide a possibility for QMP-based orchestrators to get an error like with outgoing migration. For hmp_migrate_incoming(), let's enable the new behavior: HMP is not

[PATCH v6 0/5] migration: do not exit on incoming failure

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
Hi all! The series brings an option to not immediately exit on incoming migration failure, giving a possibility to orchestrator to get the error through QAPI and shutdown QEMU by "quit". v6: 01,02: add r-b by Peter 03: only fix potential use-after-free 04: rework error handling, drop r-b v5: -

[PATCH v6 3/5] migration: process_incoming_migration_co(): fix reporting s->error

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to use-after-free crash. Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 2/5] migration: process_incoming_migration_co(): complete cleanup on failure

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
Make call to migration_incoming_state_destroy(), instead of doing only partial of it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/migration.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH v6 4/5] migration: process_incoming_migration_co(): rework error reporting

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
Unify error reporting in the function. This simplifies the following commit, which will not-exit-on-error behavior variant to the function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff

Re: [PATCH] iotests/pylintrc: allow up to 10 similar lines

2024-04-30 Thread Philippe Mathieu-Daudé
On 30/4/24 11:13, Vladimir Sementsov-Ogievskiy wrote: We want to have similar QMP objects in different tests. Reworking these objects to make common parts by calling some helper functions doesn't seem good. It's a lot more comfortable to see the whole QAPI request in one place. So, let's

Re: [PATCH v6 4/5] migration: process_incoming_migration_co(): rework error reporting

2024-04-30 Thread Philippe Mathieu-Daudé
On 30/4/24 10:56, Vladimir Sementsov-Ogievskiy wrote: Unify error reporting in the function. This simplifies the following commit, which will not-exit-on-error behavior variant to the function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 23 +--

RE: [PATCH v3 04/19] vfio/iommufd: Introduce HostIOMMUDeviceIOMMUFDVFIO device

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 04/19] vfio/iommufd: Introduce >HostIOMMUDeviceIOMMUFDVFIO device > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> HostIOMMUDeviceIOMMUFDVFIO represents a host IOMMU device under >VFIO >> iommufd backend. It will be

Re: [PATCH v3 07/19] vfio/container: Implement HostIOMMUDeviceClass::realize() handler

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: Utilize range_get_last_bit() to get host IOMMU address width and package it in HostIOMMUDeviceCaps for query with .check_cap(). Signed-off-by: Zhenzhong Duan --- hw/vfio/container.c | 29 + 1 file changed, 29 insertions(+)

Re: [PATCH v3 13/19] vfio: Create host IOMMU device instance

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: Create host IOMMU device instance in vfio_attach_device() and call .realize() to initialize it further. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/common.c | 18

Re: [PATCH v3 11/19] backends/iommufd: Implement HostIOMMUDeviceClass::check_cap() handler

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- backends/iommufd.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/backends/iommufd.c b/backends/iommufd.c index d61209788a..28faec528e 100644 ---

Re: [PATCH v3 06/19] range: Introduce range_get_last_bit()

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: This helper get the highest 1 bit position of the upper bound. If the range is empty or upper bound is zero, -1 is returned. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- include/qemu/range.h | 11 +++ 1 file changed, 11

Re: [PATCH] WHPX: Add support for device backed memory regions

2024-04-30 Thread Philippe Mathieu-Daudé
(old patch) Cc'ing Paolo, Gerd (and Laszlo for https://edk2.groups.io/g/discuss/topic/83941304) On 30/7/22 10:39, Helge Konetzka wrote: Am 27.07.22 um 20:00 schrieb Aidan Khoury: Due to skipping the mapping of read only device memory, Windows Hypervisor Platform would fail to emulate such

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 11:40:42AM +0200, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 30/4/24 08:45, Thomas Huth wrote: > > Old machine types often have bugs or work-arounds that affect our > > possibilities to move forward with the QEMU code base (see for example > >

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

2024-04-30 Thread Vinayak Kale
On 29/04/24 6:10 pm, Cédric Le Goater wrote: Hello Vinayak, On 3/28/24 10:30, Cédric Le Goater wrote: On 3/27/24 21:52, Alex Williamson wrote: On Wed, 27 Mar 2024 16:11:37 -0400 "Michael S. Tsirkin" wrote: On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote: On Fri, 22 Mar

RE: [PATCH v3 13/19] vfio: Create host IOMMU device instance

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 13/19] vfio: Create host IOMMU device instance > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> Create host IOMMU device instance in vfio_attach_device() and call >> .realize() to initialize it further. >> >> Suggested-by:

Re: [PATCH v4 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-04-30 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 30.04.24 11:15, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Split vhost_user_blk_sync_config() out from >>> vhost_user_blk_handle_config_change(), to be reused in the following >>> commit. >>> >>> Signed-off-by: Vladimir

Re: QEMU Community Call Agenda Items (April 30th, 2024)

2024-04-30 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Apr 29, 2024 at 05:06:36PM +0200, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 29/4/24 00:25, Philippe Mathieu-Daudé wrote: >> > Hi, >> > >> > The KVM/QEMU community call is at: >> > >> >   https://meet.jit.si/kvmcallmeeting >> >   @ >> >   30/4/2024

Re: [PATCH v3 04/19] vfio/iommufd: Introduce HostIOMMUDeviceIOMMUFDVFIO device

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: HostIOMMUDeviceIOMMUFDVFIO represents a host IOMMU device under VFIO iommufd backend. It will be created during VFIO device attaching and passed to vIOMMU. It includes a link to VFIODevice so that we can do VFIO device specific operations, i.e.,

Re: [PATCH v3 02/19] vfio/container: Introduce HostIOMMUDeviceLegacyVFIO device

2024-04-30 Thread Cédric Le Goater
On 4/29/24 08:50, Zhenzhong Duan wrote: HostIOMMUDeviceLegacyVFIO represents a host IOMMU device under VFIO legacy container backend. It includes a link to VFIODevice. I don't see any use of this attribute. May be introduce later when needed. Thanks, C. Suggested-by: Eric Auger

Re: [PATCH 0/5] hw/loongarch: Refine numa memory map

2024-04-30 Thread maobibo
Sure, I will rebase and send the new version. Regards Bibo Mao On 2024/4/30 下午4:15, gaosong wrote: Hi, 在 2024/3/18 下午4:01, Bibo Mao 写道: One LoongArch virt machine platform, there is limitation for memory map information. The minimum memory size is 256M and minimum memory size for numa node0

Re: [PATCH v5 3/5] migration: process_incoming_migration_co(): fix reporting s->error

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 30.04.24 11:09, Vladimir Sementsov-Ogievskiy wrote: On 30.04.24 11:06, Vladimir Sementsov-Ogievskiy wrote: On 29.04.24 22:32, Peter Xu wrote: On Mon, Apr 29, 2024 at 10:14:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: It's bad idea to leave critical section with error object freed, but

Re: QEMU Community Call Agenda Items (April 30th, 2024)

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 10:44:20AM +0100, Peter Maydell wrote: > On Tue, 30 Apr 2024 at 08:36, Markus Armbruster wrote: > > > > Daniel P. Berrangé writes: > > > * /machine to get the rtc-time property value > > > > This is an alias to the RTC device's "rtc-time" property. Only some > >

Re: [PATCH v4 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-30 Thread David Hildenbrand
On 29.04.24 21:10, Collin Walling wrote: Retain a list of deprecated features disjoint from any particular CPU model. A query-cpu-model-expansion reply will now provide a list of properties (i.e. features) that are flagged as deprecated. Example: { "return": { "model": {

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 10:55:38AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > > Old machine types often have bugs or work-arounds that affect our > > possibilities to move forward with the QEMU code base (see for example > >

Re: [PATCH 3/6] hw/acpi: Generic Port Affinity Structure support

2024-04-30 Thread Markus Armbruster
Jonathan Cameron writes: > On Tue, 23 Apr 2024 12:56:21 +0200 > Markus Armbruster wrote: > >> Jonathan Cameron writes: >> >> > These are very similar to the recently added Generic Initiators >> > but instead of representing an initiator of memory traffic they >> > represent an edge point

Re: [PATCH v3 07/16] aspeed/smc: fix dma moving incorrect data length issue

2024-04-30 Thread Cédric Le Goater
On 4/19/24 15:41, Cédric Le Goater wrote: On 4/16/24 11:18, Jamin Lin wrote: DMA length is from 1 byte to 32MB for AST2600 and AST10x0 and DMA length is from 4 bytes to 32MB for AST2500. In other words, if "R_DMA_LEN" is 0, it should move at least 1 byte data for AST2600 and AST10x0 and 4

[PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. Signed-off-by: Thomas Huth --- include/hw/s390x/sclp.h| 2 +- hw/s390x/s390-virtio-ccw.c | 11 +++

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread David Hildenbrand
On 30.04.24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. IIRC, this should not affect migration Reviewed-by: David Hildenbrand

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
On 30/04/2024 10.19, David Hildenbrand wrote: On 30.04.24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. IIRC, this should not

Re: [PATCH v4 3/3] qapi: introduce device-sync-config

2024-04-30 Thread Vladimir Sementsov-Ogievskiy
On 30.04.24 11:19, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not triggered interrupt to the guest or just not available (not supported by

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Peter Maydell
On Tue, 30 Apr 2024 at 07:45, Thomas Huth wrote: > > Old machine types often have bugs or work-arounds that affect our > possibilities to move forward with the QEMU code base (see for example > https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely > cannot be fixed without

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > Old machine types often have bugs or work-arounds that affect our > possibilities to move forward with the QEMU code base (see for example > https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely > cannot be fixed

RE: [PATCH v3 06/19] range: Introduce range_get_last_bit()

2024-04-30 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v3 06/19] range: Introduce range_get_last_bit() > >On 4/29/24 08:50, Zhenzhong Duan wrote: >> This helper get the highest 1 bit position of the upper bound. >> >> If the range is empty or upper bound is zero, -1 is

Re: [PATCH 1/2] accel/tcg: Make TCGCPUOps::cpu_exec_halt return bool for whether to halt

2024-04-30 Thread Philippe Mathieu-Daudé
On 30/4/24 16:00, Peter Maydell wrote: The TCGCPUOps::cpu_exec_halt method is called from cpu_handle_halt() when the CPU is halted, so that a target CPU emulation can do anything target-specific it needs to do. (At the moment we only use this on i386.) The current specification of the method

[PATCH v3 5/6] migration: Remove non-multifd compression

2024-04-30 Thread Fabiano Rosas
The 'compress' migration capability enables the old compression code which has shown issues over the years and is thought to be less stable and tested than the more recent multifd-based compression. The old compression code has been deprecated in 8.2 and now is time to remove it. Deprecation

[PATCH v3 2/6] migration: Remove 'inc' option from migrate command

2024-04-30 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas ---

[PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-30 Thread Fabiano Rosas
The block migration is considered obsolete and has been deprecated in 8.2. Remove the migrate command option that enables it. This only affects the QMP and HMP commands, the feature can still be accessed by setting the migration 'block' capability. The whole feature will be removed in a future

[PATCH v3 6/6] migration: Deprecate fd: for file migration

2024-04-30 Thread Fabiano Rosas
The fd: URI can currently trigger two different types of migration, a TCP migration using sockets and a file migration using a plain file. This is in conflict with the recently introduced (8.2) QMP migrate API that takes structured data as JSON-like format. We cannot keep the same backend for both

[PATCH v3 0/6] migration removals & deprecations

2024-04-30 Thread Fabiano Rosas
since v2: - removed some more stuff which I missed: blk/inc options from hmp-commands.hx the entire ram-compress.h unused declarations from options.h unused compression functions from qemu-file.c - removed must_remove_block_options earlier in the 'blk' patch - added a deprecation

[PATCH v3 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-30 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst

  1   2   3   >