[PATCH] hw/char/serial: Remove unused prog_if compat property

2025-05-01 Thread BALATON Zoltan
This property was added to preserve previous value when this was fixed in version 2.1 but the 2.0 machine using it was already removed leaving this property unused and unnecessary. This was also copy & pasted into diva-gsp where it was probably never used so get rid of this property at last. Fixes

[PATCH 4/8] hw/pci-host/q35: Remove Q35PCIHost::pci_hole64_fix field

2025-05-01 Thread Philippe Mathieu-Daudé
The Q35PCIHost::pci_hole64_fix boolean was only set in the pc_compat_2_10[] array, via the 'x-pci-hole64-fix=off' property. We removed all machines using that array, lets remove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/q35.h | 1 - h

[PATCH 0/8] hw/i386/pc: Remove deprecated 2.10, 2.11 and 2.12 PC machines

2025-05-01 Thread Philippe Mathieu-Daudé
The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can remove them. This series includes the 2.10 to 2.12 machines removal. Philippe Mathieu-Daudé (8): hw/i386/pc: Remove deprecated pc-q3

[PATCH 2/8] hw/i386/pc: Remove pc_compat_2_10[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The pc_compat_2_10[] array was only used by the pc-q35-2.10 and pc-i440fx-2.10 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 7 --- 2 files changed, 10 deletions(-) diff --git a/include/hw/i386/pc.h b/i

[PATCH 6/8] hw/i386/pc: Remove pc_compat_2_11[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The pc_compat_2_11[] array was only used by the pc-q35-2.11 and pc-i440fx-2.11 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 6 -- 2 files changed, 9 deletions(-) diff --git a/include/hw/i386/pc.h b/inc

[PATCH 5/8] hw/i386/pc: Remove deprecated pc-q35-2.11 and pc-i440fx-2.11 machines

2025-05-01 Thread Philippe Mathieu-Daudé
These machines has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") they can now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_

[PATCH 3/8] hw/pci-host/i440fx: Remove I440FXState::pci_hole64_fix field

2025-05-01 Thread Philippe Mathieu-Daudé
The I440FXState::pci_hole64_fix boolean was only set in the pc_compat_2_10[] array, via the 'x-pci-hole64-fix=off' property. We removed all machines using that array, lets remove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 7 ++-

[PATCH 7/8] hw/i386/pc: Remove deprecated pc-q35-2.12 and pc-i440fx-2.12 machines

2025-05-01 Thread Philippe Mathieu-Daudé
These machines has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") they can now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_

[PATCH 8/8] hw/i386/pc: Remove pc_compat_2_12[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The pc_compat_2_12[] array was only used by the pc-q35-2.12 and pc-i440fx-2.12 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 8 2 files changed, 11 deletions(-) diff --git a/include/hw/i386/pc.h b/

[PATCH 1/8] hw/i386/pc: Remove deprecated pc-q35-2.10 and pc-i440fx-2.10 machines

2025-05-01 Thread Philippe Mathieu-Daudé
These machines has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") they can now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_

Re: [PATCH 5/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.10 and 2.11 machine types

2025-05-01 Thread Philippe Mathieu-Daudé
On 15/1/25 08:38, Thomas Huth wrote: They are older than 6 years, so according to our machine support policy, they can be removed now. There was not anything special in the 2.10 machine type, so just remove it together with the 2.11 machine type. The 2.11 machine type switched some configuration

Re: [PATCH 8/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.12 machine type

2025-05-01 Thread Philippe Mathieu-Daudé
On 15/1/25 08:38, Thomas Huth wrote: The s390-ccw-virtio-2.12 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 14 -- 1 file changed, 14 deletions(-) Reviewed-by: Philip

RE: [PATCH v3 5/9] hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A1 SSP SoC

2025-05-01 Thread Steven Lee
Hi Cédric, > -Original Message- > From: Cédric Le Goater > Sent: Wednesday, April 30, 2025 5:46 PM > To: Steven Lee ; Peter Maydell > ; Troy Lee ; Jamin Lin > ; Andrew Jeffery > ; Joel Stanley ; open > list:ASPEED BMCs ; open list:All patches CC here > > Cc: Troy Lee ; long...@lenovo.com

[PATCH] docs: Don't define duplicate label in qemu-block-drivers.rst.inc

2025-05-01 Thread Peter Maydell
Sphinx requires that labels within documents are unique across the whole manual. This is because the "create a hyperlink" directive specifies only the name of the label, not a filename+label. Some Sphinx versions will warn about duplicate labels, but even if there is no warning there is still an

RE: [PATCH 0/5] Add support for user creatable SMMUv3 device

2025-05-01 Thread Shameerali Kolothum Thodi via
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Wednesday, April 30, 2025 6:48 PM > To: Donald Dutile ; Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > berra...@redhat.com; nath...@

[PATCH v2] target/riscv: Fix fcvt.s.bf16 NaN box checking

2025-05-01 Thread Anton Blanchard
fcvt.s.bf16 uses the FP16 check_nanbox_h() which returns an FP16 quiet NaN. Add check_nanbox_bf16() which returns a BF16 quiet NaN. Signed-off-by: Anton Blanchard --- target/riscv/fpu_helper.c | 2 +- target/riscv/internals.h | 16 2 files changed, 17 insertions(+), 1 deletion

Re: Functional tests precache behaviour

2025-05-01 Thread Peter Maydell
On Wed, 30 Apr 2025 at 17:41, Daniel P. Berrangé wrote: > FWIW, if you want to run a specific test, personally don't use meson > or make, as you can just invoke the file directly: > > $ QEMU_TEST_QEMU_BINARY=./build/qemu-system-x86_64 \ >PYTHONPATH=./python \ >./tests/functional/test_x86_

Re: Re [PATCH v3 08/11] mirror: Skip writing zeroes when target is already zero

2025-05-01 Thread Eric Blake
On Thu, May 01, 2025 at 12:38:30AM +0800, Sunny Zhu wrote: > on Thu 24 Apr 2025 19:52:08 -0500, Eric wrote: > > if (s->zero_target) { > > +int64_t bitmap_length = DIV_ROUND_UP(s->bdev_length, > > s->granularity); > > + > > offset = 0; > > bdrv_graph_co_rdlock(); > >

Re: [PATCH v3 10/11] tests: Add iotest mirror-sparse for recent patches

2025-05-01 Thread Eric Blake
On Thu, May 01, 2025 at 01:34:19PM -0400, Stefan Hajnoczi wrote: > On Thu, Apr 24, 2025 at 07:52:10PM -0500, Eric Blake wrote: > > +TEST_IMG="$TEST_IMG.base" _make_test_img 20M > > +$QEMU_IO -c 'w 8M 2M' -f $IMGFMT "$TEST_IMG.base" | _filter_qemu_io > > + > > +_launch_qemu -machine q35 \ > > Does

Re: [PATCH v3 30/33] target/arm/ptw: remove TARGET_AARCH64 from arm_casq_ptw

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 424d1b54275..f428c9b9267 100644 --- a/target/arm/ptw.c +++ b/target/arm/pt

madvise(MADV_DONTDUMP)

2025-05-01 Thread Jon Wilson
Hi, I'm a first time contributor to QEMU. I am using qemu-user for fuzzing using LibAFL and as part of that including support for address sanitizer (https://github.com/google/sanitizers/wiki/addresssanitizeralgorithm). In essence, this requires that my process running in QEMU requires very lar

Re: OSUOSL in trouble

2025-05-01 Thread Paolo Bonzini
Il gio 1 mag 2025, 17:51 Daniel P. Berrangé ha scritto: > > Paolo, please let me know how I can help with migrating VMs or setting > up a > > CI Kubernetes cluster on Amazon. > Since in the past Camilla did it but I am not sure if she has bandwidth, let's run it with Red Hat first. All I did was

Re: [PATCH v3 33/33] target/arm/kvm-stub: compile file once (system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 32/33] target/arm/meson: accelerator files are not needed in user mode

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 31/33] target/arm/ptw: compile file once (system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 13/33] target/arm/helper: use i64 for exception_pc_alignment

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -49,7 +49,7 @@ DEF_HELPER_3(exception_with_syndrome, noreturn, env, i32, i32) DEF_HELPER_4(exception_with_syndrome_el, noreturn, env, i32, i32, i32) DEF_HELPER_2(exception_bkpt_insn, noreturn, env

Re: OSUOSL in trouble

2025-05-01 Thread Daniel P . Berrangé
On Thu, May 01, 2025 at 06:20:50PM +0200, Paolo Bonzini wrote: > Il gio 1 mag 2025, 17:51 Daniel P. Berrangé ha > scritto: > > > > Paolo, please let me know how I can help with migrating VMs or setting > > up a > > > CI Kubernetes cluster on Amazon. > > > > Since in the past Camilla did it but I

Re: [PATCH v7 0/6] Report vfio-ap configuration changes

2025-05-01 Thread Cédric Le Goater
On 4/30/25 22:55, Rorie Reyes wrote: On 4/28/25 5:29 PM, Cédric Le Goater wrote: On 4/25/25 07:23, Rorie Reyes wrote: Changelog: v7: - Dropped initial commit for linux-header file vfio.h since I created two new commits to address the changes made in v6 - Moved patches 6 and 7 to the beginning

[PATCH] Support madvise(MADV_DONTDUMP) when creating core dumps for qemu-user

2025-05-01 Thread WorksButNotTested
--- include/exec/page-protection.h | 6 ++ linux-user/elfload.c | 4 linux-user/mmap.c | 5 + 3 files changed, 15 insertions(+) diff --git a/include/exec/page-protection.h b/include/exec/page-protection.h index c43231af8b..f8826d917e 100644 --- a/include/exec/p

Re: [PATCH v3 15/33] target/arm/helper: extract common helpers

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/helper.h | 1152 +- target/arm/tcg/helper.h | 1153 +++ 2 files changed, 1155 insertions(+), 1150 deletions(-) create mode 100

Re: [PATCH v3 16/33] target/arm/debug_helper: only include common helpers

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Avoid pulling helper.h which contains TARGET_AARCH64. Signed-off-by: Pierrick Bouvier --- target/arm/debug_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 473

[PATCH] scripts/vmstate-static-checker.py: Add new hpet entry for num_timers

2025-05-01 Thread Peter Xu
The old "num_timers" got a rename. See commit 1433e38cc8 ("hpet: do not overwrite properties on post_load") for more details. Teach the script to accept the new name. Cc: Paolo Bonzini Cc: Thomas Huth Signed-off-by: Peter Xu --- scripts/vmstate-static-checker.py | 1 + 1 file changed, 1 inse

Re: [PATCH v3 20/33] target/arm/helper: replace target_ulong by vaddr

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 085c1656027..595d9334977 100644 --- a/target/arm/helper.c +++ b/target/arm/help

Re: [PATCH v3 18/33] target/arm/debug_helper: compile file twice (user, system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 21/33] target/arm/helper: expose aarch64 cpu registration

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: associated define_arm_cp_regs are guarded by "cpu_isar_feature(aa64_*)", so it's safe to expose that code for arm target (32 bit). Signed-off-by: Pierrick Bouvier --- target/arm/helper.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Richa

Re: [PATCH v3 22/33] target/arm/helper: remove remaining TARGET_AARCH64

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: They were hiding aarch64_sve_narrow_vq and aarch64_sve_change_el, which we can expose safely. Signed-off-by: Pierrick Bouvier --- target/arm/helper.c | 8 1 file changed, 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 23/33] target/arm/helper: compile file twice (user, system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 19/33] target/arm/helper: restrict include to common helpers

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 257b1ba5270..085c1656027 100644 --- a/target/arm/helper.c +++ b/target/arm/h

Re: [PATCH v3 25/33] target/arm/arch_dump: remove TARGET_AARCH64 conditionals

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Associated code is protected by cpu_isar_feature(aa64*) Signed-off-by: Pierrick Bouvier --- target/arm/arch_dump.c | 6 -- 1 file changed, 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 26/33] target/arm/arch_dump: compile file once (system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 24/33] target/arm/vfp_fpscr: compile file twice (user, system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 27/33] target/arm/arm-powerctl: compile file once (system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 17/33] target/arm/debug_helper: remove target_ulong

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/debug_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 357bc2141ae..50ef5618f51 100644 --- a/target/arm/debug_helper

Re: [PATCH v3 28/33] target/arm/cortex-regs: compile file once (system)

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 29/33] target/arm/ptw: replace target_ulong with uint64_t

2025-05-01 Thread Richard Henderson
On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index d0a53d0987f..424d1b54275 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -16

Re: [PATCH v3 15/33] target/arm/helper: extract common helpers

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 8:06 AM, Richard Henderson wrote: On 4/30/25 23:23, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/helper.h | 1152 +- target/arm/tcg/helper.h | 1153 +++ 2 files changed, 1155 in

[PATCH v3 27/33] target/arm/arm-powerctl: compile file once (system)

2025-05-01 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index 95a2b077dd6..7db573f4a97 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -15,7 +15,6 @@ arm_ss.a

Re: [PULL 0/1] Block patches

2025-05-01 Thread Peter Maydell
On Wed, 30 Apr 2025 at 20:05, Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any > user-visible changes. We're into 10.1 now so you should update your email template :-) I have created https://wiki.qemu.org/ChangeLog/10.1

Re: [PATCH v2 3/7] hw/core/cpu-common: Don't init gdbstub until cpu_exec_realizefn()

2025-05-01 Thread Alex Bennée
Peter Maydell writes: > Currently we call gdb_init_cpu() in cpu_common_initfn(), which is > very early in the CPU object's init->realize creation sequence. In > particular this happens before the architecture-specific subclass's > init fn has even run. This means that gdb_init_cpu() can only do

Re: [PATCH] target/arm: Don't assert() for ISB/SB inside IT block

2025-05-01 Thread Richard Henderson
On 5/1/25 05:55, Peter Maydell wrote: (NB: the TCG optimizer doesn't optimize out the jump-to-next, but we can't really avoid emitting it because we don't know at the point we're emitting the handling for the condexec check whether this insn is going to happen to be a nop for us or not.) Heh.

Re: [PATCH 4/4] tests/functional: Test with scripts/vmstate-static-checker.py

2025-05-01 Thread Peter Xu
On Wed, Apr 30, 2025 at 09:10:30AM -0700, Pierrick Bouvier wrote: > On 4/29/25 8:21 AM, Thomas Huth wrote: > > From: Thomas Huth > > > > We've got this nice vmstate-static-checker.py script that can help > > to detect screw-ups in the migration states. Unfortunately, it's > > currently only run m

[PATCH v2 02/16] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field

2025-05-01 Thread Philippe Mathieu-Daudé
The PCMachineClass::legacy_cpu_hotplug boolean was only used by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got removed. Remove it and simplify build_dsdt(), removing build_legacy_cpu_hotplug_aml() altogether. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/acpi/cpu_hotplug.h | 3 -

[PATCH v3 1/1] hw/nvme: CMIC.MCTRS should be set automatically for multi-controller subsystems or by parameter

2025-05-01 Thread Alan Adamson
If there are multiple controllers in a subsystem, CMIC.MCTRS should be set to on for all controllers. For single controller subsystems, CMIC.MCTRS will be off by default. A new subsystem specific parameter will allow setting CMIC.MCTRS for single controller subsystems. New NVMe Subsystem QEMU Para

[PATCH v2 00/16] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-05-01 Thread Philippe Mathieu-Daudé
(repost since v1 was incomplete) The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can remove them. This series only includes the 2.6 and 2.7 machines removal, as it is a big enough number

[PATCH v2 04/16] hw/i386/pc: Remove pc_compat_2_6[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The pc_compat_2_6[] array was only used by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 8 2 files changed, 11 deletions(-) diff --git a/include/hw/i386/pc.h b/inc

[PATCH v2 01/16] hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines

2025-05-01 Thread Philippe Mathieu-Daudé
These machines has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") they can now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_

[PATCH v2 12/16] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field

2025-05-01 Thread Philippe Mathieu-Daudé
The IntelIOMMUState::buggy_eim boolean was only set in the hw_compat_2_7[] array, via the 'x-buggy-eim=true' property. We removed all machines using that array, lets remove that property, simplifying vtd_decide_config(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/intel_iommu.h | 1

[PATCH v2 15/16] hw/char/virtio-serial: Do not expose the 'emergency-write' property

2025-05-01 Thread Philippe Mathieu-Daudé
The VIRTIO_CONSOLE_F_EMERG_WRITE feature bit was only set in the hw_compat_2_7[] array, via the 'emergency-write=off' property. We removed all machines using that array, lets remove that property. All instances have this feature bit set and it can not be disabled. Signed-off-by: Philippe Mathieu-D

[PATCH v2 11/16] hw/core/machine: Remove hw_compat_2_7[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The hw_compat_2_7[] array was only used by the pc-q35-2.7 and pc-i440fx-2.7 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 3 --- hw/core/machine.c | 9 - 2 files changed, 12 deletions(-) diff --git a/include/hw/boards.h b/inclu

[PATCH v2 07/16] hw/virtio/virtio-mmio: Remove VirtIOMMIOProxy::format_transport_address field

2025-05-01 Thread Philippe Mathieu-Daudé
The VirtIOMMIOProxy::format_transport_address boolean was only set in the hw_compat_2_6[] array, via the 'format_transport_address=off' property. We removed all machines using that array, lets remove that property, simplifying virtio_mmio_bus_get_dev_path(). Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 13/16] hw/intc/ioapic: Remove IOAPICCommonState::version field

2025-05-01 Thread Philippe Mathieu-Daudé
The IOAPICCommonState::version integer was only set in the hw_compat_2_7[] array, via the 'version=0x11' property. We removed all machines using that array, lets remove that property, simplify by only using the default version (defined as IOAPIC_VER_DEF). Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 16/16] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_PAGE_PER_VQ definition

2025-05-01 Thread Philippe Mathieu-Daudé
VIRTIO_PCI_FLAG_PAGE_PER_VQ was only used by the hw_compat_2_7[] array, via the 'page-per-vq=on' property. We removed all machines using that array, lets remove all the code around VIRTIO_PCI_FLAG_PAGE_PER_VQ (see commit 9a4c0e220d8 for similar VIRTIO_PCI_FLAG_* enum removal). Signed-off-by: Phili

[PATCH v3 0/1] hw/nvme: CMIC.MCTRS should be set automatically for multi-controller subsystems or by parameter

2025-05-01 Thread Alan Adamson
v3: - Sync up with v10.0 v2: - Change the parameter name from "cmic" to "cmic-mctrs". - If there is more than 1 controller in a subsystem, set CMIC.MCTRS for each controller whether or not the cmic-mctrs parameter is set. While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Lin

[PATCH 2/3] hw/pci-host/designware: Fix viewport configuration

2025-05-01 Thread Bernhard Beschow
Commit 6970f91ac781, "hw/pci-host/designware: Use deposit/extract API" accidentally introduced a copy-and-paste error, causing Linux 6.14 to hang when initializing the PCIe bridge on the imx8mp-evk machine. This fix corrects the error. Fixes: 6970f91ac781 ("hw/pci-host/designware: Use deposit/extr

[PATCH 3/3] hw/gpio/imx_gpio: Fix interpretation of GDIR polarity

2025-05-01 Thread Bernhard Beschow
According to the i.MX 8M Plus reference manual, a GPIO pin is configured as an output when the corresponding bit in the GDIR register is set. The function imx_gpio_set_int_line() is intended to be a no-op if the pin is configured as an output, returning early in such cases. However, it inverts the

[PATCH 0/3] i.MX fixes

2025-05-01 Thread Bernhard Beschow
This series contains two bug fixes related to i.MX SoCs, plus one cosmetic change. The first fix adresses a bug in the Designware PCIe bridge that just got introduced in the 10.1 development cycle, the other one fixes a bug in the i.MX GPIO controller which existed since its introduction. Bernhard

[PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci-host/designware

[PATCH v2 03/16] hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field

2025-05-01 Thread Philippe Mathieu-Daudé
The X86MachineClass::fwcfg_dma_enabled boolean was only used by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got removed. Remove it and simplify. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/x86.h | 2 -- hw/i386/microvm.c | 3 --- hw/i386/multiboot.c | 7 +-- hw/i386/

[PATCH v2 05/16] hw/intc/apic: Remove APICCommonState::legacy_instance_id field

2025-05-01 Thread Philippe Mathieu-Daudé
The APICCommonState::legacy_instance_id boolean was only set in the pc_compat_2_6[] array, via the 'legacy-instance-id=on' property. We removed all machines using that array, lets remove that property, simplifying apic_common_realize(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/a

[PATCH v2 06/16] hw/core/machine: Remove hw_compat_2_6[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The hw_compat_2_6[] array was only used by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 3 --- hw/core/machine.c | 8 2 files changed, 11 deletions(-) diff --git a/include/hw/boards.h b/includ

[PATCH v2 08/16] hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines

2025-05-01 Thread Philippe Mathieu-Daudé
These machines has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") they can now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_

[PATCH v2 14/16] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field

2025-05-01 Thread Philippe Mathieu-Daudé
The VirtIOPCIProxy::ignore_backend_features boolean was only set in the hw_compat_2_7[] array, via the 'x-ignore-backend-features=on' property. We removed all machines using that array, lets remove that property, simplify by only using the default version. Signed-off-by: Philippe Mathieu-Daudé --

[PATCH v2 09/16] hw/i386/pc: Remove pc_compat_2_7[] array

2025-05-01 Thread Philippe Mathieu-Daudé
The pc_compat_2_7[] array was only used by the pc-q35-2.7 and pc-i440fx-2.7 machines, which got removed. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 10 -- 2 files changed, 13 deletions(-) diff --git a/include/hw/i386/pc.h b

[PATCH v2 10/16] hw/audio/pcspk: Remove PCSpkState::migrate field

2025-05-01 Thread Philippe Mathieu-Daudé
The PCSpkState::migrate boolean was only set in the pc_compat_2_7[] array, via the 'migrate=off' property. We removed all machines using that array, lets remove that property, simplifying vmstate_spk[]. Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/pcspk.c | 10 -- 1 file changed, 1

Re: [PATCH 2/3] hw/pci-host/designware: Fix viewport configuration

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 20:34, Bernhard Beschow wrote: Commit 6970f91ac781, "hw/pci-host/designware: Use deposit/extract API" accidentally introduced a copy-and-paste error, causing Linux 6.14 to hang when initializing the PCIe bridge on the imx8mp-evk machine. This fix corrects the error. Fixes: 6970f91ac781

Re: [PATCH 03/11] accel/tcg: Use target_long_bits() in cputlb.c

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH 04/11] accel/tcg: Use vaddr for plugin_{load,store}_cb

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Avoid the use of abi_ptr within ldst_common.c.inc. Signed-off-by: Richard Henderson --- accel/tcg/ldst_common.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH 07/11] include/user: Use vaddr in guest-host.h

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Replace abi_ptr and abi_ulong with vaddr. Signed-off-by: Richard Henderson --- include/user/guest-host.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH 05/11] accel/tcg: Build cputlb.c once

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c| 3 ++- accel/tcg/meson.build | 5 + 2 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH 11/11] accel/tcg: Build user-exec.c once

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 5 ++--- accel/tcg/meson.build | 5 + 2 files changed, 3 insertions(+), 7 deletions(-) Yeah! Reviewed-by: Pierrick Bouvier

Re: [PATCH 06/11] include/user: Convert GUEST_ADDR_MAX to a variable

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Remove GUEST_ADDR_MAX and add guest_addr_max. Initialize it in *-user/main.c, after reserved_va. Signed-off-by: Richard Henderson --- include/user/guest-host.h | 27 +++ accel/tcg/user-exec.c | 4 ++-- bsd-user/main.c

Re: [PATCH 08/11] accel/tcg: Move TARGET_TAGGED_ADDRESSES to TCGCPUOps.untagged_addr

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 7 +++ include/user/guest-host.h | 8 +--- target/arm/cpu-param.h | 7 +-- target/arm/cpu.h| 32 +--- target/arm/cpu.

Re: [PATCH 09/11] accel/tcg: Remove TARGET_PAGE_DATA_SIZE

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: This macro is used by only one target, and even then under unusual conditions -- AArch64 with mmap's PROT_MTE flag. Since page size for aarch64-linux-user is variable, the per-page data size is also variable. Since page_reset_target_data via target_mun

Re: [PATCH 10/11] accel/tcg: Avoid abi_ptr in user-exec.c

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: In page_dump/dump_region, use guest_addr_max to check the size of the guest address space and size the output appropriately. This will change output with small values of -R reserved_va, but shouldn't affect anything else. Signed-off-by: Richard Hender

Re: [PATCH 00/11] accel/tcg: Finish building once

2025-05-01 Thread Pierrick Bouvier
On 5/1/25 7:55 AM, Richard Henderson wrote: Based-on: 20250430230631.2571291-1-richard.hender...@linaro.org ("[PATCH 0/6] accel/tcg: Build translate-all, tcg-all twice") Adjust the final two files in accel/tcg/ to build once. Congrats! r~ Richard Henderson (11): accel/tcg: Move user-o

[PULL v2 3/8] block: refactor error handling of commit_iteration

2025-05-01 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer Signed-off-by: Vincent Vanlaer Message-Id: <20241026163010.2865002-4-libvirt-e6954...@volkihar.be> [vsementsov]: move action declaration to the top of the function Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 63

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-01 Thread Anthony Krowiak
On 4/30/25 3:39 PM, John Levon wrote: Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Reviewed-by

Re: [PATCH v6 0/1] Optimizing the print format of the QEMU monitor 'info mtree'

2025-05-01 Thread BALATON Zoltan
On Thu, 1 May 2025, Philippe Mathieu-Daudé wrote: Hi Chao, On 1/5/25 04:24, Chao Liu wrote: Hi, all: Thanks to BALATON, and David for their reviews. In PATCH v6: 1. Replaced the bool type with enum mtree_node_type to improve code readability. 2. Modified the output to use only one horizonta

Re: [PATCH] docs: Don't define duplicate label in qemu-block-drivers.rst.inc

2025-05-01 Thread Eric Blake
On Thu, May 01, 2025 at 10:31:26AM +0100, Peter Maydell wrote: > Sphinx requires that labels within documents are unique across the > whole manual. This is because the "create a hyperlink" directive > specifies only the name of the label, not a filename+label. Some > Sphinx versions will warn abo

Re: [PATCH v3 03/11] block: Let bdrv_co_is_zero_fast consolidate adjacent extents

2025-05-01 Thread Stefan Hajnoczi
On Thu, Apr 24, 2025 at 07:52:03PM -0500, Eric Blake wrote: > Some BDS drivers have a cap on how much block status they can supply > in one query (for example, NBD talking to an older server cannot > inspect more than 4G per query; and qcow2 tends to cap its answers > rather than cross a cluster bo

Re: [PATCH 04/11] accel/tcg: Use vaddr for plugin_{load,store}_cb

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 16:55, Richard Henderson wrote: Avoid the use of abi_ptr within ldst_common.c.inc. Signed-off-by: Richard Henderson --- accel/tcg/ldst_common.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 02/11] accel/tcg: Move tlb_vaddr_to_host declaration to probe.h

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 16:55, Richard Henderson wrote: This is a probing function, not a load/store function. TIL. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/accel/tcg/cpu-ldst.h | 16 include/accel/tcg/probe.h| 16 2 file

Re: [PATCH v3 04/11] block: Add new bdrv_co_is_all_zeroes() function

2025-05-01 Thread Stefan Hajnoczi
On Thu, Apr 24, 2025 at 07:52:04PM -0500, Eric Blake wrote: > There are some optimizations that require knowing if an image starts > out as reading all zeroes, such as making blockdev-mirror faster by > skipping the copying of source zeroes to the destination. The > existing bdrv_co_is_zero_fast()

Re: [PATCH 05/11] accel/tcg: Build cputlb.c once

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 16:55, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c| 3 ++- accel/tcg/meson.build | 5 + 2 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé :)

Re: [PATCH v6 0/1] Optimizing the print format of the QEMU monitor 'info mtree'

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 15:49, BALATON Zoltan wrote: On Thu, 1 May 2025, Philippe Mathieu-Daudé wrote: Hi Chao, On 1/5/25 04:24, Chao Liu wrote: Hi, all: Thanks to BALATON, and David for their reviews. In PATCH v6: 1. Replaced the bool type with enum mtree_node_type to improve code readability. 2. Modifi

Re: [PATCH v3 07/11] mirror: Skip pre-zeroing destination if it is already zero

2025-05-01 Thread Eric Blake
On Thu, May 01, 2025 at 12:09:26AM +0800, Sunny Zhu wrote: > > When doing a sync=full mirroring, QMP drive-mirror requests full > > zeroing if it did not just create the destination, and blockdev-mirror > > requests full zeroing unconditionally. This is because during a full > > sync, we must ensu

Re: [PATCH v3 10/11] tests: Add iotest mirror-sparse for recent patches

2025-05-01 Thread Stefan Hajnoczi
On Thu, Apr 24, 2025 at 07:52:10PM -0500, Eric Blake wrote: > +TEST_IMG="$TEST_IMG.base" _make_test_img 20M > +$QEMU_IO -c 'w 8M 2M' -f $IMGFMT "$TEST_IMG.base" | _filter_qemu_io > + > +_launch_qemu -machine q35 \ Does the machine type matter? This test would be more portable without q35. signat

Re: OSUOSL in trouble

2025-05-01 Thread Stefan Hajnoczi
On Thu, May 1, 2025 at 12:31 PM Daniel P. Berrangé wrote: > > On Thu, May 01, 2025 at 06:20:50PM +0200, Paolo Bonzini wrote: > > Il gio 1 mag 2025, 17:51 Daniel P. Berrangé ha > > scritto: > > > > > > Paolo, please let me know how I can help with migrating VMs or setting > > > up a > > > > CI Kub

[PULL v2 0/8] block-job patches 2025-04-29

2025-05-01 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit 73d29ea2417b58ca55fba1aa468ba38e3607b583: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-04-27 12:47:23 -0400) are available in the Git repository at: https://gitlab.com/vsementsov/qemu.git tags/pull-block-jobs-2025-04-29-v2

Re: [PATCH 2/6] accel/tcg: Don't use TARGET_LONG_BITS in decode_sleb128

2025-05-01 Thread Pierrick Bouvier
On 4/30/25 4:06 PM, Richard Henderson wrote: When we changed decode_sleb128 from target_long to int64_t, we failed to adjust the shift limit. Cc: qemu-sta...@nongnu.org Fixes: c9ad8d27caa ("tcg: Widen gen_insn_data to uint64_t") Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c |

  1   2   3   4   >