[Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-19 Thread identifier scorpio
Hello. I ported TCG to alpha platform, the patch is currently based on stable-0.10 branch, and now it can run linux-0.2.img testing image on my alpha XP1000 workstation. but it still can't run MS-windows, and I hope someone, especially those guys that are working on target-alpha, may help me

Re: [Qemu-devel] [PATCH] Documentation: Add missing documentation for qdev related command line options

2010-01-19 Thread Markus Armbruster
Stefan Weil w...@mail.berlios.de writes: Markus Armbruster schrieb: Stefan Weil w...@mail.berlios.de writes: The command line options -device, -nodefaults, -readconfig, -writeconfig had entries for command line help, but documentation for texi and derived formats (man, html, info) was

[Qemu-devel] Stop using which in ./configure

2010-01-19 Thread Loïc Minier
Hi Following the thread on the sdl-config patch, please find attached a patch to add a couple of portable shell functions which allow testing whehter a command/builtin is available and to find the full pathname of an executable in the PATH. This also replaces all uses of which in

Re: [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:31PM +0100, Kevin Wolf wrote: Don't assume -EIO but return the real error. While I'm not very found of assignment inside of if statements the patch looks correct, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote: Return the appropriate error value instead of always using EIO. Don't free the L1 table on errors, we still need it. Signed-off-by: Kevin Wolf kw...@redhat.com Looks good correct, but shouldn't we free the clusters for the new l1

Re: [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:28PM +0100, Kevin Wolf wrote: Don't assume success but pass the bdrv_pwrite return value on. Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 03/10] qcow2: Return 0/-errno in get_cluster_table

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:29PM +0100, Kevin Wolf wrote: Switching to 0/-errno allows it to distinguish different error cases. Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-19 Thread Kevin Wolf
Am 19.01.2010 11:58, schrieb Christoph Hellwig: On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote: Return the appropriate error value instead of always using EIO. Don't free the L1 table on errors, we still need it. Signed-off-by: Kevin Wolf kw...@redhat.com Looks good correct,

Re: [Qemu-devel] Stop using which in ./configure

2010-01-19 Thread Loïc Minier
On Tue, Jan 19, 2010, Laurent Vivier wrote: Why don't you use type -P for path_of ? I don't think that's portable enough: $ sh -c 'type -P ls' -P: not found ls is /bin/ls -- Loïc Minier

Re: [Qemu-devel] Stop using which in ./configure

2010-01-19 Thread Loïc Minier
On Tue, Jan 19, 2010, Loïc Minier wrote: Following the thread on the sdl-config patch, please find attached a patch to add a couple of portable shell functions which allow testing whehter a command/builtin is available and to find the full pathname of an executable in the PATH. This also

Re: [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset

2010-01-19 Thread Kevin Wolf
Am 19.01.2010 12:35, schrieb Christoph Hellwig: @@ -715,6 +721,7 @@ uint64_t qcow2_alloc_cluster_offset(BlockDriverState *bs, cluster_offset = ~QCOW_OFLAG_COPIED; m-nb_clusters = 0; +m-depends_on = NULL; What does this have to do with the rest? It's needed to

Re: [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset

2010-01-19 Thread Christoph Hellwig
On Tue, Jan 19, 2010 at 12:57:35PM +0100, Kevin Wolf wrote: It's needed to be able to distinguish between the case where the clusters are already allocated (0/NULL) and the case where the request depends on another one (0/non-NULL). This check previously used the return value (cluster_offset

[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Juan Quintela
Kirill A. Shutemov kir...@shutemov.name wrote: A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Hi Have you updated this series? Is there any reason that you know when they haven't been picked? I am also interested in getting

[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Kirill A. Shutemov
On Tue, Jan 19, 2010 at 2:11 PM, Juan Quintela quint...@redhat.com wrote: Kirill A. Shutemov kir...@shutemov.name wrote: A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Hi Have you updated this series?  Is there any reason that you

Re: [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset

2010-01-19 Thread Christoph Hellwig
@@ -715,6 +721,7 @@ uint64_t qcow2_alloc_cluster_offset(BlockDriverState *bs, cluster_offset = ~QCOW_OFLAG_COPIED; m-nb_clusters = 0; +m-depends_on = NULL; What does this have to do with the rest? Otherwise looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH] Documentation: Add missing documentation for qdev related command line options

2010-01-19 Thread Michael S. Tsirkin
On Mon, Jan 18, 2010 at 08:32:25PM +0100, Stefan Weil wrote: Markus Armbruster schrieb: Stefan Weil w...@mail.berlios.de writes: The command line options -device, -nodefaults, -readconfig, -writeconfig had entries for command line help, but documentation for texi and derived formats

Re: [Qemu-devel] [PATCH] Fix missing symbols in .rela.plt sections

2010-01-19 Thread Loïc Minier
On Sun, Jan 17, 2010, Loïc Minier wrote: Static builds of qemu on x86-64 (and probably i386) fail After actually checking in an i386 Ubuntu lucid chroot, I found out that ld uses .rel.plt and .rel.iplt instead of .rela.plt and .rela.iplt. I've applied the same fixes to the two .ld scripts

RE: [Qemu-devel] Stop using which in ./configure

2010-01-19 Thread Krumme, Chris
Hello Laurent, Good or bad type -P skips the aliases. Thanks Chris -Original Message- From: qemu-devel-bounces+chris.krumme=windriver@nongnu.org [mailto:qemu-devel-bounces+chris.krumme=windriver@nongnu.o rg] On Behalf Of Laurent Vivier Sent: Tuesday, January 19, 2010

Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Anthony Liguori
On 01/14/2010 09:34 AM, Amit Shah wrote: On (Thu) Jan 14 2010 [08:34:42], Anthony Liguori wrote: On 01/14/2010 07:17 AM, Amit Shah wrote: Hello people, This iteration of the series removes the START and END flags (and hence the header associated with each buffer). That's the major

[Qemu-devel] Fwd: Some encountered issues when compiling openbios on a ppc64 host

2010-01-19 Thread Zhiyong Wu
HI, Blue Swirl Can you give me a help about the issues below? Thanks ahead. Cheers, Zhiyong Wu -- Forwarded message -- From: Zhiyong Wu zwu.ker...@gmail.com Date: Tue, Jan 19, 2010 at 6:27 PM Subject: Some encountered issues when compiling openbios on a ppc64 host To:

[Qemu-devel] KVM developer call minutes (Jan 19)

2010-01-19 Thread Chris Wright
Minutes (please reply w/ corrections or follow-ups): how is stable branch working (both qemu and kvm)? - qemu 0.12 cherry picking pretty aggressively - could use more community involvement - any distro patches for qemu/kvm packages? - doesn't sound like it vhost-net command line syntax

[Qemu-devel] [ANNOUNCE] Release 0.12.2 of QEMU

2010-01-19 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.12.2 release. This is a stable release of the 0.12 series and only contains bug fixes since 0.12.1. It can be downloaded from Savannah at: http://download.savannah.gnu.org/releases/qemu/qemu-0.12.2.tar.gz On behalf of the QEMU

Re: [Qemu-devel] Stop using which in ./configure

2010-01-19 Thread Stefan Weil
Loïc Minier schrieb: On Tue, Jan 19, 2010, Loïc Minier wrote: Following the thread on the sdl-config patch, please find attached a patch to add a couple of portable shell functions which allow testing whehter a command/builtin is available and to find the full pathname of an

[Qemu-devel] [PULL] eepro100 patches

2010-01-19 Thread Michael S. Tsirkin
The following changes since commit 1c39457adf220f9011cc6e08c05b272073ec3126: Blue Swirl (1): Sparc32: Update OpenBIOS image to r666 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Stefan Weil (2): eepro100:

[Qemu-devel] Re: Stop using which in ./configure

2010-01-19 Thread Måns Rullgård
Laurent Vivier laur...@vivier.eu writes: Hi Following the thread on the sdl-config patch, please find attached a patch to add a couple of portable shell functions which allow testing whehter a command/builtin is available and to find the full pathname of an executable in the PATH.

[Qemu-devel] Re: Stop using which in ./configure

2010-01-19 Thread Måns Rullgård
Loïc Minier l...@dooz.org writes: On Tue, Jan 19, 2010, Loïc Minier wrote: Following the thread on the sdl-config patch, please find attached a patch to add a couple of portable shell functions which allow testing whehter a command/builtin is available and to find the full pathname of an

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v2

2010-01-19 Thread Blue Swirl
On Mon, Jan 18, 2010 at 10:28 PM, Igor V. Kovalenko igor.v.kovale...@gmail.com wrote: From: Igor V. Kovalenko igor.v.kovale...@gmail.com sparc64 timer has tick counter which can be set and read, and tick compare value used as deadline to fire timer interrupt. The timer is not used as periodic

Re: [Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Blue Swirl
On Tue, Jan 19, 2010 at 12:17 PM, Kirill A. Shutemov kir...@shutemov.name wrote: On Tue, Jan 19, 2010 at 2:11 PM, Juan Quintela quint...@redhat.com wrote: Kirill A. Shutemov kir...@shutemov.name wrote: A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov

Re: [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:33PM +0100, Kevin Wolf wrote: If update_refcount fails, try to undo any changes made so far to avoid inconsistencies in the image file. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-refcount.c | 32 +--- 1 files

Re: [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts

2010-01-19 Thread Christoph Hellwig
#endif -if (length = 0) +if (length 0) { return -EINVAL; +} + start = offset ~(s-cluster_size - 1); last = (offset + length - 1) ~(s-cluster_size - 1); for(cluster_offset = start; cluster_offset = last; So for legnth = 0, last will equal start and

Re: [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value

2010-01-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters return value

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote: @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size) /* write new table (align to cluster) */ new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2); +if (new_l1_table_offset 0) { +

Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Amit Shah
On (Tue) Jan 19 2010 [17:59:33], Jamie Lokier wrote: What happens if the guest crashes, kexecs or whatever when it's half way through sending a cut buffer? A stream protocol will not have a nice way to recover from that unless there is an additional out of band way to say I'm starting

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Amit Shah
Hello all, In this series I've removed the buffering that happened in the host and ack the amount of data that ports actually consume. This basically removes the older patch 5/8 that introduced buffering and throttling. Other changes include addition of patch 8: MSI support and ensuring we don't

[Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max

2010-01-19 Thread Amit Shah
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in hw/virtio.h. Also, bump up the value of the maximum allowed virtqueues to 64. This is in preparation to allow multiple ports per virtio-console device. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio.c |2 --

[Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state

2010-01-19 Thread Amit Shah
Via control channel messages, the guest can tell us whether a port got opened or closed. Similarly, we can also indicate to the guest of host port open/close events. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 94

[Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests

2010-01-19 Thread Amit Shah
The port 'id' or number is internal state between the guest kernel and our bus implementation. This is invocation-dependent and isn't part of the guest-host ABI. To correcly enumerate and map ports between the host and the guest, the 'name' property is used. Example: -device

[Qemu-devel] [PATCH 6/8] virtio-serial: Add a 'virtserialport' device for generic serial port support

2010-01-19 Thread Amit Shah
This commit adds a simple chardev-based serial port. Any data the guest sends is forwarded to the chardev and vice-versa. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clipboard

[Qemu-devel] [PATCH 7/8] Move virtio-serial to Makefile.objs

2010-01-19 Thread Amit Shah
There's nothing target-dependent in the virtio-serial code so allow it to be compiled just once for all the targets. Signed-off-by: Amit Shah amit.s...@redhat.com --- Makefile.objs |2 +- Makefile.target |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 8/8] virtio-serial: Use MSI vectors for port virtqueues

2010-01-19 Thread Amit Shah
This commit enables the use of MSI interrupts for virtqueue notifications for ports. We use nr_ports + 1 (for control channel) msi entries for the ports, as only the in_vq operations need an interrupt on the guest. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-pci.c |4 1

[Qemu-devel] Re: sparc32 do_unassigned_access overhaul

2010-01-19 Thread Blue Swirl
On Tue, Jan 19, 2010 at 5:30 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/1/15 Artyom Tarasenko atar4q...@googlemail.com: 2010/1/15 Blue Swirl blauwir...@gmail.com: On Fri, Jan 15, 2010 at 9:11 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/1/15 Blue Swirl

Re: [Qemu-devel] [PATCH] [For stable-0.12] Sync OSS_GETVERSION handling with head

2010-01-19 Thread Anthony Liguori
On 01/17/2010 11:23 AM, Juergen Lock wrote: As suggested by Andreas Färber, here is a cumulative patch that syncs OSS_GETVERSION handling with head by merging the following commits: 1. oss: issue OSS_GETVERSION ioctl only when needed 6d246526ce3c145b2831285def6983f5de6190d3 2. oss: fix

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Anthony Liguori
On 01/18/2010 10:45 AM, john cooper wrote: This is a rework of the prior version which adds definitions for contemporary processors selected via -cpumodel, as an alternative to the existing use of -cpu qemu64 augmented with a series of feature flags. The primary motivation was determination of

Re: [Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Anthony Liguori
On 01/19/2010 06:17 AM, Kirill A. Shutemov wrote: On Tue, Jan 19, 2010 at 2:11 PM, Juan Quintelaquint...@redhat.com wrote: Kirill A. Shutemovkir...@shutemov.name wrote: A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemovkir...@shutemov.name

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've encountered, -cpu Nehalem is just as obscure as -cpu qemu64,-sse3,+vmx,... What name will these users

Re: [Qemu-devel] [PATCH 4/5] PCI: do_pci_info(): PCI bridge support

2010-01-19 Thread Luiz Capitulino
On Mon, 18 Jan 2010 18:14:32 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit adds the pci_bridge key to the PCI device QDict, it also adds support for printing it in the user protocol. IMPORTANT: This code is being added

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-19 Thread Richard Henderson
On 01/19/2010 12:47 AM, identifier scorpio wrote: I ported TCG to alpha platform, the patch is currently based on stable-0.10 branch, and now it can run linux-0.2.img testing image on my alpha XP1000 workstation. but it still can't run MS-windows, and I hope someone, especially those guys that

Re: [Qemu-devel] [PATCH 3/5] PCI: Convert pci_info() to QObject

2010-01-19 Thread Luiz Capitulino
On Mon, 18 Jan 2010 18:16:21 +0100 Markus Armbruster arm...@redhat.com wrote: +static QObject *pci_get_dev_class(const PCIDevice *dev) +{ +int class; +const char *str = ; +const pci_class_desc *desc; + +class = pci_get_word(dev-config + PCI_CLASS_DEVICE); desc

[Qemu-devel] PATCH 3/2] block: kill BDRV_O_CREAT

2010-01-19 Thread Christoph Hellwig
The BDRV_O_CREAT option is unused inside qemu and partially duplicates the bdrv_create method. Remove it, and the -C option to qemu-io which isn't used in qemu-iotests anyway. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c

[Qemu-devel] Re: KVM developer call minutes (Jan 19)

2010-01-19 Thread Dustin Kirkland
On Wed, Jan 20, 2010 at 6:31 AM, Chris Wright chr...@redhat.com wrote: how is stable branch working (both qemu and kvm)? - qemu 0.12 cherry picking pretty aggressively  - could use more community involvement  - any distro patches for qemu/kvm packages?    - doesn't sound like it I'm

[Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-19 Thread Christoph Hellwig
If we go over the maximum number of iovecs support by syscall we get back EINVAL from the kernel which translate to I/O errors for the guest. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c === --- qemu.orig/block.c

Re: [Qemu-devel] [PATCH] [For stable-0.12] Sync OSS_GETVERSION handling with head

2010-01-19 Thread malc
On Tue, 19 Jan 2010, Anthony Liguori wrote: On 01/17/2010 11:23 AM, Juergen Lock wrote: As suggested by Andreas F?rber, here is a cumulative patch that syncs OSS_GETVERSION handling with head by merging the following commits: 1. oss: issue OSS_GETVERSION ioctl only when needed

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-19 Thread malc
On Tue, 19 Jan 2010, Richard Henderson wrote: On 01/19/2010 12:47 AM, identifier scorpio wrote: I ported TCG to alpha platform, the patch is currently based on stable-0.10 branch, and now it can run linux-0.2.img testing image on my alpha XP1000 workstation. but it still can't run

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

2010-01-19 Thread Stefan Weil
identifier scorpio schrieb: Hello. I ported TCG to alpha platform, the patch is currently based on stable-0.10 branch, and now it can run linux-0.2.img testing image on my alpha XP1000 workstation. but it still can't run MS-windows, and I hope someone, especially those guys that are

[Qemu-devel] Re: sparc32 do_unassigned_access overhaul

2010-01-19 Thread Artyom Tarasenko
2010/1/19 Blue Swirl blauwir...@gmail.com: On Tue, Jan 19, 2010 at 5:30 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/1/15 Artyom Tarasenko atar4q...@googlemail.com: 2010/1/15 Blue Swirl blauwir...@gmail.com: On Fri, Jan 15, 2010 at 9:11 PM, Artyom Tarasenko

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Jamie Lokier
Anthony Liguori wrote: On 01/18/2010 10:45 AM, john cooper wrote: x86 Conroe Intel Celeron_4x0 (Conroe/Merom Class Core 2) x86 Penryn Intel Core 2 Duo P9xxx (Penryn Class Core 2) x86 Nehalem Intel Core i7 9xx (Nehalem Class Core i7) x86

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Jamie Lokier
Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've encountered, -cpu Nehalem is just as obscure as -cpu qemu64,-sse3,+vmx,...

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Jamie Lokier
john cooper wrote: As before a cpu feature 'check' option is added which warns when feature flags (either implicit in a cpu model or explicit on the command line) would have otherwise been quietly unavailable to a guest: # qemu-system-x86_64 ... -cpu Nehalem,check warning: host

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Chris Wright
* Jamie Lokier (ja...@shareable.org) wrote: Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've encountered, -cpu Nehalem is just

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v2

2010-01-19 Thread Igor Kovalenko
On Tue, Jan 19, 2010 at 9:44 PM, Blue Swirl blauwir...@gmail.com wrote: On Mon, Jan 18, 2010 at 10:28 PM, Igor V. Kovalenko igor.v.kovale...@gmail.com wrote: From: Igor V. Kovalenko igor.v.kovale...@gmail.com sparc64 timer has tick counter which can be set and read, and tick compare value

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Anthony Liguori
On 01/19/2010 02:03 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've encountered, -cpu Nehalem is just as obscure as -cpu

[Qemu-devel] [PATCH] sparc64: reimplement tick timers v3

2010-01-19 Thread Igor V. Kovalenko
From: Igor V. Kovalenko igor.v.kovale...@gmail.com sparc64 timer has tick counter which can be set and read, and tick compare value used as deadline to fire timer interrupt. The timer is not used as periodic timer, instead deadline is set each time new timer interrupt is needed. v2 - v3: - added

[Qemu-devel] Re: [PULL] eepro100 patches

2010-01-19 Thread Anthony Liguori
On 01/19/2010 11:42 AM, Michael S. Tsirkin wrote: The following changes since commit 1c39457adf220f9011cc6e08c05b272073ec3126: Blue Swirl (1): Sparc32: Update OpenBIOS image to r666 are available in the git repository at:

Re: [Qemu-devel] [PATCH] rtl8139: fix clang reporting unused assignment of VLAN tagging data

2010-01-19 Thread Anthony Liguori
On 01/13/2010 04:53 PM, Igor V. Kovalenko wrote: From: Igor V. Kovalenkoigor.v.kovale...@gmail.com Currently we do not implement VLAN tagging for rtl8139(C+), still data is read from ring buffer headers. - augment unused assignment with TODO item - cast txdw1 to void for now Signed-off-by:

Re: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call.

2010-01-19 Thread Anthony Liguori
On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote: qemu_chr_open_fd() calls qemu_chr_generic_open(), so qemu_chr_open_tty() doesn't need to call it. Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp Applied. Thanks. Regards, Anthony Liguori --- qemu-char.c |1 - 1 files

Re: [Qemu-devel] [PATCH v4] raw-posix: Detect legacy floppy via ioctl on linux

2010-01-19 Thread Anthony Liguori
On 01/14/2010 10:19 AM, Cole Robinson wrote: Current legacy floppy detection is hardcoded based on source file name. Make this smarter on linux by attempting a floppy specific ioctl. v2: Give ioctl check higher priority than filename check s/IDE/legacy/ v3: Actually initialize

Re: [Qemu-devel] [PATCH 1/8] VNC: Use 'enabled' key instead of 'status'

2010-01-19 Thread Anthony Liguori
On 01/14/2010 10:50 AM, Luiz Capitulino wrote: Currently the 'status' key is a string whose value can be disabled or enabled, change it to the QMP's standard 'enabled' key, which is a bool. Note that 'status' in being dropped and this wouldn't be allowed if QMP were stable. Signed-off-by: Luiz

Re: [Qemu-devel] [PATCH 1/3] remove dead code from target-i386/exec.h

2010-01-19 Thread Anthony Liguori
On 01/15/2010 01:56 AM, Paolo Bonzini wrote: These are unused since edea5f0 (no need to define global registers in cpu-exec.c, 2008-05-10). Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- target-i386/exec.h | 48

Re: [Qemu-devel] [PATCH] avoid unreachable statement after break

2010-01-19 Thread Anthony Liguori
On 01/15/2010 02:41 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- cpu-exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 44d45fc..d974141 100644 ---

Re: [Qemu-devel] [PATCH 1/4] clean up env-current_tb

2010-01-19 Thread Anthony Liguori
On 01/15/2010 02:42 AM, Paolo Bonzini wrote: There are three paths from the innermost while loop of cpu_exec to the top of the outermost for loop. Two do not reset env-current_tb. Fix this. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT

2010-01-19 Thread Anthony Liguori
On 01/15/2010 05:56 AM, Kevin Wolf wrote: Since commit 747bbdf7 QEMU_WARN_UNUSED_RESULT is never defined as it is conditional on a define from config-host.h which is included only later. Include that file earlier to get the warnings back. Reactivating it unfortunately leads to some warnings

Re: [Qemu-devel] [PATCH] QMP: Emit asynchronous events on all QMP monitors

2010-01-19 Thread Anthony Liguori
On 01/15/2010 08:34 AM, Adam Litke wrote: When using a control/QMP monitor in tandem with a regular monitor, asynchronous messages can get lost depending on the order of the QEMU program arguments. QEMU events issued by monitor_protocol_event() always go to cur_mon. If the user monitor was

[Qemu-devel] [PATCH 00/17] Fix compilation with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
Hi This series is a work on top of Kirill previous patches. Changes are: - I addressed all reviewers comments - Improved some error messages - Check that it is valid to return -errno (switched lots of places to just return -1). - check correctly system() result for errors. -

[Qemu-devel] [PATCH 01/17] Introduce qemu_write_full()

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Signed-off-by: Juan Quintela quint...@redhat.com --- osdep.c | 27 +++ qemu-common.h |1 + 2 files changed,

[Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full()

2010-01-19 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- qemu-common.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index a8144cb..f009796 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -160,7 +160,8 @@ void

[Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCposix-aio-compat.o cc1: warnings being treated as errors posix-aio-compat.c: In function 'aio_signal_handler': posix-aio-compat.c:505: error: ignoring return value of 'write', declared with attribute warn_unused_result make: ***

[Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCblock/cow.o cc1: warnings being treated as errors block/cow.c: In function 'cow_create': block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result block/cow.c:253: error: ignoring return value of

[Qemu-devel] [PATCH 05/17] block/qcow.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCblock/qcow.o cc1: warnings being treated as errors block/qcow.c: In function 'qcow_create': block/qcow.c:804: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow.c:806: error: ignoring return value of

[Qemu-devel] [PATCH 06/17] block/vmdk.o: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCblock/vmdk.o cc1: warnings being treated as errors block/vmdk.c: In function 'vmdk_snapshot_create': block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result block/vmdk.c: In function

[Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CC

[Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCnet/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1

[Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCblock/qcow2.o cc1: warnings being treated as errors block/qcow2.c: In function 'qcow_create2': block/qcow2.c:829: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow2.c:838: error: ignoring return

[Qemu-devel] [PATCH 11/17] vl.c: fix warning with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCi386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute

[Qemu-devel] [PATCH 10/17] usb-linux.c: fix warning with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCusb-linux.o cc1: warnings being treated as errors usb-linux.c: In function 'usb_host_read_file': usb-linux.c:1204: error: ignoring return value of 'fgets', declared with attribute warn_unused_result make: *** [usb-linux.o] Error 1

[Qemu-devel] [PATCH 12/17] monitor.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCi386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with

[Qemu-devel] [PATCH 13/17] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name CCi386-linux-user/mmap.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag': /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared

[Qemu-devel] [PATCH 14/17] check pipe() return value

2010-01-19 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/xen_domainbuild.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c index 20d731d..2f59856 100644 --- a/hw/xen_domainbuild.c +++ b/hw/xen_domainbuild.c @@

[Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2

2010-01-19 Thread Juan Quintela
From: Kirill A. Shutemov kir...@shutemov.name _FORTIFY_SOURCE is a Glibc feature which adds memory and string function protection. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Signed-off-by: Juan Quintela quint...@redhat.com --- configure |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all

2010-01-19 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5556b9d..d8af978 100755 --- a/configure +++ b/configure @@ -101,7 +101,7 @@ QEMU_CFLAGS=-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS

[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 01/19/2010 06:17 AM, Kirill A. Shutemov wrote: On Tue, Jan 19, 2010 at 2:11 PM, Juan Quintelaquint...@redhat.com wrote: Kirill A. Shutemovkir...@shutemov.name wrote: A variant of write(2) which handles partial write.

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: On 01/19/2010 02:03 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've

Re: [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full()

2010-01-19 Thread malc
On Wed, 20 Jan 2010, Juan Quintela wrote: From: Kirill A. Shutemov kir...@shutemov.name A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name Signed-off-by: Juan Quintela quint...@redhat.com --- osdep.c | 27

[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Anthony Liguori
On 01/19/2010 06:04 PM, Juan Quintela wrote: Anthony Liguorianth...@codemonkey.ws wrote: On 01/19/2010 06:17 AM, Kirill A. Shutemov wrote: On Tue, Jan 19, 2010 at 2:11 PM, Juan Quintelaquint...@redhat.com wrote: Kirill A. Shutemovkir...@shutemov.name wrote:

Re: [Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2010-01-19 Thread Jamie Lokier
Anthony Liguori wrote: -write(posix_aio_state-wfd,byte, sizeof(byte)); +ret = write(posix_aio_state-wfd,byte, sizeof(byte)); +if (ret 0 errno != EAGAIN) +die(write()); } if write() fails in a pipe in the signal handler, I am at a lost about what

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-19 Thread Jamie Lokier
Anthony Liguori wrote: On 01/19/2010 02:03 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and for most of the users I've encountered, -cpu Nehalem is just as

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

2010-01-19 Thread Jamie Lokier
Michael S. Tsirkin wrote: On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have BDRV_DONT_SNAPSHOT, either. Well, this just mirros the file access macros: we have RDONLY, WRONLY and RDRW. I assume this similarity

Re: [Qemu-devel] [PATCH v2 1/4] Make CDROM a read-only drive

2010-01-19 Thread Jamie Lokier
Naphtali Sprei wrote: } (void)bdrv_set_read_only(dinfo-bdrv, 1); } +/* + * cdrom is read-only. Set it now, after above interface checking + * since readonly attribute not explicitly required, so no error. + */ +if (media == MEDIA_CDROM) { +

[Qemu-devel] Does anybody can explain how qemu do network simulation?

2010-01-19 Thread fan ni
Hi: Does anybody here have read the network simulation code in qemu and have a knowledge of how it works and connected to the host network? And how network tap works in qemu?

[Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Kirill A. Shutemov
On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela quint...@redhat.com wrote: From: Kirill A. Shutemov kir...@shutemov.name CC    block/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate',

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

2010-01-19 Thread Markus Armbruster
Jamie Lokier ja...@shareable.org writes: Michael S. Tsirkin wrote: On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have BDRV_DONT_SNAPSHOT, either. Well, this just mirros the file access macros: we have RDONLY,

  1   2   >