Re: [Qemu-devel] Re: [BUG] Regression: readonly raw images no longer work

2010-02-15 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 02/13/2010 10:40 PM, Stefan Weil wrote: This command used to work, but fails now: $ i386-softmmu/qemu -snapshot /dev/sda qemu: could not open disk image /dev/sda: Permission denied $ ls -l /dev/sda brw-rw-r-- 1 root disk 8, 0 13. Feb 08:55

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-15 Thread Alexander Graf
On 15.02.2010, at 07:12, OHMURA Kei wrote: dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. But We think that dirty-bitmap-traveling by long size is faster than by byte We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Gerd Hoffmann
On 02/12/10 15:23, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. In addition to this,

[Qemu-devel] Re: [PATCH 2/2] net/macvtap: add vhost suppor

2010-02-15 Thread Arnd Bergmann
On Sunday 14 February 2010, Michael S. Tsirkin wrote: @@ -473,7 +477,7 @@ static struct socket *get_socket(int fd) sock = get_raw_socket(fd); if (!IS_ERR(sock)) return sock; - sock = get_tun_socket(fd); + sock = get_tap_socket(fd); if

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote: On 02/12/10 15:23, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should

[Qemu-devel] Re: EHCI support in QEMU

2010-02-15 Thread Jan Kiszka
Taimoor Mirza wrote: Hi all, I downloaded version 0.12.2 of QEMU and I am unable to find EHCI support in it. Does QEMU support EHCI emulation? Do I need to download some other patch for it? QEMU documentation also does not tell anything about EHCI. QEMU does not support USB 2.0 /

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2010 at 02:54:01PM +0530, Amit Shah wrote: On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote: On 02/12/10 15:23, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare

Re: [Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-15 Thread Rob Landley
On Sunday 14 February 2010 08:41:00 Alexander Graf wrote: Am Sun 14 Feb 2010 09:36:27 AM CET schrieb Rob Landley r...@landley.net: On Thursday 11 February 2010 06:32:12 Alexander Graf wrote: Rob Landley wrote: Static binaries that run under the Linux kernel don't run under qemu-ppc. For

Re: [Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-15 Thread Alexander Graf
On 15.02.2010, at 12:10, Rob Landley wrote: On Sunday 14 February 2010 08:41:00 Alexander Graf wrote: Am Sun 14 Feb 2010 09:36:27 AM CET schrieb Rob Landley r...@landley.net: On Thursday 11 February 2010 06:32:12 Alexander Graf wrote: Rob Landley wrote: Static binaries that run under the

[Qemu-devel] Re: qemu-ppc can't run static uClibc binaries.

2010-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2010 at 06:58:33AM -0600, Rob Landley wrote: On Monday 15 February 2010 05:19:24 Alexander Graf wrote: On 15.02.2010, at 12:10, Rob Landley wrote: On Sunday 14 February 2010 08:41:00 Alexander Graf wrote: So the only case I can imagine that this breaks anything is that

Re: [Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-15 Thread Alexander Graf
On 15.02.2010, at 13:58, Rob Landley wrote: On Monday 15 February 2010 05:19:24 Alexander Graf wrote: On 15.02.2010, at 12:10, Rob Landley wrote: On Sunday 14 February 2010 08:41:00 Alexander Graf wrote: So the only case I can imagine that this breaks anything is that uClibc requires

[Qemu-devel] [PATCH 1/3] pc: Bump up pc version to 0.13 and add a 0.12 compat version

2010-02-15 Thread Amit Shah
The version 0.13 will be the new default and compatibility options will be added to the 0.12 version. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/pc.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 6fbe98b..7c9a24e 100644 ---

[Qemu-devel] [PATCH 2/3] pc: Add backward compatibility options for virtio-serial

2010-02-15 Thread Amit Shah
virtio-serial-pci can support multiple ports in the current development version that will become 0.13. Add compatibility options for the 0.12 and 0.11 pc machine types. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/pc.c | 29 + 1 files changed, 29

[Qemu-devel] [PATCH 3/3] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
From: Michael S. Tsirkin m...@redhat.com Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amit Shah

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is

[Qemu-devel] Re: [PATCH 2/3] pc: Add backward compatibility options for virtio-serial

2010-02-15 Thread Gerd Hoffmann
@@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = { static void pc_machine_init(void) { qemu_register_machine(pc_machine); +qemu_register_machine(pc_machine_v0_12); qemu_register_machine(pc_machine_v0_11); qemu_register_machine(pc_machine_v0_10);

[Qemu-devel] Re: [PATCH 2/3] pc: Add backward compatibility options for virtio-serial

2010-02-15 Thread Amit Shah
On (Mon) Feb 15 2010 [15:36:34], Gerd Hoffmann wrote: @@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = { static void pc_machine_init(void) { qemu_register_machine(pc_machine); +qemu_register_machine(pc_machine_v0_12); qemu_register_machine(pc_machine_v0_11);

[Qemu-devel] Re: [PATCH v2 1/3] pc: Bump up pc version to 0.13 and add a 0.12 compat version

2010-02-15 Thread Gerd Hoffmann
On 02/15/10 16:13, Amit Shah wrote: The version 0.13 will be the new default and compatibility options will be added to the 0.12 version. Whole series looks good now. Acked-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote: On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow

[Qemu-devel] [PATCH v2 3/3] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
From: Michael S. Tsirkin m...@redhat.com Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amit Shah

[Qemu-devel] [PATCH v2 1/3] pc: Bump up pc version to 0.13 and add a 0.12 compat version

2010-02-15 Thread Amit Shah
The version 0.13 will be the new default and compatibility options will be added to the 0.12 version. Signed-off-by: Amit Shah amit.s...@redhat.com --- v2: register the 0.12 version in this patch instead of the next one. hw/pc.c | 10 +- 1 files changed, 9 insertions(+), 1

[Qemu-devel] [PATCH] tcg: Add consistency checks for op definitions

2010-02-15 Thread Stefan Weil
When compiled with CONFIG_DEBUG_TCG, this code looks for missing, duplicate and wrong entries in the op definitions. Errors will raise an assertion at program start (all checks are done in the initial phase). The current code contains such errors, at least for i386 guest on i386 host.

[Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

2010-02-15 Thread Kevin Wolf
The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing. Just

[Qemu-devel] [PATCH 1/3] qcow2: Factor next_refcount_table_size out

2010-02-15 Thread Kevin Wolf
When the refcount table grows, it doesn't only grow by one entry but reserves some space for future refcount blocks. The algorithm to calculate the number of entries stays the same with the fixes, so factor it out before replacing the rest. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 3/3] qcow2: More checks for qemu-img check

2010-02-15 Thread Kevin Wolf
Implement some more refcount block related checks Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-refcount.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index e7fdf64..e50fb2a 100644 ---

[Qemu-devel] [PATCH 2/3] qcow2: Rewrite alloc_refcount_block/grow_refcount_table

2010-02-15 Thread Kevin Wolf
The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing. In

[Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-15 Thread Jes Sorensen
Hi, Kevin and I have agreed on the approach for this one now. So here is the latest version of the patch for QEMU, submitting e820 reservation entries via fw_cfg. Cheers, Jes Use qemu-cfg to provide the BIOS with an optional table of e820 entries. Notify the BIOS of the location of the

[Qemu-devel] [PATCH] Seabios e820 reservation portion

2010-02-15 Thread Jes Sorensen
Hi, This is the Seabios part to match my e820 reservation via fw_cfg patch. Cheers, Jes Read optional table of e820 entries from qemu_cfg Read optional table of e820 entries through qemu_cfg, allowing QEMU to provide the location of KVM's switch area etc. rather than rely on hard coded

[Qemu-devel] sparc32 fix spurious dma interrupts v2

2010-02-15 Thread Artyom Tarasenko
Don't raise irq when not enabled. Raise irq on enabling if DMA_INTR is set Don't clear irq unless it was raised by DMA, as there are other irq sources Don't set DMA_INTR bit spuriously. v1-v2: - Don't clear irq unless it was raised by DMA - Raise irq on enabling if DMA_INTR is set - Assume

[Qemu-devel] Re: sparc32 fix spurious dma interrupts v2

2010-02-15 Thread Blue Swirl
Thanks, applied. On Mon, Feb 15, 2010 at 7:39 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise irq when not enabled. Raise irq on enabling if DMA_INTR is set Don't clear irq unless it was raised by DMA, as there are other irq sources Don't set DMA_INTR bit spuriously.

[Qemu-devel] Re: QError conversion problems: putting errors in context

2010-02-15 Thread Markus Armbruster
Anthony Liguori aligu...@linux.vnet.ibm.com writes: Hi Markus, On 02/12/2010 11:48 AM, Markus Armbruster wrote: Our QError conversions were pretty straightforward so far. For example, when we found monitor_printf(mon, device is not removable\n); in eject_device(), we

[Qemu-devel] Re: [PATCH] QEMU e820 reservation patch

2010-02-15 Thread Stefano Stabellini
On Mon, 15 Feb 2010, Jes Sorensen wrote: Hi, Kevin and I have agreed on the approach for this one now. So here is the latest version of the patch for QEMU, submitting e820 reservation entries via fw_cfg. I think the interface is fine and it is perfectly usable by Xen as well. Cheers,

[Qemu-devel] [PATCH 1/7] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-15 Thread Richard Henderson
Removes a set of ifdefs from exec.c. Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other than Alpha. This will be used for page_find_alloc, which is supposed to be using virtual addresses in the first place. --- exec.c | 17 - target-alpha/cpu.h |

[Qemu-devel] [PATCH 3/7] Fix last page errors in page_set_flags and page_check_range.

2010-02-15 Thread Richard Henderson
The addr end comparison prevents the last page from being iterated; an iteration based on length avoids this problem. --- exec.c | 39 +-- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/exec.c b/exec.c index 766568b..1521ce3 100644 ---

[Qemu-devel] [PATCH 7/7] Assert arguments in range for guest address space.

2010-02-15 Thread Richard Henderson
We don't expect host addresses within page_set_flags or page_check_range. --- exec.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index bb712ec..10673fc 100644 --- a/exec.c +++ b/exec.c @@ -2327,6 +2327,14 @@ void

[Qemu-devel] [PATCH 5/7] linux-user: Use h2g_valid in qemu_vmalloc.

2010-02-15 Thread Richard Henderson
--- linux-user/mmap.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 25fc0b2..65fdc33 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -80,16 +80,15 @@ void mmap_unlock(void) void *qemu_vmalloc(size_t size) {

[Qemu-devel] [PATCH 2/7] Use TARGET_VIRT_ADDR_SPACE_BITS in h2g_valid.

2010-02-15 Thread Richard Henderson
Previously, only 32-bit guests had a proper check for the validity of the virtual address. Extend that check to 64-bit guests with a restricted virtual address space. --- cpu-all.h | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/cpu-all.h b/cpu-all.h

[Qemu-devel] [PATCH 0/7] Multi-level page tables and userland mapping fixes, v2

2010-02-15 Thread Richard Henderson
Changes since v1: * Sparc virt and phys address range corrections. * Unrelated changes removed. * Assertions added for guest address space. r~ Richard Henderson (7): Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h. Use TARGET_VIRT_ADDR_SPACE_BITS in h2g_valid. Fix last page

[Qemu-devel] [PATCH 6/7] linux-user: Fix mmap_find_vma returning invalid addresses.

2010-02-15 Thread Richard Henderson
Don't return addresses that aren't properly aligned for the guest, e.g. when the guest has a larger page size than the host. Don't return addresses that are outside the virtual address space for the target, by paying proper attention to the h2g/g2h macros. At the same time, place the default

[Qemu-devel] [PATCH 4/7] Implement multi-level page tables.

2010-02-15 Thread Richard Henderson
Use TARGET_VIRT_ADDR_SPACE_BITS for the virtual memory map based off of l1_map. This rewrites page_find_alloc, page_flush_tb, and walk_memory_regions. Use TARGET_PHYS_ADDR_SPACE_BITS for the physical memory map based off of l1_phys_map. This rewrites page_phys_find_alloc and phys_page_for_each.

Re: [Qemu-devel] Re: [PATCH 2/2] tcg-sparc: Implement setcond, setcond2.

2010-02-15 Thread Richard Henderson
On 02/13/2010 02:01 PM, Blue Swirl wrote: On Tue, Feb 9, 2010 at 11:37 PM, Richard Henderson r...@twiddle.net wrote: --- tcg/sparc/tcg-target.c | 126 1 files changed, 126 insertions(+), 0 deletions(-) Something's wrong with the patch...

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-15 Thread Christoph Hellwig
On Fri, Feb 12, 2010 at 11:28:57AM -0600, Anthony Liguori wrote: Yes. The BSDs tend to not play stupid emulation games in the libc, so changes of these kinds of messups to happen are far less. In all fairness, I seem to recall there being a problem with the kernel implementation of

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-15 Thread Christoph Hellwig
On Fri, Feb 12, 2010 at 06:47:55PM +, Richard W.M. Jones wrote: I don't think there's a good solution for this at the qemu level. However I have a working patch for glibc: https://bugzilla.redhat.com/show_bug.cgi?id=563103#c13 Any chance you could just persuade Uli to drop the

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-15 Thread Richard W.M. Jones
On Mon, Feb 15, 2010 at 11:17:27PM +0100, Christoph Hellwig wrote: On Fri, Feb 12, 2010 at 06:47:55PM +, Richard W.M. Jones wrote: I don't think there's a good solution for this at the qemu level. However I have a working patch for glibc:

Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation.

2010-02-15 Thread Juergen Lock
On Mon, Feb 15, 2010 at 06:15:41AM +0300, malc wrote: On Sun, 14 Feb 2010, Juergen Lock wrote: Submitted by: Andreas Tobler andre...@fgznet.ch Signed-off-by: Juergen Lock n...@jelal.kn-bremen.de --- a/cache-utils.c +++ b/cache-utils.c @@ -57,6 +57,23 @@ } #endif +#if

Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation.

2010-02-15 Thread Juergen Lock
On Mon, Feb 15, 2010 at 06:16:07AM +0300, malc wrote: On Sun, 14 Feb 2010, Juergen Lock wrote: Submitted by: Andreas Tobler andre...@fgznet.ch Signed-off-by: Juergen Lock n...@jelal.kn-bremen.de --- a/cache-utils.c +++ b/cache-utils.c @@ -57,6 +57,23 @@ } #endif +#if

[Qemu-devel] Re: [PATCH 1/2] macvtap: rework object lifetime rules

2010-02-15 Thread Ed Swierk
On Sat, Feb 13, 2010 at 2:33 AM, Arnd Bergmann a...@arndb.de wrote: The original macvtap code has a number of problems resulting from the use of RCU for protecting the access to struct macvtap_queue from open files. This includes - need for GFP_ATOMIC allocations for skbs - potential

[Qemu-devel] Re: [PATCH] Seabios e820 reservation portion

2010-02-15 Thread Kevin O'Connor
On Mon, Feb 15, 2010 at 06:33:59PM +0100, Jes Sorensen wrote: Hi, This is the Seabios part to match my e820 reservation via fw_cfg patch. This still has 'struct e820_entry' which is too similar to 'struct e820entry' in memmap.h. Otherwise, it looks good to me. -Kevin

[Qemu-devel] Re: qemu-ppc can't run static uClibc binaries.

2010-02-15 Thread Rob Landley
On Monday 15 February 2010 07:08:33 Michael S. Tsirkin wrote: On Mon, Feb 15, 2010 at 06:58:33AM -0600, Rob Landley wrote: On Monday 15 February 2010 05:19:24 Alexander Graf wrote: On 15.02.2010, at 12:10, Rob Landley wrote: On Sunday 14 February 2010 08:41:00 Alexander Graf wrote:

Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation.

2010-02-15 Thread malc
On Mon, 15 Feb 2010, Juergen Lock wrote: On Mon, Feb 15, 2010 at 06:16:07AM +0300, malc wrote: On Sun, 14 Feb 2010, Juergen Lock wrote: Submitted by: Andreas Tobler andre...@fgznet.ch Signed-off-by: Juergen Lock n...@jelal.kn-bremen.de --- a/cache-utils.c +++