Re: [Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub

2010-05-10 Thread Stefan Hajnoczi
bdrv_aio_noop_em() could be useful for benchmarking and optimizing the aio code. It serves as a cheap operation that lets us see the cost of the aio roundtrip. Stefan

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-10 Thread Markus Armbruster
Blue Swirl writes: > On 5/9/10, chen huacai wrote: >> This patch add initial support of VIA IDE controller used by fulong mini pc >> >> Signed-off-by: Huacai Chen >> - [...] >> diff --git a/hw/ide/via.c b/hw/ide/via.c >> new file mode 100644 >> index 000..9adc5b5 >> --- /dev/null

[Qemu-devel] Re: vmstate: Useless post_save?

2010-05-10 Thread andrzej zaborowski
Hi, On 8 May 2010 00:39, Jan Kiszka wrote: > I wondered why we have the post_save callback in vmstate. Conceptually, > it made no sense to me. So I grep'ed for its users - and found exactly > one: tmp105. As suspected, only "strange" code was found: > > static void tmp105_post_save(void *opaque)

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread chen huacai
>>  +    s->pci = qemu_mallocz(sizeof(*s->pci)); >>  +    assert(s->pci != NULL); >>  +    bonito_state = s; >>  + >>  +    /* get the north bridge pci bus */ >>  +    s->pci->bus = pci_register_bus(NULL, "pci", pci_bonito_set_irq, >>  +                                   pci_bonito_map_irq, pic, 0x

[Qemu-devel] Re: [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Kevin O'Connor
On Mon, May 10, 2010 at 11:36:37AM +0300, Gleb Natapov wrote: > This patch adds native support for booting from virtio disks to Seabios. > > Signed-off-by: Gleb Natapov Thanks - commit 89acfa3f. The patch had some compile errors on gcc3.4 and gcc4.5 - I went ahead and committed an update to fix

[Qemu-devel] Re: [PATCH 0/6] [AHCI]resend all patches to add ahci support into qemu

2010-05-10 Thread Alexander Graf
On 11.05.2010, at 01:19, QiaoChong wrote: > When ahci init ,driver will send ATA_SRST command,ahci device report device > type through port's sig register. > Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not > support cdrom media. > I just copy ide_atapi_cmd from hw/ide/c

[Qemu-devel] [PATCH 5/6] ahci pci ids into pci_ids.h, add warning messages.

2010-05-10 Thread QiaoChong
move ahci pci device id define into pci_ids.h,add warning messages for unsupported features. Signed-off-by: QiaoChong --- hw/ahci.c| 10 +- hw/pci_ids.h |1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/ahci.c b/hw/ahci.c index cb4a851..e1aed4a 100644 ---

[Qemu-devel] [PATCH 1/6] add ahci support into qemu, only support sata disk.

2010-05-10 Thread QiaoChong
use -drive if=sd,file=diskname to add a ahci disk into qemu. Signed-off-by: QiaoChong --- Makefile.target |4 + hw/ahci.c | 805 +++ 2 files changed, 809 insertions(+), 0 deletions(-) create mode 100644 hw/ahci.c diff --git a/Makef

[Qemu-devel] [PATCH 6/6] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
ahci disk look up from IF_SCSI now. test a sata disk: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk test a sata cd: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso Signe

[Qemu-devel] [PATCH 0/6] [AHCI]resend all patches to add ahci support into qemu

2010-05-10 Thread QiaoChong
When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a little,then the cdrom c

[Qemu-devel] [PATCH 3/6] fix port count, cap and version etc to ahci.

2010-05-10 Thread QiaoChong
From: Sebastian Herbszt - debug output with DEBUG_AHCI - set port count to 4 - change return value of PxSSTS to include SPD and IPM - change cap and version default values according to Intel #301473-002 Signed-off-by: QiaoChong --- hw/ahci.c | 68 -

[Qemu-devel] [PATCH 2/6] add ahci device into i386 pc just for test.

2010-05-10 Thread QiaoChong
test like this: dd if=/dev/zero of=/tmp/disk bs=1M count=100 ./i386-softmmu/qemu -cdrom /mnt/hdb1/knoppix-dvd/KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -boot d -drive if=sd,file=/tmp/disk Signed-off-by: QiaoChong --- default-configs/i386-softmmu.mak |2 ++ hw/pc.c |

[Qemu-devel] [PATCH 4/6] add WIN_STANDBYNOW1 process into ahci.

2010-05-10 Thread QiaoChong
Signed-off-by: QiaoChong --- hw/ahci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ahci.c b/hw/ahci.c index b6a81af..cb4a851 100644 --- a/hw/ahci.c +++ b/hw/ahci.c @@ -676,6 +676,7 @@ static void handle_cmd(AHCIState *s,int port,int slot)

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread Alexander Graf
On 11.05.2010, at 00:13, Sebastian Herbszt wrote: > Alexander Graf wrote: >> Hi Chong, >> >> On 10.05.2010, at 13:55, QiaoChong wrote: >> >> > When ahci init ,driver will send ATA_SRST command,ahci device report >> > device type through port's sig register. >> > Ahci disk lookup change from IF

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 5:59 AM, Avi Kivity wrote: > On 04/21/2010 08:53 PM, Cam Macdonell wrote: >> >> Support an inter-vm shared memory device that maps a shared-memory object >> as a >> PCI device in the guest.  This patch also supports interrupts between >> guest by >> communicating over a uni

[Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-10 Thread Alex Williamson
If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a bogus pointer in the bus devices array that can cause a segfault or garbage data from 'info pci'.

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-05-10 Thread Adam Lackorzynski
Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 0eccca5..afd6716 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -6344,7 +6344,11 @

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread Alexander Graf
On 11.05.2010, at 00:13, Sebastian Herbszt wrote: > Alexander Graf wrote: >> Hi Chong, >> >> On 10.05.2010, at 13:55, QiaoChong wrote: >> >> > When ahci init ,driver will send ATA_SRST command,ahci device report >> > device type through port's sig register. >> > Ahci disk lookup change from IF

[Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-10 Thread Richard Henderson
Computing carry is trivial for some inputs. By avoiding an external function call, we generate near-optimal code for the common cases of add+addx (double-word arithmetic) and cmp+addx (a setcc pattern). Signed-off-by: Richard Henderson --- target-sparc/helper.h|2 +- target-sparc/op_hel

[Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements.

2010-05-10 Thread Richard Henderson
The first patch is required in order to fix TCGv_i32/_i64 type errors. The second patch fixes some mistakes I noticed with ADDX carry generation. The third patch improves code generation for some common cases. With Aurelien's tcg-optimization patches we get nearly optimal code, and it isn't half

[Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug.

2010-05-10 Thread Richard Henderson
Return a target_ulong from compute_C_icc to match the width of the users. Signed-off-by: Richard Henderson --- target-sparc/helper.h|2 +- target-sparc/op_helper.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h inde

[Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-10 Thread Richard Henderson
Use int32 types instead of target_ulong when computing ICC. This simplifies the generated code for 32-bit host and 64-bit guest. Use the same simplified expressions for ICC as were already used for XCC in carry flag generation. ADDX ICC carry generation was using the same routines as ADD ICC, whi

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread Sebastian Herbszt
Alexander Graf wrote: Hi Chong, On 10.05.2010, at 13:55, QiaoChong wrote: > When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. > Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. > I just co

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Anthony Liguori
On 05/10/2010 05:03 PM, Alexander Graf wrote: On 10.05.2010, at 23:59, Anthony Liguori wrote: On 05/10/2010 04:51 PM, Alexander Graf wrote: Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistenc

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Alexander Graf
On 10.05.2010, at 23:59, Anthony Liguori wrote: > On 05/10/2010 04:51 PM, Alexander Graf wrote: >> Thanks to recent improvements, qemu flushes guest data to disk when the guest >> tells us to do so. >> >> This is great if we care about data consistency on host disk failures. In >> cases >> wher

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Anthony Liguori
On 05/10/2010 04:51 PM, Alexander Graf wrote: Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One su

[Qemu-devel] [PATCH] add interface type IF_SATA

2010-05-10 Thread Sebastian Herbszt
Add interface type IF_SATA. Signed-off-by: Sebastian Herbszt diff --git a/sysemu.h b/sysemu.h index fa921df..b88bae9 100644 --- a/sysemu.h +++ b/sysemu.h @@ -151,7 +151,7 @@ extern unsigned int nb_prom_envs; typedef enum { IF_NONE, IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, I

Re: [Qemu-devel] [PATCH] fix migration with large mem

2010-05-10 Thread Anthony Liguori
On 05/10/2010 04:45 PM, Izik Eidus wrote: On Mon, 10 May 2010 15:24:20 -0500 Anthony Liguori wrote: On 04/13/2010 04:33 AM, Izik Eidus wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidus Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PA

[Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub

2010-05-10 Thread Alexander Graf
We need to be able to do nothing in AIO fashion. Since I suspect this could be useful for more cases than the non flushing, I figured I'd create a new function that does everything AIO-like, but doesn't do anything. Signed-off-by: Alexander Graf --- block.c | 18 ++ block.h |

[Qemu-devel] [PATCH 2/2] Add flush=off parameter to -drive

2010-05-10 Thread Alexander Graf
Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive that allows us to set the flushing behavior to "on" or "off", defaulting to enabling the guest to flush. Signed-off-b

[Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Alexander Graf
Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One such use case is the building of appliances in SUS

Re: [Qemu-devel] [PATCH] fix migration with large mem

2010-05-10 Thread Izik Eidus
On Mon, 10 May 2010 15:24:20 -0500 Anthony Liguori wrote: > On 04/13/2010 04:33 AM, Izik Eidus wrote: > > From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 > > 2001 From: Izik Eidus > > Date: Tue, 13 Apr 2010 12:24:57 +0300 > > Subject: [PATCH] fix migration with large mem > > >

[Qemu-devel] Re: [SeaBIOS] [PATCH] smbios: avoid counting io hole as ram

2010-05-10 Thread Alex Williamson
On Mon, 2010-05-10 at 23:05 +0200, Sebastian Herbszt wrote: > Kevin O'Connor wrote: > > On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote: > >> Avoid counting the io hole as part of ram, a vm started with 4G > >> should report 4G in smbios, not 4.5G. > >> > >> Signed-off-by: Alex Wil

[Qemu-devel] Re: [SeaBIOS] [PATCH] smbios: avoid counting io hole as ram

2010-05-10 Thread Sebastian Herbszt
Kevin O'Connor wrote: On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote: Avoid counting the io hole as part of ram, a vm started with 4G should report 4G in smbios, not 4.5G. Signed-off-by: Alex Williamson Looks okay to me. If there are no other comments, I'll commit in the ne

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-10 Thread Blue Swirl
On 5/10/10, Artyom Tarasenko wrote: > 2010/5/10 Blue Swirl : > > > On 5/10/10, Artyom Tarasenko wrote: > >> 2010/5/9 Blue Swirl : > >> > On 5/9/10, Artyom Tarasenko wrote: > >> >> 2010/5/9 Blue Swirl : > >> >> > >> >> > On 5/8/10, Artyom Tarasenko wrote: > >> >> >> On the real hardw

[Qemu-devel] [PATCH 1/2] acpi: remove static pm_state

2010-05-10 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/acpi.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index e3b63b7..bb2974e 100644 --- a/hw/acpi.c +++ b/hw/acpi.c @@ -76,8 +76,6 @@ typedef struct PIIX4PMState { #define SMBHSTDAT1 0x06 #define SMBBLKDAT 0

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-10 Thread Artyom Tarasenko
2010/5/10 Blue Swirl : > On 5/10/10, Artyom Tarasenko wrote: >> 2010/5/9 Blue Swirl : >>  > On 5/9/10, Artyom Tarasenko wrote: >>  >> 2010/5/9 Blue Swirl : >>  >> >>  >> > On 5/8/10, Artyom Tarasenko wrote: >>  >>  >> On the real hardware (SS-5, LX) the MMU is not padded, but aliased. >>  >>  >>

[Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-10 Thread Blue Swirl
Make gpe and pci0_status fields in PIIX4PMState. Signed-off-by: Blue Swirl --- hw/acpi.c | 93 +--- hw/pc.c |1 - hw/pc.h |1 - hw/pci.c | 12 +-- hw/pci.h |6 ++- 5 files changed, 63 insertions(+), 50 deletions(-)

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread François Revol
Le Mon, 10 May 2010 22:12:33 +0200, Stefan Weil a écrit : > The fix is based on a patch from Kevin Wolf. Here his comment: > > "The number of blocks needs to be rounded up to cover all of the > virtual hard > disk. Without this fix, we can't even open our own images if their > size is not > a multi

[Qemu-devel] [PATCH 3/6] virtio-9p: modify create/open2 and mkdir for new security model.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h | 23 +- hw/virtio-9p-local.c | 117 + hw/virtio-9p.c | 42

Re: [Qemu-devel] [PATCH 2/3] dmg: use pread

2010-05-10 Thread Christoph Hellwig
On Mon, May 10, 2010 at 12:07:40PM +0200, Kevin Wolf wrote: > > > > -info_begin=read_off(s->fd); > > -if(info_begin==0) > > - goto fail; > > -if(lseek(s->fd,info_begin,SEEK_SET)<0) > > - goto fail; > > We seek to info_begin. > > > -if(read_uint32(s->fd)!=0x100) > > - goto

[Qemu-devel] [PATCH 0/6] virtio-9p:Introducing security model for VirtFS

2010-05-10 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series. It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control. L

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread Alexander Graf
Hi Chong, On 10.05.2010, at 13:55, QiaoChong wrote: > When ahci init ,driver will send ATA_SRST command,ahci device report device > type through port's sig register. > Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not > support cdrom media. > I just copy ide_atapi_cmd fro

[Qemu-devel] [PATCH 5/6] virtio-9p: Implemented security model for symlink and link.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 +- hw/virtio-9p-local.c | 74 + hw/virtio-9p.c | 24 +++- 3 files changed, 75 insertions(+), 27 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.

[Qemu-devel] [PATCH 2/6] virtio-9p: Rearrange fileop structures

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 185 ++-- hw/virtio-9p.h | 92 2 files changed, 138 insertions(+), 139 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 62be770..365259c

[Qemu-devel] [PATCH 1/6] virtio-9p: Introduces an option to specify the security model.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev local,id=jvrao,path=/tmp/,security_model=[mapped|passthrough] -virtfs local,path=/tmp/,security_model=[mapped|passthrough],mnt_tag=v_tmp. In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are saved in ext

Re: [Qemu-devel] [PATCH] fix migration with large mem

2010-05-10 Thread Anthony Liguori
On 04/13/2010 04:33 AM, Izik Eidus wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidus Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PATCH] fix migration with large mem In cases of guests with large mem that have pages that all their bytes content ar

[Qemu-devel] [PATCH 4/6] virtio-9p: Implement Security model for mknod related files

2010-05-10 Thread Venkateswararao Jujjuri (JV)
In the mapped security model all the special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. These extended attributes are used to present this file as special file to the client. Signed-off-by: Venkateswararao Jujjuri --- hw/f

[Qemu-devel] [PATCH 6/6] virtio-9p: Implemented Security model for lstat and fstat

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 67 +++--- 1 files changed, 63 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 89b17f0..529de73 100644 --- a/hw/virtio-9p-local.c +++ b/hw/

Re: [Qemu-devel] [PATCH 1/5] SCSI: Add disk reset handler

2010-05-10 Thread Anthony Liguori
On 05/04/2010 07:20 AM, Jan Kiszka wrote: Ensure that pending requests of an SCSI disk are purged on system reset and also restore max_lba. The latter is no only present in the reset handler as that one is called after init as well. Signed-off-by: Jan Kiszka Applied all (including v2 of 5/

Re: [Qemu-devel] [PATCH] iov: Move from hw/ to topdir

2010-05-10 Thread Anthony Liguori
On 05/04/2010 06:09 AM, Amit Shah wrote: The iov functions can be useful to other code as well. Signed-off-by: Amit Shah CC: Christoph Hellwig Applied. Thanks. Regards, Anthony Liguori --- hw/iov.c => iov.c |0 hw/iov.h => iov.h |0 2 files changed, 0 insertions(+), 0 de

Re: [Qemu-devel] [PATCH 1/4] doc: Fix host forwarding monitor command documentation

2010-05-10 Thread Anthony Liguori
On 05/04/2010 06:20 AM, Markus Armbruster wrote: Commit f3546deb replaced host_net_redir by hostfwd_add, hostfwd_remove, but neglected to update documentation. Signed-off-by: Markus Armbruster Applied all. Thanks. Regards, Anthony Liguori --- qemu-monitor.hx | 13 ++--- 1

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2010-05-10 Thread Anthony Liguori
On 04/18/2010 02:21 PM, Shahar Havivi wrote: Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the structure handled by qemu tail queue. Adding a new keyboard add to the list and select it, removing keyboard select the previous keyboard in list. Signed-off-by: Shahar Havivi

[Qemu-devel] [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread Stefan Weil
The fix is based on a patch from Kevin Wolf. Here his comment: "The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size." While Kevin's patch addressed vdi_create, my m

Re: [Qemu-devel] Print input opcodes before translation

2010-05-10 Thread Blue Swirl
On 5/10/10, John Vele wrote: > Greetings, > > I'm using qemu user mode for i386 and I would like to print the opcodes of > an > input executable one bye one before any translation. > Is the file target-i386/translate.c the one that I shall edit? The function > disas_insn() > in the same file is t

[Qemu-devel] Print input opcodes before translation

2010-05-10 Thread John Vele
Greetings, I'm using qemu user mode for i386 and I would like to print the opcodes of an input executable one bye one before any translation. Is the file target-i386/translate.c the one that I shall edit? The function disas_insn() in the same file is the appropriate one? Thanx in advance

[Qemu-devel] [PATCH] Compile virtio-9p-debug and virtio-9p-local once

2010-05-10 Thread Blue Swirl
Signed-off-by: Blue Swirl --- Makefile.objs |2 ++ Makefile.target |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index ecdd53e..110f8fd 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -226,6 +226,8 @@ sound-obj-$(CONFIG_CS4231A) +=

[Qemu-devel] [PATCH] block/vpc: Fix conversion from size to disk geometry

2010-05-10 Thread Stefan Weil
The VHD algorithm calculates a disk geometry which is usually smaller than the requested size. QEMU tried to round up but failed for certain sizes: qemu-img create -f vpc disk.vpc 9437184 would create an image with 9435136 bytes (which is too small for qemu-img convert). Instead of hacking the g

Re: [Qemu-devel] [PATCH] sh: sm501: add 2D engine support

2010-05-10 Thread Blue Swirl
On 5/9/10, Shin-ichiro KAWASAKI wrote: > In linux kernel v2.6.33, sm501 frame buffer driver modified to support > 2D graphics engine on sm501 chip. One example is "fill rectangle" operation. > But current qemu's sm501 emulation doesn't support it. This results in > graphics console disturbanc

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai wrote: > This patch add initial support of VIA IDE controller used by fulong mini pc > > Signed-off-by: Huacai Chen > - > diff --git a/Makefile.objs b/Makefile.objs > index ecdd53e..75be9ce 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -195,6 +195,7 @@

Re: [Qemu-devel] [RFC] default mac address issue

2010-05-10 Thread Anthony Liguori
Hi Bruce, On 05/10/2010 02:07 PM, Bruce Rogers wrote: I know this behavior has worked this way all along, but I wanted to bring up the following concern and float a few ideas about possible solutions. Please provide your perspective, opinion, etc. qemu (or qemu-kvm) users can easily get into

Re: [Qemu-devel] [RFC][MIPS][PATCH 2/6] Initial support of vt82686b south bridge used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai wrote: > This patch add initial support of vt82686b south bridge used by fulong mini pc > > Signed-off-by: Huacai Chen > - > diff --git a/Makefile.target b/Makefile.target > index fc4c59f..08968d6 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -219,7

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai wrote: > This patch add initial support of bonito north bridge used by fulong mini pc > > Signed-off-by: Huacai Chen > - > diff --git a/Makefile.target b/Makefile.target > index c092900..fc4c59f 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -218,7 +

[Qemu-devel] [RFC] default mac address issue

2010-05-10 Thread Bruce Rogers
I know this behavior has worked this way all along, but I wanted to bring up the following concern and float a few ideas about possible solutions. Please provide your perspective, opinion, etc. qemu (or qemu-kvm) users can easily get into trouble when they don't specifying the mac address for t

Re: [Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-10 Thread Blue Swirl
On 5/10/10, Mark Cave-Ayland wrote: > Blue Swirl wrote: > > > > Thanks a lot, with this patch my tests passed! I applied the combined > patch. > > > > Yes, I definitely see an improvement with this patch - at least my Debian > lenny SPARC boot cd doesn't randomly kernel panic any more. It looks a

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-10 Thread Blue Swirl
On 5/10/10, Artyom Tarasenko wrote: > 2010/5/9 Blue Swirl : > > On 5/9/10, Artyom Tarasenko wrote: > >> 2010/5/9 Blue Swirl : > >> > >> > On 5/8/10, Artyom Tarasenko wrote: > >> >> On the real hardware (SS-5, LX) the MMU is not padded, but aliased. > >> >> Software shouldn't use aliased

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 11:52 AM, Anthony Liguori wrote: > On 05/10/2010 12:43 PM, Cam Macdonell wrote: >> >> On Mon, May 10, 2010 at 11:25 AM, Anthony Liguori >>  wrote: >> >>> >>> On 05/10/2010 11:59 AM, Avi Kivity wrote: >>> On 05/10/2010 06:38 PM, Anthony Liguori wrote: > >>

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 12:43 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 11:25 AM, Anthony Liguori wrote: On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-10 Thread Markus Armbruster
Anthony Liguori writes: > On 04/21/2010 03:28 AM, Daniel P. Berrange wrote: >> On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: [...] >> Wouldn't it be nicer to return strerror_r() output instead of errno >> names ? >> > > Both are equally wrong :-) > > QMP should insult user

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 04 May 2010 16:56:19 -0500 > Anthony Liguori wrote: > >> On 05/04/2010 03:30 PM, Luiz Capitulino wrote: >> > >> > StateVmSaveFailed is not like CommandFailed, there are five errors >> > in do_savevm() and StateVmSaveFailed happens to be one of them. >> > >> >

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 11:25 AM, Anthony Liguori wrote: > On 05/10/2010 11:59 AM, Avi Kivity wrote: >> >> On 05/10/2010 06:38 PM, Anthony Liguori wrote: >>> > Otherwise, if the BAR is allocated during initialization, I would have > to use MAP_FIXED to mmap the memory.  This is what I did

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Anthony Liguori writes: > On 05/03/2010 08:06 AM, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >> >>> We need to expose errno in QMP, for three reasons: >>> >>>1. Some error handling functions print errno codes to the user, >>> while it's debatable whether this is good or

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory. This is what I did before the qemu_ram_mmap() function was added. What would happen to any dat

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread Stefan Weil
Am 10.05.2010 13:21, schrieb chen huacai: --- a/hw/mips.h +++ b/hw/mips.h @@ -5,6 +5,9 @@ /* gt64xxx.c */ PCIBus *pci_gt64120_init(qemu_irq *pic); +/* bonito.c */ +PCIBus *bonito_init_2e(qemu_irq pic); + /* ds1225y.c */ void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory. This is what I did before the qemu_ram_mmap() function was added. What would happen to any data written to the BAR before the the handsh

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 11:20 AM, Cam Macdonell wrote: On Mon, May 10, 2010 at 9:38 AM, Anthony Liguori wrote: On 05/10/2010 10:28 AM, Avi Kivity wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's shared memory region f

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 10:40 AM, Avi Kivity wrote: > On 05/10/2010 06:41 PM, Cam Macdonell wrote: >> >>> What would happen to any data written to the BAR before the the handshake >>> completed?  I think it would disappear. >>> >> >> But, the BAR isn't there until the handshake is completed.  Only

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the the handshake completed? I think it would disappear. But, the BAR isn't there until the handshake is completed. Only after receiving the shared memory fd does my device call pci_reg

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 9:38 AM, Anthony Liguori wrote: > On 05/10/2010 10:28 AM, Avi Kivity wrote: >> >> On 05/10/2010 06:22 PM, Cam Macdonell wrote: >>> > + > +    /* if the position is -1, then it's shared memory region fd */ > +    if (incoming_posn == -1) { > + > +  

[Qemu-devel] Re: [PATCH] virtio: invoke set_features on load

2010-05-10 Thread David Stevens
"Michael S. Tsirkin" wrote on 05/09/2010 09:42:09 AM: > After migration, vhost was not getting features > acked because set_features callback was never invoked. > The fix is just to invoke that callback. > > Reported-by: David L Stevens > Signed-off-by: Michael S. Tsirkin > --- > > David, a t

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
On Mon, May 10, 2010 at 10:58:45AM -0500, Anthony Liguori wrote: > On 05/10/2010 10:54 AM, Gleb Natapov wrote: > >On Mon, May 10, 2010 at 10:48:42AM -0500, Anthony Liguori wrote: > >>On 05/10/2010 03:11 AM, Gleb Natapov wrote: > >>>This patch adds native support for booting from virtio disks to Sea

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Anthony Liguori
On 05/10/2010 10:54 AM, Gleb Natapov wrote: On Mon, May 10, 2010 at 10:48:42AM -0500, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov A related problem tha

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
On Mon, May 10, 2010 at 10:48:42AM -0500, Anthony Liguori wrote: > On 05/10/2010 03:11 AM, Gleb Natapov wrote: > >This patch adds native support for booting from virtio disks to Seabios. > > > >Signed-off-by: Gleb Natapov > > A related problem that I think we need to think about how we solve > is

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-10 Thread Aurelien Jarno
Shin-ichiro KAWASAKI a écrit : > Hello, Rob, > > This mail might be too late, but I want to report you that I > encountered similar trouble. > > Using the linux kernel after the following commit, the qemu-sh > serial console shows no output. > >cd5f107628ab89c5dec5ad923f1c27f4cba41972 > > T

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Anthony Liguori
On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov A related problem that I think we need to think about how we solve is indicating to Seabios which device we want to boot from With your patch,

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 9:28 AM, Avi Kivity wrote: > On 05/10/2010 06:22 PM, Cam Macdonell wrote: >> >>> + +    /* if the position is -1, then it's shared memory region fd */ +    if (incoming_posn == -1) { + +        s->num_eventfds = 0; + +        if (check_shm

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 10:28 AM, Avi Kivity wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's shared memory region fd */ +if (incoming_posn == -1) { + +s->num_eventfds = 0; + +if (check_shm_size(s, incoming_fd) == -1) { +exi

[Qemu-devel] Re: [PATCH v5 2/5] Support adding a file to qemu's ram allocation

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 4:39 AM, Avi Kivity wrote: > On 04/21/2010 08:53 PM, Cam Macdonell wrote: >> >> This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to >> map a >> host file into guest RAM.  This function mmaps the opened file anywhere >> and adds >> the memory to the ram b

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's shared memory region fd */ +if (incoming_posn == -1) { + +s->num_eventfds = 0; + +if (check_shm_size(s, incoming_fd) == -1) { +exit(-1); +} + +/* creating a

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 5:59 AM, Avi Kivity wrote: > On 04/21/2010 08:53 PM, Cam Macdonell wrote: >> >> Support an inter-vm shared memory device that maps a shared-memory object >> as a >> PCI device in the guest.  This patch also supports interrupts between >> guest by >> communicating over a uni

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:13 PM, Cam Macdonell wrote: +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t addr, uint32_t val, bool assign) +{ + +int ret; +struct kvm_ioeventfd iofd; + +iofd.datamatch = val; +iofd.addr = addr; +iofd.len = 4; +iofd.flags = KVM_IOEVENTFD_FLAG_DATAMATC

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 4:43 AM, Avi Kivity wrote: > On 04/21/2010 08:53 PM, Cam Macdonell wrote: >> >> Generic functions to assign irqfds and ioeventfds. >> >> > > Signoff. > >>  } >> >>  #ifdef KVM_IOEVENTFD >> +int kvm_set_irqfd(int fd, uint16_t vector, uint32_t gsi) >> +{ >> +    struct kvm_ir

[Qemu-devel] KVM call agenda for May 11

2010-05-10 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-10 Thread Shin-ichiro KAWASAKI
Hello, Rob, This mail might be too late, but I want to report you that I encountered similar trouble. Using the linux kernel after the following commit, the qemu-sh serial console shows no output. cd5f107628ab89c5dec5ad923f1c27f4cba41972 This trouble was discussed in sh-linux ML. http://m

Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Avi Kivity
On 05/10/2010 04:43 PM, Jan Kiszka wrote: Avi Kivity wrote: On 05/10/2010 01:59 PM, Jan Kiszka wrote: From a quick glance at the JSON spec, there is no room for a new type. I think we have to overload an existing one and convert that into a QBuffer (typically, we know the actual se

[Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Tejun Heo
Hello, On 05/09/2010 09:11 PM, Alexander Graf wrote: > Sebastian Herbszt wrote: >> The ICH6 AHCI implementation submitted by Chong is an all-in-one >> attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, >> SATA and ATA specification. The code in hw/ide/* on the other hand >> is spl

[Qemu-devel] qemu-system-arm use for bootloader running

2010-05-10 Thread Belisko Marek
Hi, I'm working on eol bootloader (http://vivien.chappelier.free.fr/typhoon/release/eol/20070609/eol-0.5.tar.gz) This bootloader was written to load kernel image from sd card in SPL mode for htc phones (omap 730, omap 850) to no start WINCE but you can choose what to load. First of all I would l

[Qemu-devel] [PATCH 2/2] ehci: Fix debug traces

2010-05-10 Thread Vincent Palatin
- fix build error when activating traces - properly display the config flags register Signed-off-by: Vincent Palatin --- hw/usb-ehci.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index e724653..ab9a23e 100644 --- a/hw/usb-ehci.c +++

[Qemu-devel] ehci fixes

2010-05-10 Thread Vincent Palatin
Dear developers, While using the EHCI patchset, I have found 2 minor issues. So, I send in this email thread 2 fix proposals. Those patches apply on top of the Jan Kiszka's ehci branch. Thanks to Jan and David for gathering and updating this patchset. -- Vincent

[Qemu-devel] [PATCH 1/2] ehci: Fix error detection when registering a new list base address

2010-05-10 Thread Vincent Palatin
We must check against the current running command not the list address. Signed-off-by: Vincent Palatin --- hw/usb-ehci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 8be0780..e724653 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c

  1   2   >