[Qemu-devel] [PATCH] x86: Fix INIT processing

2010-06-23 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This fixes a regression of 0e26b7b892: Reset halted also on INIT. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/helper.c

[Qemu-devel] [PATCH] x86: Clean up CPU reset

2010-06-23 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pc.c | 22 -- 1 files changed, 4 insertions(+), 18 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 1848151..8b9e70a 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -812,20 +812,12 @@

[Qemu-devel] [PATCH v5 0/9] pci: multi-function bit fixes

2010-06-23 Thread Isaku Yamahata
Maing changes v4 - v5: - split up/reorder patches for bisectability and testability - stype fixes. patch description: When pci devices are populated as multi-function, OS can fail to probe function 0. It's because multi function bit of header type register in configuration space isn't set, so

[Qemu-devel] [PATCH v5 2/9] pci: insert assert that auto-assigned-address function is single function device.

2010-06-23 Thread Isaku Yamahata
Auto-assigned-address pci function (passing devfn = -1) is always single function. This patch adds assert() to guarantee that auto-assigned-address function is always single function device at function = 0. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- changes v2 - v3 split out into

[Qemu-devel] [PATCH v5 3/9] pci: don't overwrite multi functio bit in pci header type.

2010-06-23 Thread Isaku Yamahata
Don't overwrite pci header type. Otherwise, multi function bit which pci_init_header_type() sets appropriately is lost. Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero which is already zero cleared. how to test: run qemu and issue info pci to see whether a device in question

[Qemu-devel] [PATCH v5 7/9] pci: set multifunction property for normal device.

2010-06-23 Thread Isaku Yamahata
use pci_create_simple_multifunction() for normal device which sets multifunction bit. At the moment, only pc_piix.c and mips_malta.c uses multifunction devices with piix3/4 pci-isa bridge. And other boards don't populate those devices. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp ---

[Qemu-devel] [PATCH v5 5/9] qdev: implement qdev_prop_set_bit().

2010-06-23 Thread Isaku Yamahata
implement qdev_prop_set_bit(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/qdev-properties.c |5 + hw/qdev.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 5a8739d..20eec76 100644 ---

[Qemu-devel] [PATCH v5 1/9] pci: use PCI_DEVFN() where appropriate.

2010-06-23 Thread Isaku Yamahata
Use PCI_DEVFN() and PCI_FUNC_MAX where appropriate. This patch make it clear that func = 0. test: The following object files with/without this patch are stripped and compared. They remains same. arm-softmmu/versatile_pci.o libhw32/ppce500_pci.o libhw32/unin_pci.o libhw64/ppce500_pci.o

[Qemu-devel] [PATCH v5 8/9] pci_bridge: make pci bridge aware of pci multi function bit.

2010-06-23 Thread Isaku Yamahata
make pci bridge aware of pci multi function property and let pci generic code to set the bit. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- changes v4 - v5: - uint8_t mf - bool multifunction --- hw/apb_pci.c |4 ++-- hw/dec_pci.c |2 +-

[Qemu-devel] [PATCH v5 9/9] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
Set PCI multi-function bit according to multifunction property. PCI address, devfn ,is exported to users as addr property, so users can populate pci function(PCIDevice in qemu) at arbitrary devfn. It means each function(PCIDevice) don't know whether pci device (PCIDevice[8]) is multi function or

RE: [Qemu-devel] u-boot on 'qemu-system-mips64 -M mips'

2010-06-23 Thread KAWAKATSU, Noritaka
I report the workaround for u-boot execution on qemu-system-mips64. movn s1,v1,v0 From what I understand when reading the mips IV manual, the movn ins is only for mips IV / 32bit and not 64bit. Looks like the qemu code has been written following this. (This also explains why

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-23 Thread Jan Kiszka
Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: Jan Kiszka wrote: Marcelo Tosatti wrote: Clear exit_request when iothread grabs the global lock. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/cpu-exec.c b/cpu-exec.c

[Qemu-devel] [PATCH v5 6/9] pci: introduce multifunction property.

2010-06-23 Thread Isaku Yamahata
introduce multifunction property. Also introduce new convenient device creation function which will be used later. For bisectability this patch doesn't do anything, but sets the property resulting in no functional changes. Actual changes will be introduced by later patch. Signed-off-by: Isaku

[Qemu-devel] [PATCH v5 4/9] pci: remove PCIDeviceInfo::header_type

2010-06-23 Thread Isaku Yamahata
replace PCIDeviceInfo::header_type with is_bridge as suggested by Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/apb_pci.c |2 +- hw/dec_pci.c |2 +- hw/pci.c | 15 --- hw/pci.h |8 ++-- 4 files changed, 16

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Mon, Jun 21, 2010 at 03:36:00PM +0300, Michael S. Tsirkin wrote: On Mon, Jun 21, 2010 at 03:03:58PM +0900, Isaku Yamahata wrote: Set PCI multi-function bit according to multifunction property. PCI address, devfn ,is exported to users as addr property, so users can populate pci

[Qemu-devel] [Bug 597575] [NEW] Hangs on HTTP errors when using the curl block driver

2010-06-23 Thread Apollon Oikonomopoulos
Public bug reported: Hi, It seems that qemu-kvm does not handle HTTP errors gracefully when using the curl block driver and a synchronous request is made (i.e. one using bdrv_read_em() for example). In these cases, if an HTTP error (such as 404 or 416) is returned, the aio thread exits but the

Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com We allow to address a bus only using its local name. This is ambiguous but unfortunately so handy that people (specifically libvirt) will likely complain if bus=pci.0 needs to be replaced with

Re: [Qemu-devel] [PATCH v4 01/23] qdev: Rework qtree path abbreviations

2010-06-23 Thread Markus Armbruster
[cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Path abbreviations suffer from the inconsistency that bus names can only be omitted at the end of a path. Drop this special rule, and also remove the now obsolete QERR_DEVICE_MULTIPLE_BUSSES.

[Qemu-devel] [Bug 592056] Re: qemu segmentation fault when create qcow2 image with qemu-img command

2010-06-23 Thread xudong
This bug has been fixed on commit: kvm-commit:a63e16c655f9e68d49d6fae4275ffda16b1888b2, qemu-kvm commit:97011c7fce92f8c0928c9e94e9896f0dca1bdeb9. qcow.img file can be created by qemu-img successfully. fixed patch: diff --git a/qemu-option.c b/qemu-option.c index

Re: [Qemu-devel] [PATCH v4 04/23] qdev: Allow device addressing via 'driver.instance'

2010-06-23 Thread Markus Armbruster
[cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Extend qbus_find_dev to allow addressing of devices without an unique id via an optional per-bus instance number. The new formats are 'driver.instance' and 'alias.instance'. Attach this name extension

Re: [Qemu-devel] [PATCH v4 01/23] qdev: Rework qtree path abbreviations

2010-06-23 Thread Markus Armbruster
Hmm, what happens if the path denotes a device instead of a bus? qemu-system-x86_64: -device e1000,bus=/i440FX-pcihost: Bus '' not found Not so nice.

Re: [Qemu-devel] [PATCH v4 07/23] qdev: Allow device specification by qtree path for device_del

2010-06-23 Thread Markus Armbruster
[cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Allow to specify the device to be removed via device_del not only by ID but also by its full or abbreviated qtree path. For this purpose, qdev_find is introduced which combines walking the qtree with

Re: [Qemu-devel] [PATCH v4 08/23] qdev: Introduce qdev_iterate_recursive

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Add qdev_iterate_recursive to walk the complete qtree invoking a callback for each device. Use this service to implement qdev_find_id_recursive. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/qdev.c |

Re: [Qemu-devel] [PATCH v4 12/23] monitor: Add completion for qdev paths

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Implement monitor command line completion for device tree paths. The first user are device_add ('bus' option) and device_del. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/qdev.c | 19 +

[Qemu-devel] [PATCH] virtio-net: correct header length math

2010-06-23 Thread Michael S. Tsirkin
We were requesting too much when checking buffer length: size already includes host header length. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-net.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c

Re: [Qemu-devel] [PATCH v4 13/23] monitor: Allow to specify HMP-specifc command arguments

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com As we may want to shrink or enhance the argument set used for monitor command in HMP mode, add a separate, optional argument string for that case. When an HMP request is parsed, this argument string, if available,

Re: [Qemu-devel] [PATCH v4 14/23] monitor: return length of printed string via monitor_[v]printf

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This simply forwards the result of the internal vsnprintf to the callers of monitor_printf and monitor_vprintf. When invoked over a QMP session or in absence of an active monitor, -1 is returned. Signed-off-by:

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 04:25:20PM +0900, Isaku Yamahata wrote: On Mon, Jun 21, 2010 at 03:36:00PM +0300, Michael S. Tsirkin wrote: On Mon, Jun 21, 2010 at 03:03:58PM +0900, Isaku Yamahata wrote: Set PCI multi-function bit according to multifunction property. PCI address, devfn ,is

Re: [Qemu-devel] [PATCH v4 00/23] qdev path reworks basic device state visualization

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: This is v4 of this series. Besides small fixes, it's main focus is on the groundwork for the visualization command: qdev path usability. Don't let my griping on individual patches mislead you: there's lots of good stuff in here.

[Qemu-devel] Re: [PATCH v5 1/9] pci: use PCI_DEVFN() where appropriate.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 04:15:25PM +0900, Isaku Yamahata wrote: Use PCI_DEVFN() and PCI_FUNC_MAX where appropriate. This patch make it clear that func = 0. test: The following object files with/without this patch are stripped and compared. They remains same. arm-softmmu/versatile_pci.o

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This enables command line completion inside option strings. A list of expected key names and their completion type can be appended to the 'O' inside parentheses ('O(key:type,...)'). The first use case is block

Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name

2010-06-23 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com We allow to address a bus only using its local name. This is ambiguous but unfortunately so handy that people (specifically libvirt) will likely complain if bus=pci.0 needs to be replaced

[Qemu-devel] Re: [PATCH v5 2/9] pci: insert assert that auto-assigned-address function is single function device.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 04:15:26PM +0900, Isaku Yamahata wrote: Auto-assigned-address pci function (passing devfn = -1) is always single function. This patch adds assert() to guarantee that auto-assigned-address function is always single function device at function = 0. Signed-off-by: Isaku

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Wed, Jun 23, 2010 at 12:52:10PM +0300, Michael S. Tsirkin wrote: @@ -575,6 +576,44 @@ static void pci_init_wmask_bridge(PCIDevice *d) pci_set_word(d-wmask + PCI_BRIDGE_CONTROL, 0x); } +static int pci_init_multifunction(PCIBus *bus, PCIDevice *dev) +{

[Qemu-devel] [PATCH] block: allow filenames with colons again for host devices

2010-06-23 Thread Christoph Hellwig
Before the raw/file split we used to allow filenames with colons for host device only. While this was more by accident than by design people rely on it, so we need to bring it back. So move the host device probing to be before the protocol detection again. Signed-off-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree paths

2010-06-23 Thread Jan Kiszka
Markus Armbruster wrote: [cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Device IDs may conflict with device names or aliases. From now on we only accept them outside qtree paths. This also makes dumping IDs in qbus_list_dev/bus obsolete.

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-23 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This enables command line completion inside option strings. A list of expected key names and their completion type can be appended to the 'O' inside parentheses ('O(key:type,...)'). The

[Qemu-devel] [Bug 597641] [NEW] SD card state change from ident to stby

2010-06-23 Thread Rudrajit Sengupta
Public bug reported: My environment host : Linux PC(2.6.29.4) Target: ARM-CortexA8 I am not running any OS on the target. Below is my command line: ../src/arm-softmmu/qemu-system-arm -M FPGA_NOOS -kernel elfImage -nographic -sd sd.img Problem scenario 1. CMD13 issued immediately after

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 07:13:38PM +0900, Isaku Yamahata wrote: On Wed, Jun 23, 2010 at 12:52:10PM +0300, Michael S. Tsirkin wrote: @@ -575,6 +576,44 @@ static void pci_init_wmask_bridge(PCIDevice *d) pci_set_word(d-wmask + PCI_BRIDGE_CONTROL, 0x); } +static

Re: [Qemu-devel] [PATCH] block: allow filenames with colons again for host devices

2010-06-23 Thread Kevin Wolf
Am 23.06.2010 12:25, schrieb Christoph Hellwig: Before the raw/file split we used to allow filenames with colons for host device only. While this was more by accident than by design people rely on it, so we need to bring it back. So move the host device probing to be before the protocol

Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com We allow to address a bus only using its local name. This is ambiguous but unfortunately so handy that people (specifically libvirt) will likely

Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree paths

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Markus Armbruster wrote: [cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Device IDs may conflict with device names or aliases. From now on we only accept them outside qtree paths. This also makes

Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree paths

2010-06-23 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Markus Armbruster wrote: [cc: kraxel] Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com Device IDs may conflict with device names or aliases. From now on we only accept them outside qtree

Re: [Qemu-devel] [PATCH v6 6/6] the stand-alone shared memory server for inter-VM shared memory

2010-06-23 Thread Avi Kivity
On 06/14/2010 06:53 PM, Anthony Liguori wrote: index 000..e0a7b98 --- /dev/null +++ b/contrib/ivshmem-server/ivshmem_server.c There's no licensing here. I don't think this belongs in the qemu tree either to be honest. I asked for this, to simplify life for people trying this out. If

[Qemu-devel] [PATCH 1/2] rtc: Parse the 'driftfix' option only for TARGET_I386

2010-06-23 Thread Amit Shah
The driftfix option is only useful for Windows guests, and for the x86 architecture, so limit the option parsing to TARGET_I386. This ifdef conditional is moved from qemu-config.c to vl.c. The next patch will fix a bug where the driftfix option wasn't exposed at all even to the x86 architecture.

[Qemu-devel] [PATCH 2/2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-06-23 Thread Amit Shah
qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-config.c |2 -- 1 files changed, 0 insertions(+), 2

[Qemu-devel] Re: [PATCH 1/2] rtc: Parse the 'driftfix' option only for TARGET_I386

2010-06-23 Thread Paolo Bonzini
On 06/23/2010 04:29 PM, Amit Shah wrote: The driftfix option is only useful for Windows guests, and for the x86 architecture, so limit the option parsing to TARGET_I386. This ifdef conditional is moved from qemu-config.c to vl.c. The next patch will fix a bug where the driftfix option wasn't

[Qemu-devel] Re: [PATCH 1/2] rtc: Parse the 'driftfix' option only for TARGET_I386

2010-06-23 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: The driftfix option is only useful for Windows guests, and for the x86 architecture, so limit the option parsing to TARGET_I386. This ifdef conditional is moved from qemu-config.c to vl.c. The next patch will fix a bug where the driftfix option wasn't

[Qemu-devel] Re: [PATCH 1/2] rtc: Parse the 'driftfix' option only for TARGET_I386

2010-06-23 Thread Amit Shah
On (Wed) Jun 23 2010 [16:35:26], Paolo Bonzini wrote: On 06/23/2010 04:29 PM, Amit Shah wrote: The driftfix option is only useful for Windows guests, and for the x86 architecture, so limit the option parsing to TARGET_I386. This ifdef conditional is moved from qemu-config.c to vl.c. The next

[Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-06-23 Thread Amit Shah
qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-config.c |2 -- 1 files changed, 0 insertions(+), 2

[Qemu-devel] Re: [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-06-23 Thread Paolo Bonzini
On 06/23/2010 04:44 PM, Amit Shah wrote: qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shahamit.s...@redhat.com --- qemu-config.c |2 --

[Qemu-devel] Re: [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-06-23 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah amit.s...@redhat.com Acked-by: Juan Quintela

[Qemu-devel] Question about mmap from user space and accessing emulated device bar0 contents

2010-06-23 Thread Anjali Kulkarni
Hi, I am not sure if this is the right forum for my questions - I am using Qemu+KVM on centOS to run my freebsd based virtual OS. The Qemu emulates one of my nics - yukon -II 88E8022 chip. Now, my yukon driver exists in kernel as well as user space(and I will use the one which I want based on

Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool

2010-06-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Historically, user monitor arguments beginning with '-' (eg. '-f') were passed as integers down to handlers. I've maintained this behavior in the new monitor because we didn't have a boolean type at the very beginning of QMP. Today we have it

Re: [Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part)

2010-06-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This commit introduces the second (and last) part of QMP's new argument checker. The job is done by check_client_args_type(), it iterates over the client's argument qdict and for for each argument it checks if it exists and if its type is

Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This is similar to qmp_check_client_args(), but it checks if the input object follows the specification (QMP/qmp-spec.txt section 2.3). As we're limited to three keys, the work here is quite simple: we iterate over the input object, checking

[Qemu-devel] [PATCH 0/7] QMP: Introduce query-netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. There is small change in the specification from the last version: when type is tap, the attribute sndbuf have been removed. sndbuf is not available on all platforms and most of the tap_set_sndbuf() implementations are stubs.

[Qemu-devel] [PATCH 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-23 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qdict.c | 60

[Qemu-devel] [PATCH 3/7] net: Introduce VLANClientState-info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net.c |1 + net.h

[Qemu-devel] [PATCH 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 +++ net.c | 70 + net.h |2 + 3 files changed, 80 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 4/7] net: tap/tap-win32: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c

[Qemu-devel] [PATCH 2/2] QError: Enhance QERR_DEVICE_NOT_ACTIVE's user desc

2010-06-23 Thread Luiz Capitulino
The 'by the guest' part is misleading, it could be disabled by the host too. We will likely need more surgery if we care for the distinction, just dropping the problematic part is good enough for now. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |2 +- 1 files changed,

[Qemu-devel] [PATCH 0/2]: QMP/Monitor: Fix balloon error reporting

2010-06-23 Thread Luiz Capitulino
Details in the patches.

[Qemu-devel] [PATCH 5/7] net: vde: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include qemu-char.h #include

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing writeback cache option

2010-06-23 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu) Status: Incomplete = Confirmed -- qemu-nbd slow and missing writeback cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid

[Qemu-devel] [PATCH 6/7] net: slirp: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6

[Qemu-devel] Re: [PATCH] virtio-net: correct header length math

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 05:57:13PM +0200, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: We were requesting too much when checking buffer length: size already includes host header length. Signed-off-by: Michael S. Tsirkin m...@redhat.com All changes here are ok, but we

[Qemu-devel] [PATCH 1/2] QMP: Fix error reporting in the async API

2010-06-23 Thread Luiz Capitulino
The current asynchronous command API doesn't return a QMP response when the async command fails. This is easy to reproduce with the balloon command (the sole async command we have so far): run qemu w/o the '-balloon virtio' option and try to issue the balloon command via QMP: no response will be

[Qemu-devel] Re: [PATCH] virtio-net: correct header length math

2010-06-23 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: We were requesting too much when checking buffer length: size already includes host header length. Signed-off-by: Michael S. Tsirkin m...@redhat.com All changes here are ok, but we are still missing more checks. --- hw/virtio-net.c | 20

Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool

2010-06-23 Thread Luiz Capitulino
On Wed, 23 Jun 2010 17:05:02 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Historically, user monitor arguments beginning with '-' (eg. '-f') were passed as integers down to handlers. I've maintained this behavior in the new monitor

[Qemu-devel] [PATCH v7 RESEND 4/4] Inter-VM shared memory PCI device

2010-06-23 Thread Cam Macdonell
resent for some printf macros and one addition Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository.

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing writeback cache option

2010-06-23 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu) Status: Confirmed = Incomplete -- qemu-nbd slow and missing writeback cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid

Re: [Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-23 Thread Anthony Liguori
On 06/23/2010 02:42 AM, Jan Kiszka wrote: Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: Jan Kiszka wrote: Marcelo Tosatti wrote: Clear exit_request when iothread grabs the global lock.

Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-23 Thread Luiz Capitulino
On Wed, 23 Jun 2010 17:23:54 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This is similar to qmp_check_client_args(), but it checks if the input object follows the specification (QMP/qmp-spec.txt section 2.3). As we're limited to

Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool

2010-06-23 Thread Luiz Capitulino
On Wed, 23 Jun 2010 18:31:53 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 23 Jun 2010 17:05:02 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Historically, user monitor

Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool

2010-06-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 23 Jun 2010 17:05:02 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Historically, user monitor arguments beginning with '-' (eg. '-f') were passed as integers down to handlers.

Re: [Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part)

2010-06-23 Thread Luiz Capitulino
On Wed, 23 Jun 2010 17:21:12 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit introduces the second (and last) part of QMP's new argument checker. The job is done by check_client_args_type(), it iterates over the client's

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This enables command line completion inside option strings. A list of expected key names and their completion type can be appended to the 'O'

Re: [Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part)

2010-06-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 23 Jun 2010 17:21:12 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit introduces the second (and last) part of QMP's new argument checker. The job is done by

[Qemu-devel] [PATCH] virtio-serial: Fix compat property name

2010-06-23 Thread Amit Shah
Starting with qemu -M pc-0.12 -device virtio-serial results in -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix that. Also fix the ppc440 machine type bamboo-0.12 which has this typo. Reported-by:

[Qemu-devel] Guest OS hangs on usb_add

2010-06-23 Thread Timothy Jones
I am trying to attach universal remote control (URC MX-950) to Windows XP guest as follows: == (qemu) info usbhost   Device 1.1, speed 480 Mb/s     Hub: USB device 1d6b:0002, EHCI Host Controller   Device 2.1, speed 480 Mb/s     Hub: USB device 1d6b:0002, EHCI Host

[Qemu-devel] Filme Porno Gratis

2010-06-23 Thread Filme Porno

[Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-06-23 Thread Serge Hallyn
Note that putting quotes around the filename lets you use '/'. I.e. pmemsave 0x200 0x200 /tmp/abab I assume this is a shortcoming in the parser, as the source code at first glance claims to simply read a string. So I'm not sure how easily fixable it would be, but it appears to be something for

Re: [Qemu-devel] [PATCH v6 6/6] the stand-alone shared memory server for inter-VM shared memory

2010-06-23 Thread Anthony Liguori
On 06/23/2010 08:12 AM, Avi Kivity wrote: On 06/14/2010 06:53 PM, Anthony Liguori wrote: index 000..e0a7b98 --- /dev/null +++ b/contrib/ivshmem-server/ivshmem_server.c There's no licensing here. I don't think this belongs in the qemu tree either to be honest. I asked for this, to

[Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-06-23 Thread Anthony Liguori
The '/' character is used to create special expressions if double quotes aren't used. ** Changed in: qemu Status: New = Invalid -- qemus pmemsave doesn't accept / in filename https://bugs.launchpad.net/bugs/543478 You received this bug notification because you are a member of qemu-

[Qemu-devel] Re: [PATCH v5 2/9] pci: insert assert that auto-assigned-address function is single function device.

2010-06-23 Thread Isaku Yamahata
On Wed, Jun 23, 2010 at 01:11:00PM +0300, Michael S. Tsirkin wrote: On Wed, Jun 23, 2010 at 04:15:26PM +0900, Isaku Yamahata wrote: Auto-assigned-address pci function (passing devfn = -1) is always single function. This patch adds assert() to guarantee that auto-assigned-address function

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Wed, Jun 23, 2010 at 01:41:57PM +0300, Michael S. Tsirkin wrote: I will try to find a bit of time to rearrange the code in pci.c a bit, but this can come afterwards. I'd like to move pci_bridge_xxx into pci_bridge.c because pci.c has grown. Are you okay with it? Or should I wait for your

Re: [Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing writeback cache option

2010-06-23 Thread Jamie Lokier
Serge Hallyn wrote: The default of qemu-img (of using O_SYNC) is not very sensible because anyway, the client (the kernel) uses caches (write-back), (and qemu-nbd -d doesn't flush those by the way). So if for instance qemu-nbd is killed, regardless of whether qemu-nbd uses O_SYNC, O_DIRECT or

[Qemu-devel] Guest OS hangs on usb_add

2010-06-23 Thread Timothy Jones
With some digging around I found out that the qemu hangs in usb_host_claim_interfaces, which is caused by screwed up usb descriptor. The device reports the following: (gdb) p dev-descr_len $21 = 50 (gdb) p /x dev-descr...@50 $23 = {0x18, 0x1, 0x0, 0x1, 0xff, 0xff, 0xff, 0x8, 0x47, 0x46, 0x0,

Re: [Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-06-23 Thread Serge E. Hallyn
Thanks, Anthony. Do I understand correctly that that's the case '/' in monitor_parse_command() for '/10x' gdb-like format? thanks, -serge Quoting Anthony Liguori (anth...@codemonkey.ws): The '/' character is used to create special expressions if double quotes aren't used. ** Changed in:

[Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-06-23 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu) Status: New = Invalid -- qemus pmemsave doesn't accept / in filename https://bugs.launchpad.net/bugs/543478 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid Status in

[Qemu-devel] [Bug 597932] [NEW] qemu fail to parse command line with -pcidevice B:D.F

2010-06-23 Thread xudong
Public bug reported: Host OS:ia32e Guest OS :32e and pae kvm.git Commit:a63e16c655f9e68d49d6fae4275ffda16b1888b2 qemu-kvm Commit:97011c7fce92f8c0928c9e94e9896f0dca1bdeb9 Host Kernel Version:2.6.35-rc3 Hardware:Gulftown-HEDT Bug detailed description: -- when use command

[Qemu-devel] qemu fail to parse command line with -pcidevice 00:19.0

2010-06-23 Thread Hao, Xudong
When assign one PCI device, qemu fail to parse the command line: qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 Error: qemu-system-x86_64: Parameter 'id' expects an identifier Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. pcidevice

[Qemu-devel] [Bug 592056] Re: qemu segmentation fault when create qcow2 image with qemu-img command

2010-06-23 Thread xudong
** Changed in: qemu Status: New = Fix Committed -- qemu segmentation fault when create qcow2 image with qemu-img command https://bugs.launchpad.net/bugs/592056 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Fix

[Qemu-devel] [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices

2010-06-23 Thread Ryan Harper
Using Rusty's suggestion I've respun the patch removing the special copy function. I've tested this patch in a guest kernel with and without qemu supplying serial numbers for the block devices and it's working as expected. When qemu supplies serial numbers, the correct value is supplied to

[Qemu-devel] [PATCH 1/2] v2 Add 'serial' attribute to virtio-blk devices

2010-06-23 Thread Ryan Harper
Create a new attribute for virtio-blk devices that will fetch the serial number of the block device. This attribute can be used by udev to create disk/by-id symlinks for devices that don't have a UUID (filesystem) associated with them. ATA_IDENTIFY strings are special in that they can be up to

[Qemu-devel] [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-23 Thread Ryan Harper
With the availablility of a sysfs device attribute for examining disk serial numbers the ioctl is no longer needed. The user-space changes for this aren't upstream yet so we don't have any users to worry about. Signed-off-by: Ryan Harper ry...@us.ibm.com --- drivers/block/virtio_blk.c | 10

[Qemu-devel] [PATCH 02/15] qdev: Add a get_dev_path() function to BusInfo

2010-06-23 Thread Alex Williamson
This function is meant to provide a stable device path for buses which are able to implement it. If a bus has a globally unique addresses scheme, one address level may be sufficient to provide a path. Other buses may need to recursively traverse up the qdev tree. Signed-off-by: Alex Williamson

[Qemu-devel] [PATCH 00/15] Make migration work with hotplug

2010-06-23 Thread Alex Williamson
Ok, new approach. I'm going to attempt to extract myself for the canonical device path approach, because we're missing too many pieces to make that work. Instead, I'll take Anthony's advice and try to simplify. We still want a unique name for ramblocks and savevm, but the hotplug problem today

  1   2   >