[Qemu-devel] Re: [PATCHv2] qemu-kvm/vhost: fix up irqfd support

2010-10-07 Thread Michael S. Tsirkin
Looks fine except for the extra white space here and copied below. Thanks, Alex OK, I fixed this up and queued the patch with your ack. Thanks for the review! -- MST

Re: [Qemu-devel] [Bug 642304] Re: Solaris/x86 v10 hangs under KVM

2010-10-07 Thread Michael Tokarev
07.10.2010 17:17, Nigel Horne wrote: 2) KVM doesn't have specific versions on Debian. The kernel is built with KVM included. The kernel is version 2.6.32-5 This is just plain wrong. _Every_ package in debian has specific version, just like in almost every other distribution. /mjt

[Qemu-devel] Re: UPD: qemu-kvm 0.12.5 virtio-net page allocation error

2010-10-07 Thread Peter Lieven
Peter Lieven wrote: Am 03.10.2010 um 01:48 schrieb Peter Lieven: Hi, running 0.12.5 with a Ubuntu LTS 10.04.1 64-bit kernel I see the following error after a few days with severe load (constant 100-200mbps input). # uname -a Linux ubuntu-newsfeed 2.6.32-24-server #43-Ubuntu SMP Thu Sep

[Qemu-devel] Re: [PATCHv2] qemu-kvm/vhost: fix up irqfd support

2010-10-07 Thread Alex Williamson
On Thu, 2010-10-07 at 11:57 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 04:05:38PM -0600, Alex Williamson wrote: On Wed, 2010-10-06 at 23:44 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 11:24:24AM -0600, Alex Williamson wrote: You could always keep the functions

[Qemu-devel] [Bug 642304] Re: Solaris/x86 v10 hangs under KVM

2010-10-07 Thread Michael Tokarev
As I mentioned in email reply, _every_ package in almost every distribution (the ones I know anyway), Debian included, has a version number attached. The git commit ID (58aebb946acff82c62383f350cab593e55cc13dc) appears to be in qemu or qemu-kvm git tree (it's found on both), somewhere past

[Qemu-devel] Re: [PATCH 3/6] Add more error handling to strtosz()

2010-10-07 Thread Paolo Bonzini
On 10/07/2010 05:01 PM, jes.soren...@redhat.com wrote: +if (tmpval ~(size_t)0) Since -1 is an error, this needs to be =. Paolo

[Qemu-devel] [PATCH] configure: Send error message from spice check to /dev/null

2010-10-07 Thread Stefan Weil
pkg-config is not always available (e.g. on win32 hosts), but we don't want to see the 'command not found' error message. Redirect stdout and stderr to /dev/null. Cc: Gerd Hoffmann kra...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- configure |8 +++- 1 files changed,

[Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-07 Thread Paolo Bonzini
On 10/07/2010 05:01 PM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Signed-off-by: Jes Sorensenjes.soren...@redhat.com --- hmp-commands.hx |2 +- migration.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hmp-commands.hx

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-10-07 Thread Alex Williamson
Avi, Marcelo, Assuming this gets merged to qemu.git, you'll need the attached trivial updates for the qemu-kvm.git merge. Thanks, Alex On Wed, 2010-10-06 at 14:58 -0600, Alex Williamson wrote: Our code paths for saving or migrating a VM are full of functions that return void, leaving no

[Qemu-devel] [PATCH] win32: Set unbuffered stdout

2010-10-07 Thread Stefan Weil
Win32 does not support line-buffering, but it allows unbuffered output. Unbuffered output is a good approximation. For typical output statements which usually end with '\n', it's even identical. Buffered output is unusable for program traces because of its large delay. Cc: Blue Swirl

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)          env-gpr[3] = 0;          break;      case 39: /* video_ctrl */ -        if (env-gpr[6] == 0 || env-gpr[6] ==

Re: [Qemu-devel] Load primitive in linux-user/signal.c

2010-10-07 Thread Lluís
Mulyadi Santosa writes: I know nothing about your patch, but I suggest to rewrite this post so it follows patch submission format e.g comment, signed off then the patch itself :) No offense, ok? :) None taken. I've sent it again with (I suppose) the adequate format. Lluis -- And

[Qemu-devel] [PATCH] Use '_raw' memory access primitives.

2010-10-07 Thread Lluís
Using a pointer on the host should not go through lduw. Signed-off-by: Lluís xscr...@gmx.net --- linux-user/signal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 77683f7..097da9d 100644 --- a/linux-user/signal.c +++

Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 8:27 AM, malc av1...@comtv.ru wrote: On Thu, 7 Oct 2010, Paolo Bonzini wrote: On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-i386/op_helper.c: In function 'switch_tss':

[Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-i386/op_helper.c: In function 'switch_tss': /src/qemu/target-i386/op_helper.c:283:53: error: variable

Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable

2010-10-07 Thread malc
On Thu, 7 Oct 2010, Blue Swirl wrote: On Thu, Oct 7, 2010 at 8:27 AM, malc av1...@comtv.ru wrote: On Thu, 7 Oct 2010, Paolo Bonzini wrote: On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-i386/op_helper.c: In function

Re: [Qemu-devel] [PATCH 03/11] eepro100: initialize a variable in all cases

2010-10-07 Thread Stefan Weil
Am 07.10.2010 11:31, schrieb Markus Armbruster: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/hw/eepro100.c: In function 'eepro100_read4': /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function

Re: [Qemu-devel] [PATCH 03/11] eepro100: initialize a variable in all cases

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 9:31 AM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/hw/eepro100.c: In function 'eepro100_read4': /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used

Re: [Qemu-devel] [PATCH 07/11] cris: avoid write only variables

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 11:07 AM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Thu, Oct 07, 2010 at 12:08:05PM +0200, Markus Armbruster wrote: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-cris/op_helper.c: In function

Re: [Qemu-devel] [PATCH 2/5] spice: make compression configurable.

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 7:55 AM, Gerd Hoffmann kra...@redhat.com wrote: From: Yonit Halperin yhalp...@redhat.com No description? ---  qemu-config.c   |    9 ++  qemu-options.hx |    9 ++  ui/spice-core.c |   77 +-  3 files

[Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 7:23 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/06/2010 11:33 PM, Blue Swirl wrote: +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)          } else if (strncmp(options, acl, 3) == 0) {              acl = 1; +#endif Not sure it's okay to reject the

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 08/03/2010 03:14 PM, Christian Brunner wrote: +#include qemu-common.h +#include qemu-error.h +#includesys/types.h +#includestdbool.h + +#includeqemu-common.h This looks to be unnecessary.  Generally, system

Re: [Qemu-devel] [PATCH 01/11] block: avoid a write only variable

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 11:55 AM, Kevin Wolf kw...@redhat.com wrote: Am 07.10.2010 11:37, schrieb Markus Armbruster: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/block/qcow2-refcount.c: In function 'update_refcount':

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Anthony Liguori
On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguorianth...@codemonkey.ws wrote: On 08/03/2010 03:14 PM, Christian Brunner wrote: +#include qemu-common.h +#include qemu-error.h +#includesys/types.h +#includestdbool.h +

Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster arm...@redhat.com wrote: Paolo Bonzini pbonz...@redhat.com writes: On 10/06/2010 11:32 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':

Re: [Qemu-devel] [PATCH 3/5] spice: add config options for channel security.

2010-10-07 Thread Stefan Weil
Am 07.10.2010 09:55, schrieb Gerd Hoffmann: This allows to enforce tls or plaintext usage for certain spice channels. --- qemu-config.c |6 ++ qemu-options.hx |8 ui/spice-core.c | 25 + 3 files changed, 39 insertions(+), 0 deletions(-) diff

[Qemu-devel] [STATUS] static instrumentation

2010-10-07 Thread Lluís
All virtual memory accesses should now be instrumented on all architectures. Next steps (in order): * Separately instrument physical memory addresses for executed instructions, regular memory accesses and memory accesses to I/O space (if possible). This will need to add an extra field

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 11:38 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguorianth...@codemonkey.ws  wrote: On 08/03/2010 03:14 PM, Christian Brunner wrote: +#include qemu-common.h

[Qemu-devel] Re: [PATCH] configure: Send error message from spice check to /dev/null

2010-10-07 Thread Stefan Weil
Am 07.10.2010 21:05, schrieb Gerd Hoffmann: On 10/07/10 17:58, Stefan Weil wrote: pkg-config is not always available (e.g. on win32 hosts), but we don't want to see the 'command not found' error message. compile_object() { + echoconfig.log + cat $TMPCconfig.log + echoconfig.log This

[Qemu-devel] [PATCH v2] configure: Send error message from spice check to /dev/null

2010-10-07 Thread Stefan Weil
pkg-config is not always available (e.g. on win32 hosts), but we don't want to see the 'command not found' error message. Redirect stdout and stderr to /dev/null. v2: * Removed changes which should not have been here. Cc: Gerd Hoffmann kra...@redhat.com Signed-off-by: Stefan Weil

Re: [Qemu-devel] [STATUS] static instrumentation

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 6:40 PM, Lluís xscr...@gmx.net wrote: All virtual memory accesses should now be instrumented on all architectures. Next steps (in order):  * Separately instrument physical memory addresses for executed    instructions, regular memory accesses and memory accesses to

[Qemu-devel] Re: [PATCH] configure: Send error message from spice check to /dev/null

2010-10-07 Thread Gerd Hoffmann
On 10/07/10 17:58, Stefan Weil wrote: pkg-config is not always available (e.g. on win32 hosts), but we don't want to see the 'command not found' error message. compile_object() { + echoconfig.log + cat $TMPCconfig.log + echoconfig.log This looks unrelated. @@ -28,6 +31,9 @@

[Qemu-devel] Re: [PATCH 10/11] ppc: avoid write only variables

2010-10-07 Thread Blue Swirl
On Wed, Oct 6, 2010 at 9:39 PM, Alexander Graf ag...@suse.de wrote: On 06.10.2010, at 23:34, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi': /src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set

Re: [Qemu-devel] [PATCH 2/5] spice: make compression configurable.

2010-10-07 Thread Gerd Hoffmann
On 10/07/10 20:12, Blue Swirl wrote: On Thu, Oct 7, 2010 at 7:55 AM, Gerd Hoffmannkra...@redhat.com wrote: From: Yonit Halperinyhalp...@redhat.com No description? Detailed description comes here: --- a/qemu-options.hx +++ b/qemu-options.hx @@ -704,6 +704,15 @@ The x509 file names can

Re: [Qemu-devel] [PATCH 3/5] spice: add config options for channel security.

2010-10-07 Thread Gerd Hoffmann
+ if (strcmp(name, tls-channel) == 0) + security = SPICE_CHANNEL_SECURITY_SSL; CODING_STYLE (if (...) { ... })? Same in next lines. Oops. Slipped through, will fix. thanks, Gerd

[Qemu-devel] [ANNOUNCE] Git User's Survey 2010 is now up!

2010-10-07 Thread Stefan Weil
This might be interesting for users of qemu-devel, too... Original-Nachricht Betreff:[ANNOUNCE] Git User's Survey 2010 is now up! Datum: Thu, 30 Sep 2010 01:20:21 +0200 Von:Jakub Narebski jna...@gmail.com An: Undisclosed.Recipients: ; Hello all, This

Re: [Qemu-devel] [PATCH 07/11] cris: avoid write only variables

2010-10-07 Thread Edgar E. Iglesias
On Thu, Oct 07, 2010 at 05:57:30PM +, Blue Swirl wrote: On Thu, Oct 7, 2010 at 11:07 AM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Thu, Oct 07, 2010 at 12:08:05PM +0200, Markus Armbruster wrote: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Anthony Liguori
On 10/07/2010 01:41 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 11:38 AM, Anthony Liguorianth...@codemonkey.ws wrote: On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguorianth...@codemonkey.ws wrote: On

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-10-07 Thread Anthony Liguori
On 10/07/2010 06:15 AM, Gerd Hoffmann wrote: This patch adds support for expiring passwords to vnc. It adds a new lifetime parameter to the vnc_display_password() function, which specifies the number of seconds the new password will be valid. Passing zero as lifetime maintains current behavior

Re: [Qemu-devel] [PATCH 0/2] USB CCID device

2010-10-07 Thread Anthony Liguori
On 10/07/2010 02:39 AM, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: On 10/06/2010 03:55 AM, Gerd Hoffmann wrote: On 10/06/10 02:28, Alon Levy wrote: Does this work with live migration? I can't see how it would. No, it doesn't

Re: [Qemu-devel] [PATCH 0/2] USB CCID device

2010-10-07 Thread Anthony Liguori
On 10/06/2010 05:12 PM, Alon Levy wrote: Actually, both are possible - but the later is the interesting use case (the former is mainly for debugging). To elaborate: the device is meant to allow a hardware reader to be available to the guest while still being available to the client (which is

[Qemu-devel] Re: [PATCH 10/11] ppc: avoid write only variables

2010-10-07 Thread Alexander Graf
Am 07.10.2010 um 20:59 schrieb Blue Swirl blauwir...@gmail.com: On Wed, Oct 6, 2010 at 9:39 PM, Alexander Graf ag...@suse.de wrote: On 06.10.2010, at 23:34, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':

Re: [Qemu-devel] [STATUS] static instrumentation

2010-10-07 Thread Lluís
Blue Swirl writes: The patches there seem to be fixes or small changes to your other patches. This makes any review very difficult. Sorry, I'm really new to git, so I don't really know how to maintain and grow an organized set of patches for review while I keep improving the work. But I'm

[Qemu-devel] [PATCH 2/2] check for close() errors on qcow2_create()

2010-10-07 Thread Eduardo Habkost
Errors when closing the file we just created should not be ignored. I/O errors may happen and qemu-img create should fail in those cases. If we are already exiting due to an error, we will still return the original error number, though. Signed-off-by: Eduardo Habkost ehabk...@redhat.com ---

[Qemu-devel] [PATCH 0/2] qcow2_create() error handling fixes

2010-10-07 Thread Eduardo Habkost
From: Eduardo Habkost ehabk...@raisama.net Hi, Here are two small fixes on qcow2_create() error handling. Eduardo Habkost (2): fix fd leak on a qcow2_create2() error path check for close() errors on qcow2_create() block/qcow2.c | 11 --- 1 files changed, 8 insertions(+), 3

[Qemu-devel] [PATCH 1/2] fix fd leak on one qcow2_create2() error path

2010-10-07 Thread Eduardo Habkost
When getting an invalid cluster size, the open fd must be closed before qcow2_create() returns an error. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- block/qcow2.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 12:51 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 01:41 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 11:38 AM, Anthony Liguorianth...@codemonkey.ws  wrote: On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Anthony Liguori
On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote: How is that possible? Are the callbacks delivered in the context of a different thread? If so, don't you need locking? Not sure I'm completely following you. The callbacks are delivered in the context of a different thread, but won't

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 2:04 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote: How is that possible?  Are the callbacks delivered in the context of a different thread?  If so, don't you need locking? Not sure I'm completely following you.

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Anthony Liguori
On 10/07/2010 04:49 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 2:04 PM, Anthony Liguorianth...@codemonkey.ws wrote: On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote: How is that possible? Are the callbacks delivered in the context of a different thread? If so,

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Sage Weil
On Thu, 7 Oct 2010, Anthony Liguori wrote: On 10/07/2010 04:49 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 2:04 PM, Anthony Liguorianth...@codemonkey.ws wrote: On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote: How is that possible? Are the callbacks

Re: [Qemu-devel] fix unsigned comparison warning in TCG

2010-10-07 Thread Venkateswararao Jujjuri (JV)
On 9/26/2010 11:33 AM, Blue Swirl wrote: On Sun, Sep 26, 2010 at 5:40 PM, Hollis Blanchard hol...@penguinppc.org wrote: TCGOpcode is an enum, which apparently can be unsigned. Signed-off-by: Hollis Blanchard hol...@penguinppc.org --- % ./configure --target-list=ppcemb-softmmu

[Qemu-devel] segmentation fault running ppc linux user regression test

2010-10-07 Thread Suet Fei Li
Hi guys: I am very new to qemu and not sure which place to go for help. So if this is not the proper forum, please point me to the appreciate one, if available. I just downloaded the newest qemu version: qemu-0.12.5 and build the ppc-linux-user. To test it, I also downloaded the

[Qemu-devel] Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-07 Thread Huang Ying
On Thu, 2010-10-07 at 00:05 +0800, Marcelo Tosatti wrote: On Wed, Oct 06, 2010 at 10:58:36AM +0900, Hidetoshi Seto wrote: I got some more question: (2010/10/05 3:54), Marcelo Tosatti wrote: Index: qemu/target-i386/cpu.h

[Qemu-devel] Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-07 Thread Huang Ying
Hi, Seto, On Thu, 2010-10-07 at 11:41 +0800, Hidetoshi Seto wrote: (2010/10/07 3:10), Dean Nelson wrote: On 10/06/2010 11:05 AM, Marcelo Tosatti wrote: On Wed, Oct 06, 2010 at 10:58:36AM +0900, Hidetoshi Seto wrote: I got some more question: (2010/10/05 3:54), Marcelo Tosatti wrote:

[Qemu-devel] Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-07 Thread Hidetoshi Seto
Hi, Huang-san, (2010/10/08 12:15), Huang Ying wrote: Hi, Seto, On Thu, 2010-10-07 at 11:41 +0800, Hidetoshi Seto wrote: (2010/10/07 3:10), Dean Nelson wrote: On 10/06/2010 11:05 AM, Marcelo Tosatti wrote: On Wed, Oct 06, 2010 at 10:58:36AM +0900, Hidetoshi Seto wrote: I got some more

Re: [Qemu-devel] [PATCH 0/2] USB CCID device

2010-10-07 Thread Gerd Hoffmann
On 10/06/10 21:00, Anthony Liguori wrote: Better yet, mark the guest as unmigrateable and let the management tool unplug the usb device before migration and replug it after migration. Yep, that will work too. cheers, Gerd

[Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:33 PM, Blue Swirl wrote: +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL) } else if (strncmp(options, acl, 3) == 0) { acl = 1; +#endif Not sure it's okay to reject the option altogether (i.e. maybe the #if should only include acl = 1. Paolo

[Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:32 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable] Fix by making the variable

[Qemu-devel] Re: [PATCH 00/11] GCC 4.6.0 fixes

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:31 PM, Blue Swirl wrote: Blue Swirl (11): block: avoid a write only variable cirrus: avoid write only variables eepro100: initialize a variable in all cases lsi53c895a: avoid a write only variable Delete write only variables mips_fulong2e: Delete write only

[Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a lot of warnings like: /src/qemu/target-mips/translate.c: In function 'gen_ld': /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used [-Werror=unused-but-set-variable] Fix by making

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) env-gpr[3] = 0; break; case 39: /* video_ctrl */ -if (env-gpr[6] == 0 || env-gpr[6] == 1) -vga_vbl_enabled = env-gpr[6]; env-gpr[3] = 0;

[Qemu-devel] [PATCH 0/5] spice config options

2010-10-07 Thread Gerd Hoffmann
Hi, This patch series adds a bunch of config options to spice, most notably it enables to configure TLS and thus using spice encrypted. The commit messages are not that verbose, but every patch comes with a patch chunk updating the spice section in the documentation. Please look there when

[Qemu-devel] [PATCH 4/5] spice: add config options for the listening address

2010-10-07 Thread Gerd Hoffmann
Make listening address configurable. Also add options to force using IPv4 or IPv6. --- qemu-config.c |9 + qemu-options.hx |7 +++ ui/spice-core.c | 13 +++-- 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index

[Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-i386/op_helper.c: In function 'switch_tss': /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used [-Werror=unused-but-set-variable] Fix by deleting the

[Qemu-devel] [PATCH 2/5] spice: make compression configurable.

2010-10-07 Thread Gerd Hoffmann
From: Yonit Halperin yhalp...@redhat.com --- qemu-config.c |9 ++ qemu-options.hx |9 ++ ui/spice-core.c | 77 +- 3 files changed, 93 insertions(+), 2 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index

[Qemu-devel] [PATCH 5/5] spice: add misc config options

2010-10-07 Thread Gerd Hoffmann
This patch adds a few more options to tweak spice server behavior. The documentation update chunk has the details ;) --- qemu-config.c |9 + qemu-options.hx |9 + ui/spice-core.c | 29 - 3 files changed, 46 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 1/5] spice: tls support

2010-10-07 Thread Gerd Hoffmann
Add options to the -spice command line switch to setup tls. --- qemu-config.c | 24 +++ qemu-options.hx | 18 ++- ui/spice-core.c | 67 +++--- 3 files changed, 104 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] USB CCID device

2010-10-07 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/06/2010 03:55 AM, Gerd Hoffmann wrote: On 10/06/10 02:28, Alon Levy wrote: Does this work with live migration? I can't see how it would. No, it doesn't right now. It would require cooperation with the client, to tell it

[Qemu-devel] [PATCH 3/5] spice: add config options for channel security.

2010-10-07 Thread Gerd Hoffmann
This allows to enforce tls or plaintext usage for certain spice channels. --- qemu-config.c |6 ++ qemu-options.hx |8 ui/spice-core.c | 25 + 3 files changed, 39 insertions(+), 0 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-07 Thread Roedel, Joerg
On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version = machine-compat_version; + if (display_type == DT_NOGRAPHIC) { if (default_parallel) add_device_config(DEV_PARALLEL, null); -- 1.7.0.4 Looks fine to me,

Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable

2010-10-07 Thread malc
On Thu, 7 Oct 2010, Paolo Bonzini wrote: On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-i386/op_helper.c: In function 'switch_tss': /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used

[Qemu-devel] [Bug 642304] Re: Solaris/x86 v10 hangs under KVM

2010-10-07 Thread Jes Sorensen
Your bug report doesn't tell us anything about the host system (AMD, Intel, which CPU model etc), nor which version of KVM you are running, which distro etc? Did it work with older versions of qemu-kvm? Which version of Solaris/x86 (pointer to version preferably) Please provide appropriate

Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 10/06/2010 11:32 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used

Re: [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add

2010-10-07 Thread Jes Sorensen
On 10/05/10 02:23, Vincent Minet wrote: Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an infinite loop in acpi_table_add. Signed-off-by: Vincent Minet vinc...@vincent-minet.net --- hw/acpi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) OUCH! Good

[Qemu-devel] [Bug 643465] Re: Crash at network boot

2010-10-07 Thread Jes Sorensen
Hi, The backtrace shows it crashes in lsi_update_irq() which is in the SCSI emulation, not the networking code. Please try and see if this happens if you use IDE or virtio-blk for your disk drives. Second, please provide proper information about your software stack: - kernel version - qemu-kvm

Re: [Qemu-devel] [PATCH 01/11] block: avoid a write only variable

2010-10-07 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/block/qcow2-refcount.c: In function 'update_refcount': /src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable] Fix by adding a

Re: [Qemu-devel] [PATCH 03/11] eepro100: initialize a variable in all cases

2010-10-07 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/hw/eepro100.c: In function 'eepro100_read4': /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized] /src/qemu/hw/eepro100.c: In

Re: [Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2010-10-07 Thread Michal Suchanek
On 7 October 2010 11:05, Jes Sorensen 639...@bugs.launchpad.net wrote: Just to be sure, you are not using the virtio-blk driver for Windows here? I have seen similar crashes with the older version of virtio-blk when used on recent versions of KVM. -- DRIVER_IRQL_NOT_LESS_OR_EQUAL booting

[Qemu-devel] [Bug 655555] Re: -cpu ? doesn't work as documented

2010-10-07 Thread Jes Sorensen
Seems like this isn't a bug after all, so closing. If you want to add a note to the manual, that is cool, but please submit a patch, otherwise I doubt it will get addressed. It should also be a more generic note since it would apply to all arguments that accept ? Cheers, Jes ** Changed in:

Re: [Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2010-10-07 Thread Jes Sorensen
On 10/07/10 11:51, Michal Suchanek wrote: Actually the issue is caused by the Synaptics touchpad driver binding to the PS/2 mouse device in qemu. I have no idea how PS/2 devices are detected but the one present in qemu is misdetected as a synaptics touchapd by the Synaptics driver for

[Qemu-devel] [Bug 586420] Re: WinXP install cd hangs at boot time if machine started with floppy

2010-10-07 Thread Jes Sorensen
Closing per tekditt's posting on 2010-07-22 ** Changed in: qemu Status: Incomplete = Fix Committed -- WinXP install cd hangs at boot time if machine started with floppy https://bugs.launchpad.net/bugs/586420 You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] Re: [PATCHv2] qemu-kvm/vhost: fix up irqfd support

2010-10-07 Thread Michael S. Tsirkin
On Wed, Oct 06, 2010 at 04:05:38PM -0600, Alex Williamson wrote: On Wed, 2010-10-06 at 23:44 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 11:24:24AM -0600, Alex Williamson wrote: You could always keep the functions as separate wrapper callers of the common function so you only

Re: [Qemu-devel] [PATCH 07/11] cris: avoid write only variables

2010-10-07 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-cris/op_helper.c: In function 'helper_movl_sreg_reg': /src/qemu/target-cris/op_helper.c:145:8: error: variable 'tlb_v' set but not used [-Werror=unused-but-set-variable] In file

Re: [Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2010-10-07 Thread Michal Suchanek
I have no idea how to log the data. I looked at the qemu man page but it does not even mention the PS/2 mouse as a chardev nor offers an option to log traffic of chardevs without attaching them to a file and thus detaching them from the emulated device. Thanks Michal --

[Qemu-devel] Re: [PATCH] lsi53c895a: Add support for OS/2 Warp SYM8XX.ADD driver

2010-10-07 Thread Kevin Wolf
Am 30.09.2010 07:07, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings Paul, Jan, Kevin and co, This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer SGL passthrough from Gerd Hoffman, 8708EM2 MegaSas emulation from Dr. Hannes

Re: [Qemu-devel] [PATCH 07/11] cris: avoid write only variables

2010-10-07 Thread Edgar E. Iglesias
On Thu, Oct 07, 2010 at 12:08:05PM +0200, Markus Armbruster wrote: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-cris/op_helper.c: In function 'helper_movl_sreg_reg': /src/qemu/target-cris/op_helper.c:145:8: error: variable

[Qemu-devel] [PATCH] .gitignore: Ignore *-timestamp

2010-10-07 Thread Stefan Hajnoczi
Timestamp files were recently added to reduce make churn on source files that use tracing. The timestamp files should never be committed and should not be visible in git status. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- .gitignore |1 + 1 files changed, 1 insertions(+),

[Qemu-devel] [PATCH 1/3] vnc: auth reject cleanup

2010-10-07 Thread Gerd Hoffmann
protocol_client_auth_vnc() has two places where the auth can fail, with identical code sending the reject message to the client. Move the common code to the end of the function and make both error paths jump there. No functional change. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 0/3] vnc/spice: add monitor command to change password.

2010-10-07 Thread Gerd Hoffmann
Hi, This patch series adds a new monitor command to set the password with optional expiry time for spice and vnc remote desktop connections. The patches are also available in the git repository at: git://anongit.freedesktop.org/spice/qemu passwd.1 Gerd Hoffmann (3): vnc: auth reject

[Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-10-07 Thread Gerd Hoffmann
This patch adds support for expiring passwords to vnc. It adds a new lifetime parameter to the vnc_display_password() function, which specifies the number of seconds the new password will be valid. Passing zero as lifetime maintains current behavior (password never expires). Signed-off-by: Gerd

[Qemu-devel] [PATCH 3/3] vnc/spice: add set_passwd monitor command.

2010-10-07 Thread Gerd Hoffmann
This patch adds a new set_password monitor command which allows to change the password for spice and vnc connections. See the doc update patch chunk for details. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 23 + monitor.c | 58

[Qemu-devel] Re: [PATCH] lsi53c895a: add support for ABORT messages

2010-10-07 Thread Kevin Wolf
Am 06.09.2010 16:42, schrieb Bernhard Kohl: If these messages are not handled correctly the guest driver may hang. Always mandatory: - ABORT - BUS DEVICE RESET Mandatory if tagged queuing is implemented (which disks usually do): - ABORT TAG - CLEAR QUEUE Signed-off-by: Bernhard Kohl

[Qemu-devel] [Bug 643465] Re: Crash at network boot

2010-10-07 Thread BRULE Herman
Whan I put vga card it work perfectly. I have only the bug with wmware card and particulare version of linux - vanilla 2.6.32.22 - 0.12.5-r1 - gentoo - core i5 750 Guest: - gentoo kernel (based on vanilla kernel 2.6.32.16) - VMware SVGA video driver 11.0.1 - network boot via pxe and squashfs +

Re: [Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2010-10-07 Thread Jes Sorensen
On 10/07/10 12:17, Michal Suchanek wrote: I have no idea how to log the data. I looked at the qemu man page but it does not even mention the PS/2 mouse as a chardev nor offers an option to log traffic of chardevs without attaching them to a file and thus detaching them from the emulated

Re: [Qemu-devel] [PATCH 01/11] block: avoid a write only variable

2010-10-07 Thread Kevin Wolf
Am 07.10.2010 11:37, schrieb Markus Armbruster: Blue Swirl blauwir...@gmail.com writes: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/block/qcow2-refcount.c: In function 'update_refcount': /src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Kevin Wolf
Am 23.09.2010 04:21, schrieb Yehuda Sadeh Weinraub: Following up on this one, I'd like to know whether there is any pending issue preventing rbd from being included upstream. Basically for me the only problem at the moment is a lack of reviews. If nobody else picks it up, I'll get to it

Re: [Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables

2010-10-07 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 10/06/2010 11:33 PM, Blue Swirl wrote: +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL) } else if (strncmp(options, acl, 3) == 0) { acl = 1; +#endif Not sure it's okay to reject the option altogether (i.e. maybe

Re: [Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables

2010-10-07 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 10/06/2010 11:34 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a lot of warnings like: /src/qemu/target-mips/translate.c: In function 'gen_ld': /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used

Re: [Qemu-devel] Re: [PATCH 10/11] ppc: avoid write only variables

2010-10-07 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: On 06.10.2010, at 23:34, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi': /src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but not used

  1   2   >