[Qemu-devel] Re: TODO item: guest programmable mac/vlan filtering with macvtap

2010-10-15 Thread Michael S. Tsirkin
On Thu, Oct 14, 2010 at 11:40:52PM +0200, Dragos Tatulea wrote: Hi, I'm starting a thread related to the TODO item mentioned in the subject. Currently still gathering info and trying to make kvm macvtap play nicely together. I have used this [1] guide to set it up but qemu is still

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-15 Thread Stefan Hajnoczi
On Thu, Oct 14, 2010 at 5:16 PM, Avi Kivity a...@redhat.com wrote:  On 10/14/2010 11:15 AM, Stefan Hajnoczi wrote: I forgot to add that the semantics of cancellation make it difficult to write correct user code.  Every cancellation user needs to add extra synchronization after the cancel call

[Qemu-devel] Re: [PATCH] vga: Mark VBE area as reserved in e820 tables

2010-10-15 Thread Gerd Hoffmann
On 10/14/10 20:36, Alex Williamson wrote: Otherwise the guest might try to use the range for device hotplug. Arrgh. /me tries to kill vga_init_vbe() usage for everything (but isa-vga) for *months* now. I want to zap the magic framebuffer @ VBE_DISPI_LFB_PHYSICAL_ADDRESS instead of

Re: [Qemu-devel] Hitting 29 NIC limit

2010-10-15 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 10/14/2010 07:36 AM, Markus Armbruster wrote: Avi Kivitya...@redhat.com writes: On 10/14/2010 12:54 AM, Anthony Liguori wrote: On 10/13/2010 05:32 PM, Anjali Kulkarni wrote: Hi, Using the legacy way of starting up

[Qemu-devel] [PATCH 1/2] spice-core: fix watching for write events

2010-10-15 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 8b5e4a8..3fcbeca 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@

[Qemu-devel] [PATCH 0/2] spice fixes.

2010-10-15 Thread Gerd Hoffmann
Hi, This patch series brings two bug fixes for spice. The patches are also available in the git repository at: git://anongit.freedesktop.org/spice/qemu bugfix.1 please pull, Gerd Gerd Hoffmann (1): spice display: replace private lock with qemu mutex. Hans de Goede (1): spice-core:

[Qemu-devel] Re: [Tracing][RFC v2 PATCH 1/2] Introduce 'query-trace' 'query-trace-events' interfaces

2010-10-15 Thread Stefan Hajnoczi
On Fri, Oct 15, 2010 at 10:10:10AM +0530, Prerna Saxena wrote: [PATCH 1/2] Introduce QMP interfaces : query-trace query-trace-events Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- monitor.c | 46 +--- simpletrace.c | 58

[Qemu-devel] [PATCH 2/2] spice display: replace private lock with qemu mutex.

2010-10-15 Thread Gerd Hoffmann
qemu_spice_create_update() must aquire the global qemu mutex to make sure DisplayState doesn't change while we are accessing it. Once this is in place the private lock is pretty pointless as everything it protects is covered by the global qemu mutex now. Drop it. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-15 Thread Stefan Hajnoczi
On Thu, Oct 14, 2010 at 10:17 PM, Venkateswararao Jujjuri (JV) jv...@linux.vnet.ibm.com wrote: On 10/14/2010 2:02 AM, Stefan Hajnoczi wrote: On Wed, Oct 13, 2010 at 4:31 PM, Arun R Bharadwaj +static void *threadlet_worker(void *data) +{ +    ThreadletQueue *queue = data; + +    

[Qemu-devel] [PATCH v2 3/4] switch vmware_vga to pci vgabios

2010-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vmware_vga.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 3d25c14..9337fdb 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_vga.c @@ -114,14 +114,12 @@ struct

[Qemu-devel] [PATCH v2 1/4] Add new vgabios binaries to blobs list.

2010-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 252c817..2aa69ff 100644 --- a/Makefile +++ b/Makefile @@ -175,8 +175,9 @@ ar de en-us fi fr-be hr it lv nl

[Qemu-devel] [PATCH v2 2/4] switch stdvga to pci vgabios

2010-10-15 Thread Gerd Hoffmann
Make stdvga provide the new vgabios binary (with pcibios support) using the PCI option rom bar. Seabios will happily load it from there. The new vga bios will also lookup the framebuffer address in pci config space, so the magic bochs lfb @ 0xe000 is not needed any more - zap it. Without

[Qemu-devel] [PATCH v2 4/4] more stdvga cleanups.

2010-10-15 Thread Gerd Hoffmann
video.x is gone now. It was the only user of the vga bios_offset + bios_size logic. Zap it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc.c |2 +- hw/pc.h |3 +-- hw/ppc_newworld.c |2 +- hw/ppc_oldworld.c |2 +- hw/ppc_prep.c |2 +-

[Qemu-devel] [PATCH v2 0/4] use new vgabios.

2010-10-15 Thread Gerd Hoffmann
This patch series will put the new vgabios into use for stdvga and vmware_vga. The vgabios patches have been posted a while ago, they are also also available from git://anongit.freedesktop.org/~kraxel/vgabios pcibios For obvious reasons it depends on the new vgabios binaries being present,

[Qemu-devel] Re: [PATCH v2] pc: e820 qemu_cfg tables need to be packed

2010-10-15 Thread Arnd Bergmann
On Friday 15 October 2010, Alex Williamson wrote: We can't let the compiler define the alignment for qemu_cfg data. Signed-off-by: Alex Williamson alex.william...@redhat.com --- v2: Adjust alignment to help non-x86 hosts per Arnd's suggestion Ok, looks good now. Thanks! Arnd

Re: [Qemu-devel] Re: [PATCH 07/11] kvm, x86: unify sigbus handling, prep

2010-10-15 Thread Marcelo Tosatti
On Fri, Oct 15, 2010 at 10:29:25AM +0900, Hidetoshi Seto wrote: (2010/10/15 9:36), Marcelo Tosatti wrote: On Thu, Oct 14, 2010 at 05:49:43PM +0900, Jin Dongming wrote: There are 2 similar functions to handle SIGBUS: sigbus_handler(int n, struct qemu_signalfd_siginfo *siginfo,

Re: [Qemu-devel] Re: [PATCH 11/11] kvm, x86: broadcast mce depending on the cpu version

2010-10-15 Thread Marcelo Tosatti
On Fri, Oct 15, 2010 at 10:52:05AM +0900, Hidetoshi Seto wrote: (2010/10/15 10:06), Marcelo Tosatti wrote: On Thu, Oct 14, 2010 at 05:55:28PM +0900, Jin Dongming wrote: There is no reason why SRAO event received by the main thread is the only one that being broadcasted. According to the

[Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com TRUE/FALSE are generally reserved keywords and shouldn't be defined in a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE respectively. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/bt-sdp.c | 20 ++-- 1

[Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 21 + os-win32.c | 24 osdep.c| 38 -- 3 files changed, 45 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH 2/9] Move osdep socket code to os-{posix, win32}-lib.c

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix-lib.c | 15 +++ os-win32-lib.c | 21 + osdep.c| 38 -- 3 files changed, 36 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to os-posix-lib.c

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix-lib.c | 22 ++ osdep.c| 22 -- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/os-posix-lib.c b/os-posix-lib.c index

[Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves library functions used by both QEMU and the QEMU tools, such as qemu-img, qemu-nbd etc. from osdep.c to os-{posix,win32}-lib.c In addition it introduces oslib-obj.y to the Makefile set to be included by the various targets, instead of relying

[Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com In addition add sysemu.h includes to file requiring a prototype for ffs() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/bt-sdp.c|1 + os-win32-lib.c | 27 +++ osdep.c| 31

[Qemu-devel] [PATCH 0/9] Re-factor osdep code + macro and brace fixes

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, Here is another set of patches which tries to split up osdep.c further into posix and win32 versions. It introduces os-{posix,win32}-lib.c files which are used for functions that are OS specific core library functionality, like gettimeofday(), and

[Qemu-devel] [PATCH 9/9] Remove unncessary includes

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com No need to include stdlib.h for BSD as it is included by qemu-common.h, windows.h is handled by sysemu.h and osdep.c no longer needs malloc.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- osdep.c |8 1 files changed, 0

[Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 32 osdep.c| 34 -- 2 files changed, 32 insertions(+), 34 deletions(-) diff --git a/os-posix.c b/os-posix.c

[Qemu-devel] [PATCH 1/1] Fold send_all() wrapper unix_write() into one function

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The current send_all() wrapper for POSIX calls does nothing but call unix_write(). Merge them to simplify the code. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-char.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-)

[Qemu-devel] Re: [PATCH 1/3] Introduce threadlets

2010-10-15 Thread Paolo Bonzini
On 10/14/2010 11:02 AM, Stefan Hajnoczi wrote: 2. Moving qemu_cond_signal() outside queue-lock is dangerous for the same reason: you need to be careful not to qemu_cond_signal() when the thread isn't inside qemu_cond_timedwait(). Yes, please do so. I personally consider it bad programming

[Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions

2010-10-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This consolidates the duplicated oom_check() functions, as well as splitting them into OS dependant versions to avoid the #ifdef grossness that was present in the old osdep.c version. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[Qemu-devel] Re: [PATCH] vga: Mark VBE area as reserved in e820 tables

2010-10-15 Thread Alex Williamson
On Fri, 2010-10-15 at 10:22 +0200, Gerd Hoffmann wrote: On 10/14/10 20:36, Alex Williamson wrote: Otherwise the guest might try to use the range for device hotplug. Arrgh. /me tries to kill vga_init_vbe() usage for everything (but isa-vga) for *months* now. I want to zap the magic

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-15 Thread Venkateswararao Jujjuri (JV)
On 10/15/2010 2:52 AM, Stefan Hajnoczi wrote: On Thu, Oct 14, 2010 at 10:17 PM, Venkateswararao Jujjuri (JV) jv...@linux.vnet.ibm.com wrote: On 10/14/2010 2:02 AM, Stefan Hajnoczi wrote: On Wed, Oct 13, 2010 at 4:31 PM, Arun R Bharadwaj +static void *threadlet_worker(void *data) +{ +

[Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file

2010-10-15 Thread Christoph Hellwig
On Thu, Oct 14, 2010 at 03:01:18PM +0200, Kevin Wolf wrote: Additionally to testing the qemu-img convert -B option, also test -o backing_file. Also, the old test acidentlly used a pattern of zeros for most of the writes, so that the allocation test didn't really work out. This is fixed by

[Qemu-devel] Re: [PATCH 1/2][qemu-iotests] add sub-cluster allocating write test for sparse image formats

2010-10-15 Thread Christoph Hellwig
Thanks, I've applied both patches. Btw, do you have any plans to add qed support to qemu-iotests?

[Qemu-devel] weird mouse troubles in latest git

2010-10-15 Thread Brian Wheeler
I'm trying to run openstep 2.4 on the latest git and the mouse hangs after a few seconds of running. I turned on debugging some debugging flags: ps2.c: DEBUG_MOUSE pckbd.c: DEBUG_KEYBOARD i8259.c: DEBUG_PIC I'm still not sure where the problem is, but here's what I've discovered: If I filter

[Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file

2010-10-15 Thread Christoph Hellwig
On Fri, Oct 15, 2010 at 05:56:03PM +0200, Kevin Wolf wrote: Didn't I send a patch for qemu-iotests, too? I do have local commit updating this at least. If you have it around please just resend it.

[Qemu-devel] [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file

2010-10-15 Thread Kevin Wolf
Additionally to testing the qemu-img convert -B option, also test -o backing_file. Also, the old test acidentlly used a pattern of zeros for most of the writes, so that the allocation test didn't really work out. This is fixed by using an explicit pattern. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH] qemu-iotests: Update expected results after qemu-img changes

2010-10-15 Thread Kevin Wolf
The error message for leaked clusters has changed. qemu-iotests needs to be updated to pass 026 again. Signed-off-by: Kevin Wolf kw...@redhat.com --- 026.out | 120 +++ 1 files changed, 90 insertions(+), 30 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-15 Thread Paolo Bonzini
On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: +typedef struct timeval qemu_timeval; +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL); Argh, trailing semicolon. Please remove it or use an inline function. Paolo

[Qemu-devel] Re: [PATCH 0/9] Re-factor osdep code + macro and brace fixes

2010-10-15 Thread Paolo Bonzini
On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Hi, Here is another set of patches which tries to split up osdep.c further into posix and win32 versions. It introduces os-{posix,win32}-lib.c files which are used for functions that are OS

Re: [Qemu-devel] Re: [PATCH 1/2][qemu-iotests] add sub-cluster allocating write test for sparse image formats

2010-10-15 Thread Stefan Hajnoczi
On Fri, Oct 15, 2010 at 4:00 PM, Christoph Hellwig h...@lst.de wrote: Thanks, I've applied both patches. Btw, do you have any plans to add qed support to qemu-iotests? Yes, I have a qemu-iotests qed branch here: http://repo.or.cz/w/qemu-iotests/stefanha.git/shortlog/refs/heads/qed I'm going

[Qemu-devel] QEMU host support

2010-10-15 Thread Jes Sorensen
Hi, Looking through some code in qemu-char.c I was wondering if we support any other QEMU host target than Win32 which isn't covered by these defines: #if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \ || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__)

Re: [Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-15 Thread Blue Swirl
On Fri, Oct 15, 2010 at 1:33 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/14/2010 07:59 PM, Blue Swirl wrote: It is even more hypothetical when empty-format printfs are optimized away by GCC: $ gcc -x c - -O2 -S -o - #includestdio.h main() { printf (); }        .file          

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-10-15 Thread Christian Brunner
Hi, once again, Yehuda committed fixes for all the suggestions made on the list (and more). Here is the next update for the ceph/rbd block driver. Please let us know if there are any pending issues. For those who didn't follow the previous postings: This is an block driver for the distributed

[Qemu-devel] Passing in additional info to guest OS and e1000 test suite?

2010-10-15 Thread Anjali Kulkarni
Hi, - If I want to pass in additional arguments to the guest OS while booting(in particular which slot I want to map a nic to) - is there any way to do it? Some kind of configuration file that I can pass in would also be ok for me. - Is there a KVM/Qemu/e1000 test suite that is already available

[Qemu-devel] Re: Passing in additional info to guest OS and e1000 test suite?

2010-10-15 Thread Anthony Liguori
On 10/15/2010 01:49 PM, Anjali Kulkarni wrote: Hi, - If I want to pass in additional arguments to the guest OS while booting(in particular which slot I want to map a nic to) - is there any way to do it? Some kind of configuration file that I can pass in would also be ok for me. - Is there a

Re: [Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files

2010-10-15 Thread Blue Swirl
On Fri, Oct 15, 2010 at 2:05 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This moves library functions used by both QEMU and the QEMU tools, such as qemu-img, qemu-nbd etc. from osdep.c to os-{posix,win32}-lib.c $ find . \( -name '*posix*.c' -o -name

[Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-15 Thread Stefan Weil
PCI device with different device ids sometimes share the same rom code. Only the device id and the checksum differ in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c. It uses at least 3 different device ids, so normally

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-15 Thread Stefan Weil
Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: Am 12.10.2010 14:41, schrieb Markus Armbruster: Commit db667a12 added a reference to ROM file gpxe-eepro100-80862449.rom, but no such file. Intentional? Yes. See

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-15 Thread Anthony Liguori
On 10/15/2010 03:51 PM, Stefan Weil wrote: PCI device with different device ids sometimes share the same rom code. Only the device id and the checksum differ in a boot rom for such devices. BTW, SeaBIOS doesn't reject ROMs when they're loaded via rombar, only when they're loaded via

[Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file

2010-10-15 Thread Christoph Hellwig
On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote: Additionally to testing the qemu-img convert -B option, also test -o backing_file. Also, the old test acidentlly used a pattern of zeros for most of the writes, so that the allocation test didn't really work out. This is fixed by

[Qemu-devel] Re: [PATCH] qemu-iotests: Update expected results after qemu-img changes

2010-10-15 Thread Christoph Hellwig
On Fri, Oct 15, 2010 at 06:11:50PM +0200, Kevin Wolf wrote: The error message for leaked clusters has changed. qemu-iotests needs to be updated to pass 026 again. Thanks, applied!