[Qemu-devel] [Bug 685096] [NEW] USB Passthrough not working for Windows 7 guest

2010-12-03 Thread Max Power
Public bug reported: USB Passthrough from host to guest is not working for a 32-bit Windows 7 guest, while it works perfectly for a 32-bit Windows XP guest. The device appears in the device manager of Windows 7, but with "Error code 10: device cannot start". I have tried this with numerous USB th

Re: [Qemu-devel] [PATCH 00/16] linux-user updates

2010-12-03 Thread Edgar E. Iglesias
On Fri, Dec 03, 2010 at 03:36:27PM +0200, r...@afflict.kos.to wrote: > From: Riku Voipio > > Hi, > > Collection of recent linux-user patches that have been > tested to be good. Patches have been sent to the list before, > lets have a couple of days for comments and I'll request a pull > from. A

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-03 Thread Gerd Hoffmann
Hi, as you may know, there is an experimental git repository at git://git.kiszka.org/qemu.git ehci Looking into this right now as I'm busy with various usb issues anyway. Current state: http://cgit.freedesktop.org/spice/qemu/log/?h=usb.1 - lacks integration with UHCI (currentl

[Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice

2010-12-03 Thread Benjamin Drung
I have installed the package from maverick-proposed and can confirm that this bug is fixed by that version. ** Description changed: Binary package hint: qemu-kvm I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread ronnie sahlberg
Thankyou. On Sat, Dec 4, 2010 at 7:32 AM, Stefan Hajnoczi wrote: > > You want the library to be GPL, not LGPL? I have changed it to LGPLv3 for next submission. >> +       /* use a "random" isid */ >> +       srandom(getpid() ^ time(NULL)); > > The random number generator has global state and th

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread Anthony Liguori
On 12/03/2010 01:57 PM, ronnie sahlberg wrote: On Sat, Dec 4, 2010 at 2:05 AM, Anthony Liguori wrote: On 12/03/2010 05:09 AM, ronniesahlb...@gmail.com wrote: Note that ./block/iscsi/* is aimed at being re-used outisde of qemu/kvm in other applications why qemu/kvm specific calkls

[Qemu-devel] offre de service: Traductrice Interpr è te

2010-12-03 Thread ANGLAIS FRANCAIS
Traductrice Interprète Anglais <> Français Bonjour, Je viens vers vous car dans le cadre de mon activité: Traduction - Interprétariat Anglais - Français - Anglais, j'aimerais collaborer avec vous et vous proposer mes services. TRADUCTION Sites Internet CV norme anglophone M

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread Stefan Hajnoczi
On Fri, Dec 3, 2010 at 11:09 AM, wrote: > @@ -0,0 +1,215 @@ > +/* > +   Copyright (C) 2010 by Ronnie Sahlberg > + > +   This program is free software; you can redistribute it and/or modify > +   it under the terms of the GNU General Public License as published by > +   the Free Software Foundati

Re: [Qemu-devel] Re: [PATCH v5 4/5] qed: Read/write support

2010-12-03 Thread Stefan Hajnoczi
On Fri, Dec 3, 2010 at 4:06 PM, Kevin Wolf wrote: > Am 24.11.2010 12:11, schrieb Stefan Hajnoczi: >> +static void qed_aio_cancel(BlockDriverAIOCB *blockacb) >> +{ >> +    QEDAIOCB *acb = (QEDAIOCB *)blockacb; >> +    bool finished = false; >> + >> +    /* Wait for the request to finish */ >> +    

[Qemu-devel] offre de service: Traduction et Interpr é tariat asserment é s

2010-12-03 Thread RUSSE FRANCAIS
Traduction et Interprétariat assermentés RUSSE FRANCAIS Chère Madame, cher Monsieur, Dans le cadre de mon activité Traductrice et Interprète Français Russe Experte près la Cour d'Appel de Montpellier, je suis amenée à offrir mes services à des professionnels dans divers secteurs d'activité et

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread ronnie sahlberg
On Sat, Dec 4, 2010 at 2:05 AM, Anthony Liguori wrote: > On 12/03/2010 05:09 AM, ronniesahlb...@gmail.com wrote: >> >> Note that ./block/iscsi/* is aimed at being re-used outisde of qemu/kvm >> in other applications why qemu/kvm specific calkls are not used there. >> > > So should the library be

[Qemu-devel] [RFC][PATCH v5 16/21] virtagent: add client capabilities init function

2010-12-03 Thread Michael Roth
Non-monitor version of agent_capabilities monitor function. This is called by the local RPC server when it gets a "hello" from the guest agent to re-negotiate guest agent capabilities. Signed-off-by: Michael Roth --- virtagent.c | 18 ++ virtagent.h |1 + 2 files changed, 1

[Qemu-devel] [RFC][PATCH v5 20/21] virtagent: integrate virtagent server/client via chardev

2010-12-03 Thread Michael Roth
This adds a new chardev, virtagent, which actually just passes back a socket chardev after connecting to it and initializing the agent. Signed-off-by: Michael Roth --- qemu-char.c | 49 + 1 files changed, 49 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-03 Thread Michael Roth
Add RPC to retrieve a guest file. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael Roth --- virtagent-server.c | 59 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/

[Qemu-devel] [RFC][PATCH v5 19/21] virtagent: add virtagent guest daemon

2010-12-03 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile |4 +- qemu-va.c | 327 + 2 files changed, 330 insertions(+), 1 deletions(-) create mode 100644 qemu-va.c diff --git a/Makefile b/Makefile index 4e120a2..556c853 100644 --- a/Makefile +++

[Qemu-devel] [RFC][PATCH v5 21/21] virtagent: various bits to build QEMU with virtagent

2010-12-03 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.target |2 +- configure | 26 ++ 2 files changed, 27 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 2800f47..c549c66 100644 --- a/Makefile.target +++ b/Makefile.target @@ -185,7 +185

[Qemu-devel] [RFC][PATCH v5 10/21] virtagent: add agent_viewdmesg qmp/hmp commands

2010-12-03 Thread Michael Roth
Add commands to view guest dmesg output. Currently it is a 16K buffer. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 + qmp-commands.hx | 35 + virtagent.c | 92 +++ virtagent.h |3 ++ 4 file

[Qemu-devel] [RFC][PATCH v5 18/21] virtagent: add "hello" notification function for guest agent

2010-12-03 Thread Michael Roth
This tells the host RPC server (QEMU) that we're up and running Signed-off-by: Michael Roth --- virtagent.c | 47 +++ virtagent.h |1 + 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/virtagent.c b/virtagent.c index 887ad02..e1200

[Qemu-devel] [RFC][PATCH v5 15/21] virtagent: add agent_capabilities qmp/hmp commands

2010-12-03 Thread Michael Roth
Call guest agent's built-in introspection functions to get a list of supported RPCs, and re-negotiate guest agent capabilities to determine what agent_* commands are supported. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 + qmp-commands.hx | 32 ++ virtagent.

[Qemu-devel] [RFC][PATCH v5 14/21] virtagent: add agent_ping qmp/hmp commands

2010-12-03 Thread Michael Roth
Monitor command to ping the RPC server. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 qmp-commands.hx | 32 +++ virtagent.c | 74 +++ virtagent.h |3 ++ 4 files changed, 125 insertions(

[Qemu-devel] [RFC][PATCH v5 12/21] virtagent: add agent_shutdown qmp/hmp commands

2010-12-03 Thread Michael Roth
Provide monitor command to initiate guest reboot/halt/powerdown Signed-off-by: Michael Roth --- hmp-commands.hx | 16 ++ qmp-commands.hx | 32 + virtagent.c | 59 +++ virtagent.h |2 + 4

[Qemu-devel] [RFC][PATCH v5 17/21] virtagent: add va.hello RPC

2010-12-03 Thread Michael Roth
This RPC tells us the guest agent is up and ready, and invokes guest agent capability negotiation Signed-off-by: Michael Roth --- virtagent-server.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index 4a8ce7

[Qemu-devel] [RFC][PATCH v5 05/21] virtagent: base client definitions

2010-12-03 Thread Michael Roth
Functions for managing client capabilities and creating client RPC jobs. Signed-off-by: Michael Roth --- qerror.c|8 +++ qerror.h|6 +++ virtagent.c | 141 +++ virtagent.h | 32 + 4 files changed, 187 insertio

[Qemu-devel] [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-03 Thread Michael Roth
Add RPC to view guest dmesg output. Signed-off-by: Michael Roth --- virtagent-server.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index a430b58..aac8f70 100644 --- a/virtagent-serv

[Qemu-devel] [RFC][PATCH v5 13/21] virtagent: add va.ping RPC

2010-12-03 Thread Michael Roth
Do-nothing RPC that can be used to "ping" the RPC server Signed-off-by: Michael Roth --- virtagent-server.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index 453cf0d..4a8ce7d 100644 --- a/virtagent-server.c +++

[Qemu-devel] [RFC][PATCH v5 11/21] virtagent: add va.shutdown RPC

2010-12-03 Thread Michael Roth
RPC to initiate guest reboot/halt/powerdown Signed-off-by: Michael Roth --- virtagent-server.c | 58 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index aac8f70..453cf0d 100644 --- a/

[Qemu-devel] [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-03 Thread Michael Roth
Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it and provide it back to the user (base64 encoding it for instance). Hence the otherwise confusing "vi

[Qemu-devel] [RFC][PATCH v5 06/21] virtagent: base server definitions

2010-12-03 Thread Michael Roth
Functions for managing server's RPC methods. Signed-off-by: Michael Roth --- virtagent-server.c | 62 virtagent-server.h | 30 + 2 files changed, 92 insertions(+), 0 deletions(-) create mode 100644 virtagent-server

[Qemu-devel] [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-03 Thread Michael Roth
This implements a simple state machine to manage client/server rpc jobs being multiplexed over a single channel. A client job consists of sending an rpc request, reading an rpc response, then making the appropriate callbacks. We allow one client job to be processed at a time, which will make the f

[Qemu-devel] [RFC][PATCH v5 02/21] Add qemu_set_fd_handler() wrappers to qemu-tools.c

2010-12-03 Thread Michael Roth
This adds state information for managing fd handlers to qemu-tools.c so that tools that build against it can implement an I/O loop for interacting with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- qemu-tool.c | 25 - 1 files changed, 24 inserti

[Qemu-devel] [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-03 Thread Michael Roth
Async read/send handlers for managing RPC/HTTP request/responses. The read handler runs continuously and calls into client or server RPC callbacks based on the HTTP header. The send handlers are started up to send RPC client requests/server responses. Signed-off-by: Michael Roth --- virtagent-co

[Qemu-devel] [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-03 Thread Michael Roth
This allows us to implement an i/o loop outside of vl.c that can interact with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- Makefile.objs |2 +- qemu-char.h |4 ++ qemu-ioh.c| 115 + qemu-ioh.h|

[Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-03 Thread Michael Roth
These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 CHANGES IN V5: - Dependency on virtproxy dropped, virtagent now handles transport and multiplexing of bi-directional RPCs internally - Removed duplification of qemu_set_fd_handler()-cent

[Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice

2010-12-03 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/maverick-proposed/qemu-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/427612 Title: kvm sends caps lock key up event twice Status in QEMU: New Status in “libsdl1.2

[Qemu-devel] [PATCH] exec: Remove debugging fprintf() that slipped into qemu_ram_alloc_from_ptr()

2010-12-03 Thread Stefan Hajnoczi
Remove the debugging fprintf() slipped in via the following commit: commit b2e0a138e77245290428a7d599a929e2e1bfe510 Author: Michael S. Tsirkin Date: Mon Nov 22 19:52:34 2010 +0200 migration: stable ram block ordering Signed-off-by: Stefan Hajnoczi --- exec.c |1 - 1

Re: [Qemu-devel] [PATCHv2 2/6] cpus: flush all requests on each vm stop

2010-12-03 Thread Marcelo Tosatti
On Tue, Nov 30, 2010 at 04:05:31PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 30, 2010 at 11:46:48AM -0200, Marcelo Tosatti wrote: > > On Tue, Nov 30, 2010 at 03:34:29PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 30, 2010 at 10:45:40AM -0200, Marcelo Tosatti wrote: > > > > On Wed, Nov 2

[Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice

2010-12-03 Thread Martin Pitt
Accepted qemu-kvm into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Tags added: verification-needed

[Qemu-devel] Re: [PATCH v5 4/5] qed: Read/write support

2010-12-03 Thread Kevin Wolf
Am 24.11.2010 12:11, schrieb Stefan Hajnoczi: > This patch implements the read/write state machine. Operations are > fully asynchronous and multiple operations may be active at any time. > > Allocating writes lock tables to ensure metadata updates do not > interfere with each other. If two alloc

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-12-03 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.12.3+noroms-0ubuntu9.3 --- qemu-kvm (0.12.3+noroms-0ubuntu9.3) lucid-proposed; urgency=low * Fix segfault when using scsi with writeback (LP: #595438) -- Serge HallynWed, 28 Jul 2010 09:56:56 -0500 ** Changed in: qemu-kvm (Ubuntu

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread Anthony Liguori
On 12/03/2010 05:09 AM, ronniesahlb...@gmail.com wrote: This series of pathces adds built in iscsi support to qemu. The first 12 patches 14 adds a general purpose iscsi client library in a separate subdirectory ./block/iscsi that is aimed at being useful not only for kvm/qemu but for all scsi rel

Re: [Qemu-devel] [PATCH 00/16] linux-user updates

2010-12-03 Thread Peter Maydell
On 3 December 2010 13:36, wrote: > Collection of recent linux-user patches that have been > tested to be good. Patches have been sent to the list before, > lets have a couple of days for comments and I'll request a pull > from. I hate to quibble, but: > Peter Maydell (10): >  target-arm: remove

[Qemu-devel] [PATCH 06/16] ARM: enable XScale/iWMMXT in linux-user mode

2010-12-03 Thread Riku
From: Peter Maydell In linux-user mode, the XScale/iWMMXT coprocessors must be enabled at reset so that we can run code that uses these instructions. Signed-off-by: Peter Maydell --- target-arm/helper.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-arm/he

[Qemu-devel] [PATCH 10/16] ARM: linux-user: Expose VFP registers to signal handlers

2010-12-03 Thread Riku
From: Peter Maydell For ARM linux-user mode signal handlers, fill in the ucontext with VFP register contents in the same way that the kernel does. We only do this for v2 format sigframe (2.6.12 and above); this is actually bug-for-bug compatible with the older kernels, which don't save and restor

[Qemu-devel] [PATCH 04/16] linux-user: remove unnecessary local from __get_user(), __put_user()

2010-12-03 Thread Riku
From: Peter Maydell Remove an unnecessary local variable from the __get_user() and __put_user() macros. This avoids confusing compilation failures if the name of the local variable ('size') happens to be the same as the variable the macro user is trying to read/write. Signed-off-by: Peter Maydel

[Qemu-devel] [PATCH 05/16] linux-user: Translate getsockopt level option

2010-12-03 Thread Riku
From: Jamie Lentin n setsockopt, the socket level options are translated to the hosts' architecture before the real syscall is called, e.g. TARGET_SO_TYPE -> SO_TYPE. This patch does the same with getsockopt. Tested on a x86 host emulating MIPS. Without it:- $ grep getsockopt host.strace 31311

[Qemu-devel] [PATCH 13/16] ARM: linux-user: Restore iWMMXT state from ucontext on sigreturn

2010-12-03 Thread Riku
From: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/signal.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index b4b610b..c846b8c 100644 --- a/linux-user/si

[Qemu-devel] [PATCH 07/16] target-sparc: remove unused functions cpu_lock(), cpu_unlock()

2010-12-03 Thread Riku
From: Peter Maydell --- target-sparc/cpu.h|2 -- target-sparc/helper.c | 14 -- 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 7e0d17c..3e93bbb 100644 --- a/target-sparc/cpu.h +++ b/target-sparc/cpu.h @@ -444,8

[Qemu-devel] [PATCH 16/16] linux-user: fix mips and ppc to use UID16

2010-12-03 Thread Riku
From: Martin Mohring Signed-off-by: Martin Mohring Signed-off-by: Jan-Simon Möller Signed-off-by: Riku Voipio --- linux-user/mips/syscall_nr.h | 38 +++--- linux-user/ppc/syscall_nr.h | 30 +++--- linux-user/syscall_defs.h|2

[Qemu-devel] [PATCH 12/16] ARM: linux-user: Expose iWMMXT registers to signal handlers

2010-12-03 Thread Riku
From: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/signal.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 63d893b..b4b610b 100644 --- a/linux-

[Qemu-devel] [PATCH 01/16] [PATCH] target-arm: remove unused functions cpu_lock(), cpu_unlock()

2010-12-03 Thread Riku
From: Peter Maydell Signed-off-by: Riku Voipio --- target-arm/cpu.h |2 -- target-arm/op_helper.c | 14 -- 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index b87c605..0284bad 100644 --- a/target-arm/cpu.h +++ b/targe

[Qemu-devel] [PATCH 02/16] linux-user: mmap_reserve() not controlled by RESERVED_VA

2010-12-03 Thread Riku
From: amateur mmap_reserve() should be called only when RESERVED_VA is enabled. Otherwise, unmaped virtual address space will never be reusable. This bug will exhaust virtual address space in extreme conditions. Signed-off-by: Riku Voipio --- linux-user/mmap.c |4 +++- 1 files changed, 3 i

[Qemu-devel] [PATCH 11/16] ARM: linux-user: Restore VFP state from ucontext on sigreturn

2010-12-03 Thread Riku
From: Peter Maydell Restore the VFP registers from the ucontext on return from a signal handler in linux-user mode. This means that signal handlers cannot accidentally corrupt the interrupted code's VFP state, and allows them to deliberately modify the state via the ucontext structure. Signed-of

[Qemu-devel] [PATCH 03/16] linux-user: fix memory leaks with NPTL emulation

2010-12-03 Thread Riku
From: Nathan Froyd Running programs that create large numbers of threads, such as this snippet from libstdc++'s pthread7-rope.cc: const int max_thread_count = 4; const int max_loop_count = 1; ... for (int j = 0; j < max_loop_count; j++) { ... for (int i = 0; i < max_t

[Qemu-devel] [PATCH 15/16] update binfmt conf

2010-12-03 Thread Riku
From: Riku Voipio 1) dont register i386 qemu on x86_64 host 2) widen sparc and arm match 3) add sh4, based on patch by David Kozub Rest based on patch by Jan-Simon Möller --- qemu-binfmt-conf.sh |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-binfmt-conf.s

[Qemu-devel] [PATCH 14/16] linux-user: fix compiler error on nptl

2010-12-03 Thread Riku
From: Riku Voipio Some compilers detect that new_stack isnt used after dd75d784 Signed-off-by: Riku Voipio --- linux-user/syscall.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 070241b..c3e8706 100644 --- a/linux-u

[Qemu-devel] [PATCH 08/16] ARM: linux-user: Correct size of padding in target_ucontext_v2

2010-12-03 Thread Riku
From: Peter Maydell The padding in the target_ucontext_v2 is defined by the size of the target's sigset_t type, not the host's. (This bug only causes problems when we start using the uc_regspace[] array to expose VFP registers to userspace signal handlers.) Signed-off-by: Peter Maydell Signed-o

[Qemu-devel] [PATCH 09/16] ARM: Expose vfp_get_fpscr() and vfp_set_fpscr() to C code

2010-12-03 Thread Riku
From: Peter Maydell Expose the vfp_get_fpscr() and vfp_set_fpscr() functions to C code as well as generated code, so we can use them to read and write the FPSCR when saving and restoring VFP registers across signal handlers in linux-user mode. Signed-off-by: Peter Maydell Signed-off-by: Riku Vo

[Qemu-devel] [PATCH 00/16] linux-user updates

2010-12-03 Thread Riku
From: Riku Voipio Hi, Collection of recent linux-user patches that have been tested to be good. Patches have been sent to the list before, lets have a couple of days for comments and I'll request a pull from. The following changes since commit 6a8657528d94fa1be78d1be0821a01a251fa2de9: Anthony

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Jason Wang
Michael S. Tsirkin writes: > On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: > > Michael S. Tsirkin writes: > > > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > > > > Michael S. Tsirkin writes: > > > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote:

[Qemu-devel] Re: [PATCH 3/3] Fail if detecting an unknown option

2010-12-03 Thread Kevin Wolf
Am 02.12.2010 18:46, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > This patch changes qemu-img to exit if an unknown option is detected, > instead of trying to continue with a set of arguments which may be > incorrect. > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 48 +

[Qemu-devel] [PATCH 11/14] ./block/iscsi/connect.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : connect.c This file contains helper functions to make simples use of iscsi resources easier by for example baking tcp connect, login, testunit ready, verifying device is available, into one simple to use function. ... ./block/iscsi/ contains a cop

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread ronnie sahlberg
On Fri, Dec 3, 2010 at 10:42 PM, Stefan Hajnoczi wrote: > On Fri, Dec 3, 2010 at 11:09 AM,   wrote: >> This series of pathces adds built in iscsi support to qemu. > > Christoph asked why block/iscsi.c exists and we don't have something > like hw/iscsi-disk.c.  Any thoughts on "pass-through" SCSI s

[Qemu-devel] [PATCH 10/14] ./block/iscsi/sync.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : sync.c This file contains functions for implementing a synchronous api layers ontop of the asynchronous library. These functions are all synchronous and thus blocking making them' useful mainly for simple applications where ease of use if more impor

Re: [Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option

2010-12-03 Thread Stefan Hajnoczi
On Thu, Dec 2, 2010 at 5:46 PM, wrote: > From: Jes Sorensen > > This patch changes qemu-img to exit if an unknown option is detected, > instead of trying to continue with a set of arguments which may be > incorrect. > > Signed-off-by: Jes Sorensen > --- >  qemu-img.c |   48

[Qemu-devel] [PATCH 14/14] iscsi support

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg add iscsi.c and the iscsi library to the makefile sot it gets built Signed-off-by: Ronnie Sahlberg --- Makefile |2 +- Makefile.objs |9 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index c80566c..6efdf14 10064

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread Stefan Hajnoczi
On Fri, Dec 3, 2010 at 11:09 AM, wrote: > This series of pathces adds built in iscsi support to qemu. Christoph asked why block/iscsi.c exists and we don't have something like hw/iscsi-disk.c. Any thoughts on "pass-through" SCSI support so CDBs from guest SCSI can be written straight to the iSC

[Qemu-devel] [PATCH 09/14] ./block/iscsi/scsi-lowlevel.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : scsi-lowlevel.c This file contains functions for marshalling and unmarshalling scsi CDB blocks and DATA-IN/DATA-OUT blocks. This currently supports only small subset of SCSI opcodes but the hope is contributions will expand its coverage over time.

[Qemu-devel] [PATCH 12/14] ./block/iscsi/*.h

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : *.h These files contain the heade declaraions, typedefs and useful macros used by the iscsi client library. ... ./block/iscsi/ contains a copy of a general purpose iscsi client library which is aimed at providing a clientside api for iscsi for both

[Qemu-devel] [PATCH 03/14] ./block/iscsi/login.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : login.c This file contains functions associated with loggign in to a target, negotiating session parameters and logging out from a target. Login negitiation is currently limited in scope and functionality but can log in successfully to TGTD targets

[Qemu-devel] [PATCH 07/14] ./block/iscsi/pdu.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : pdu.c This file contains functions for basic manipulation of iscsi PDUs and their flags as well as tracking and matching relations between requests, data-in, data-out and responses. ... ./block/iscsi/ contains a copy of a general purpose iscsi cli

[Qemu-devel] [PATCH 08/14] ./block/iscsi/sscsi-command.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : scsi-command.c This file contains functions for providing a fully async and fully nonblocking interface to send scsi commands to a target and handle replies coming back. This layer is fully async and nonblocking. Client applications can send and kee

[Qemu-devel] [PATCH 13/14] ./block/iscsi.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg This file provides a new protocol ISCSI to qemu and allows qemu connect directly to iscsi resources, without having to go through the host scsi layer. This allows qemu/kvm to use iscsi devices without exposing these to the host system and without polluting the page cache of

[Qemu-devel] [PATCH 02/14] ./block/iscsi/socket.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : socket.c This file contains functions for basic manipulation of the socket used to talk to a iscsi target. This includes, connect, disconnect, basic primitives for interfacing with an external eventsystem, reading and writing to the socket. The sock

[Qemu-devel] [PATCH 06/14] ./block/iscsi/nop.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : nop.c This file contains functions for processing of initiator initiated NOP exchanges. While target initiated exchanged look virtually identical, these are not implemented. TGTD iscsin target does not use target initiated nop exchanges but other ta

[Qemu-devel] [PATCH 05/14] ./block/iscsi/crc32c.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : crc32c.c This file contains functions for computing the crc32c used by iscsi header digest and icsi data digest to ensure data integrity across the transport. ... ./block/iscsi/ contains a copy of a general purpose iscsi client library which is aim

[Qemu-devel] [PATCH 04/14] ./block/iscsi/discovery.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : discovery.c This file contains functions for managing discovery sessions used by iscsi clients to discover which targets may be present behind a particular iscsi portal. ... ./block/iscsi/ contains a copy of a general purpose iscsi client library w

[Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : init.c This file contains functions to create a iscsi context, destroy a context, error reporting api, as well as basic functions to manipulate properties of an iscsi context. ... ./block/iscsi/ contains a copy of a general purpose iscsi client lib

[Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread ronniesahlberg
This series of pathces adds built in iscsi support to qemu. The first 12 patches 14 adds a general purpose iscsi client library in a separate subdirectory ./block/iscsi that is aimed at being useful not only for kvm/qemu but for all scsi relates applications. Patch 13 adds the block driver ./block

[Qemu-devel] [PATCH] isa-bus.c: use hw_error instead of fprintf

2010-12-03 Thread Tristan Gingold
Minor clean-up in isa-bus.c. Using hw_error is more consistent. There is a difference however: hw_error dumps the cpu state. Signed-off-by: Tristan Gingold --- hw/isa-bus.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 4e306

Re: [Qemu-devel] [PATCH 2/3] Fix formatting and missing braces in qemu-img.c

2010-12-03 Thread Stefan Hajnoczi
On Thu, Dec 2, 2010 at 5:46 PM, wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- >  qemu-img.c |   77 +++ >  1 files changed, 51 insertions(+), 26 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-03 Thread Stefan Hajnoczi
On Fri, Dec 3, 2010 at 10:57 AM, Stefan Hajnoczi wrote: > On Thu, Dec 2, 2010 at 5:46 PM,   wrote: >> @@ -694,6 +720,11 @@ static int img_convert(int argc, char **argv) >> >>     out_filename = argv[argc - 1]; >> >> +    if (options && !strcmp(options, "?")) { >> +        ret = print_block_option_

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-03 Thread Jes Sorensen
On 12/03/10 11:57, Stefan Hajnoczi wrote: > On Thu, Dec 2, 2010 at 5:46 PM, wrote: >> +create_options = append_option_parameters(create_options, >> + drv->create_options); >> +create_options = append_option_parameters(create_options, >> +

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-03 Thread Stefan Hajnoczi
On Thu, Dec 2, 2010 at 5:46 PM, wrote: > @@ -188,6 +188,32 @@ static int read_password(char *buf, int buf_size) >  } >  #endif > > +static int print_block_option_help(const char *filename, const char *fmt) > +{ > +    BlockDriver *drv, *proto_drv; > +    QEMUOptionParameter *create_options = NULL

[Qemu-devel] [PATCH 1/2] make kvmclock value idempotent for stopped machine

2010-12-03 Thread Glauber Costa
Although we never made such commitment clear (well, to the best of my knowledge), some people expect that two savevm issued in sequence in a stopped machine will yield the same results. This is not a crazy requirement, since we don't expect a stopped machine to be updating its state, for any device

[Qemu-devel] [PATCH 2/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-03 Thread Glauber Costa
Usually nobody usually thinks about that scenario (me included and specially), but kvmclock can be actually disabled in the host. It happens in two scenarios: 1. host too old. 2. we passed -kvmclock to our -cpu parameter. In both cases, we should not register kvmclock savevm section. This patch

[Qemu-devel] [PATCH 0/2] Fix savevm odness related to kvmclock

2010-12-03 Thread Glauber Costa
Some users told me that savevm path is behaving oddly wrt kvmclock. The first oddness is that a guarantee we never made (AFAIK) is being broken: two consecutive "savevm" operations, with the machine stopped in between produces different results, due to the call to KVM_GET_CLOCK ioctl. I believe the

[Qemu-devel] Re: megasas: Usage of is_write in megasas_map_sgl()

2010-12-03 Thread Hannes Reinecke
On 12/03/2010 11:25 AM, Kevin Wolf wrote: > Am 02.12.2010 23:24, schrieb Nicholas A. Bellinger: >> The usage of a inverted is_write with cpu_physical_memory_map() also >> seems to be the case in dma-helpers.c:dma_brdv_cb(): >> >> mem = cpu_physical_memory_map(cur_addr, &cur_len, !dbs->is_write

[Qemu-devel] Re: megasas: Usage of is_write in megasas_map_sgl()

2010-12-03 Thread Kevin Wolf
Am 02.12.2010 23:24, schrieb Nicholas A. Bellinger: > The usage of a inverted is_write with cpu_physical_memory_map() also > seems to be the case in dma-helpers.c:dma_brdv_cb(): > > mem = cpu_physical_memory_map(cur_addr, &cur_len, !dbs->is_write); > > After changing to an inverted is_write

[Qemu-devel] Re: [RFC PATCH v3 2/4] Add block-queue

2010-12-03 Thread Stefan Hajnoczi
On Tue, Nov 30, 2010 at 12:48 PM, Kevin Wolf wrote: > +/* > + * Adds a write request to the queue. > + */ > +int blkqueue_pwrite(BlockQueueContext *context, uint64_t offset, void *buf, > +    uint64_t size) > +{ > +    BlockQueue *bq = context->bq; > +    BlockQueueRequest *section_req; > +    boo

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Kevin Wolf
Am 01.12.2010 06:59, schrieb Michael S. Tsirkin: > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: >> Michael S. Tsirkin writes: >> > Avoid sending out packets, and modifying >> > device state, when VM is stopped. >> > Add assert statements to verify this does not happen. >> > >>

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Kevin Wolf
Am 02.12.2010 19:27, schrieb Michael S. Tsirkin: > On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: >> Michael S. Tsirkin writes: >> > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: >> > > Michael S. Tsirkin writes: >> > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jaso