[Qemu-devel] [PATCH] wdt_i6300esb: register a reset function

2010-12-09 Thread Bernhard Kohl
The device shall set its default hardware state after each reset. This includes that the timer is stopped which is especially important if the guest does a reboot independantly of a watchdog bite. I moved the initialization of the state variables completely from the init to the reset function

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-09 Thread David S. Ahern
On 12/08/10 01:32, Jan Kiszka wrote: Am 08.12.2010 09:26, Gerd Hoffmann wrote: Hi, It appears that the import of the ehci code to spice has completely lost the development history and code contributions - from the original version by Mark Burkley through the work I've done on it. Would

[Qemu-devel] [PATCH] blockdev: check dinfo ptr before using

2010-12-09 Thread Ryan Harper
If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we attempt to access dinfo-auto_del.[1] The fix is to check if

[Qemu-devel] IRC channel movement - FreeNode to OFTC

2010-12-09 Thread Anthony Liguori
Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

2010-12-09 Thread Paul Brook
But that's entirely in guest memory, so it's limited to the amount of RAM that has been allocated to the guest. Exactly. The guest can cause ram_size * nr_ports of additional host memory to be allocated. Not acceptable. OK -- so this is how it adds up: - guest

[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using

2010-12-09 Thread Luiz Capitulino
On Wed, 8 Dec 2010 10:05:00 -0600 Ryan Harper ry...@us.ibm.com wrote: If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-09 Thread Jes Sorensen
On 12/07/10 18:32, Michael Roth wrote: On 12/07/2010 08:37 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: +static xmlrpc_value *va_getdmesg(xmlrpc_env *env, + xmlrpc_value *param, + void *user_data) +{ +char

[Qemu-devel] [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Luiz Capitulino
Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts) on ram_size in the control path after we determine we're not using kvm Upstream qemu-kvm is affected if using the -no-kvm option;

[Qemu-devel] Re: seabios: acpi: add _RMV control method for PCI devices

2010-12-09 Thread Marcelo Tosatti
On Wed, Dec 08, 2010 at 07:34:42PM +0200, Gleb Natapov wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. But Windows still shows device as removable in the gui and allows to remove it, correct? No. From

[Qemu-devel] Re: [PATCH v2 1/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-09 Thread Marcelo Tosatti
On Tue, Dec 07, 2010 at 03:12:36PM -0200, Glauber Costa wrote: On Mon, 2010-12-06 at 19:04 -0200, Marcelo Tosatti wrote: On Mon, Dec 06, 2010 at 09:03:46AM -0500, Glauber Costa wrote: Usually nobody usually thinks about that scenario (me included and specially), but kvmclock can be

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2010-12-09 Thread Mirco Bauer
I suffer from the same issue using QEMU 1.1. I tried 5 different USB thumbdrives and none of them worked. Interesting was that a USB 1.1 mouse was working though. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] Re: seabios: acpi: add _RMV control method for PCI devices

2010-12-09 Thread Gleb Natapov
On Wed, Dec 08, 2010 at 04:01:18PM -0200, Marcelo Tosatti wrote: On Wed, Dec 08, 2010 at 07:34:42PM +0200, Gleb Natapov wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. But Windows still shows device as

[Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Anthony Liguori
On 12/08/2010 12:01 PM, Luiz Capitulino wrote: Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts) on ram_size in the control path after we determine we're not using kvm Upstream

[Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Luiz Capitulino
On Wed, 08 Dec 2010 12:23:12 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 12/08/2010 12:01 PM, Luiz Capitulino wrote: Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on

[Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Anthony Liguori
On 12/08/2010 12:27 PM, Luiz Capitulino wrote: On Wed, 08 Dec 2010 12:23:12 -0600 Anthony Liguorialigu...@linux.vnet.ibm.com wrote: On 12/08/2010 12:01 PM, Luiz Capitulino wrote: Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple

[Qemu-devel] Re: seabios: acpi: add _RMV control method for PCI devices

2010-12-09 Thread Marcelo Tosatti
On Wed, Dec 08, 2010 at 09:58:35PM +0200, Gleb Natapov wrote: On Wed, Dec 08, 2010 at 04:01:18PM -0200, Marcelo Tosatti wrote: On Wed, Dec 08, 2010 at 07:34:42PM +0200, Gleb Natapov wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Stefan Hajnoczi
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf ag...@suse.de wrote: +struct AHCIDevice { +    IDEBus port; +    int port_no; +    uint32_t port_state; +    uint32_t finished; +    AHCIPortRegs port_regs; +    struct AHCIState *hba; +    uint8_t *lst; +    uint8_t *res_fis; +    uint8_t

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Mon, Dec 06, 2010 at 10:26:02AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- hw/grlib_gptimer.c | 448 1 files changed, 448 insertions(+), 0 deletions(-) diff --git a/hw/grlib_gptimer.c

Re: [Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-09 Thread Jes Sorensen
On 12/07/10 18:19, Michael Roth wrote: On 12/07/2010 07:44 AM, Jes Sorensen wrote: +static int va_end_of_header(char *buf, int end_pos) +{ +return !strncmp(buf+(end_pos-2), \n\r\n, 3); +} Maybe I am missing something here, but it looks like you do a strncmp to a char that is one past

[Qemu-devel] Re: [PATCH] fix qruncom compilation problems

2010-12-09 Thread Stefano Bonifazi
On 12/08/2010 01:49 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- I had this patch lying around but I don't think I ever got qruncom to work completely. Makefile.target |3 ++ tests/Makefile |7 ++-- tests/qruncom.c | 93

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-09 Thread Jes Sorensen
On 12/07/10 17:00, Adam Litke wrote: Hi Jes, you raise some good points and pitfalls with the current getfile approach. I've been thinking about an alternative and am wondering what you (and others) think... First off, I think we should switch to a copyfile() API that allows us to avoid

[Qemu-devel] [PATCH] disable sigcld handling before calling pclose()

2010-12-09 Thread Wen Congyang
When I use the command 'virsh save' to save the domain state, I receive the following error message: operation failed: Migration unexpectedly failed. I debug the qemu by adding some printf(), and find the function pclose() returns -1. I use strace to trace qemu, the log is as the following:

[Qemu-devel] Re: [PATCH 1/6] qemu, kvm: Enable NMI support for user space irqchip

2010-12-09 Thread Jan Kiszka
Am 09.12.2010 07:58, Lai Jiangshan wrote: Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space APIC emulation or some other source raised them. In that light, the subject is not absolutely correct. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff

Re: [Qemu-devel] [PATCH] ppc: kvm: fix signedness warning

2010-12-09 Thread Edgar E. Iglesias
On Wed, Dec 08, 2010 at 12:01:43PM +0100, Alexander Graf wrote: ping? I've applied this, thanks. On 25.11.2010, at 08:20, Alexander Graf wrote: I get a warning on a signed comparison with an unsigned variable, so let's make the variable signed and be happy. Signed-off-by: Alexander

Re: [Qemu-devel] [PATCH] fix qruncom compilation problems

2010-12-09 Thread Isaku Yamahata
What is the reason to duplicate cpu_{in,out}[bwl]() instead of ioport-user.c? On Wed, Dec 08, 2010 at 01:49:11PM +0100, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- I had this patch lying around but I don't think I ever got qruncom to work

[Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency

2010-12-09 Thread Michael S. Tsirkin
On Sat, Dec 04, 2010 at 02:35:53PM +0100, Paolo Bonzini wrote: On 12/02/2010 11:54 PM, Michael S. Tsirkin wrote: +bool assert = pcie_aer_root_does_trigger(root_cmd_set, root_status); Risky variable name, I think it would fail if someone includes assert.h. Paolo We already do, it

Re: [Qemu-devel] [PATCH] fix qruncom compilation problems

2010-12-09 Thread Paolo Bonzini
On 12/09/2010 04:32 AM, Isaku Yamahata wrote: What is the reason to duplicate cpu_{in,out}[bwl]() instead of ioport-user.c? That's the reason why I hadn't submitted the patch so far, it's not really finished. I also wanted to remove the need for mmap(MAP_FIXED). Paolo

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Fabien Chouteau
On 12/08/2010 11:51 PM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:02AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteauchout...@adacore.com --- hw/grlib_gptimer.c | 448 1 files changed, 448 insertions(+), 0

[Qemu-devel] [PULL 00/14] Block patches

2010-12-09 Thread Kevin Wolf
The following changes since commit 138b38b61bf92d4e9588acf934e532499c94e185: ppc: kvm: fix signedness warning (2010-12-08 21:30:19 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christian Brunner (1): ceph/rbd block driver for qemu-kvm Jes

[Qemu-devel] [PATCH 03/14] Use qemu_mallocz() instead of calloc() in img_convert()

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index fa77ac0..eca99c4 100644 ---

[Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice

2010-12-09 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.12.5+noroms-0ubuntu7.1 --- qemu-kvm (0.12.5+noroms-0ubuntu7.1) maverick-proposed; urgency=low * Add caps-lock-key-up-event.patch to enable normal up/down events for Caps-Lock and Num-Lock keys by setting SDL_DISABLE_LOCK_KEYS

[Qemu-devel] [PATCH 4/6] qemu,qmp: QError: New QERR_TOO_MANY_KEYS

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/qerror.c b/qerror.c index a7ef758..fd66d2a 100644 --- a/qerror.c +++ b/qerror.c @@ -197,6 +197,10 @@ static const QErrorStringTable qerror_table[] = { .desc = Too many open files, }, { +.error_fmt =

[Qemu-devel] [PATCH 02/14] Add missing tracing to qemu_mallocz()

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-malloc.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/qemu-malloc.c b/qemu-malloc.c index 28fb05a..b9b3851 100644 ---

[Qemu-devel] [PATCH 01/14] block: Make bdrv_create_file() ':' handling consistent

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Filenames may start with protocol: to explicitly use a protocol like nbd. Filenames with unknown protocols are rejected in most of QEMU except for bdrv_create_file(). Even if a file with an invalid filename can be created, QEMU cannot use it

[Qemu-devel] [PATCH 07/14] Fail if detecting an unknown option

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com This patch changes qemu-img to exit if an unknown option is detected, instead of trying to continue with a set of arguments which may be incorrect. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [Bug 687733] Re: Linux KSM not compiled in (MADV_MERGEABLE always undef)

2010-12-09 Thread Walter Haidinger
To clarify: custom kernel == vanilla Linux kernel, i.e. not distribution kernel. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/687733 Title: Linux KSM not compiled in (MADV_MERGEABLE always undef)

[Qemu-devel] Re: [PATTCH v2 0/6] pcie aer fixes

2010-12-09 Thread Michael S. Tsirkin
On Wed, Dec 08, 2010 at 05:46:22PM +0900, Isaku Yamahata wrote: I respined the patch series by mst for bisectability. Applied, thanks. Changes v1 - v2: - reorder patches for bisectability - s/assert/trigger/ to avoid name conflict - abort() instead of assert(0) Original patch

[Qemu-devel] [PATCH 09/14] ceph/rbd block driver for qemu-kvm

2010-12-09 Thread Kevin Wolf
From: Christian Brunner c...@muc.de RBD is an block driver for the distributed file system Ceph (http://ceph.newdream.net/). This driver uses librados (which is part of the Ceph server) for direct access to the Ceph object store and is running entirely in userspace (Yehuda also wrote a driver for

[Qemu-devel] [PATCH 2/2] Make img_create() use strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This reestablished the old default of using bytes as the default for the size argument, and not MB as we do in pretty much every other place. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c |2 +- 1 files changed, 1

[Qemu-devel] [PATCH v3 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c |

[Qemu-devel] Re: [PATCH] kvm: x86: Save/restore error_code

2010-12-09 Thread Juan Quintela
Jason Wang jasow...@redhat.com wrote: The saving and restoring of error_code seems lost and convert the error_code to uint32_t. Signed-off-by: Jason Wang jasow...@redhat.com --- target-i386/cpu.h |4 ++-- target-i386/machine.c |2 ++ 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH 5/6] qemu,qmp: QError: New QERR_UNKNOWN_KEY

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/qerror.c b/qerror.c index fd66d2a..07b4cfc 100644 --- a/qerror.c +++ b/qerror.c @@ -205,6 +205,10 @@ static const QErrorStringTable qerror_table[] = { .desc = An undefined error has ocurred, }, { +

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Fabien Chouteau
On 12/09/2010 12:06 PM, Edgar E. Iglesias wrote: On Thu, Dec 09, 2010 at 12:03:35PM +0100, Fabien Chouteau wrote: On 12/09/2010 11:32 AM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteauchout...@adacore.com ---

[Qemu-devel] [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH v4 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch set introduces strtosz_suffix() which is needed to be able to use strtosz parsing with a non MB default suffix. This is used to clean up qemu-img.c:img_create(). Kevin asked me to rebase this instead of applying the other patches on top, so

[Qemu-devel] [PATCH 2/2] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c |

[Qemu-devel] [PATCH 04/24] usb storage: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb storage driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c | 167 ++ 1 files changed, 63 insertions(+), 104 deletions(-) diff --git a/hw/usb-msd.c

[Qemu-devel] Re: [PATCH 2/3] block: Introduce path_has_protocol() function

2010-12-09 Thread Kevin Wolf
Am 30.11.2010 16:14, schrieb Stefan Hajnoczi: The bdrv_find_protocol() function returns NULL if an unknown protocol name is given. It returns the file protocol when the filename contains no protocol at all. This makes it difficult to distinguish between paths which contain a protocol and

[Qemu-devel] [PATCH 01/24] usb: data structs and helpers for usb descriptors.

2010-12-09 Thread Gerd Hoffmann
This patch adds hw/usb-desc.[ch] files. They carry data structures for various usb descriptors and helper functions to generate usb packets from the structures. The intention is to have a internal representation of the device desription which is more usable than the current char array blobs, so

[Qemu-devel] [PATCH 02/24] usb hid: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb hid drivers (keyboard, mouse, tablet) over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c | 448 +++--- 1 files changed, 205 insertions(+), 243 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Fabien Chouteau
On 12/09/2010 11:32 AM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteauchout...@adacore.com --- hw/grlib_irqmp.c | 416 ++ 1 files changed, 416 insertions(+), 0

[Qemu-devel] [PATCH 05/24] usb wacom: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb wavom driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-wacom.c | 178 +++- 1 files changed, 73 insertions(+), 105 deletions(-) diff --git a/hw/usb-wacom.c

[Qemu-devel] [PATCH 09/24] usb storage: serial number support

2010-12-09 Thread Gerd Hoffmann
If a serial number is present for the drive fill it into the usb serialnumber string descriptor. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 20ab886..9aa 100644

[Qemu-devel] [PATCH 06/14] Fix formatting and missing braces in qemu-img.c

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 77 +++ 1 files changed,

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-09 Thread Kevin Wolf
Am 08.12.2010 13:13, schrieb Alexander Graf: The ATA core is currently heavily intertwined with BMDMA code. Let's loosen that a bit, so we can happily replace the DMA backend with different implementations. Signed-off-by: Alexander Graf ag...@suse.de --- v7 - v8: - rewrite as DMA

[Qemu-devel] [PATCH 07/24] usb hub: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb hub driver over to the new descriptor infrastructure. It also removes the nr_ports variable and MAX_PORTS define and introduces a NUM_PORTS define instead. The numver of ports was (and still is) fixed at 8 anyway. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c |

[Qemu-devel] [PATCH 20/24] usb: add attach callback

2010-12-09 Thread Gerd Hoffmann
Add handle_attach() callback to USBDeviceInfo which is called by the generic package handler when the device is attached to the usb bus (i.e. plugged into a port). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.c |7 ++- hw/usb.h |5 + 2 files changed, 11

[Qemu-devel] [PATCH 18/24] usb: hid: remote wakeup support.

2010-12-09 Thread Gerd Hoffmann
Add usb_wakeup() call to the hid driver so remote wakeup actually works. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 1c35960..60fa57f 100644 --- a/hw/usb-hid.c +++

[Qemu-devel] [PATCH 08/14] Make error handling more consistent in img_create() and img_resize()

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 6fd52e9..5b6e648

[Qemu-devel] Invitation to connect on LinkedIn

2010-12-09 Thread Anbang Ruan via LinkedIn
LinkedIn Anbang Ruan requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Anbang Accept invitation from Anbang Ruan

[Qemu-devel] Re: [PATCH] fix qruncom compilation problems

2010-12-09 Thread Paolo Bonzini
On 12/08/2010 10:43 PM, Stefano Bonifazi wrote: I've linked qemu-malloc.o and cutils.o together with qruncom.c and I managed to succesfully make it! here the make line: #$(MAKE) -C ../i386-linux-user libqemu.a $(CC) $(CFLAGS) -fomit-frame-pointer $(LDFLAGS) -I../target-i386 -I.. -I../linux-user

[Qemu-devel] [PATCH 12/14] qemu-option: Fix parse_option_parameters() documentation typo

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Yoda said, list is the templace is. Fix this. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-option.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 23/24] usb storage: high speed support

2010-12-09 Thread Gerd Hoffmann
Add high speed support to the usb mass storage device. With this patch applied the linux kernel recognises the usb storage device as highspeed capable device and suggests to connect it to a highspeed port instead of the uhci. Tested with both uhci and (not-yet submitted) ehci. Signed-off-by:

[Qemu-devel] [PATCH 2/6] qemu, qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, we need to use it(via libvirt). It is trivial, as it never fails, doesn't have output nor return any data. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 7a49b74..2e6b034 100644 ---

[Qemu-devel] Re: [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 14/14] qemu-img: Fail creation if backing format is invalid

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The qemu-img create command should check the backing format to ensure only image files with valid backing formats are created. By checking in qemu-img.c we can print a useful error message. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [Bug 687733] [NEW] Linux KSM not compiled in (MADV_MERGEABLE always undef)

2010-12-09 Thread Walter Haidinger
Public bug reported: Linux KSM support is not enabled because MADV_MERGEABLE remains undefined. It seems that asm-generic/mman-common.h is not included. Maybe some kind of header dependency problem? Adding #include asm-generic/mman-common.h to exec.c of qemu-kvm-0.13.0 enables use of KSM and

[Qemu-devel] [PATCH 0/2] Fix size default for qemu-img

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Kevin pointed out that my chance to img_create()'s handling of the image size, changed the previous default of byte for size if no suffix was specified, since strtosz() defaults to MB. This patch set introduces strtosz_suffix() and then changes

[Qemu-devel] [PATCH 00/24] usb descriptor overhaul.

2010-12-09 Thread Gerd Hoffmann
Hi, This patch series is the start for an overhaul of the usb descriptor handling for emulated usb devices. Instead of storing the device desriptors in blobs (aka char arrays) they are stored in structs, which makes it alot easier to work with them. This in turn allows to move common device

[Qemu-devel] [PATCH 05/14] Consolidate printing of block driver options

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com This consolidates the printing of block driver options in print_block_option_help() which is called from both img_create() and img_convert(). This allows for the ? detection to be done just after the parsing of options and the filename, instead of half

[Qemu-devel] [PATCH 10/14] qemu-img: Deprecate obsolete -6 and -e options

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com If -6 or -e is specified, an error message is printed and we exit. It does not print help() to avoid the error message getting lost in the noise. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 1/1] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH 03/24] usb serial: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb serial drivers (serial, braille) over to the new descriptor infrastructure. Note that this removes the freely configurable vendor and product id properties. I think the only reason this was configurable is that the only difference between the serial and the braille device is the

[Qemu-devel] [PATCH] kvm: x86: Save/restore error_code

2010-12-09 Thread Jason Wang
The saving and restoring of error_code seems lost and convert the error_code to uint32_t. Signed-off-by: Jason Wang jasow...@redhat.com --- target-i386/cpu.h |4 ++-- target-i386/machine.c |2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.h

[Qemu-devel] [PATCH 11/14] qemu-option: Don't reinvent append_option_parameters()

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com parse_option_parameters() may need to create a new option parameter list from a template list. Use append_option_parameters() instead of duplicating the code. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH] migration: ide: drop ide_pci_post_load()

2010-12-09 Thread Jason Wang
When the bmdma transfering ended, the unit were set to -1(0xFF), but after migration ide_pci_post_load() would change it to 1. This is not intended and it also would break the migration stability that we could not get exactly the same exec file before and after migration. So this patch drop the

[Qemu-devel] [PATCH 19/24] usb: add speed mask to ports

2010-12-09 Thread Gerd Hoffmann
Add a field to usb ports indicating the speed(s) they are able to handle. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |3 ++- hw/usb-hub.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |3 ++- hw/usb-uhci.c |3 ++- hw/usb.h |9 - 6 files

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-09 Thread Gerd Hoffmann
Hi, New features developed for the kernel are done in a separate git trees. When a feature is ready for inclusion into the main kernel tree, a pull request is sent. That workflow maintains a complete change history for the feature. Take performance events for example: you can go into Linus'

[Qemu-devel] [PATCH 15/24] usb: rework attach/detach workflow

2010-12-09 Thread Gerd Hoffmann
Add separate detach callback to USBPortOps, split uhci/ohci/musb/usbhub attach functions into two. Move common code to the usb_attach() function, only the hardware-specific bits remain in the attach/detach callbacks. Keep track of the port it is attached to for each usb device. Signed-off-by:

[Qemu-devel] Re: [PATCH] migration: ide: drop ide_pci_post_load()

2010-12-09 Thread Juan Quintela
Jason Wang jasow...@redhat.com wrote: When the bmdma transfering ended, the unit were set to -1(0xFF), but after migration ide_pci_post_load() would change it to 1. This is not intended and it also would break the migration stability that we could not get exactly the same exec file before and

[Qemu-devel] Re: [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function

2010-12-09 Thread Gerd Hoffmann
On 11/26/10 19:13, Hans de Goede wrote: The next patch in this series introduces multiple ways to get the alt setting dependent upon usb_fs_type, it is cleaner to put this into its own function. Note that this patch also changes the assumed alt setting in case of an error getting the alt

[Qemu-devel] [PATCH 2/2] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c |

Re: [Qemu-devel] IRC channel movement - FreeNode to OFTC

2010-12-09 Thread Mulyadi Santosa
On Wed, Dec 8, 2010 at 23:18, Anthony Liguori anth...@codemonkey.ws wrote: Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. OFTC is nice place too IMHO... but if it's not a top secret, why move? -- regards, Mulyadi Santosa Freelance Linux

[Qemu-devel] [PULL] spice: add qxl device, qmp events + monitor commands.

2010-12-09 Thread Gerd Hoffmann
The following changes since commit 138b38b61bf92d4e9588acf934e532499c94e185: ppc: kvm: fix signedness warning (2010-12-08 21:30:19 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu spice.v23.pull Gerd Hoffmann (7): spice: add qxl vgabios binary.

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Scott Moser
** Changed in: kvm (Ubuntu) Status: New = Invalid ** Changed in: qemu (Ubuntu) Status: New = Invalid ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided = Medium ** Changed in: qemu-kvm (Ubuntu) Status: New = Triaged -- You received this bug notification because you

[Qemu-devel] Re: [PATCH] fix qruncom compilation problems

2010-12-09 Thread Stefano Bonifazi
On 12/09/2010 08:16 AM, Paolo Bonzini wrote: On 12/08/2010 10:43 PM, Stefano Bonifazi wrote: Anyway running it with a com file as argument gave the error: mmap: Operation not permitted You have to run it as root I think. Paolo Thank you! Running as root worked, though it raises then the

[Qemu-devel] Re: IRC channel movement - FreeNode to OFTC

2010-12-09 Thread François Revol
Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. - what's wrong with freenode ? everyone is there. - #define OFTC ? François.

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Thu, Dec 09, 2010 at 12:03:35PM +0100, Fabien Chouteau wrote: On 12/09/2010 11:32 AM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteauchout...@adacore.com --- hw/grlib_irqmp.c | 416

Re: [Qemu-devel] IRC channel movement - FreeNode to OFTC

2010-12-09 Thread Anthony Liguori
On 12/09/2010 09:12 AM, Mulyadi Santosa wrote: On Wed, Dec 8, 2010 at 23:18, Anthony Liguorianth...@codemonkey.ws wrote: Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. OFTC is nice place too IMHO... but if it's not a top secret,

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Kevin Wolf wrote: Am 09.12.2010 16:48, schrieb Alexander Graf: +static void ncq_cb(void *opaque, int ret) +{ +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; +IDEState *ide_state; + +if (ret 0) { +/* XXX error */ +} Missing error

[Qemu-devel] Re: [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 14:17, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com This patch set introduces strtosz_suffix() which is needed to be able to use strtosz parsing with a non MB default suffix. This is used to clean up qemu-img.c:img_create(). Kevin asked me to

[Qemu-devel] [PATCH 13/14] qemu-img: Free option parameter lists in img_create()

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Free option parameter lists in the img_create() error return path. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch set introduces strtosz_suffix() which is needed to be able to use strtosz parsing with a non MB default suffix. This is used to clean up qemu-img.c:img_create(). Kevin asked me to rebase this instead of applying the other patches on top, so

[Qemu-devel] Re: [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes Sorensen
On 12/09/10 13:53, Stefan Hajnoczi wrote: On Thu, Dec 09, 2010 at 01:13:33PM +0100, jes.soren...@redhat.com wrote: @@ -371,3 +377,8 @@ fail: return retval; } + +ssize_t strtosz(const char *nptr, char **end) +{ +return strtosz_suffix(nptr, end, 0); This obscures what the

[Qemu-devel] [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen

[Qemu-devel] [Bug 688052] [NEW] usb does not work 0.13.0

2010-12-09 Thread sirio81
Public bug reported: Hi all, I'm using both, debian lenny and debian squeeze. I installed qemu-kvm (0.12.5) form debian repository but I got problem trying to pass a host usb device to the guest. I compiled so the latest stable version (0.13.0) hoping that the problem was fixed. It didn't

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2010-12-09 Thread sirio81
** Attachment added: host hardware details https://bugs.launchpad.net/bugs/688052/+attachment/1760810/+files/host_info.txt.gz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/688052 Title: usb

[Qemu-devel] Re: [PATCH v2] block: Introduce path_has_protocol() function

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 12:53, schrieb Stefan Hajnoczi: The bdrv_find_protocol() function returns NULL if an unknown protocol name is given. It returns the file protocol when the filename contains no protocol at all. This makes it difficult to distinguish between paths which contain a protocol and

[Qemu-devel] Re: [PATCH 2/6] qemu, qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:00 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Convert do_inject_nmi() to QObject, we need to use it(via libvirt). Patches 0/6 and 1/6 are missing. Also, I see that you're converting two unrelated commands in the same series. Please, split into two series. It

  1   2   >