[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
diff --git a/hw/piix4.c b/hw/piix4.c index 5489386..1678898 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = { .qdev.desc= ISA bridge, .qdev.size= sizeof(PCIDevice), .qdev.no_user = 1, +.qdev.no_hotplug

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-06 Thread Stefan Hajnoczi
On Tue, Jan 4, 2011 at 9:44 PM, Chunqiang Tang ct...@us.ibm.com wrote: Happy new year! We would like to contribute a new year gift to the community. We == IBM Research? The FVD patch also includes a fully automated testing framework that exercises QEMU block device drivers under stress load

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 09:40:52AM +0100, Gerd Hoffmann wrote: diff --git a/hw/piix4.c b/hw/piix4.c index 5489386..1678898 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = { .qdev.desc= ISA bridge, .qdev.size=

[Qemu-devel] Re: [PATCH 0/4] ppc: Fix PReP emulation

2011-01-06 Thread Rob Landley
On Wednesday 05 January 2011 06:31:01 Alexander Graf wrote: On 05.01.2011, at 13:07, Rob Landley wrote: On Tuesday 04 January 2011 15:00:12 Alexander Graf wrote: I have this very issue with s390. The only host to run (and compile) this on is an s390. And few people have those. So it breaks

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 05:47:27PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 10:45:13PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote:

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-06 Thread Yoshiaki Tamura
2011/1/6 Michael S. Tsirkin m...@redhat.com: On Thu, Jan 06, 2011 at 05:47:27PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 10:45:13PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at

Re: [Qemu-devel] [Bug 697510] [NEW] Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2011-01-06 Thread Stefan Hajnoczi
On Wed, Jan 5, 2011 at 5:05 AM, TiCPU jeromepou...@gmail.com wrote: Using Virtio and Red Hat driver I get a STOP screen 0x10d1 and machine either reboot, stay frozen or shut off. Here the minidump would be useful and we should get in touch with the person that maintains the virtio-blk

[Qemu-devel] [PATCH] spice/qxl: zap spice 0.4 migration compatibility bits

2011-01-06 Thread Gerd Hoffmann
Live migration from and to spice 0.4 qxl devices isn't going to work. Rip out the bits which attempt to support that. Zap the subsection logic which is obsolete now. Bumb the version to make a clean cut. This should obviously go in before 0.14 is released. Signed-off-by: Gerd Hoffmann

[Qemu-devel] Re: [PATCH 03/13] Add callback function to ThreadletWork structure.

2011-01-06 Thread Arun R Bharadwaj
* Stefan Hajnoczi stefa...@linux.vnet.ibm.com [2011-01-05 19:54:17]: On Tue, Jan 04, 2011 at 10:57:20AM +0530, Arun R Bharadwaj wrote: +static void aio_thread(ThreadletWork *work) +{ aio_thread() is not a descriptive name here. This isn't the top-level thread function, just the

[Qemu-devel] Re: [PATCH 01/13] Add aiocb_mutex and aiocb_completion.

2011-01-06 Thread Arun R Bharadwaj
* Stefan Hajnoczi stefa...@linux.vnet.ibm.com [2011-01-05 19:53:44]: On Tue, Jan 04, 2011 at 10:57:08AM +0530, Arun R Bharadwaj wrote: @@ -545,13 +555,19 @@ static void paio_cancel(BlockDriverAIOCB *blockacb) } mutex_unlock(lock); -if (active) { -/* fail safe:

Re: [Qemu-devel] Usefulness of the bug tracker

2011-01-06 Thread Stefan Hajnoczi
Patches that are being submitted shouldn't go on the bug tracker. I have edited the QEMU wiki to make this clearer: http://wiki.qemu.org/Contribute/SubmitAPatch http://wiki.qemu.org/Contribute/ReportABug Hopefully this will help first-time bug reporters put things in the right place. You

Re: [Qemu-devel] Usefulness of the bug tracker

2011-01-06 Thread Stefan Hajnoczi
On Thu, Jan 6, 2011 at 10:28 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Patches that are being submitted shouldn't go on the bug tracker.  I have edited the QEMU wiki to make this clearer: http://wiki.qemu.org/Contribute/SubmitAPatch http://wiki.qemu.org/Contribute/ReportABug Hopefully

[Qemu-devel] [PATCH] vnc/spice: fix never and now expire_time

2011-01-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com --- monitor.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index f258000..038d532 100644 --- a/monitor.c +++ b/monitor.c @@ -1136,9 +1136,9 @@ static int expire_password(Monitor *mon, const

[Qemu-devel] Re: [PATCH 06/13] Threadlet: Add dequeue_work threadlet API

2011-01-06 Thread Arun R Bharadwaj
* Stefan Hajnoczi stefa...@linux.vnet.ibm.com [2011-01-05 19:55:46]: On Tue, Jan 04, 2011 at 10:57:39AM +0530, Arun R Bharadwaj wrote: @@ -574,33 +574,39 @@ static void paio_remove(struct qemu_paiocb *acb) } } -static void paio_cancel(BlockDriverAIOCB *blockacb) +/** + *

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Stefan Hajnoczi
On Wed, Jan 5, 2011 at 5:01 PM, Serge E. Hallyn se...@hallyn.com wrote: I don't see this patch in the git tree, nor a revert of the buggy commit.  Was any decision made on this? Blue Swirl posted a patch a few days ago: [PATCH] pc: move port 92 stuff back to pc.c from pckbd.c It hasn't been

Re: [Qemu-devel] [PATCH] spice: add chardev (v3)

2011-01-06 Thread Gerd Hoffmann
On 12/17/10 16:01, Anthony Liguori wrote: On 12/17/2010 07:39 AM, Alon Levy wrote: Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. Example usage: qemu -device virtio-serial -chardev spicevmc,name=vdagent,id=vdagent

Re: [Qemu-devel] [PATCH] spice: add chardev (v3)

2011-01-06 Thread Alon Levy
On Thu, Jan 06, 2011 at 01:05:33PM +0100, Gerd Hoffmann wrote: On 12/17/10 16:01, Anthony Liguori wrote: On 12/17/2010 07:39 AM, Alon Levy wrote: Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. Example usage: qemu

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Andreas Färber
Am 05.01.2011 um 11:21 schrieb Aurelien Jarno: On Wed, Jan 05, 2011 at 09:15:43AM +0100, Andreas Färber wrote: Am 05.01.2011 um 00:56 schrieb Aurelien Jarno: HPPA code has still to be ported to TCG. Yes it still uses dyngen. Oh. I was pretty sure I saw TCG host support patches... Yes,

Re: [Qemu-devel] [Bug 697510] [NEW] Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2011-01-06 Thread Stefan Hajnoczi
On Thu, Jan 6, 2011 at 9:43 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jan 5, 2011 at 5:05 AM, TiCPU jeromepou...@gmail.com wrote: Using Virtio and Red Hat driver I get a STOP screen 0x10d1 and machine either reboot, stay frozen or shut off. Here the minidump would be useful

[Qemu-devel] [PATCH 5/5] ccid: add docs

2011-01-06 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff

[Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2)

2011-01-06 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and

[Qemu-devel] [PATCH 0/5] usb-ccid (v13)

2011-01-06 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 2/5] ccid: add passthru card device

2011-01-06 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy al...@redhat.com ---

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-06 Thread Serge Hallyn
Please test the package at https://launchpad.net/~serge-hallyn/+archive/testkernel If that kernel works, I'll complete the SRU process to request the maverick kernel get this patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus

2011-01-06 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how simple the change is. Respin goes to the list shortly. cheers, Gerd

[Qemu-devel] [PATCH v2 0/4] add hotplug opt-out option for pci devices.

2011-01-06 Thread Gerd Hoffmann
Hi, This patch series adds a flag which allows pci devices being tagged as not hotpluggable. It also sets this flag for a number of devices. [ v2: fix mips build failure ] [ v2: add patch for qxl ] Gerd Hoffmann (4): pci: allow devices being tagged as not hotpluggable. piix: tag as

[Qemu-devel] [PATCH v2 4/4] qxl: tag as not hotpluggable

2011-01-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 207aa63..bd71e58 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1546,6 +1546,7 @@ static PCIDeviceInfo qxl_info_primary = { .qdev.size=

[Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
This patch adds a field to PCIDeviceInfo to tag devices as being not hotpluggable. Any attempt to plug-in or -out such a device will throw an error. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pci.c | 10 ++ hw/pci.h |3 +++ qerror.c |4 qerror.h |3 +++ 4

[Qemu-devel] [PATCH v2 3/4] vga: tag as not hotplugable.

2011-01-06 Thread Gerd Hoffmann
This patch tags all vga cards as not hotpluggable. The qemu standard vga will never ever be hotpluggable. For cirrus + vmware it might be possible to get that work some day. Todays we can't handle that for a number of reasons though. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
This patch tags all pci devices which belong to the piix3/4 chipsets as not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c |2 ++ hw/ide/piix.c |2 ++ hw/piix4.c |1 + hw/piix_pci.c |

[Qemu-devel] [PATCH] spice: add chardev (v4)

2011-01-06 Thread Alon Levy
Adding a chardev backend for spice, where spice determines what to do with it based on the name attribute given during chardev creation. For usage by spice vdagent in conjunction with a properly named virtio-serial device, and future smartcard channel usage. Example usage: qemu -device

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how simple the change is. Yes but I don't know whether the untested devices this

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote: On Wed, Jan 05, 2011 at 11:21:06AM +0100, Aurelien Jarno wrote: But that's not the subject we are talking about HPPA guest support. target-hppa fork still (partially) uses dyngen code, which we don't support in upstream for

Re: [Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 01:04:51PM -0600, Ryan Harper wrote: * Ryan Harper ry...@us.ibm.com [2011-01-04 09:49]: * Aurelien Jarno aurel...@aurel32.net [2010-12-25 16:37]: On Wed, Dec 08, 2010 at 04:27:45PM -0200, Luiz Capitulino wrote: On Wed, 08 Dec 2010 12:23:12 -0600 Anthony

[Qemu-devel] [PATCH] linux-user: Implement sync_file_range{, 2} syscalls

2011-01-06 Thread Peter Maydell
Implement the missing syscalls sync_file_range and sync_file_range2. The latter in particular is used by newer versions of apt on Ubuntu for ARM. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- configure | 18 ++ linux-user/strace.list |6 ++

[Qemu-devel] Re: [PATCH 1/3] pci: allow devices being tagged as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Tue, Nov 30, 2010 at 02:26:02PM +0100, Gerd Hoffmann wrote: This patch adds a field to PCIDeviceInfo to tag devices as being not hotpluggable. Any attempt to plug-in or -out such a device will throw an error. Signed-off-by: Gerd Hoffmann kra...@redhat.com Acked-by: Michael S. Tsirkin

[Qemu-devel] [PATCH 1/2] linux-user: Support ioctls whose parameter size is not constant

2011-01-06 Thread Peter Maydell
Some ioctls (for example FS_IOC_FIEMAP) use structures whose size is not constant. The generic argument conversion code in do_ioctl() cannot handle this, so add support for implementing a special-case handler for a particular ioctl which does the conversion itself. Signed-off-by: Peter Maydell

[Qemu-devel] Re: [PATCH 2/3] target-ppc: fix default qNaN

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 06:09:34PM +0100, Alexander Graf wrote: On 02.01.2011, at 15:39, Aurelien Jarno wrote: On PPC the default qNaN doesn't have the sign bit set. The spec says don't care for the sign bit. Did you extract the value empirically? I'm not saying it's wrong - the

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 02:10:36PM +0100, Andreas Färber wrote: Am 05.01.2011 um 11:21 schrieb Aurelien Jarno: I'll commit it in 6 months if nothing has changed with regards to HPPA. Just pointing out that there were 5 months without activity from yourself last year. It happens, Real Life

[Qemu-devel] Re: Usefulness of the bug tracker

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 10:28:46AM +, Stefan Hajnoczi wrote: The real problem is that we're collecting bugs but not effectively investigating and fixing them. Can Launchpad send out automatic bug summary emails once every week/two weeks/month? Launchpad is at least part of the problem.

[Qemu-devel] Re: [PATCH 0/3] add hotplug opt-out option for pci devices.

2011-01-06 Thread Michael S. Tsirkin
On Wed, Jan 05, 2011 at 05:57:24PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 30, 2010 at 02:26:01PM +0100, Gerd Hoffmann wrote: Hi, This patch series adds a flag which allows pci devices being tagged as not hotpluggable. It also sets this flag for a number of devices. cheers,

[Qemu-devel] [PATCH 0/2] linux-user: implement FS_IOC_FIEMAP ioctl

2011-01-06 Thread Peter Maydell
This patchset implements support for the Linux FS_IOC_FIEMAP ioctl. This is used by apt (or possibly one of the programs it runs) when it is installing packages. The major effect of this fix is that qemu no longer spits out warnings about the ioctl being unimplemented when you use it to install

[Qemu-devel] [PATCH 2/2] linux-user: Implement FS_IOC_FIEMAP ioctl

2011-01-06 Thread Peter Maydell
Implement the FS_IOC_FIEMAP ioctl using the new support for custom handling of ioctls; this is needed because the struct that is passed includes a variable-length array. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/ioctls.h|4 ++ linux-user/syscall.c |

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 14:35, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote:    Is there any plan to deal with use of float*_is_quiet_nan(), where    float*_is_any_nan() was intended?  These should really either be    fixed (and tested), or

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: On 1 January 2011 18:25, Aurelien Jarno aurel...@aurel32.net wrote: SMMLA and SMMLS are broken on both in normal and thumb mode, that is both (different) implementations are wrong. They try to avoid a 64-bit add for the

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 15:50, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: Isn't this adding b to the msw of a, rather than the other way round as the comment claims? I think the comment is actually wrong in both way, as a shift is

[Qemu-devel] [PATCH] do_snapshot_blkdev() error on missing snapshot_file argument

2011-01-06 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Current code does not support snapshot internally to the running image. Error in case no snapshot_file is specified. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- blockdev.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-)

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Serge E. Hallyn
Thanks, Stefan. That patch actually doesn't compile for me, because it leaves references in hw/pckbd.c to both ioport92_write and ioport92_read, which it deletes from there. Should ioport92_read just be renamed to outport_read instead of delted, and the remaining references changed to

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Stefan Hajnoczi
Here are 4k sequential read results (cache=none) to check whether we see an ioeventfd performance regression with virtio-blk. The idea is to use a small blocksize with an I/O pattern (sequential reads) that is cheap and executes quickly. Therefore we're doing many iops and the cost virtqueue

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 04:41:50PM +, Stefan Hajnoczi wrote: Here are 4k sequential read results (cache=none) to check whether we see an ioeventfd performance regression with virtio-blk. The idea is to use a small blocksize with an I/O pattern (sequential reads) that is cheap and

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 03:54:46PM +, Peter Maydell wrote: On 6 January 2011 15:50, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: Isn't this adding b to the msw of a, rather than the other way round as the comment claims?

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 04:41:50PM +, Stefan Hajnoczi wrote: Here are 4k sequential read results (cache=none) to check whether we see an ioeventfd performance regression with virtio-blk. The idea is to use a small blocksize with an I/O pattern (sequential reads) that is cheap and

[Qemu-devel] [PATCH 29/35] kvm: Drop smp_cpus argument from init functions

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com No longer used. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |4 ++-- kvm-stub.c |2 +- kvm.h |4 ++-- target-i386/kvm.c |2 +-

[Qemu-devel] [PATCH 08/35] kvm: introduce kvm_inject_x86_mce_on

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com Pass a table instead of multiple args. Note: kvm_inject_x86_mce(env, bank, status, mcg_status, addr, misc, abort_on_error); is equal to: struct kvm_x86_mce mce = { .bank = bank, .status = status,

[Qemu-devel] [PATCH 19/35] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This code path will not yet be taken as we still lack in-kernel irqchip support. But qemu-kvm can already make use of it and drop its own mp_state access services. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 32/35] kvm: Flush coalesced mmio buffer on IO window exits

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com We must flush pending mmio writes if we leave kvm_cpu_exec for an IO window. Otherwise we risk to loose those requests when migrating to a different host during that window. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 01/35] kvm: Enable user space NMI injection for kvm guest

2011-01-06 Thread Marcelo Tosatti
From: Lai Jiangshan la...@cn.fujitsu.com Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space raised them. (example: qemu monitor's nmi command) Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com Acked-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo

[Qemu-devel] [PATCH 30/35] kvm: Consolidate must-have capability checks

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Instead of splattering the code with #ifdefs and runtime checks for capabilities we cannot work without anyway, provide central test infrastructure for verifying their availability both at build and runtime. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] [PATCH 09/35] kvm: x86: Fix DPL write back of segment registers

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com The DPL is stored in the flags and not in the selector. In fact, the RPL may differ from the DPL at some point in time, and so we were corrupting the guest state so far. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity

[Qemu-devel] [PATCH 10/35] kvm: x86: Remove obsolete SS.RPL/DPL aligment

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This seems to date back to the days KVM didn't support real mode. The check is no longer needed and, even worse, is corrupting the guest state in case SS.RPL != DPL. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com

[Qemu-devel] [PATCH 34/35] kvm: x86: Implicitly clear nmi_injected/pending on reset

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com All CPUX86State variables before CPU_COMMON are automatically cleared on reset. Reorder nmi_injected and nmi_pending to avoid having to touch them explicitly. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 11/35] kvm: x86: Prevent sign extension of DR7 in guest debugging mode

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This unbreaks guest debugging when the 4th hardware breakpoint used for guest debugging is a watchpoint of 4 or 8 byte lenght. The 31st bit of DR7 is set in that case and used to cause a sign extension to the high word which was breaking the guest state (vm

[Qemu-devel] [PATCH 03/35] Clean up cpu_inject_x86_mce()

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com Clean up cpu_inject_x86_mce() for later patch. Signed-off-by: Jin Dongming jin.dongm...@np.css.fujitsu.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/helper.c | 27 +-- 1 files changed, 17

[Qemu-devel] [PATCH 02/35] kvm: convert kvm_ioctl(KVM_CHECK_EXTENSION) to kvm_check_extension()

2011-01-06 Thread Marcelo Tosatti
From: Lai Jiangshan la...@cn.fujitsu.com simple cleanup and use existing helper: kvm_check_extension(). Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |2 +- target-i386/kvm.c |4 ++-- 2 files changed, 3

[Qemu-devel] [PATCH 23/35] kvm: x86: Reset paravirtual MSRs

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Make sure to write the cleared MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN to the kernel state so that a freshly booted guest cannot be disturbed by old values. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Glauber Costa

[Qemu-devel] [PATCH 22/35] kvm: x86: Refactor msr_star/hsave_pa setup and checks

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Simplify kvm_has_msr_star/hsave_pa to booleans and push their one-time initialization into kvm_arch_init. Also handle potential errors of that setup procedure. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 21/35] kvm: x86: Fix xcr0 reset mismerge

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com For unknown reasons, xcr0 reset ended up in kvm_arch_update_guest_debug on upstream merge. Fix this and also remove the misleading comment (1 is THE reset value). Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 27/35] kvm: x86: Fix !CONFIG_KVM_PARA build

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If we lack kvm_para.h, MSR_KVM_ASYNC_PF_EN is not defined. The change in kvm_arch_init_vcpu is just for consistency reasons. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c |8

[Qemu-devel] [PATCH 20/35] kvm: x86: Remove redundant mp_state initialization

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com kvm_arch_reset_vcpu initializes mp_state, and that function is invoked right after kvm_arch_init_vcpu. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c |2 -- 1 files changed, 0

[Qemu-devel] [PATCH 24/35] Synchronize VCPU states before reset

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This is required to support keeping VCPU states across a system reset. If we do not read the current state before the reset, cpu_synchronize_all_post_reset may write back incorrect state information. The first user of this will be MCE MSR synchronization

[Qemu-devel] [PATCH 13/35] kvm: Fix coding style violations

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c | 139 ++-- 1 files changed, 79 insertions(+), 60

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 17:24, Aurelien Jarno aurel...@aurel32.net wrote: For the subtraction, how would you say a = (b 32) - a ? I think we should just say Return (b 32) - a for that :-) I can't think of a clean way of putting it in English. -- PMM

[Qemu-devel] [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com It is not used, it is not needed, so let's remove it. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |6 ++ kvm-stub.c |4 ++-- kvm.h |2 +- 3 files changed, 5

[Qemu-devel] [PATCH 16/35] kvm: Improve reporting of fatal errors

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Report KVM_EXIT_UNKNOWN, KVM_EXIT_FAIL_ENTRY, and KVM_EXIT_EXCEPTION with more details to stderr. The latter two are so far x86-only, so move them into the arch-specific handler. Integrate the Intel real mode warning on KVM_EXIT_FAIL_ENTRY that qemu-kvm

[Qemu-devel] [PATCH 17/35] x86: Optionally dump code bytes on cpu_dump_state

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Introduce the cpu_dump_state flag CPU_DUMP_CODE and implement it for x86. This writes out the code bytes around the current instruction pointer. Make use of this feature in KVM to help debugging fatal vm exits. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 05/35] Add function for checking mca broadcast of CPU

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com Add function for checking whether current CPU support mca broadcast. Signed-off-by: Jin Dongming jin.dongm...@np.css.fujitsu.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/cpu.h|1 + target-i386/helper.c | 33

[Qemu-devel] [PATCH 00/35] [PULL] qemu-kvm.git uq/master queue

2011-01-06 Thread Marcelo Tosatti
The following changes since commit 23979dc5411befabe9049e37075b2b6320debc4e: microblaze: Use more TB chaining (2011-01-05 02:23:09 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (27): kvm: x86: Fix DPL write back

[Qemu-devel] [PATCH 07/35] kvm: kvm_mce_inj_* subroutines for templated error injections

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com Refactor codes for maintainability. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Jin Dongming jin.dongm...@np.css.fujitsu.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c | 111

[Qemu-devel] [PATCH 15/35] kvm: Stop on all fatal exit reasons

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Ensure that we stop the guest whenever we face a fatal or unknown exit reason. If we stop, we also have to enforce a cpu loop exit. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-06 Thread Brian Murray
** Also affects: kvm (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: qemu-kvm (Ubuntu Maverick)

[Qemu-devel] [PATCH 31/35] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com In order to support loading BIOSes 256K, reorder the code, adjusting the base if the kernel supports moving the identity map. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c | 63

[Qemu-devel] [PATCH 04/35] Add broadcast option for mce command

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com When the following test case is injected with mce command, maybe user could not get the expected result. DATA command cpu bank status mcg_status addr misc (qemu) mce 1 10xbd00 0x05

[Qemu-devel] [PATCH 18/35] kvm: x86: Align kvm_arch_put_registers code with comment

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com The ordering doesn't matter in this case, but better keep it consistent. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c |6 +++--- 1 files changed, 3 insertions(+), 3

[Qemu-devel] [PATCH 12/35] kvm: x86: Fix a few coding style violations

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- target-i386/kvm.c | 335 + 1 files changed, 182 insertions(+), 153 deletions(-)

[Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 06/35] kvm: introduce kvm_mce_in_progress

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming jin.dongm...@np.css.fujitsu.com Share same error handing, and rename this function after MCIP (Machine Check In Progress) flag. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Jin Dongming jin.dongm...@np.css.fujitsu.com Signed-off-by: Marcelo

[Qemu-devel] [PATCH 25/35] kvm: x86: Drop MCE MSRs write back restrictions

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Huang Ying ying.hu...@intel.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] Re: [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 03:14:37PM +0100, Gerd Hoffmann wrote: This patch adds a field to PCIDeviceInfo to tag devices as being not hotpluggable. Any attempt to plug-in or -out such a device will throw an error. Signed-off-by: Gerd Hoffmann kra...@redhat.com Acked-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: On 5 January 2011 23:13, Stuart Brady s...@zubnet.me.uk wrote: I do have a few concerns regarding SoftFloat, though:   FIXMEs should be left in the code (or a document maintained on the   Wiki) to keep track of which

Re: [Qemu-devel] qemu branching internal questions

2011-01-06 Thread Mike Frysinger
On Wed, Jan 5, 2011 at 05:59, Edgar E. Iglesias wrote: On Tue, Jan 04, 2011 at 02:43:11PM -0500, Mike Frysinger wrote: i've been working on a new architecture port, but i cant quite figure out some of the intricacies from reading the code.  i have all the simple stuff working for linux-user

[Qemu-devel] [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate any need to refer to it outside of kvm-all.c. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Alexander Graf

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Blue Swirl
On Thu, Jan 6, 2011 at 4:41 PM, Serge E. Hallyn se...@hallyn.com wrote: Thanks, Stefan.  That patch actually doesn't compile for me, because it leaves references in hw/pckbd.c to both ioport92_write and ioport92_read, which it deletes from there.  Should ioport92_read just be renamed to

[Qemu-devel] [PATCH 0/2] linux-user: fix incorrect NaN detection in ARM nwfpe emulation

2011-01-06 Thread Peter Maydell
The code in the linux-user ARM nwfpe emulation was incorrectly checking only for quiet NaNs when it should have been checking for any kind of NaN. This is probably because the code in question was taken from the Linux kernel, whose copy of the softfloat library had been modified so that

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: On 6 January 2011 14:35, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote:    Is there any plan to deal with use of float*_is_quiet_nan(), where    float*_is_any_nan() was

Re: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Marcelo Tosatti
On Thu, Jan 06, 2011 at 04:34:38PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how

[Qemu-devel] Re: acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-06 Thread Marcelo Tosatti
On Wed, Jan 05, 2011 at 09:32:39PM +0200, Michael S. Tsirkin wrote: On Wed, Dec 08, 2010 at 03:11:36PM -0200, Marcelo Tosatti wrote: On top of add hotplug opt-out option for devices patchset http://www.mail-archive.com/qemu-devel@nongnu.org/msg46953.html. Signed-off-by: Marcelo

[Qemu-devel] [PATCH 2/2] linux-user: Fix incorrect NaN detection in ARM nwfpe emulation

2011-01-06 Thread Peter Maydell
The code in the linux-user ARM nwfpe emulation was incorrectly checking only for quiet NaNs when it should have been checking for any kind of NaN. This is probably because the code in question was taken from the Linux kernel, whose copy of the softfloat library had been modified so that

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:13, Stuart Brady s...@zubnet.me.uk wrote: On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: On 5 January 2011 23:13, Stuart Brady s...@zubnet.me.uk wrote: I do have a few concerns regarding SoftFloat, though:   FIXMEs should be left in the code (or a

[Qemu-devel] [PATCH 1/2] softfloat: Implement floatx80_is_any_nan() and float128_is_any_nan()

2011-01-06 Thread Peter Maydell
Implement versions of float*_is_any_nan() for the floatx80 and float128 types. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- fpu/softfloat.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h b/fpu/softfloat.h index f2104c6..ac81845

  1   2   >