[Qemu-devel] [PATCH] bsd-user: Fix possible memory leaks

2011-01-16 Thread Stefan Weil
These errors were reported by cppcheck: bsd-user/elfload.c:1076: error: Memory leak: s bsd-user/elfload.c:1079: error: Memory leak: syms Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- bsd-user/elfload.c |9 +++-- 1 files changed, 7 insertions(+),

[Qemu-devel] Re: [PATCH] bsd-user: Fix possible memory leaks

2011-01-16 Thread Blue Swirl
On Sun, Jan 16, 2011 at 12:56 PM, Stefan Weil w...@mail.berlios.de wrote: These errors were reported by cppcheck: bsd-user/elfload.c:1076: error: Memory leak: s bsd-user/elfload.c:1079: error: Memory leak: syms Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] bsd-user: Fix possible memory leaks

2011-01-16 Thread Peter Maydell
On 16 January 2011 12:56, Stefan Weil w...@mail.berlios.de wrote: diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 7374912..313ddc6 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/elfload.c @@ -1072,11 +1072,16 @@ static void load_symbols(struct elfhdr *hdr, int fd)     /* Now know

[Qemu-devel] [Bug 584153] Re: no useful error message when tap device open fails

2011-01-16 Thread Aurelien Jarno
** Changed in: qemu Status: In Progress = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584153 Title: no useful error message when tap device open fails Status in QEMU: Fix

[Qemu-devel] [Bug 573827] Re: QEMU 0.12.3 crashes on incomplete USB serial device parameter

2011-01-16 Thread Aurelien Jarno
** Changed in: qemu Status: In Progress = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/573827 Title: QEMU 0.12.3 crashes on incomplete USB serial device parameter Status in

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Raphael Lefevre
On Wed, Dec 15, 2010 at 4:17 AM, Stefano Bonifazi stefboombas...@gmail.com wrote: On 12/11/2010 03:44 PM, Blue Swirl wrote: Hi! Thank you very much! Knowing exactly where I should check, in a so big project helped me very much!! Anyway after having spent more than 2 days on that code

[Qemu-devel] [Bug 581737] Re: Can't read e1000 NIC EEPROM on NetBSD guest

2011-01-16 Thread Aurelien Jarno
** Changed in: qemu Status: Incomplete = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/581737 Title: Can't read e1000 NIC EEPROM on NetBSD guest Status in QEMU: Fix

[Qemu-devel] [Bug 578346] Re: ATA IDENTIFY DEVICE word 64 doesn't describe available PIO modes

2011-01-16 Thread Aurelien Jarno
** Changed in: qemu Status: New = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/578346 Title: ATA IDENTIFY DEVICE word 64 doesn't describe available PIO modes Status in QEMU:

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Stefano Bonifazi
On 01/16/2011 03:46 PM, Raphael Lefevre wrote: On Wed, Dec 15, 2010 at 4:17 AM, Stefano Bonifazi stefboombas...@gmail.com wrote: On 12/11/2010 03:44 PM, Blue Swirl wrote: Hi! Thank you very much! Knowing exactly where I should check, in a so big project helped me very much!!

Re: [Qemu-devel] [PATCH] bsd-user: Fix possible memory leaks

2011-01-16 Thread Stefan Weil
Am 16.01.2011 15:07, schrieb Peter Maydell: On 16 January 2011 12:56, Stefan Weil w...@mail.berlios.de wrote: diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 7374912..313ddc6 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/elfload.c @@ -1072,11 +1072,16 @@ static void

[Qemu-devel] [PATCH v2] bsd-user: Fix possible memory leaks and wrong realloc call

2011-01-16 Thread Stefan Weil
These errors were reported by cppcheck: [bsd-user/elfload.c:1108]: (error) Common realloc mistake: syms nulled but not freed upon failure [bsd-user/elfload.c:1076]: (error) Memory leak: s [bsd-user/elfload.c:1079]: (error) Memory leak: syms v2: * The previous fix for memory leaks was incomplete

Re: [Qemu-devel] Tracking unfreed tcg temps

2011-01-16 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 11:55:33PM +0100, Aurelien Jarno wrote: On Tue, Jan 11, 2011 at 06:09:06AM -0600, Peter Maydell wrote: The ARM target-arm/translate.c file has some code in it which tries to track the number of TCG temporaries allocated during translation of an ARM instruction and

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Raphaël Lefèvre
On Sun, Jan 16, 2011 at 11:21 PM, Stefano Bonifazi stefboombas...@gmail.com wrote: Thank you very much! I've already solved this problem.. Right now I am fighting with the possibility of changing qemu-user code for making it run several binaries in succession .. But it seems to remember the

[Qemu-devel] [Bug 659276] Re: Accessing Century byte via RTC

2011-01-16 Thread Aurelien Jarno
The century register is only present in recent version of the chip, and is at an address corresponding to the NVRAM memory. It is not manipulated directly by the RTC and therefore is always in BCD format. The current QEMU implementation is correct. ** Changed in: qemu Status: New = Invalid

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Stefano Bonifazi
Sorry for my belated on this discussion, after I searched for the topics you posted, it seems two main problems are unsolved? (Am I right?? I'm not sure...) 1. I edited QEMU user, more exactly qemu-ppc launching the main function (inside main.c) from another c function I created, passing it

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Peter Maydell
2011/1/16 Stefano Bonifazi stefboombas...@gmail.com: My workaround to this problem was compiling qemu-ppc as a dynamic library and load it at runtime.. I also managed to load multiple copies of it (with dlmopen each at a different address space) ..in fact I need to run more than one qemu-ppc

[Qemu-devel] [PATCH] usb-hid: modifiers should generate an event

2011-01-16 Thread Aurelien Jarno
When a modifier key is pressed or released, the USB HID keyboard still answers NAK, unless another key is also pressed or released. The patch fixes that by calling usb_hid_changed() when a modifier key is pressed or released. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- hw/usb-hid.c |

Re: [Qemu-devel] [PATCH] USB keyboard emulation key mapping error - debian#578846

2011-01-16 Thread Aurelien Jarno
On Mon, Oct 18, 2010 at 04:55:25PM +0400, Michael Tokarev wrote: Brad Jorsch ano...@users.sourceforge.net writes ( http://bugs.debian.org/578846 ): The USB keyboard emulation's translation table in hw/usb-hid.c doesn't match the codes actually sent for the Logo (a.k.a. Windows) or Menu

[Qemu-devel] [Bug 584139] Re: keymapping error for usb keyboard (windows/menu keys)

2011-01-16 Thread Aurelien Jarno
** Changed in: qemu Status: New = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584139 Title: keymapping error for usb keyboard (windows/menu keys) Status in QEMU: Fix

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Stefano Bonifazi
Thank you very much for Your fast reply! On 01/16/2011 07:29 PM, Peter Maydell wrote: Linux doesn't seem to have dlmopen http://www.unix.com/man-page/All/3c/dlmopen/ #define __USE_GNU #include dlfcn.h lib_handle1 = dlmopen(LM_ID_NEWLM,./libqemu-ppc.so, RTLD_NOW); I am developing that on a

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Raphaël Lefèvre
2011/1/17 Stefano Bonifazi stefboombas...@gmail.com: Hi! Thank you very much for Your concern! Honestly I had lost hope in any help, I even contacted directly some developers in this mailing list without luck! I guess many good developers in mailing list are still try their best to solve

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Peter Maydell
2011/1/16 Stefano Bonifazi stefboombas...@gmail.com: I need to make the different instances of qemu-user exchange data .. obviously keeping all of them in the same address space would be the easiest way (unless I have to change all qemu code ;) ) The problem is that you're trying to break a

Re: [Qemu-devel] [PATCH v2] gdbstub: Close connection in gdb_exit

2011-01-16 Thread Edgar E. Iglesias
On Thu, Jan 13, 2011 at 12:46:57PM +0100, Fabien Chouteau wrote: On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Version 2: Fix linux-user build error. Applied, thanks. Signed-off-by: Fabien Chouteau

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Stefano Bonifazi
Hi! In case you are interested in helping me, I'll give you a big piece of news I've just got (even my teacher is not informed yet! :) ) I've just managed to make more than one instance of qemu-user run at the same time linking the target code with a specified address for the code section

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-16 Thread Raphaël Lefèvre
2011/1/17 Stefano Bonifazi stefboombas...@gmail.com: Hi!  In case you are interested in helping me, I'll give you a big piece of news I've just got (even my teacher is not informed yet! :) ) I've just managed to make more than one instance of qemu-user run at the same time linking the target

Re: [Qemu-devel] [PATCH] m48t59: Fix a wrong opaque passed to nvram read and write routines

2011-01-16 Thread Aurelien Jarno
On Sun, Jan 02, 2011 at 07:44:49PM +0100, Hervé Poussineau wrote: This unregresses Sun4m and PPC prep/ref405ep machines Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/m48t59.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) Thanks, applied. diff --git

Re: [Qemu-devel] [PATCH, RFC 3/4] prep: Fix duplicate ISA IDE IRQ

2011-01-16 Thread Aurelien Jarno
On Tue, Dec 14, 2010 at 01:49:17AM +0100, Andreas Färber wrote: Calling isa_ide_init() twice with the same IRQ 13 fails: qemu: hardware error: isa irq 13 already assigned Use a different IRQ (14) for the second one to avoid this. I am not sure it is actually a good idea. While it fixes the

Re: [Qemu-devel] RFC: mass comment conversion from C99 to C89

2011-01-16 Thread Peter Maydell
On 15 January 2011 16:02, Blue Swirl blauwir...@gmail.com wrote: With the sed script below (my first I think), I'm able to convert most files in QEMU from C99 comment style to C89. When successive line with C99 comments are converted, the comments are merged. Two files (hw/rtl8139.c and

[Qemu-devel] Re: [PATCH uq/master 2/2] MCE, unpoison memory address across reboot

2011-01-16 Thread Huang Ying
On Fri, 2011-01-14 at 16:38 +0800, Jan Kiszka wrote: Am 14.01.2011 02:51, Huang Ying wrote: On Thu, 2011-01-13 at 17:01 +0800, Jan Kiszka wrote: Am 13.01.2011 09:34, Huang Ying wrote: [snip] + +void kvm_unpoison_all(void *param) Minor nit: This can be static now. In uq/master, it

[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-16 Thread Paolo Bonzini
On 01/15/2011 06:45 PM, Blue Swirl wrote: + if ($level == 0 !$block =~ /^\s*\{/ !$allowed) { I'm not a Perl expert at all, but I think you need parentheses for the argument of !: if ($level == 0 !($block =~ /^\s*\{/) !$allowed) { Paolo

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-16 Thread Gerd Hoffmann
There are three cases: (1) no pressure supported (i.e. your mouse moving around in the vnc window and qemu reporting this as tablet coordinates). (2) just pen/finger present/not present supported. pressure jumps between 0 and max (and we can make max == 1 in that case). Phew - that's one of