[Qemu-devel] QEMU API for modelling of user's hardware

2011-03-28 Thread wzab
Hi, I wanted to prepare QEMU models of new hardware for my students, to let them to write and debug device drivers before the real hardware is available (or even to optimize the design of this hardware before it is really made). I was able to establish the basic communication with memory mapped

[Qemu-devel] Re: [PATCH 3/4] Introduce machine state

2011-03-28 Thread Paolo Bonzini
On 03/26/2011 11:28 PM, Blue Swirl wrote: Move generic machine state to machine-state.h, adjust users. What's the distinction between vm state and machine state? Perhaps your vm state is more appropriately called emulator state (i.e. sits between host and vm), and machine state is actually

[Qemu-devel] Re: [PATCH] floppy: save and restore DIR register

2011-03-28 Thread Paolo Bonzini
On 03/28/2011 04:40 AM, Jason Wang wrote: On 03/25/2011 07:27 AM, Jason Wang wrote: We need to keep DIR register unchanged across migration, but currently it depends on the media_changed flags from block layer and we do not save/restore it which could let the guest driver think the

Re: [Qemu-devel] [V2 PATCH] floppy: save and restore DIR register

2011-03-28 Thread Jes Sorensen
On 03/28/11 04:47, Jason Wang wrote: We need to keep DIR register unchanged across migration, but currently it depends on the media_changed flags from block layer. Since we do not save/restore it and the bdrv_open() called in dest node may set the media_changed flag when trying to open floppy

Re: [Qemu-devel] [PATCH v2] hw/pc: Support system flash memory with -pflash parameter

2011-03-28 Thread Jes Sorensen
On 03/24/11 03:07, jordan.l.jus...@intel.com wrote: +static void pc_isa_bios_init(ram_addr_t ram_offset, int ram_size) +{ +int isa_bios_size; + +/* map the last 128KB of the BIOS in ISA space */ +isa_bios_size = ram_size; +if (isa_bios_size (128 * 1024)) +

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Alexander Graf
On 28.03.2011, at 03:19, David Gibson wrote: On Fri, Mar 25, 2011 at 01:29:17PM -0500, Anthony Liguori wrote: On 03/24/2011 10:21 PM, David Gibson wrote: Currently, the emulated pSeries machine requires the use of the -kernel parameter in order to explicitly load a guest kernel. This means

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Markus Armbruster
Isaku Yamahata yamah...@valinux.co.jp writes: On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: Am 28.03.2011 04:17, schrieb Isaku Yamahata: [...] On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote: cirrus_reset is also called by the pci framework, so there is no need to

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Isaku Yamahata
On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: Isaku Yamahata yamah...@valinux.co.jp writes: On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: Am 28.03.2011 04:17, schrieb Isaku Yamahata: [...] On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote:

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-03-28 Thread Kevin Wolf
Am 26.03.2011 22:56, schrieb Dushyant Bansal: On the other hand, I think the starting point for a generic in-place converter would be a loop that does something like bdrv_is_allocated() but translates the guest position in the block device into an offset into the image file. That, together

[Qemu-devel] Re: [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Alexander Graf
On 25.03.2011, at 04:21, David Gibson wrote: Currently, the emulated pSeries machine requires the use of the -kernel parameter in order to explicitly load a guest kernel. This means booting from the virtual disk, cdrom or network is not possible. This patch addresses this limitation by

Re: [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-28 Thread Peter Maydell
On 26 March 2011 11:41, Blue Swirl blauwir...@gmail.com wrote: On Mon, Mar 21, 2011 at 7:47 PM, Peter Maydell peter.mayd...@linaro.org wrote: This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine structure so that a board model can specify the maximum RAM it will accept.

[Qemu-devel] Re: [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Paolo Bonzini
On 03/28/2011 12:30 PM, Alexander Graf wrote: diff --git a/pc-bios/README b/pc-bios/README index 3fc0944..646a31a 100644 --- a/pc-bios/README +++ b/pc-bios/README @@ -13,6 +13,11 @@ The included image for PowerPC (for 32 and 64 bit PPC CPUs), Sparc32 and Sparc64 are built from OpenBIOS SVN

[Qemu-devel] Re: [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Paolo Bonzini
On 03/28/2011 12:30 PM, Alexander Graf wrote: On 25.03.2011, at 04:21, David Gibson wrote: Currently, the emulated pSeries machine requires the use of the -kernel parameter in order to explicitly load a guest kernel. This means booting from the virtual disk, cdrom or network is not possible.

[Qemu-devel] Re: [PATCH] e1000: check buffer availability

2011-03-28 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: Reduce spurious packet drops on RX ring empty by verifying that we have at least 1 buffer ahead of the time. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

[Qemu-devel] Re: [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Alexander Graf
On 28.03.2011, at 12:51, Paolo Bonzini wrote: On 03/28/2011 12:30 PM, Alexander Graf wrote: diff --git a/pc-bios/README b/pc-bios/README index 3fc0944..646a31a 100644 --- a/pc-bios/README +++ b/pc-bios/README @@ -13,6 +13,11 @@ The included image for PowerPC (for 32 and 64 bit PPC

[Qemu-devel] Re: [V2 PATCH] floppy: save and restore DIR register

2011-03-28 Thread Juan Quintela
Jason Wang jasow...@redhat.com wrote: We need to keep DIR register unchanged across migration, but currently it depends on the media_changed flags from block layer. Since we do not save/restore it and the bdrv_open() called in dest node may set the media_changed flag when trying to open floppy

[Qemu-devel] Re: [PATCH v5 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Isaku Yamahata
On Sun, Mar 27, 2011 at 04:56:29PM +0200, Michael S. Tsirkin wrote: On Wed, Mar 23, 2011 at 11:17:19AM +0900, Isaku Yamahata wrote: v4 has minor typo. I sent it too early. Here's fixed one. v3 - v4 Main changes are - use pirq, pci_intx instead of irq_num in piix_pci.c - patch 4/4

[Qemu-devel] Re: [0/27] Implement emulation of pSeries logical partitions (v5)

2011-03-28 Thread Alexander Graf
On 25.03.2011, at 04:21, David Gibson wrote: This patch series adds a pseries machine to qemu, allowing it to emulate IBM pSeries logical partitions. More specifically it implements the interface defined by the PowerPC Architecture Platform Requirements document (PAPR, or sPAPR for short).

Re: [Qemu-devel] Relative/Absolute timing snapshot problem

2011-03-28 Thread Jes Sorensen
On 03/18/11 21:39, Clemens Kolbitsch wrote: Hi list, strange situation: When I create a snapshot using Qemu 0.14.0 stable, everything works smoothly and resuming the CPU takes about 1-2 seconds. If I don't use the snapshot file for some time, the time it takes to resume grows by 2-3

[Qemu-devel] Re: [PATCH v5 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Michael S. Tsirkin
On Mon, Mar 28, 2011 at 08:19:56PM +0900, Isaku Yamahata wrote: On Sun, Mar 27, 2011 at 04:56:29PM +0200, Michael S. Tsirkin wrote: On Wed, Mar 23, 2011 at 11:17:19AM +0900, Isaku Yamahata wrote: v4 has minor typo. I sent it too early. Here's fixed one. v3 - v4 Main changes are -

[Qemu-devel] Re: [PATCH] e1000: check buffer availability

2011-03-28 Thread Kevin Wolf
Am 27.03.2011 17:01, schrieb Michael S. Tsirkin: Reduce spurious packet drops on RX ring empty by verifying that we have at least 1 buffer ahead of the time. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: --- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) Acked-by: Jes Sorensen jes.soren...@redhat.com This should be able to go in as is - even

Re: [Qemu-devel] [PATCH v23 02/11] qemu-thread.h: include inttypes.h

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Acked-by: Jes

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

Re: [Qemu-devel] [PATCH v23 04/11] introduce libcacard/vscard_common.h

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: --- Signed-off-by: Alon Levy al...@redhat.com Reviewed-by: Jes Sorensen jes.soren...@redhat.com

Re: [Qemu-devel] [PATCH v23 05/11] ccid: add passthru card device

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it,

Re: [Qemu-devel] [PATCH v23 05/11] ccid: add passthru card device

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:08:45PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h

[Qemu-devel] [Bug 744195] Re: guest cannot boot with 8 VFs or more

2011-03-28 Thread Yongjie Ren
a related issues was reported and fiexed before, but the two is not the same problem. http://sourceforge.net/tracker/?func=detailaid=2847560group_id=180599atid=893831 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 744195] [NEW] guest cannot boot with 8 VFs or more

2011-03-28 Thread Yongjie Ren
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):All Guest OS (ia32/ia32e/IA64): All Guest OS Type (Linux/Windows): Linux kvm.git Commit:a3e2cba1e702cfe15e2ebb20a75b88f02c834d3f qemu-kvm Commit:2c9bb5d4e5ae3b12ad71bd6a0c1b32003661f53a Host Kernel Version:2.6.38+

Re: [Qemu-devel] [PATCH 4/4] trace: [simple] always enable trace points

2011-03-28 Thread Lluís
Last patch was missing the trace-events hunk. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu diff --git a/scripts/tracetool b/scripts/tracetool index 7506776..b355ac5 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -221,15 +221,10 @@ EOF linetoc_simple() { -local name state +

Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:35:23PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following

Re: [Qemu-devel] [PATCH 4/4] trace: [simple] always enable trace points

2011-03-28 Thread Lluís
Last time there was discussion on disabling all tracee points in simple by default, but providing an argument for a list of trace point to enable at startup. Instead, what I've done is enabling all trace points in simple by default. Given that disable will effectively disable all points,

Re: [Qemu-devel] [PATCH v23 07/11] libcacard: add vscclient

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. --- libcacard/Makefile|7 +- libcacard/vscclient.c | 730 +

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Avi Kivity
On 03/28/2011 11:03 AM, Alexander Graf wrote: I'm also not sure this is too important. Most of our firmware blobs come from svn repos which can't be submoduled. And as long as we don't have a consistent policy about it, we can just as well stick with the README file. We can have a git

Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following patch. Docs are available in docs/libcacard.txt Signed-off-by: Alon

Re: [Qemu-devel] [PATCH v23 07/11] libcacard: add vscclient

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:43:38PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. --- libcacard/Makefile|7 +-

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Alexander Graf
On 28.03.2011, at 14:49, Avi Kivity wrote: On 03/28/2011 11:03 AM, Alexander Graf wrote: I'm also not sure this is too important. Most of our firmware blobs come from svn repos which can't be submoduled. And as long as we don't have a consistent policy about it, we can just as well stick

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Avi Kivity
On 03/28/2011 02:53 PM, Alexander Graf wrote: On 28.03.2011, at 14:49, Avi Kivity wrote: On 03/28/2011 11:03 AM, Alexander Graf wrote: I'm also not sure this is too important. Most of our firmware blobs come from svn repos which can't be submoduled. And as long as we don't have a

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Alexander Graf
On 28.03.2011, at 15:02, Avi Kivity wrote: On 03/28/2011 02:53 PM, Alexander Graf wrote: On 28.03.2011, at 14:49, Avi Kivity wrote: On 03/28/2011 11:03 AM, Alexander Graf wrote: I'm also not sure this is too important. Most of our firmware blobs come from svn repos which can't be

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Anthony Liguori
On 03/27/2011 08:19 PM, David Gibson wrote: We should pull in SLOF via a git submodule. That ensures we ship the source code along with the binary. Um, ok. Do I need to do anything about this? We should introduce SLOF as one patch that adds the git submodule and the binary. The best way

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Anthony Liguori
On 03/28/2011 04:03 AM, Alexander Graf wrote: Um, ok. Do I need to do anything about this? I'm also not sure this is too important. It's GPL compliance so yes, it's very important. Most of our firmware blobs come from svn repos which can't be submoduled. The only firmware blob we're

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Anthony Liguori
On 03/28/2011 08:08 AM, Alexander Graf wrote: It depends on how often the code changes. If it changes regularly and qemu is expected to take in newer versions, then we need to record which slof version comes with which qemu version. Submodules do just that. A commit id / tag in the README

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: diff --git a/libcacard/passthru.c b/libcacard/passthru.c new file mode 100644 index 000..d78e2db --- /dev/null +++ b/libcacard/passthru.c @@ -0,0 +1,609 @@ +/* + * implement the applets for the CAC card. + * + * This work is licensed under the

Re: [Qemu-devel] [PATCH v23 09/11] libcacard: add docs

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt Didn't review the content in detail,

Re: [Qemu-devel] [PATCH v23 10/11] ccid: add ccid-card-emulated device

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can

[Qemu-devel] Re: [PATCH v5 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Isaku Yamahata
On Mon, Mar 28, 2011 at 01:34:02PM +0200, Michael S. Tsirkin wrote: On Mon, Mar 28, 2011 at 08:19:56PM +0900, Isaku Yamahata wrote: On Sun, Mar 27, 2011 at 04:56:29PM +0200, Michael S. Tsirkin wrote: On Wed, Mar 23, 2011 at 11:17:19AM +0900, Isaku Yamahata wrote: v4 has minor typo. I

Re: [Qemu-devel] [PATCH v23 11/11] ccid: add docs

2011-03-28 Thread Jes Sorensen
On 03/23/11 14:19, Alon Levy wrote: Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy al...@redhat.com --- docs/ccid.txt | 135 + 1

[Qemu-devel] Re: [PATCH]hw/xen_disk: ioreq not finished on error

2011-03-28 Thread Stefano Stabellini
On Sun, 27 Mar 2011, Feiran Zheng wrote: Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio' won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in the blkdev-inflight list and a leak. Signed-off-by: Feiran Zheng famc...@gmail.com --- hw/xen_disk.c | 22

[Qemu-devel] [PATCH v2 2/5] hw: Add maximum RAM specifications for ARM devboard models

2011-03-28 Thread Peter Maydell
Specify the maximum memory permitted for the various ARM devboard models (integratorcp, realview-eb, realview-eb-mpcore, realview-pb-a8, realview-pbx-a9, versatilepb, versatileab). This means we now handle attempts to specify too much RAM gracefully rather than causing the guest to crash in an

[Qemu-devel] [PATCH v2 1/5] Allow boards to specify maximum RAM size

2011-03-28 Thread Peter Maydell
Allow boards to specify their maximum RAM size in the QEMUMachine struct. This allows us to provide a useful diagnostic if the user tries to specify a RAM size that the board cannot support. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/boards.h |1 + vl.c| 16

[Qemu-devel] [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

2011-03-28 Thread Peter Maydell
Combine the per-machine QEMUMachine struct into the per-machine sun4*_hwdef struct. This requires some moving around of init functions to avoid forward references. We also have to move the 'const' attribute from the whole sun4*_hwdef[] array to the individual fields of the structure, because

Re: [Qemu-devel] [PATCH v23 05/11] ccid: add passthru card device

2011-03-28 Thread Jes Sorensen
On 03/28/11 14:14, Alon Levy wrote: +static void ccid_card_vscard_send_init(PassthruState *s) +{ +VSCMsgInit msg = { +.version = htonl(VSCARD_VERSION), +.magic = VSCARD_MAGIC, +.capabilities = {0} +}; + If this goes over the wire, don't

[Qemu-devel] [PATCH v2 5/5] hw/sun4m: Use a macro to hide the repetitive board init functions

2011-03-28 Thread Peter Maydell
Tidy up the repetitive board init functions (which are all the same apart from which hwdef struct they pass in). This also lets us add an assertion that the hwdef points to the init function which uses that hwdef, rather than some other one. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit

2011-03-28 Thread Jes Sorensen
On 03/28/11 14:42, Alon Levy wrote: On Mon, Mar 28, 2011 at 02:35:23PM +0200, Jes Sorensen wrote: +/* + * NSS headers + */ +#include nss.h +#include pk11pub.h +#include cert.h +#include key.h +#include secmod.h +#include prthread.h +#include secerr.h + +#include qemu-common.h again

[Qemu-devel] [PATCH v2 4/5] hw/sun4m: Use the QEMUMachine max_ram to implement memory limit

2011-03-28 Thread Peter Maydell
Use the max_ram field in QEMUMachine to indicate maximum memory, rather than a field in the sun4*_hwdef structure. This allows us to use the vl.c check on RAM specifications rather than having to code our own. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/sun4m.c | 42

Re: [Qemu-devel] [PATCH v23 07/11] libcacard: add vscclient

2011-03-28 Thread Jes Sorensen
On 03/28/11 14:51, Alon Levy wrote: as mentioned in an earlier series, I think VSCARD_MAGIC needs to be network converted too, to handle difference in endianness between hosts. Same answer as to your previous comment. Yeah I saw your answer - I am happy with the code in general, so if you

[Qemu-devel] Re: [PATCH]hw/xen_disk: ioreq not finished on error

2011-03-28 Thread Feiran Zheng
On Mon, Mar 28, 2011 at 9:42 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Sun, 27 Mar 2011, Feiran Zheng wrote: Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio' won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in the blkdev-inflight

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread David Gibson
On Mon, Mar 28, 2011 at 08:16:51AM -0500, Anthony Liguori wrote: On 03/28/2011 04:03 AM, Alexander Graf wrote: Um, ok. Do I need to do anything about this? I'm also not sure this is too important. It's GPL compliance so yes, it's very important. Most of our firmware blobs come from

Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status

2011-03-28 Thread Peter Maydell
On 14 March 2011 05:35, Nathan Froyd froy...@codesourcery.com wrote: On Fri, Mar 11, 2011 at 10:31:31PM +, Peter Maydell wrote: On 11 March 2011 18:30, Nathan Froyd froy...@codesourcery.com wrote: Is there a reason that you don't simply use the global env rather than passing in an extra

Re: [Qemu-devel] [PATCH 00/17] s390x emulation support

2011-03-28 Thread Alexander Graf
On 03/24/2011 04:58 PM, Alexander Graf wrote: We've had support for running s390x guests with KVM for a while now. This patch set also enables support for running s390x guests in system as well as linux-user mode in emulation! Within this scope, I again want to stress that this is _not_

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 03:27:49PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: diff --git a/libcacard/passthru.c b/libcacard/passthru.c new file mode 100644 index 000..d78e2db --- /dev/null +++ b/libcacard/passthru.c @@ -0,0 +1,609 @@ +/* + * implement the

Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 01:59:10PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: --- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) Acked-by: Jes Sorensen

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it,

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Jes Sorensen
On 03/28/11 16:28, Alon Levy wrote: On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next

Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Jes Sorensen
On 03/28/11 16:26, Alon Levy wrote: On Mon, Mar 28, 2011 at 01:59:10PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: --- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32

[Qemu-devel] [PATCH v2 0/5] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-28 Thread Peter Maydell
This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine structure so that a board model can specify the maximum RAM it will accept. We can then produce a friendly diagnostic message when the user tries to start qemu with a '-m' option asking for more RAM than that. (Currently

Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:35:23PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: From: Robert Relyea rrel...@redhat.com libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following

Re: [Qemu-devel] [PATCH 12/17] s390x: Prepare cpu.h for emulation

2011-03-28 Thread Peter Maydell
On 24 March 2011 15:58, Alexander Graf ag...@suse.de wrote: diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h Minor nits only. -    FPReg fregs[16]; /* FP registers */ +    CPU_DoubleU fregs[16]; /* FP registers */ These changes mean that the FPReg typedef in this file is no longer used,

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 02/15] xen: Make Xen build once.

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 10:57, Alexander Graf ag...@suse.de wrote: On 01.03.2011, at 19:35, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com xen_domainbuild is now build in libhw. And xen_machine_pv is build only for i386 targets. Signed-off-by: Anthony

[Qemu-devel] [PATCH v6 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Isaku Yamahata
Here is v6 which fixed piix3_set_irq_pic(). 4/4 needs more extensive tests. So please feel free to pick it up now or drop it for now. patch description: This patch series optimizes irq data path of piix_pci. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by

[Qemu-devel] [PATCH v6 2/4] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-28 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Juan Quintela quint...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- Changes v3 - v4: - use PCI_NUM_PINS instead of magic number 4

[Qemu-devel] [PATCH v6 4/4] piix_pci: load path clean up

2011-03-28 Thread Isaku Yamahata
The previous patch didn't change the behavior when load, it resulted in ugly code. This patch cleans it up. With this patch, pic irq lines are manipulated when loaded. It is expected that it won't change the behaviour because the interrupts are level: at the moment e.g. pci devices already

[Qemu-devel] [PATCH v6 1/4] pci: add accessor function to get irq levels

2011-03-28 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |7 +++

[Qemu-devel] [PATCH v6 3/4] piix_pci: optimize set irq path

2011-03-28 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 03:27:49PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: diff --git a/libcacard/passthru.c b/libcacard/passthru.c new file mode 100644 index 000..d78e2db --- /dev/null +++ b/libcacard/passthru.c @@ -0,0 +1,609 @@ +/* + * implement the

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Jes Sorensen
On 03/28/11 17:21, Alon Levy wrote: Where does this odd LONG type come from? I think Windows uses LONG so having your own type would conflict with that, and of course we don't really want Windows types directly in QEMU either, so I am curious? This comes from pcsclite (which means I need

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 03/15] xen: Support new libxc calls from xen unstable.

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 10:43, Alexander Graf ag...@suse.de wrote: On 01.03.2011, at 19:35, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch updates the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build

Re: [Qemu-devel] [PATCH 16/17] s390x: translate engine for s390x CPU

2011-03-28 Thread Peter Maydell
On 24 March 2011 15:58, Alexander Graf ag...@suse.de wrote: diff --git a/target-s390x/translate.c b/target-s390x/translate.c +typedef struct DisasContext DisasContext; +struct DisasContext { +    uint64_t pc; +    int is_jmp; +    enum cc_op cc_op; +    CPUS390XState *env; +    struct

Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 04:30:26PM +0200, Jes Sorensen wrote: On 03/28/11 16:26, Alon Levy wrote: On Mon, Mar 28, 2011 at 01:59:10PM +0200, Jes Sorensen wrote: On 03/23/11 14:19, Alon Levy wrote: --- Makefile | 32 Makefile.objs | 32

[Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 01/10] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index 89e88b4..209e14d 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o:

[Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 04/10] introduce libcacard/vscard_common.h

2011-03-28 Thread Alon Levy
--- Signed-off-by: Alon Levy al...@redhat.com v20-v21 changes: (Jes Sorensen review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19-v20 changes: * checkpatch.pl v15-v16 changes: Protocol change: * VSCMsgInit capabilities and magic *

Re: [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform pci device

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 12:08, Alexander Graf ag...@suse.de wrote: diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 6eff06e..417c456 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -121,6 +121,10 @@ static void pc_init1(ram_addr_t ram_size,     pc_vga_init(pci_enabled? pci_bus: NULL); +    

[Qemu-devel] [PATCH 07/10] libcacard: add vscclient

2011-03-28 Thread Alon Levy
From: Robert Relyea rrel...@redhat.com client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. v23-v24 changes: (Jes Sorensen review 2) * use qemu_socket instead of socket * use fprintf(stderr,..) for errors * remove unneccessary includes since using

[Qemu-devel] [PATCH 08/10] libcacard: add docs

2011-03-28 Thread Alon Levy
From: Robert Relyea rrel...@redhat.com --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt diff --git a/docs/libcacard.txt b/docs/libcacard.txt new file mode 100644 index

[Qemu-devel] [PATCH 05/10] ccid: add passthru card device

2011-03-28 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy al...@redhat.com ---

[Qemu-devel] [PATCH 09/10] ccid: add ccid-card-emulated device

2011-03-28 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 13/15] xen: Initialize event channels and io rings

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 12:36, Alexander Graf ag...@suse.de wrote: +/* Compatibility with older version */ +#if __XEN_LATEST_INTERFACE_VERSION__ 0x0003020a +#  define xen_vcpu_eport(shared_page, i) \ +    (shared_page-vcpu_iodata[i].vp_eport) +#  define xen_vcpu_ioreq(shared_page, vcpu) \ +

[Qemu-devel] Re: [PATCH v6 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Michael S. Tsirkin
On Tue, Mar 29, 2011 at 12:05:26AM +0900, Isaku Yamahata wrote: Here is v6 which fixed piix3_set_irq_pic(). 4/4 needs more extensive tests. So please feel free to pick it up now or drop it for now. Could you pls clarify how did you test and which patches? patch description: This patch

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Michael S. Tsirkin
On Mon, Mar 28, 2011 at 06:20:15PM +0200, Stefan Weil wrote: Am 28.03.2011 11:24, schrieb Isaku Yamahata: On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: Isaku Yamahata yamah...@valinux.co.jp writes: On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: Am

Re: [Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 06:11:04PM +0200, Alon Levy wrote: Sorry, please ignore this mail. This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguorialigu...@us.ibm.com wrote: On 03/25/2011 02:47 PM, Michael Roth wrote: Async commands like 'guest-ping' have NULL retvals. Handle these by inserting an empty dictionary in the response's return

Re: [Qemu-devel] Re: [RFC][PATCH v1 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent)

2011-03-28 Thread Anthony Liguori
On 03/25/2011 05:36 PM, Michael Roth wrote: Basically just need a way to pull whatever is stored in the response qdict's return field out without specifying the QTYPE in advance... which exists in qdict.c:qdict_get_obj(), it's just not currently exposed to outside callers. Just use

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Luiz Capitulino
On Mon, 28 Mar 2011 12:01:16 -0500 Anthony Liguori aligu...@us.ibm.com wrote: On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguorialigu...@us.ibm.com wrote: On 03/25/2011 02:47 PM, Michael Roth wrote: Async commands like 'guest-ping' have

[Qemu-devel] [PATCH 03/10] usb-ccid: add CCID bus

2011-03-28 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 12:06 PM, Luiz Capitulino wrote: On Mon, 28 Mar 2011 12:01:16 -0500 Anthony Liguorialigu...@us.ibm.com wrote: On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguorialigu...@us.ibm.com wrote: On 03/25/2011 02:47 PM, Michael Roth

[Qemu-devel] Re: [PATCH 3/4] Introduce machine state

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 10:25 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 03/26/2011 11:28 PM, Blue Swirl wrote: Move generic machine state to machine-state.h, adjust users. What's the distinction between vm state and machine state? Machine state or configuration is visible to guest,

Re: [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers

2011-03-28 Thread Alexander Graf
On 03/24/2011 06:29 PM, Peter Maydell wrote: On 24 March 2011 15:58, Alexander Grafag...@suse.de wrote: This is more random comments in passing than a thorough review; sorry. +#if HOST_LONG_BITS == 64 defined(__GNUC__) +/* assuming 64-bit hosts have __uint128_t */ +

  1   2   >