Re: [Qemu-devel] [PATCH] Fix signal handling when io-thread is disabled

2011-06-14 Thread Jan Kiszka
On 2011-06-14 05:46, Alexandre Raymond wrote: This fix effectively blocks, in the main thread, the signals handled by signalfd or the compatibility signal thread. This way, such signals are received synchronously in the main thread through sigfd_handler() instead of triggering the signal

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-14 Thread Jan Kiszka
On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM but not yet by TCG. So far we unconditionally set them to 0 in the guest which may cause state corruptions - not only during

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
On 2011-06-12 19:42, Peter Maydell wrote: On 11 June 2011 10:05, Jan Kiszka jan.kis...@web.de wrote: @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name) return -EINVAL; } +qemu_system_reset(); ret = qemu_loadvm_state(f); This means that if we're doing a load

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
On 2011-06-12 19:13, Avi Kivity wrote: On 06/11/2011 12:05 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot,

Re: [Qemu-devel] usb-musb: calls usb_packet_complete() on packets with no owner

2011-06-14 Thread Gerd Hoffmann
Hi, usb_packet_complete(s-port.dev,ep-packey[dir].p); which will call usb_packet_complete() on packets which did not return USB_RET_ASYNC from usb_handle_packet, and so trips this assert. Any suggestions about what the right way to fix this is? (I'm a bit confused about the comment

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-14 Thread Dmitry Konishchev
On Mon, Jun 13, 2011 at 1:13 PM, Dmitry Konishchev konishc...@gmail.com wrote: I haven't done this because in this case I have to pass too lot of local variables to this function. Just not sure that it'll look better. But if you mind I surely can do this. Should I? -- Dmitry Konishchev

Re: [Qemu-devel] [PATCH v2] block/rbd: Remove unused local variable

2011-06-14 Thread Kevin Wolf
Am 10.06.2011 22:05, schrieb Stefan Weil: Variable 'snap' is assigned a value that is never used. Remove snap and the related code. v2: The unused variable which was in function rbd_open is now in function qemu_rbd_create, so the patch needed an update. Cc: Christian Brunner

Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-14 Thread Stefan Hajnoczi
On Sat, Jun 04, 2011 at 08:40:50AM +0800, Fam Zheng wrote: vmdk_probe for mono flat images. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in cpus.c

2011-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2011 at 10:16:36PM -0400, Alexandre Raymond wrote: filed - failed Signed-off-by: Alexandre Raymond cerb...@gmail.com --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree:

[Qemu-devel] [RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability

2011-06-14 Thread M. Mohan Kumar
[RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability In passthrough security model, following a symbolic link in the server side could result in TOCTTOU vulnerability. Use clone system call to create a thread which runs in chrooted environment. All passthrough model file

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-14 Thread Avi Kivity
On 06/14/2011 09:10 AM, Jan Kiszka wrote: On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM but not yet by TCG. So far we unconditionally set them to 0 in the guest

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-14 Thread Jan Kiszka
On 2011-06-14 10:23, Avi Kivity wrote: On 06/14/2011 09:10 AM, Jan Kiszka wrote: On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM but not yet by TCG. So far we

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-14 Thread Hannes Reinecke
On 06/10/2011 04:35 PM, Paolo Bonzini wrote: If requests are placed on arbitrary queues you'll inevitably run on locking issues to ensure strict request ordering. I would add here: If a device uses more than one queue it is the responsibility of the device to ensure strict request ordering.

Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-06-14 Thread Markus Armbruster
Devin Nakamura devin...@gmail.com writes: Fix a bug caused by lack of braces in if statement You describe the bug's cause. That's good. Please also describe the bug's effect, i.e. what exactly is broken for users. Signed-off-by: Devin Nakamura devin...@gmail.com --- qemu-io.c |4

Re: [Qemu-devel] QEMU API for modelling of user's hardware

2011-06-14 Thread Markus Armbruster
wzab w...@ise.pw.edu.pl writes: I've found the following source of information regarding writing of device models for QEMU: http://www.linux-kvm.org/wiki/images/f/fe/2010-forum-armbru-qdev.pdf http://www.google.com/url?sa=Dq=http://www.linux-kvm.org/wiki/images/f/fe/2010-forum-armbru-qdev.pdf

[Qemu-devel] [Bug 785668] Re: bonding inside a bridge does not update ARP correctly when bridged net accessed from within a VM

2011-06-14 Thread Raul Morera
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/785668 Title: bonding inside a bridge does not update ARP correctly when bridged net

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Alexander Graf
On 31.05.2011, at 13:05, Stefano Stabellini wrote: On Sat, 28 May 2011, Alexander Graf wrote: On 26.05.2011, at 17:48, Stefano Stabellini wrote: xen: fix interrupt routing - remove i440FX-xen and i440fx_write_config_xen we don't need to intercept pci config writes to i440FX anymore;

[Qemu-devel] How to increase ram beyond 756 MB ?

2011-06-14 Thread मनीष शर्मा
Hi All, I am using arm on x86, running Linux 2.6.33 as guest and fedora 14 as host. And using Realview board inside Qemu Machine. Even though I passed 1024 MB as qemu memory in command line, I can only see ~756MB given to guest. Also I tried passing more than 1024 MB say 2048 MB But I am unable

Re: [Qemu-devel] How to increase ram beyond 756 MB ?

2011-06-14 Thread Peter Maydell
2011/6/14 मनीष शर्मा manishs...@gmail.com: I am using arm on x86, running Linux 2.6.33 as guest and fedora 14 as host. And using Realview board inside Qemu Machine. Do you mean realview-eb, realview-eb-mpcore, realview-pb-a9, or realview-pbx-a9 ? They are different models. Even though I

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Avi Kivity
On 06/14/2011 09:19 AM, Jan Kiszka wrote: On 2011-06-12 19:13, Avi Kivity wrote: On 06/11/2011 12:05 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
On 2011-06-14 12:50, Avi Kivity wrote: On 06/14/2011 09:19 AM, Jan Kiszka wrote: On 2011-06-12 19:13, Avi Kivity wrote: On 06/11/2011 12:05 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com In case we load the vmstate during incoming migration, we start from a clean,

Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-14 Thread Alexander Graf
On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. We are only left with build dependencies that are controlled by kvm arch headers. This should completely rule out all CAPs right? IIRC, all CAPs are defined in generic code, so we don't get number

[Qemu-devel] [PULL] usb patch queue

2011-06-14 Thread Gerd Hoffmann
Hi, The USB patch queue has been rebased, got a minor fix (wrong comment in patch #8, spotted by David Ahern) and three new patches. I'm just posting the three new patches to avoid spamming the list with 30 identical patches ... please pull, Gerd The following changes since commit

[Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup

2011-06-14 Thread Gerd Hoffmann
From: Peter Maydell peter.mayd...@linaro.org Implement the wakeup callback in the OHCI USBPortOps, so that when a downstream device wakes up it correctly causes the OHCI controller to come out of suspend. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Jan Kiszka
On 2011-06-14 12:54, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen can only do dirty bit tracking for one memory region, so we should explicitly avoid

[Qemu-devel] [PATCH 34/34] usb-uhci: fix expire time initialization.

2011-06-14 Thread Gerd Hoffmann
expire_time must be initialited when the guest activates the usb scheduler, not at device creation time. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index

Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-14 Thread Jan Kiszka
On 2011-06-14 13:17, Alexander Graf wrote: On 14.06.2011, at 13:07, Jan Kiszka wrote: On 2011-06-14 13:05, Alexander Graf wrote: On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. We are only left with build dependencies that are controlled by

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-14 Thread Alexander Graf
On 08.06.2011, at 16:10, Jan Kiszka wrote: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent headers installed on their build machine. Consequently, the patch removes and build-time

Re: [Qemu-devel] [PATCH 05/12] kvm: ppc: Drop CONFIG_KVM_PPC_PVR

2011-06-14 Thread Alexander Graf
On 08.06.2011, at 16:10, Jan Kiszka wrote: Required header support is now unconditionally available. Looks good to me :) Reviewed-by: Alexander Graf ag...@suse.de Alex

Re: [Qemu-devel] [PATCH 09/12] kvm: ppc: Drop KVM_CAP build dependencies

2011-06-14 Thread Alexander Graf
On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. What a nice code cleanup. Reviewed-by: Alexander Graf ag...@suse.de

[Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()

2011-06-14 Thread Peter Maydell
In musb_packet() handle final processing of non-asynchronous USB packets by directly calling musb_schedule_cb() rather than going through usb_packet_complete(). The latter will trigger an assertion because the packet doesn't belong to a device. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 13:07, Jan Kiszka wrote: On 2011-06-14 13:05, Alexander Graf wrote: On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. We are only left with build dependencies that are controlled by kvm arch headers. This should completely

Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-14 Thread Jan Kiszka
On 2011-06-14 13:05, Alexander Graf wrote: On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. We are only left with build dependencies that are controlled by kvm arch headers. This should completely rule out all CAPs right? IIRC, all CAPs are

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Avi Kivity
On 06/14/2011 01:56 PM, Jan Kiszka wrote: I believe it is not. But regardless, we shouldn't add more incorrect behaviour. It depends on how the reset event is defined in QMP. As I see it, there is nothing stated about reset reasons or sources. So emitting information about the actually

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 13:21, Jan Kiszka wrote: On 2011-06-14 13:11, Alexander Graf wrote: On 08.06.2011, at 16:10, Jan Kiszka wrote: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-14 Thread Jan Kiszka
On 2011-06-14 13:11, Alexander Graf wrote: On 08.06.2011, at 16:10, Jan Kiszka wrote: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent headers installed on their build machine.

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: On 2011-06-14 12:54, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen can only do dirty bit tracking for one

[Qemu-devel] SdCard read/write performance is slow

2011-06-14 Thread Sid Kapoor
Hi, I am using qemu-system-arm for ARM Realview PBX-A9 board. I feel that the performance (read/write) from the SdCard is slower than the case in which I was mounting my rootfs through NFS. The size of my rootfs is around 3 GB. I am making my SdCard image using qemu-img command and formatting it

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen can only do dirty bit tracking for one memory region, so we should explicitly

Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 13:19, Jan Kiszka wrote: On 2011-06-14 13:17, Alexander Graf wrote: On 14.06.2011, at 13:07, Jan Kiszka wrote: On 2011-06-14 13:05, Alexander Graf wrote: On 08.06.2011, at 16:11, Jan Kiszka wrote: No longer needed with accompanied kernel headers. We are only left

[Qemu-devel] Fwd: How to increase ram beyond 756 MB ?

2011-06-14 Thread मनीष शर्मा
-- Forwarded message -- From: मनीष शर्मा manishs...@gmail.com Date: 2011/6/14 Subject: Re: [Qemu-devel] How to increase ram beyond 756 MB ? To: Peter Maydell peter.mayd...@linaro.org Thanks Peter. I am able to change memory size in guest to 1024 MB now. After making small

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-14 Thread Jan Kiszka
On 2011-06-14 13:28, Alexander Graf wrote: On 14.06.2011, at 13:21, Jan Kiszka wrote: On 2011-06-14 13:11, Alexander Graf wrote: On 08.06.2011, at 16:10, Jan Kiszka wrote: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-14 Thread Ian Campbell
On Tue, 2011-06-14 at 10:25 +0100, Alexander Graf wrote: On 31.05.2011, at 13:05, Stefano Stabellini wrote: On Sat, 28 May 2011, Alexander Graf wrote: On 26.05.2011, at 17:48, Stefano Stabellini wrote: xen: fix interrupt routing - remove i440FX-xen and i440fx_write_config_xen

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 13:48, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen can only do dirty bit tracking

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-14 Thread Alexander Graf
Am 14.06.2011 um 14:17 schrieb Ian Campbell ian.campb...@citrix.com: On Tue, 2011-06-14 at 10:25 +0100, Alexander Graf wrote: On 31.05.2011, at 13:05, Stefano Stabellini wrote: On Sat, 28 May 2011, Alexander Graf wrote: On 26.05.2011, at 17:48, Stefano Stabellini wrote: xen: fix

Re: [Qemu-devel] SdCard read/write performance is slow

2011-06-14 Thread Peter Maydell
On 14 June 2011 12:22, Sid Kapoor sidkapoor2...@gmail.com wrote: I am using qemu-system-arm for ARM Realview PBX-A9 board. I feel that the performance (read/write) from the SdCard is slower than the case in which I was mounting my rootfs through NFS. The size of my rootfs is around 3 GB. I am

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Jan Kiszka
On 2011-06-14 13:50, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Jan Kiszka wrote: On 2011-06-14 12:54, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen

Re: [Qemu-devel] Question on virtio disk maximum index and maximum partition

2011-06-14 Thread Richard W.M. Jones
On Wed, Jun 01, 2011 at 05:56:02AM +0100, Stefan Hajnoczi wrote: Partitions are not at the virtio-blk level. The guest operating system will see the virtio-blk disk and scan its partition table to determine which partitions are available. The limit then depends on the partitioning scheme

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-14 Thread Anthony Liguori
On 06/13/2011 03:59 PM, Blue Swirl wrote: On Sun, Jun 12, 2011 at 10:21 PM, Anthony Liguorialigu...@us.ibm.com wrote: On 06/12/2011 12:12 PM, Avi Kivity wrote: On 06/10/2011 06:43 PM, Anthony Liguori wrote: What exactly is so very wrong about buses that they need to die? They force a

Re: [Qemu-devel] KVM call agenda for June 14

2011-06-14 Thread Anthony Liguori
On 06/13/2011 07:40 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - 0.15 release - guest additions (virt-agent next steps) Regards, Anthony Liguori thanks, -juan

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Jan Kiszka
On 2011-06-14 14:30, Alexander Graf wrote: Am 14.06.2011 um 14:17 schrieb Ian Campbell ian.campb...@citrix.com: On Tue, 2011-06-14 at 10:25 +0100, Alexander Graf wrote: On 31.05.2011, at 13:05, Stefano Stabellini wrote: On Sat, 28 May 2011, Alexander Graf wrote: On 26.05.2011, at 17:48,

Re: [Qemu-devel] stale savannah git repo (was: Re: KVM call agenda for April 05)

2011-06-14 Thread Anthony Liguori
On 06/09/2011 05:14 AM, Peter Maydell wrote: On 5 April 2011 09:29, Alexander Grafag...@suse.de wrote: On 05.04.2011, at 08:01, Brad Hards wrote: It isn't even easy to figure out what trees there are (apart from the main one) and a google search for qemu git produces some misleading links to

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: I bet the motivation is to have an IRQ route that is independent of QEMU, thus can be discovered inside the Xen kernel and then remains stable - or is simply hard-wired. Device assignment? Direct legacy IRQ injection from the kernel? This code predates

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Alexander Graf wrote: static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) { PCII440FXState *d = opaque; @@ -267,8 +263,17 @@ static PCIBus *i440fx_common_init(const char *device_name, d = pci_create_simple(b, 0, device_name);

[Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Corey Bryant
sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended attributes. Some file systems, such as NFS, do not support the

Re: [Qemu-devel] [PATCH] cirrus_vga: reset lfb_addr after a pci config write if the BAR is unmapped

2011-06-14 Thread Alexander Graf
On 06/03/2011 05:56 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com If the cirrus_vga PCI BAR is unmapped than we should not only reset map_addr but also lfb_addr, otherwise we'll keep trying to map the old lfb_addr in map_linear_vram. The

[Qemu-devel] [PATCH v2] Fix signal handling when io-thread is disabled

2011-06-14 Thread Alexandre Raymond
Changes since v1: - take pthread_sigmask() out of the ifdef as it is now common to both parts. This fix effectively blocks, in the main thread, the signals handled by signalfd or the compatibility signal thread. This way, such signals are received synchronously in the main thread through

Re: [Qemu-devel] [PATCH] Fix signal handling when io-thread is disabled

2011-06-14 Thread Alexandre Raymond
Hi Jan, Thanks for reviewing my patch. But please pull the now common pthread_sigmask out of the #ifdef. Please see v2. Alexandre

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-14 Thread Peter Maydell
I think you should be able to work around this with: echo 2 /proc/cpu/alignment which makes unaligned accesses fault and the kernel fix them up. This will be slower than if qemu wasn't generating unaligned accesses in the first place but it should at least make things run. (echo 0 ... will give

Re: [Qemu-devel] [PULL] libcacard libtoolized + usb-ccid fix

2011-06-14 Thread Alon Levy
On Thu, Jun 09, 2011 at 11:16:11AM +0300, Alon Levy wrote: Ping? Reping. On Tue, May 31, 2011 at 07:42:20PM +0300, Alon Levy wrote: Hi, This pull request includes the libcacard.la library target and a memory leak fix by Markus. Please pull. The following changes since commit

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Alexander Graf wrote: On 14.06.2011, at 13:48, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Alexander Graf
On 06/14/2011 05:24 PM, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 14.06.2011, at 13:48, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 03.06.2011, at 17:56,stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote:

[Qemu-devel] [PATCH 1/3] pc: add compat machine types for 0.14 and 0.15

2011-06-14 Thread Alexander Graf
We change virtual hardware from time to time, so in order to ensure that the guest doesn't get confused, we have compatibility machines for the PC machine. This patch adds compatibility definitions for 0.14 and 0.15 versions. Signed-off-by: Alexander Graf ag...@suse.de --- hw/pc_piix.c | 32

[Qemu-devel] [PATCH 2/3] pc: use old default cpu type for 0.14 and 0.15 compat machines

2011-06-14 Thread Alexander Graf
When running with the 0.14 or 0.15 machine types, use the old mechanism of determining the default CPU to choose, so that the guest sees the same default CPU when running qemu in compat mode. Signed-off-by: Alexander Graf ag...@suse.de --- hw/pc_piix.c | 16 1 files changed,

[Qemu-devel] [PATCH 3/3] pc: use -cpu host as default for kvm

2011-06-14 Thread Alexander Graf
When running with KVM, people expect to get the best possible performance inside the VM. To really get this, the guest needs to know about the CPU features it can use. We have a CPU type that exports exactly this information to the guest, but hasn't been used much, as it wasn't the default. Set

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-14 Thread Hannes Reinecke
On 06/12/2011 09:51 AM, Michael S. Tsirkin wrote: On Fri, Jun 10, 2011 at 02:55:35PM +0200, Hannes Reinecke wrote: Device operation: request queues The driver queues requests to an arbitrary request queue, and they are used by the device on that same queue.

[Qemu-devel] [PATCH 0/3] pc: enable -cpu host as default

2011-06-14 Thread Alexander Graf
As discussed during the community call, -cpu qemu64 breaks for a bunch of workloads, most prominently recent gcc versions thanks to libgmp. To work around this and to also give the user the best possible performance when running with default command line options, let's use -cpu host as default

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Jan Kiszka
On 2011-06-14 15:27, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) { PCII440FXState *d = opaque; @@ -267,8 +263,17 @@ static PCIBus *i440fx_common_init(const char *device_name, d =

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Luiz Capitulino
On Tue, 14 Jun 2011 14:14:58 +0300 Avi Kivity a...@redhat.com wrote: On 06/14/2011 01:56 PM, Jan Kiszka wrote: I believe it is not. But regardless, we shouldn't add more incorrect behaviour. It depends on how the reset event is defined in QMP. As I see it, there is nothing

[Qemu-devel] [PATCH v2 3/3] ide: add TRIM support

2011-06-14 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de Add support for TRIM sub function of the data set management command, and wire it up to the qemu discard infrastructure. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Kevin Wolf kw...@redhat.com --- v2: - Fixed bdrv_discard call (takes sectors,

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-14 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 9:39 AM, Hannes Reinecke h...@suse.de wrote: On 06/10/2011 04:35 PM, Paolo Bonzini wrote: If requests are placed on arbitrary queues you'll inevitably run on locking issues to ensure strict request ordering. I would add here: If a device uses more than one queue it

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-14 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 8:43 AM, Dmitry Konishchev konishc...@gmail.com wrote: On Mon, Jun 13, 2011 at 1:13 PM, Dmitry Konishchev konishc...@gmail.com wrote: I haven't done this because in this case I have to pass too lot of local variables to this function. Just not sure that it'll look

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Eric Blake
On 06/14/2011 07:31 AM, Corey Bryant wrote: This patch contains the Qemu code to support this solution. I would like to solicit input from the libvirt community prior to starting the libvirt patch. Currently, Qemu opens an image file in addition to performing the necessary read and write

[Qemu-devel] [PATCH v2 2/2] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot, the machine can be in any state. That can cause troubles if loading an older image which does not carry all state information

Re: [Qemu-devel] [PATCH] cirrus_vga: reset lfb_addr after a pci config write if the BAR is unmapped

2011-06-14 Thread Jan Kiszka
On 2011-06-14 15:54, Alexander Graf wrote: On 06/03/2011 05:56 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com If the cirrus_vga PCI BAR is unmapped than we should not only reset map_addr but also lfb_addr, otherwise we'll keep trying to

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Avi Kivity
On 06/14/2011 02:04 PM, Jan Kiszka wrote: BTW, if Xen is not able to track more than one dirty region, I think it's time to fix that limitation. At some point it may no longer be possible to work around it (who knows how the new memory API will look like in this regard). Since the memory API

[Qemu-devel] [PATCH 1/2] Allow silent system resets

2011-06-14 Thread Jan Kiszka
This allows qemu_system_reset to be issued silently for internal purposes, ie. without sending out a monitor event. Convert the system reset after startup to the silent mode. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- sysemu.h |5 - vl.c | 10 ++ xen-all.c |

[Qemu-devel] [PATCH 04/13] vmware-vga: Disable verbose mode

2011-06-14 Thread Jan Kiszka
Elimiates 'vmsvga_value_write: guest runs Linux.' messages from the console. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmware_vga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c

Re: [Qemu-devel] [PATCH v2] Fix signal handling when io-thread is disabled

2011-06-14 Thread Jan Kiszka
On 2011-06-14 16:05, Alexandre Raymond wrote: Changes since v1: - take pthread_sigmask() out of the ifdef as it is now common to both parts. This fix effectively blocks, in the main thread, the signals handled by signalfd or the compatibility signal thread. This way, such signals are

[Qemu-devel] [PATCH 08/13] vmware-vga: Register reset service

2011-06-14 Thread Jan Kiszka
Fixes cold reset in vmware graphic modes. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmware_vga.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 93b8811..c20f154 100644

[Qemu-devel] [PATCH 00/13] vga: dirty log cleanup, more linear mapping

2011-06-14 Thread Jan Kiszka
A few optimizations and cleanups I came across when trying to speed up slow graphical grub unter non-cirrus vga. This series - eliminates log_start/stop CPUPhysMemoryClient callbacks - accelerates chain 4 vga mode under KVM - fixes reset of vmware-vga - cleans up vmware-vga a bit At least

[Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart

2011-06-14 Thread Jan Kiszka
Convert the last user of vga_dirty_log_restart to cpu_register_physical_memory_log and drop the service. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vga.c|6 -- hw/vga_int.h|1 - hw/vmware_vga.c |5 ++--- 3 files

[Qemu-devel] [PATCH 05/13] vmware-vga: Remove dead DIRECT_VRAM mode

2011-06-14 Thread Jan Kiszka
The code was disabled since day 1 of vmware-vga, and now it does not even build anymore. Time for a cleanup. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmware_vga.c | 168 ++ 1 files

[Qemu-devel] [PATCH 07/13] vmware_vga: Do not enable dirty logging when in SVGA mode

2011-06-14 Thread Jan Kiszka
Just like on SVGA_REG_ENABLE changes, keep dirty logging off on PCI BAR remappings when SVGA mode is on. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmware_vga.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
Drop outdated dirty log disable/enable around PCI remapping and register the BAR for dirty logging via cpu_register_physical_memory_log. That allows to remove all vga_dirty_log_start/stop references from qxl. Note: The addtional vga_dirty_log_start for the primary interface looked stray.

[Qemu-devel] [PATCH 13/13] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-06-14 Thread Jan Kiszka
Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping, which can then be combined with dirty logging

[Qemu-devel] [PATCH 02/13] vga-pci: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vga-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ce9ec45..d7d904a 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -53,10 +53,10 @@ static void vga_map(PCIDevice *pci_dev,

[Qemu-devel] [PATCH 11/13] vga: Refactor lfb_vram_mapped to vga_mem_mapped

2011-06-14 Thread Jan Kiszka
Make it clearer that this flag indicates wether the legacy VGA memory region is mapped as RAM. And change its type to bool. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/cirrus_vga.c | 10 -- hw/vga.c|4 ++-- hw/vga_int.h|2 +- 3 files changed, 7

[Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
This eliminates the last user of vga_dirty_log_start/start. CC: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmware_vga.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index

[Qemu-devel] [PATCH 03/13] cirrus-vga: Drop redundant vga_dirty_log_start

2011-06-14 Thread Jan Kiszka
map_linear_vram requests logging via cpu_register_physical_memory_log now, and cirrus_pci_lfb_map does not leave anything to log behind. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 12/13] vga: Move vga_sync_dirty_bitmap

2011-06-14 Thread Jan Kiszka
We will need it earlier in the code. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vga.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index ee0c68e..4208151 100644 --- a/hw/vga.c +++ b/hw/vga.c @@

[Qemu-devel] [PATCH 0/2] get_maintainers script

2011-06-14 Thread Michael S. Tsirkin
I copied get_maintainers.pl from Linux, seems to work. Here it is, with minor tweaks Michael S. Tsirkin (2): get_maintainer.pl: copy utility from Linux get_maintainer: update to match qemu tree scripts/get_maintainer.pl | 2144 + 1 files changed,

Re: [Qemu-devel] [PATCH] smc91c111: qdevify reset

2011-06-14 Thread Peter Maydell
Ping? On 31 May 2011 17:48, Peter Maydell peter.mayd...@linaro.org wrote: From: Juha Riihimäki juha.riihim...@nokia.com Register the smc91c111 reset function as a qdev reset function. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH 10/13] Drop dirty log start/stop infrastructure

2011-06-14 Thread Jan Kiszka
No more users of vga_dirty_log_start/start, thus also no use anymore for the log_start/stop CPUPhysMemoryClient callbacks. Drop the whole infrastructure. CC: Anthony PERARD anthony.per...@citrix.com CC: Michael S. Tsirkin m...@redhat.com CC: Avi Kivity a...@redhat.com Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
This is on top of my pci tree. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/usb-ehci.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index f63519e..4d6989a 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -1945,6

[Qemu-devel] [PATCH resend] ppce500: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
This is on top of my pci tree. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Resending, +qemu-devel. sorry about the noise. hw/ppce500_pci.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 069af96..fc11af4

[Qemu-devel] [PATCH] vga: Fix type of map_addr/end.

2011-06-14 Thread Richard Henderson
These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson r...@twiddle.net Cc: Jan Kiszka jan.kis...@siemens.com --- hw/vga_int.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Jan's recent patch series

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: On 2011-06-14 15:27, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) { PCII440FXState *d = opaque; @@ -267,8 +263,17 @@ static PCIBus

[Qemu-devel] [PATCH 06/13] qed: add support for copy-on-read

2011-06-14 Thread Stefan Hajnoczi
From: Anthony Liguori aligu...@us.ibm.com This patch implements copy-on-read in QED. Once a read request reaches the copy-on-read state it adds itself to the allocating write queue in order to avoid race conditions with write requests. If an allocating write request manages to sneak in before

[Qemu-devel] [PATCH 2/2] get_maintainer: update to match qemu tree

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- scripts/get_maintainer.pl | 29 +++-- 1 files changed, 7 insertions(+), 22 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index d29a8d7..c52ae59 100755 --- a/scripts/get_maintainer.pl

  1   2   >