Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Sep 19, 2011 at 09:41:41AM -0500, Michael Roth wrote: OVERVIEW This patch series implements a QEMUFile Visitor class that's intended to abstract away direct calls to qemu_put_*/qemu_get_* for save/load functions. Currently this is done by always creating a

Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset

2011-10-03 Thread Paolo Bonzini
On 10/02/2011 10:55 PM, Blue Swirl wrote: It's already in, see -win2k-hack and floppy DMA hack. Is the floppy DMA hack just a consequence of the weird idle BHs, or is it to actually please a real BIOS? Paolo

[Qemu-devel] About custom board support

2011-10-03 Thread TusharK
Hi, I would like to know whether I can make fewer changes into existing QEMU to support my new custom board? I am planing to use IPs from ARM and Synopsys. So Whatever IPs I am planning to use from ARM and Synopsys are available in QEMU? If not how can I add support in QEMU? Basically I

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-03 Thread Alon Levy
On Sun, Oct 02, 2011 at 07:12:07PM +0200, Avi Kivity wrote: On 10/02/2011 04:31 PM, Alon Levy wrote: On Sun, Oct 02, 2011 at 03:24:36PM +0200, Alon Levy wrote: Hi, Converting qemu's ram allocation to a mmap and using remap_file_pages seems like it could work. Any ideas why it wouldn't?

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/49 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH] need to export variables in config.mak

2011-10-03 Thread Jan Kiszka
On 2011-09-30 19:40, Chris Friesen wrote: The variables being written to config.mak by configure need to be exported in order to take effect when building the package. The following patch fixes this in our environment. Signed-off-by: Chris Friesen chris.frie...@genband.com Index:

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-03 Thread Yonit Halperin
On 10/02/2011 03:24 PM, Alon Levy wrote: Hi, I'm trying to acheive the $subject. Some background: currently spice relies on a preallocated pci bar for both surfaces and for VGA framebuffer + commands. I have been trying to get rid of the surfaces bar. To do that I allocate memory in the

Re: [Qemu-devel] [PATCH] etrax: Fix wrong conditional statement

2011-10-03 Thread Edgar E. Iglesias
On Fri, Sep 30, 2011 at 11:46:09PM +0200, Stefan Weil wrote: cppcheck reports an error: the conditional statement is always true. I assume that the register should be masked with 3, but could not test the code. Please test before applying this patch. Thanks Stefan, I tested committed a

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5

2011-10-03 Thread Stefan Hajnoczi
On Sat, Oct 01, 2011 at 03:03:23PM +0530, Aneesh Kumar K.V wrote: +#ifndef CONFIG_UTIMENSAT +/* + * We support handle fs driver only if all related + * syscalls are provided by host. + */ Perhaps a ./configure check should be added to see whether the handle syscalls are

Re: [Qemu-devel] [PATCH] hmp: re-enable trace-file command

2011-10-03 Thread Stefan Hajnoczi
On Sun, Oct 02, 2011 at 08:44:37AM -0500, Michael Roth wrote: Commit 31965ae27bc11e90674be12584bb201b83df5aef reverted a previous renaming of CONFIG_SIMPLE_TRACE-CONFIG_TRACE_SIMPLE in a couple spots, leading to trace-file currently being unavailable. Signed-off-by: Michael Roth

Re: [Qemu-devel] qcow2 corrupted image, no error from qemu-img check

2011-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 09:21:29PM +0200, nicolas prochazka wrote: qemu-img from qemu 0.15 DEV-10.98.98.1:~# qemu-img info /mnt/disks/export/images/vm_import image: /mnt/disks/export/images/vm_import file format: qcow2 virtual size: 20G (21474836480 bytes) disk size: 12G cluster_size:

Re: [Qemu-devel] [RFC 0/2] target-arm: Adding Cortex-R4F support

2011-10-03 Thread Peter Maydell
On 2 October 2011 22:44, Peter Maydell peter.mayd...@linaro.org wrote: R4F is going to want V4T, V5, V6, V7, THUMB2, MPU, VFP3, VFP_FP16 and DIV [although since R profile has UDIV and SDIV only in Thumb mode and I've just sent patches that make the DIV feature enable it for ARM mode too we'll

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-03 Thread Alon Levy
On Mon, Oct 03, 2011 at 10:17:59AM +0200, Yonit Halperin wrote: On 10/02/2011 03:24 PM, Alon Levy wrote: Hi, I'm trying to acheive the $subject. Some background: currently spice relies on a preallocated pci bar for both surfaces and for VGA framebuffer + commands. I have been trying

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-03 Thread Alon Levy
On Mon, Oct 03, 2011 at 10:37:55AM +0200, Alon Levy wrote: On Mon, Oct 03, 2011 at 10:17:59AM +0200, Yonit Halperin wrote: On 10/02/2011 03:24 PM, Alon Levy wrote: Hi, I'm trying to acheive the $subject. Some background: currently spice relies on a preallocated pci bar for both

Re: [Qemu-devel] [PATCH 0/6] Alpha system emulation, v11

2011-10-03 Thread Paolo Bonzini
On 09/22/2011 06:04 PM, Edgar E. Iglesias wrote: On Thu, Sep 22, 2011 at 08:30:43AM -0700, Richard Henderson wrote: Changes v10 - v11: * Fixes for icount, based on feedback from Peter and Edgar. * Re-based against master. The patch set is also available at

Re: [Qemu-devel] [PATCH V3] Add stdio char device on windows

2011-10-03 Thread Fabien Chouteau
On 01/10/2011 08:40, Blue Swirl wrote: On Wed, Sep 28, 2011 at 4:28 PM, Fabien Chouteau chout...@adacore.com wrote: Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau chout...@adacore.com --- qemu-char.c | 216

[Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-03 Thread Andreas Färber
-cpu arm1136-r2 is commented to in fact be ARM1136 r0p2, whereas -cpu arm1136 seems to be ARM1136 r1p3 according to the MIDR value. The CPUID values contain major and minor revision numbers (rnpn) and are never used with a mask, so are specific to the chosen revision. Rename the CPUID

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5

2011-10-03 Thread Aneesh Kumar K.V
On Mon, 3 Oct 2011 08:37:52 +0100, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, Oct 01, 2011 at 03:03:23PM +0530, Aneesh Kumar K.V wrote: +#ifndef CONFIG_UTIMENSAT +/* + * We support handle fs driver only if all related + * syscalls are provided by host. + */

[Qemu-devel] [PATCH 0/2] Introduce QemuRWLock

2011-10-03 Thread Harsh Prateek Bora
SynthFS uses rwlocks, which raise the need of a generic QemuRWLock APIs. This patchset introduces the same making necessary changes to relevant code. Harsh Prateek Bora (2): Introduce QemuRWLock Use qemu_rwlock_* interface instead of pthread_rwlock_* hw/9pfs/virtio-9p-synth.c | 23

[Qemu-devel] [PATCH 2/2] Use qemu_rwlock_* interface instead of pthread_rwlock_*

2011-10-03 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-synth.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/9pfs/virtio-9p-synth.c b/hw/9pfs/virtio-9p-synth.c index cbf74e4..9867bba 100644 ---

[Qemu-devel] [PATCH 1/2] Introduce QemuRWLock

2011-10-03 Thread Harsh Prateek Bora
SynthFS introduced in http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg01206.html uses pthread_rwlock_* APIs for rwlocks, which raise the need of a generic Qemu specific, os independent rwlock APIs. This patch introduces the same. Another patch to switch pthread_rwlock_* into qemu_rwlock_*

[Qemu-devel] [PATCH 1/4] hmp: re-enable trace-file command

2011-10-03 Thread Stefan Hajnoczi
From: Michael Roth mdr...@linux.vnet.ibm.com Commit 31965ae27bc11e90674be12584bb201b83df5aef reverted a previous renaming of CONFIG_SIMPLE_TRACE-CONFIG_TRACE_SIMPLE in a couple spots, leading to trace-file currently being unavailable. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com

[Qemu-devel] [PULL 0/4] Tracing patches

2011-10-03 Thread Stefan Hajnoczi
The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7: etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git tracing Michael Roth (1): hmp: re-enable trace-file command

[Qemu-devel] [PATCH 4/4] trace: add arguments to bdrv_co_io_em() trace event

2011-10-03 Thread Stefan Hajnoczi
It is useful to know the BlockDriverState as well as the sector_num/nb_sectors of an emulated .bdrv_co_*() request. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c |2 +- trace-events |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] trace: trace monitor qmp dispatch/completion

2011-10-03 Thread Stefan Hajnoczi
Add trace events for handle_qmp_command(), which dispatches qmp commands, and monitor_protocol_emitter(), which produces the reply to a qmp command. Also remove duplicate #include trace/control.h. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- monitor.c|5 -

[Qemu-devel] [PATCH 2/4] trace: trace bdrv_open_common()

2011-10-03 Thread Stefan Hajnoczi
bdrv_open_common() is a useful point to trace since it reveals the filename and block driver for a given BlockDriverState. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c |2 ++ trace-events |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] Introduce QemuRWLock

2011-10-03 Thread Jan Kiszka
On 2011-10-03 13:23, Harsh Prateek Bora wrote: SynthFS uses rwlocks, which raise the need of a generic QemuRWLock APIs. This patchset introduces the same making necessary changes to relevant code. Is the impact of using a plain mutex measurable with 9pfs? Usually it takes very heavy write

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 01:46 AM, Michael S. Tsirkin wrote: On Mon, Sep 19, 2011 at 09:41:41AM -0500, Michael Roth wrote: OVERVIEW This patch series implements a QEMUFile Visitor class that's intended to abstract away direct calls to qemu_put_*/qemu_get_* for save/load functions. Currently this is

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 04:21:47PM -0400, Stefan Berger wrote: 4) Implement the BERVisitor and make this the default migration protocol. Most of the work will be in 1), though with the implementation in this series we should be able to do it

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Stefan Berger
On 10/03/2011 08:55 AM, Anthony Liguori wrote: On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 04:21:47PM -0400, Stefan Berger wrote: 4) Implement the BERVisitor and make this the default migration protocol. Most of the work will be in 1), though with the

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-03 Thread Anthony Liguori
On 10/02/2011 05:25 AM, Michael S. Tsirkin wrote: On Mon, Sep 05, 2011 at 02:34:56PM +1000, David Gibson wrote: This patch adds functions to pci.[ch] to perform PCI DMA operations. At present, these are just stubs which perform directly cpu physical memory accesses. Using these stubs,

[Qemu-devel] [PATCH V4] Add stdio char device on windows

2011-10-03 Thread Fabien Chouteau
Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau chout...@adacore.com --- qemu-char.c | 227 ++- 1 files changed, 225 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-03 Thread Anthony Liguori
On 10/02/2011 07:14 AM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 02:01:10PM +0200, Avi Kivity wrote: Hmm, not entirely virtio specific, some devices use stX macros to do the conversion. E.g. stw_be_phys and stl_le_phys are used in several places. These are fine - explicit

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 08:10 AM, Stefan Berger wrote: I am doing that. Indefinite length encoding *would* be a problem because you cannot push the size onto the stack so that you could skip to the end of the structure. For an indefinite length encoding, you just have to keep reading the stream at

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote: Here are some suggestions: - Let's make the protocol be BER directly. As a first step, use a single octet string for the whole of data. Next, start splitting this up. This can't be done without breaking the old style

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 08:18:31AM -0500, Anthony Liguori wrote: On 10/03/2011 08:10 AM, Stefan Berger wrote: I am doing that. Indefinite length encoding *would* be a problem because you cannot push the size onto the stack so that you could skip to the end of the structure. For an

Re: [Qemu-devel] [PULL] lm32 fixes and new milkymist hardware support

2011-10-03 Thread Michael Walle
Hi Anthony, Please publish a git URI. Fetching over HTTP is painful, particularly when the connection to the server isn't very good. The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7: etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200) are available

Re: [Qemu-devel] qcow2 corrupted image, no error from qemu-img check

2011-10-03 Thread Stefan Hajnoczi
On Mon, Oct 3, 2011 at 2:01 PM, nicolas prochazka prochazka.nico...@gmail.com wrote: sorry to bother you, i send dump of two qemu-io command . What can I do with this result ? The qemu-io -c read command was successful. This means that the I/O error was triggered by the specific request that

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 07:55:48AM -0500, Anthony Liguori wrote: On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 04:21:47PM -0400, Stefan Berger wrote: 4) Implement the BERVisitor and make this the default migration protocol. Most of the work will be in 1), though

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote: Here are some suggestions: - Let's make the protocol be BER directly. As a first step, use a single octet string for the whole of data. Next, start splitting this up. This

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 08:30 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:18:31AM -0500, Anthony Liguori wrote: On 10/03/2011 08:10 AM, Stefan Berger wrote: I am doing that. Indefinite length encoding *would* be a problem because you cannot push the size onto the stack so that you could

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 08:38 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:55:48AM -0500, Anthony Liguori wrote: On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 04:21:47PM -0400, Stefan Berger wrote: 4) Implement the BERVisitor and make this the default migration

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: visit_start_array(v, entries, errp); for (int i = 0; i s-size; i++) { visit_type_int(v, NULL,s-entry[i], errp); } visit_end_array(v, errp); Sequences can encode structures not just arrays. How would you encode this for

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: Having the ability to ignore some fields is not enough. But it is also really required. We need to also be able to split a single field into multiple fields, and event split a single device into multiple devices. If we're

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 08:48:05AM -0500, Anthony Liguori wrote: On 10/03/2011 08:30 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:18:31AM -0500, Anthony Liguori wrote: On 10/03/2011 08:10 AM, Stefan Berger wrote: I am doing that. Indefinite length encoding *would* be a problem

[Qemu-devel] [PATCH] rsqrte_f32: No need to copy sign bit.

2011-10-03 Thread Christophe Lyon
Indeed, the result is known to be always positive. Signed-off-by: Christophe Lyon christophe.l...@st.com --- target-arm/helper.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d3a3ba2..ff5456c 100644 ---

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 08:51:10AM -0500, Anthony Liguori wrote: On 10/03/2011 08:38 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:55:48AM -0500, Anthony Liguori wrote: On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct 02, 2011 at 04:21:47PM -0400, Stefan Berger wrote:

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 09:11 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: visit_start_array(v, entries, errp); for (int i = 0; i s-size; i++) { visit_type_int(v, NULL,s-entry[i], errp); } visit_end_array(v, errp); Sequences can encode structures

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 09:18 AM, Michael S. Tsirkin wrote: skip_indefinite: while tag != CANARY: if tag == INT: visit_type_int(v, NULL, NULL, errp); elif tag == STRING: visit_type_str(v, NULL, NULL, errp); elif tag == INDEFINITE: visit_start_struct(v, NULL, NULL,

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 09:41 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:51:10AM -0500, Anthony Liguori wrote: On 10/03/2011 08:38 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:55:48AM -0500, Anthony Liguori wrote: On 10/02/2011 04:08 PM, Michael S. Tsirkin wrote: On Sun, Oct

Re: [Qemu-devel] qcow2 corrupted image, no error from qemu-img check

2011-10-03 Thread nicolas prochazka
hello test with qemu-img from git tree with your patch for log : DEV-10.98.98.1:~# /tmp/qemu-img convert -O qed /mnt/disks/export/images/vm_import /mnt/disks/export-ns/test qemu-img: error while reading bs_i 0 sector_num 5406720 bs_offset 0 n 4096: Input/output error Regards, Nicolas

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-03 Thread Avi Kivity
On 10/03/2011 10:37 AM, Alon Levy wrote: Hi, won't there be an overhead for rendering on a non continuous surface? Will it be worthwhile comparing to not creating the surface? If I use a scatter-gather list there is overhead of allocating and copying the surface whenever I want to

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 09:42:02AM -0500, Anthony Liguori wrote: On 10/03/2011 09:11 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: visit_start_array(v, entries, errp); for (int i = 0; i s-size; i++) { visit_type_int(v, NULL,s-entry[i],

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 09:55:45AM -0500, Anthony Liguori wrote: How I see this all evolving in the future is that we would have a formal protocol specification. From that spec, we would generate Visitors. This would handle taking what's on the wire and building an in-memory tree. If an

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 09:56:47AM -0500, Anthony Liguori wrote: On 10/03/2011 09:18 AM, Michael S. Tsirkin wrote: skip_indefinite: while tag != CANARY: if tag == INT: visit_type_int(v, NULL, NULL, errp); elif tag == STRING: visit_type_str(v, NULL, NULL, errp);

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 10:29 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 09:42:02AM -0500, Anthony Liguori wrote: On 10/03/2011 09:11 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: visit_start_array(v, entries, errp); for (int i = 0; i

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 10:00:48AM -0500, Anthony Liguori wrote: On 10/03/2011 09:41 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:51:10AM -0500, Anthony Liguori wrote: On 10/03/2011 08:38 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:55:48AM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 10:44:45AM -0500, Anthony Liguori wrote: Specifically the case where first field in a sequence tells you the meaning of the following ones? Can you give me the example in ASN.1? Regards, Anthony Liguori That would be a selection from CHOICE. Note that CHOICE

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 10:58 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 10:44:45AM -0500, Anthony Liguori wrote: Specifically the case where first field in a sequence tells you the meaning of the following ones? Can you give me the example in ASN.1? Regards, Anthony Liguori That would

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 10:45 AM, Michael S. Tsirkin wrote: BTW, putting this info properly into migration stats would probably be pretty useful. Regards, Anthony Liguori Problem is adding anything to monitor makes me worry about future compatibility so much I usually just give up. IMO we really need

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Anthony Liguori
On 10/03/2011 09:15 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 08:43:54AM -0500, Anthony Liguori wrote: Having the ability to ignore some fields is not enough. But it is also really required. I agree. It's the principle of being conservative in what you send and liberal in what

[Qemu-devel] New option for snapshot_blkdev to avoid image creation

2011-10-03 Thread Federico Simoncelli
In some situations might be useful to let qemu use an image that was prepared for a live snapshot. The advantage is that creating the snapshot file outside of the qemu process we can use the whole range of options provided by the format (eg for qcow2: encryption, cluster_size and preallocation).

[Qemu-devel] [PATCH] qemu: new option for snapshot_blkdev to avoid image creation

2011-10-03 Thread Federico Simoncelli
Add the new option [-n] for snapshot_blkdev to avoid the image creation. The file provided as [new-image-file] is considered as already initialized and will be used after passing a check for the backing file. Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- blockdev.c | 54

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2011 at 11:05:02AM -0500, Anthony Liguori wrote: On 10/03/2011 10:45 AM, Michael S. Tsirkin wrote: BTW, putting this info properly into migration stats would probably be pretty useful. Regards, Anthony Liguori Problem is adding anything to monitor makes me worry about

[Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-03 Thread Dr. David Alan Gilbert
Make cpu_single_env thread local (Linux only for now) * Fixes some user space threading issues (esp those triggered by bug 823902) Against rev d11cf8cc..., tested on ARM user mode, and ARM Vexpress system mode (with Blue Swirl's fix from yesterday) - only tested on Linux host. Lets me

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 11:05:02AM -0500, Anthony Liguori wrote: On 10/03/2011 10:45 AM, Michael S. Tsirkin wrote: BTW, putting this info properly into migration stats would probably be pretty useful. Regards, Anthony Liguori Problem is adding anything to monitor makes me worry about

[Qemu-devel] [Bug 865518] [NEW] qemu segfaults when writing to very large qcow2 disk

2011-10-03 Thread Richard W.M. Jones
Public bug reported: Create a ridiculously large qcow2 disk: qemu-img create -f qcow2 test1.img $((2**63-513)) Attach it to a guest and try to use parted to partition it. This is easy with virt-rescue: you just do: virt-rescue test1.img rescue parted /dev/vda mklabel gpt -- bang! qemu

[Qemu-devel] Regarding address mapping

2011-10-03 Thread sparsh mittal
Hello I am new to qemu and have a question regarding address mapping. Can we change the virtual to physical mapping in qemu, in a particular manner, for example, changing this mapping in a multi-core environment to control their share? One possibility is adding page table. But I am not sure. If

Re: [Qemu-devel] [PATCH 0/2] Introduce QemuRWLock

2011-10-03 Thread Jan Kiszka
On 2011-10-03 19:30, Aneesh Kumar K.V wrote: On Mon, 03 Oct 2011 14:16:09 +0200, Jan Kiszka jan.kis...@web.de wrote: Non-text part: multipart/signed On 2011-10-03 13:23, Harsh Prateek Bora wrote: SynthFS uses rwlocks, which raise the need of a generic QemuRWLock APIs. This patchset introduces

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-03 Thread Jan Kiszka
On 2011-10-03 18:33, Dr. David Alan Gilbert wrote: Make cpu_single_env thread local (Linux only for now) * Fixes some user space threading issues (esp those triggered by bug 823902) Against rev d11cf8cc..., tested on ARM user mode, and ARM Vexpress system mode (with Blue Swirl's fix

[Qemu-devel] Slow linux (RH5.6) guest reboot?

2011-10-03 Thread Kenton Cabiness
In general, we have seen that during a reboot of a running guest (by issuing a 'reboot' command in the guest), the guest goes down normally, but when coming back up, during the udev phase, it takes anywhere from a few seconds to a few hours to complete that part of the boot. Then the guest seems

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for guest

2011-10-03 Thread Marcelo Tosatti
On Sun, Sep 25, 2011 at 10:47:46PM +0800, Liu, Jinsong wrote: Marcelo Tosatti wrote: On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote: Marcelo Tosatti wrote: On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote: From 4d5b83aba40ce0d421add9a41a6c591a8590a32e Mon Sep 17

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-03 Thread Anthony Liguori
On 09/30/2011 10:26 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2011 at 11:39 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the

Re: [Qemu-devel] [PATCH 0/2] Use QEMU_GNUC_PREREQ to fix wrong gcc version test

2011-10-03 Thread Stefan Weil
Am 16.09.2011 22:03, schrieb Stefan Weil: These two patches fix a wrong gcc version test. [PATCH 1/2] Move macro QEMU_GNUC_PREREQ to compiler.h [PATCH 2/2] Fix and clean code which tests the gcc version Ping? Maybe these patches can be applied via qemu-trivial.

Re: [Qemu-devel] Slow linux (RH5.6) guest reboot?

2011-10-03 Thread Kenton Cabiness
One thing I forgot to mention is that this same guest image has no problem when installed bare metal. Kenton On 10/3/2011 1:20 PM, Kenton Cabiness wrote: In general, we have seen that during a reboot of a running guest (by issuing a 'reboot' command in the guest), the guest goes down

Re: [Qemu-devel] [PATCH 0/2] Use QEMU_GNUC_PREREQ to fix wrong gcc version test

2011-10-03 Thread Stefan Weil
Am 03.10.2011 22:05, schrieb Stefan Weil: Am 16.09.2011 22:03, schrieb Stefan Weil: These two patches fix a wrong gcc version test. [PATCH 1/2] Move macro QEMU_GNUC_PREREQ to compiler.h [PATCH 2/2] Fix and clean code which tests the gcc version Ping? Maybe these patches can be applied via

[Qemu-devel] Clean cache related code which was used only by PPC hosts

2011-10-03 Thread Stefan Weil
These patches clean an issue which was discussed some weeks ago (http://lists.nongnu.org/archive/html/qemu-devel/2011-09/msg02279.html): Code which was only needed for the PPC* tcg targets (flush_icache_range, qemu_cache_utils_init) was defined in files used by all host architectures. The 1st

[Qemu-devel] [PATCH 1/2] linux-user: Remove unused code

2011-10-03 Thread Stefan Weil
The code is unused since 8 years, so remove it. Signed-off-by: Stefan Weil s...@weilnetz.de --- linux-user/signal.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 89276eb..40c5eb1 100644 --- a/linux-user/signal.c +++

[Qemu-devel] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Stefan Weil
qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc and tcg/ppc64. Initialisation is called from tcg_target_init() there. Signed-off-by: Stefan Weil s...@weilnetz.de --- Makefile.objs

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Scott Wood
On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc and tcg/ppc64. Initialisation is called from tcg_target_init() there.

[Qemu-devel] [PATCH 0/1] [PULL] qemu-kvm.git uq/master queue

2011-10-03 Thread Marcelo Tosatti
The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7: etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200) are available in the git repository at: git://github.com/avikivity/qemu.git uq/master Liu, Jinsong (1): kvm: support TSC deadline MSR

[Qemu-devel] [PATCH 1/1] kvm: support TSC deadline MSR

2011-10-03 Thread Marcelo Tosatti
From: Liu, Jinsong jinsong@intel.com KVM add emulation of lapic tsc deadline timer for guest. This patch is co-operation work at qemu side. Signed-off-by: Liu, Jinsong jinsong@intel.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/cpu.h |4 +++-

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Stefan Weil
Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc and tcg/ppc64. Initialisation is called from

Re: [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code

2011-10-03 Thread Stefan Weil
Am 03.10.2011 22:43, schrieb Stefan Weil: The code is unused since 8 years, so remove it. Signed-off-by: Stefan Weil s...@weilnetz.de --- linux-user/signal.c | 5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 89276eb..40c5eb1

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Alexander Graf
On 03.10.2011, at 23:10, Stefan Weil wrote: Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Scott Wood
On 10/03/2011 04:10 PM, Stefan Weil wrote: Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Alexander Graf
On 03.10.2011, at 23:40, Scott Wood wrote: On 10/03/2011 04:10 PM, Stefan Weil wrote: Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Scott Wood
On 10/03/2011 04:36 PM, Alexander Graf wrote: With TCG, we're never executing guest code directly, but always go through TCG to emulate it. So the only case where we actually need to flush the icache is in TCG code generation, never outside, right? Right. For KVM, I agree. We need some

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Scott Wood
On 10/03/2011 04:43 PM, Alexander Graf wrote: On 03.10.2011, at 23:40, Scott Wood wrote: On 10/03/2011 04:10 PM, Stefan Weil wrote: Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Alexander Graf
On 03.10.2011, at 23:51, Scott Wood wrote: On 10/03/2011 04:43 PM, Alexander Graf wrote: On 03.10.2011, at 23:40, Scott Wood wrote: On 10/03/2011 04:10 PM, Stefan Weil wrote: Am 03.10.2011 22:52, schrieb Scott Wood: On 10/03/2011 03:43 PM, Stefan Weil wrote: qemu_cache_utils_init() is

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/44 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61

[Qemu-devel] buildbot failure in qemu on default_i386_out_of_tree

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_i386_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_out_of_tree/builds/236 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread malc
On Mon, 3 Oct 2011, Stefan Weil wrote: qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc and tcg/ppc64. Initialisation is called from tcg_target_init() there. This can't

[Qemu-devel] buildbot failure in qemu on default_mingw32

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/44 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

[Qemu-devel] buildbot failure in qemu on default_openbsd_4.9

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/44 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49

[Qemu-devel] buildbot failure in qemu on default_x86_64_out_of_tree

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_out_of_tree/builds/236 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Alexander Graf
On 04.10.2011, at 00:07, Scott Wood wrote: On 10/03/2011 05:06 PM, Alexander Graf wrote: On 03.10.2011, at 23:50, Scott Wood wrote: On 10/03/2011 04:36 PM, Alexander Graf wrote: With TCG, we're never executing guest code directly, but always go through TCG to emulate it. So the only

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code

2011-10-03 Thread Scott Wood
On 10/03/2011 05:06 PM, Alexander Graf wrote: On 03.10.2011, at 23:50, Scott Wood wrote: On 10/03/2011 04:36 PM, Alexander Graf wrote: With TCG, we're never executing guest code directly, but always go through TCG to emulate it. So the only case where we actually need to flush the icache

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_4.9

2011-10-03 Thread Anthony Liguori
On 10/03/2011 06:15 PM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/44 Buildbot URL:

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2011-10-03 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/50 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

  1   2   >