Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode

2011-10-21 Thread Stefan Weil
Am 20.10.2011 23:36, schrieb malc: On Thu, 20 Oct 2011, Stefan Weil wrote: [..snip..] +/* Trace message to see program flow. */ +#if defined(CONFIG_DEBUG_TCG_INTERPRETER) +#define TRACE() \ +loglevel \ +? fprintf(stderr, TCG %s:%u: %s()\n, __FILE__, __LINE__, __func__) \ +:

[Qemu-devel] QEMU via GDB

2011-10-21 Thread Davide
Dear all, I am trying to debug QEMU via GDB. I configured and compiled QEMU with debugging flags, i.e., # CFLAGS=-g3 -O0 ./configure --disable-gfx-check and run gdb: # gdb ./i386-linux-user/qemu-i386 (gdb) break main (gdb) run Starting program: /home/test/femu/i386-linux-user/qemu-i386

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy

2011-10-21 Thread Paolo Bonzini
On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote: On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkovpavel.borzen...@gmail.com --- block/qed.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Thanks, applied

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-21 Thread Alexander Graf
On 20.10.2011, at 22:06, David Gibson wrote: On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: On 20.10.2011, at 17:41, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Oct 20, 2011 at 10:12:51AM -0700, Alexander Graf wrote: On 17.10.2011, at 21:15, David Gibson wrote:

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-10-21 Thread Peter Maydell
On 20 October 2011 23:51, Andreas Färber andreas.faer...@web.de wrote: I have now come across such a heterogeneous SoC myself: Renesas announced the R-Car H1 this week, a SoC with one SH4A core and four ARM Cortex-A9 cores. Does it expose the SH4 to apps/OSes, or is it mostly used for power

[Qemu-devel] QEMU via GDB

2011-10-21 Thread davide . ferraretto
Dear all, I am trying to debug QEMU via GDB. I configured and compiled QEMU with debugging flags, i.e., # CFLAGS=-g3 -O0 ./configure --disable-gfx-check and run gdb: # gdb ./i386-linux-user/qemu-i386 (gdb) break main (gdb) run Starting program:

Re: [Qemu-devel] passing secrets to block devices

2011-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2011 at 09:37:11AM +0800, shu ming wrote: On 2011-10-21 5:48, Josh Durgin wrote: On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To

Re: [Qemu-devel] passing secrets to block devices

2011-10-21 Thread Daniel P. Berrange
On Thu, Oct 20, 2011 at 02:48:15PM -0700, Josh Durgin wrote: On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret.

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-21 Thread Jan Kiszka
On 2011-10-21 00:02, Michael S. Tsirkin wrote: Yes. But this still makes an API for acquiring per-vector resources a requirement. Yes, but a different one than current use/unuse. What's wrong with use/unuse as an API? It's already in place and virtio calls it. Not for that purpose. It

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-21 Thread Jan Kiszka
On 2011-10-20 12:03, Wen Congyang wrote: At 10/20/2011 05:41 PM, Jan Kiszka Write: On 2011-10-20 03:22, Wen Congyang wrote: I didn't read full story but 'crash' is used for investigating kernel core generated by kdump for several years. Considering support service guys, virsh dump should

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-21 Thread Gerd Hoffmann
Hi, dtc-lexer.lex.o: In function `pop_input_file': /home/buildbot/git/dtc/dtc-lexer.l:201: undefined reference to `yypop_buffer_state' collect2: ld returned 1 exit status make: *** [dtc] Error 1 ...this is harder. I do rely fairly heavily on the lex multiple input buffer support for

Re: [Qemu-devel] QEMU via GDB

2011-10-21 Thread Robert Wang
What is your configure parameters? I think you could try like this: ./configure --enable-debug --extra-cflags=-g3 -O0 And I did not find options like disable-gfx-check. 2011/10/21 Davide outshel...@gmail.com: Dear all, I am trying to debug QEMU via GDB. I configured and compiled QEMU with

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-10-21 Thread 陳韋任
We may want the tb cache to be per-core anyway (and one thread per core), which would avoid the problem of trying to wedge everything into one set of tb_flags. (Has anybody had a look at http://sourceforge.net/p/coremu/home/Home/ ?) COREMU treats QEMU as an entity and lauches multiple

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-21 Thread Wen Congyang
At 10/21/2011 03:11 PM, Jan Kiszka Write: On 2011-10-20 12:03, Wen Congyang wrote: At 10/20/2011 05:41 PM, Jan Kiszka Write: On 2011-10-20 03:22, Wen Congyang wrote: I didn't read full story but 'crash' is used for investigating kernel core generated by kdump for several years. Considering

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-21 Thread Michael S. Tsirkin
On Fri, Oct 21, 2011 at 09:09:10AM +0200, Jan Kiszka wrote: On 2011-10-21 00:02, Michael S. Tsirkin wrote: Yes. But this still makes an API for acquiring per-vector resources a requirement. Yes, but a different one than current use/unuse. What's wrong with use/unuse as an API? It's

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-21 Thread Paolo Bonzini
On 10/20/2011 08:35 PM, Gerd Hoffmann wrote: Hi, If there are build problems with libfdt on any platform let me know about them. I would like it to build clean as widely as possible, but I don't have that great a diversity of build environments, so I have to reply on bug reports.

[Qemu-devel] [PATCH v2 0/6] MIPS64 user mode emulation in QEMU with Cavium specific instruction support

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk This is the team work of Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt from HPCN Lab KICS UET Lahore. v1 contains: * SEQI related changes specified by Richard Henderson * Fix issues related to coding style, typos and misleading comments * Cavium

[Qemu-devel] [PATCH v2 3/6] linux-user:Signal handling for MIPS64

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- linux-user/signal.c | 438 +-- 1 files changed, 426 insertions(+), 12 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index

[Qemu-devel] [PATCH v2 6/6] Addition of Cavium instructions in disassembler

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- mips-dis.c | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/mips-dis.c b/mips-dis.c index e3a6e0b..96ab1e8 100644 --- a/mips-dis.c

[Qemu-devel] [PATCH v2 1/6] linux-user:Support for MIPS64 user mode emulation in QEMU

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- configure |1 + default-configs/mips64-linux-user.mak |1 + linux-user/main.c | 21 +++-- linux-user/mips64/syscall.h |2

Re: [Qemu-devel] passing secrets to block devices

2011-10-21 Thread Kevin Wolf
Am 20.10.2011 23:48, schrieb Josh Durgin: On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy

2011-10-21 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote: On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkovpavel.borzen...@gmail.com --- block/qed.c |6 -- 1 files changed, 4

[Qemu-devel] [PATCH v2 5/6] target-mips: Support for Cavium specific instructions

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk Signed-off-by: Ehsan Ul Haq ehsan.ul...@kics.edu.pk Signed-off-by: Abdul Qadeer qad...@kics.edu.pk Signed-off-by: Abdul Waheed awah...@kics.edu.pk --- target-mips/cpu.h |7 + target-mips/helper.h|

[Qemu-devel] [PATCH v2 0/6] MIPS64 user mode emulation in QEMU with Cavium specific instruction support

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk This is the team work of Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt from HPCN Lab KICS UET Lahore. v1 contains: * SEQI related changes specified by Richard Henderson * Fix issues related to coding style, typos and misleading comments * Cavium

[Qemu-devel] [PATCH v2 4/6] target-mips:Octeon cpu definition

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- target-mips/mips-defs.h |2 ++ target-mips/translate_init.c | 24 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/target-mips/mips-defs.h

[Qemu-devel] [PATCH v2 2/6] target-mips:enabling of 64 bit user mode and floating point operations

2011-10-21 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- target-mips/translate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..0550333 100644 --- a/target-mips/translate.c

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-21 Thread Jan Kiszka
On 2011-10-21 09:54, Michael S. Tsirkin wrote: On Fri, Oct 21, 2011 at 09:09:10AM +0200, Jan Kiszka wrote: On 2011-10-21 00:02, Michael S. Tsirkin wrote: Yes. But this still makes an API for acquiring per-vector resources a requirement. Yes, but a different one than current use/unuse.

Re: [Qemu-devel] [PATCH v2 0/7] finish coroutinization of drivers

2011-10-21 Thread Kevin Wolf
Am 20.10.2011 13:16, schrieb Paolo Bonzini: Drivers that only implement the bdrv_read and bdrv_write callbacks were unwillingly converted to be reentrant when bdrv_read and bdrv_write were changed to always create coroutines. So, we need locks aroudn read and write operations. This series

[Qemu-devel] [Qemu-trivial] [PATCH] exec.c: Remove useless comment

2011-10-21 Thread 陳韋任
As phys_ram_size had been removed since QEMU 0.12. Remove the useless comment. Signed-off-by: Chen Wen-Ren che...@iis.sinica.edu.tw --- exec.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index d0cbf15..fb21e76 100644 --- a/exec.c +++ b/exec.c @@

[Qemu-devel] [PATCH] xen_disk: Always set feature-barrier = 1

2011-10-21 Thread Kevin Wolf
The synchronous .bdrv_flush callback doesn't exist any more and a device really shouldn't poke into the block layer internals anyway. All drivers are supposed to have a correctly working bdrv_flush, so let's just hard-code this. Signed-off-by: Kevin Wolf kw...@redhat.com --- I'm not sure what

[Qemu-devel] [PATCH] block: Add !qemu_in_coroutine() assertions to synchronous functions

2011-10-21 Thread Kevin Wolf
When adding the locking, we came to the conclusion that converting read/write/flush/discard to coroutines should be enough because everything else isn't called in coroutine context. Add assertions to spell this assumption out and ensure that it won't be broken accidentally. And even if we have

[Qemu-devel] [PATCH] fw_cfg: Use g_file_get_contents instead of multiple fread() calls

2011-10-21 Thread Pavel Borzenkov
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com --- hw/fw_cfg.c | 100 ++- 1 files changed, 37 insertions(+), 63 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 8df265c..d2400f5 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c

Re: [Qemu-devel] [PATCH 11/35] scsi-disk: support READ DVD STRUCTURE

2011-10-21 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 101 +++- 1 files changed, 100 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index

Re: [Qemu-devel] [PATCH] [v3] hw/arm_gic.c: Fix save/load of irq_target array

2011-10-21 Thread Andreas Färber
Am 20.10.2011 12:48, schrieb Dmitry Koshelev: irq_target array saving/loading is in the wrong loop. Version bump. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com Acked-by: Andreas Färber andreas.faer...@web.de Applies cleanly now. Is there a particular use case that was broken before

Re: [Qemu-devel] [PATCH 12/35] scsi-disk: report media changed via GET EVENT STATUS NOTIFICATION

2011-10-21 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: This adds support for media change notification via the GET EVENT STATUS NOTIFICATION command, used by Linux versions 2.6.38 and newer. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Looks good, but the ATAPI version of the code is somewhat nicer

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-21 Thread Michael S. Tsirkin
On Fri, Oct 21, 2011 at 11:27:48AM +0200, Jan Kiszka wrote: On 2011-10-21 09:54, Michael S. Tsirkin wrote: On Fri, Oct 21, 2011 at 09:09:10AM +0200, Jan Kiszka wrote: On 2011-10-21 00:02, Michael S. Tsirkin wrote: Yes. But this still makes an API for acquiring per-vector resources a

Re: [Qemu-devel] [PATCH 13/35] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo)

2011-10-21 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |7 +-- hw/lsi53c895a.c |9 ++--- hw/scsi-bus.c| 27 --- hw/scsi-disk.c |2 +- hw/scsi.h| 11 +--

Re: [Qemu-devel] [PATCH 13/35] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo)

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 02:01 PM, Kevin Wolf wrote: -static const struct SCSIBusOps vscsi_scsi_ops = { +static const struct SCSIBusInfo vscsi_scsi_info = { +.tcq = true, +.ndev = 63, /* logical unit addressing format */ This is a change from VSCSI_REQ_LIMIT = 24. This may be a bugfix or

Re: [Qemu-devel] [PATCH 15/35] scsi: remove devs array from SCSIBus

2011-10-21 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: Change the devs array into a linked list, and add a scsi_device_find function to navigate the children list instead. This lets the SCSI bus use more complex addressing. scsi_device_find may return another LUN on the same target if none is found

Re: [Qemu-devel] [PATCH 11/35] scsi-disk: support READ DVD STRUCTURE

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 01:42 PM, Kevin Wolf wrote: +if (s-qdev.type != TYPE_ROM || !bdrv_is_inserted(s-bs)) { +return -1; +} +if (s-tray_open || !bdrv_is_inserted(s-bs)) { +scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); +return -1; +} You are

Re: [Qemu-devel] [PATCH 11/35] scsi-disk: support READ DVD STRUCTURE

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 01:42 PM, Kevin Wolf wrote: There is only one 'goto fail', all other places have a direct return -1. It would be good to be consistent. Also, as this is mostly a refactored copy from the ATAPI code, I wonder what our long-term plan is. At which point will we be able to unify what

Re: [Qemu-devel] [PATCH 15/35] scsi: remove devs array from SCSIBus

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 02:31 PM, Kevin Wolf wrote: diff --git a/hw/esp.c b/hw/esp.c index d3fb1c6..8e17005 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -217,7 +217,8 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf) s-async_len = 0; } -if (target= ESP_MAX_DEVS ||

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-21 Thread Jan Kiszka
On 2011-10-21 15:02, Dave Anderson wrote: - Original Message - At 10/21/2011 03:11 PM, Jan Kiszka Write: On 2011-10-20 12:03, Wen Congyang wrote: At 10/20/2011 05:41 PM, Jan Kiszka Write: On 2011-10-20 03:22, Wen Congyang wrote: I didn't read full story but 'crash' is used for

Re: [Qemu-devel] [PATCH 11/35] scsi-disk: support READ DVD STRUCTURE

2011-10-21 Thread Kevin Wolf
Am 21.10.2011 15:12, schrieb Paolo Bonzini: On 10/21/2011 01:42 PM, Kevin Wolf wrote: There is only one 'goto fail', all other places have a direct return -1. It would be good to be consistent. Also, as this is mostly a refactored copy from the ATAPI code, I wonder what our long-term plan

[Qemu-devel] [PATCH] Mark future contributions to GPLv2-only files as GPLv2+

2011-10-21 Thread Paolo Bonzini
Even for files are licensed GPLv2-only, let's not play catch with ourselves, and explicitly declare that future contributions to those files will also be available as any later version. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- aio.c |2 ++ block-migration.c

Re: [Qemu-devel] [PATCH] Mark future contributions to GPLv2-only files as GPLv2+

2011-10-21 Thread Anthony Liguori
On 10/21/2011 09:03 AM, Paolo Bonzini wrote: Even for files are licensed GPLv2-only, let's not play catch with ourselves, and explicitly declare that future contributions to those files will also be available as any later version. Signed-off-by: Paolo Bonzinipbonz...@redhat.com diff --git

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-21 Thread Richard W.M. Jones
On Fri, Oct 21, 2011 at 09:02:37AM -0400, Dave Anderson wrote: It would be kind of cool if there was a /dev/mem-like interface to a KVM guest's physical memory, so that you could sit on a KVM host and enter crash vmlinux-of-guest /dev/mem-of-guest in order to run live analysis of a guest. OT

Re: [Qemu-devel] [PATCH] [v3] hw/arm_gic.c: Fix save/load of irq_target array

2011-10-21 Thread Andreas Färber
Am 21.10.2011 15:58, schrieb Dmitry Koshelev: On Fri, Oct 21, 2011 at 3:42 PM, Andreas Färber afaer...@suse.de wrote: Am 20.10.2011 12:48, schrieb Dmitry Koshelev: irq_target array saving/loading is in the wrong loop. Version bump. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com

Re: [Qemu-devel] [PATCH v2 5/6] target-mips: Support for Cavium specific instructions

2011-10-21 Thread Richard Henderson
On 10/21/2011 01:17 AM, kha...@kics.edu.pk wrote: +switch (opc) { +case OPC_SEQ: +tcg_gen_setcondi_tl(TCG_COND_LTU, cpu_gpr[rd], t0, 1); +opn = seq; +break; +case OPC_SNE: +tcg_gen_setcondi_tl(TCG_COND_GTU, cpu_gpr[rd], t0, 0); +opn =

Re: [Qemu-devel] [PATCH] Mark future contributions to GPLv2-only files as GPLv2+

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 04:11 PM, Anthony Liguori wrote: Otherwise I'm a bit concerned about ambiguity here. Let's say we have to backport a fit to stable, we need to pull in this new copyright statement. But then what if we later discovered we need to pull in a fix from before 10/25. That will appear

Re: [Qemu-devel] [PATCH] Mark future contributions to GPLv2-only files as GPLv2+

2011-10-21 Thread Kevin Wolf
Am 21.10.2011 16:11, schrieb Anthony Liguori: On 10/21/2011 09:03 AM, Paolo Bonzini wrote: Even for files are licensed GPLv2-only, let's not play catch with ourselves, and explicitly declare that future contributions to those files will also be available as any later version. Signed-off-by:

[Qemu-devel] [PATCH v2 2/4] Add access control support to qemu bridge helper

2011-10-21 Thread Corey Bryant
We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism. However, we further restrict what we allow users to do to simply adding a tap device to a bridge interface by virtue of the fact that this is the only functionality we expose. This is not

Re: [Qemu-devel] [PATCH] [v3] hw/arm_gic.c: Fix save/load of irq_target array

2011-10-21 Thread andrzej zaborowski
On 20 October 2011 12:48, Dmitry Koshelev karaghio...@gmail.com wrote: irq_target array saving/loading is in the wrong loop. Version bump. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com Thanks, pushed this patch. Cheers

[Qemu-devel] [PATCH v2 3/4] Add cap reduction support to enable use as SUID

2011-10-21 Thread Corey Bryant
The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to package files with fscaps applied. This means they'll have to SUID the qemu-bridge-helper binary. To improve

Re: [Qemu-devel] [PATCH] hw/omap2: Wire up the IRQ for the 2430's fifth GPIO module

2011-10-21 Thread andrzej zaborowski
On 18 October 2011 17:12, Peter Maydell peter.mayd...@linaro.org wrote: The OMAP2430 version of the omap-gpio device has five GPIO modules, not four like the other OMAP2 versions; wire up the fifth module's IRQ line correctly. Thanks, pushed this patch. Cheers

[Qemu-devel] [PATCH v2 1/4] Add basic version of bridge helper

2011-10-21 Thread Corey Bryant
This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root while still satisfying the majority of what users tend to want to do with tap

[Qemu-devel] [PATCH v2 0/4] -net bridge: rootless bridge support for qemu

2011-10-21 Thread Corey Bryant
With qemu it is possible to run a guest from an unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network backend and a new network option for -net tap. This is less flexible when compared to existing

[Qemu-devel] [PATCH v2 4/4] Add support for net bridge

2011-10-21 Thread Corey Bryant
The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's incredibly difficult to eliminate the need to

Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-21 Thread Aneesh Kumar K.V
On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov jcmvb...@gmail.com wrote: Hi. Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers. Error messages: In file included from trace.c:2:0:

[Qemu-devel] New message-Cheque 904533.

2011-10-21 Thread The Co-operative Bank

[Qemu-devel] [PATCH] Add SPICE support to add_client monitor command

2011-10-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com With the proposal of some new APIs[1] to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new 'tls'

Re: [Qemu-devel] [PATCH] linux-user: Fix broken -version option

2011-10-21 Thread andrzej zaborowski
On 29 September 2011 16:48, Peter Maydell peter.mayd...@linaro.org wrote: Fix the -version option, which was accidentally broken in commit fc9c541:  * exit after printing version information rather than proceeding   blithely onward (and likely printing the full usage message)  * correct the

Re: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd

2011-10-21 Thread andrzej zaborowski
On 13 October 2011 19:45, Peter Maydell peter.mayd...@linaro.org wrote: Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Also pushed this patch. Cheers

[Qemu-devel] [PATCH] [v2] target-arm/machine.c: Fix load of floating point registers

2011-10-21 Thread Dmitry Koshelev
Fix load of floating point registers Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- target-arm/machine.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/machine.c b/target-arm/machine.c index 7d4fc54..aaee9b9 100644 --- a/target-arm/machine.c +++

Re: [Qemu-devel] [PATCH V5] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-21 Thread andrzej zaborowski
Hi Mathieu, On 18 October 2011 23:45, Mathieu Sonet cont...@elasticsheep.com wrote: This driver emulates the ARM AACI interface (PL041) connected to a LM4549 codec. It enables audio playback for the Versatile/PB platform. Limitations: - Supports only a playback on one channel

[Qemu-devel] [PATCH v3 01/13] remove unused function

2011-10-21 Thread Paolo Bonzini
Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mac_dbdma.c |5 - hw/mac_dbdma.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index 5affdd1..1791ec1 100644 ---

[Qemu-devel] [PATCH v3 12/13] Revert to a hand-made select loop

2011-10-21 Thread Paolo Bonzini
This reverts commit c82dc29a9112f34e0a51cad9a412cf6d9d05dfb2 and 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- iohandler.c | 54 +- 1 files changed, 1 insertions(+), 53 deletions(-) diff --git

[Qemu-devel] [PATCH v3 04/13] qemu-timer: more clock functions

2011-10-21 Thread Paolo Bonzini
These will be used when moving icount accounting to cpus.c. Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 25 + qemu-timer.h |3 +++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v3 02/13] qemu-timer: remove active_timers array

2011-10-21 Thread Paolo Bonzini
Embed the list in the QEMUClock instead. Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 59 +++-- 1 files changed, 28 insertions(+), 31 deletions(-) diff --git

[Qemu-devel] [PATCH 16/19] block: take lock around bdrv_read implementations

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This does the first part of the conversion to coroutines, by wrapping bdrv_read implementations to take the mutex. Drivers that implement bdrv_read rather than bdrv_co_readv can then benefit from asynchronous operation (at least if the underlying protocol

[Qemu-devel] [PATCH v3 10/13] main-loop: create main-loop.h

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- async.c |1 + cpus.c|7 +- cpus.h|1 - iohandler.c |1 + main-loop.h | 327 + qemu-char.h | 12 +--

[Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-21 Thread Paolo Bonzini
Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+), 76 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index acf7a15..e2551f3

[Qemu-devel] [PATCH v3 08/13] qemu-timer: move more stuff out of qemu-timer.c

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 35 --- qemu-timer.h |2 ++ savevm.c | 25 + vl.c |1 + 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c

[Qemu-devel] [PATCH v3 07/13] qemu-timer: use atexit for quit_timers

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 15 --- qemu-timer.h |1 - vl.c |1 - 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index d8507e3..7fa81e1 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@

[Qemu-devel] [PATCH 11/19] qcow2: Fix bdrv_write_compressed error handling

2011-10-21 Thread Kevin Wolf
If during allocation of compressed clusters the cluster was already allocated uncompressed, fail and properly release the l2_table (the latter avoids a failed assertion). While at it, make it return some real error numbers instead of -1. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by:

[Qemu-devel] [PATCH 05/19] xen_disk: Always set feature-barrier = 1

2011-10-21 Thread Kevin Wolf
The synchronous .bdrv_flush callback doesn't exist any more and a device really shouldn't poke into the block layer internals anyway. All drivers are supposed to have a correctly working bdrv_flush, so let's just hard-code this. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/xen_disk.c |5

[Qemu-devel] [PATCH 10/19] qemu-img: Don't allow preallocation and compression at the same time

2011-10-21 Thread Kevin Wolf
Only qcow and qcow2 can do compression at all, and they require unallocated clusters when writing the compressed data. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-img.c | 11 +++ 1 files changed, 11 insertions(+), 0

[Qemu-devel] [PATCH 02/19] add socket_set_block

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- oslib-posix.c |7 +++ oslib-win32.c |6 ++ qemu_socket.h |1 + 3 files changed, 14

[Qemu-devel] [PATCH 08/19] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This similarly adds support for coroutine and asynchronous discard. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 102 +++-- block.h

[Qemu-devel] [PATCH v3 11/13] main-loop: create main-loop.c

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.objs|2 +- cpus.c | 189 +- cpus.h |1 + main-loop.c | 495 ++ main-loop.h | 24 +++ os-win32.c | 123

[Qemu-devel] [PATCH v3 05/13] qemu-timer: move icount to cpus.c

2011-10-21 Thread Paolo Bonzini
None of this is needed by tools, and most of it can even be made static inside cpus.c. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c| 295 + exec-all.h| 14 +++ exec.c|3 - qemu-common.h |4 +

[Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop

2011-10-21 Thread Paolo Bonzini
The following changes since commit c76eaf13975130768070ecd2d4f3107eb69ab757: hw/9pfs: Fix broken compilation caused by wrong trace events (2011-10-20 15:30:59 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git split-main-loop-for-anthony This patch series

[Qemu-devel] [PATCH v3 09/13] qemu-timer: do not use RunState change handlers

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 58926dd..f11a28d 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -273,7 +273,11 @@ static QEMUClock

[Qemu-devel] [PATCH 09/19] fdc: Fix floppy port I/O

2011-10-21 Thread Kevin Wolf
The floppy device was broken by commit 212ec7ba (fdc: Convert to isa_register_portio_list). While the old interface provided the port number relative to the floppy drive's io_base, the new one provides the real port number, so we need to apply a bitmask now to get the register number.

[Qemu-devel] [PATCH 03/19] block: rename bdrv_co_rw_bh

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9873b57..7184a0f 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH 06/19] block: unify flush implementations

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplified to always go through a coroutine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-21 Thread Stuart Brady
On Fri, Oct 21, 2011 at 09:37:02AM +0200, Paolo Bonzini wrote: On 10/21/2011 02:26 AM, Stuart Brady wrote: They all look okay, perhaps the include path you passed to Coccinelle is incomplete? Ah, good point! I'm not sure what include dirs are needed, though... anyone have any advice?

[Qemu-devel] [PATCH 17/19] block: take lock around bdrv_write implementations

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This does the first part of the conversion to coroutines, by wrapping bdrv_write implementations to take the mutex. Drivers that implement bdrv_write rather than bdrv_co_writev can then benefit from asynchronous operation (at least if the underlying

[Qemu-devel] [PATCH v3 06/13] qemu-timer: do not refer to runstate_is_running()

2011-10-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |1 + qemu-timer.c |5 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 21538e6..1328baa 100644 --- a/cpus.c +++ b/cpus.c @@ -1059,6 +1059,7 @@ void pause_all_vcpus(void) {

[Qemu-devel] [PULL 00/19] Block patches

2011-10-21 Thread Kevin Wolf
The following changes since commit c2e2343e1faae7bbc77574c12a25881b1b696808: hw/arm_gic.c: Fix save/load of irq_target array (2011-10-21 17:19:56 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alex Jia (1): fix memory leak in aio_write_f

[Qemu-devel] [PATCH 15/19] block: add a CoMutex to synchronous read drivers

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com The big conversion of bdrv_read/write to coroutines caused the two homonymous callbacks in BlockDriver to become reentrant. It goes like this: 1) bdrv_read is now called in a coroutine, and calls bdrv_read or bdrv_pread. 2) the nested bdrv_read goes

[Qemu-devel] [PATCH 01/19] sheepdog: add coroutine_fn markers

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This makes the following patch easier to review. Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c | 14 +++--- 1 files changed, 7

[Qemu-devel] [PATCH 2/2] block: Handle cache=unsafe only in raw-posix/win32

2011-10-21 Thread Kevin Wolf
The expected meaning of cache=unsafe with qcow2 is that on a flush the metadata caches are written out, but no fsync is performed. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |4 +--- block/raw-posix.c |4 block/raw-win32.c |4 3 files changed, 9

[Qemu-devel] [PATCH v3 13/13] simplify main loop functions

2011-10-21 Thread Paolo Bonzini
Provide a clean example of how to use the main loop in the tools. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |5 cpus.h |1 - vl.c | 79 +-- 3 files changed, 41 insertions(+), 44 deletions(-) diff

[Qemu-devel] [PATCH 14/19] vmdk: clean up open

2011-10-21 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Move vmdk_parent_open to vmdk_open. There's another path how vmdk_parent_open can be reached: vmdk_parse_extents() - vmdk_open_sparse() - vmdk_open_vmdk4() - vmdk_open_desc_file(). If that can happen, however, the code is bogus. vmdk_parent_open

[Qemu-devel] [PATCH 1/2] raw-posix: Convert to bdrv_co_flush

2011-10-21 Thread Kevin Wolf
The next patch will introduce an early return. Using a bottom half to invoke the AIO callback wouldn't be much less code, so let's go with the native block layer interface. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw-posix.c | 53

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-21 Thread Paolo Bonzini
On 10/21/2011 07:08 PM, Kevin Wolf wrote: Avi complained that not even writing out qcow2's cache on bdrv_flush() made cache=unsafe too unsafe to be useful. He's got a point. Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash. If you do this for raw-posix, you need to do it

[Qemu-devel] New message-Cheque 0000904533 on hold.

2011-10-21 Thread The Co-operative Bank
Dear Customer, You Have One New Message You have a new message in online banking. Subject: Cheque on hold. Resolve the problem. We telephoned you today in relation to your Cheque payment, unfortunately we were unable to contact you on the telephone numbers registered for your account to

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-10-21 Thread Andreas
Am 21.10.2011 09:26, schrieb 陳韋任: COREMU treats QEMU as an entity and lauches multiple QEMUs at the same time. QEMUs communicates to each other by using a underlying thin layer provided by COREMU. I think this approach is much clean than trying to parallelize QEMU itself. In this case I

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-10-21 Thread Steve
@Peter - thanks, fair enough... I don't know enough about qemu's source to understand what you mean, but clearly it's a complex issue. For now the patch seems to work for me-- I haven't had the issue that @Ricardo discusses (again, I'm on armv7l, though). -- You received this bug notification

  1   2   >