Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-24 Thread Aneesh Kumar K.V
On Sun, 23 Oct 2011 15:54:59 +0200, Jan Kiszka jan.kis...@web.de wrote: On 2011-10-21 17:10, Aneesh Kumar K.V wrote: On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov jcmvb...@gmail.com wrote: Hi. Current git head build with trace enabled is broken by the commit

Re: [Qemu-devel] [Qemu-discuss] [Qemu-discussion] QEMU via GDB

2011-10-24 Thread davide . ferraretto
It dosen't work. GDB returns the same error. - Original Message - From: davide.ferrare...@studenti.univr.it Date: Monday, October 24, 2011 8:37 Subject: Re: [Qemu-discuss] [Qemu-discussion] QEMU via GDB To: davide.ferrare...@studenti.univr.it It dosen't work. GDB return the same error.

[Qemu-devel] Question about intermediate code generation in qemu (tcg)

2011-10-24 Thread Carter Cheng
Hi, I was wondering if someone could help me understand some aspects of the current qemu code generation routines. How are floating point and SSE ops currently handled? I do not see specific tcg routines for these cases(the README seems to indicate that FP and vector ops are not handled using the

Re: [Qemu-devel] [PATCH] qxl: reset update_surface

2011-10-24 Thread Gerd Hoffmann
On 10/23/11 17:03, Alon Levy wrote: update init_qxl_ram to reset update_surface to 0. This fixes one case of breakage when installing an old driver in a vm that had a new driver installed. The newer driver would know about surface creation and would change update_surface to !=0, then a reset

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 21.10.2011 20:44, schrieb Paolo Bonzini: On 10/21/2011 07:08 PM, Kevin Wolf wrote: Avi complained that not even writing out qcow2's cache on bdrv_flush() made cache=unsafe too unsafe to be useful. He's got a point. Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash. It's

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 09:37 AM, Kevin Wolf wrote: Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash. It's surely expected on a host crash, but is it for a qemu crash? cache=unsafe was introduced to avoid fsync() costs, which it still does after this patch. I think it's not about

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 23.10.2011 16:33, schrieb Paolo Bonzini: On 10/22/2011 05:07 PM, Alexander Graf wrote: On 21.10.2011, at 11:44, Paolo Bonzini wrote: On 10/21/2011 07:08 PM, Kevin Wolf wrote: Avi complained that not even writing out qcow2's cache on bdrv_flush() made cache=unsafe too unsafe to be useful.

Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-24 Thread Aneesh Kumar K.V
On Mon, 24 Oct 2011 11:46:21 +0530, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Sun, 23 Oct 2011 15:54:59 +0200, Jan Kiszka jan.kis...@web.de wrote: On 2011-10-21 17:10, Aneesh Kumar K.V wrote: On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov jcmvb...@gmail.com wrote:

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 09:53, schrieb Paolo Bonzini: On 10/24/2011 09:37 AM, Kevin Wolf wrote: Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash. It's surely expected on a host crash, but is it for a qemu crash? cache=unsafe was introduced to avoid fsync() costs, which it still

Re: [Qemu-devel] Question about intermediate code generation in qemu (tcg)

2011-10-24 Thread Peter Maydell
On 24 October 2011 07:46, Carter Cheng carterch...@gmail.com wrote: I was wondering if someone could help me understand some aspects of the current qemu code generation routines. How are floating point and SSE ops currently handled? I do not see specific tcg routines for these cases(the README

[Qemu-devel] [PATCH] hw/9pfs: Make VirtTFS work correctly

2011-10-24 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com this patch fix multiple issues with VitFS tracing. a) Add tracepoint to the correct code path. We handle error in complete_pdu b) Fix indentation in python script c) Fix variable naming issue in python script Signed-off-by: Aneesh Kumar K.V

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 10:17 AM, Kevin Wolf wrote: I think it's not about why is it there, but rather about what is it useful for. My interpretation of it is I do not need the image anymore unless the command exits cleanly: VM installations, qemu-img conversions, BDRV_O_SNAPSHOT (doesn't do it

Re: [Qemu-devel] [PATCH] monitor: refactor whitespace and optional argument parsing

2011-10-24 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: Takes out the optional ('?') message parsing from the main switch loop in monitor_parse_command. Adds optional argument option for boolean parameters. Signed-off-by: Alon Levy al...@redhat.com --- Previous patch used qemu_free (that's how old it is),

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 10:47, schrieb Paolo Bonzini: On 10/24/2011 10:17 AM, Kevin Wolf wrote: I think it's not about why is it there, but rather about what is it useful for. My interpretation of it is I do not need the image anymore unless the command exits cleanly: VM installations, qemu-img

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Peter Maydell
On 24 October 2011 09:17, Kevin Wolf kw...@redhat.com wrote: Am 24.10.2011 09:53, schrieb Paolo Bonzini: I think it's not about why is it there, but rather about what is it useful for.  My interpretation of it is I do not need the image anymore unless the command exits cleanly: VM

Re: [Qemu-devel] [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed

2011-10-24 Thread Ben Hutchings
On Mon, 2011-10-24 at 07:25 +0200, Michael S. Tsirkin wrote: On Mon, Oct 24, 2011 at 02:54:59PM +1030, Rusty Russell wrote: On Sat, 22 Oct 2011 13:43:11 +0800, Jason Wang jasow...@redhat.com wrote: This make let virtio-net driver can send gratituous packet by a new config bit -

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 10:54 AM, Kevin Wolf wrote: I don't know... checking BDRV_O_NO_FLUSH in the drivers rather than in the generic code sounds like a layering violation. Perhaps what you're after is a separation of bdrv_co_flush from bdrv_{,co_,aio_}fsync? Then BDRV_O_NO_FLUSH (better

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 11:26, schrieb Paolo Bonzini: On 10/24/2011 10:54 AM, Kevin Wolf wrote: I don't know... checking BDRV_O_NO_FLUSH in the drivers rather than in the generic code sounds like a layering violation. Perhaps what you're after is a separation of bdrv_co_flush from

[Qemu-devel] [PATCH] hw/9pfs: Make VirtFS tracing work correctly

2011-10-24 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com this patch fix multiple issues with VirtFS tracing. a) Add tracepoint to the correct code path. We handle error in complete_pdu b) Fix indentation in python script c) Fix variable naming issue in python script Signed-off-by: Aneesh Kumar K.V

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 11:36 AM, Kevin Wolf wrote: You're changing the API and asking for possibly non-trivial changes in all protocol drivers, in order to accomodate semantics that all format drivers potentially could desire. So I wonder if the problem is simply that the current API is not

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 11:40, schrieb Paolo Bonzini: On 10/24/2011 11:36 AM, Kevin Wolf wrote: You're changing the API and asking for possibly non-trivial changes in all protocol drivers, in order to accomodate semantics that all format drivers potentially could desire. So I wonder if the problem

Re: [Qemu-devel] Question about intermediate code generation in qemu (tcg)

2011-10-24 Thread Carter Cheng
Thanks Peter. On Mon, Oct 24, 2011 at 7:39 PM, Peter Maydell peter.mayd...@linaro.orgwrote: On 24 October 2011 07:46, Carter Cheng carterch...@gmail.com wrote: I was wondering if someone could help me understand some aspects of the current qemu code generation routines. How are floating

[Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Chris Webb
I have a qemu-kvm guest (apparently a Ubuntu 11.04 x86-64 install) which has stopped and refuses to continue: (qemu) info status VM status: paused (qemu) cont (qemu) info status VM status: paused The host is running linux 2.6.39.2 with qemu-kvm 0.14.1 on 24-core Opteron 6176 box, and

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 11:53 AM, Kevin Wolf wrote: I'm talking about the internal driver API only. The external API is fine as is. Ok, so external callers don't force us to do it. Yes, we could split bdrv_flush internally into two functions for flush one level to the OS and flush all the

[Qemu-devel] (no subject)

2011-10-24 Thread 王永博
ff

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 12:00, schrieb Chris Webb: I have a qemu-kvm guest (apparently a Ubuntu 11.04 x86-64 install) which has stopped and refuses to continue: (qemu) info status VM status: paused (qemu) cont (qemu) info status VM status: paused The host is running linux 2.6.39.2 with

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Chris Webb
Kevin Wolf kw...@redhat.com writes: Am 24.10.2011 12:00, schrieb Chris Webb: I have qemu monitor access and can even strace the relevant qemu process if necessary: is it possible to use this to diagnose what's caused this guest to stop, e.g. the unsupported instruction if it's an emulation

[Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH] fw_cfg: Use g_file_get_contents instead of multiple fread() calls

2011-10-24 Thread Peter Maydell
On 21 October 2011 12:35, Pavel Borzenkov pavel.borzen...@gmail.com wrote: Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com Thanks; I think this looks a lot nicer than the raw file ops code did. I think we could probably make the error messages slightly more user friendly while we're

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 12:58, schrieb Chris Webb: Kevin Wolf kw...@redhat.com writes: Am 24.10.2011 12:00, schrieb Chris Webb: I have qemu monitor access and can even strace the relevant qemu process if necessary: is it possible to use this to diagnose what's caused this guest to stop, e.g. the

Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-24 Thread Peter Maydell
On 22 October 2011 11:33, Andreas Färber andreas.faer...@web.de wrote: Am 22.10.2011 12:20, schrieb Peter Maydell: On 3 October 2011 11:32, Andreas Färber andreas.faer...@web.de wrote: -#define ARM_CPUID_ARM1136     0x4117b363 -#define ARM_CPUID_ARM1136_R2  0x4107b362 +#define

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Chris Webb
Kevin Wolf kw...@redhat.com writes: In qemu 1.0 we'll have an extended 'info status' that includes the stop reason, but 0.14 doesn't have this yet (was committed to git master only recently). Right, okay. I might take a look at cherry-picking and back-porting that to our version of qemu-kvm

[Qemu-devel] [PATCH v2] fw_cfg: Use g_file_get_contents instead of multiple fread() calls

2011-10-24 Thread Pavel Borzenkov
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com --- hw/fw_cfg.c | 102 ++- 1 files changed, 38 insertions(+), 64 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 8df265c..dbcb888 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c

[Qemu-devel] [PATCH] tools: reorganize Makefile variables

2011-10-24 Thread Paolo Bonzini
- Add all dependencies of the block layer to block-obj-y, and all dependencies of QObject to qobject-obj-y - Remove the block layer from tools-obj-y, add it to qemu-img, qemu-nbd, qemu-io - Add qobject-obj-y and tools-obj-y wherever useful, remove duplicates Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 13:29, schrieb Chris Webb: Kevin Wolf kw...@redhat.com writes: In qemu 1.0 we'll have an extended 'info status' that includes the stop reason, but 0.14 doesn't have this yet (was committed to git master only recently). Right, okay. I might take a look at cherry-picking and

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 01:04 PM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. - What's left to merge for 1.0. - What kind of patch after the end of the freeze Paolo

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Peter Maydell
On 24 October 2011 12:35, Paolo Bonzini pbonz...@redhat.com wrote: On 10/24/2011 01:04 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - What's left to merge for 1.0. Things on my list, FWIW: * current target-arm pullreq * PL041 support (needs

[Qemu-devel] [PATCH 0/5] monitor+qxl: async monitor support

2011-10-24 Thread Alon Levy
This patchset converts the screen_dump command to async across qemu, and then implements it asynchronously for the qxl device in Native mode. This fixes a hang that is caused when the spice client is also a qemu monitor client and the client is single threaded: io thread

Re: [Qemu-devel] qemu-kvm guest which won't 'cont' (emulation failure?)

2011-10-24 Thread Chris Webb
Kevin Wolf kw...@redhat.com writes: Good point... The only other thing that I can think of would be attaching gdb and setting a breakpoint in vm_stop() or something. Perfect, that seems to identified what's going on very nicely: (gdb) break vm_stop Breakpoint 1 at 0x407d10: file

[Qemu-devel] [PATCH 2/5] qxl: s/__FUNCTION__/__func__/, change logging levels

2011-10-24 Thread Alon Levy
--- hw/qxl.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 4003e53..af02cda 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -515,7 +515,7 @@ static int interface_get_command(QXLInstance *sin, struct QXLCommandExt *ext) switch (qxl-mode)

[Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-24 Thread Alon Levy
Make screen_dump monitor command an async command to allow next for qxl to implement it as a initiating call to red_worker and completion on callback, to fix a deadlock when issueing a screendump command via libvirt while connected with a libvirt controlled spice-gtk client. This patch introduces

[Qemu-devel] [PATCH 3/5] qxl: support concurrent async commands

2011-10-24 Thread Alon Levy
change the single pending current_async to a linked list of pending SpiceAsyncCommand. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl-render.c|2 +- hw/qxl.c | 145 +++- hw/qxl.h | 29 +--

[Qemu-devel] [PATCH 5/5] qxl: support async monitor screen dump

2011-10-24 Thread Alon Levy
Split qxl_spice_update_area_complete from qxl_render_update, use SPICE_INTERFACE_QXL_MINOR 2 introduced spice_qxl_update_area_dirty_async to retrive the dirty rectangles asyncronously (the previous spice_qxl_update_area_async did not accept a dirty rectangles array). Introduce

[Qemu-devel] [PATCH 4/5] qxl: split qxl_render_display_resized

2011-10-24 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl-render.c | 75 ++- 1 files changed, 41 insertions(+), 34 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 23a4289..fd3c016 100644 --- a/hw/qxl-render.c +++

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Andreas Färber
Am 24.10.2011 14:02, schrieb Peter Maydell: On 24 October 2011 12:35, Paolo Bonzini pbonz...@redhat.com wrote: On 10/24/2011 01:04 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - What's left to merge for 1.0. I also think that it's somewhat

Re: [Qemu-devel] [PATCH v2 1/4] Add basic version of bridge helper

2011-10-24 Thread Corey Bryant
On 10/23/2011 08:56 AM, Blue Swirl wrote: On Fri, Oct 21, 2011 at 15:07, Corey Bryantcor...@linux.vnet.ibm.com wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN

[Qemu-devel] [PATCH 06/19] qapi: Convert the cpu command

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx |3 +-- hmp.c| 12 hmp.h|1 + monitor.c| 11 --- qapi-schema.json | 11 +++ qmp-commands.hx |

[Qemu-devel] [PATCH 11/19] qapi: Convert query-blockstats

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 111 ++ hmp.c| 34 hmp.h|1 + monitor.c| 11 +-

[Qemu-devel] [PATCH 19/19] Drop qemu-objects.h from modules that don't require it

2011-10-24 Thread Luiz Capitulino
Previous commits dropped most qobjects usage from qemu modules (now they are a low level interface used by the QAPI). However, some modules still include the qemu-objects.h header file. This commit drops qemu-objects.h from some of those modules and includes qjson.h instead, which is what they

[Qemu-devel] [PATCH 18/19] Monitor: do_info(): Drop QMP command handling code

2011-10-24 Thread Luiz Capitulino
Previous commits converted all existing QMP commands to the QAPI, now each info command does its own QMP call. Let's then drop all QMP command handling code from do_info(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 32 +--- 1 files

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-24 Thread Kevin Wolf
Am 21.09.2011 11:37, schrieb Ronnie Sahlberg: This provides built-in support for iSCSI to QEMU. This has the advantage that the iSCSI devices need not be made visible to the host, which is useful if you have very many virtual machines and very many iscsi devices. It also has the benefit

[Qemu-devel] [PATCH 07/19] qapi: Convert query-cpus

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cpus.c | 45 hmp.c| 39 + hmp.h|1 + monitor.c| 101

[Qemu-devel] [PATCH 09/19] block: Rename the BlockIOStatus enum values

2011-10-24 Thread Luiz Capitulino
The biggest change is to rename its prefix from BDRV_IOS to BLOCK_DEVICE_IO_STATUS. Next commit will convert the query-block command to the QAPI and that's how the enumeration is going to be generated. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 18 ++

Re: [Qemu-devel] [PATCH v2 2/4] Add access control support to qemu bridge helper

2011-10-24 Thread Corey Bryant
On 10/23/2011 09:10 AM, Blue Swirl wrote: On Fri, Oct 21, 2011 at 15:07, Corey Bryantcor...@linux.vnet.ibm.com wrote: We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism. However, we further restrict what we allow users to do to

[Qemu-devel] [PATCH 10/19] qapi: Convert query-block

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 112 ++--- block.h |5 -- block_int.h |3 +- hmp.c| 42 hmp.h

Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-24 Thread Anthony PERARD
On Thu, Oct 20, 2011 at 11:57, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: diff --git a/Makefile.target b/Makefile.target index 417f23e..c518103 100644 --- a/Makefile.target +++ b/Makefile.target @@ -208,6 +208,8 @@ obj-$(CONFIG_NO_XEN) += xen-stub.o  obj-i386-$(CONFIG_XEN)

[Qemu-devel] [PATCH 12/19] qerror: Add a user string for QERR_FEATURE_DISABLED

2011-10-24 Thread Luiz Capitulino
Missing from commit 821601ea5b. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 68998d4..4b48b39 100644 --- a/qerror.c +++ b/qerror.c @@ -117,6 +117,10 @@ static const

[Qemu-devel] [PATCH 08/19] block: iostatus: Drop BDRV_IOS_INVAL

2011-10-24 Thread Luiz Capitulino
A future commit will convert bdrv_info() to the QAPI and it won't provide IOS_INVAL. Luckily all we have to do is to add a new 'iostatus_enabled' member to BlockDriverState and use it instead. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c |5 +++-- block.h |3

[Qemu-devel] [PATCH 01/19] qapi-commands.py: Don't call the output marshal on error

2011-10-24 Thread Luiz Capitulino
Today we generate something like this: int qmp_marshal_input_query_foo(...) ... retval = qmp_query_foo(errp); qmp_marshal_output_query_foo(retval, ret, errp); ... However, if qmp_query_foo() fails 'retval' will probably be NULL, which can cause a segfault

Re: [Qemu-devel] [PATCH] Add Qemu A15 minimal support for ARM KVM

2011-10-24 Thread Peter Maydell
On 29 September 2011 08:30, bill4car...@gmail.com wrote: From: Bill Carson bill4car...@gmail.com This patch add some A15 codes which enables ARM KVM could run Guest OS build with Versatile Express Cortex-A15x4 tile. Thanks for sending this; I have somewhat belatedly written up some comments

[Qemu-devel] [PATCH 17/19] QMP: Drop the query commands dispatch table

2011-10-24 Thread Luiz Capitulino
Because QMP development originated in the monitor, it has inherited the monitor's distinction between query- and non-query commands. However, previous commits unified both commands and the distinction is gone. This commit drops the query commands dispatch table and does some simplifications along

[Qemu-devel] [PATCH 03/19] qapi: Convert query-migrate

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp.c| 31 hmp.h|1 + migration.c | 82 +++-- monitor.c| 11 +--

Re: [Qemu-devel] [PATCH v2 3/4] Add cap reduction support to enable use as SUID

2011-10-24 Thread Corey Bryant
On 10/23/2011 09:22 AM, Blue Swirl wrote: On Fri, Oct 21, 2011 at 15:07, Corey Bryantcor...@linux.vnet.ibm.com wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a

[Qemu-devel] [PATCH 04/19] Monitor: Make mon_set_cpu() public

2011-10-24 Thread Luiz Capitulino
Also rename it to monitor_set_cpu(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 11 +-- monitor.h |1 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index ea5ccd8..3f99ea0 100644 --- a/monitor.c +++ b/monitor.c @@

[Qemu-devel] [PATCH 14/19] qapi: Convert query-spice

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp.c| 43 + hmp.h|1 + monitor.c| 13 +- qapi-schema.json | 74 + qmp-commands.hx |8 +++

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-24 Thread Dave Anderson
- Original Message - The question is that: 'virsh dump' can not be used when host pci device is used by guest. We are discussing how to fix the problem. We have determined that introduce a new monitor command dump. Jan suggested that the core file's format is gdb standard core

Re: [Qemu-devel] [PATCH V2 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-10-24 Thread Anthony PERARD
On Thu, Oct 20, 2011 at 11:57, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Oct 2011, Anthony PERARD wrote: Signed-off-by: Anthony PERARD anthony.per...@citrix.com ---  Makefile.target      |    1 +  hw/host-pci-device.c |  245

[Qemu-devel] [PATCH 02/19] qapi: Convert query-mice

2011-10-24 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp.c| 20 hmp.h|1 + input.c | 64 + monitor.c| 11 +

Re: [Qemu-devel] [PATCH V2 08/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-10-24 Thread Anthony PERARD
On Thu, Oct 20, 2011 at 11:59, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: +    if (s-pm_state != NULL s-pm_state-flags PT_FLAG_TRANSITING) { +        qemu_mod_timer(s-pm_state-pm_timer, +                       qemu_get_clock_ms(rt_clock) + s-pm_state-pm_delay); +    } where

[Qemu-devel] [PATCH 15/19] qapi: Convert query-balloon

2011-10-24 Thread Luiz Capitulino
Please, note that some of the code supporting memory statistics is still around (eg. virtio_balloon_receive_stats() and reset_stats()). Also, the qmp_query_balloon() function is synchronous and thus doesn't make any use of the (not fully working) monitor's asynchronous command support (the old

Re: [Qemu-devel] [PATCH V2 09/10] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2011-10-24 Thread Anthony PERARD
On Thu, Oct 20, 2011 at 12:01, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: +    /* disable MSI/MSI-X and MSI-INTx translation */ +    if (s-msi) { +        pt_msi_disable(s); +    } +    if (s-msix) { +        pt_msix_disable(s); +    } these msi functions are not

[Qemu-devel] [PATCH 16/19] qapi: Convert query-pci

2011-10-24 Thread Luiz Capitulino
This also fixes a bug with the old version: QMP would invert device id and vendor id. This would look ok on HMP because it was printing device:vendor instead of vendor:device. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp.c

[Qemu-devel] [PATCH 13/19] qapi: Convert query-vnc

2011-10-24 Thread Luiz Capitulino
There are three important remarks in relation to the non-qapi command: 1. This commit also fixes the behavior of the 'query-vnc' and 'info vnc' commands to return an error when qemu is built without VNC support (ie. --disable-vnc). The non-qapi command would return the OK response in

[Qemu-devel] [PATCH 05/19] Monitor: Introduce monitor_get_cpu_index()

2011-10-24 Thread Luiz Capitulino
Returns 'cur_mons's CPU index. A future commit will use it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 + monitor.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 3f99ea0..3e1cd33 100644 --- a/monitor.c +++

[Qemu-devel] [PATCH v1 00/19]: QAPI conversions round 2

2011-10-24 Thread Luiz Capitulino
This series completes the conversion of current QMP query commands to the QAPI framework. IOW, with this series applied no single query command will be building QObjects by hand. This series also contains two fixes and some cleanups. One of the fixes solves a problem with the generated code which

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-24 Thread Bob Breuer
Kai Tietz wrote: Hi, For trunk-version I have a tentative patch for this issue. On 4.6.x and older branches this doesn't work, as here we can't differenciate that easy between ms- and sysv-abi. But could somebody give this patch a try? Regards, Kai ChangeLog *

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-24 Thread Avi Kivity
On 10/24/2011 04:25 PM, Dave Anderson wrote: The question is that: 'virsh dump' can not be used when host pci device is used by guest. We are discussing how to fix the problem. We have determined that introduce a new monitor command dump. Jan suggested that the core file's format is

Re: [Qemu-devel] [PATCH 29/35] scsi-disk: remove cluster_size

2011-10-24 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: This field is redundant, and its presence makes it more complicated to share reqops between the upcoming scsi-block and scsi-generic. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 45

Re: [Qemu-devel] [PATCH 15/24] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-24 Thread Pierre Riteau
This commit (1c9805a398cc1125b4defa6367172c8c2c0bca9f in Git) breaks qemu-nbd for me. I cannot mount any VM image (raw or qcow2 format) with this commit or today's HEAD. Previous commit c5fbe57111ef59c315a71cd80e8b0af59e36ff21 works fine. The qemu-nbd process hangs while reading disk: 31175 ?

Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-24 Thread Gerd Hoffmann
On 10/24/11 14:02, Alon Levy wrote: Make screen_dump monitor command an async command to allow next for qxl to implement it as a initiating call to red_worker and completion on callback, to fix a deadlock when issueing a screendump command via libvirt while connected with a libvirt controlled

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-24 Thread Dave Anderson
- Original Message - On 10/24/2011 04:25 PM, Dave Anderson wrote: The question is that: 'virsh dump' can not be used when host pci device is used by guest. We are discussing how to fix the problem. We have determined that introduce a new monitor command dump. Jan suggested

Re: [Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device passthrough

2011-10-24 Thread Kevin Wolf
Am 13.10.2011 13:04, schrieb Paolo Bonzini: scsi-block is a new device that supports device passthrough of Linux block devices (i.e. /dev/sda, not /dev/sg0). It uses SG_IO for commands other than I/O commands, and regular AIO read/writes for I/O commands. Besides being simpler to configure

Re: [Qemu-devel] [PATCH 3/5] qxl: support concurrent async commands

2011-10-24 Thread Gerd Hoffmann
Hi, +SpiceAsyncCommand *push_spice_async_command(PCIQXLDevice *qxl, +uint32_t async_io, int size) +/* caller must call g_free */ +static SpiceAsyncCommand *pop_spice_async_command(PCIQXLDevice *qxl, + uint64_t cookie) +{ push/pop

Re: [Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device passthrough

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 05:28 PM, Kevin Wolf wrote: scsi-block is a new device that supports device passthrough of Linux block devices (i.e. /dev/sda, not /dev/sg0). It uses SG_IO for commands other than I/O commands, and regular AIO read/writes for I/O commands. Besides being simpler to configure

Re: [Qemu-devel] [PATCH 5/5] qxl: support async monitor screen dump

2011-10-24 Thread Gerd Hoffmann
On 10/24/11 14:02, Alon Levy wrote: Split qxl_spice_update_area_complete from qxl_render_update, use SPICE_INTERFACE_QXL_MINOR 2 introduced spice_qxl_update_area_dirty_async to retrive the dirty rectangles asyncronously (the previous spice_qxl_update_area_async did not accept a dirty

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-24 Thread Avi Kivity
On 10/24/2011 05:25 PM, Dave Anderson wrote: - Original Message - On 10/24/2011 04:25 PM, Dave Anderson wrote: The question is that: 'virsh dump' can not be used when host pci device is used by guest. We are discussing how to fix the problem. We have determined that

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Luiz Capitulino
On Mon, 24 Oct 2011 13:02:05 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 24 October 2011 12:35, Paolo Bonzini pbonz...@redhat.com wrote: On 10/24/2011 01:04 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - What's left to merge for 1.0.

Re: [Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device passthrough

2011-10-24 Thread Kevin Wolf
Am 24.10.2011 17:28, schrieb Paolo Bonzini: On 10/24/2011 05:28 PM, Kevin Wolf wrote: scsi-block is a new device that supports device passthrough of Linux block devices (i.e. /dev/sda, not /dev/sg0). It uses SG_IO for commands other than I/O commands, and regular AIO read/writes for I/O

Re: [Qemu-devel] [PATCH 29/35] scsi-disk: remove cluster_size

2011-10-24 Thread Paolo Bonzini
On 10/24/2011 05:10 PM, Kevin Wolf wrote: -bdrv_get_geometry(s-qdev.conf.bs,nb_sectors); -nb_sectors /= s-cluster_size; -if (nb_sectors) { -nb_sectors--; +if (s-qdev.blocksize) { When would it be 0? And wouldn't we crash with a zero blocksize anyway?

Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-24 Thread Luiz Capitulino
On Mon, 24 Oct 2011 17:13:14 +0200 Gerd Hoffmann kra...@redhat.com wrote: On 10/24/11 14:02, Alon Levy wrote: Make screen_dump monitor command an async command to allow next for qxl to implement it as a initiating call to red_worker and completion on callback, to fix a deadlock when

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-24 Thread Dave Anderson
- Original Message - No, an ELF image of the guest's physical memory. Well then that should be pretty straight forward to support. Depending upon how similar it would be to the standard kdump ELF format, the only other issue is how to determine the physical base address at

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-24 Thread Kai Tietz
2011/10/24 Bob Breuer breu...@mc.net: Kai Tietz wrote: Hi, For trunk-version I have a tentative patch for this issue.  On 4.6.x and older branches this doesn't work, as here we can't differenciate that easy between ms- and sysv-abi. But could somebody give this patch a try? Regards, Kai

Re: [Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop

2011-10-24 Thread Anthony Liguori
On 10/21/2011 11:26 AM, Paolo Bonzini wrote: The following changes since commit c76eaf13975130768070ecd2d4f3107eb69ab757: hw/9pfs: Fix broken compilation caused by wrong trace events (2011-10-20 15:30:59 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PULL 00/19] Block patches

2011-10-24 Thread Anthony Liguori
On 10/21/2011 12:18 PM, Kevin Wolf wrote: The following changes since commit c2e2343e1faae7bbc77574c12a25881b1b696808: hw/arm_gic.c: Fix save/load of irq_target array (2011-10-21 17:19:56 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled.

Re: [Qemu-devel] [PATCH v2 2/4] Add access control support to qemu bridge helper

2011-10-24 Thread Blue Swirl
On Mon, Oct 24, 2011 at 13:44, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 10/23/2011 09:10 AM, Blue Swirl wrote: On Fri, Oct 21, 2011 at 15:07, Corey Bryantcor...@linux.vnet.ibm.com  wrote:  We go to great lengths to restrict ourselves to just cap_net_admin as an OS  enforced

Re: [Qemu-devel] [PATCH v2 3/4] Add cap reduction support to enable use as SUID

2011-10-24 Thread Blue Swirl
On Mon, Oct 24, 2011 at 14:13, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 10/23/2011 09:22 AM, Blue Swirl wrote: On Fri, Oct 21, 2011 at 15:07, Corey Bryantcor...@linux.vnet.ibm.com  wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using:  setcap

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-24 Thread Alexander Graf
On 23.10.2011, at 22:29, David Gibson wrote: On Thu, Oct 20, 2011 at 11:49:40PM -0700, Alexander Graf wrote: On 20.10.2011, at 22:06, David Gibson wrote: On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: On 20.10.2011, at 17:41, David Gibson da...@gibson.dropbear.id.au

Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

2011-10-24 Thread Alon Levy
On Mon, Oct 24, 2011 at 01:45:16PM -0200, Luiz Capitulino wrote: On Mon, 24 Oct 2011 17:13:14 +0200 Gerd Hoffmann kra...@redhat.com wrote: On 10/24/11 14:02, Alon Levy wrote: Make screen_dump monitor command an async command to allow next for qxl to implement it as a initiating call to

Re: [Qemu-devel] [PATCH 5/5] qxl: support async monitor screen dump

2011-10-24 Thread Alon Levy
On Mon, Oct 24, 2011 at 05:29:47PM +0200, Gerd Hoffmann wrote: On 10/24/11 14:02, Alon Levy wrote: Split qxl_spice_update_area_complete from qxl_render_update, use SPICE_INTERFACE_QXL_MINOR 2 introduced spice_qxl_update_area_dirty_async to retrive the dirty rectangles asyncronously (the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-24 Thread Alexander Graf
On 24.10.2011, at 10:25, Alexander Graf wrote: On 23.10.2011, at 22:29, David Gibson wrote: On Thu, Oct 20, 2011 at 11:49:40PM -0700, Alexander Graf wrote: On 20.10.2011, at 22:06, David Gibson wrote: On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: On 20.10.2011, at

  1   2   >